Commit Graph

2315 Commits

Author SHA1 Message Date
Beka Westberg
e6e63f456b Fixed bubble dispose (#3430)
* Fixed bubble dispose.
2019-11-12 10:15:16 -08:00
Beka Westberg
dad8738e75 Cleaned up unbindEvent_ calls (#3429)
* Cleaned up unbindEvent_ calls.
2019-11-12 10:14:31 -08:00
Beka Westberg
8747d5e6b5 Fixed comment event listener disposal. (#3427)
* Fixed listener disposal for comment icons.

* Fixed listener disposal for bubbles.
2019-11-11 17:02:17 -08:00
alschmiedt
40bdfac017 Fix setting focus for workspace (#3425)
* Fix setting focus for workspace
2019-11-11 16:44:58 -08:00
Rachel Fenichel
3076874b2b Merge pull request #3426 from rachel-fenichel/highlight_for_replacement
Move highlightForReplacement into the path object as well.
2019-11-11 16:32:49 -08:00
Sam El-Husseini
95f2b232b9 Field constants (#3423)
* Move field text sizing constants to renderer constants
2019-11-11 16:13:50 -08:00
Rachel Fenichel
23635598ec Update i_path_object.js 2019-11-11 15:44:11 -08:00
Rachel Fenichel
067fbb4488 Move highlightForReplacement into the path object as well. 2019-11-11 15:17:26 -08:00
Beka Westberg
8625a96496 Fixed getRootBlock error. 2019-11-09 07:27:58 -08:00
Rachel Fenichel
611c8b81fe Only log about a missing event group if we actually did something 2019-11-08 15:14:14 -08:00
alschmiedt
b7b262efd5 Action update (#3389)
Make it easier for users to create new shortcuts
2019-11-08 13:51:22 -08:00
Sam El-Husseini
36cc9a2e89 Zelos constants (#3419) 2019-11-08 10:59:10 -08:00
Sam El-Husseini
fdc50f2cd0 Add the theme name to the injection div (#3413)
* Set the theme name as a class on the injection div.
2019-11-07 15:19:58 -08:00
Sam El-Husseini
ee09aafd57 [zelos] Add input outlines on the path object. (#3410)
* Add input outlines on the path object.
2019-11-07 15:15:49 -08:00
Rachel Fenichel
a038bfde94 Merge pull request #3395 from BeksOmega/fixes/EqualsDynamicChecks
Fixed logic_compare type checks for disposed blocks
2019-11-07 15:10:47 -08:00
Rachel Fenichel
48a2f823e4 Merge pull request #3409 from rachel-fenichel/remove_constants
Delete two leftover constants in block_svg.
2019-11-06 16:37:16 -08:00
Rachel Fenichel
04ddb90680 Delete two leftover constants in block_svg. 2019-11-06 14:02:13 -08:00
Sam El-Husseini
d49b3400e6 Add zelos selection highlight. (#3390)
* zelos selection highlight
2019-11-06 13:47:30 -08:00
Rachel Fenichel
c6061ef0e6 Merge pull request #3405 from rachel-fenichel/path_obj_set_class
Move lots of update style functions from block_svg to path_object
2019-11-06 12:38:02 -08:00
Rachel Fenichel
bfff91b673 Update geras and add underscore to setClass_ 2019-11-06 11:47:33 -08:00
alschmiedt
5824615666 Add flag to navigate to all fields (#3404) 2019-11-05 19:03:16 -08:00
Rachel Fenichel
e71366259c Move lots of update style functions from block_svg to path_object 2019-11-05 17:15:26 -08:00
Sam El-Husseini
337cb9c486 Fix path_object inheritance (#3403)
* Fix path_object inheritance, add zelos path_object
2019-11-05 16:36:30 -08:00
Sam El-Husseini
30343c8cf6 Move the theme manager into WorkspaceSvg (#3400) 2019-11-05 10:44:51 -08:00
Sam El-Husseini
43224afbf7 Move parseBlockColour into Blockly.utils (#3399)
* Move parseBlockColour into utils and add missing require.
2019-11-04 22:39:18 -08:00
Beka Westberg
1ce97d1c50 Added checking if the block is disposed before trying to reconnect in logic_compare block. 2019-11-04 14:41:45 -08:00
Rachel Fenichel
88a317899b Merge pull request #3388 from rachel-fenichel/defs
Move filters and patterns into constants
2019-11-01 15:57:05 -07:00
Rachel Fenichel
13e4d671c3 Moved setHighlighted and setDisabled into the path object. 2019-11-01 14:28:51 -07:00
Rachel Fenichel
46f323971a Move filter and pattern creation from inject into constants. 2019-11-01 13:32:17 -07:00
Sam El-Husseini
0aea33d8a6 Make theme validate style method work with advanced compilation (#3384) 2019-11-01 12:21:05 -07:00
Neil Fraser
22c1eba546 Make warnings an optional module. 2019-11-01 11:52:12 -07:00
Sam El-Husseini
0f659b25fa Support workspace theme option as JSON (#3379)
* Allow passing in a theme as JSON
2019-10-31 15:49:48 -07:00
Sam El-Husseini
93755fef53 Treat compiler warnings as errors and run on travis (#3378)
* Enable compiler warnings as errors and run on travis
2019-10-31 15:49:28 -07:00
Neil Fraser
123f436e04 Add parens around inline assignments (#3381) 2019-10-31 15:17:35 -07:00
alschmiedt
eece280d92 Fix colour (#3374) 2019-10-31 09:04:10 -07:00
Rachel Fenichel
207e0ebe7b Add tests and better validation for block styles 2019-10-30 17:24:03 -07:00
Rachel Fenichel
5634ff5de0 Remove extra annotation 2019-10-30 16:07:41 -07:00
Rachel Fenichel
46fad66ab1 Review feedback. 2019-10-30 15:58:53 -07:00
Rachel Fenichel
e91304ede1 Fix bad reference 2019-10-30 14:47:23 -07:00
Rachel Fenichel
5ef08fc0d4 Switch to using the style object in the path object. 2019-10-30 14:47:23 -07:00
Rachel Fenichel
ca1e49bf8e Fields now go through blockSvg for colours. 2019-10-30 14:43:42 -07:00
Rachel Fenichel
f4bbeb0688 Fix bad function definition. 2019-10-30 14:42:13 -07:00
Rachel Fenichel
7e84dcd3c4 Remove colourSecondary/tertiary from block. 2019-10-30 14:42:13 -07:00
Rachel Fenichel
ecef3467fd Colourer/path_object cleanup 2019-10-30 14:42:13 -07:00
Rachel Fenichel
6f520335ea Cleanup of colouring code, and move it into path_object. 2019-10-30 14:42:13 -07:00
Rachel Fenichel
85c4db5a10 First pass at colourers 2019-10-30 14:42:13 -07:00
Sam El-Husseini
6367d5f27a Fix RTL bubble drag (#3356) 2019-10-30 14:15:54 -07:00
Sam El-Husseini
eb50bb33e7 Use a cursor to tab between tab navigable fields. (#3365)
* Use a cursor to tab between tab navigable fields.
2019-10-30 12:41:04 -07:00
Sam El-Husseini
cd412b678e Remove firefox workaround that is no longer needed (#3349) 2019-10-30 11:44:05 -07:00
Sam El-Husseini
f79740c087 Use zero height / width for compute canvas (#3369)
* Make the blockly compute canvas have no height or width
2019-10-30 10:59:24 -07:00