Commit Graph

20 Commits

Author SHA1 Message Date
Rachel Fenichel
db9a9f5182 Move code from the variable to the variable map. Fixes #1512. 2017-12-15 15:31:41 -08:00
Rachel Fenichel
66975c8f94 Rebase 2017-12-15 13:44:27 -08:00
Rachel Fenichel
f0b7190603 Clean up TODOs and move potential variable map to the flyout workspace 2017-12-13 11:50:08 -08:00
Rachel Fenichel
5047b00e27 Fix missing events for variable creation 2017-12-13 11:50:08 -08:00
Rachel Fenichel
1ce46ab88b Move getOrCreateVariable to variables.js 2017-12-13 11:50:07 -08:00
Rachel Fenichel
3ae7ac1cd4 Make unique variable names in the flyout 2017-12-13 11:50:07 -08:00
Karishma Chadha
143d95222c Fixing type annotation. 2017-11-22 15:22:34 -05:00
Karishma Chadha
aae1b1bb74 Addressing PR comment. Moving functionality to get newly added variables into a helper function. 2017-11-22 14:51:11 -05:00
Karishma Chadha
ee142e92bb Fixing comment style. 2017-11-22 13:43:25 -05:00
Karishma Chadha
c950225897 Minor refactoring 2017-11-22 13:37:30 -05:00
Karishma Chadha
71205de2ef Target workspace is the one that carries the variables we want. VarCreate gets fired when a block with a new default variable is dragged out into the workspace. 2017-11-22 13:27:29 -05:00
Karishma Chadha
07d6624625 Fixing bug where VarCreate event does not fire when adding a block with pre-existing variables from the flyout into the workspace. 2017-11-22 12:50:00 -05:00
Neil Fraser
7216c060bd Terminology: "background button" -> "mat"
Originally flyouts had ‘blocks’ and rectangular hidden ’buttons’
underneath the blocks.  When UI buttons were added to flyounts, there
was a terminology collision.  This change renames the original
background ‘buttons’ to ‘mats’.  As in placemats or door mats.
2017-11-07 14:23:41 -08:00
Sam El-Husseini
9c0de1ae8d Avoid IE and Edge re-rendering (#1326)
* Fix wrong width of field_dropdown with an image on Edge / IE

* Avoid re-rendering on IE and Edge by using getBBox().width to compute the text width on those browsers
2017-09-19 15:04:25 -07:00
Sam El-Husseini
6e3a2b7218 Fix flyout labels causing flyout scrolling issues (#1301) 2017-09-05 10:26:58 -07:00
marisaleung
5f21a43caf Fix type tags and todo placement. 2017-08-03 12:35:14 -07:00
Rachel Fenichel
d2f7d5a71a Use the same math for dragging blocks out of horizontal and vertical flyouts. (#1215)
* Use the same math for dragging blocks out of horizontal and vertical flyouts.

* Update flyout_base.js
2017-07-19 11:30:08 -07:00
marisaleung
fba60bf7a5 Fix flyout dropdown bug. 2017-06-26 10:41:17 -07:00
marisaleung
7c71b9e7fc Fix checkbox delete bug. 2017-06-20 15:13:10 -07:00
Rachel Fenichel
2d532225d3 Split flyout into flyout_base, flyout_horizontal, and flyou_vertical
* Rename flyout to flyout_base

* flyout_base minus horizontal and vertical code

* Add flyout_vertical and flyout_horizontal

* review fixes + toolbox and workspace use

* Fix hat block case

* rebuild uncompressed

* Fix travis problem

* Fix build problem
2017-06-08 13:36:11 -07:00