Commit Graph

2328 Commits

Author SHA1 Message Date
Rachel Fenichel 9d71c972cb Respond to review comments in variable_map 2017-12-12 17:19:41 -08:00
Rachel Fenichel 9f4b52a834 Clean up TODOs and move potential variable map to the flyout workspace 2017-12-12 17:19:41 -08:00
Rachel Fenichel f0b4b4402c Avoid spurious rename event 2017-12-12 17:19:41 -08:00
Rachel Fenichel 676253ec32 Fix missing events for variable creation 2017-12-12 17:19:41 -08:00
Rachel Fenichel 1491950394 Fix checkmarks when the variable dropdown is open. 2017-12-12 17:19:41 -08:00
Rachel Fenichel 464b2769a8 Tests 2017-12-12 17:19:41 -08:00
Rachel Fenichel e7e66fb7b7 Tests 2017-12-12 17:19:41 -08:00
Rachel Fenichel 96e814deff Fix events for variable renaming 2017-12-12 17:19:41 -08:00
Rachel Fenichel 3b91de7bb4 Remove ws.updateVariableStore and tests, and ws.getVariableUses 2017-12-12 17:19:41 -08:00
Rachel Fenichel 72e4be9b4e Get rid of workspace.deleteVariable 2017-12-12 17:19:41 -08:00
Rachel Fenichel 9e0d908133 Move getOrCreateVariable to variables.js 2017-12-12 17:19:41 -08:00
Rachel Fenichel f7438d9c95 Fix default variable name 2017-12-12 17:19:41 -08:00
Rachel Fenichel 7df7750b19 Make unique variable names in the flyout 2017-12-12 17:19:41 -08:00
Rachel Fenichel 2bb66aa9aa All tests pass 2017-12-12 17:19:41 -08:00
Rachel Fenichel f3f3f34fc2 All but XML tests now pass 2017-12-12 17:19:41 -08:00
Rachel Fenichel a7b98f7479 Move code from renameVariableInternal to renameVariableById 2017-12-12 17:19:41 -08:00
Rachel Fenichel 62737bc233 Update tests in workspace_test. Get rid of renameVariable 2017-12-12 17:19:41 -08:00
Rachel Fenichel 5145ad6918 Fix variable_map_test and variable_model_test 2017-12-12 17:19:41 -08:00
Rachel Fenichel c541a544c6 Fix tests in field_variable_test.js 2017-12-12 17:19:41 -08:00
Rachel Fenichel 0516310f66 Delete by id 2017-12-12 17:19:41 -08:00
Rachel Fenichel 08e065a75b Fix renaming 2017-12-12 17:19:41 -08:00
Rachel Fenichel 745bed5ac3 Can now create a variable with the button in the flyout; drag a block with a variable out of the flyout; handle default variable names; and import and export variables 2017-12-12 17:19:41 -08:00
Rachel Fenichel 731d2735c0 Add TODOs and fix return type 2017-12-12 17:19:41 -08:00
Rachel Fenichel c825e60813 Allow variables of different types to share the same name. 2017-12-12 17:19:41 -08:00
Rachel Fenichel 0cb5dfc437 Merge pull request #1492 from Kenny2github/patch-1
Remove "fake some drags!"
2017-12-11 17:12:11 -08:00
Rachel Fenichel 4b3cac71e1 Merge pull request #1495 from rachel-fenichel/feature/variables_by_id
Act on variables by ID, not name + type
2017-12-11 15:47:37 -08:00
duzc2dtw@gmail.com 26ea42c264 #1376 2017-12-09 20:41:43 +08:00
Tianwei Du 0ce3963648 Merge pull request #2 from google/develop
Develop
2017-12-09 20:30:39 +08:00
RoboErikG 0142aa0e94 Don't require flyouts to run Blockly (#1502)
* Don't require flyouts to run Blockly

There was a bug with Dynamic Variables that made them required for Blockly
to run. This adds checks so that the flyouts only get registered if they're
included. Also does a rebuild of core to pick up the fix.

* Also fix dependencies so dynamic vars don't get stripped
2017-12-08 14:18:09 -08:00
Tianwei Du 383f1d9bac Develop (#1501)
Adds missing requires in core/extensions
2017-12-08 10:49:35 -08:00
RoboErikG a83a625e3b Rebuild core and fix indents in field_variable.js (#1500)
After the addition of dynamic variables blockly_uncompressed needed
to be rebuilt for the playground. Also fixes some leftover missing
indents.
2017-12-08 10:46:20 -08:00
duzc2dtw@gmail.com 0ee877b4bf fix indent 2017-12-09 02:09:58 +08:00
duzc2dtw@gmail.com f770b29491 fix #1173 2017-12-09 02:03:28 +08:00
Tianwei Du 63143d6eff Merge pull request #1 from google/develop
Develop
2017-12-09 02:01:36 +08:00
Tianwei Du 492462e1d4 Develop (#1481)
* variables_dynamic

* make test , and i18n

* Issue #1470

* Blockly.Constants.VariablesDynamic.CUSTOM_CONTEXT_MENU_VARIABLE_MUTATION
to make sure setCheck before event trigger

* Update built files from develop.

* fix copyright ,quotes , comments ,  and optimize some flow.

* quotes,change UI , change category custom name

* single setter , remove mutator , colour typo , typed variables create button message

* undo the indent edits.
2017-12-08 08:53:24 -08:00
duzc2dtw@gmail.com 8022d7e24b undo the indent edits. 2017-12-08 11:59:45 +08:00
Rachel Fenichel 77a47aee94 Fix html escaping and flyouts opening 2017-12-07 16:08:00 -08:00
Rachel Fenichel 404373e53a Merge pull request #1496 from rachel-fenichel/bugfix/1467
Fix #1467
2017-12-07 15:06:37 -08:00
Rachel Fenichel 73253ea64f Respond to review comments in variable_map 2017-12-07 13:12:20 -08:00
Rachel Fenichel cc6eeb8c68 Clean up TODOs and move potential variable map to the flyout workspace 2017-12-07 10:43:12 -08:00
duzc2dtw@gmail.com b642317b0f single setter , remove mutator , colour typo , typed variables create button message 2017-12-07 15:40:28 +08:00
Rachel Fenichel 7ef19b6851 Fix #1467 2017-12-06 17:00:22 -08:00
Rachel Fenichel 3cecc0f604 Avoid spurious rename event 2017-12-06 16:57:46 -08:00
Rachel Fenichel 0909af76e5 Fix missing events for variable creation 2017-12-06 16:41:17 -08:00
Rachel Fenichel abc83b12d7 Fix checkmarks when the variable dropdown is open. 2017-12-06 16:07:21 -08:00
Rachel Fenichel 637a909de7 Tests 2017-12-06 15:56:18 -08:00
Rachel Fenichel 38d134aa4f Tests 2017-12-06 15:49:20 -08:00
Rachel Fenichel 1506a36b58 Fix events for variable renaming 2017-12-06 14:41:56 -08:00
duzc2dtw@gmail.com a42c1bca74 quotes,change UI , change category custom name 2017-12-06 16:24:34 +08:00
Rachel Fenichel 90e79c6ba9 Remove ws.updateVariableStore and tests, and ws.getVariableUses 2017-12-05 13:52:01 -08:00