Commit Graph

1699 Commits

Author SHA1 Message Date
Neil Fraser
e06d4e648c Rename BlockAnimation > blockAnimation
Issue 2102.  And do a full recompile due to changed the dependency name.
2019-07-08 17:31:38 -07:00
Neil Fraser
dd6cb19f5d Backward compatibility check for ‘variableType’ 2019-07-08 13:29:43 -07:00
Neil Fraser
52b6ce18a5 Fix unit tests 2019-07-08 13:29:43 -07:00
Neil Fraser
20d4a27f0a Add namespacing to XML
Fixes #1978.
2019-07-08 13:29:43 -07:00
Neil Fraser
74be35e23d Rename Blockly.Xml.utils to Blockly.utils.xml 2019-07-08 13:29:43 -07:00
alschmiedt
7c57432faf Merge pull request #2611 from alschmiedt/shadow_fixes
Adds fill to svg dark path
2019-07-03 16:08:42 -07:00
alschmiedt
a7ec185c69 Adds fill to svg dark path 2019-07-03 14:10:56 -07:00
alschmiedt
c45be91f7a Fixes spacing problem in procedure name 2019-07-03 11:40:55 -07:00
alschmiedt
11d368e415 Merge pull request #2607 from alschmiedt/input_number
Adds type to FieldNumber editor
2019-07-02 14:10:34 -07:00
alschmiedt
45387faab7 Adds type to FieldNumber editor 2019-07-02 10:53:45 -07:00
alschmiedt
8ef9be2fdf Fixes theme error for headless workspaces 2019-07-01 10:38:28 -07:00
Rachel Fenichel
a45b0b1d85 Merge pull request #2597 from rachel-fenichel/svg_utils
Create svg_utils file
2019-06-28 16:55:39 -07:00
Rachel Fenichel
f2be890f9f More cleanup 2019-06-28 16:55:04 -07:00
Neil Fraser
d23dc0ae55 Minor cleanup from #2581 2019-06-28 16:47:12 -07:00
Neil Fraser
712576a5b1 Fix IE not unhighlighting
This is a rework of PR #2580.
2019-06-28 16:47:12 -07:00
Rachel Fenichel
2aa1bed83f Add some spaces 2019-06-28 16:36:59 -07:00
Rachel Fenichel
f1e05b1e68 Lowercase l in comments 2019-06-28 15:09:59 -07:00
Rachel Fenichel
1f82f9d9e2 Create svg_utils file 2019-06-28 15:00:09 -07:00
alschmiedt
a8dc8359c5 Merge pull request #2587 from BeksOmega/fixes/ImagesAndTextDropdown
Fixed Rendering of Images & Text Dropdown
2019-06-24 17:19:58 -07:00
alschmiedt
55fc506782 Merge pull request #2577 from BeksOmega/fixes/doValueInvalid
Added Sending the Bad Value to doValueInvalid
2019-06-24 16:09:20 -07:00
Beka Westberg
5a4cc7ae12 Removed textToDom Needing <xml> Documents (#2585)
* Removed textToDom needing <xml> documents.

* Fixed jsdoc.

* Followon changes resulting from lack of XML tag.

* Fix Mocha test.
2019-06-24 15:50:06 -07:00
Beka Westberg
3227223c82 Renamed _newValue param to _invalidValue. 2019-06-24 14:58:33 -07:00
Beka Westberg
27a6593d27 Removed Class Option Check from Text Input fromJson (#2588)
* Removed class option check from text input fromJson, as text input fields don't accept a class.

* Fixed syntax error.
2019-06-24 13:34:28 -07:00
Beka Westberg
b98eef2ae2 Fixed rendering of images & text dropdown. 2019-06-24 10:20:26 -07:00
amber-cd
492d0719d6 Pull Request: Split showContextMenu_ (#2581)
* Split showContextMenu_

Split showContextMenu_ into generateContextMenu_ and showContextMenu_. This allows for custom Blockly forks to easily extend the context menu options available on all blocks by just doing something like

```
var oldGenerateContextMenu_ = Blockly.BlockSvg.prototype.generateContextMenu_;
Blockly.BlockSvg.prototype.generateContextMenu_ = function() {
  var menuOptions = Blockly.BlockSvg.prototype.generateContextMenu_() || [];
  // Push other options into menuOptions
  return menuOptions;
}
```

Rather than having to modify the core code in such a way as to cause unnecessary maintenance overhead when upgrading Blockly versions.

* Forgot the docblock, sorry

* Oops, missed a few ESLint things

* Update block_svg.js

Updated to be protected rather than private.
2019-06-21 15:14:11 -07:00
Beka Westberg
69e2eae218 Fixed setTooltip not working before appendField(). (#2578) 2019-06-21 13:36:25 -07:00
Beka Westberg
4a0d5f5df0 Added sending the bad value to doValueInvalid. 2019-06-14 12:00:10 -07:00
Neil Fraser
9f6c1c316a Refactor workspace.connectionDBList
It seems wrong that Blockly.ConnectionDB.init reaches in to create a property on workspace.
It seems wrong that this database isn’t disposed of when the workspace is.
It seems unnecessary that disposed connections need to drop their reference *to* the workspace’s database since the connection object is going away anyway, and the databases aren’t.
2019-06-12 13:15:39 -07:00
Neil Fraser
f1c73e2244 Rename helper function 2019-06-12 10:59:33 -07:00
Neil Fraser
b8cbd9e7df Resolve 13 warnings
Reduce count from 632 to 619.
Eliminate copy-paste code duplication in Field.prototype.setValue
2019-06-12 10:59:33 -07:00
Beka Westberg
bf6d621c63 Added colour and date editor auto close on selection. 2019-06-11 16:22:24 -07:00
Beka Westberg
efdfec6d8a Fixed last rebase error. 2019-06-11 14:29:19 -07:00
Beka Westberg
6f69b85639 Removed unnecessary todo's. 2019-06-11 14:24:48 -07:00
Beka Westberg
4b0397de17 Cleaned up utils renamings. Readded widget div hide in field angle. 2019-06-11 13:48:01 -07:00
Beka Westberg
392119680e Fixed misc PR comments. 2019-06-11 13:32:10 -07:00
Beka Westberg
2af17fd782 Removed obsolete widgetDiv check in tooltip code. 2019-06-11 13:32:10 -07:00
Beka Westberg
6d47853370 Fixed workspace scroll not properly hiding floating elements. 2019-06-11 13:32:10 -07:00
Beka Westberg
8ee266ea65 Fixed dropdowndiv not animating correctly after hideChaff. Extracted dual functionality of positionInternal_ and moved it to hideWithoutAnimation. 2019-06-11 13:32:10 -07:00
Beka Westberg
7af5c5147a Fixed dropdown div not fading in correctly. 2019-06-11 13:32:10 -07:00
Beka Westberg
153817eaee Removed angle field WidgetDiv.hide call. 2019-06-11 13:32:10 -07:00
Beka Westberg
81035c3bcb Fixed unit tests. 2019-06-11 13:32:10 -07:00
Beka Westberg
303115953e Moved to #2125 disposal. Cleaned up some doc. 2019-06-11 13:32:09 -07:00
Beka Westberg
217206911a Fixed some formatting in text input. 2019-06-11 13:30:50 -07:00
Beka Westberg
0122f36450 Fixed field disposal, and reorganized editor creation. 2019-06-11 13:30:50 -07:00
Rachel Fenichel
d54fa2e4f9 Merge pull request #2559 from google/fraser-regexp
Fix regular expressions.
2019-06-11 12:25:38 -07:00
Rachel Fenichel
8ce82d5142 Merge pull request #2558 from BeksOmega/fixes/ReadOnlyFields
Fixed Fields Still Being Editable on Non-Editable Blocks
2019-06-11 11:09:26 -07:00
Neil Fraser
1535f35ff2 Remove unused CSS image fetch
This default Closure image was always being overridden and was never fetched.  But it takes some research to determine that this is not in effect a potential monitoring point.
2019-06-10 13:20:33 -07:00
Neil Fraser
6134337568 Reduce memory footprint
Blockly.Css.CONTENT isn’t needed after its first use.
There also is no longer a need to store a reference to the stylesheet, just a boolean.
2019-06-10 11:40:41 -07:00
Neil Fraser
aca1a43ec8 Fix regular expressions.
1) Simplifications.
2) Enable toolbox category colours to be specified using the full range of CSS formats (not just hue or #rrggbb).
3) Fix bug where `Blockly.utils.checkMessageReferences('%{BKY_today}  %{BKY_xxx}')` returns true.
2019-06-10 11:03:22 -07:00
Beka Westberg
e0909b4ef8 Fixed fields still being editable on non-editable blocks. 2019-06-10 10:42:58 -07:00