Commit Graph

2320 Commits

Author SHA1 Message Date
Rachel Fenichel
fced496d28 Lua generator tests pass with new variables 2017-12-20 15:23:05 -08:00
Rachel Fenichel
3d0567fe46 JS and Dart generator tests pass 2017-12-20 15:14:37 -08:00
Rachel Fenichel
04fa9faadd Merge pull request #1520 from rachel-fenichel/feature/variables_headless
Fix headless
2017-12-19 16:53:51 -08:00
Rachel Fenichel
d69519bdab Fix headless 2017-12-19 16:10:07 -08:00
Rachel Fenichel
c113d5c785 Merge pull request #1519 from rachel-fenichel/feature/variables_headless
Create variables when blocks are created directly (not from XML)
2017-12-19 15:46:55 -08:00
Rachel Fenichel
4cd0b36944 Fix event ordering for variables created from XML implicitly 2017-12-19 14:25:52 -08:00
Rachel Fenichel
6218750207 Fix events for variable fields on new blocks; fix tests 2017-12-19 11:28:23 -08:00
Rachel Fenichel
3e56e6f8f2 Merge pull request #1518 from rachel-fenichel/feature/move_variable_map
Move all variable functionality into the variable map.
2017-12-15 16:08:50 -08:00
Rachel Fenichel
db9a9f5182 Move code from the variable to the variable map. Fixes #1512. 2017-12-15 15:31:41 -08:00
Rachel Fenichel
792ada63dc Merge branch 'variables_by_id' of https://github.com/google/blockly into variables_by_id 2017-12-15 14:56:32 -08:00
Rachel Fenichel
9593a90cc0 Merge pull request #1517 from rachel-fenichel/rebase_variables_by_id
Merge develop into variables_by_id
2017-12-15 14:33:32 -08:00
Rachel Fenichel
df1d5ba525 fix tests 2017-12-15 14:07:17 -08:00
Rachel Fenichel
66975c8f94 Rebase 2017-12-15 13:44:27 -08:00
Rachel Fenichel
a75ab878af Fix html escaping and flyouts opening 2017-12-13 11:50:08 -08:00
Rachel Fenichel
e77b498504 Respond to review comments in variable_map 2017-12-13 11:50:08 -08:00
Rachel Fenichel
f0b7190603 Clean up TODOs and move potential variable map to the flyout workspace 2017-12-13 11:50:08 -08:00
Rachel Fenichel
b60e70497a Avoid spurious rename event 2017-12-13 11:50:08 -08:00
Rachel Fenichel
5047b00e27 Fix missing events for variable creation 2017-12-13 11:50:08 -08:00
Rachel Fenichel
7e411b5428 Fix checkmarks when the variable dropdown is open. 2017-12-13 11:50:08 -08:00
Rachel Fenichel
be4054b593 Tests 2017-12-13 11:50:08 -08:00
Rachel Fenichel
399f1a5c11 Tests 2017-12-13 11:50:08 -08:00
Rachel Fenichel
279cf83b72 Fix events for variable renaming 2017-12-13 11:50:08 -08:00
Rachel Fenichel
24672bcbb2 Remove ws.updateVariableStore and tests, and ws.getVariableUses 2017-12-13 11:50:08 -08:00
Rachel Fenichel
61db23c78a Get rid of workspace.deleteVariable 2017-12-13 11:50:08 -08:00
Rachel Fenichel
1ce46ab88b Move getOrCreateVariable to variables.js 2017-12-13 11:50:07 -08:00
Rachel Fenichel
f37386d2bf Fix default variable name 2017-12-13 11:50:07 -08:00
Rachel Fenichel
3ae7ac1cd4 Make unique variable names in the flyout 2017-12-13 11:50:07 -08:00
Rachel Fenichel
523a10413b All tests pass 2017-12-13 11:50:07 -08:00
Rachel Fenichel
19939dc16a All but XML tests now pass 2017-12-13 11:50:07 -08:00
Rachel Fenichel
4d76f2948c Move code from renameVariableInternal to renameVariableById 2017-12-13 11:50:07 -08:00
Rachel Fenichel
3728cfed45 Update tests in workspace_test. Get rid of renameVariable 2017-12-13 11:50:07 -08:00
Rachel Fenichel
6974208fa3 Fix variable_map_test and variable_model_test 2017-12-13 11:50:07 -08:00
Rachel Fenichel
c55b6afc6f Fix tests in field_variable_test.js 2017-12-13 11:50:07 -08:00
Rachel Fenichel
012ba022c8 Delete by id 2017-12-13 11:50:07 -08:00
Rachel Fenichel
47457d1683 Fix renaming 2017-12-13 11:50:07 -08:00
Rachel Fenichel
c157412fc5 Can now create a variable with the button in the flyout; drag a block with a variable out of the flyout; handle default variable names; and import and export variables 2017-12-13 11:50:07 -08:00
Rachel Fenichel
24462fbc91 Add TODOs and fix return type 2017-12-13 11:50:07 -08:00
Rachel Fenichel
779be46a92 Allow variables of different types to share the same name. 2017-12-13 11:50:07 -08:00
Rachel Fenichel
733a629f06 Merge pull request #1504 from areyeshot/develop
fix #1376
2017-12-13 09:41:40 -08:00
duzc2dtw@gmail.com
da429688f8 space between if and ( 2017-12-13 17:02:34 +08:00
Neil Fraser
bc1a5baa48 Fixes to Generator tests (#1510)
* Remove unneeded report variable from generator tests.
* Fix missing message parameter in unittest_fail.  This was a compile error in Dart.
* Fix indentation in PHP.
* Equality helper function not needed in PHP.
2017-12-12 17:38:38 -08:00
Rachel Fenichel
05351569c5 Fix html escaping and flyouts opening 2017-12-12 17:19:41 -08:00
Rachel Fenichel
9d71c972cb Respond to review comments in variable_map 2017-12-12 17:19:41 -08:00
Rachel Fenichel
9f4b52a834 Clean up TODOs and move potential variable map to the flyout workspace 2017-12-12 17:19:41 -08:00
Rachel Fenichel
f0b4b4402c Avoid spurious rename event 2017-12-12 17:19:41 -08:00
Rachel Fenichel
676253ec32 Fix missing events for variable creation 2017-12-12 17:19:41 -08:00
Rachel Fenichel
1491950394 Fix checkmarks when the variable dropdown is open. 2017-12-12 17:19:41 -08:00
Rachel Fenichel
464b2769a8 Tests 2017-12-12 17:19:41 -08:00
Rachel Fenichel
e7e66fb7b7 Tests 2017-12-12 17:19:41 -08:00
Rachel Fenichel
96e814deff Fix events for variable renaming 2017-12-12 17:19:41 -08:00