picklesrus
fd7d8b1ac8
Fix #967 by overriding the updateWidth method in FieldImage blocks to be a no-op. FieldImage fields should not change size after the width is set in init. The updateWidth and, therefore, getCachedWidth is now being called by BlockSvg renderFields_ (see commit d55d9cbd9f). IIUC, updateWidth/getCachedWidth was only called from render before which is overridden in FieldImage to be a no-op already. ( #979 )
2017-03-17 16:15:40 -07:00
Rachel Fenichel
036f364e57
Merge pull request #978 from rachel-fenichel/feature/developer_background
...
Set background color to lilac if opening the playground from file:
2017-03-13 14:55:43 -07:00
Rachel Fenichel
a6a70a647c
set background color to lilac if opening the playground from file:
2017-03-13 14:37:27 -07:00
picklesrus
847d83e4af
Another attempt to fix #904 to keep the page from jumping to the focused workspace in IE 11 ( #974 )
2017-03-10 14:58:09 -08:00
picklesrus
9b98573327
Cross browser friendly fix for #904 . This calls blur and focus from … ( #972 )
...
* Cross browser friendly fix for #904 . This calls blur and focus from workspace.markFocused and removes the event listener on focus events. markFocused is called from all of our mouse down handlers, which triggers the focus event leading to an infinite loop of focus. As far as I can tell, there are no uses of the focus handler that actually did anything for us.
2017-03-08 14:27:53 -08:00
Andrew n marshall
6313b202f7
unction to function corrects #962 ( #970 )
2017-03-08 07:47:48 -08:00
picklesrus
63c899e4e1
Potential fix for #888 . Stops checking whether we are mid workspace drag since we do not always get mosue up events when blockly is in an iframe. ( #899 )
2017-03-06 16:19:29 -08:00
picklesrus
ab042d4dd8
Fix bug #904 by explicitly grabbing focus on the workspace svg element. ( #964 )
2017-03-03 16:15:02 -08:00
Rachel Fenichel
aff78ccc45
Merge pull request #963 from rachel-fenichel/bugfix/blocks_object_annotation
...
Annotation fix
2017-03-03 13:53:55 -08:00
Rachel Fenichel
72256a187d
Annotation fixes
2017-03-03 13:22:50 -08:00
Andrew n marshall
6e1ffe09c2
Adding Blockly.Xml.appendDomToWorkspace() ( #962 )
...
This is a copy (with additional comments) of PR #822 (and also #961 ) by @qnoirhomme with unrelated files removed. See #822 for full review.
2017-03-03 08:40:00 -08:00
Rachel Fenichel
ef34ee5433
Merge pull request #959 from rachel-fenichel/cleanup/variable_category_xml
...
Make it easier to read the code that creates the variable category in…
2017-03-02 14:12:51 -08:00
Rachel Fenichel
4b75b6271b
Make it easier to read the code that creates the variable category in the tolbox
2017-03-02 13:55:25 -08:00
Andrew n marshall
27a20b1be2
Extra character in comment. ( #958 from AnmAtAnm/typo)
2017-03-02 09:02:06 -08:00
Andrew n marshall
b5f91dd054
Typo in comment.
2017-03-02 08:34:27 -08:00
Andrew n marshall
16380ab8f6
Merge pull request #956 from AnmAtAnm/msg-urls
...
Update help URL per #937 .
2017-02-28 11:00:15 -08:00
Andrew n marshall
2c349a3152
Update help URL per #937 .
...
Replace URL usages of %28 and %29 with normal parenthesis characters. (They aren't replaced by JavaScript's encodeURIComponent() function, and seem to work just fine without them.)
Added missing semicolon in build.py.
2017-02-28 08:38:37 -08:00
Rachel Fenichel
05312c9bf7
Merge pull request #952 from rachel-fenichel/feature/if_else_update
...
Use mutator extension for controls_if block
2017-02-27 19:56:32 -08:00
Rachel Fenichel
c30928a177
Make some functions private and add tests
2017-02-24 15:51:59 -08:00
Andrew n marshall
c0677100fd
Merge pull request #954 from AnmAtAnm/warn-on-overwrite
...
Adding warning on duplicate JSON block definition.
2017-02-24 15:51:20 -08:00
Andrew n marshall
1bc74819aa
period
2017-02-24 15:47:35 -08:00
Andrew n marshall
a9aabd637f
Adding warning on duplicate JSON block definition.
2017-02-24 15:41:56 -08:00
Rachel Fenichel
aa8e996799
Handle mutations with both mixins and functions
2017-02-23 17:07:06 -08:00
Rachel Fenichel
4b0c32e91f
Add safety checks for mutators and non-mutator extensions
2017-02-23 15:55:13 -08:00
Andrew n marshall
89c2bf66ca
Merge pull request #951 from AnmAtAnm/fix950-blockfactory
...
Fix #950 : BlockFactory typo and copypasta
2017-02-23 10:22:46 -08:00
Andrew n marshall
af6d4dcfc6
Merge pull request #948 from AnmAtAnm/fix946
...
Fix #946 . Don't check for presence of constants.js
2017-02-23 10:22:32 -08:00
Andrew n marshall
2279b55057
Merge pull request #949 from AnmAtAnm/fix-annotations
...
Fix #945 (annotations) and an eslint issue (constant condition)
2017-02-23 10:22:17 -08:00
Andrew n marshall
7e178af49c
Fix #950 : BlockFactory typo and copypasta
2017-02-23 08:53:01 -08:00
Andrew n marshall
3db3cf551f
Fix #945 (annotations) and an eslint issue (constant condition)
2017-02-22 23:15:39 -08:00
Andrew n marshall
c5c32b457f
Fix #946 . Don't check for presence of constants.js
2017-02-22 22:58:39 -08:00
Rachel Fenichel
455432250e
Use mutator extension for controls_if block
2017-02-22 17:05:52 -08:00
Rachel Fenichel
3d08099950
Merge pull request #809 from google/paternity
...
Option for moving one block from stack.
2017-02-22 10:39:11 -08:00
Andrew n marshall
1bd8204922
Make variable add set/get block in context menu obey block limits ( #938 from bwinf/develop)
2017-02-16 08:26:13 -08:00
Robert Czechowski
5a7b7b3c5a
Make variable add set/get block in context menu obey block limits
2017-02-16 15:03:50 +01:00
CoryDCode
c3c1f83105
Fixing Enter so it properly propogates to dropdown selection. ( #934 )
...
Fixing FieldSegment so it updates dropdowns when the underlying dropdown changes.
2017-02-15 11:13:32 -08:00
Rachel Fenichel
0a73ae38f9
Merge pull request #933 from K-ran/bugfix/rounding_error
...
Potential bug fix for issue #661
2017-02-15 09:12:23 -08:00
Karan Purohit
4a81623f8d
Code correction from previous commit. Moved style to css.js and set ROUNDING=15;
2017-02-15 14:33:20 +05:30
Andrew n marshall
4b6f98166c
Merge pull request #935 from AnmAtAnm/clarification
...
Clarification in Blockly.utils.tokenizeInterpolation_
2017-02-14 16:29:08 -08:00
Andrew n marshall
b32136d81f
Clarification update.
...
Unraveling nested ternaries in Blockly.utils.tokenizeInterpolation_()
2017-02-14 15:51:24 -08:00
Andrew n marshall
b0264eb5ea
Internationalize variable name strings ( #930 from AnmAtAnm/variable_i18n)
...
Also, .utils.replaceMessageReferences(..) now gracefully returns non-string arguments.
2017-02-14 11:58:02 -08:00
Andrew n marshall
afd1fdeb15
.utils.replaceMessageReferences(..) now gracefully returns non-string arguments.
2017-02-14 11:00:34 -08:00
Andrew n marshall
750c0300ec
Addressing comments.
2017-02-14 11:00:34 -08:00
Andrew n marshall
dc0d3beba3
Moving FieldImage string dereferencing back into Block.interpolate_() (part of jsonInit()). This sets a clear boundary of where dereferencing should happen.
...
Towards this, I've added message dereferencing for other field types here, as well. I've used a pattern of field-type specific helper functions.
2017-02-14 11:00:34 -08:00
Andrew n marshall
640fb9c733
Dereference string table references when loading variable fields from JSON.
2017-02-14 11:00:34 -08:00
Andrew n marshall
feed5ffc6d
Renamed extension function constant, and moved variables into the mixin.
2017-02-14 09:37:45 -08:00
Andrew n marshall
6919f588f8
extension controls_if => controls_if_mutator.
2017-02-14 09:37:45 -08:00
Karan Purohit
cdef092683
Potential bug fix for issue #661
2017-02-14 23:00:14 +05:30
Andrew n marshall
802c03b4c0
Adding tests for logic_ternary block in a new jsunit test framework.
2017-02-13 16:28:43 -08:00
Andrew n marshall
79becd6b31
Add no-op stub .neighbors() for headless Connection.
2017-02-13 16:28:43 -08:00
Andrew n marshall
2e8d107682
Correcting output of the logic_null block.
2017-02-13 16:28:43 -08:00
