ff34e067f8
Update positionable jsdoc ( #4908 )
2021-06-14 13:14:01 -07:00
1931c31aa6
Update JsDoc for IDragTarget ( #4907 )
2021-06-14 12:19:36 -07:00
34fce2c1cb
Moves toolbox cursor styling out of block_dragger ( #4896 )
2021-06-11 18:02:40 -07:00
5a1533d1b0
Creates getLocationAfterMove in BlockDragger ( #4905 )
...
* Add getLocationAfterMove method to block dragger
* Renames and addresses comments
2021-06-11 17:32:27 -07:00
a17cb7f12e
Adding parameter to dragEnter and dragExit ( #4890 )
...
* introduce IDraggable interface
* Add parameter to drag methods in IDragTarget
* combines bubble/drag methods on IDragTarget and IDeleteArea to take an IDraggable element
2021-06-11 12:58:26 -07:00
fb170b9052
Remove extra space in generator error message.
2021-06-11 12:12:14 -07:00
8aeb78eff3
Revert bubble dragger logic change and helper name change ( #4897 )
...
* Revert accidental change in bubble drag logic
* Revert name change
2021-06-11 11:10:39 -07:00
73b06f14bb
Fix bug in Flyout getClientRect ( #4901 )
2021-06-11 11:10:22 -07:00
566b14e15f
Fixes block dragger after merge ( #4895 )
2021-06-10 16:54:33 -07:00
2005576036
Add onDragOver and wouldDelete_ to DeleteArea ( #4888 )
...
* keep track of state for whether the block or bubble would be deleted for use with drag enter exit
* Check if block and bubble is deletable in IDeleteArea
* Add to jsdoc of IDeleteArea
2021-06-10 16:27:04 -07:00
2c15a0dfb1
Merge pull request #4894 from maribethb/clone-coord
...
Add a clone method to Coordinate
2021-06-10 16:24:41 -07:00
777b3f46d6
use clone
2021-06-10 16:17:12 -07:00
e40093dc23
Add API to IDragTarget to prevent block move ( #4886 )
2021-06-10 16:17:07 -07:00
c4f04a7a7b
Merge branch 'develop' of github.com:google/blockly into clone-coord
2021-06-10 16:15:25 -07:00
f0143b6d6c
Add a clone method to Coordinate
2021-06-10 16:12:48 -07:00
0014ad3257
Add id to component interface ( #4887 )
2021-06-10 16:03:43 -07:00
9eaca6a1e1
Adds necessary methods for scroll-options plugin ( #4893 )
2021-06-10 15:50:42 -07:00
77dddca02e
Fix bug with updating cursor style in draggers ( #4889 )
2021-06-10 10:57:09 -07:00
d2579a7369
Add removeComponent to ComponentManager ( #4884 )
2021-06-09 22:29:33 -07:00
96315ad449
Fix removal of spaces near parens inside strings
...
Extra spaces should only be stripped from the inside of paren tokens. Parens in strings (and other static content) should not be edited.
2021-06-09 22:16:35 -07:00
d2c61d5735
Prevent uncessary add/remove class calls on cursor during drag ( #4885 )
2021-06-09 19:20:47 -07:00
11390341b1
Adding IDragTarget support. ( #4852 )
2021-06-09 13:59:22 -07:00
861a981cb6
Remove extra else clauses
2021-06-09 11:41:42 -07:00
cff7b359f4
Make comments more consistent.
2021-06-09 11:41:42 -07:00
6a6c630f8c
Back out variable change.
2021-06-09 11:41:42 -07:00
76b5517008
Use null-prototype objects for maps
...
A {} has a bunch of names already defined on it (like ‘toString’). When using an object as a map with arbitrary keys, it should not inherit from Object.prototype.
2021-06-09 11:41:42 -07:00
53d8754ee9
Remove row healing for block deletion #4832 ( #4873 )
2021-06-08 17:13:17 -07:00
e3e1089641
ComponentManager API extension ( #4875 )
2021-06-08 14:03:41 -07:00
8e7cb406f9
Handle overriding components in ComponentManager ( #4856 )
2021-06-08 12:28:59 -07:00
e7bf54e82e
Fixes a check in bump into bounds ( #4872 )
2021-06-08 08:17:00 -07:00
5f7fe9096b
Use String() over toLocaleString when possible
...
toLocaleString results in a 4.6% performance penalty when loading the Spaghetti test in Playground.
2021-06-08 06:08:12 -07:00
c5a7b481bc
Code simplifications
2021-06-03 08:23:01 -07:00
e661c92a36
More JSDoc improvements
2021-05-27 21:30:26 -07:00
f64c11d74e
Make JSDoc object nullability more strict.
...
Also make Blockly.utils.deprecation.warn apply to properties.
2021-05-27 21:30:26 -07:00
c9b9144a50
Make explicit that names and IDs are conflated
...
This is potentially dangerous code. And ID could theoretically collide with a name.
2021-05-27 21:30:26 -07:00
43b65d2aa1
Factor out procedure population from generators
...
Also fix bug in Lua generator where variables were not populated in the nameDB (only language with no variable initialization).
2021-05-27 21:30:26 -07:00
9869269ce2
Add procedures to name DB in init
...
This enables the generator for any block to see all variable names and procedure names in the whole program, including those that haven’t generated yet.
2021-05-27 21:30:26 -07:00
17f9209f2f
Add missing extern
2021-05-27 21:30:26 -07:00
ecca5bf274
Use Object.values rather than loop
...
Only for JS, Lua, and PHP. Dart and Python need extra logic to split out import statements.
Also use ‘this’ instead of fully qualified names in generators.
2021-05-27 21:30:26 -07:00
d919b0af21
Update JSDoc from Array.<> to Array<>
...
Same with Object.
2021-05-27 21:30:26 -07:00
b50cb5779f
Set generator’s isInitialized to false in finish
...
Previously isInitialized would remain true after first generation.
Also move common init/finish code to parent class.
2021-05-27 21:30:26 -07:00
5d2c48e1ab
Remove unused Blockly.Generator.NAME_TYPE
2021-05-27 21:30:26 -07:00
a385f3c2a6
Enable extraction of names from name DB.
...
Also gets rid of hacky name_realm contatination.
2021-05-27 21:30:26 -07:00
d519ab8f54
JSDoc improvements
2021-05-27 21:30:26 -07:00
2f2252f588
Rename variableDB_ to nameDB_
...
There is significant confusion in names and comments with regards to variables and procedures. `Blockly.Generator.prototype.variableDB_` is a Blockly.Names database, not a variable map. This rename introduces a getter and setter so deprecated references still work. This commit also fixes some comments which are either outright wrong or misleading regarding variable and procedure names.
2021-05-27 21:30:26 -07:00
5344ad6c21
Add support for IAutoHideable ( #4855 )
2021-05-27 17:01:11 -07:00
1cadbb94bd
Rename PluginManager and related elements ( #4857 )
...
* Rename PluginManager and related elements to use component instead of plugin
* Rename types to capabilities
2021-05-27 16:14:33 -07:00
5ffd43824f
Change lastConnectionInRow to getPlaceForOrphanedOutput - Take 2 ( #4851 )
...
* Change lastConnectionInRow to getPlaceForOrphanedOutput
* PR comments
2021-05-26 09:16:33 -07:00
dd0314bc0b
Normalize comments
2021-05-19 09:57:14 -07:00
4436e2814d
Use localeCompare’s case insensitivity option
...
Variables and procedures now sorted using local rules, not Unicode code points. Verified that ’sensitivity’ survives Closure compiler without quotes.
2021-05-19 09:57:14 -07:00
Monica Kozbial
Maribeth Bottorff
Neil Fraser
alschmiedt
jschanker
Beka Westberg