Lerking/IsItMaintained
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

Add 'help wanted' to the list of excluded labels #35

Closed
limonte wants to merge 1 commits from master into master
pull from: master
merge into: Lerking:master
Conversation 5 Commits 1 Files Changed 1 +10 -17
limonte commented 2017-03-29 16:48:46 +02:00 (Migrated from github.com)
Copy Link

help wanted is the default label for GitHub repositories:

I think that issues with help wanted label should be excluded from the median issue resolution time calculation.

`help wanted` is the default label for GitHub repositories: ![](https://i.imgur.com/fz8n8m6.png) I think that issues with `help wanted` label should be excluded from the median issue resolution time calculation.
mnapoli commented 2017-03-29 21:44:44 +02:00 (Migrated from github.com)
Copy Link

Hi, thanks for the pull request. I'm not sure I see why those issues should be excluded for the calculations? They could still be bugs

Hi, thanks for the pull request. I'm not sure I see why those issues should be excluded for the calculations? They could still be bugs
limonte commented 2017-03-30 13:07:27 +02:00 (Migrated from github.com)
Copy Link

You're totally right, an issue labelled help wanted could be a bug. As well as wip labelled could be a bug and wip is in the list of excluded labels for the calculation.

Sometimes project owner or collaborators submit issues by theirseft and label those issues with help wanted. For example, https://github.com/sweetalert2/sweetalert2/issues/388

IMO it's better to exclude such issues from calculation.

PS. Totally forgot to say THANK YOU for the awesome idea and great implementation!

You're totally right, an issue labelled `help wanted` could be a bug. As well as `wip` labelled could be a bug and `wip` is in the list of excluded labels for the calculation. Sometimes project owner or collaborators submit issues by theirseft and label those issues with `help wanted`. For example, https://github.com/sweetalert2/sweetalert2/issues/388 IMO it's better to exclude such issues from calculation. PS. Totally forgot to say THANK YOU for the awesome idea and great implementation!
mnapoli commented 2017-04-08 11:09:18 +02:00 (Migrated from github.com)
Copy Link

Thanks :)

wip is often used for pull requests that are in progress, so if such PR is 2 month old it's not the "fault" of the package maintainer for not merging it.

help wanted is a bit more fuzzy to me, that a maintainer needs help or not to fix a bug, the bug is still not fixed. Does that make sense for you?

Thanks :) `wip` is often used for pull requests that are in progress, so if such PR is 2 month old it's not the "fault" of the package maintainer for not merging it. `help wanted` is a bit more fuzzy to me, that a maintainer needs help or not to fix a bug, the bug is still not fixed. Does that make sense for you?
limonte commented 2017-04-08 11:16:09 +02:00 (Migrated from github.com)
Copy Link

Yeah, makes sense, I'll close this PR 👍

Anyway, thanks again! I'm using the IsItMaintained badge on my project SweetAlert2 which is trending JS repository now 🚀

Yeah, makes sense, I'll close this PR :+1: Anyway, thanks again! I'm using the IsItMaintained badge on my project [SweetAlert2](https://github.com/sweetalert2/sweetalert2) which is [trending JS repository](https://github.com/trending/js) now :rocket:
mnapoli commented 2017-04-08 11:53:33 +02:00 (Migrated from github.com)
Copy Link

Nice!

Nice!

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Lerking
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Lerking/IsItMaintained#35
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?