Lerking/Phoenix
1
0
Fork 0
mirror of https://github.com/wxWidgets/Phoenix.git synced 2026-01-04 19:10:09 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use key-up on MSW and key-down on others. Only skip for keys not handled by the event handler.

Browse Source
This commit is contained in:
Robin Dunn
2020-10-12 12:24:46 -07:00
parent a2f316edcf
commit 88dd4e2f30
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
wx/lib/checkbox.py
View File

@@ -139,9 +139,13 @@ class GenCheckBox(wx.Control):
# MSW Sometimes does strange things...
self.Bind(wx.EVT_LEFT_DCLICK, self.OnMouseClick)
# We want also to react to keyboard keys, namely the
# space bar that can toggle our checked state.
self.Bind(wx.EVT_KEY_UP, self.OnKeyUp)
# We want also to react to keyboard keys, namely the space bar that can
# toggle our checked state. Whether key-up or key-down is used is based
# on platform.
if 'wxMSW' in wx.PlatformInfo:
self.Bind(wx.EVT_KEY_UP, self.OnKeyEvent)
else:
self.Bind(wx.EVT_KEY_DOWN, self.OnKeyEvent)
# Then, we react to focus event, because we want to draw a small
# dotted rectangle around the text if we have focus.
@@ -400,9 +404,10 @@ class GenCheckBox(wx.Control):
# Refresh ourselves: the bitmap has changed.
self.Refresh()
def OnKeyUp(self, event):
def OnKeyEvent(self, event):
"""
Handles the ``wx.EVT_KEY_UP`` event for :class:`GenCheckBox`.
Handles the ``wx.EVT_KEY_UP`` or ``wx.EVT_KEY_UP`` event (depending on
platform) for :class:`GenCheckBox`.
:param `event`: A `wx.KeyEvent` to be processed.
:type `event`: `wx.KeyEvent`
@@ -411,10 +416,8 @@ class GenCheckBox(wx.Control):
if event.GetKeyCode() == wx.WXK_SPACE:
# The spacebar has been pressed: toggle our state.
self.SendCheckBoxEvent()
else:
event.Skip()
return
event.Skip()
def OnSetFocus(self, event):
"""