19470 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
wxiaoguang	b1cc4bf77f	Validate hex colors when creating/editing labels (#34623) (#34630) ... Backport #34623 --------- Co-authored-by: Kemal Zebari <kemalzebra@gmail.com>	2025-06-07 11:24:28 +03:00
Giteabot	d35161ceb8	bump to alpine 3.22 (#34613) (#34615)	2025-06-05 21:45:30 -04:00
Giteabot	8defca6d39	Fix possible pull request broken when leave the page immediately after clicking the update button (#34509) (#34607) ... Backport #34509 by @lunny If user leaves the page, the context will become cancelled, so that the update process maybe terminal in an unexpected status. This PR haven't resolve the problem totally. It uses a background context to not cancel the update process even if the user leaved the pull request view page. Fix #31779 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2025-06-05 07:15:32 +00:00
Giteabot	fac434da0a	Fix margin issue in markup paragraph rendering (#34599) (#34606) ... Backport #34599 by @silverwind The Fomantic-inherited `p:last-child` rule in base.css interferes with this markdown rendering: ``` 1. a 2. a ``` Before (unequal margin): <img width="143" alt="Screenshot 2025-06-04 at 14 09 07" src="https://github.com/user-attachments/assets/6d6ba5e0-0d84-42e0-a0e4-9e93a59c4d65" /> After (rendering matches GitHub): <img width="181" alt="Screenshot 2025-06-04 at 14 09 14" src="https://github.com/user-attachments/assets/bb81e14e-bc9f-4d52-92d0-f7a17c63070e" /> Co-authored-by: silverwind <me@silverwind.io>	2025-06-05 13:48:07 +08:00
Giteabot	e18eae7129	Fix migration pull request title too long (#34577) (#34604) ... Backport #34577 by @lunny Fix #34294 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2025-06-04 13:36:09 -04:00
Giteabot	c60bc26fd3	Fix issue label delete incorrect labels webhook payload (#34575) (#34603) ... Backport #34575 by @badhezi Fixes https://github.com/go-gitea/gitea/issues/34560 explanation of the bug in the issue setting `issue.isLabelsLoaded = false` before calling `deleteIssueLabel` guarantee we will load the new state of the labels into the issue object before sending it in the webhook. Co-authored-by: badhezi <zlilaharon@gmail.com>	2025-06-05 00:41:01 +08:00
Giteabot	bacc69db83	Make pull request and issue history more compact (#34588) (#34594) ... Backport #34588 by @silverwind Before, waste of space in multiple places: <img width="962" alt="Screenshot 2025-06-02 at 23 11 08" src="https://github.com/user-attachments/assets/ecddf247-d690-434c-a865-9d5e6c690b7d" /> After, reduced spacing around history entries and inside commits list, also fixed unequal horizontal spacing inside commit badge. <img width="946" alt="Screenshot 2025-06-02 at 23 10 45" src="https://github.com/user-attachments/assets/fe92f8e6-28af-4647-ac3a-1aced23d3b27" /> Also, here's a rendering of issue history events, it's more compact now at 8px padding: <img width="565" alt="image" src="https://github.com/user-attachments/assets/cdbf7c0a-a9a2-4942-85fc-c388abb36e15" /> Co-authored-by: silverwind <me@silverwind.io>	2025-06-04 00:04:07 +00:00
Giteabot	c5da032193	fixed incorrect page navigation with up and down arrow on last item of dashboard repos (#34570) (#34596) ... Backport #34570 by metiftikci Co-authored-by: metiftikci <metiftikci@hotmail.com>	2025-06-04 07:13:39 +08:00
Giteabot	3ace45c118	Fix doctor deleting orphaned issues attachments (#34142) (#34571) ... Backport #34142 by @lunny Fix the bug when deleting orphaned issues attachments. The attachments maybe stored on other storages service rather than disk. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2025-06-03 07:01:09 +00:00
Giteabot	5d6c5ce71a	Fix/improve avatar sync from LDAP (#34573) (#34587) ... Backport #34573 by @raucao This fixes 3 issues I encountered when debugging problems with our LDAP sync: 1. The comparison of the hashed image data in `IsUploadAvatarChanged` is wrong. It seems to be from before avatar hashing was changed and unified in #22289. This results in the function always returning `true` for any avatars, even if they weren't changed. 2. Even if there's no avatar to upload (i.e. no avatar available for the LDAP entry), the upload function would still be called for every single user, only to then fail, because the data isn't valid. This is unnecessary. 3. Another small issue is that the comparison function (and thus hashing of data) is called for every user, even if there is no avatar attribute configured at all for the LDAP source. Thus, I switched the condition nesting, so that no cycles are wasted when avatar sync isn't configured in the first place. I also added a trace log for when there is actually a new avatar being uploaded for an existing user, which is now only shown when that is actually the case. Co-authored-by: Râu Cao <842+raucao@users.noreply.github.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-06-02 23:19:55 +02:00
Giteabot	7baa6fa47c	Fix some trivial problems (#34579) (#34585) ... Backport #34579 by wxiaoguang See the comments Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-06-02 17:31:35 +00:00
Giteabot	f9a0b077a7	Retain issue sort type when a keyword search is introduced (#34559) (#34581) ... Backport #34559 by badhezi Fixes #34523 Co-authored-by: badhezi <zlilaharon@gmail.com>	2025-06-02 22:33:44 +08:00
Giteabot	d3317ebabe	Always use an empty line to separate the commit message and trailer (#34512) (#34578) ... Backport #34512 by tclin914 If the message from form.MergeMessageField is empty, we will miss a "\n" between the title and the "Co-authored-by:" line. The title and message should have a blank line between of them. Co-authored-by: Jim Lin <jim@andestech.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-06-02 15:59:10 +08:00
wxiaoguang	e9481e1da3	Fix line-button issue after file selection in file tree (#34574) (#34576) ... Backport #34574 --------- Co-authored-by: Kerwin Bryant <kerwin612@qq.com>	2025-06-01 23:20:21 -07:00
Giteabot	8965c068e9	Fix possible nil description of pull request when migrating from CodeCommit (#34541) (#34550) ... Backport #34541 by @lunny Fix #34320 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2025-05-27 20:11:09 +00:00
Giteabot	eaaa158df3	Add webhook assigning test and fix possible bug (#34420) (#34551) ... Backport #34420 by lunny Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2025-05-28 03:45:25 +08:00
Giteabot	f5498421c4	Refactor commit reader (#34542) (#34549) ... Backport #34542 by wxiaoguang Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-05-27 17:14:33 +00:00
Giteabot	a6a14c9a92	Don't display error log when .git-blame-ignore-revs doesn't exist (#34457) (#34540) ... Backport #34457 by @lunny Fix #34454 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2025-05-26 21:54:03 +02:00
Giteabot	d0ec1788b8	Add sort option recentclose for issues and pulls (#34525) (#34539) ... Backport #34525 by @MarkusAmshove closes #34171 Adds a new sort option `recentclose` for issues and pull requests which will return items in a descending order of when they were closed Co-authored-by: Markus Amshove <scm@amshove.org>	2025-05-27 02:16:50 +08:00
Giteabot	c1202f1b57	Run integration tests against postgres 14 (#34514) (#34536) ... Backport #34514 by @silverwind postgres 12 is end of life since 6 months. 13 and above are still supported but I think it's overall better if we test a more recent version of postgres because that's what new users will be running on. Ref: https://endoflife.date/postgresql Co-authored-by: silverwind <me@silverwind.io>	2025-05-26 12:19:19 -04:00
Giteabot	1162cbccc0	Performance optimization for tags synchronization (#34355) (#34522) ... Backport #34355 by @lunny The tags synchronization is very slow for a non-mirror repository with many tags especially forking. This PR make all repositories' tags synchronization use the same function and remove the low performance synchronization function. The commit count of tag now will not be stored into database when syncing. Since the commits count will always be read from cache or git data, the `NumCommits` in the release table will be updated for the first read from git data. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2025-05-22 19:28:25 -07:00
NorthRealm	038990e0ff	Fix ephemeral runner deletion (#34447) (#34513)	2025-05-21 18:02:34 -04:00
Giteabot	03ff09870d	Fix edithook api can not update package, status and workflow_job events (#34495) (#34499) ... Backport #34495 by @ChristopherHX * the origin of this problem is duplicated code Co-authored-by: ChristopherHX <christopher.homberger@web.de>	2025-05-18 21:18:19 -07:00
Giteabot	8bf4f2cc8f	Fix url validation in webhook add/edit API (#34492) (#34496) ... Backport #34492 by @lunny Fix #34491 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2025-05-17 15:31:36 -07:00
Giteabot	21731c1370	Fix get / delete runner to use consistent http 404 and 500 status (#34480) (#34488) ... Backport #34480 by @ChristopherHX * previously deleting an already deleted runner returned http 500 * previously any database error for the get endpoint was http 404 and never 500 Co-authored-by: ChristopherHX <christopher.homberger@web.de>	2025-05-16 16:59:29 +00:00
Giteabot	a0e272d95a	Add missing setting load in dump-repo command (#34479) (#34489) ... Backport #34479 by @lunny Fix #34465 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2025-05-16 16:33:04 +00:00
NorthRealm	47537a8361	Add a button editing action secret #34348 (#34462) ... Backport #34348 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-05-16 15:26:21 +00:00
Giteabot	d018c1b4b1	nix flake update (#34476) (#34490) ... Backport #34476 by techknowlogick Co-authored-by: techknowlogick <techknowlogick@gitea.com>	2025-05-16 23:00:18 +08:00
Giteabot	d2cbe2fba0	Add migrations tests (#34456) (#34483) ... Backport #34456 by @lunny Fix #34455 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-05-16 10:37:06 -04:00
Giteabot	d6233c25b5	Fix project board view (#34470) (#34475) ... Backport #34470 by wxiaoguang Fix #34469 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-05-16 01:32:53 +08:00
Giteabot	2bf2d00c8a	When updating comment, if the content is the same, just return and not update the databse (#34422) (#34464) ... Backport #34422 by @lunny Fix #34318 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-05-14 21:48:49 -07:00
Giteabot	9bd56a8ba0	Fix Workflow run Not Found page (#34459) (#34466) ... Backport #34459 by NorthRealm Co-authored-by: NorthRealm <155140859+NorthRealm@users.noreply.github.com>	2025-05-15 11:55:39 +08:00
Giteabot	a1dc3c9bd1	Fix remove org user failure on mssql (#34449) (#34453) ... Backport #34449 by @ChristopherHX * mssql does not support fetching 0 repositories * remove paging by NumRepos that might be 0 * extend admin api test to purge user 2 Fixes #34448 Co-authored-by: ChristopherHX <christopher.homberger@web.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-05-13 13:28:26 -07:00
Giteabot	47ee84d1f3	Fix repo broken check (#34444) (#34452) ... Backport #34444 by wxiaoguang Fix #34424 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-05-13 19:02:24 +00:00
Giteabot	89f1df033a	Fix comment textarea scroll issue in Firefox (#34438) (#34446) ... Backport #34438 by @silverwind In the comment editor, there is a bug in Firefox where the scroll position unexpectedly moves up, which is annoying. This is not reproducible in Chrome and Safari. To reproduce here are some steps: - Go into an editable issue - Scroll page to bottom - Focus the textarea and press Return many times, causing the textarea to get a scrollbar - Scroll page to bottom again - Press Return once more - Page should not scroll up. This fixes the bug by adding a temporary margin, and I verified it works in all browsers. Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-05-13 18:39:02 +02:00
Giteabot	94b67f1967	Fix releases sidebar navigation link (#34436) (#34440) ... Backport #34436 by @badhezi Resolves https://github.com/go-gitea/gitea/issues/34435 Co-authored-by: badhezi <zlilaharon@gmail.com>	2025-05-12 14:41:24 -07:00
Giteabot	0a9a84df11	Fix bug webhook milestone is not right. (#34419) (#34428) ... Backport #34419 by @lunny Fix #34400 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: silverwind <me@silverwind.io>	2025-05-12 00:21:14 +00:00
Giteabot	cdac263bb8	Only git operations should update last changed of a repository (#34388) (#34427) ... Backport #34388 by @lunny Try to fix #32046 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2025-05-11 23:23:12 +02:00
Giteabot	a5c7df7a4c	Fix GetUsersByEmails (#34423) (#34425) ... Backport #34423 by wxiaoguang Fix #34418, fix #34353 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-05-11 04:42:59 +08:00
Giteabot	6d738fecc4	Fix a bug when uploading file via lfs ssh command (#34408) (#34416) ... Backport #34408 by @lunny Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-05-10 02:03:37 +00:00
Giteabot	38cc7453e2	Merge and tweak markup editor expander CSS (#34409) (#34415) ... Backport #34409 by @silverwind - Merge the CSS for the two expanders (text-expander-element and tribute.js) into one file - Fix overflow issues - Remove min-width - Various other tweaks like borders, colors, padding, gaps. text-expander: <img width="645" alt="Screenshot 2025-05-09 at 02 21 24" src="https://github.com/user-attachments/assets/33276dc4-38e8-45e1-8216-2a4baa9bc039" /> tribute: <img width="624" alt="Screenshot 2025-05-09 at 02 21 37" src="https://github.com/user-attachments/assets/91fbcd1a-9bfc-40fd-93f0-a05b4bd4c98d" /> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-05-09 18:58:19 +02:00
Giteabot	b44175c071	Refactor commit message rendering and fix bugs (#34412) (#34414) ... Backport #34412 by wxiaoguang Fix #34398, fix #33308 Remove all `repo.ComposeCommentMetas` from templates, only use `repo` to render commit message. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-05-09 13:08:23 +00:00
Giteabot	947358dffe	Fix incorrect divergence cache after switching default branch (#34370) (#34406) ... Backport #34370 by @GWDx Issue: After switching the default branch, other branches are still compared against the old default branch due to outdated divergence cache. Change: Clear the divergence cache in SetRepoDefaultBranch to ensure correct comparisons against the new default branch. Fixes #34369 Co-authored-by: GWDx <gwdx@mail.ustc.edu.cn>	2025-05-09 01:31:34 +02:00
Giteabot	be1090cb2d	Grey out expired artifact on Artifacts list (#34314) (#34404) ... Backport #34314 by @NorthRealm Grey out expired artifact on Artifacts list.   Co-authored-by: NorthRealm <155140859+NorthRealm@users.noreply.github.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-05-08 10:56:51 -07:00
Giteabot	c8f3402841	Fix LFS file not stored in LFS when uploaded/edited via API or web UI (#34367) (#34396) ... Backport #34367 by bytedream Files that should be stored in LFS and are uploaded/edited from the API or web UI aren't stored in LFS. This may be a regression from #34154. Co-authored-by: bytedream <bytedream@protonmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-05-08 05:33:19 +00:00
Giteabot	a3a95a0b67	Upgrade go-github v61 -> v71 (#34385) (#34387) ... Backport #34385 by @lunny There will be a possible bug when migrating from Github https://github.com/google/go-github/issues/3229 This PR upgrades go-github from v61 to v71 to resolve that problem. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2025-05-07 10:05:41 -07:00
Giteabot	ed527b664d	Fix only text/* being viewable in web UI (#34374) (#34378) ... Backport #34374 by @bytedream Regression from #34356, files like SVGs should be editable too (https://github.com/go-gitea/gitea/pull/34356#discussion_r2072766240). Co-authored-by: bytedream <bytedream@protonmail.com>	2025-05-06 05:18:12 +00:00
Giteabot	e4717d426e	Fix bug when visiting comparation page (#34334) (#34365) ... Backport #34334 by @lunny The `ci.HeadGitRepo` was opened and closed in the function `ParseCompareInfo` but reused in the function `PrepareCompareDiff`. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2025-05-04 20:43:42 +00:00
Giteabot	16f15d2f7b	Fix bug when API get pull changed files for deleted head repository (#34333) (#34366) ... Backport #34333 by @lunny Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2025-05-04 20:18:11 +00:00
Giteabot	b3f5196241	Fix LFS files being editable in web UI (#34356) (#34362) ... Backport #34356 by @bytedream It's possible to edit "raw" lfs files in the web UI when accessing the path manually.  Co-authored-by: bytedream <git@bytedream.dev>	2025-05-04 12:38:23 -07:00