Lerking/gtk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

textbtree: Speed up _gtk_text_btree_find_line_top

Browse Source 
Another place where we can avoid allocating a stack
piecemeal.
This commit is contained in:
Matthias Clasen
2021-04-03 22:36:43 -04:00
parent d731ce49ad
commit 0334d002c0
1 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
gtk/gtktextbtree.c
View File

@@ -1481,30 +1481,28 @@ _gtk_text_btree_find_line_top (GtkTextBTree *tree,
{
int y = 0;
BTreeView *view;
GSList *nodes;
GSList *iter;
GtkTextBTreeNode *node;
GtkTextBTreeNode *nodes[64];
int tos = 0;
view = gtk_text_btree_get_view (tree, view_id);
g_return_val_if_fail (view != NULL, 0);
nodes = NULL;
node = target_line->parent;
while (node != NULL)
{
nodes = g_slist_prepend (nodes, node);
nodes[tos++] = node;
node = node->parent;
}
iter = nodes;
while (iter != NULL)
tos--;
while (tos >= 0)
{
node = iter->data;
node = nodes[tos];
if (node->level == 0)
{
g_slist_free (nodes);
return find_line_top_in_line_list (tree, view,
node->children.line,
target_line, y);
@@ -1514,8 +1512,8 @@ _gtk_text_btree_find_line_top (GtkTextBTree *tree,
GtkTextBTreeNode *child;
GtkTextBTreeNode *target_node;
g_assert (iter->next != NULL); /* not at level 0 */
target_node = iter->next->data;
g_assert (tos > 0); /* not at level 0 */
target_node = nodes[tos - 1];
child = node->children.node;
@@ -1538,7 +1536,7 @@ _gtk_text_btree_find_line_top (GtkTextBTree *tree,
ran out of nodes */
}
iter = iter->next;
tos--;
}
g_assert_not_reached (); /* we return when we find the target line */