Lerking/gtk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Turn off sorting while inserting batches of new files, since sorting is

Browse Source 
2004-09-28  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilechooserentry.c (update_current_folder_files): Turn
	off sorting while inserting batches of new files, since sorting
	is slow with the current list store implementation.
This commit is contained in:
Matthias Clasen
2004-09-28 19:19:49 +00:00
committed by Matthias Clasen
parent 851a9de3f3
commit 0aaac89cfd
5 changed files with 32 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@@ -1,3 +1,9 @@
2004-09-28 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkfilechooserentry.c (update_current_folder_files): Turn
off sorting while inserting batches of new files, since sorting
is slow with the current list store implementation.
2004-09-27 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkliststore.c: Allow to disable sorting. This is meant

6
ChangeLog.pre-2-10
View File

@@ -1,3 +1,9 @@
2004-09-28 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkfilechooserentry.c (update_current_folder_files): Turn
off sorting while inserting batches of new files, since sorting
is slow with the current list store implementation.
2004-09-27 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkliststore.c: Allow to disable sorting. This is meant

6
ChangeLog.pre-2-6
View File

@@ -1,3 +1,9 @@
2004-09-28 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkfilechooserentry.c (update_current_folder_files): Turn
off sorting while inserting batches of new files, since sorting
is slow with the current list store implementation.
2004-09-27 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkliststore.c: Allow to disable sorting. This is meant

6
ChangeLog.pre-2-8
View File

@@ -1,3 +1,9 @@
2004-09-28 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkfilechooserentry.c (update_current_folder_files): Turn
off sorting while inserting batches of new files, since sorting
is slow with the current list store implementation.
2004-09-27 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkliststore.c: Allow to disable sorting. This is meant

11
gtk/gtkfilechooserentry.c
View File

@@ -522,7 +522,10 @@ update_current_folder_files (GtkFileChooserEntry *chooser_entry,
g_assert (chooser_entry->completion_store != NULL);
/* Bah. Need to turn off sorting */
/* Turn off sorting, since it is slow with the default list store implementation */
gtk_tree_sortable_set_sort_column_id (GTK_TREE_SORTABLE (chooser_entry->completion_store),
-2, GTK_SORT_ASCENDING);
for (tmp_list = added_uris; tmp_list; tmp_list = tmp_list->next)
{
GtkFileInfo *info;
@@ -535,9 +538,11 @@ update_current_folder_files (GtkFileChooserEntry *chooser_entry,
NULL); /* NULL-GError */
if (info)
{
const gchar *display_name = gtk_file_info_get_display_name (info);
const gchar *display_name;
GtkTreeIter iter;
display_name = gtk_file_info_get_display_name (info);
gtk_list_store_append (chooser_entry->completion_store, &iter);
gtk_list_store_set (chooser_entry->completion_store, &iter,
DISPLAY_NAME_COLUMN, display_name,
@@ -548,7 +553,7 @@ update_current_folder_files (GtkFileChooserEntry *chooser_entry,
}
}
/* FIXME: we want to turn off sorting temporarily. I suck... */
/* Turn sorting back on */
gtk_tree_sortable_set_sort_column_id (GTK_TREE_SORTABLE (chooser_entry->completion_store),
DISPLAY_NAME_COLUMN, GTK_SORT_ASCENDING);