popover: Do not validate the css node on show()
This was a good idea back in GTK3 when popovers were toplevels, but now they're regular child widgets, so they should behave that way. Also, with the introduction of the bloom filter, gtk_css_node_validate() now assumes it's only called on root nodes, so assert that that is the case.
This commit is contained in:
@@ -1353,6 +1353,8 @@ gtk_css_node_validate (GtkCssNode *cssnode)
|
||||
gint64 timestamp;
|
||||
gint64 before = g_get_monotonic_time ();
|
||||
|
||||
g_assert (cssnode->parent == NULL);
|
||||
|
||||
timestamp = gtk_css_node_get_timestamp (cssnode);
|
||||
|
||||
gtk_css_node_validate_internal (cssnode, &filter, timestamp);
|
||||
|
||||
@@ -647,7 +647,6 @@ gtk_popover_show (GtkWidget *widget)
|
||||
GtkPopoverPrivate *priv = gtk_popover_get_instance_private (popover);
|
||||
|
||||
_gtk_widget_set_visible_flag (widget, TRUE);
|
||||
gtk_css_node_validate (gtk_widget_get_css_node (widget));
|
||||
gtk_widget_realize (widget);
|
||||
gtk_popover_native_check_resize (GTK_NATIVE (widget));
|
||||
gtk_widget_map (widget);
|
||||
|
||||
Reference in New Issue
Block a user