Lerking/gtk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gdkwindow: avoid multiple walking of children list

Browse Source 
This counts the number of children and fetches the last GList
node at the same time.
This commit is contained in:
Christian Hergert
2015-09-14 12:25:44 -07:00
parent 7d3ad43841
commit 1c8760c5fa
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
gdk/gdkwindow.c
View File

@@ -3545,6 +3545,7 @@ _gdk_window_process_updates_recurse_helper (GdkWindow *window,
GdkWindow **free_children = NULL;
int i, n_children;
GList *l;
GList *last_link;
if (window->destroyed)
return;
@@ -3587,14 +3588,22 @@ _gdk_window_process_updates_recurse_helper (GdkWindow *window,
_gdk_event_emit (&event);
}
n_children = g_list_length (window->children);
n_children = 0;
last_link = NULL;
/* Count n_children and fetch bottommost at same time */
for (l = window->children; l != NULL; l = l->next)
{
last_link = l;
n_children++;
}
children = g_newa (GdkWindow *, n_children);
if (children == NULL)
children = free_children = g_new (GdkWindow *, n_children);
n_children = 0;
/* Iterate over children, starting at bottommost */
for (l = g_list_last (window->children); l != NULL; l = l->prev)
for (l = last_link; l != NULL; l = l->prev)
{
child = l->data;