Lerking/gtk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

entry: Don't try to handle Tab in entry completions

Browse Source 
Instead, fall through to the default handler after closing the
completion. This has the advantage of letting the file chooser entry
capture the tab key properly, so one can't accidentally move out of the
entry by pressing tab while the completion is popped up.

I also suspect it fixes bugs with weird tab keys and shift/ctrl
oddities. But who knows...

Conflicts:
	gtk/gtkentry.c
This commit is contained in:
Benjamin Otte
2011-11-03 22:03:22 +01:00
committed by Federico Mena Quintero
parent 8f9487fca7
commit 71b20bd105
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gtk/gtkentry.c
View File

@@ -9518,18 +9518,13 @@ keypress_completion_out:
event->keyval == GDK_KP_Tab ||
event->keyval == GDK_ISO_Left_Tab)
{
GtkDirectionType dir = event->keyval == GDK_ISO_Left_Tab ?
GTK_DIR_TAB_BACKWARD : GTK_DIR_TAB_FORWARD;
_gtk_entry_reset_im_context (GTK_ENTRY (widget));
_gtk_entry_completion_popdown (completion);
g_free (completion->priv->completion_prefix);
completion->priv->completion_prefix = NULL;
gtk_widget_child_focus (gtk_widget_get_toplevel (widget), dir);
return TRUE;
return FALSE;
}
else if (event->keyval == GDK_ISO_Enter ||
event->keyval == GDK_KP_Enter ||