Lerking/gtk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

for the END case, use end_position - page_size instead of G_MAXINT, since

Browse Source 
Wed Sep  3 23:18:17 2003  Kristian Rietveld  <kris@gtk.org>

	* gtk/gtkmenu.c (gtk_menu_real_move_scroll): for the END case,
	use end_position - page_size instead of G_MAXINT, since
	gtk_menu_scroll_to doesn't CLAMP anymore internally. (Fixes #121237,
	reported by Havoc Pennington).
This commit is contained in:
Kristian Rietveld
2003-09-03 21:25:02 +00:00
committed by Kristian Rietveld
parent be8c14f372
commit 74ba2d30aa
6 changed files with 39 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
ChangeLog
View File

@@ -1,3 +1,10 @@
Wed Sep 3 23:18:17 2003 Kristian Rietveld <kris@gtk.org>
* gtk/gtkmenu.c (gtk_menu_real_move_scroll): for the END case,
use end_position - page_size instead of G_MAXINT, since
gtk_menu_scroll_to doesn't CLAMP anymore internally. (Fixes #121237,
reported by Havoc Pennington).
Wed Sep 3 21:58:03 2003 Kristian Rietveld <kris@gtk.org>
* gtk/gtkiconfactory.c (cached_icon_free): if icon->style != NULL,

7
ChangeLog.pre-2-10
View File

@@ -1,3 +1,10 @@
Wed Sep 3 23:18:17 2003 Kristian Rietveld <kris@gtk.org>
* gtk/gtkmenu.c (gtk_menu_real_move_scroll): for the END case,
use end_position - page_size instead of G_MAXINT, since
gtk_menu_scroll_to doesn't CLAMP anymore internally. (Fixes #121237,
reported by Havoc Pennington).
Wed Sep 3 21:58:03 2003 Kristian Rietveld <kris@gtk.org>
* gtk/gtkiconfactory.c (cached_icon_free): if icon->style != NULL,

7
ChangeLog.pre-2-4
View File

@@ -1,3 +1,10 @@
Wed Sep 3 23:18:17 2003 Kristian Rietveld <kris@gtk.org>
* gtk/gtkmenu.c (gtk_menu_real_move_scroll): for the END case,
use end_position - page_size instead of G_MAXINT, since
gtk_menu_scroll_to doesn't CLAMP anymore internally. (Fixes #121237,
reported by Havoc Pennington).
Wed Sep 3 21:58:03 2003 Kristian Rietveld <kris@gtk.org>
* gtk/gtkiconfactory.c (cached_icon_free): if icon->style != NULL,

7
ChangeLog.pre-2-6
View File

@@ -1,3 +1,10 @@
Wed Sep 3 23:18:17 2003 Kristian Rietveld <kris@gtk.org>
* gtk/gtkmenu.c (gtk_menu_real_move_scroll): for the END case,
use end_position - page_size instead of G_MAXINT, since
gtk_menu_scroll_to doesn't CLAMP anymore internally. (Fixes #121237,
reported by Havoc Pennington).
Wed Sep 3 21:58:03 2003 Kristian Rietveld <kris@gtk.org>
* gtk/gtkiconfactory.c (cached_icon_free): if icon->style != NULL,

7
ChangeLog.pre-2-8
View File

@@ -1,3 +1,10 @@
Wed Sep 3 23:18:17 2003 Kristian Rietveld <kris@gtk.org>
* gtk/gtkmenu.c (gtk_menu_real_move_scroll): for the END case,
use end_position - page_size instead of G_MAXINT, since
gtk_menu_scroll_to doesn't CLAMP anymore internally. (Fixes #121237,
reported by Havoc Pennington).
Wed Sep 3 21:58:03 2003 Kristian Rietveld <kris@gtk.org>
* gtk/gtkiconfactory.c (cached_icon_free): if icon->style != NULL,

7
gtk/gtkmenu.c
View File

@@ -3192,6 +3192,8 @@ static void
gtk_menu_real_move_scroll (GtkMenu *menu,
GtkScrollType type)
{
gint page_size = get_visible_size (menu);
gint end_position = get_menu_height (menu);
GtkMenuShell *menu_shell = GTK_MENU_SHELL (menu);
switch (type)
@@ -3199,7 +3201,6 @@ gtk_menu_real_move_scroll (GtkMenu *menu,
case GTK_SCROLL_PAGE_UP:
case GTK_SCROLL_PAGE_DOWN:
{
gint page_size = get_visible_size (menu);
gint old_offset;
gint new_offset;
gint child_offset = 0;
@@ -3225,7 +3226,7 @@ gtk_menu_real_move_scroll (GtkMenu *menu,
old_offset = menu->scroll_offset;
new_offset = menu->scroll_offset + step;
new_offset = CLAMP (new_offset, 0, get_menu_height (menu) - page_size);
new_offset = CLAMP (new_offset, 0, end_position - page_size);
gtk_menu_scroll_to (menu, new_offset);
@@ -3256,7 +3257,7 @@ gtk_menu_real_move_scroll (GtkMenu *menu,
/* Ignore the enter event we might get if the pointer is on the menu
*/
menu_shell->ignore_enter = TRUE;
gtk_menu_scroll_to (menu, G_MAXINT);
gtk_menu_scroll_to (menu, end_position - page_size);
_gtk_menu_shell_select_last (menu_shell, TRUE);
break;
default: