Lerking/gtk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

textlayout: remove use of GtkTextIter in line comparison

Browse Source 
We do not need to create a GtkTextIter to perform the comparison here as
that will require a number of validation steps that are extra work
compared to just discovering the GtkTextLine number directly.
This commit is contained in:
Christian Hergert
2019-09-04 09:12:54 -07:00
parent cbdea09c92
commit 7cea21043e
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
gtk/gtktextlayout.c
View File

@@ -4197,11 +4197,16 @@ gtk_text_line_display_compare (const GtkTextLineDisplay *display1,
const GtkTextLineDisplay *display2,
GtkTextLayout *layout)
{
GtkTextIter iter1;
GtkTextIter iter2;
gint line1;
gint line2;
gtk_text_layout_get_iter_at_line (layout, &iter1, display1->line, 0);
gtk_text_layout_get_iter_at_line (layout, &iter2, display2->line, 0);
line1 = _gtk_text_line_get_number (display1->line);
line2 = _gtk_text_line_get_number (display2->line);
return gtk_text_iter_compare (&iter1, &iter2);
if (line1 < line2)
return -1;
else if (line1 > line2)
return 1;
else
return 0;
}