Lerking/gtk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Set the activate_time to 0, so that we handle a quick press/release

Browse Source 
Thu Feb  3 14:46:01 2000  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkmenushell.c (gtk_menu_shell_button_release): Set
	the activate_time to 0, so that we handle a quick
	press/release press/release properly and don't suppress
        the second release. (Red Hat bug #7545)
This commit is contained in:
Owen Taylor
2000-02-02 22:04:41 +00:00
committed by Owen Taylor
parent cec440f3e4
commit 7de47cc94b
8 changed files with 88 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
ChangeLog
View File

@@ -1,9 +1,16 @@
Thu Feb 3 14:46:01 2000 Owen Taylor <otaylor@redhat.com>
* gtk/gtkmenushell.c (gtk_menu_shell_button_release): Set
the activate_time to 0, so that we handle a quick
press/release press/release properly and don't suppress
the second release. (Red Hat bug #7545)
Wed Feb 2 22:25:17 2000 Tim Janik <timj@gtk.org>
* gtk/gtkctree.c (row_delete):
(gtk_ctree_node_set_row_data_full): fixed very evil reentrancy bugs with
destruction notifier, *always* update internal structures *before*
calling user code.
* gtk/gtkctree.c (row_delete):
(gtk_ctree_node_set_row_data_full): fixed very evil reentrancy
bugs with destruction notifier, *always* update internal
structures *before* calling user code.
Sun Jan 30 20:10:52 2000 Lars Hamann <lars@gtk.org>

15
ChangeLog.pre-2-0
View File

@@ -1,9 +1,16 @@
Thu Feb 3 14:46:01 2000 Owen Taylor <otaylor@redhat.com>
* gtk/gtkmenushell.c (gtk_menu_shell_button_release): Set
the activate_time to 0, so that we handle a quick
press/release press/release properly and don't suppress
the second release. (Red Hat bug #7545)
Wed Feb 2 22:25:17 2000 Tim Janik <timj@gtk.org>
* gtk/gtkctree.c (row_delete):
(gtk_ctree_node_set_row_data_full): fixed very evil reentrancy bugs with
destruction notifier, *always* update internal structures *before*
calling user code.
* gtk/gtkctree.c (row_delete):
(gtk_ctree_node_set_row_data_full): fixed very evil reentrancy
bugs with destruction notifier, *always* update internal
structures *before* calling user code.
Sun Jan 30 20:10:52 2000 Lars Hamann <lars@gtk.org>

15
ChangeLog.pre-2-10
View File

@@ -1,9 +1,16 @@
Thu Feb 3 14:46:01 2000 Owen Taylor <otaylor@redhat.com>
* gtk/gtkmenushell.c (gtk_menu_shell_button_release): Set
the activate_time to 0, so that we handle a quick
press/release press/release properly and don't suppress
the second release. (Red Hat bug #7545)
Wed Feb 2 22:25:17 2000 Tim Janik <timj@gtk.org>
* gtk/gtkctree.c (row_delete):
(gtk_ctree_node_set_row_data_full): fixed very evil reentrancy bugs with
destruction notifier, *always* update internal structures *before*
calling user code.
* gtk/gtkctree.c (row_delete):
(gtk_ctree_node_set_row_data_full): fixed very evil reentrancy
bugs with destruction notifier, *always* update internal
structures *before* calling user code.
Sun Jan 30 20:10:52 2000 Lars Hamann <lars@gtk.org>

15
ChangeLog.pre-2-2
View File

@@ -1,9 +1,16 @@
Thu Feb 3 14:46:01 2000 Owen Taylor <otaylor@redhat.com>
* gtk/gtkmenushell.c (gtk_menu_shell_button_release): Set
the activate_time to 0, so that we handle a quick
press/release press/release properly and don't suppress
the second release. (Red Hat bug #7545)
Wed Feb 2 22:25:17 2000 Tim Janik <timj@gtk.org>
* gtk/gtkctree.c (row_delete):
(gtk_ctree_node_set_row_data_full): fixed very evil reentrancy bugs with
destruction notifier, *always* update internal structures *before*
calling user code.
* gtk/gtkctree.c (row_delete):
(gtk_ctree_node_set_row_data_full): fixed very evil reentrancy
bugs with destruction notifier, *always* update internal
structures *before* calling user code.
Sun Jan 30 20:10:52 2000 Lars Hamann <lars@gtk.org>

15
ChangeLog.pre-2-4
View File

@@ -1,9 +1,16 @@
Thu Feb 3 14:46:01 2000 Owen Taylor <otaylor@redhat.com>
* gtk/gtkmenushell.c (gtk_menu_shell_button_release): Set
the activate_time to 0, so that we handle a quick
press/release press/release properly and don't suppress
the second release. (Red Hat bug #7545)
Wed Feb 2 22:25:17 2000 Tim Janik <timj@gtk.org>
* gtk/gtkctree.c (row_delete):
(gtk_ctree_node_set_row_data_full): fixed very evil reentrancy bugs with
destruction notifier, *always* update internal structures *before*
calling user code.
* gtk/gtkctree.c (row_delete):
(gtk_ctree_node_set_row_data_full): fixed very evil reentrancy
bugs with destruction notifier, *always* update internal
structures *before* calling user code.
Sun Jan 30 20:10:52 2000 Lars Hamann <lars@gtk.org>

15
ChangeLog.pre-2-6
View File

@@ -1,9 +1,16 @@
Thu Feb 3 14:46:01 2000 Owen Taylor <otaylor@redhat.com>
* gtk/gtkmenushell.c (gtk_menu_shell_button_release): Set
the activate_time to 0, so that we handle a quick
press/release press/release properly and don't suppress
the second release. (Red Hat bug #7545)
Wed Feb 2 22:25:17 2000 Tim Janik <timj@gtk.org>
* gtk/gtkctree.c (row_delete):
(gtk_ctree_node_set_row_data_full): fixed very evil reentrancy bugs with
destruction notifier, *always* update internal structures *before*
calling user code.
* gtk/gtkctree.c (row_delete):
(gtk_ctree_node_set_row_data_full): fixed very evil reentrancy
bugs with destruction notifier, *always* update internal
structures *before* calling user code.
Sun Jan 30 20:10:52 2000 Lars Hamann <lars@gtk.org>

15
ChangeLog.pre-2-8
View File

@@ -1,9 +1,16 @@
Thu Feb 3 14:46:01 2000 Owen Taylor <otaylor@redhat.com>
* gtk/gtkmenushell.c (gtk_menu_shell_button_release): Set
the activate_time to 0, so that we handle a quick
press/release press/release properly and don't suppress
the second release. (Red Hat bug #7545)
Wed Feb 2 22:25:17 2000 Tim Janik <timj@gtk.org>
* gtk/gtkctree.c (row_delete):
(gtk_ctree_node_set_row_data_full): fixed very evil reentrancy bugs with
destruction notifier, *always* update internal structures *before*
calling user code.
* gtk/gtkctree.c (row_delete):
(gtk_ctree_node_set_row_data_full): fixed very evil reentrancy
bugs with destruction notifier, *always* update internal
structures *before* calling user code.
Sun Jan 30 20:10:52 2000 Lars Hamann <lars@gtk.org>

12
gtk/gtkmenushell.c
View File

@@ -494,7 +494,17 @@ gtk_menu_shell_button_release (GtkWidget *widget,
}
}
else
deactivate = FALSE;
{
/* We only ever want to prevent deactivation on the first
* press/release. Setting the time to zero is a bit of a
* hack, since we could be being triggered in the first
* few fractions of a second after a server time wraparound.
* the chances of that happening are ~1/10^6, without
* serious harm if we lose.
*/
menu_shell->activate_time = 0;
deactivate = FALSE;
}
/* If the button click was very fast, or we ended up on a submenu,
* leave the menu up