Lerking/gtk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix up signal ordering issues in GtkEntry

Browse Source 
Ensure that text and selection boundaries are in a
consistent state when we emit notifications, that ::insert-text
and ::delete-text are emitted before any changes, and that
::changed is emitted after property notifications when inserting
or deleting text.

Conflicts:
	gtk/gtkentry.c
This commit is contained in:
Matthias Clasen
2011-06-25 18:49:54 -04:00
committed by Federico Mena Quintero
parent fb9a63f9d0
commit 87e0582f03
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
gtk/gtkentry.c
View File

@@ -4581,12 +4581,18 @@ buffer_inserted_text (GtkEntryBuffer *buffer,
GtkEntry *entry)
{
guint password_hint_timeout;
guint current_pos;
gint selection_bound;
if (entry->current_pos > position)
entry->current_pos += n_chars;
current_pos = entry->current_pos;
if (current_pos > position)
current_pos += n_chars;
if (entry->selection_bound > position)
entry->selection_bound += n_chars;
selection_bound = entry->selection_bound;
if (selection_bound > position)
selection_bound += n_chars;
gtk_entry_set_positions (entry, current_pos, selection_bound);
/* Calculate the password hint if it needs to be displayed. */
if (n_chars == 1 && !entry->visible)