Lerking/gtk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

textbuffer: Return GObject properties on get_can_redo/undo

Browse Source 
It's possible that the textbuffer has been subclassed and
have overridden 'can-redo' or 'can-undo' properties.

gtk_text_buffer_get_can_redo()/undo() should return those
overridden properties in those cases so that the users of the
API (eg: The 'Redo' or 'Undo' button in the text-view context
menu) behaves properly.
This commit is contained in:
Mohammed Sadiq
2023-08-06 11:58:05 +05:30
parent 28190ded71
commit a3adeefb79
1 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
gtk/gtktextbuffer.c
View File

@@ -1039,11 +1039,11 @@ gtk_text_buffer_get_property (GObject *object,
break;
case PROP_CAN_UNDO:
g_value_set_boolean (value, gtk_text_buffer_get_can_undo (text_buffer));
g_value_set_boolean (value, gtk_text_history_get_can_undo (text_buffer->priv->history));
break;
case PROP_CAN_REDO:
g_value_set_boolean (value, gtk_text_buffer_get_can_redo (text_buffer));
g_value_set_boolean (value, gtk_text_history_get_can_redo (text_buffer->priv->history));
break;
default:
@@ -4871,9 +4871,13 @@ gtk_text_buffer_real_redo (GtkTextBuffer *buffer)
gboolean
gtk_text_buffer_get_can_undo (GtkTextBuffer *buffer)
{
gboolean can_undo;
g_return_val_if_fail (GTK_IS_TEXT_BUFFER (buffer), FALSE);
return gtk_text_history_get_can_undo (buffer->priv->history);
g_object_get (buffer, "can-undo", &can_undo, NULL);
return can_undo;
}
/**
@@ -4887,9 +4891,13 @@ gtk_text_buffer_get_can_undo (GtkTextBuffer *buffer)
gboolean
gtk_text_buffer_get_can_redo (GtkTextBuffer *buffer)
{
gboolean can_redo;
g_return_val_if_fail (GTK_IS_TEXT_BUFFER (buffer), FALSE);
return gtk_text_history_get_can_redo (buffer->priv->history);
g_object_get (buffer, "can-redo", &can_redo, NULL);
return can_redo;
}
static void