Lerking/gtk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

notebook: fix gtk_widget_unparent() with NULL child

Browse Source 
When using gtk4-demo and closing the window (after changing notebook tabs),
a CRITICAL like the following is presented.

  gtk_widget_unparent: assertion 'GTK_IS_WIDGET (widget)' failed

This fixes that by conditionally checking that we have a valid widget still
within the GtkBin.
This commit is contained in:
Christian Hergert
2019-10-04 12:41:23 -07:00
parent 94d9088034
commit bdd7b6ec26
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
gtk/gtknotebook.c
View File

@@ -5674,8 +5674,13 @@ static void
gtk_notebook_menu_label_unparent (GtkWidget *widget,
gpointer data)
{
gtk_widget_unparent (gtk_bin_get_child (GTK_BIN (widget)));
_gtk_bin_set_child (GTK_BIN (widget), NULL);
GtkWidget *child = gtk_bin_get_child (GTK_BIN (widget));
if (child != NULL)
{
gtk_widget_unparent (child);
_gtk_bin_set_child (GTK_BIN (widget), NULL);
}
}
/* Public GtkNotebook Page Insert/Remove Methods :