Lerking/gtk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't omit setting the properties if flags == 0 - there may be an existing

Browse Source 
Sat Sep  4 08:39:26 1999  Owen Taylor  <otaylor@redhat.com>

	* gdk/gdkwindow.c (gdk_window_set_geometry_hints)
	  gdk/gdkwindow.c (gdk_window_set_hints):

	Don't omit setting the properties if flags == 0 -
	there may be an existing set of properties there
	already. (Very old bug. Would it be better to
	delete the property instead?)

	* gdk/gdkselection.c (gdk_selection_property_get): Fix
	  spelling error in comment.
This commit is contained in:
Owen Taylor
1999-09-02 03:41:41 +00:00
committed by Owen Taylor
parent bd2194afb1
commit c431108d84
11 changed files with 125 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
ChangeLog
View File

@@ -1,3 +1,16 @@
Sat Sep 4 08:39:26 1999 Owen Taylor <otaylor@redhat.com>
* gdk/gdkwindow.c (gdk_window_set_geometry_hints)
gdk/gdkwindow.c (gdk_window_set_hints):
Don't omit setting the properties if flags == 0 -
there may be an existing set of properties there
already. (Very old bug. Would it be better to
delete the property instead?)
* gdk/gdkselection.c (gdk_selection_property_get): Fix
spelling error in comment.
Wed Sep 1 20:46:11 1999 Owen Taylor <otaylor@redhat.com>
* gtk/gtkrc.c: deal properly with the fact that RC
@@ -296,6 +309,7 @@ Sat Aug 21 14:07:36 1999 Lars Hamann <lars@gtk.org>
show them instead.
(Bug#1805 Reported by: Dave Cole <dave@dccs.com.au>)
>>>>>>> 1.1061.2.110
Wed Aug 18 09:20:10 1999 Tim Janik <timj@gtk.org>
* gtk/gtkwindow.c:
@@ -352,6 +366,7 @@ Tue Aug 17 07:43:04 1999 Tim Janik <timj@gtk.org>
function from gtk_tooltips_expose, as we connect to ::expose_event
*and* ::draw now.
>>>>>>> 1.1061.2.104
1999-08-18 Federico Mena Quintero <federico@redhat.com>
* gtk/gtkselection.c (gtk_target_list_ref): Added missing sanity

15
ChangeLog.pre-2-0
View File

@@ -1,3 +1,16 @@
Sat Sep 4 08:39:26 1999 Owen Taylor <otaylor@redhat.com>
* gdk/gdkwindow.c (gdk_window_set_geometry_hints)
gdk/gdkwindow.c (gdk_window_set_hints):
Don't omit setting the properties if flags == 0 -
there may be an existing set of properties there
already. (Very old bug. Would it be better to
delete the property instead?)
* gdk/gdkselection.c (gdk_selection_property_get): Fix
spelling error in comment.
Wed Sep 1 20:46:11 1999 Owen Taylor <otaylor@redhat.com>
* gtk/gtkrc.c: deal properly with the fact that RC
@@ -296,6 +309,7 @@ Sat Aug 21 14:07:36 1999 Lars Hamann <lars@gtk.org>
show them instead.
(Bug#1805 Reported by: Dave Cole <dave@dccs.com.au>)
>>>>>>> 1.1061.2.110
Wed Aug 18 09:20:10 1999 Tim Janik <timj@gtk.org>
* gtk/gtkwindow.c:
@@ -352,6 +366,7 @@ Tue Aug 17 07:43:04 1999 Tim Janik <timj@gtk.org>
function from gtk_tooltips_expose, as we connect to ::expose_event
*and* ::draw now.
>>>>>>> 1.1061.2.104
1999-08-18 Federico Mena Quintero <federico@redhat.com>
* gtk/gtkselection.c (gtk_target_list_ref): Added missing sanity

15
ChangeLog.pre-2-10
View File

@@ -1,3 +1,16 @@
Sat Sep 4 08:39:26 1999 Owen Taylor <otaylor@redhat.com>
* gdk/gdkwindow.c (gdk_window_set_geometry_hints)
gdk/gdkwindow.c (gdk_window_set_hints):
Don't omit setting the properties if flags == 0 -
there may be an existing set of properties there
already. (Very old bug. Would it be better to
delete the property instead?)
* gdk/gdkselection.c (gdk_selection_property_get): Fix
spelling error in comment.
Wed Sep 1 20:46:11 1999 Owen Taylor <otaylor@redhat.com>
* gtk/gtkrc.c: deal properly with the fact that RC
@@ -296,6 +309,7 @@ Sat Aug 21 14:07:36 1999 Lars Hamann <lars@gtk.org>
show them instead.
(Bug#1805 Reported by: Dave Cole <dave@dccs.com.au>)
>>>>>>> 1.1061.2.110
Wed Aug 18 09:20:10 1999 Tim Janik <timj@gtk.org>
* gtk/gtkwindow.c:
@@ -352,6 +366,7 @@ Tue Aug 17 07:43:04 1999 Tim Janik <timj@gtk.org>
function from gtk_tooltips_expose, as we connect to ::expose_event
*and* ::draw now.
>>>>>>> 1.1061.2.104
1999-08-18 Federico Mena Quintero <federico@redhat.com>
* gtk/gtkselection.c (gtk_target_list_ref): Added missing sanity

15
ChangeLog.pre-2-2
View File

@@ -1,3 +1,16 @@
Sat Sep 4 08:39:26 1999 Owen Taylor <otaylor@redhat.com>
* gdk/gdkwindow.c (gdk_window_set_geometry_hints)
gdk/gdkwindow.c (gdk_window_set_hints):
Don't omit setting the properties if flags == 0 -
there may be an existing set of properties there
already. (Very old bug. Would it be better to
delete the property instead?)
* gdk/gdkselection.c (gdk_selection_property_get): Fix
spelling error in comment.
Wed Sep 1 20:46:11 1999 Owen Taylor <otaylor@redhat.com>
* gtk/gtkrc.c: deal properly with the fact that RC
@@ -296,6 +309,7 @@ Sat Aug 21 14:07:36 1999 Lars Hamann <lars@gtk.org>
show them instead.
(Bug#1805 Reported by: Dave Cole <dave@dccs.com.au>)
>>>>>>> 1.1061.2.110
Wed Aug 18 09:20:10 1999 Tim Janik <timj@gtk.org>
* gtk/gtkwindow.c:
@@ -352,6 +366,7 @@ Tue Aug 17 07:43:04 1999 Tim Janik <timj@gtk.org>
function from gtk_tooltips_expose, as we connect to ::expose_event
*and* ::draw now.
>>>>>>> 1.1061.2.104
1999-08-18 Federico Mena Quintero <federico@redhat.com>
* gtk/gtkselection.c (gtk_target_list_ref): Added missing sanity

15
ChangeLog.pre-2-4
View File

@@ -1,3 +1,16 @@
Sat Sep 4 08:39:26 1999 Owen Taylor <otaylor@redhat.com>
* gdk/gdkwindow.c (gdk_window_set_geometry_hints)
gdk/gdkwindow.c (gdk_window_set_hints):
Don't omit setting the properties if flags == 0 -
there may be an existing set of properties there
already. (Very old bug. Would it be better to
delete the property instead?)
* gdk/gdkselection.c (gdk_selection_property_get): Fix
spelling error in comment.
Wed Sep 1 20:46:11 1999 Owen Taylor <otaylor@redhat.com>
* gtk/gtkrc.c: deal properly with the fact that RC
@@ -296,6 +309,7 @@ Sat Aug 21 14:07:36 1999 Lars Hamann <lars@gtk.org>
show them instead.
(Bug#1805 Reported by: Dave Cole <dave@dccs.com.au>)
>>>>>>> 1.1061.2.110
Wed Aug 18 09:20:10 1999 Tim Janik <timj@gtk.org>
* gtk/gtkwindow.c:
@@ -352,6 +366,7 @@ Tue Aug 17 07:43:04 1999 Tim Janik <timj@gtk.org>
function from gtk_tooltips_expose, as we connect to ::expose_event
*and* ::draw now.
>>>>>>> 1.1061.2.104
1999-08-18 Federico Mena Quintero <federico@redhat.com>
* gtk/gtkselection.c (gtk_target_list_ref): Added missing sanity

15
ChangeLog.pre-2-6
View File

@@ -1,3 +1,16 @@
Sat Sep 4 08:39:26 1999 Owen Taylor <otaylor@redhat.com>
* gdk/gdkwindow.c (gdk_window_set_geometry_hints)
gdk/gdkwindow.c (gdk_window_set_hints):
Don't omit setting the properties if flags == 0 -
there may be an existing set of properties there
already. (Very old bug. Would it be better to
delete the property instead?)
* gdk/gdkselection.c (gdk_selection_property_get): Fix
spelling error in comment.
Wed Sep 1 20:46:11 1999 Owen Taylor <otaylor@redhat.com>
* gtk/gtkrc.c: deal properly with the fact that RC
@@ -296,6 +309,7 @@ Sat Aug 21 14:07:36 1999 Lars Hamann <lars@gtk.org>
show them instead.
(Bug#1805 Reported by: Dave Cole <dave@dccs.com.au>)
>>>>>>> 1.1061.2.110
Wed Aug 18 09:20:10 1999 Tim Janik <timj@gtk.org>
* gtk/gtkwindow.c:
@@ -352,6 +366,7 @@ Tue Aug 17 07:43:04 1999 Tim Janik <timj@gtk.org>
function from gtk_tooltips_expose, as we connect to ::expose_event
*and* ::draw now.
>>>>>>> 1.1061.2.104
1999-08-18 Federico Mena Quintero <federico@redhat.com>
* gtk/gtkselection.c (gtk_target_list_ref): Added missing sanity

15
ChangeLog.pre-2-8
View File

@@ -1,3 +1,16 @@
Sat Sep 4 08:39:26 1999 Owen Taylor <otaylor@redhat.com>
* gdk/gdkwindow.c (gdk_window_set_geometry_hints)
gdk/gdkwindow.c (gdk_window_set_hints):
Don't omit setting the properties if flags == 0 -
there may be an existing set of properties there
already. (Very old bug. Would it be better to
delete the property instead?)
* gdk/gdkselection.c (gdk_selection_property_get): Fix
spelling error in comment.
Wed Sep 1 20:46:11 1999 Owen Taylor <otaylor@redhat.com>
* gtk/gtkrc.c: deal properly with the fact that RC
@@ -296,6 +309,7 @@ Sat Aug 21 14:07:36 1999 Lars Hamann <lars@gtk.org>
show them instead.
(Bug#1805 Reported by: Dave Cole <dave@dccs.com.au>)
>>>>>>> 1.1061.2.110
Wed Aug 18 09:20:10 1999 Tim Janik <timj@gtk.org>
* gtk/gtkwindow.c:
@@ -352,6 +366,7 @@ Tue Aug 17 07:43:04 1999 Tim Janik <timj@gtk.org>
function from gtk_tooltips_expose, as we connect to ::expose_event
*and* ::draw now.
>>>>>>> 1.1061.2.104
1999-08-18 Federico Mena Quintero <federico@redhat.com>
* gtk/gtkselection.c (gtk_target_list_ref): Added missing sanity

2
gdk/gdkselection.c
View File

@@ -109,7 +109,7 @@ gdk_selection_property_get (GdkWindow *requestor,
g_return_val_if_fail (requestor != NULL, 0);
/* If retrieved chunks are typically small, (and the ICCM says the
/* If retrieved chunks are typically small, (and the ICCCM says the
should be) it would be a win to try first with a buffer of
moderate length, to avoid two round trips to the server */

14
gdk/gdkwindow.c
View File

@@ -1082,8 +1082,10 @@ gdk_window_set_hints (GdkWindow *window,
size_hints.max_height = max_height;
}
if (flags)
XSetWMNormalHints (private->xdisplay, private->xwindow, &size_hints);
/* FIXME: Would it be better to delete this property of
* flags == 0? It would save space on the server
*/
XSetWMNormalHints (private->xdisplay, private->xwindow, &size_hints);
}
void
@@ -1165,9 +1167,11 @@ gdk_window_set_geometry_hints (GdkWindow *window,
size_hints.max_aspect.y = 65536 / geometry->max_aspect;;
}
}
if (geom_mask)
XSetWMNormalHints (private->xdisplay, private->xwindow, &size_hints);
/* FIXME: Would it be better to delete this property of
* geom_mask == 0? It would save space on the server
*/
XSetWMNormalHints (private->xdisplay, private->xwindow, &size_hints);
}
void

2
gdk/x11/gdkselection-x11.c
View File

@@ -109,7 +109,7 @@ gdk_selection_property_get (GdkWindow *requestor,
g_return_val_if_fail (requestor != NULL, 0);
/* If retrieved chunks are typically small, (and the ICCM says the
/* If retrieved chunks are typically small, (and the ICCCM says the
should be) it would be a win to try first with a buffer of
moderate length, to avoid two round trips to the server */

14
gdk/x11/gdkwindow-x11.c
View File

@@ -1082,8 +1082,10 @@ gdk_window_set_hints (GdkWindow *window,
size_hints.max_height = max_height;
}
if (flags)
XSetWMNormalHints (private->xdisplay, private->xwindow, &size_hints);
/* FIXME: Would it be better to delete this property of
* flags == 0? It would save space on the server
*/
XSetWMNormalHints (private->xdisplay, private->xwindow, &size_hints);
}
void
@@ -1165,9 +1167,11 @@ gdk_window_set_geometry_hints (GdkWindow *window,
size_hints.max_aspect.y = 65536 / geometry->max_aspect;;
}
}
if (geom_mask)
XSetWMNormalHints (private->xdisplay, private->xwindow, &size_hints);
/* FIXME: Would it be better to delete this property of
* geom_mask == 0? It would save space on the server
*/
XSetWMNormalHints (private->xdisplay, private->xwindow, &size_hints);
}
void