Lerking/gtk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

printunixdialog: Set selection after list view item created

Browse Source 
Commit b807b84e16 ("print dialog: Fix initial selection") made a
change where we connect to items-changed before the list item manager.
That leads to us attempting to set a selection for a tile that does
not yet exist.

Fixes: https://gitlab.gnome.org/GNOME/gtk/-/issues/7109
This commit is contained in:
Corey Berla
2024-10-28 22:25:37 -07:00
committed by Matthias Clasen
parent 1cfef15317
commit db3807ca1f
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gtk/print/gtkprintunixdialog.c
View File

@@ -889,8 +889,6 @@ gtk_print_unix_dialog_init (GtkPrintUnixDialog *dialog)
selection = G_LIST_MODEL (gtk_single_selection_new (NULL));
gtk_single_selection_set_autoselect (GTK_SINGLE_SELECTION (selection), FALSE);
g_signal_connect (selection, "items-changed", G_CALLBACK (printer_added_cb), dialog);
g_signal_connect_swapped (selection, "notify::selected", G_CALLBACK (selected_printer_changed), dialog);
gtk_single_selection_set_model (GTK_SINGLE_SELECTION (selection), filtered);
@@ -898,6 +896,9 @@ gtk_print_unix_dialog_init (GtkPrintUnixDialog *dialog)
gtk_column_view_set_model (GTK_COLUMN_VIEW (dialog->printer_list), GTK_SELECTION_MODEL (selection));
g_signal_connect (selection, "items-changed", G_CALLBACK (printer_added_cb), dialog);
g_signal_connect_swapped (selection, "notify::selected", G_CALLBACK (selected_printer_changed), dialog);
g_object_unref (selection);
gtk_print_load_custom_papers (dialog->custom_paper_list);