Lerking/gtk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't looks the bookmark label when reordering. (#320720, Jeremy Cook)

Browse Source 
2005-11-07  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilechooserdefault.c (shortcuts_reorder): Don't
	looks the bookmark label when reordering.  (#320720, Jeremy Cook)
This commit is contained in:
Matthias Clasen
2005-11-07 20:30:17 +00:00
committed by Matthias Clasen
parent b3a1c4cdb7
commit e2db438a36
3 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
ChangeLog
View File

@@ -1,5 +1,8 @@
2005-11-07 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkfilechooserdefault.c (shortcuts_reorder): Don't
looks the bookmark label when reordering. (#320720, Jeremy Cook)
* gtk/gtkpathbar.[hc]: Set focus-on-click to FALSE for all buttons.
Don't grab focus when a slider button is pressed, instead, use
a bit in the pathbar struct to determine whether to scroll up

3
ChangeLog.pre-2-10
View File

@@ -1,5 +1,8 @@
2005-11-07 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkfilechooserdefault.c (shortcuts_reorder): Don't
looks the bookmark label when reordering. (#320720, Jeremy Cook)
* gtk/gtkpathbar.[hc]: Set focus-on-click to FALSE for all buttons.
Don't grab focus when a slider button is pressed, instead, use
a bit in the pathbar struct to determine whether to scroll up

9
gtk/gtkfilechooserdefault.c
View File

@@ -2900,6 +2900,7 @@ shortcuts_reorder (GtkFileChooserDefault *impl,
const GtkFilePath *file_path;
GtkFilePath *file_path_copy;
GError *error;
gchar *name;
/* Get the selected path */
@@ -2915,12 +2916,13 @@ shortcuts_reorder (GtkFileChooserDefault *impl,
g_assert (old_position >= 0 && old_position < impl->num_bookmarks);
gtk_tree_model_get (GTK_TREE_MODEL (impl->shortcuts_model), &iter,
SHORTCUTS_COL_NAME, &name,
SHORTCUTS_COL_DATA, &col_data,
SHORTCUTS_COL_IS_VOLUME, &is_volume,
-1);
g_assert (col_data != NULL);
g_assert (!is_volume);
file_path = col_data;
file_path_copy = gtk_file_path_copy (file_path); /* removal below will free file_path, so we need a copy */
@@ -2934,7 +2936,10 @@ shortcuts_reorder (GtkFileChooserDefault *impl,
error = NULL;
if (gtk_file_system_remove_bookmark (impl->file_system, file_path_copy, &error))
shortcuts_add_bookmark_from_path (impl, file_path_copy, new_position);
{
shortcuts_add_bookmark_from_path (impl, file_path_copy, new_position);
gtk_file_system_set_bookmark_label (impl->file_system, file_path_copy, name);
}
else
error_adding_bookmark_dialog (impl, file_path_copy, error);