Lerking/gtk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

a11y: Skip atspi.Cache signals for hidden elements

Browse Source 
If the accessible object is hidden, we can skip the emission of the
AddAccessible and RemoveAccessible signals on the cache, as those
objects won't be visible in the accessibility tree.
This commit is contained in:
Emmanuele Bassi
2020-11-19 14:46:01 +00:00
parent 8fa58c2e17
commit e600a07237
1 changed files with 24 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
gtk/a11y/gtkatspicache.c
View File

@@ -176,6 +176,18 @@ static void
emit_add_accessible (GtkAtSpiCache *self,
GtkAtSpiContext *context)
{
GtkATContext *at_context = GTK_AT_CONTEXT (context);
/* If the context is hidden, we don't need to update the cache */
if (gtk_at_context_has_accessible_state (at_context, GTK_ACCESSIBLE_STATE_HIDDEN))
{
GtkAccessibleValue *is_hidden =
gtk_at_context_get_accessible_state (at_context, GTK_ACCESSIBLE_STATE_HIDDEN);
if (gtk_boolean_accessible_value_get (is_hidden))
return;
}
GVariantBuilder builder = G_VARIANT_BUILDER_INIT (G_VARIANT_TYPE ("(" ITEM_SIGNATURE ")"));
collect_object (self, &builder, context);
@@ -194,6 +206,18 @@ static void
emit_remove_accessible (GtkAtSpiCache *self,
GtkAtSpiContext *context)
{
GtkATContext *at_context = GTK_AT_CONTEXT (context);
/* If the context is hidden, we don't need to update the cache */
if (gtk_at_context_has_accessible_state (at_context, GTK_ACCESSIBLE_STATE_HIDDEN))
{
GtkAccessibleValue *is_hidden =
gtk_at_context_get_accessible_state (at_context, GTK_ACCESSIBLE_STATE_HIDDEN);
if (gtk_boolean_accessible_value_get (is_hidden))
return;
}
GVariant *ref = gtk_at_spi_context_to_ref (context);
g_dbus_connection_emit_signal (self->connection,