Commit Graph

67644 Commits

Author SHA1 Message Date
Matthias Clasen
137eef6465 Fix get_closest_point for rectangles
This was still returning wrong offsets for one of the four
sides. Add a testcase for rectangles and circles to prevent
this happening again in the future.
2020-12-12 10:05:38 -05:00
Benjamin Otte
dfb25771a7 xxx path)_fill 2020-12-11 01:42:17 +01:00
Benjamin Otte
b286b04b7d testsuite: Add tests for the dasher 2020-12-11 01:42:17 +01:00
Benjamin Otte
22aa12ade5 path: Add a foreach function that dashes a path 2020-12-11 01:42:17 +01:00
Benjamin Otte
79ba157664 path: Deal with non-uniformness of progress parameter
The progress is non-uniform, so simple translation of progress doesn't work.
So check if larger and smaller values inch closer towards minimal distance.
2020-12-10 20:18:05 +01:00
Benjamin Otte
c21c63c357 path: Always decompose conics into at least 2 segments
Conics are evil in that their parameter skews towards the center, and if
it's a very flat conic (weight almost equal to 0), then we'd approximate
it with a single segment and not subdivide, which would cause the
parameter to be wildly off around 0.25 or 0.75.

And that would cause offset calculations to fail.
2020-12-10 20:18:05 +01:00
Matthias Clasen
78f04ae486 testsuite Add curve tangent tests 2020-12-10 20:18:05 +01:00
Benjamin Otte
bd4dcc54fb testsuite: Add a test for the conic that got us segment() 2020-12-10 20:18:05 +01:00
Benjamin Otte
580d3057ce path: Add gsk_curve_segment()
Using split() twice with scaled t values does not work with conics.
2020-12-10 20:18:05 +01:00
Benjamin Otte
0060734103 testsuite: Add a test for gsk_curve_decompose() 2020-12-10 20:18:05 +01:00
Benjamin Otte
95ce8aafb4 testuite: Add tests for gsk_curve_get_tangent() 2020-12-10 20:18:05 +01:00
Matthias Clasen
0603bc2f45 testuite: Add tests for gsk_curve_get_point()
Add a few tests for gsk_curve_get_point().

Since GskCurve is not public api, we add gskcurve.c
as source to the test binary.
2020-12-10 20:18:05 +01:00
Benjamin Otte
07864c3070 curve: Split eval() into get_point() and get_tangent()
That's more in line with the get_start/end_point/tangent() functions.

Plus, those calls are independent and we usually want one or the other.
2020-12-10 20:18:05 +01:00
Matthias Clasen
95d5b9a057 Add gsk_curve_get_{start,end}_tangent
Add a way to get the tangents at the start and end of the curve.
This will be used in stroking.
2020-12-10 20:18:05 +01:00
Benjamin Otte
d5fe88a787 testsuite: Add conics to the random paths 2020-12-10 20:18:05 +01:00
Benjamin Otte
343324c205 path: Add GskCurve
GskCurve is an abstraction for path operations. It's essentially a
collection of vfuncs per GskPathOperation.

GskStandardContour has been ported to use it where appropriate.
2020-12-10 20:18:05 +01:00
Benjamin Otte
12dde7b4a1 path: Introduce gskpathop
A gskpathop is a pointer to a graphene_point_t* with the low bits used
to encode the GskPathOperation. It's an easy way to introduce API for
operations.

So far it's just used to replace GskStandardOperation.
2020-12-10 20:18:05 +01:00
Benjamin Otte
c07afdf1d7 WIP: css: Replace border rendering code with GskPath
The weight is wrong still, I need to compute the correct one to get real
45deg circle corners and not just roughly correct ones.
2020-12-10 20:18:05 +01:00
Benjamin Otte
7959ed96e2 WIP: pathbuilder: Add gsk_path_builder_add_rounded_rect()
It works, but does not use a custom contour yet.
2020-12-10 20:02:13 +01:00
Benjamin Otte
43360a1cfa path: Add conic curves
So far this just adds the API, if you use it, you'll get lots of
g_warnings().

This will be fixed in future commits.
2020-12-08 21:33:46 +01:00
Benjamin Otte
22753c685e path: Rename to gtk_path_builder_add_segment()
It's about bulding paths, not about measuring them.
2020-12-06 18:54:01 +01:00
Benjamin Otte
40ae74e03d path: Split contours into their own file
I'm not sure I want to keep all contours in one file, but for now that's
how it is.
2020-12-06 18:54:01 +01:00
Benjamin Otte
95b71d47c9 path: Make all private contour APIs take a GskContour
... instead of a path, index tuple.
2020-12-06 18:54:01 +01:00
Benjamin Otte
cfd8855676 stroke: Add support for dashes
... and hook it up in the node parser and for Cairo rendering.
2020-12-06 18:54:01 +01:00
Matthias Clasen
7c7bb31d93 gsk: Implement parsing fill and stroke nodes
Make serialization and deserialization work for stroke and
fill nodes.
2020-12-06 18:54:01 +01:00
Benjamin Otte
a0c9e33865 path: Add flags to gsk_path_foreach()
This way we can default to the siplest possible foreach() output - like
cairo_copy_path_flat() decomposing everything into lines - and add flags
to get more and more fancy.

This will be useful to have conics automatically decomposed for Cairo
drawing or if we want to add more line types in the future.
2020-12-06 18:54:01 +01:00
Benjamin Otte
dccec4ced2 testsuite: Add an in_fill() test 2020-12-06 18:54:01 +01:00
Matthias Clasen
8f3f16d251 Implement gsk_path_measure_in_fill
Implement this in the obvious way, using the decomposed form
of standard contours. Since the decomposed form is part of the
measure object, this api moves from gsk_path_in_fill to
gsk_path_measure_in_fill.
2020-12-06 18:54:01 +01:00
Benjamin Otte
d0ce83e853 testsuite: Add a parsing test
This test includes an implementation of a gsk_path_equal() func with
a tolerance that is necessary because parsing does not always work
100% exactly due to floating point rounding, so we can't just
compare the to_string() output.
2020-12-06 18:54:01 +01:00
Matthias Clasen
91dd2e449e path: Special-case rects and circles
Write out the commands for rects and circles in a special
way, and add code in the parser to recognize this, so we
can successfully round-trip these through the SVG path format.

The special way - for people who want to use it for debugging -
for now is that we use uppercase "Z" to close standard paths, but
lowercase "z" to close our special paths.

A test is included, but the random path serializations should take care
of it, too.
2020-12-06 18:54:01 +01:00
Matthias Clasen
6ff7c67c67 path: Fix serialization for circles
The svg A can not do a full circle, since it is a two point
parametrization - if the start and end point are the same,
it draws nothing. So, use two arcs.
2020-12-06 18:54:01 +01:00
Benjamin Otte
de1213cbb2 testsuite: Add librsvg path tests 2020-12-06 18:54:01 +01:00
Matthias Clasen
217921ff22 path: Implement gsk_path_parse
Implement the SVG path syntax to read back the strings
that we generate when serializing paths. The tests for
this code are taken from librsvg.

This includes an elliptical arc implementation according
to the SVG spec. The code is mostly taken from librsvg,
but pretty directly follows the SVG spec implementation
notes. We don't export this, since the parametrization
is inconvenient. We do want an arc_to API, but
these are not the arcs we are looking for.
2020-12-06 18:54:01 +01:00
Matthias Clasen
13153e4b30 path: Implement SVG arcs
This is elliptical arc implementation according to the SVG spec.
The code is mostly taken from librsvg, but pretty directly
follows the SVG spec implementation notes.

We don't export this, since the parametrization is inconvenient.
We do want an arc_to API, but these are not the arcs we are
looking for.

It will be used in parsing SVG path syntax.
2020-12-06 18:54:01 +01:00
Matthias Clasen
1eca63e442 stroke: Add miter limit
Add a miter limit to GskStroke. This will be needed to
fully implement line joins.

Also introduce the GSK_LINE_JOIN_MITER_CLIP value,
following SVG 2.0. cairo does not have it, so translate
it to plain miter when using cairo.
2020-12-06 18:54:01 +01:00
Matthias Clasen
2ed55da45c Documentation typo fixes 2020-12-06 18:54:01 +01:00
Benjamin Otte
ab77041437 testsuite: Add relative path functions
They're making the paths slightly weirder, but they test public API, so
woohoo!
2020-12-06 18:54:01 +01:00
Benjamin Otte
1ef2a39c4d pathbuilder: Add relative path commands
And gsk_path_builder_get_current_point().

They will be needed by the string parser.
2020-12-06 18:54:01 +01:00
Benjamin Otte
bccada91b6 path: Add GSK_CIRCLE_POINT_INIT() to initialize points on the circle
This is just splitting out a commonly done operation into a macro.
2020-12-06 18:54:01 +01:00
Benjamin Otte
bed254cc7a pathbuilder: Redo semantics for starting curves
We now always have a "current point" which is either the last point an
operation was made to, or (0, 0) if no drawing operation has
been made yet.

Adding a contour of any kind to the builder will always update the
current point to that contour's end point.
2020-12-06 18:54:00 +01:00
Benjamin Otte
bb224682c1 xxx: demo 2020-12-06 18:53:24 +01:00
Benjamin Otte
8e2f90c887 path: Split GskPathBuilder into its own file
... and add missing API docs.
2020-12-06 18:53:17 +01:00
Benjamin Otte
705617a6d5 testsuite: Add a test using get_point() and get_closest_point() 2020-12-06 18:51:55 +01:00
Benjamin Otte
bc019bd1fc testsuite: Add a test for get_point() 2020-12-06 18:51:55 +01:00
Benjamin Otte
c9edcb1009 testsuite: Update create_random_path()
1. Allow specifying the max number of contours
2. Be smarter about creating the paths:
   With 10% chance, create a "weird" path like the empty one or only
   points or things like that.
   Otherwise create a bunch of contours, with 2/3 a standard contour,
   with 1/3 a predetermined one.
2020-12-06 18:51:55 +01:00
Benjamin Otte
967968fb0b gtk-demo: Add cute maze demo 2020-12-06 18:51:55 +01:00
Benjamin Otte
9e7d3b4473 testsuite: Add tests for gsk_path_measure_get_closest_point() 2020-12-06 18:51:54 +01:00
Benjamin Otte
5819bfeca7 path: Add gsk_path_measure_get_closest_point()
... and gsk_path_measure_get_closest_point_full().

Those 2 functions allow finding the closest point on a path to a given
point.
2020-12-06 18:51:54 +01:00
Benjamin Otte
e611becb9f spline: Use Skia's tolerance checks
This avoids measuring being too far off (it's still off, but it's less
than a percent now.
2020-12-06 18:51:54 +01:00
Benjamin Otte
541f7aa2bb testsuite: Add tests for gsk_path_measure_add_segment() 2020-12-06 18:51:54 +01:00