Commit Graph

32802 Commits

Author SHA1 Message Date
Kalev Lember
25cabe3945 gtkroundedbox: Fix a compiler warning
Use the correct enum type.
2013-01-03 18:01:23 -05:00
Kalev Lember
2e9e739111 gtkliststore: Add explicit braces to avoid dangling else
Otherwise the following else becomes attached to the wrong if.
2013-01-03 18:00:33 -05:00
Matthias Clasen
72b8e937d1 Add a missing va_end call
va_copy must be matched with va_end.
2013-01-03 18:00:09 -05:00
Matthias Clasen
c705d2df60 Avoid unreachable code
Reestablish an else that went missing in commit 5ff328d2. Without
it, the return is reached unconditionally, and the code behind
it is dead.
2013-01-03 18:00:04 -05:00
Matthias Clasen
ac35a00a5c Don't return prematurely
This code was clearly meant to return _after_ the loop.
Don't put the return inside the loop body, then.
2013-01-03 17:59:58 -05:00
Matthias Clasen
cea2b80f40 GtkAboutDialog: Initialize a variable
Coverity complains about it being uninitialized, otherwise.
2013-01-03 17:59:52 -05:00
Matthias Clasen
aaea19ee91 GtkNotebook: Clarify a switch statement
We were intentionally falling through here, this commit
just adds comments to make that explicit.
2013-01-03 17:59:46 -05:00
Matthias Clasen
347f4aa54b GtkCellAccessible: Add missing break statements
This switch was entirely breakless. Amazing accessibility code,
found by Coverity.
2013-01-03 17:59:40 -05:00
Matthias Clasen
f294563685 GtkExpander: Clarify a nested switch
This code confused Coverity into thinking we were falling through,
when we were not. Add a few explicit breaks to clear that up.
2013-01-03 17:59:26 -05:00
Matthias Clasen
b85098c819 Add a forgotten break in render_border
The GTK_BORDER_STYLE_DOUBLE case was clearly not meant to
fall through to the subsequent cases, yet it did.
Found by Coverity.
2013-01-03 17:59:19 -05:00
Matthias Clasen
77e2df6145 GtkIconViewAccessible: Fix a copy-paste error
Don't access vadjustment after checking hadjustment for
not being NULL. Found by Coverity.
2013-01-03 17:59:11 -05:00
Matthias Clasen
ed7d5cdba3 GtkActionHelper: Fix a copy-paste error
The code clearly meant to reset action->active here.

This was found by Coverity.
2013-01-03 17:59:02 -05:00
Matthias Clasen
c76ca484d1 gtk_css_value_bg_size_equal: actually compare contain values
Due to a copy-paste error, the code failed to compare the
contain members of value1 and value2.

This was found by Coverity.
2013-01-03 17:58:54 -05:00
Matthias Clasen
5d55191880 Don't check the same crossing mode twice
This was broken since commit b2aaa94 in 2008. Its commit message
clearly states that the intention was to check for GTK_GRAB,
GTK_UNGRAB and STATE_CHANGED. Lets do that, then.

This was found by Coverity.
2013-01-03 17:58:45 -05:00
Matthias Clasen
35079629a5 GtkLabel: Fix a pointless expression
Clearly, what was meant here was that we create a new attribute
list if either of the input attribute lists are non-NULL.
This was found by Coverity.
2013-01-03 17:53:24 -05:00
Christophe Fergeau
a568991866 Sanitize memory handling in cups_request_printer_list_cb
gtk+ was trying to display already freed strings, leaking memory,
...I noticed this because I was getting weird blinking characters
as the status of my cups printers, and valgrind confirmed something
was wrong.

https://bugzilla.gnome.org/show_bug.cgi?id=683072
2013-01-03 17:52:47 -05:00
Jasper St. Pierre
dc35b2770b gtkversion.h.in: Put the documentation inside the header guards
This fixes a warning with gobject-introspecion scanning
2013-01-03 17:49:24 -05:00
Gheyret Kenji
46667db696 updated uyghur translation.
Signed-off-by: Gheyret Kenji <gheyret@gmail.com>
2012-12-23 12:13:46 +09:00
Gheyret Kenji
ed2ce93465 updated Uyghur translation
Signed-off-by: Gheyret Kenji <gheyret@gmail.com>
2012-12-23 12:06:42 +09:00
Benjamin Otte
984e2e41dd roundedbox: Fix copy-paste error
y coordinates don't care about the right value, they want bottom.
2012-12-21 16:29:31 +01:00
Shantha kumar
0b141481d2 Tamil translation updated 2012-12-19 14:59:06 +05:30
Shantha kumar
219a8448f4 Tamil translation updated 2012-12-19 14:58:16 +05:30
Michael Natterer
a398c1917a quartz: make setting_same_owner member of GtkClipboardOwner @public
to fix the build, thanks to parafin for the patch.
(cherry picked from commit e3e055f855)
2012-12-17 22:22:58 +01:00
Cosimo Cecchi
8a34428e00 csskeyframes: unref GtkCssValues when free-ing
We assume a reference to all the GtkCssValues we store, so we need to
release it when free-ing.
2012-12-17 17:59:52 +01:00
Stéphane Démurget
583a7bf189 gtkmenushell: Fix an endless loop on focus cycle
This is a simple fallout from sealing gtkmenushell, which only appears
when F10 or Shift-F10 is used in a submenu.

https://bugzilla.gnome.org/show_bug.cgi?id=690266
2012-12-17 16:07:44 +01:00
Christian Kirbach
feacd258de Updated German translation (bug 690302) 2012-12-17 01:41:58 +01:00
Michael Natterer
f89b149eeb gtk: fix scrolling in modal dialogs when event_widget is insensitive
When checking for modal grabs in gtk_main_do_event(), forward
GDK_SCROLL events to event_widget, even if it is insensitive.
(cherry picked from commit 343f1706bd)
2012-12-14 15:54:43 +01:00
Chun-wei Fan
136c719997 Bug 668239 - texts disappear when notebook switch page at zh_CN locate
In gtkimcontextime.c, use gdk_win32_window_get_impl_hwnd() to get to
the impl's existing native window instead of GDK_WINDOW_HWND() which
implicitly ensures a native window for the widget itself. This seems
to work around whatever GDK problem with native subwindows and fixes
the bug.

This is based on Michael Natterer's fix for gtk-2-24.
2012-12-13 11:03:01 +08:00
Michael Natterer
9d7461370c quartz: fix crash in the recent clipboard "fix", and really fix it
We must not release the GtkClipboardOwner in pasteboardChangedOwner
becaue we don't own a reference to ourselves (NSPasteboard does).
Instead, release the owner right after setting it, transferring
ownership to NSPasteboard

Also, fix repeated setting of the same owner by keeping the
owner around in GtkCLipboard, and re-use it if "user_data"
doesn't change. To avoid clipboard_unset()ting our own contents
in the process, add an ugly "setting_same_owner" boolean to
GtkClipboardOwner, set it during re-setting the same owner,
and avoid calling clipboard_unset() from pasteboardChangedOwner
if it's TRUE.
(cherry picked from commit 4a8df7a33c)
2012-12-07 12:33:39 +01:00
Benjamin Otte
c3508c9fa3 stylecontext: Always recompute font
This is necessary  because values in a GtkCssComputedValues can change
now. So if the font-size is inherited or animated, the cached value will
be outdated.
2012-12-05 18:43:56 +01:00
Marek Kasik
39bc5d3b66 printing: Call mark_printer_active() with correct parameters
Revert the second part of the commit
6ad6f719c6. mark_printer_active()
was called without its second parameter in g_list_free_full().
2012-12-04 15:50:13 +01:00
Michael Natterer
0b7d04fcdd Bug 626499 - GtkClipboard unnotified on change of OS X pasteboard owner
pasteboardChangedOwner is not called as reliably as we'd want to get it,
so keep track of [pasteboard changeCount] and drop clipboard ownership
when a change happened. Also better unset the clipboard content redundantly
in a few places rather than missing one, and reorder the code in
gtk_clipboard_set_contents() so that the new aggressive unsetting
won't unset the clipboard under our feet when we call
[pasteboard declareTypes].
(cherry picked from commit f2b74db5dc)
2012-12-04 14:44:05 +01:00
Michael Natterer
423f97c3af gtk: convert keyvals to unicode before committing to the imcontext
(cherry picked from commit 9eea724e3b)
2012-11-30 15:13:00 +01:00
Michael Natterer
4d474f4613 gtk: add more OSX special casing for the deadacute and deaddoubleacute keys
So " plus foo prduces foo-with-diaereses and ' plus c produces
c-with-cedilla.
(cherry picked from commit f619f91a8f)
2012-11-30 15:12:37 +01:00
Alan McGovern
dcc78e96d8 Fix broken function pointer declarations on windows
Both flashing a window and setting the window opacity were using
incorrect declarations for function pointers. They were missing the
WINAPI annotation as defined in windows.h. As a result, the stack
could be corrupted when these functions were invoked.

Fixes https://bugzilla.gnome.org/show_bug.cgi?id=689235
(cherry picked from commit 5637ef1f97)
2012-11-29 15:08:37 +01:00
Michael Natterer
200aab2f7f quartz: add mountain lion as version 8 to enum GdkOSXVersion
Also use GDK_OSX_UNSUPPORTED instead of 0 in gdk_quartz_osx_version().
(cherry picked from commit 9644e910a8)
2012-11-29 15:02:27 +01:00
Michael Natterer
cfe1b0263f quartz: call Gestalt() only once per session in gdk_quartz_osx_version()
Thanks to Paul Davis for pointing this out.
(cherry picked from commit d6533ffc44)
2012-11-29 15:02:19 +01:00
Benjamin Berg
885d028c20 Use the ppd groups "name" instead of "text" (bug #687065)
This commit fixes a regression caused by a patch to remove Cups 1.2
ifdefs. This resulted in the "installable options" to appear in the
print dialog.
2012-11-29 10:08:31 +01:00
Piotr Drąg
474d742a0e Updated POTFILES.skip 2012-11-26 22:43:23 +01:00
David King
1837787ce6 docs: Add gtk-doc comment for GtkTreeRowReference
https://bugzilla.gnome.org/show_bug.cgi?id=93381
2012-11-26 14:13:22 +00:00
Benjamin Otte
94fecf591a reftests: Add reftest for broken fixed height mode
https://bugzilla.gnome.org/show_bug.cgi?id=687816
2012-11-26 00:24:34 +01:00
Benjamin Otte
335ede0f83 treeview: Delay computing fixed height
In the setter, we only set fixed height mode and queue a revalidation of
the row heights.

https://bugzilla.gnome.org/show_bug.cgi?id=687816
2012-11-26 00:24:27 +01:00
David King
1dbf309359 docs: gtk_file_chooser_get_filename() returns absolute paths
The documentation for gtk_file_chooser_get_filenames() states that the
returned filenames are absolute paths, and uses g_file_get_path() to
construct the filename. The same function is used to construct the
filename in gtk_file_chooser_get_filename(), so it should also return
absolute paths.

https://bugzilla.gnome.org/show_bug.cgi?id=371034
2012-11-24 19:58:40 +00:00
David King
16687615ed docs: Fix typo in gtk_tree_view_set_tooltip_column comment
https://bugzilla.gnome.org/show_bug.cgi?id=688884
2012-11-22 22:25:43 +00:00
David King
1bad36ae1d docs: Improve GtkTreeModel iteration pattern
Iterating over the model in this way means that use of continue is less
error-prone, as the increment is part of the loop construct.

https://bugzilla.gnome.org/show_bug.cgi?id=548793
2012-11-22 21:34:58 +00:00
David King
92f536b907 docs: Correct GtkWidget::scroll-event mask documentation
Since GTK+ 3.3.18, GDK_SCROLL_MASK has been used as the mask for scroll
events. Update the documentation to reflect this.

https://bugzilla.gnome.org/show_bug.cgi?id=677339
2012-11-22 21:34:57 +00:00
Martin Pitt
61cb32fbf9 aboutdialog: Fix add_credit_section() annotations
The people argument is an array.

https://mail.gnome.org/archives/python-hackers-list/2012-November/msg00010.html
2012-11-22 14:57:33 +01:00
Michael Natterer
07d04fb0f8 gtk: don't let insensitive children eat scroll events when bubbling down
When event capturing is enabled, stop propagating scroll events
at insensitive widgets, but don't handle them (don't return TRUE),
so they can bubble up again and reach their handling widgets.
(cherry picked from commit 2d9454363f)
2012-11-22 13:54:55 +01:00
Wouter Bolsterlee
3a03638e2e Updated Dutch translation 2012-11-22 12:02:09 +01:00
Sweta Kothari
53dc151e9f Updated gujarati file 2012-11-22 13:01:43 +05:30