Commit Graph

59769 Commits

Author SHA1 Message Date
Benjamin Otte
41c93153bf listview: Track focus movements and update selection
When focus moves via tab/arrow, we need to select the new item.
2019-12-13 06:11:56 +01:00
Benjamin Otte
8eee9897a8 listview: Implement activation
- a GtkListview::activate signal
- a GtkListItem::activatable property
- activate list items on double clicks and <Enter> presses
2019-12-13 06:11:56 +01:00
Benjamin Otte
1d2b8af320 treeexpander: Implement input support
This implements all the keybindings from GtkTreeView that can be
supported.

It does not implement expand-all, because supporting that means
causing the TreeListModel to emit lots of create_model vfuncs which in
turn would cause many items-changed signal which in turn would cause
many signal handlers to run which in turn would make "expand-all" very
reentrant, and I'm uneasy about supporting that.

For the mouse, just add a click gesture to the expander icon that toggles
expanded state.
2019-12-13 06:11:56 +01:00
Benjamin Otte
e5a4ea71a4 listitem: Change focus handling
Focus in the listitem now works like this:
1. If any child can take focus, do not ever attempt
   to take focus.
2. Otherwise, if this item is selectable or activatable,
   allow focusing this widget.

This makes sure every item in a list is focusable for
activation and selection handling, but no useless widgets
get focused and moving focus is as fast as possible.
2019-12-13 06:11:56 +01:00
Benjamin Otte
6a496603bd popover: Remove unneeded vfunc
The vfunc is identical to the GtkWidget implementation it replaces. So
just keep using that one.
2019-12-13 06:11:56 +01:00
Benjamin Otte
36621a7f7d inspector: Make the recorder node list use a ListView
It's quite a bit faster now, but the code is also a bit more awkward.

Pain points:

- GtkTreeListModel cannot be created in UI files because it needs
  a CreateModelFunc.
  Using a signal for this doesn't work because autoexpand wants to
  expand the model before the signal handler is connected.

- The list item factory usage is still awkward. It's bearable here
  because the list items are very simple, but still.
2019-12-13 06:11:56 +01:00
Benjamin Otte
ae86e6fe54 inspector: Use a GtkTreeExpander in the object tree 2019-12-13 06:11:56 +01:00
Benjamin Otte
9d1509671b inspector: Use a treeexpander in the recorder 2019-12-13 06:11:56 +01:00
Benjamin Otte
bd426eb89d demo: Add a GSettings tree demo
It is meant to look somewhat like dconf-editor when it is done.

So far, it's just a list.
2019-12-13 06:11:56 +01:00
Benjamin Otte
be96154c85 Add GtkTreeExpander
This is a container widget that takes over all the duties of tree
expanding and collapsing.
It has to be a container so it can capture keybindings while focus is
inside the listitem.

So far, this widget does not allow interacting with it, but it shows the
expander arrow in its correct state.

Also, testlistview uses this widget now instead of implementing
expanding itself.
2019-12-13 06:11:56 +01:00
Benjamin Otte
5d4dc52ff5 gridview: Actually do something
Implement measuring and allocating items - which makes the items appear
when drawing and allows interacting with the items.

However, the gridview still does not allow any user interaction
(including scrolling).
2019-12-13 06:11:56 +01:00
Benjamin Otte
d45422328a listview: Pass the CSS name of listitems to the manager
... instead of hardcoding "row".
2019-12-13 06:11:56 +01:00
Benjamin Otte
007c70310b gridview: Implement GtkOrientable
Again, this is just the skeleton, because the Gridview does nothing yet.
2019-12-13 06:11:56 +01:00
Benjamin Otte
9bf3725d20 gridview: Add factory handling
Just copy the listview APIs.

Code still doesn't do anything with it.
2019-12-13 06:11:56 +01:00
Benjamin Otte
9dc88eed5a listview: Expose GtkListItemFactory APIs
Due to the many different ways to set factories, it makes sense to
expose them as custom objects.

This makes the actual APIs for the list widgets simpler, because they
can just have a regular "factory" property.

As a convenience function, gtk_list_view_new_with_factory() was added
to make this whole approach easy to use from C.
2019-12-13 06:11:56 +01:00
Benjamin Otte
1612741f32 textview: Make cursor work when blinking is disabled 2019-12-13 06:11:56 +01:00
Benjamin Otte
9f35883ee1 gtk-demo: Add a rough start at a Weather demo
This demos a horizontal listview.
2019-12-13 06:11:56 +01:00
Benjamin Otte
7c3db57a59 listview: Implement GtkOrientable 2019-12-13 06:11:56 +01:00
Benjamin Otte
ddf35d09e0 tests: Add a rough form of multiselection
Just store a "filechooser::selected" attribute in the GFileInfo if
the file is meant to be selected.
2019-12-13 06:11:56 +01:00
Benjamin Otte
37906a099b listview: Implement extending selections
Shift-clicking to extend selections now also works, imitating the
behavior of normal clicking and Windows Explorer (but not treeview):

1. We track the last selected item (normally, not via extend-clicking).

2. When shift-selecting, we modify the range from the last selected item
   to this item the same way we modify the regular item when not using
   shift:

2a. If Ctrl is not pressed, we select the range and unselect everything
    else.

2b. If Ctrl is pressed, we make the range have the same selection state
    as the last selected item:
    - If the last selected item is selected, select the range.
    - If the last selected item is not selected, unselect the range.
2019-12-13 06:11:56 +01:00
Benjamin Otte
bd42d344a3 listview: Add list.scroll_to_item action
The action scrolls the given item into view.

Listitems activate this action when they gain focus.
2019-12-13 06:11:56 +01:00
Benjamin Otte
233db07715 testlistview: Load icons async
Speeds up loading by 4x, because out of view icons aren't loaded
anymore.
2019-12-13 06:11:56 +01:00
Benjamin Otte
84e1a21e05 testlistview: Port to directory list 2019-12-13 06:11:56 +01:00
Benjamin Otte
3f2f7bf074 listitemfactory: Add a factory for ui files
Reuse <template> magic to initialize GtkListItems. This feels
amazingly hacky, but it also amazingly worked on the first try.
2019-12-13 06:11:56 +01:00
Benjamin Otte
8b67057c19 listitemfactory: Split implementation out
.. into gtkfunctionslistitemfactory.c

Now we can add a different implmenetation.
2019-12-13 06:11:56 +01:00
Benjamin Otte
e5a5f2bd90 listitemfactory: vfuncify
No functional changes other than a new indirection.
2019-12-13 06:11:56 +01:00
Benjamin Otte
aea62f9f77 listitemfactory: Sanitize APIs
Make sure the APIs follow a predictable path:

setup
  bind
    rebind/update (0-N times)
  unbind
teardown

This is the first step towards providing multiple different factories.
2019-12-13 06:11:56 +01:00
Benjamin Otte
b22acbcff6 listview: Add gtk_list_view_set_show_separators()
Do the same thing that GtkListBox does in commit
0249bd4f8a
2019-12-13 06:11:56 +01:00
Benjamin Otte
dfbcc9c50d listitemmanager: Add trackers
... and replace the anchor tracking with a tracker.

Trackers track an item through the list across changes and ensure that
this item (and potentially siblings before/after it) are always backed
by a GtkListItem and that if the item gets removed a replacement gets
chosen.

This is now used for tracking the anchor but can also be used to add
trackers for the cursor later.
2019-12-13 06:11:56 +01:00
Benjamin Otte
c1e1e0e683 listitemmanager: Simplify
Remove a bunch of API from the headers that isn't used anymore and then
refactor code to not call it anymore.

In particular, get rid of GtkListItemManagerChange and replace it with a
GHashTable.
2019-12-13 06:11:56 +01:00
Benjamin Otte
bfb3da854d gridview: Implement GtkScrollable
We can now scroll all the nothing we display.

We also clip it properly.
2019-12-13 06:11:56 +01:00
Benjamin Otte
b077952901 listitemmanager: Move list of listitems here
All the listview infrastructure moved with it, so the next step is
moving that back...
2019-12-13 06:11:56 +01:00
Benjamin Otte
f1b300324e wayland: Remove function declaration for nonexisting function 2019-12-13 06:11:56 +01:00
Benjamin Otte
6a32109aed gridview: Add API for setting number of columns
The API isn't used yet.
2019-12-13 06:11:56 +01:00
Benjamin Otte
bd5562fe89 gtk: Add a GtkGridView skeleton 2019-12-13 06:11:56 +01:00
Benjamin Otte
0556f13532 listitem: Add a press gesture to select the item
This is implemented by using actions, which are a neat trick to get to
allow the ListItem to call functions on the ListView without actually
needing to be aware of it.
2019-12-13 06:10:08 +01:00
Benjamin Otte
34e6840d0a listview: Add initial support for displaying selections 2019-12-13 06:10:08 +01:00
Benjamin Otte
922991a3d7 listview: Reset listitems' CSS animations when rebinding
This way, newly displayed rows don't play an unselect animation (text
fading in) when they are unselected, but the row was previously used for
a selected item.
2019-12-13 06:10:08 +01:00
Benjamin Otte
37e4a0eca9 listview: Add selection properties to ListItem
This just brings the infrastructure into place, we're not using the
properties yet.
2019-12-13 06:10:08 +01:00
Benjamin Otte
345a18b1a1 listview: Try to keep the list items in order when scrolling
Instead of just destroying all items and then recreating them (or even
hide()ing and then show()ing them again (or even even repositioning
them in the widget tree)), just try to reust them in the order they are.

This works surprisingly well when scrolling and most/all widgets
just moved.
2019-12-13 06:10:08 +01:00
Benjamin Otte
6a3a936c4e listlistmodel: Add gtk_list_list_model_item_moved()
Use it to fix a case that just said g_warning ("oops").

Apparently I had forgotten the case where a container moved a child
in the widget tree.
2019-12-13 06:10:08 +01:00
Benjamin Otte
4e98bd33a5 listitemmanager: Switch from "insert_before" to "insert_after" argumnet
We reorder widgets start to end, so when reusing a list item, we
correctly know the previous sibling for that list item, but not the
next sibling yet. We just know the widget it should ultimately be in
front of.
So we can do a more correct guess of the list item's place in the widget
tree if we think about where to place an item like this.

Actually using this change will come in the next commit.
2019-12-13 06:10:08 +01:00
Benjamin Otte
2d89a8380f testlistview: Create widgets only once
Previously, we were recreating all widgets every time the list item was
rebound, which caused a lot of extra work every time we scrolled.

Now we keep the widgets around and only set their properties again when
the item changes.
2019-12-13 06:10:08 +01:00
Benjamin Otte
d3be13875d testlistview: Show the row number
Always show the current row. This is mostly useful for debugging, not
for beauty.
2019-12-13 06:10:08 +01:00
Benjamin Otte
40b8b9742e listview: Only allocate necesary rows
This is the big one.

The listview only allocates 200 rows around the visible row now.
Everything else is kept in ListRow instances with row->widget == NULL.

For rows without a widget, we assign the median height of the child
widgets as the row's height and then do all calculations as if there
were widgets that had requested that height (like setting adjustment
values or reacting to adjustment value changes).

When the view is scrolled, we bind the 200 rows to the new visible area,
so that the part of the listview that can be seen is always allocated.
2019-12-13 06:10:08 +01:00
Benjamin Otte
c06fee7460 listview: Change anchor handling again
The anchor is now a tuple of { listitem, align }.

Using the actual list item allows keeping the anchor across changes
in position (ie when lists get resorted) while still being able to fall
back to positions (list items store their position) when an item gets
removed.

The align value is in the range [0..1] and defines where in the visible
area to do the alignment.
0.0 means to align the top of the row with the top of the visible area,
1.0 aligns the bottom of the widget with the visible area and 0.5 keeps
the center of the widget at the center of the visible area.
It works conceptually the same as percentages in CSS background-position
(where the background area and the background image's size are matched
the same way) or CSS transform-origin.
2019-12-13 06:10:08 +01:00
Benjamin Otte
7d152619bc listview: Change how binding is done
We now don't let the functions create widgets for the item from the
listmodel, instead we hand out a GtkListItem for them to add a widget
to.

GtkListItems are created in advance and can only be filled in by the
binding code by gtk_container_add()ing a widget.
However, they are GObjects, so they can provide properties that the
binding code can make use of - either via notify signals or GBinding.
2019-12-13 06:10:08 +01:00
Benjamin Otte
c65be391db listitem: Add gtk_list_item_get_position()
Also refactor the whole list item management yet again.

Now, list item APIs doesn't have bind/unbind functions anymore, but only
property setters.

The item factory is the only one doing the binding.
As before, the item manager manages when items need to be bound.
2019-12-13 06:10:08 +01:00
Benjamin Otte
d516dd523e tests: Make animating listview do random resorts 2019-12-13 06:10:08 +01:00
Benjamin Otte
e431cd720f listview: Change change management
Add a GtkListItemManagerChange object that tracks all removed list
rows during an item-changed signal so they can be added back later.
2019-12-13 06:10:08 +01:00