Matthias Clasen
b694aef7a6
testsections: Print out the sections
...
This helps for debugging some situations.
2023-05-20 21:14:37 -04:00
Matthias Clasen
631ee08d9a
testsections: Warn on hscroll
...
Print out whenever the hadjustment value changes.
That makes it easier to catch situations where
vertical scrolling causes us to move horizontally
(ie jitter).
Note that this currently triggers even without
sections, so there's debugging work to be done.
2023-05-20 21:14:37 -04:00
Matthias Clasen
bbe9e9bcdd
testsections: Capitalize the header properly
2023-05-20 21:14:37 -04:00
Matthias Clasen
ff46f050f5
testsections: Make sections toggleable
...
Add a check button, so sections can be turned
on and off. This helps debugging the transitions.
2023-05-20 21:14:37 -04:00
Matthias Clasen
9a66ec81bf
testsections: Allow loading a word list
...
The code to load words from a list is copyied from
the words demo in gtk4-demo.
2023-05-20 20:51:43 -04:00
Matthias Clasen
e5f0e17378
testsections: A testbed for sections
...
Add a simple test client that lets us compare
and explore the section handling in listview
and gridview.
2023-05-20 20:51:43 -04:00
Matthias Clasen
c7d295dd9b
gridview: Copy section plumbing
...
Add a header factory, and implement prepare_section and
create_header_widget.
Allocating header and footer tiles properly will be
left to future commits.
2023-05-20 20:51:43 -04:00
Matthias Clasen
2e30806d42
listbase: Export gtk_list_base_dump_tiles privately
...
This is so we call it from gtkgridview.c to debug things.
2023-05-20 20:51:43 -04:00
Matthias Clasen
56907ad66f
listbase: Add headers and footers to tile debug
...
Use some shades of purple to show headers and
footers in the node dump for tiles.
2023-05-20 20:51:43 -04:00
Benjamin Otte
9cb94c1547
listbase: Add a debug keybinding
...
Ctrl-Shift-R (for rendernode, yay my creativity):
Creates a rendernode of the current tiles and dumps them into the
clipboard.
2023-05-20 20:51:43 -04:00
Matthias Clasen
ca744b925e
Merge branch 'list-tile-gc' into 'main'
...
Add gtk_list_item_manager_gc_tiles
See merge request GNOME/gtk!5995
2023-05-21 00:51:00 +00:00
Matthias Clasen
53c63673e4
gridview: Use gtk_list_item_manager_gc_tiles
...
This simplifies the code a bit.
2023-05-20 19:50:11 -04:00
Matthias Clasen
431458ed78
listview: Use gtk_list_item_manager_gc_tiles
...
This simplifies the code a bit.
2023-05-20 19:50:11 -04:00
Matthias Clasen
56cfef3544
testsuite: Use gtk_list_item_manager_gc_tiles
...
Use this new api instead of open-coding it.
Also, assert that it merges consecutive
multi-item tiles.
2023-05-20 19:50:11 -04:00
Matthias Clasen
e23358e09f
Merge branch 'matthiasc/for-main' into 'main'
...
Cosmetics
See merge request GNOME/gtk!5996
2023-05-20 23:22:56 +00:00
Matthias Clasen
833e1bdcf6
Cosmetics
...
Fix some typos.
2023-05-20 19:03:41 -04:00
Matthias Clasen
0091425729
listitemmanager: Stop exporting tile_gc
...
This function is now just used internally,
so make it static.
2023-05-20 18:59:16 -04:00
Matthias Clasen
b1c2a1c015
listitemmanager: Use gc_tiles
...
Replace an open-coded version of this function
with a call to gtk_list_item_manager_gc_tiles.
2023-05-20 18:59:16 -04:00
Matthias Clasen
31d03f9f26
Add gtk_list_item_manager_gc_tiles
...
This will allow us to simplify size allocation
code in listview and gridview.
2023-05-20 16:17:11 -04:00
Benjamin Otte
3beaf0962c
Merge branch 'drop-filler-tiles' into 'main'
...
Drop the FILLER tile type
See merge request GNOME/gtk!5993
2023-05-20 17:18:53 +00:00
Matthias Clasen
48e49b4c50
gridview: Update factories in set_factory
...
Call update_factories() so the children get their
factories properly updated.
This matches what GtkListView does.
2023-05-20 12:53:39 -04:00
Matthias Clasen
1d4f383ba5
Drop the FILLER tile type
...
It is not used anymore.
2023-05-20 12:28:19 -04:00
Matthias Clasen
8cb3e01eef
gridview: Stop using a filler tile
...
We can just use the footer to fill that space.
2023-05-20 12:28:19 -04:00
Matthias Clasen
42a0dcc7e4
gridview: Add an assertion
...
The want to use the footer tile at the end
to fill leftover space at the bottome right.
So lets assert that we actually dealing with
a footer tile, just in case something changes
in the future that might have us end up with
some other kind of tile.
2023-05-20 12:26:51 -04:00
Matthias Clasen
e9731fc99b
Add some tile helpers
2023-05-20 12:26:39 -04:00
Matthias Clasen
2890557236
Revert "gridview: GC tiles first"
...
This reverts commit e121a5ca6f .
The tile that was causing the critical in #5836
(what that commit was about) was a FILLER, and we
are getting rid of FILLER tiles here. Which will
avoid the issue in a more elegant way.
2023-05-20 12:25:33 -04:00
Matthias Clasen
43a22bb350
Cosmetics
...
Use the proper g_assert variant.
2023-05-20 07:39:21 -04:00
Matthias Clasen
cd9c277820
Merge branch 'ci-clang-build' into 'main'
...
ci: Add a clang build
See merge request GNOME/gtk!5987
2023-05-18 19:10:52 +00:00
Matthias Clasen
42a12f1788
ci: Add a clang build
...
This is meant to catch build errors with clang.
2023-05-18 14:39:46 -04:00
Matthias Clasen
5f39820729
cups: Silence a compiler warning
...
Bitfields should be unsigned int.
2023-05-18 14:39:46 -04:00
Matthias Clasen
c2a8620660
gsk: Mark some variables as unused
...
Hopefully that shuts up clang.
2023-05-18 13:29:28 -04:00
Asier Sarasua Garmendia
647d5e17c1
Update Basque translation
...
(cherry picked from commit a6931a66c5 )
2023-05-18 16:31:00 +00:00
Matthias Clasen
d87b9ee4c5
Merge branch 'matthiasc/for-main' into 'main'
...
roaring: Mark a variable as unused
See merge request GNOME/gtk!5990
2023-05-18 13:35:17 +00:00
Matthias Clasen
70ba00ae53
testsuite: Make this test compile
...
clang did not like this creative use of
strings at all. Rightfully so.
2023-05-18 08:40:50 -04:00
Matthias Clasen
c4fb473d4b
roaring: Mark a variable as unused
...
Otherwise clang complains.
2023-05-18 08:34:48 -04:00
Matthias Clasen
b4fbd74f98
Merge branch 'fina/scrolled-window-measure' into 'main'
...
scrolledwindow: Propagate child measure size whenever possible
Closes #5838
See merge request GNOME/gtk!5986
2023-05-18 12:26:05 +00:00
Fina Wilke
7fae0bc0de
scrolledwindow: Propagate child measure size whenever possible
...
In height-for-width and hscrollbar-policy = never, we can provide
the child with a proper for_size when measuring it. The same is true for
width-for-height and vscrollbar-policy = never.
This allows for accurately measuring the size of eg. wrapping labels.
2023-05-18 13:25:20 +02:00
Benjamin Otte
89b61eeec4
Merge branch 'listview-factory-leak' into 'main'
...
listview: Don't leak the factories
See merge request GNOME/gtk!5989
2023-05-17 18:57:28 +00:00
Matthias Clasen
e2492dd568
gridview: Don't leak the factory
2023-05-17 14:32:55 -04:00
Matthias Clasen
ca000287fc
listview: Don't leak the factories
2023-05-17 14:17:47 -04:00
Benjamin Otte
ff14fea672
Merge branch 'fix-gridview-critical' into 'main'
...
gridview: GC tiles first
Closes #5836
See merge request GNOME/gtk!5988
2023-05-17 17:04:43 +00:00
Matthias Clasen
e121a5ca6f
gridview: GC tiles first
...
Before checking that there are no tiles,
we need to gc any possibly leftover filler
tiles.
Fixes : #5836
2023-05-17 12:31:16 -04:00
Matthias Clasen
e79851502c
Merge branch 'pathbar-early-return-on-cancellation' into 'main'
...
pathbar: Fail setting the path on cancellation
Closes #5792
See merge request GNOME/gtk!5982
2023-05-17 10:15:26 +00:00
Matthias Clasen
0132ab046b
Merge branch 'matthiasc/for-main' into 'main'
...
Reduce pixbuf helpers
See merge request GNOME/gtk!5984
2023-05-17 10:14:44 +00:00
Matthias Clasen
c2ba1d69a1
Rename pixbuf utils to texture utils
...
That is what this is now.
2023-05-16 22:00:08 -04:00
Matthias Clasen
847739aed7
Reduce pixbuf helpers
...
Concentrate pixbuf handling in gdkpixbufutils.c.
2023-05-16 21:56:22 -04:00
Matthias Clasen
4d66598f31
Merge branch 'matthiasc/for-main' into 'main'
...
gsk: Cosmetics
See merge request GNOME/gtk!5983
2023-05-17 00:58:48 +00:00
Matthias Clasen
2ec1bd7248
Merge branch 'gl-renderer-more-defensive' into 'main'
...
gsk: Stop setting uniforms when we are out of batches
See merge request GNOME/gtk!5981
2023-05-17 00:29:40 +00:00
Benjamin Otte
646d1a8923
Merge branch 'wip/otte/ci-emergency' into 'main'
...
CI: Actually build our code
See merge request GNOME/gtk!5980
2023-05-17 00:19:06 +00:00
Matthias Clasen
4a8a6e9f70
gsk: Don't build unused functions
...
The only caller is #if 0 ed, so don't build
these functions.
2023-05-16 20:13:57 -04:00