Commit Graph

63630 Commits

Author SHA1 Message Date
Benjamin Otte
e515e880e7 listitemwidget: Add a private struct
I had to rename the item property to list_item anyway, so I could just
do the next step with it.
2020-05-29 19:46:32 -04:00
Benjamin Otte
0730eb70e1 listitemfactory: Simplify
Instead of 6 vfuncs, we now have 3 and rely on the factory keeping track
of what it needs to do.

We're doing lots of dancing from one object to another here, but this
will hopefully get simpler with further commits.
2020-05-29 19:46:32 -04:00
Benjamin Otte
e0b7c82fac listitemfactory: Reorganize vfuncs
Instead of bind/rebind/update/unbind, we now just have update, and the
factories get to interpret that in the way they want.
2020-05-29 19:46:32 -04:00
Benjamin Otte
82e93d9b2e listitem: Make this a GObject
This splits GtkListItem into 2 parts:

1. GtkListItem
   This is purely a GObject with public API for developers who want to
   populate lists. There is no chance to cause conflict with GtkWidget
   properties that the list implementation assumed control over and
   defines a clear boundary.
2. GtkListItemWidget
   The widget part of the listitem. This is not only fully in control of
   the list machinery, the machinery can also use different widget
   implementations for different list widgets like I inted to for
   GtkColumnView.
2020-05-29 19:46:32 -04:00
Benjamin Otte
55dafea2e4 builder: Make gtk_builder_extend_with_template() work with objects
This will be relevant later when we introduce GtkListItem which is not a
GtkWidget.
2020-05-29 19:46:32 -04:00
Benjamin Otte
538897a055 gtk-demo: Add a Coverflow application launcher
This is roughly the simplest demo I could come up with.

But I documented it, so there's your tutorial.

Related: #2214
2020-05-29 19:46:32 -04:00
Benjamin Otte
fcab9e1c07 Add GtkSignalListItemFactory
So the poor Rust users can actually use this.

I would totally not use this ever!
2020-05-29 19:46:32 -04:00
Benjamin Otte
3e4d81417c columnview: Allow adding/removing columns
... and make that work in UI files via <child>, too.
2020-05-29 19:46:32 -04:00
Benjamin Otte
c9874ef736 gtk-demo: Add a minesweeper demo
The demo shows creating ones own listmodel and using it to fill a grid.

I am totally getting the hang of React btw:
500 lines of logic with no UI code and 100 lines of GtkBuilder XML and
I get a sweet UI.
2020-05-29 19:46:32 -04:00
Benjamin Otte
5e9abb956f Add GtkColumnView skeleton
It's just a copy/paste of the listview code with all the internals
gutted. The code doesn't do anything.
2020-05-29 19:46:32 -04:00
Benjamin Otte
930442f616 wip: Add GtkCoverFlow
The widget mostly works out of the box, but some tweaking may be
necessary (in particular in the theme) and the gtk-demo changes might
require removing before this is production-ready.
2020-05-29 19:46:32 -04:00
Benjamin Otte
fb1f719127 listbase: Take over anchor handling
With that, pretty much all code but allocating the widgets is gone from
the gridview and listview.
2020-05-29 19:46:32 -04:00
Benjamin Otte
f4150c6d64 listbase: Add vfuncs to convert positions to/from coordinates
... and use that to implement PageUp/PageDown.

With that, all keyboard handling has been moved to GtkListBase.
2020-05-29 19:46:32 -04:00
Benjamin Otte
045cea31e5 listbase: Move focus moving keybindings here
The focus tracker is not yet moved because that depends on scroll_to()
support and we don't have that yet.
Whoops.
So we use a hack.
2020-05-29 19:46:32 -04:00
Benjamin Otte
aa411acaa2 Remove gtk_selection_model_user_select_item() again
This reverts commit 6a164ab306dad9096bde736c907494c71086d3c4.

The function was awkward and we now have only one caller again, so we
can fold it back into it.
2020-05-29 19:46:32 -04:00
Benjamin Otte
a3b1e7872f listbase: Move orientable implementation here 2020-05-29 19:46:32 -04:00
Benjamin Otte
a6ff878e4c listbase: Move selection handling here 2020-05-29 19:46:32 -04:00
Benjamin Otte
9a3ef0435d listbase: Move item manager here
Nothing really changes, because both ListView and GridView still keep
self->item_manager around, but it's set up to point at the base's item
manager.

This way we can slowly move things to GtkListBase that need the item
manager (like trackers).
2020-05-29 19:46:32 -04:00
Benjamin Otte
a23dfc9861 listbase: Move GtkScrollable implementation
Shared code between GtkGridView and GtkListView.
2020-05-29 19:46:32 -04:00
Benjamin Otte
b7c04ff9a9 Add GtkListBase
This is a base item for GTK's list widgets so they can share some (read:
hopefully a lot of) code.
2020-05-29 19:46:32 -04:00
Benjamin Otte
de36e9d951 gridview: Simplify allocation code
It doesn't fix the bug I'm after, but it looks a lot better.
2020-05-29 19:46:32 -04:00
Benjamin Otte
1eabde4b6f listview: Port various gridview improvements
- Handle anchor as align + top/bottom
  This fixes behavior for cells that are higher than the view
- Add gtk_list_view_adjustment_is_flipped()
  This should fix RTL handling of horizontal lists
- Fix scrolling
  This should make scrolling more reliable, particularly on short lists
  that are only a few pages long.
2020-05-29 19:46:32 -04:00
Benjamin Otte
768b94ab90 demo: Add a file browser demo 2020-05-29 19:46:32 -04:00
Benjamin Otte
417072dd19 gridview: Add move keybindings 2020-05-29 19:46:31 -04:00
Benjamin Otte
3df388e176 gridview: Implement (un)select all
Adds listitem.select-all and listitem.unselect-all actions and installs
the same keybindings as the treeview for those actions.
2020-05-29 19:46:31 -04:00
Benjamin Otte
26065eb200 gridview: Add a focus tracker
... and use that to properly update selections when moving around with
the arrow keys.
2020-05-29 19:46:31 -04:00
Benjamin Otte
e9cc7e0917 gridview: Implement list.scroll-to action 2020-05-29 19:46:31 -04:00
Benjamin Otte
5008a11b57 gridview: Add activation 2020-05-29 19:46:31 -04:00
Benjamin Otte
5c48501961 gridview: Implement minimum row height
We only allocate a certain amount of widgets - and we don't want to run
out of them. So we make all widgets high enough for this to never
happen.
2020-05-29 19:46:31 -04:00
Benjamin Otte
97eb6c24ee gridview: Implement the list.select-item action 2020-05-29 19:46:31 -04:00
Benjamin Otte
c0a7639cbe selectionmodel: Add gtk_selection_model_user_select_item()
I'm not sure this should be public API because it's incredibly awkward.
But it should definitely be shared between list widget implementations.
2020-05-29 19:46:31 -04:00
Benjamin Otte
e795aff583 gridview: Implement anchors and scrolling 2020-05-29 19:46:31 -04:00
Benjamin Otte
5a087b5140 widget: Add gtk_widget_get_size()
A little bit of convenience.
2020-05-29 19:46:31 -04:00
Benjamin Otte
ece4958769 listitemmanager: Handle NULL factory
Just don't call it and create empty listitems.
2020-05-29 19:46:31 -04:00
Timm Bäder
b0b5c2a73f demo: Use a listview as sidebar 2020-05-29 19:46:31 -04:00
Benjamin Otte
4f2bd7331a gtk-demo: Introduce awards
We need a way to get a useful listbox, so here we go!
2020-05-29 19:46:31 -04:00
Benjamin Otte
53b6c7ee7b builder: Autofill scope property of listitemfactory
I couldn't come up with a better way to automatically inherit the scope
in the builder list item factory that didn't involve a magic
incantation in the XML file. And I do not want developers to know magic
incantations to do a thing that should pretty much always be done.
2020-05-29 19:46:31 -04:00
Benjamin Otte
3d1474fba8 builderlistitemfactory: Add scope argument
This way, the scope used when creating builder instances can be
influenced. This way, callbacks can be passed into the factory.
2020-05-29 19:46:31 -04:00
Benjamin Otte
8609ccd43e listitemfactory: Make the builder factory properly buildable
Turn the construct arguments into construct properties so that they can
be set from ui files.
2020-05-29 19:46:31 -04:00
Benjamin Otte
d816070c2a listview: Add move keybindings
My god, these are a lot.

And my god, these are complicated to get right.
2020-05-29 19:46:31 -04:00
Benjamin Otte
438df090e9 listview: Add gtk_list_view_get_position_at_y() 2020-05-29 19:46:31 -04:00
Benjamin Otte
69b57a73c7 listitem: Add "listitem.select" action and keybindings for it
In fact, grab space with all modifiers to toggle selection of the
current item.
2020-05-29 19:46:31 -04:00
Benjamin Otte
38a5f11e1b listview: Add a focus tracker
This ensures that the row with the input focus always stays available,
even when scrolled out of view.
2020-05-29 19:46:31 -04:00
Benjamin Otte
09c90683e1 listview: Implement (un)select all
Adds listitem.select-all and listitem.unselect-all actions and installs
the same keybindings as the treeview for those actions.
2020-05-29 19:46:31 -04:00
Benjamin Otte
e227855b68 listview: Track focus movements and update selection
When focus moves via tab/arrow, we need to select the new item.
2020-05-29 19:46:31 -04:00
Benjamin Otte
51a9d59c07 listview: Implement activation
- a GtkListview::activate signal
- a GtkListItem::activatable property
- activate list items on double clicks and <Enter> presses
2020-05-29 19:46:31 -04:00
Benjamin Otte
bf9f6bca41 treeexpander: Implement input support
This implements all the keybindings from GtkTreeView that can be
supported.

It does not implement expand-all, because supporting that means
causing the TreeListModel to emit lots of create_model vfuncs which in
turn would cause many items-changed signal which in turn would cause
many signal handlers to run which in turn would make "expand-all" very
reentrant, and I'm uneasy about supporting that.

For the mouse, just add a click gesture to the expander icon that toggles
expanded state.
2020-05-29 19:46:31 -04:00
Benjamin Otte
772d7e41f2 listitem: Change focus handling
Focus in the listitem now works like this:
1. If any child can take focus, do not ever attempt
   to take focus.
2. Otherwise, if this item is selectable or activatable,
   allow focusing this widget.

This makes sure every item in a list is focusable for
activation and selection handling, but no useless widgets
get focused and moving focus is as fast as possible.
2020-05-29 19:46:31 -04:00
Benjamin Otte
0e325c3208 inspector: Make the recorder node list use a ListView
It's quite a bit faster now, but the code is also a bit more awkward.

Pain points:

- GtkTreeListModel cannot be created in UI files because it needs
  a CreateModelFunc.
  Using a signal for this doesn't work because autoexpand wants to
  expand the model before the signal handler is connected.

- The list item factory usage is still awkward. It's bearable here
  because the list items are very simple, but still.
2020-05-29 19:46:31 -04:00
Benjamin Otte
9914982c4f inspector: Use a GtkTreeExpander in the object tree 2020-05-29 19:46:31 -04:00