wip

Pass an extra boolean that tells whether the target image is GL_SRGB,
in which case, the rendering color state must be srgb-linear.

Update all callers to pass FALSE, except for the one call in
the node processor, where we want to take GL_LINEAR into account.

.gitlab-ci.yml

@@ -26,8 +26,7 @@ variables:
   BACKEND_FLAGS: "-Dx11-backend=true -Dwayland-backend=true -Dbroadway-backend=true"
   FEATURE_FLAGS: "-Dvulkan=enabled -Dcloudproviders=enabled -Dbuild-testsuite=true -Dintrospection=enabled"
   MESON_TEST_TIMEOUT_MULTIPLIER: 3
-  MESON_TEST_MAX_PROCESSES: 8
-  FEDORA_IMAGE: "registry.gitlab.gnome.org/gnome/gtk/fedora:v52"
+  FEDORA_IMAGE: "registry.gitlab.gnome.org/gnome/gtk/fedora:v49"
 
 workflow:
   rules:
@@ -119,9 +118,8 @@ release-build:
   script:
     - .gitlab-ci/show-info-linux.sh
     - mkdir _install
-    # don't use catch by default, since it causes sporadic test failures
-    # - export PATH="$HOME/.local/bin:${CI_PROJECT_DIR}/_install/bin:$PATH"
-    # - .gitlab-ci/install-meson-project.sh --prefix ${CI_PROJECT_DIR}/_install https://gitlab.gnome.org/jadahl/catch.git main
+    - export PATH="$HOME/.local/bin:${CI_PROJECT_DIR}/_install/bin:$PATH"
+    - .gitlab-ci/install-meson-project.sh --prefix ${CI_PROJECT_DIR}/_install https://gitlab.gnome.org/jadahl/catch.git main
     - meson subprojects download
     - meson subprojects update --reset
     - meson setup
@@ -416,12 +414,11 @@ static-scan:
 # Run tests with the address sanitizer. We need to turn off introspection
 # and f16c, since they are incompatible with asan
 asan-build:
-  extends: .build-fedora-default
+  image: $FEDORA_IMAGE
   tags: [ asan ]
   stage: analysis
   needs: []
   variables:
-    MESON_TEST_MAX_PROCESSES: 4
   script:
     - export PATH="$HOME/.local/bin:$PATH"
     - CC=clang meson setup

.gitlab-ci/fedora.Dockerfile

@@ -1,4 +1,4 @@
-FROM fedora:40
+FROM fedora:39
 
 RUN dnf -y install \
     adwaita-icon-theme \
@@ -99,11 +99,8 @@ RUN dnf -y install \
     which \
     wireplumber \
     xorg-x11-server-Xvfb \
- && dnf -y update \
  && dnf clean all
 
-RUN rm /usr/share/vulkan/icd.d/powervr_mesa_icd.x86_64.json
-
 # Enable sudo for wheel users
 RUN sed -i -e 's/# %wheel/%wheel/' -e '0,/%wheel/{s/%wheel/# %wheel/}' /etc/sudoers
 

.gitlab-ci/run-tests.sh

@@ -8,19 +8,17 @@ builddir=$1
 setup=$2
 suite=$3
 multiplier=${MESON_TEST_TIMEOUT_MULTIPLIER:-1}
-n_processes=${MESON_TEST_MAX_PROCESSES:-1}
 
 # Ignore memory leaks lower in dependencies
 export LSAN_OPTIONS=suppressions=$srcdir/lsan.supp:print_suppressions=0:detect_leaks=0:allocator_may_return_null=1
+export G_SLICE=always-malloc
 
 case "${setup}" in
   x11*)
-    dbus-run-session -- \
-       xvfb-run -a -s "-screen 0 1024x768x24 -noreset" \
+    xvfb-run -a -s "-screen 0 1024x768x24 -noreset" \
           meson test -C ${builddir} \
                 --quiet \
                 --timeout-multiplier "${multiplier}" \
-                --num-processes "${n_processes}" \
                 --print-errorlogs \
                 --setup=${setup} \
                 --suite=${suite//,/ --suite=} \
@@ -42,11 +40,9 @@ case "${setup}" in
     compositor=$!
     export WAYLAND_DISPLAY=wayland-5
 
-    dbus-run-session -- \
-          meson test -C ${builddir} \
+    meson test -C ${builddir} \
                 --quiet \
                 --timeout-multiplier "${multiplier}" \
-                --num-processes "${n_processes}" \
                 --print-errorlogs \
                 --setup=${setup} \
                 --suite=${suite//,/ --suite=} \
@@ -67,11 +63,9 @@ case "${setup}" in
     server=$!
     export BROADWAY_DISPLAY=:5
 
-    dbus-run-session -- \
-          meson test -C ${builddir} \
+    meson test -C ${builddir} \
                 --quiet \
                 --timeout-multiplier "${multiplier}" \
-                --num-processes "${n_processes}" \
                 --print-errorlogs \
                 --setup=${setup} \
                 --suite=${suite//,/ --suite=} \

NEWS

@@ -1,311 +1,6 @@
-Overview of Changes in 4.16.3, 04-10-2024
+Overview of Changes in 4.15.5, xx-xx-xxxx
 =========================================
 
-* GtkScrolledWindow
- - Fix criticals in size allocation code
-
-* GtkFileChooser
- - Fix a crash in the portal code
-
-* GtkPicture
- - Avoid unnecessary resizes
-
-* GtkVideo
- - Make dmabufs work without GL
-
-* Accessibility:
- - Always realized non-widget accessibles
-
-* Wayland:
- - Improve settings portal handling
- - Improve fallback for cursor themes
- - Sync default values for settings with schema defaults
-
-* Translation updates:
- Brazilian Portuguese
- Galician
- Swedish
-
-
-Overview of Changes in 4.16.2, 25-09-2024
-=========================================
-
-* GtkLabel:
- - Fix centered text in RTL
-
-* Gsk:
- - Speed up some Vulkan operations
- - Improve startup speed by avoiding initialization
-   of GL and Vulkan in most cases
- - Reduce critials at startup to warnings
- - Fix a crash on startup with some Vulkan drivers
- - Fix a big texture leak in NGL
-
-* Gdk:
- - Speed up memory format conversions
-
-* Wayland:
- - Be more careful with mimetypes during DND or copy-paste
-
-* Tools:
- - builder-tool: Improve conversion of boxes
-
-* Translation updates:
- Brazilian Portuguese
- Bulgarian
- Catalan
- Chinese (China)
- Georgian
- German
- Hebrew
- Indonesian
- Persian
- Polish
- Portuguese
- Slovenian
- Spanish
- Turkish
- Ukrainian
-
-
-Overview of Changes in 4.16.1, 16-09-2024
-=========================================
-
-* GtkFileChooser:
- - Plug a memory leak
-
-* GtkCalendar:
- - Avoid ending up with invalid dates
-
-* Printing:
- - Fix initial printer selection in the print dialog
-
-* Gsk:
- - Fix shadows for opaque textures
- - Fix a crash in a corner case
-
-* Css:
- - Make relative paths work again in theme files
-
-* Accessibility:
- - Fix detection of the Flatpak portal
-
-* MacOS:
- - Fix keyboard input in popovers
- - Keep DND icons above regular windows
- - Ignore events from DND icons
-
-* Translation updates
- Basque
- British English
- Bulgarian
- Czech
- Danish
- Georgian
- Hungarian
- Lithuanian
- Portuguese
- Spanish
- Swedish
-
-
-Overview of Changes in 4.16.0, 06-09-2024
-=========================================
-
-Note: This release changes the default GSK renderer to be Vulkan,
-on Wayland. Other platforms still use ngl. The intent of this change
-is to use the best available platform APIs. You can still override
-the renderer choice using the GSK_RENDERER environment variable.
-
-We believe that most of the problems reported with the new renderers
-during the 4.13 and 4.15 development cycles have been addressed by now.
-
-But the new renderers and dmabuf support are using graphics drivers
-in different ways than the old gl renderer, and trigger new driver bugs.
-Therefore, it is recommended to use the latest mesa release (24.2)
-with the new renderers.
-
-* GtkScale:
- - Fix positioning of scale values
-
-* GtkEmojiChooser:
- - Make Control-clicks work for the recent section
-
-* GtkPopover:
- - Make sure focus lands on the right widget when cascading
-
-* GtkSpinButton:
- - Disable Emoji input for numeric spin buttons
-
-* GtkSingleSelection:
- - Implement unselect_all
-
-* Accssibility:
- - Fix roles for radio buttons
- - Check if ATs are listening before exporting trees
- - Add a check for sandboxed accessibility bus
- - Fix handling of the error message relation
- - Turn criticals into debug messages
- - Set expanded states properly in menus
-
-* CSS:
- - Fix a few issues on bigendian systems
- - Avoid a crash with relative colors
-
-* GSK:
- - Use the right GL context when exporting textures
- - Don't let colors influence depth decisions
- - Allow uploading of mipmap levels when tiling textures
-
-* GDK:
- - Update keysyms from libX11 1.8.10
- - Implement cpu-side mipmapping
- - Use a thread pool for color conversions and mipmapping
-
-* Vulkan:
- - Fix drag surface offsets
-
-* Wayland:
- - Fix a crash
- - Associate EGL windows with context later
-
-* X11:
- - Fix initial EGL context creation
- - Fix a problem with GL context creation
-
-* Broadway:
- - Implement compute_size and request_layout
-
-* MacOS:
- - Set transparent backgroiund for toplevel windows
-
-* Windows:
- - Improve debug output
- - Detect Mesas d3d12 driver and request GDI compat
-
-* Demos:
- - Set window icons in demos
- - Add a 64k x 64k image to the image scaling demo
-
-* Translation updates
- Belarusian
- Brazilian Portuguese
- Catalan
- Czech
- Galician
- German
- Hebrew
- Indonesian
- Korean
- Lithuanian
- Persian
- Polish
- Portuguese
- Slovenian
- Spanish
- Turkish
- Ukrainian
-
-
-Overview of Changes in 4.15.6, 26-08-2024
-=========================================
-
-* GtkCheckButton:
- - Add a grouped style class for radio buttons
-
-* GtkScale:
- - Fix alignment and positioning problems
-
-* Css:
- - Fix crashes in the variable support
-
-* Gsk:
- - Make graphics offloading work better with kwin
- - Make colorstate transfer functions more robust
- - GC dead textures more agressively
- - Only use a single render pass per frame
-
-* GL:
- - Round damage rectangles properly
- - Use the shared context when creating textures
- - Fix a file descriptor leak in dmabuf export
-
-* Vulkan:
- - Round damage rectangles properly
-
-* Wayland:
- - Work with the kwin implementation of xx-color-management-v4
-
-* Windows:
- - Make gtk_show_uri use SHOpenWithDialog()
- - Enable incremental rendering with WGL
-
-* Macos:
- - Open context menus on Ctrl-left click
-
-* Debugging:
- - Show color state information in the inspector
- - Collect input event traces in the recorder
- - Add shortcuts for toggling recording: Super-r
-   and for screenshots: Super-c
- - Split the GDK_DEBUG env var into GDK_DEBUG and GDK_DISABLE
- - Add GDK_DISABLE=color-mgmt and GDK_DISABLE=offload
-
-* Tools:
- - Add a 'Paste as node' action in gtk4-node-editor
-
-* Translations updates
- Basque
- Belarusian
- Brazilian Portuguese
- Chinese (China)
- Georgian
- Hebrew
- Hindi
- Russian
- Slovenian
- Turkish
- Ukrainian
-
-
-Overview of Changes in 4.15.5, 11-08-2024
-=========================================
-
-* GtkTextView:
- - ADd GtkTextBufferCommitNotify
-
-* CSS:
- - Propagate color state information to GSK for many features:
-   colors, borders, shadows, text
-
-* Gdk:
- - Fix an fd leak in the Vulkan code
- - Fix a leak of EGLSurfaces and DMA buffers
- - Set the opaque region of surfaces automatically based on their content
-
-* Gsk:
- - Fix Emoji rendering in Vulkan
- - Rework color handling to take color states into account
- - Implement more powerful occlusion culling
- - Minimize our use of renderpasses
-
-* Macos:
- - Fix window transparency
-
-* Debugging:
- - The inspector shows details about color states
-
-* Deprecations:
- - gdk_draw_context_begin/end_frame
- - gdk_surface_set_opaque_region
-
-* Build:
- - Require gstreamer 1.24
-
-* Translation updates
- Romanian
-
-
 Overview of Changes in 4.15.4, 30-07-2024
 =========================================
 

demos/gtk-demo/demo.gresource.xml

@@ -454,9 +454,6 @@
     <file>icons/16x16/categories/applications-other.png</file>
     <file>icons/48x48/status/starred.png</file>
     <file alias="icons/scalable/apps/org.gtk.Demo4.svg">data/scalable/apps/org.gtk.Demo4.svg</file>
-    <file>portland-rose-thumbnail.png</file>
-    <file>large-image-thumbnail.png</file>
-    <file compressed="true">large-image.png</file>
   </gresource>
   <gresource prefix="/org/gtk/Demo4/gtk">
     <file preprocess="xml-stripblanks">help-overlay.ui</file>

demos/gtk-demo/errorstates.c

@@ -55,7 +55,7 @@ mode_switch_state_set (GtkSwitch *sw,
     {
       gtk_widget_set_visible (label, TRUE);
       gtk_accessible_update_relation (GTK_ACCESSIBLE (sw),
-                                      GTK_ACCESSIBLE_RELATION_ERROR_MESSAGE, label, NULL,
+                                      GTK_ACCESSIBLE_RELATION_ERROR_MESSAGE, label,
                                       -1);
       gtk_accessible_update_state (GTK_ACCESSIBLE (sw),
                                    GTK_ACCESSIBLE_STATE_INVALID, GTK_ACCESSIBLE_INVALID_TRUE,

demos/gtk-demo/image_scaling.c

@@ -14,103 +14,6 @@
 #include <gtk/gtk.h>
 #include "demo3widget.h"
 
-static GtkWidget *window = NULL;
-static GCancellable *cancellable = NULL;
-
-static void
-load_texture (GTask        *task,
-              gpointer      source_object,
-              gpointer      task_data,
-              GCancellable *cable)
-{
-  GFile *file = task_data;
-  GdkTexture *texture;
-  GError *error = NULL;
-
-  texture = gdk_texture_new_from_file (file, &error);
-
-  if (texture)
-    g_task_return_pointer (task, texture, g_object_unref);
-  else
-    g_task_return_error (task, error);
-}
-
-static void
-set_wait_cursor (GtkWidget *widget)
-{
-  gtk_widget_set_cursor_from_name (GTK_WIDGET (gtk_widget_get_root (widget)), "wait");
-}
-
-static void
-unset_wait_cursor (GtkWidget *widget)
-{
-  gtk_widget_set_cursor (GTK_WIDGET (gtk_widget_get_root (widget)), NULL);
-}
-
-static void
-texture_loaded (GObject      *source,
-                GAsyncResult *result,
-                gpointer      data)
-{
-  GdkTexture *texture;
-  GError *error = NULL;
-
-  texture = g_task_propagate_pointer (G_TASK (result), &error);
-
-  if (!texture)
-    {
-      g_print ("%s\n", error->message);
-      g_error_free (error);
-      return;
-    }
-
-  if (!window)
-    {
-      g_object_unref (texture);
-      return;
-    }
-
-  unset_wait_cursor (GTK_WIDGET (data));
-
-  g_object_set (G_OBJECT (data), "texture", texture, NULL);
-}
-
-static void
-open_file_async (GFile     *file,
-                 GtkWidget *demo)
-{
-  GTask *task;
-
-  set_wait_cursor (demo);
-
-  task = g_task_new (demo, cancellable, texture_loaded, demo);
-  g_task_set_task_data (task, g_object_ref (file), g_object_unref);
-  g_task_run_in_thread (task, load_texture);
-  g_object_unref (task);
-}
-
-static void
-open_portland_rose (GtkWidget *button,
-                    GtkWidget *demo)
-{
-  GFile *file;
-
-  file = g_file_new_for_uri ("resource:///transparent/portland-rose.jpg");
-  open_file_async (file, demo);
-  g_object_unref (file);
-}
-
-static void
-open_large_image (GtkWidget *button,
-                  GtkWidget *demo)
-{
-  GFile *file;
-
-  file = g_file_new_for_uri ("resource:///org/gtk/Demo4/large-image.png");
-  open_file_async (file, demo);
-  g_object_unref (file);
-}
-
 static void
 file_opened (GObject      *source,
              GAsyncResult *result,
@@ -118,6 +21,7 @@ file_opened (GObject      *source,
 {
   GFile *file;
   GError *error = NULL;
+  GdkTexture *texture;
 
   file = gtk_file_dialog_open_finish (GTK_FILE_DIALOG (source), result, &error);
 
@@ -128,9 +32,17 @@ file_opened (GObject      *source,
       return;
     }
 
-  open_file_async (file, data);
-
+  texture = gdk_texture_new_from_file (file, &error);
   g_object_unref (file);
+  if (!texture)
+    {
+      g_print ("%s\n", error->message);
+      g_error_free (error);
+      return;
+    }
+
+  g_object_set (G_OBJECT (data), "texture", texture, NULL);
+  g_object_unref (texture);
 }
 
 static void
@@ -204,26 +116,11 @@ transform_from (GBinding     *binding,
   return TRUE;
 }
 
-static void
-free_cancellable (gpointer data)
-{
-  g_cancellable_cancel (cancellable);
-  g_clear_object (&cancellable);
-}
-
-static gboolean
-cancel_load (GtkWidget *widget,
-             GVariant  *args,
-             gpointer   data)
-{
-  unset_wait_cursor (widget);
-  g_cancellable_cancel (G_CANCELLABLE (data));
-  return TRUE;
-}
-
 GtkWidget *
 do_image_scaling (GtkWidget *do_widget)
 {
+  static GtkWidget *window = NULL;
+
   if (!window)
     {
       GtkWidget *box;
@@ -233,7 +130,6 @@ do_image_scaling (GtkWidget *do_widget)
       GtkWidget *scale;
       GtkWidget *dropdown;
       GtkWidget *button;
-      GtkEventController *controller;
 
       window = gtk_window_new ();
       gtk_window_set_title (GTK_WINDOW (window), "Image Scaling");
@@ -242,20 +138,6 @@ do_image_scaling (GtkWidget *do_widget)
                               gtk_widget_get_display (do_widget));
       g_object_add_weak_pointer (G_OBJECT (window), (gpointer *)&window);
 
-      cancellable = g_cancellable_new ();
-      g_object_set_data_full (G_OBJECT (window), "cancellable",
-                              cancellable, free_cancellable);
-
-      controller = gtk_shortcut_controller_new ();
-      gtk_shortcut_controller_add_shortcut (GTK_SHORTCUT_CONTROLLER (controller),
-                                            gtk_shortcut_new (
-                                                gtk_keyval_trigger_new (GDK_KEY_Escape, 0),
-                                                gtk_callback_action_new (cancel_load, cancellable, NULL)
-                                                ));
-      gtk_shortcut_controller_set_scope (GTK_SHORTCUT_CONTROLLER (controller),
-                                         GTK_SHORTCUT_SCOPE_GLOBAL);
-      gtk_widget_add_controller (window, controller);
-
       box = gtk_box_new (GTK_ORIENTATION_VERTICAL, 0);
       gtk_window_set_child (GTK_WINDOW (window), box);
 
@@ -274,22 +156,6 @@ do_image_scaling (GtkWidget *do_widget)
       g_signal_connect (button, "clicked", G_CALLBACK (open_file), widget);
       gtk_box_append (GTK_BOX (box2), button);
 
-      button = gtk_button_new ();
-      gtk_button_set_child (GTK_BUTTON (button),
-                            gtk_image_new_from_resource ("/org/gtk/Demo4/portland-rose-thumbnail.png"));
-      gtk_widget_add_css_class (button, "image-button");
-      gtk_widget_set_tooltip_text (button, "Portland Rose");
-      g_signal_connect (button, "clicked", G_CALLBACK (open_portland_rose), widget);
-      gtk_box_append (GTK_BOX (box2), button);
-
-      button = gtk_button_new ();
-      gtk_button_set_child (GTK_BUTTON (button),
-                            gtk_image_new_from_resource ("/org/gtk/Demo4/large-image-thumbnail.png"));
-      gtk_widget_add_css_class (button, "image-button");
-      gtk_widget_set_tooltip_text (button, "Large image");
-      g_signal_connect (button, "clicked", G_CALLBACK (open_large_image), widget);
-      gtk_box_append (GTK_BOX (box2), button);
-
       button = gtk_button_new_from_icon_name ("object-rotate-right-symbolic");
       gtk_widget_set_tooltip_text (button, "Rotate");
       g_signal_connect (button, "clicked", G_CALLBACK (rotate), widget);
@@ -325,9 +191,7 @@ do_image_scaling (GtkWidget *do_widget)
   if (!gtk_widget_get_visible (window))
     gtk_widget_set_visible (window, TRUE);
   else
-    {
-      gtk_window_destroy (GTK_WINDOW (window));
-    }
+    gtk_window_destroy (GTK_WINDOW (window));
 
   return window;
 }

demos/gtk-demo/main.c

@@ -1068,8 +1068,6 @@ command_line (GApplication            *app,
 
   window = gtk_application_get_windows (GTK_APPLICATION (app))->data;
 
-  gtk_window_set_icon_name (GTK_WINDOW (window), "org.gtk.Demo4");
-
   if (name == NULL)
     goto out;
 

demos/gtk-demo/path_fill.c

@@ -225,8 +225,7 @@ print_ready (GObject      *source,
 
   if (!g_output_stream_close (stream, NULL, &error))
     {
-      if (!g_error_matches (error, GTK_DIALOG_ERROR, GTK_DIALOG_ERROR_DISMISSED))
-        g_print ("Error from close: %s\n", error->message);
+      g_print ("Error from close: %s\n", error->message);
       g_error_free (error);
     }
 

demos/icon-browser/iconbrowserapp.c

@@ -139,8 +139,6 @@ icon_browser_app_activate (GApplication *app)
   if (g_strcmp0 (PROFILE, "devel") == 0)
     gtk_widget_add_css_class (GTK_WIDGET (win), "devel");
 
-  gtk_window_set_icon_name (GTK_WINDOW (win), "org.gtk.IconBrowser4");
-
   gtk_window_present (GTK_WINDOW (win));
 }
 

demos/node-editor/node-editor-application.c

@@ -219,8 +219,6 @@ node_editor_application_activate (GApplication *app)
   if (g_strcmp0 (PROFILE, "devel") == 0)
     gtk_widget_add_css_class (GTK_WIDGET (win), "devel");
 
-  gtk_window_set_icon_name (GTK_WINDOW (win), "org.gtk.gtk4.NodeEditor");
-
   gtk_window_present (GTK_WINDOW (win));
 }
 

demos/node-editor/node-editor-window.c

@@ -1205,19 +1205,6 @@ node_editor_window_add_renderer (NodeEditorWindow *self,
   g_object_unref (paintable);
 }
 
-static void
-update_paste_action (GdkClipboard *clipboard,
-                     GParamSpec   *pspec,
-                     gpointer      data)
-{
-  GtkWidget *widget = GTK_WIDGET (data);
-  gboolean has_node;
-
-  has_node = gdk_content_formats_contain_mime_type (gdk_clipboard_get_formats (clipboard), "application/x-gtk-render-node");
-
-  gtk_widget_action_set_enabled (widget, "paste-node", has_node);
-}
-
 static void
 node_editor_window_realize (GtkWidget *widget)
 {
@@ -1255,7 +1242,6 @@ node_editor_window_realize (GtkWidget *widget)
   self->after_paint_handler = g_signal_connect (frameclock, "after-paint",
                                                 G_CALLBACK (after_paint), self);
 
-  g_signal_connect (gtk_widget_get_clipboard (widget), "notify::formats", G_CALLBACK (update_paste_action), widget);
 }
 
 static void
@@ -1265,8 +1251,6 @@ node_editor_window_unrealize (GtkWidget *widget)
   GdkFrameClock *frameclock;
   guint i;
 
-  g_signal_handlers_disconnect_by_func (gtk_widget_get_clipboard (widget), update_paste_action, widget);
-
   frameclock = gtk_widget_get_frame_clock (widget);
   g_signal_handler_disconnect (frameclock, self->after_paint_handler);
   self->after_paint_handler = 0;
@@ -1631,41 +1615,6 @@ edit_action_cb (GtkWidget  *widget,
   node_editor_window_edit (self, &start);
 }
 
-static void
-text_received (GObject      *source,
-               GAsyncResult *result,
-               gpointer      data)
-{
-  GdkClipboard *clipboard = GDK_CLIPBOARD (source);
-  NodeEditorWindow *self = NODE_EDITOR_WINDOW (data);
-  char *text;
-
-  text = gdk_clipboard_read_text_finish (clipboard, result, NULL);
-  if (text)
-    {
-      GtkTextBuffer *buffer;
-      GtkTextIter start, end;
-
-      buffer = gtk_text_view_get_buffer (GTK_TEXT_VIEW (self->text_view));
-      gtk_text_buffer_begin_user_action (buffer);
-      gtk_text_buffer_get_bounds (buffer, &start, &end);
-      gtk_text_buffer_delete (buffer, &start, &end);
-      gtk_text_buffer_insert (buffer, &start, text, -1);
-      gtk_text_buffer_end_user_action (buffer);
-      g_free (text);
-    }
-}
-
-static void
-paste_node_cb (GtkWidget  *widget,
-               const char *action_name,
-               GVariant   *parameter)
-{
-  GdkClipboard *clipboard = gtk_widget_get_clipboard (widget);
-
-  gdk_clipboard_read_text_async (clipboard, NULL, text_received, widget);
-}
-
 static void
 node_editor_window_set_property (GObject      *object,
                                  guint         prop_id,
@@ -1778,13 +1727,6 @@ node_editor_window_class_init (NodeEditorWindowClass *class)
   action = gtk_named_action_new ("smart-edit");
   shortcut = gtk_shortcut_new (trigger, action);
   gtk_widget_class_add_shortcut (widget_class, shortcut);
-
-  gtk_widget_class_install_action (widget_class, "paste-node", NULL, paste_node_cb);
-
-  trigger = gtk_keyval_trigger_new (GDK_KEY_v, GDK_CONTROL_MASK | GDK_SHIFT_MASK);
-  action = gtk_named_action_new ("paste-node");
-  shortcut = gtk_shortcut_new (trigger, action);
-  gtk_widget_class_add_shortcut (widget_class, shortcut);
 }
 
 static GtkWidget *

demos/node-editor/node-editor-window.ui

@@ -22,10 +22,6 @@
   </menu>
   <menu id="extra_menu">
     <section>
-      <item>
-        <attribute name="label" translatable="yes">Paste _Node</attribute>
-        <attribute name="action">paste-node</attribute>
-      </item>
       <item>
         <attribute name="label" translatable="yes">Assisted _Edit</attribute>
         <attribute name="action">smart-edit</attribute>

demos/print-editor/print-editor.c

@@ -798,7 +798,7 @@ activate (GApplication *app)
   if (g_strcmp0 (PROFILE, "devel") == 0)
     gtk_widget_add_css_class (GTK_WIDGET (main_window), "devel");
 
-  gtk_window_set_icon_name (GTK_WINDOW (main_window), "org.gtk.PrintEditor4");
+  gtk_window_set_icon_name (GTK_WINDOW (main_window), "text-editor");
   gtk_window_set_default_size (GTK_WINDOW (main_window), 400, 600);
   gtk_application_window_set_show_menubar (GTK_APPLICATION_WINDOW (main_window), TRUE);
   update_title (GTK_WINDOW (main_window));

demos/widget-factory/widget-factory.c

@@ -2241,7 +2241,6 @@ activate (GApplication *app)
   if (g_strcmp0 (PROFILE, "devel") == 0)
     gtk_widget_add_css_class (GTK_WIDGET (window), "devel");
 
-  gtk_window_set_icon_name (window, "org.gtk.WidgetFactory4");
   gtk_application_add_window (GTK_APPLICATION (app), window);
   g_action_map_add_action_entries (G_ACTION_MAP (window),
                                    win_entries, G_N_ELEMENTS (win_entries),

docs/reference/README.md

@@ -151,11 +151,10 @@ Checks whether the widget is set to be visible or not.
  - Methods are special functions whose first argument is always the instance
    of a certain class. The instance argument for newly written code should be
    called `self`.
- - If a method is a setter or a getter for an object property
-   `GtkClassName:prop-name`, and if its name does not match the naming scheme
-   `gtk_class_name_{g,s}et_prop_name`, you should add a `(set-property
-   prop-name)` or a `(get-property prop-name)` annotation to the method's
-   identifier
+ - If a method is a setter or a getter for an object property, you should
+   add an `(attributes org.gtk.Method.set_property=property-name)` or a
+   an `(attributes org.gtk.Method.get_property=property-name)` annotation
+   to the method's identifier
  - If a method changes one or more properties as side effect, link those
    properties in the method's description
  - If a method is a signal emitter, you should use the
@@ -193,10 +192,9 @@ Checks whether the widget is set to be visible or not.
    purposes.
  - Always note if setting a property has side effects, like causing another
    property to change state.
- - If a property `GtkClassName:prop-name` has a public getter or setter, and
-   they do not match the naming scheme `gtk_class_name_{g,s}et_prop_name` you
-   should annotate it with the `(setter setter_function)` and `(getter
-   getter_function)`.
+ - If the property has public accessors you should annotate it with
+   the `(attributes org.gtk.Property.set=setter_function)` and
+   `(attributes org.gtk.Property.get=getter_function)` attributes
  - The syntax for property documentation is:
 
 ```c

docs/reference/gdk/meson.build

@@ -38,7 +38,7 @@ if get_option('documentation')
       gdk_gir[0],
     ],
     depends: gdk_gir[0],
-    suite: ['docs', 'failing'],
+    suite: ['docs'],
   )
 
   if x11_enabled

docs/reference/gtk/broadway.md

@@ -1,16 +1,12 @@
 Title: The Broadway windowing system
 Slug: broadway
 
+## Using GTK with Broadway
+
 The GDK Broadway backend provides support for displaying GTK applications in
 a web browser, using HTML5 and web sockets.
 
-Broadway was written as an experiment and is not the most actively developed
-backend. It supports the features that were required of GDK backends in GTK 4.0,
-but may not be up-to-date with the latest developments.
-
-## Using GTK with Broadway
-
-To run your application under Broadway, first run the broadway server,
+To run your application in this way, first run the broadway server,
 `gtk-broadwayd`, that ships with GTK:
 
 ```

docs/reference/gtk/drawing-model.md

@@ -66,8 +66,8 @@ The clock has several phases:
 - Layout
 - Paint
 
-The phases happen in this order and all phases will always run
-through before going back to the start.
+ The phases happens in this order and we will always run each
+ phase through before going back to the start.
 
 The Events phase is a stretch of time between each redraw where
 GTK processes input events from the user and other events

docs/reference/gtk/gtk4.toml.in

@@ -260,4 +260,4 @@ name = "StyleProvider"
   hidden = true
 
 [check]
-ignore_deprecated = true
+skip_deprecated = true

docs/reference/gtk/meson.build

@@ -74,7 +74,7 @@ if get_option('documentation')
       gtk_gir[0],
     ],
     depends: gtk_gir[0],
-    suite: ['docs', 'failing'],
+    suite: ['docs'],
   )
 endif
 

docs/reference/gtk/migrating-4to5.md

@@ -24,36 +24,36 @@ the motivation and goals of larger API changes.
 ## Cell renderers are going away
 
 Cell renderers were introduced in GTK 2 to support rendering of
-“big data” UIs, in particular treeviews. Over the years, more
-“data-like” widgets have started to use them, and cell renderers
+"big data" UIs, in particular treeviews. Over the years, more
+"data-like" widgets have started to use them, and cell renderers
 have grown into a shadowy, alternative rendering infrastructure
 that duplicates much of what widgets do, while duplicating the
 code and adding their own dose of bugs.
 
-In GTK 4, replacement widgets for `GtkTreeView`, `GtkIconView` and
-`GtkComboBox` have appeared: [class@Gtk.ListView], [class@Gtk.ColumnView], [class@Gtk.GridView]
-and [class@Gtk.DropDown]. For GTK 5, we will take the next step and remove
+In GTK 4, replacement widgets for GtkTreeView, GtkIconView and
+GtkComboBox have appeared: GtkListView, GtkColumnView, GtkGridView
+and GtkDropDown. For GTK 5, we will take the next step and remove
 all cell renderer-based widgets.
 
 ## Themed rendering APIs are going away
 
 The old GTK 2 era rendering APIs for theme components like
-`gtk_render_frame()` or `gtk_render_check()` have not been used by
+gtk_render_frame() or gtk_render_check() have not been used by
 GTK itself even in later GTK 3, but they have been kept around
-for the benefit of “external drawing” users — applications that
+for the benefit of "external drawing" users - applications that
 want their controls to look like GTK without using widgets.
 
 Supporting this is increasingly getting in the way of making
 the GTK CSS machinery fast and correct. One notable problem is
-that temporary style changes (using `gtk_style_context_save()`)
+that temporary style changes (using gtk_style_context_save())
 is breaking animations. Therefore, these APIs will be going away
-in GTK 5, together with their more modern [class@Gtk.Snapshot] variants
-like `gtk_snapshot_render_background()` or `gtk_snapshot_render_focus()`.
+in GTK 5, together with their more modern GtkSnapshot variants
+like gtk_snapshot_render_background() or gtk_snapshot_render_focus().
 
 The best way to render parts of your widget using CSS styling
 is to use subwidgets. For example, to show a piece of text with
 fonts, effects and shadows according to the current CSS style,
-use a [class@Gtk.Label].
+use a GtkLabel.
 
 If you have a need for custom drawing that fits into the current
 (dark or light) theme, e.g. for rendering a graph, you can still
@@ -62,28 +62,28 @@ get the current style foreground color, using
 
 ## Local stylesheets are going away
 
-The cascading part of GTK’s CSS implementation is complicated by
+The cascading part of GTK's CSS implementation is complicated by
 the existence of local stylesheets (i.e. those added with
-`gtk_style_context_add_provider()`). And local stylesheets are
+gtk_style_context_add_provider()). And local stylesheets are
 unintuitive in that they do not apply to the whole subtree of
 widgets, but just to the one widget where the stylesheet was
 added.
 
-GTK 5 will no longer provide this functionality. The recommendation
-is to use a global stylesheet (i.e. [func@Gtk.StyleContext.add_provider_for_display])
+GTK 5 will no longer provide this functionality. The recommendations
+is to use a global stylesheet (i.e. gtk_style_context_add_provider_for_display())
 and rely on style classes to make your CSS apply only where desired.
 
 ## Non-standard CSS extensions are going away
 
-GTK’s CSS machinery has a some non-standard extensions around colors:
-named colors with `@define-color` and color functions: `lighter()`, `darker()`,
-`shade()`, `alpha()`, `mix()`.
+GTK's CSS machinery has a some non-standard extensions around colors:
+named colors with \@define-color and color functions: lighter(), darker(),
+shade(), alpha(), mix().
 
 GTK now implements equivalent functionality from the CSS specs.
 
-### `@define-color` is going away
+### \@define-color is going away
 
-`@define-color` should be replaced by custom properties in the `:root` scope.
+\@define-color should be replaced by custom properties in the :root scope.
 
 Instead of
 
@@ -117,9 +117,9 @@ spec.
 
 ### Color expressions are going away
 
-The color functions can all be replaced by combinations of `calc()` and `color-mix()`.
+The color functions can all be replaced by combinations of calc() and color-mix().
 
-`lighter(c)` and `darker(c)` are just `shade(c, 1.3)` or `shade(c, 0.7)`, respectively, and
+ligher(c) and darker(c) are just shade(c, 1.3) or shade(c, 0.7), respectively, and
 thus can be handled the same way as shade in the examples below.
 
 Replace
@@ -164,7 +164,7 @@ d {
 
 Variations of these replacements are possible.
 
-Note that GTK has historically computed `mix()` and `shade()` values in the SRGB and HSL
+Note that GTK has historically computed mix() and shade() values in the SRGB and HSL
 colorspaces, but using OKLAB instead might yield slightly better results.
 
 For more information about color-mix(), see the
@@ -172,32 +172,32 @@ For more information about color-mix(), see the
 
 ## Chooser interfaces are going away
 
-The `GtkColorChooser`, `GtkFontChooser`, `GtkFileChooser` and `GtkAppChooser`
+The GtkColorChooser, GtkFontChooser, GtkFileChooser and GtkAppChooser
 interfaces and their implementations as dialogs, buttons and widgets
 are phased out. The are being replaced by a new family of async APIs
 that will be more convenient to use from language bindings, in particular
 for languages that have concepts like promises. The new APIs are
 [class@Gtk.ColorDialog], [class@Gtk.FontDialog] and [class@Gtk.FileDialog],
-There are also equivalents for some of the “button” widgets:
+There are also equivalents for some of the 'button' widgets:
 [class@Gtk.ColorDialogButton], [class@Gtk.FontDialogButton].
 
 ## GtkMessageDialog is going away
 
-Like the Chooser interfaces, `GtkMessageDialog` has been replaced by
+Like the Chooser interfaces, GtkMessageDialog has been replaced by
 a new async API that will be more convenient, in particular for
 language binding. The new API is [class@Gtk.AlertDialog].
 
 ## GtkDialog is going away
 
-After `gtk_dialog_run()` was removed, the usefulness of `GtkDialog`
-is much reduced, and it has awkward, archaic APIs. Therefore,
+After gtk_dialog_run() was removed, the usefulness of GtkDialog
+is much reduced, and it has awkward, archaice APIs. Therefore,
 it is dropped. The recommended replacement is to just create
 your own window and add buttons as required, either in the header
 or elsewhere.
 
 ## GtkInfoBar is going away
 
-`GtkInfoBar` had a dialog API, and with dialogs going away, it was time to
+GtkInfoBar had a dialog API, and with dialogs going away, it was time to
 retire it. If you need such a widget, it is relatively trivial to create one
 using a [class@Gtk.Revealer] with labels and buttons.
 
@@ -205,11 +205,11 @@ Other libraries, such as libadwaita, may provide replacements as well.
 
 ## gtk_show_uri is being replaced
 
-Instead of `gtk_show_uri()`, you should use [class@Gtk.UriLauncher]or [class@Gtk.FileLauncher].
+Instead of gtk_show_uri(), you should use GtkUriLauncher or GtkFileLauncher.
 
 ## GtkStatusbar is going away
 
-This is an old fashioned widget that does not do all that much any more, since
+This is an oldfashioned widget that does not do all that much anymore, since
 it no longer has a resize handle for the window.
 
 ## GtkLockButton and GtkVolumeButton are going away
@@ -217,22 +217,22 @@ it no longer has a resize handle for the window.
 These are very specialized widgets that should better live with the application
 where they are used.
 
-## Widget size API changes
+## Widget size api changes
 
-The functions `gtk_widget_get_allocated_width()` and `gtk_widget_get_allocated_height()`
+The functions gtk_widget_get_allocated_width() and gtk_widget_get_allocated_height()
 are going away. In most cases, [method@Gtk.Widget.get_width] and [method@Gtk.Widget.get_height]
 are suitable replacements. Note that the semantics are slightly different though:
 the old functions return the size of the CSS border area, while the new functions return
 the size of the widgets content area. In places where this difference matters, you can
 use `gtk_widget_compute_bounds (widget, widget, &bounds)` instead.
 
-The function `gtk_widget_get_allocation()` is also going away. It does not have a direct
+The function gtk_widget_get_allocation() is also going away. It does not have a direct
 replacement, but the previously mentioned alternatives can be used for it too.
 
-The function `gtk_widget_get_allocated_baseline()` has been renamed to [method@Gtk.Widget.get_baseline].
+The function gtk_widget_get_allocated_baseline() has been renamed to [method@Gtk.Widget.get_baseline].
 
 ## Stop using GdkPixbuf
 
-GTK is moving away from `GdkPixbuf` as the primary API for transporting image data, in favor
-of [class@Gdk.Texture]. APIs that are accepting or returning `GdkPixbuf`s are being replaced by equivalent
-APIs using `GdkTexture` or [iface@Gdk.Paintable] objects.
+GTK is moving away from GdkPixbuf as the primary API for transporting image data, in favor
+of GdkTexture. APIs that are accepting or returning GdkPixbufs are being replaced by equivalent
+APIs using GdkTexture or GdkPaintable objects.

docs/reference/gtk/node-format.md

@@ -6,7 +6,7 @@ The format is a text format that follows the [CSS syntax rules](https://drafts.c
 
 The grammar of a node text representation using [the CSS value definition syntax](https://drafts.csswg.org/css-values-3/#value-defs) looks like this:
 
-    document: <@-rule>*<node>
+    document: <@-rule>*<node>*
     @-rule: @cicp "name" { <property>* }
     node: container [ "name" ] { <document> } | <node-type> [ "name" ] { <property>* } | "name"
     property: <property-name>: <node> | <value> ;
@@ -49,16 +49,12 @@ The following properties can be set for custom color states:
 | primaries | `<integer>`      | 2        | always      |
 | transfer  | `<integer>`      | 2        | always      |
 | matrix    | `<integer>`      | 2        | always      |
-| range     | `<range>`        | full     | non-default |
+| range     | `narrow | full`  | full     | non-default |
 
 Note that the primaries, transfer and matrix properties always need
 to be specified, since GTK does not allow creating color state objects
 with these being set to 2 (== unspecified).
 
-Range can have the following values:
-
-    range: narrow | full
-
 # Colors
 
 Colors can be specified with a variation of the modern CSS color syntax:
@@ -70,16 +66,6 @@ The traditional syntax for sRGB colors still works as well:
     rgba(<number>, <number>, <number>, <number)
     rgb(<number, <number>, <number>)
 
-# Rectangles
-
-Rectangles can be specified just as four integers for x, y, width and height:
-
-    rect: <number> <number> <number> <number>
-
-Rounded rectangles use a CSS-like syntax:
-
-    rounded-rect: <rect> [ "/" <number>{1,4} [ "/" <number>{1,4} ] ]
-
 # Nodes
 
 ### container
@@ -96,13 +82,6 @@ The **container** node is a special node that allows specifying a list of child
 
 Creates a node like `gsk_blend_node_new()` with the given properties.
 
-Possible values for the mode property are:
-
-    blend-mode: normal | multiply | screen | overlay | darken |
-                lighten | color-dodge | color-burn | hard-light |
-                soft-light | difference | exclusion | color |
-                hue | saturation | luminosity
-
 ### blur
 
 | property | syntax           | default                | printed     |
@@ -222,10 +201,6 @@ Creates a node like `gsk_fill_node_new()` with the given properties.
 The default child node is the default color node, but created with the
 bounds of the path.
 
-Possible values for the fill-rule property are:
-
-    fill-rule: winding | even-odd
-
 ### glshader
 
 | property   | syntax             | default                | printed     |
@@ -277,10 +252,6 @@ Creates a node like `gsk_linear_gradient_node_new()` with the given properties.
 
 Creates a node like `gsk_mask_node_new()` with the given properties.
 
-Possible values for the mode property are:
-
-    mask-mode: alpha | inverted-alpha | luminance | inverted-luminance
-
 ### opacity
 
 | property | syntax           | default                | printed     |
@@ -319,11 +290,11 @@ Creates a node like `gsk_radial_gradient_node_new()` with the given properties.
 
 ### repeat
 
-| property     | syntax     | default                | printed     |
-| ------------ | ---------- | ---------------------- | ----------- |
-| bounds       | `<rect>`   | *bounds of child node* | non-default |
-| child        | `<node>`   | color { }              | always      |
-| child-bounds | `<rect>`   | *bounds of child node* | non-default |
+| property    | syntax           | default                | printed     |
+| ----------- | ---------------- | ---------------------- | ----------- |
+| bounds      | `<rect>`         | *bounds of child node* | non-default |
+| child       | `<node>`         | color { }              | always      |
+| child-bounds| `<rect>`         | *bounds of child node* | non-default |
 
 Creates a node like `gsk_repeat_node_new()` with the given properties.
 
@@ -390,14 +361,6 @@ Creates a node like `gsk_stroke_node_new()` with the given properties.
 The default child node is the default color node, but created with the
 stroke bounds of the path.
 
-Possible values for the line-cap property are:
-
-    line-cap: butt | round | square
-
-Possible values for the line-join property are:
-
-    line-join: miter | round | bevel
-
 ### text
 
 | property     | syntax              | default             | printed     |
@@ -406,9 +369,9 @@ Possible values for the line-join property are:
 | font         | `<string>` `<url>`? | "Cantarell 15px"    | always      |
 | glyphs       | `<glyphs>`          | "Hello"             | always      |
 | offset       | `<point>`           | 0 0                 | non-default |
-| hint-style   | `<hint-style>`      | slight              | non-default |
+| hint-style   | `<hint style>`      | slight              | non-default |
 | antialias    | `<antialias>`       | gray                | non-default |
-| hint-metrics | `<hint-metrics>`    | off                 | non-default |
+| hint-metrics | `<hint metrics>`    | off                 | non-default |
 
 Creates a node like `gsk_text_node_new()` with the given properties.
 
@@ -423,17 +386,9 @@ be specified as well, like this: 40 10 0 0 color.
 If the given font does not exist or the given glyphs are invalid for the given
 font, an error node will be returned.
 
-Possible values for the hint-style property are:
-
-    hint-style: none | slight | full
-
-Possible value for the antialias property are:
-
-    antialias:  none | gray
-
-Possible value for hint-metrics are:
-
-    hint-metrics:  on | off
+Possible values for hint-style are none, slight or full.
+Possible value for antialias are none or gray.
+Possible value for hint-metrics are on or off.
 
 ### texture
 
@@ -459,15 +414,14 @@ representation for this texture is `url("data:image/png;base64,iVBORw0KGgoAAAANS
 | -------- | ---------------- | ---------------------- | ----------- |
 | bounds   | `<rect>`         | 50                     | always      |
 | texture  | `<url>`          | *see below*            | always      |
-| filter   | `filter`         | linear                 | non-default |
+| filter   | `filter`         | *see below*            | non-default |
 
 Creates a node like `gsk_texture_scale_node_new()` with the given properties.
 
 The default texture is a 10x10 checkerboard, just like for texture.
 
-Possible values for the filter property are:
-
-    filter: linear | nearest | trilinear
+The possible filter values are `linear`, `nearest` and `trilinear`, with
+`linear` being the default.
 
 ### transform
 

docs/reference/gtk/running.md

@@ -19,7 +19,8 @@ be used for end-user configuration and customization.
 ### `GTK_DEBUG`
 
 This variable can be set to a list of debug options, which cause GTK to
-print out different types of debugging information.
+print out different types of debugging information. Some of these options
+are only available when GTK has been configured with `-Ddebug=true`.
 
 `actions`
 : Actions and menu models
@@ -64,7 +65,7 @@ print out different types of debugging information.
 : Layout managers
 
 `accessibility`
-: Accessibility state changes
+: Accessibility state changs
 
 A number of keys are influencing behavior instead of just logging:
 
@@ -168,7 +169,8 @@ The `loaders.cache` file is generated by the
 ### `GDK_DEBUG`
 
 This variable can be set to a list of debug options, which cause GDK to
-print out different types of debugging information.
+print out different types of debugging information. Some of these options
+are only available when GTK has been configured with `-Ddebug=true`.
 
 `misc`
 : Miscellaneous information
@@ -221,15 +223,36 @@ A number of options affect behavior instead of logging:
 : Force graphics offload for all textures, even when slower. This allows
   to debug offloading in the absence of dmabufs.
 
+`gl-disable`
+: Disable OpenGL support
+
 `gl-no-fractional`
 : Disable fractional scaling for OpenGL.
 
 `gl-debug`
 : Insert debugging information in OpenGL
 
+`gl-disable-gl`
+: Don't allow the use of OpenGL GL API. This forces GLES to be used
+
+`gl-disable-gles`
+: Don't allow the use of OpenGL GLES API. This forces GL to be used
+
 `gl-prefer-gl`
 : Prefer OpenGL over OpenGL ES. This was the default behavior before GTK 4.14.
 
+`gl-egl`
+: Use an EGL context on X11 or Windows
+
+`gl-glx`
+: Use GLX on X11
+
+`gl-wgl`
+: Use WGL on Windows
+
+`vulkan-disable`
+: Disable Vulkan support
+
 `vulkan-validate`
 : Load the Vulkan validation layer, if available
 
@@ -239,26 +262,27 @@ A number of options affect behavior instead of logging:
 `high-depth`
 : Use high bit depth rendering if possible
 
-`linear`
-: Enable linear rendering
-
-`hdr`
-: Force HDR rendering
-
 `no-vsync`
 : Repaint instantly (uses 100% CPU with animations)
 
+`dmabuf-disable`
+: Disable dmabuf support
+
 The special value `all` can be used to turn on all debug options. The special
 value `help` can be used to obtain a list of all supported debug options.
 
 ### `GSK_DEBUG`
 
 This variable can be set to a list of debug options, which cause GSK to
-print out different types of debugging information.
+print out different types of debugging information. Some of these options
+are only available when GTK has been configured with `-Ddebug=true`.
 
 `renderer`
 : General renderer information
 
+`opengl`
+: OpenGL renderer information
+
 `vulkan`
 : Check Vulkan errors
 
@@ -285,12 +309,12 @@ A number of options affect behavior instead of logging:
 `staging`
 : Use a staging image for texture upload (Vulkan only)
 
+`offload-disable`
+: Disable graphics offload to subsurfaces
+
 `cairo`
 : Overlay error pattern over cairo drawing (finds fallbacks)
 
-`occlusion`
-: Overlay highlight over areas optimized via occlusion culling
-
 The special value `all` can be used to turn on all debug options. The special
 value `help` can be used to obtain a list of all supported debug options.
 
@@ -323,41 +347,6 @@ a `*`, which means: try all remaining backends. The special value
 backends. For more information about selecting backends,
 see the [func@Gdk.DisplayManager.get] function.
 
-### `GDK_DISABLE`
-
-This variable can be set to a list of values, which cause GDK to
-disable certain features.
-
-`gl`
-: Disable OpenGL support
-
-`gl-api`
-: Don't allow the use of OpenGL GL API. This forces GLES to be used
-
-`gles-api`
-: Don't allow the use of OpenGL GLES API. This forces GL to be used
-
-`egl`
-: Don't allow the use of an EGL context
-
-`glx`
-: Don't allow the use of GLX
-
-`wgl`
-: Don't allow the use of WGL
-
-`vulkan`
-: Disable Vulkan support
-
-`dmabuf`
-: Disable dmabuf support
-
-`offload`
-: Disable graphics offload to subsurfaces
-
-`color-mgmt`
-: Disable color management
-
 ### `GDK_GL_DISABLE`
 
 This variable can be set to a list of values, which cause GDK to
@@ -400,6 +389,15 @@ does not support them.
 `ycbr`
 : Do not support Ycbcr textures
 
+`descriptor-indexing`
+: Force slow descriptor set layout codepath
+
+`dynamic-indexing`
+: Hardcode small number of buffer and texture arrays
+
+`nonuniform-indexing`
+: Split draw calls to ensure uniform texture accesses
+
 `semaphore-export`
 : Disable sync of exported dmabufs
 
@@ -409,9 +407,6 @@ does not support them.
 `incremental-present`
 : Do not send damage regions
 
-`swapchain-maintenance`
-: Do not use advanced swapchain features
-
 The special value `all` can be used to turn on all values. The special
 value `help` can be used to obtain a list of all supported values.
 
@@ -466,12 +461,12 @@ using and the GDK backend supports them:
 This variable can be set to a list of values, which cause GSK to
 disable certain optimizations of the "ngl" and "vulkan" renderer.
 
+`uber`
+: Don't use the uber shader
+
 `clear`
 : Use shaders instead of vkCmdClearAttachment()/glClear()
 
-`merge`
-: USe one vkCmdDraw()/glDrawArrays() per operation
-
 `blit`
 : Use shaders instead of vkCmdBlit()/glBlitFramebuffer()
 
@@ -481,13 +476,6 @@ disable certain optimizations of the "ngl" and "vulkan" renderer.
 `mipmap`
 : Avoid creating mipmaps
 
-`to-image`
-: Don't fast-path creation of images for nodes
-
-`occlusion`
-: Disable occlusion culling via opacity tracking
-
-
 The special value `all` can be used to turn on all values. The special
 value `help` can be used to obtain a list of all supported values.
 
@@ -575,12 +563,6 @@ To enable the GTK inspector, you can use the <kbd>Control</kbd>+<kbd>Shift</kbd>
 <kbd>Control</kbd>+<kbd>Shift</kbd>+<kbd>D</kbd> keyboard shortcuts, or
 set the `GTK_DEBUG=interactive` environment variable.
 
-After opening the inspector, it listens for a few keyboard shortcuts that
-let you use its frame and event recording functionality without moving the
-focus away from the application window: <kbd>Super</kbd>+<kbd>R</kbd> turns
-the recording on and off, and <kbd>Super</kbd>+<kbd>C</kbd> records a single
-frame.
-
 There are a few more environment variables that can be set to influence
 how the inspector renders its UI. `GTK_INSPECTOR_DISPLAY` and
 `GTK_INSPECTOR_RENDERER` determine the GDK display and the GSK
@@ -591,7 +573,6 @@ the GTK inspector. The keyboard shortcuts can be disabled with the
 `enable-inspector-keybinding` key in the `org.gtk.Settings.Debug`
 GSettings schema.
 
-
 ## Profiling
 
 GTK supports profiling with sysprof. It exports timing information

docs/reference/gtk/section-accessibility.md

@@ -171,7 +171,7 @@ Each relation name is part of the `GtkAccessibleRelation` enumeration.
 | %GTK_ACCESSIBLE_RELATION_CONTROLS | “aria-controls” | a list of `GtkAccessible` |
 | %GTK_ACCESSIBLE_RELATION_DESCRIBED_BY | “aria-describedby” | a list of `GtkAccessible` |
 | %GTK_ACCESSIBLE_RELATION_DETAILS | “aria-details” | a list of `GtkAccessible` |
-| %GTK_ACCESSIBLE_RELATION_ERROR_MESSAGE | “aria-errormessage” | a list of `GtkAccessible` |
+| %GTK_ACCESSIBLE_RELATION_ERROR_MESSAGE | “aria-errormessage” | `GtkAccessible` |
 | %GTK_ACCESSIBLE_RELATION_FLOW_TO | “aria-flowto” | a list of `GtkAccessible` |
 | %GTK_ACCESSIBLE_RELATION_LABELLED_BY | “aria-labelledby” | a list of `GtkAccessible` |
 | %GTK_ACCESSIBLE_RELATION_OWNS | “aria-owns” | a list of `GtkAccessible` |
@@ -300,7 +300,7 @@ The attributes can also enhance the UI:
 
 ```c
 gtk_button_set_label (GTK_BUTTON (button), "Download");
-gtk_box_append (GTK_BOX (box), button);
+gtk_box_append (GTK_BOX (button), button);
 
 gtk_label_set_text (GTK_LABEL (label), "Final report.pdf");
 gtk_box_append (GTK_BOX (box), label);

docs/reference/gtk/tools.md

@@ -9,7 +9,6 @@ documentation in the form of man pages.
  - [gtk4-demo-application](gtk4-demo-application.html)
  - [gtk4-encode-symbolic-svg](gtk4-encode-symbolic-svg.html)
  - [gtk4-icon-browser](gtk4-icon-browser.html)
- - [gtk4-image-tool](gtk4-image-tool.html)
  - [gtk4-launch](gtk4-launch.html)
  - [gtk4-node-editor](gtk4-node-editor.html)
  - [gtk4-path-tool](gtk4-path-tool.html)

gdk/broadway/gdksurface-broadway.c

@@ -49,135 +49,6 @@
 
 G_DEFINE_TYPE (GdkBroadwaySurface, gdk_broadway_surface, GDK_TYPE_SURFACE)
 
-static void
-gdk_broadway_surface_toplevel_resize (GdkSurface *surface,
-                                      int         width,
-                                      int         height);
-
-static void
-gdk_broadway_surface_set_geometry_hints (GdkSurface        *surface,
-                                         const GdkGeometry *geometry,
-                                         GdkSurfaceHints    geom_mask);
-
-static void
-gdk_broadway_surface_move_resize_internal (GdkSurface *surface,
-                                           gboolean    with_move,
-                                           int         x,
-                                           int         y,
-                                           int         width,
-                                           int         height);
-
-static void
-compute_toplevel_size (GdkSurface *surface,
-                       gboolean    resizible,
-                       int        *width,
-                       int        *height)
-{
-  GdkBroadwaySurface *impl = GDK_BROADWAY_SURFACE (surface);
-  GdkDisplay *display = gdk_surface_get_display (surface);
-  GdkMonitor *monitor;
-  GdkToplevelSize size;
-  int bounds_width, bounds_height;
-  GdkGeometry geometry;
-  GdkSurfaceHints mask;
-
-  monitor = gdk_display_get_monitor_at_surface (display, surface);
-  if (monitor)
-    {
-      GdkRectangle monitor_geometry;
-
-      gdk_monitor_get_geometry (monitor, &monitor_geometry);
-      bounds_width = monitor_geometry.width;
-      bounds_height = monitor_geometry.height;
-    }
-  else
-    {
-      bounds_width = G_MAXINT;
-      bounds_height = G_MAXINT;
-    }
-
-  gdk_toplevel_size_init (&size, bounds_width, bounds_height);
-  gdk_toplevel_notify_compute_size (GDK_TOPLEVEL (surface), &size);
-  g_warn_if_fail (size.width > 0);
-  g_warn_if_fail (size.height > 0);
-  *width = size.width;
-  *height = size.height;
-  impl->resizible = (impl->resizible && resizible);
-
-  if (impl->resizible)
-    {
-      geometry.min_width = size.min_width;
-      geometry.min_height = size.min_height;
-      mask = GDK_HINT_MIN_SIZE;
-    }
-  else
-    {
-      geometry.max_width = geometry.min_width = size.width;
-      geometry.max_height = geometry.min_height = size.height;
-      mask = GDK_HINT_MIN_SIZE | GDK_HINT_MAX_SIZE;
-    }
-  gdk_broadway_surface_set_geometry_hints (surface, &geometry, mask);
-
-  if (!(surface->state & (GDK_TOPLEVEL_STATE_FULLSCREEN |
-                          GDK_TOPLEVEL_STATE_MAXIMIZED |
-                          GDK_TOPLEVEL_STATE_TILED |
-                          GDK_TOPLEVEL_STATE_TOP_TILED |
-                          GDK_TOPLEVEL_STATE_RIGHT_TILED |
-                          GDK_TOPLEVEL_STATE_BOTTOM_TILED |
-                          GDK_TOPLEVEL_STATE_LEFT_TILED |
-                          GDK_TOPLEVEL_STATE_MINIMIZED)))
-    {
-      gdk_surface_constrain_size (&geometry, mask,
-				  size.width, size.height,
-				  &size.width, &size.height);
-
-      if (impl->last_computed_width != size.width ||
-           impl->last_computed_height != size.height)
-        {
-          *width = size.width;
-          *height = size.height;
-          impl->last_computed_width = size.width;
-          impl->last_computed_height = size.height;
-
-	  gdk_broadway_surface_toplevel_resize (surface, *width, *height);
-        }
-    }
-
-  if (size.shadow.is_valid)
-    {
-      impl->shadow_left = size.shadow.left;
-      impl->shadow_right = size.shadow.right;
-      impl->shadow_top = size.shadow.top;
-      impl->shadow_bottom = size.shadow.bottom;
-    }
-}
-
-static gboolean
-compute_size_idle (gpointer user_data)
-{
-  GdkSurface *surface = user_data;
-  GdkBroadwaySurface *impl = GDK_BROADWAY_SURFACE (surface);
-  int width, height;
-
-  impl->compute_size_source_id = 0;
-  compute_toplevel_size (surface, TRUE, &width, &height);
-
-  return G_SOURCE_REMOVE;
-}
-
-static void
-on_frame_clock_after_update (GdkFrameClock *clock,
-                             GdkSurface    *surface)
-{
-  GdkBroadwaySurface *impl = GDK_BROADWAY_SURFACE (surface);
-
-  if (impl->compute_size_source_id)
-    {
-      g_clear_handle_id (&impl->compute_size_source_id, g_source_remove);
-      compute_size_idle (surface);
-    }
-}
-
 /* We need to flush in an idle rather than AFTER_PAINT, as the clock
    is frozen during e.g. surface resizes so the paint will not happen
    and the surface resize request is never flushed. */
@@ -241,8 +112,6 @@ connect_frame_clock (GdkSurface *surface)
 
   g_signal_connect (frame_clock, "before-paint",
                     G_CALLBACK (on_frame_clock_before_paint), surface);
-  g_signal_connect_after (frame_clock, "update",
-			  G_CALLBACK (on_frame_clock_after_update), surface);
   g_signal_connect (frame_clock, "after-paint",
                     G_CALLBACK (on_frame_clock_after_paint), surface);
 }
@@ -254,8 +123,6 @@ disconnect_frame_clock (GdkSurface *surface)
 
   g_signal_handlers_disconnect_by_func (frame_clock,
                                         on_frame_clock_before_paint, surface);
-  g_signal_handlers_disconnect_by_func (frame_clock,
-                                        on_frame_clock_after_update, surface);
   g_signal_handlers_disconnect_by_func (frame_clock,
                                         on_frame_clock_after_paint, surface);
 }
@@ -270,7 +137,6 @@ gdk_broadway_surface_constructed (GObject *object)
   if (!surface->parent)
     broadway_display->toplevels = g_list_prepend (broadway_display->toplevels, self);
 
-  self->resizible = TRUE;
   self->id = _gdk_broadway_server_new_surface (broadway_display->server,
                                                self->root_x,
                                                self->root_y,
@@ -450,7 +316,6 @@ gdk_broadway_surface_hide (GdkSurface *surface)
 
   _gdk_broadway_surface_grab_check_unmap (surface,
                                          _gdk_broadway_server_get_next_serial (broadway_display->server));
-  g_clear_handle_id (&impl->compute_size_source_id, g_source_remove);
 
   if (_gdk_broadway_server_surface_hide (broadway_display->server, impl->id))
     queue_flush (surface);
@@ -1144,8 +1009,6 @@ _gdk_broadway_moveresize_configure_done (GdkDisplay *display,
   BroadwayInputMsg *tmp_event;
   MoveResizeData *mv_resize = get_move_resize_data (display, FALSE);
 
-  gdk_surface_request_layout (surface);
-
   if (!mv_resize || surface != mv_resize->moveresize_surface)
     return FALSE;
 
@@ -1305,43 +1168,6 @@ gdk_broadway_surface_beep (GdkSurface *surface)
   return FALSE;
 }
 
-static void
-gdk_broadway_surface_request_layout (GdkSurface *surface)
-{
-  GdkBroadwaySurface *impl = GDK_BROADWAY_SURFACE (surface);
-
-  if (!impl->compute_size_source_id &&
-      GDK_IS_TOPLEVEL (surface))
-    {
-      impl->compute_size_source_id = g_idle_add_full (G_PRIORITY_HIGH - 10,
-                                                      compute_size_idle,
-                                                      surface,
-                                                      NULL);
-    }
-}
-
-static gboolean
-gdk_broadway_surface_compute_size (GdkSurface *surface)
-{
-  int width, height;
-
-  if (GDK_IS_TOPLEVEL (surface))
-    {
-      compute_toplevel_size (surface, TRUE, &width, &height);
-    }
-  else
-    {
-      width = gdk_surface_get_width(surface);
-      height = gdk_surface_get_height(surface);
-
-      gdk_broadway_surface_move_resize_internal (surface, FALSE,
-						 0, 0,
-						 width,
-						 height);
-    }
-  return FALSE;
-}
-
 static void
 gdk_broadway_surface_class_init (GdkBroadwaySurfaceClass *klass)
 {
@@ -1361,8 +1187,6 @@ gdk_broadway_surface_class_init (GdkBroadwaySurfaceClass *klass)
   impl_class->destroy_notify = gdk_broadway_surface_destroy_notify;
   impl_class->drag_begin = _gdk_broadway_surface_drag_begin;
   impl_class->get_scale = gdk_broadway_surface_get_scale;
-  impl_class->request_layout = gdk_broadway_surface_request_layout;
-  impl_class->compute_size = gdk_broadway_surface_compute_size;
 }
 
 #define LAST_PROP 1
@@ -1680,12 +1504,55 @@ gdk_broadway_toplevel_present (GdkToplevel       *toplevel,
                                GdkToplevelLayout *layout)
 {
   GdkSurface *surface = GDK_SURFACE (toplevel);
+  GdkBroadwaySurface *impl = GDK_BROADWAY_SURFACE (surface);
+  GdkDisplay *display = gdk_surface_get_display (surface);
+  GdkMonitor *monitor;
+  GdkToplevelSize size;
+  int bounds_width, bounds_height;
   int width, height;
+  GdkGeometry geometry;
+  GdkSurfaceHints mask;
   gboolean maximize;
 
   gdk_broadway_surface_unminimize (surface);
 
-  compute_toplevel_size (surface, gdk_toplevel_layout_get_resizable (layout), &width, &height);
+  monitor = gdk_display_get_monitor_at_surface (display, surface);
+  if (monitor)
+    {
+      GdkRectangle monitor_geometry;
+
+      gdk_monitor_get_geometry (monitor, &monitor_geometry);
+      bounds_width = monitor_geometry.width;
+      bounds_height = monitor_geometry.height;
+    }
+  else
+    {
+      bounds_width = G_MAXINT;
+      bounds_height = G_MAXINT;
+    }
+
+  gdk_toplevel_size_init (&size, bounds_width, bounds_height);
+  gdk_toplevel_notify_compute_size (toplevel, &size);
+  g_warn_if_fail (size.width > 0);
+  g_warn_if_fail (size.height > 0);
+  width = size.width;
+  height = size.height;
+
+  if (gdk_toplevel_layout_get_resizable (layout))
+    {
+      geometry.min_width = size.min_width;
+      geometry.min_height = size.min_height;
+      mask = GDK_HINT_MIN_SIZE;
+    }
+  else
+    {
+      geometry.max_width = geometry.min_width = width;
+      geometry.max_height = geometry.min_height = height;
+      mask = GDK_HINT_MIN_SIZE | GDK_HINT_MAX_SIZE;
+    }
+  gdk_broadway_surface_set_geometry_hints (surface, &geometry, mask);
+  gdk_surface_constrain_size (&geometry, mask, width, height, &width, &height);
+  gdk_broadway_surface_toplevel_resize (surface, width, height);
 
   if (gdk_toplevel_layout_get_maximized (layout, &maximize))
     {
@@ -1695,7 +1562,14 @@ gdk_broadway_toplevel_present (GdkToplevel       *toplevel,
         gdk_broadway_surface_unmaximize (surface);
     }
 
-  gdk_surface_request_layout (surface);
+  if (size.shadow.is_valid)
+    {
+      impl->shadow_left = size.shadow.left;
+      impl->shadow_right = size.shadow.right;
+      impl->shadow_top = size.shadow.top;
+      impl->shadow_bottom = size.shadow.bottom;
+    }
+
   show_surface (surface);
 }
 

gdk/broadway/gdksurface-broadway.h

@@ -76,13 +76,6 @@ struct _GdkBroadwaySurface
   int shadow_right;
   int shadow_top;
   int shadow_bottom;
-
-  int last_computed_width;
-  int last_computed_height;
-
-  guint compute_size_source_id;
-
-  gboolean resizible;
 };
 
 struct _GdkBroadwaySurfaceClass

gdk/gdk.c

@@ -133,35 +133,22 @@ static const GdkDebugKey gdk_debug_keys[] = {
   { "portals",         GDK_DEBUG_PORTALS, "Force use of portals" },
   { "no-portals",      GDK_DEBUG_NO_PORTALS, "Disable use of portals" },
   { "force-offload",   GDK_DEBUG_FORCE_OFFLOAD, "Force graphics offload for all textures" },
+  { "gl-disable",      GDK_DEBUG_GL_DISABLE, "Disable OpenGL support" },
   { "gl-no-fractional", GDK_DEBUG_GL_NO_FRACTIONAL, "Disable fractional scaling for OpenGL" },
   { "gl-debug",        GDK_DEBUG_GL_DEBUG, "Insert debugging information in OpenGL" },
+  { "gl-disable-gl",   GDK_DEBUG_GL_DISABLE_GL, "Only allow OpenGL GLES API" },
+  { "gl-disable-gles", GDK_DEBUG_GL_DISABLE_GLES, "Don't allow OpenGL GLES API" },
   { "gl-prefer-gl",    GDK_DEBUG_GL_PREFER_GL, "Prefer GL over GLES API" },
+  { "gl-egl",          GDK_DEBUG_GL_EGL, "Use EGL on X11 or Windows" },
+  { "gl-glx",          GDK_DEBUG_GL_GLX, "Use GLX on X11" },
+  { "gl-wgl",          GDK_DEBUG_GL_WGL, "Use WGL on Windows" },
+  { "vulkan-disable",  GDK_DEBUG_VULKAN_DISABLE, "Disable Vulkan support" },
   { "default-settings",GDK_DEBUG_DEFAULT_SETTINGS, "Force default values for xsettings" },
   { "high-depth",      GDK_DEBUG_HIGH_DEPTH, "Use high bit depth rendering if possible" },
   { "no-vsync",        GDK_DEBUG_NO_VSYNC, "Repaint instantly (uses 100% CPU with animations)" },
+  { "dmabuf-disable",  GDK_DEBUG_DMABUF_DISABLE, "Disable dmabuf support" },
 };
 
-static const GdkDebugKey gdk_feature_keys[] = {
-  { "gl",         GDK_FEATURE_OPENGL,           "Disable OpenGL support" },
-  { "gl-api",     GDK_FEATURE_GL_API,           "Disable non-GLES GL API" },
-  { "gles-api",   GDK_FEATURE_GLES_API,         "Disable GLES GL API" },
-  { "egl",        GDK_FEATURE_EGL,              "Disable EGL" },
-  { "glx",        GDK_FEATURE_GLX,              "Disable GLX" },
-  { "wgl",        GDK_FEATURE_WGL,              "Disable WGL" },
-  { "vulkan",     GDK_FEATURE_VULKAN,           "Disable Vulkan support" },
-  { "dmabuf",     GDK_FEATURE_DMABUF,           "Disable dmabuf support" },
-  { "offload",    GDK_FEATURE_OFFLOAD,          "Disable graphics offload" },
-  { "color-mgmt", GDK_FEATURE_COLOR_MANAGEMENT, "Disable color management" },
-};
-
-
-static GdkFeatures gdk_features;
-
-gboolean
-gdk_has_feature (GdkFeatures features)
-{
-  return (features & gdk_features) == features;
-}
 
 #ifdef G_HAS_CONSTRUCTORS
 #ifdef G_DEFINE_CONSTRUCTOR_NEEDS_PRAGMA
@@ -229,7 +216,6 @@ gdk_ensure_resources (void)
 
 guint
 gdk_parse_debug_var (const char        *variable,
-                     const char        *docs,
                      const GdkDebugKey *keys,
                      guint              nkeys)
 {
@@ -290,7 +276,6 @@ gdk_parse_debug_var (const char        *variable,
         max_width = MAX (max_width, strlen (keys[i].key));
       max_width += 4;
 
-      fprintf (stderr, "%s\n", docs);
       fprintf (stderr, "Supported %s values:\n", variable);
       for (i = 0; i < nkeys; i++) {
         fprintf (stderr, "  %s%*s%s\n", keys[i].key, (int)(max_width - strlen (keys[i].key)), " ", keys[i].help);
@@ -318,26 +303,21 @@ gdk_parse_debug_var (const char        *variable,
 void
 gdk_pre_parse (void)
 {
-  GdkFeatures disabled_features;
-
   gdk_initialized = TRUE;
 
   gdk_ensure_resources ();
 
   _gdk_debug_flags = gdk_parse_debug_var ("GDK_DEBUG",
-      "GDK_DEBUG can be set to values that make GDK print out different\n"
-      "types of debugging information or change the behavior of GDK for\n"
-      "debugging purposes.\n",
-      gdk_debug_keys,
-      G_N_ELEMENTS (gdk_debug_keys));
+                                          gdk_debug_keys,
+                                          G_N_ELEMENTS (gdk_debug_keys));
 
-  disabled_features = gdk_parse_debug_var ("GDK_DISABLE",
-      "GDK_DISABLE can be set to values which cause GDK to disable\n"
-      "certain features.\n",
-      gdk_feature_keys,
-      G_N_ELEMENTS (gdk_feature_keys));
-
-  gdk_features = GDK_ALL_FEATURES & ~disabled_features;
+  /* These are global */
+  if (_gdk_debug_flags & GDK_DEBUG_GL_EGL)
+    gdk_gl_backend_use (GDK_GL_EGL);
+  else if (_gdk_debug_flags & GDK_DEBUG_GL_GLX)
+    gdk_gl_backend_use (GDK_GL_GLX);
+  else if (_gdk_debug_flags & GDK_DEBUG_GL_WGL)
+    gdk_gl_backend_use (GDK_GL_WGL);
 
 #ifndef G_HAS_CONSTRUCTORS
   stash_and_unset_environment ();

gdk/gdkapplaunchcontext.c

@@ -120,7 +120,7 @@ gdk_app_launch_context_class_init (GdkAppLaunchContextClass *klass)
   context_class->launch_failed = gdk_app_launch_context_launch_failed;
 
   /**
-   * GdkAppLaunchContext:display:
+   * GdkAppLaunchContext:display: (attributes org.gtk.Property.get=gdk_app_launch_context_get_display)
    *
    * The display that the `GdkAppLaunchContext` is on.
    */
@@ -169,7 +169,7 @@ gdk_app_launch_context_get_display_name (GAppLaunchContext *context,
 }
 
 /**
- * gdk_app_launch_context_get_display:
+ * gdk_app_launch_context_get_display: (attributes org.gtk.Method.get_property=display)
  * @context: a `GdkAppLaunchContext`
  *
  * Gets the `GdkDisplay` that @context is for.

gdk/gdkcairocontext.c

@@ -82,10 +82,8 @@ gdk_cairo_context_cairo_create (GdkCairoContext *self)
 
   draw_context = GDK_DRAW_CONTEXT (self);
 
-G_GNUC_BEGIN_IGNORE_DEPRECATIONS
   if (!gdk_draw_context_is_in_frame (draw_context))
     return NULL;
-G_GNUC_END_IGNORE_DEPRECATIONS
 
   cr = GDK_CAIRO_CONTEXT_GET_CLASS (self)->cairo_create (self);
 

gdk/gdkcicpparams.h

@@ -58,7 +58,7 @@ void            gdk_cicp_params_set_matrix_coefficients (GdkCicpParams    *self,
 /**
  * GdkCicpRange:
  * @GDK_CICP_RANGE_NARROW: The values use the range of 16-235 (for Y) and 16-240 for u and v.
- * @GDK_CICP_RANGE_FULL: The values use the full range.
+ * @GDK_CICO_RANGE_FULL: The values use the full range.
  *
  * The values of this enumeration describe whether image data uses
  * the full range of 8-bit values.

gdk/gdkclipboard.c

@@ -353,7 +353,7 @@ gdk_clipboard_class_init (GdkClipboardClass *class)
   class->read_finish = gdk_clipboard_read_local_finish;
 
   /**
-   * GdkClipboard:display:
+   * GdkClipboard:display: (attributes org.gtk.Property.get=gdk_clipboard_get_display)
    *
    * The `GdkDisplay` that the clipboard belongs to.
    */
@@ -366,7 +366,7 @@ gdk_clipboard_class_init (GdkClipboardClass *class)
                          G_PARAM_EXPLICIT_NOTIFY);
 
   /**
-   * GdkClipboard:formats:
+   * GdkClipboard:formats: (attributes org.gtk.Property.get=gdk_clipboard_get_formats)
    *
    * The possible formats that the clipboard can provide its data in.
    */
@@ -378,7 +378,7 @@ gdk_clipboard_class_init (GdkClipboardClass *class)
                         G_PARAM_EXPLICIT_NOTIFY);
 
   /**
-   * GdkClipboard:local: (getter is_local)
+   * GdkClipboard:local: (attributes org.gtk.Property.get=gdk_clipboard_is_local)
    *
    * %TRUE if the contents of the clipboard are owned by this process.
    */
@@ -390,7 +390,7 @@ gdk_clipboard_class_init (GdkClipboardClass *class)
                           G_PARAM_EXPLICIT_NOTIFY);
 
   /**
-   * GdkClipboard:content:
+   * GdkClipboard:content: (attributes org.gtk.Property.get=gdk_clipboard_get_content)
    *
    * The `GdkContentProvider` or %NULL if the clipboard is empty or contents are
    * provided otherwise.
@@ -429,7 +429,7 @@ gdk_clipboard_init (GdkClipboard *clipboard)
 }
 
 /**
- * gdk_clipboard_get_display:
+ * gdk_clipboard_get_display: (attributes org.gtk.Method.get_property=display)
  * @clipboard: a `GdkClipboard`
  *
  * Gets the `GdkDisplay` that the clipboard was created for.
@@ -447,7 +447,7 @@ gdk_clipboard_get_display (GdkClipboard *clipboard)
 }
 
 /**
- * gdk_clipboard_get_formats:
+ * gdk_clipboard_get_formats: (attributes org.gtk.Method.get_property=formats)
  * @clipboard: a `GdkClipboard`
  *
  * Gets the formats that the clipboard can provide its current contents in.
@@ -465,7 +465,7 @@ gdk_clipboard_get_formats (GdkClipboard *clipboard)
 }
 
 /**
- * gdk_clipboard_is_local: (get-property local)
+ * gdk_clipboard_is_local: (attributes org.gtk.Method.get_property=local)
  * @clipboard: a `GdkClipboard`
  *
  * Returns if the clipboard is local.
@@ -489,7 +489,7 @@ gdk_clipboard_is_local (GdkClipboard *clipboard)
 }
 
 /**
- * gdk_clipboard_get_content:
+ * gdk_clipboard_get_content: (attributes org.gtk.Method.get_property=content)
  * @clipboard: a `GdkClipboard`
  *
  * Returns the `GdkContentProvider` currently set on @clipboard.

gdk/gdkcolor.c

@@ -229,6 +229,20 @@ gdk_color_from_rgba (GdkColor        *self,
   gdk_color_finish (&tmp);
 }
 
+/*< private >
+ * gdk_color_get_depth:
+ * @self: a `GdkColor`
+ *
+ * Returns the preferred depth for the color state of @self.
+ *
+ * Returns: the preferred depth
+ */
+GdkMemoryDepth
+(gdk_color_get_depth) (const GdkColor *self)
+{
+  return gdk_color_state_get_depth (self->color_state);
+}
+
 /*< private >
  * gdk_color_print:
  * @self: the `GdkColor` to print

gdk/gdkcolordefs.h

@@ -20,17 +20,11 @@
  * and tests, and must not include other headers.
  */
 
-static inline int
-sign (float v)
-{
-  return v < 0 ? -1 : 1;
-}
-
 static inline float
 srgb_oetf (float v)
 {
-  if (fabsf (v) > 0.0031308f)
-    return sign (v) * (1.055f * powf (fabsf (v), 1.f / 2.4f) - 0.055f);
+  if (v > 0.0031308f)
+    return 1.055f * powf (v, 1.f / 2.4f) - 0.055f;
   else
     return 12.92f * v;
 }
@@ -38,8 +32,8 @@ srgb_oetf (float v)
 static inline float
 srgb_eotf (float v)
 {
-  if (fabsf (v) >= 0.04045f)
-    return sign (v) * powf (((fabsf (v) + 0.055f) / (1.f + 0.055f)), 2.4f);
+  if (v >= 0.04045f)
+    return powf (((v + 0.055f) / (1.f + 0.055f)), 2.4f);
   else
     return v / 12.92f;
 }
@@ -47,25 +41,25 @@ srgb_eotf (float v)
 static inline float
 gamma22_oetf (float v)
 {
-  return sign (v) * powf (fabsf (v), 1.f / 2.2f);
+  return powf (v, 1.f / 2.2f);
 }
 
 static inline float
 gamma22_eotf (float v)
 {
-  return sign (v) * powf (fabsf (v), 2.2f);
+  return powf (v, 2.2f);
 }
 
 static inline float
 gamma28_oetf (float v)
 {
-  return sign (v) * powf (fabsf (v), 1.f / 2.8f);
+  return powf (v, 1.f / 2.8f);
 }
 
 static inline float
 gamma28_eotf (float v)
 {
-  return sign (v) * powf (fabsf (v), 2.8f);
+  return powf (v, 2.8f);
 }
 
 static inline float
@@ -77,10 +71,9 @@ pq_eotf (float v)
   float c2 = 2413.0 / (1 << 7);
   float c3 = 2392.0 / (1 << 7);
 
-  float x = powf (fabsf (v), minv);
-  x = powf (MAX ((x - c1), 0) / (c2 - (c3 * x)), ninv);
+  float x = powf (MAX ((powf (v, minv) - c1), 0) / (c2 - (c3 * (powf (v, minv)))), ninv);
 
-  return sign (v) * x * 10000 / 203.0;
+  return x * 10000 / 203.0;
 }
 
 static inline float
@@ -93,8 +86,7 @@ pq_oetf (float v)
   float c2 = 2413.0 / (1 << 7);
   float c3 = 2392.0 / (1 << 7);
 
-  x = powf (fabsf (x), n);
-  return sign (v) * powf (((c1 + (c2 * x)) / (1 + (c3 * x))), m);
+  return powf (((c1 + (c2 * powf (x, n))) / (1 + (c3 * powf (x, n)))), m);
 }
 
 static inline float
@@ -103,10 +95,10 @@ bt709_eotf (float v)
   const float a = 1.099;
   const float d = 0.0812;
 
-  if (fabsf (v) < d)
+  if (v < d)
     return  v / 4.5f;
   else
-    return sign (v) * powf ((fabsf (v) + (a - 1)) / a, 1 / 0.45f);
+    return powf ((v + (a - 1)) / a, 1 / 0.45f);
 }
 
 static inline float
@@ -115,10 +107,10 @@ bt709_oetf (float v)
   const float a = 1.099;
   const float b = 0.018;
 
-  if (fabsf (v) < b)
+  if (v < b)
     return v * 4.5f;
   else
-    return sign (v) * (a * powf (fabsf (v), 0.45f) - (a - 1));
+    return a * powf (v, 0.45f) - (a - 1);
 }
 
 static inline float
@@ -128,10 +120,10 @@ hlg_eotf (float v)
   const float b = 0.28466892;
   const float c = 0.55991073;
 
-  if (fabsf (v) <= 0.5)
-    return sign (v) * (v * v) / 3;
+  if (v <= 0.5)
+    return (v * v) / 3;
   else
-    return sign (v) * (expf ((fabsf (v) - c) / a) + b) / 12.0;
+    return (expf ((v - c) / a) + b) / 12.0;
 }
 
 static inline float
@@ -141,10 +133,10 @@ hlg_oetf (float v)
   const float b = 0.28466892;
   const float c = 0.55991073;
 
-  if (fabsf (v) <= 1/12.0)
-    return sign (v) * sqrtf (3 * fabsf (v));
+  if (v <= 1/12.0)
+    return sqrtf (3 * v);
   else
-    return sign (v) * (a * logf (12 * fabsf (v) - b) + c);
+    return a * logf (12 * v - b) + c;
 }
 
 /* See http://www.brucelindbloom.com/index.html?Eqn_RGB_XYZ_Matrix.html

gdk/gdkcolorimpl.h

@@ -116,10 +116,7 @@ _gdk_color_to_float (const GdkColor  *self,
 {
   if (gdk_color_state_equal (self->color_state, color_state))
     {
-      values[0] = self->values[0];
-      values[1] = self->values[1];
-      values[2] = self->values[2];
-      values[3] = self->values[3];
+      memcpy (values, self->values, sizeof (float) * 4);
       return;
     }
 
@@ -129,3 +126,10 @@ _gdk_color_to_float (const GdkColor  *self,
                                  values);
 }
 
+#define gdk_color_get_depth(self) _gdk_color_get_depth ((self))
+static inline GdkMemoryDepth
+_gdk_color_get_depth (const GdkColor *self)
+{
+  return gdk_color_state_get_depth (self->color_state);
+}
+

gdk/gdkcolorprivate.h

@@ -83,6 +83,7 @@ gboolean          gdk_color_equal               (const GdkColor         *color1,
                                                  const GdkColor         *color2);
 gboolean          gdk_color_is_clear            (const GdkColor         *self);
 gboolean          gdk_color_is_opaque           (const GdkColor         *self);
+GdkMemoryDepth    gdk_color_get_depth           (const GdkColor         *self);
 
 void              gdk_color_convert             (GdkColor               *self,
                                                  GdkColorState          *color_state,

gdk/gdkcolorstate.c

@@ -38,9 +38,9 @@
  * Crucially, GTK knows how to convert colors from one color
  * state to another.
  *
- * `GdkColorState` objects are immutable and therefore threadsafe.
+ * `GdkColorState objects are immutable and therefore threadsafe.
  *
- * Since: 4.16
+ * Since 4.16
  */
 
 G_DEFINE_BOXED_TYPE (GdkColorState, gdk_color_state,
@@ -331,68 +331,6 @@ gdk_default_color_state_get_cicp (GdkColorState *color_state)
   return &self->cicp;
 }
 
-static gboolean
-gdk_color_state_check_inf_nan (const float src[4],
-                               float       dest[4])
-{
-  if (isnan (src[0]) ||
-      isnan (src[1]) ||
-      isnan (src[2]) ||
-      isnan (src[3]))
-    {
-      dest = (float[4]) { 1.0, 0.0, 0.8, 1.0 };
-      return TRUE;
-    }
-  if (isinf (src[0]) ||
-      isinf (src[1]) ||
-      isinf (src[2]) ||
-      isinf (src[3]))
-    {
-      dest = (float[4]) { 0.0, 0.8, 1.0, 1.0 };
-      return TRUE;
-    }
-
-  return FALSE;
-}
-
-static void
-gdk_color_state_clamp_0_1 (GdkColorState *self,
-                           const float    src[4],
-                           float          dest[4])
-{
-  if (gdk_color_state_check_inf_nan (src, dest))
-    return;
-
-  dest[0] = CLAMP (src[0], 0.0f, 1.0f);
-  dest[1] = CLAMP (src[1], 0.0f, 1.0f);
-  dest[2] = CLAMP (src[2], 0.0f, 1.0f);
-  dest[3] = CLAMP (src[3], 0.0f, 1.0f);
-}
-
-static void
-gdk_color_state_clamp_unbounded (GdkColorState *self,
-                                 const float    src[4],
-                                 float          dest[4])
-{
-  if (gdk_color_state_check_inf_nan (src, dest))
-    return;
-
-  dest[0] = src[0];
-  dest[1] = src[1];
-  dest[2] = src[2];
-  dest[3] = CLAMP (src[3], 0.0f, 1.0f);
-}
-
-static void
-gdk_default_color_state_clamp (GdkColorState *color_state,
-                               const float    in[4],
-                               float          out[4])
-{
-  GdkDefaultColorState *self = (GdkDefaultColorState *) color_state;
-
-  self->clamp (color_state, in, out);
-}
-
 /* }}} */
 
 static const
@@ -404,7 +342,6 @@ GdkColorStateClass GDK_DEFAULT_COLOR_STATE_CLASS = {
   .get_convert_to = gdk_default_color_state_get_convert_to,
   .get_convert_from = gdk_default_color_state_get_convert_from,
   .get_cicp = gdk_default_color_state_get_cicp,
-  .clamp = gdk_default_color_state_clamp,
 };
 
 GdkDefaultColorState gdk_default_color_states[] = {
@@ -413,8 +350,7 @@ GdkDefaultColorState gdk_default_color_states[] = {
       .klass = &GDK_DEFAULT_COLOR_STATE_CLASS,
       .ref_count = 0,
       .depth = GDK_MEMORY_U8_SRGB,
-      .rendering_color_state = GDK_COLOR_STATE_SRGB,
-      .rendering_color_state_linear = GDK_COLOR_STATE_SRGB_LINEAR,
+      .rendering_color_state = GDK_COLOR_STATE_SRGB_LINEAR,
     },
     .name = "srgb",
     .no_srgb = GDK_COLOR_STATE_SRGB_LINEAR,
@@ -423,7 +359,6 @@ GdkDefaultColorState gdk_default_color_states[] = {
       [GDK_COLOR_STATE_ID_REC2100_PQ] = gdk_default_srgb_to_rec2100_pq,
       [GDK_COLOR_STATE_ID_REC2100_LINEAR] = gdk_default_srgb_to_rec2100_linear,
     },
-    .clamp = gdk_color_state_clamp_0_1,
     .cicp = { 1, 13, 0, 1 },
   },
   [GDK_COLOR_STATE_ID_SRGB_LINEAR] = {
@@ -432,7 +367,6 @@ GdkDefaultColorState gdk_default_color_states[] = {
       .ref_count = 0,
       .depth = GDK_MEMORY_U8,
       .rendering_color_state = GDK_COLOR_STATE_SRGB_LINEAR,
-      .rendering_color_state_linear = GDK_COLOR_STATE_SRGB_LINEAR,
     },
     .name = "srgb-linear",
     .no_srgb = NULL,
@@ -441,7 +375,6 @@ GdkDefaultColorState gdk_default_color_states[] = {
       [GDK_COLOR_STATE_ID_REC2100_PQ] = gdk_default_srgb_linear_to_rec2100_pq,
       [GDK_COLOR_STATE_ID_REC2100_LINEAR] = gdk_default_srgb_linear_to_rec2100_linear,
     },
-    .clamp = gdk_color_state_clamp_0_1,
     .cicp = { 1, 8, 0, 1 },
   },
   [GDK_COLOR_STATE_ID_REC2100_PQ] = {
@@ -449,8 +382,7 @@ GdkDefaultColorState gdk_default_color_states[] = {
       .klass = &GDK_DEFAULT_COLOR_STATE_CLASS,
       .ref_count = 0,
       .depth = GDK_MEMORY_FLOAT16,
-      .rendering_color_state = GDK_COLOR_STATE_REC2100_PQ,
-      .rendering_color_state_linear = GDK_COLOR_STATE_REC2100_LINEAR,
+      .rendering_color_state = GDK_COLOR_STATE_REC2100_LINEAR,
     },
     .name = "rec2100-pq",
     .no_srgb = NULL,
@@ -459,7 +391,6 @@ GdkDefaultColorState gdk_default_color_states[] = {
       [GDK_COLOR_STATE_ID_SRGB_LINEAR] = gdk_default_rec2100_pq_to_srgb_linear,
       [GDK_COLOR_STATE_ID_REC2100_LINEAR] = gdk_default_rec2100_pq_to_rec2100_linear,
     },
-    .clamp = gdk_color_state_clamp_0_1,
     .cicp = { 9, 16, 0, 1 },
   },
   [GDK_COLOR_STATE_ID_REC2100_LINEAR] = {
@@ -468,7 +399,6 @@ GdkDefaultColorState gdk_default_color_states[] = {
       .ref_count = 0,
       .depth = GDK_MEMORY_FLOAT16,
       .rendering_color_state = GDK_COLOR_STATE_REC2100_LINEAR,
-      .rendering_color_state_linear = GDK_COLOR_STATE_REC2100_LINEAR,
     },
     .name = "rec2100-linear",
     .no_srgb = NULL,
@@ -477,7 +407,6 @@ GdkDefaultColorState gdk_default_color_states[] = {
       [GDK_COLOR_STATE_ID_SRGB_LINEAR] = gdk_default_rec2100_linear_to_srgb_linear,
       [GDK_COLOR_STATE_ID_REC2100_PQ] = gdk_default_rec2100_linear_to_rec2100_pq,
     },
-    .clamp = gdk_color_state_clamp_unbounded,
     .cicp = { 9, 8, 0, 1 },
   },
 };
@@ -492,15 +421,15 @@ struct _GdkCicpColorState
 
   GdkColorState *no_srgb;
 
-  char *name;
+  const char *name;
 
   GdkTransferFunc eotf;
   GdkTransferFunc oetf;
 
-  float to_srgb[9];
-  float to_rec2020[9];
-  float from_srgb[9];
-  float from_rec2020[9];
+  float *to_srgb;
+  float *to_rec2020;
+  float *from_srgb;
+  float *from_rec2020;
 
   GdkCicp cicp;
 };
@@ -520,6 +449,7 @@ TRANSFORM(gdk_cicp_from_rec2100_linear, NONE,        cicp->from_rec2020, cicp->o
 
 #undef cicp
 
+/* }}} */
 /* }}} */
 /* {{{ Vfuncs */
 
@@ -528,11 +458,14 @@ gdk_cicp_color_state_free (GdkColorState *cs)
 {
   GdkCicpColorState *self = (GdkCicpColorState *) cs;
 
-  g_free (self->name);
-
   if (self->no_srgb)
     gdk_color_state_unref (self->no_srgb);
 
+  g_free (self->to_srgb);
+  g_free (self->to_rec2020);
+  g_free (self->from_srgb);
+  g_free (self->from_rec2020);
+
   g_free (self);
 }
 
@@ -622,7 +555,7 @@ gdk_cicp_color_state_get_cicp (GdkColorState  *color_state)
   return &self->cicp;
 }
 
-/* }}} */
+/* }}} */ 
 
 static const
 GdkColorStateClass GDK_CICP_COLOR_STATE_CLASS = {
@@ -633,7 +566,6 @@ GdkColorStateClass GDK_CICP_COLOR_STATE_CLASS = {
   .get_convert_to = gdk_cicp_color_state_get_convert_to,
   .get_convert_from = gdk_cicp_color_state_get_convert_from,
   .get_cicp = gdk_cicp_color_state_get_cicp,
-  .clamp = gdk_color_state_clamp_0_1,
 };
 
 static inline float *
@@ -762,8 +694,7 @@ gdk_color_state_new_for_cicp (const GdkCicp  *cicp,
   self->parent.ref_count = 1;
 
   /* sRGB is special-cased by being a default colorstate */
-  self->parent.rendering_color_state = GDK_COLOR_STATE_REC2100_PQ;
-  self->parent.rendering_color_state_linear = GDK_COLOR_STATE_REC2100_LINEAR;
+  self->parent.rendering_color_state = GDK_COLOR_STATE_REC2100_LINEAR;
 
   self->parent.depth = GDK_MEMORY_FLOAT16;
 
@@ -772,10 +703,10 @@ gdk_color_state_new_for_cicp (const GdkCicp  *cicp,
   self->eotf = eotf;
   self->oetf = oetf;
 
-  multiply (self->to_srgb, xyz_to_srgb, to_xyz);
-  multiply (self->to_rec2020, xyz_to_rec2020, to_xyz);
-  multiply (self->from_srgb, from_xyz, srgb_to_xyz);
-  multiply (self->from_rec2020, from_xyz, rec2020_to_xyz);
+  self->to_srgb = multiply (g_new (float, 9), xyz_to_srgb, to_xyz);
+  self->to_rec2020 = multiply (g_new (float, 9), xyz_to_rec2020, to_xyz);
+  self->from_srgb = multiply (g_new (float, 9), from_xyz, srgb_to_xyz);
+  self->from_rec2020 = multiply (g_new (float, 9), from_xyz, rec2020_to_xyz);
 
   self->name = g_strdup_printf ("cicp-%u/%u/%u/%u",
                                 cicp->color_primaries,
@@ -785,12 +716,12 @@ gdk_color_state_new_for_cicp (const GdkCicp  *cicp,
 
   if (cicp->transfer_function == 13)
     {
-      self->no_srgb = gdk_color_state_new_for_cicp (&(GdkCicp) {
-                                                      cicp->color_primaries,
-                                                      8,
-                                                      cicp->matrix_coefficients,
-                                                      cicp->range },
-                                                    NULL);
+      GdkCicp no_srgb;
+
+      memcpy (&no_srgb, cicp, sizeof (GdkCicp));
+      no_srgb.transfer_function = 8;
+
+      self->no_srgb = gdk_color_state_new_for_cicp (&no_srgb, NULL);
     }
 
   return (GdkColorState *) self;
@@ -838,24 +769,6 @@ gdk_color_state_get_no_srgb_tf (GdkColorState *self)
   return self->klass->get_no_srgb_tf (self);
 }
 
-/*< private >
- * gdk_color_state_clamp:
- * @self: a `GdkColorState`
- * @src: the values to clamp
- * @dest: (out): location to store the result, may be identical to
- *   the src argument
- *
- * Clamps the values to be within the allowed ranges for the given
- * color state.
- */
-void
-gdk_color_state_clamp (GdkColorState *self,
-                       const float    src[4],
-                       float          dest[4])
-{
-  self->klass->clamp (self, src, dest);
-}
-
 /* }}} */
 
 /* vim:set foldmethod=marker expandtab: */

gdk/gdkcolorstateprivate.h

@@ -26,7 +26,6 @@ struct _GdkColorState
 
   GdkMemoryDepth depth;
   GdkColorState *rendering_color_state;
-  GdkColorState *rendering_color_state_linear;
 };
 
 /* Note: self may be the source or the target colorstate */
@@ -46,9 +45,6 @@ struct _GdkColorStateClass
   GdkFloatColorConvert  (* get_convert_from)    (GdkColorState  *self,
                                                  GdkColorState  *source);
   const GdkCicp *       (* get_cicp)            (GdkColorState  *self);
-  void                  (* clamp)               (GdkColorState  *self,
-                                                 const float     src[4],
-                                                 float           dest[4]);
 };
 
 typedef struct _GdkDefaultColorState GdkDefaultColorState;
@@ -60,9 +56,6 @@ struct _GdkDefaultColorState
   const char *name;
   GdkColorState *no_srgb;
   GdkFloatColorConvert convert_to[GDK_COLOR_STATE_N_IDS];
-  void (* clamp) (GdkColorState  *self,
-                  const float     src[4],
-                  float           dest[4]);
 
   GdkCicp cicp;
 };
@@ -84,20 +77,23 @@ GdkColorState * gdk_color_state_get_no_srgb_tf          (GdkColorState
 GdkColorState * gdk_color_state_new_for_cicp            (const GdkCicp          *cicp,
                                                          GError                **error);
 
-void            gdk_color_state_clamp                   (GdkColorState          *self,
-                                                         const float             src[4],
-                                                         float                   dest[4]);
-
 static inline GdkColorState *
-gdk_color_state_get_rendering_color_state (GdkColorState *self)
+gdk_color_state_get_rendering_color_state (GdkColorState *self,
+                                           gboolean       srgb)
 {
+  if (srgb)
+    {
+      self = gdk_color_state_get_no_srgb_tf (self);
+      g_assert (self);
+    }
+
   if (GDK_DEBUG_CHECK (HDR))
     self = GDK_COLOR_STATE_REC2100_PQ;
 
   if (!GDK_DEBUG_CHECK (LINEAR))
-    return self->rendering_color_state;
+    return self;
 
-  return self->rendering_color_state_linear;
+  return self->rendering_color_state;
 }
 
 static inline GdkMemoryDepth
@@ -187,10 +183,7 @@ gdk_color_state_convert_color (GdkColorState *src_cs,
   GdkFloatColorConvert convert = NULL;
   GdkFloatColorConvert convert2 = NULL;
 
-  dest[0] = src[0];
-  dest[1] = src[1];
-  dest[2] = src[2];
-  dest[3] = src[3];
+  memcpy (dest, src, sizeof (float) * 4);
 
   if (gdk_color_state_equal (src_cs, dest_cs))
     return;
@@ -224,3 +217,4 @@ gdk_color_state_from_rgba (GdkColorState *self,
                                  self,
                                  out_color);
 }
+

gdk/gdkcontentprovider.c

@@ -169,7 +169,7 @@ gdk_content_provider_class_init (GdkContentProviderClass *class)
   class->get_value = gdk_content_provider_real_get_value;
 
   /**
-   * GdkContentProvider:formats: (getter ref_formats)
+   * GdkContentProvider:formats: (attributes org.gtk.Property.get=gdk_content_provider_ref_formats)
    *
    * The possible formats that the provider can provide its data in.
    */
@@ -181,7 +181,7 @@ gdk_content_provider_class_init (GdkContentProviderClass *class)
                         G_PARAM_EXPLICIT_NOTIFY);
 
   /**
-   * GdkContentProvider:storable-formats: (getter ref_storable_formats)
+   * GdkContentProvider:storable-formats: (attributes org.gtk.Property.get=gdk_content_provider_ref_storable_formats)
    *
    * The subset of formats that clipboard managers should store this provider's data in.
    */
@@ -214,7 +214,7 @@ gdk_content_provider_init (GdkContentProvider *provider)
 }
 
 /**
- * gdk_content_provider_ref_formats: (get-property formats)
+ * gdk_content_provider_ref_formats: (attributes org.gtk.Method.get_property=formats)
  * @provider: a `GdkContentProvider`
  *
  * Gets the formats that the provider can provide its current contents in.
@@ -230,7 +230,7 @@ gdk_content_provider_ref_formats (GdkContentProvider *provider)
 }
 
 /**
- * gdk_content_provider_ref_storable_formats: (get-property storable-formats)
+ * gdk_content_provider_ref_storable_formats: (attributes org.gtk.Method.get_property=storable-formats)
  * @provider: a `GdkContentProvider`
  *
  * Gets the formats that the provider suggests other applications to store

gdk/gdkcursor.c

@@ -172,7 +172,7 @@ gdk_cursor_class_init (GdkCursorClass *cursor_class)
   object_class->finalize = gdk_cursor_finalize;
 
   /**
-   * GdkCursor:fallback:
+   * GdkCursor:fallback: (attributes org.gtk.Property.get=gdk_cursor_get_fallback)
    *
    * Cursor to fall back to if this cursor cannot be displayed.
    */
@@ -184,7 +184,7 @@ gdk_cursor_class_init (GdkCursorClass *cursor_class)
                                                         G_PARAM_STATIC_STRINGS));
 
   /**
-   * GdkCursor:hotspot-x:
+   * GdkCursor:hotspot-x: (attributes org.gtk.Property.get=gdk_cursor_get_hotspot_x)
    *
    * X position of the cursor hotspot in the cursor image.
    */
@@ -196,7 +196,7 @@ gdk_cursor_class_init (GdkCursorClass *cursor_class)
                                                      G_PARAM_STATIC_STRINGS));
 
   /**
-   * GdkCursor:hotspot-y:
+   * GdkCursor:hotspot-y: (attributes org.gtk.Property.get=gdk_cursor_get_hotspot_y)
    *
    * Y position of the cursor hotspot in the cursor image.
    */
@@ -208,7 +208,7 @@ gdk_cursor_class_init (GdkCursorClass *cursor_class)
                                                      G_PARAM_STATIC_STRINGS));
 
   /**
-   * GdkCursor:name:
+   * GdkCursor:name: (attributes org.gtk.Property.get=gdk_cursor_get_name)
    *
    * Name of this this cursor.
    *
@@ -407,7 +407,7 @@ gdk_cursor_new_from_callback (GdkCursorGetTextureCallback  callback,
 }
 
 /**
- * gdk_cursor_get_fallback:
+ * gdk_cursor_get_fallback: (attributes org.gtk.Method.get_property=fallback)
  * @cursor: a `GdkCursor`
  *
  * Returns the fallback for this @cursor.
@@ -430,7 +430,7 @@ gdk_cursor_get_fallback (GdkCursor *cursor)
 }
 
 /**
- * gdk_cursor_get_name:
+ * gdk_cursor_get_name: (attributes org.gtk.Method.get_property=name)
  * @cursor: a `GdkCursor`
  *
  * Returns the name of the cursor.
@@ -468,7 +468,7 @@ gdk_cursor_get_texture (GdkCursor *cursor)
 }
 
 /**
- * gdk_cursor_get_hotspot_x:
+ * gdk_cursor_get_hotspot_x: (attributes org.gtk.Method.get_property=hotspot-x)
  * @cursor: a `GdkCursor`
  *
  * Returns the horizontal offset of the hotspot.
@@ -490,7 +490,7 @@ gdk_cursor_get_hotspot_x (GdkCursor *cursor)
 }
 
 /**
- * gdk_cursor_get_hotspot_y:
+ * gdk_cursor_get_hotspot_y: (attributes org.gtk.Method.get_property=hotspot-y)
  * @cursor: a `GdkCursor`
  *
  * Returns the vertical offset of the hotspot.

gdk/gdkdebugprivate.h

@@ -44,38 +44,29 @@ typedef enum {
   GDK_DEBUG_HDR             = 1 << 14,
   GDK_DEBUG_PORTALS         = 1 << 15,
   GDK_DEBUG_NO_PORTALS      = 1 << 16,
-  GDK_DEBUG_GL_NO_FRACTIONAL= 1 << 17,
-  GDK_DEBUG_FORCE_OFFLOAD   = 1 << 18,
-  GDK_DEBUG_GL_PREFER_GL    = 1 << 19,
-  GDK_DEBUG_GL_DEBUG        = 1 << 20,
-  GDK_DEBUG_DEFAULT_SETTINGS= 1 << 21,
-  GDK_DEBUG_HIGH_DEPTH      = 1 << 22,
-  GDK_DEBUG_NO_VSYNC        = 1 << 23,
+  GDK_DEBUG_GL_DISABLE      = 1 << 17,
+  GDK_DEBUG_GL_NO_FRACTIONAL= 1 << 18,
+  GDK_DEBUG_FORCE_OFFLOAD   = 1 << 19,
+  GDK_DEBUG_GL_DISABLE_GL   = 1 << 20,
+  GDK_DEBUG_GL_DISABLE_GLES = 1 << 21,
+  GDK_DEBUG_GL_PREFER_GL    = 1 << 22,
+  GDK_DEBUG_GL_DEBUG        = 1 << 23,
+  GDK_DEBUG_GL_EGL          = 1 << 24,
+  GDK_DEBUG_GL_GLX          = 1 << 25,
+  GDK_DEBUG_GL_WGL          = 1 << 26,
+  GDK_DEBUG_VULKAN_DISABLE  = 1 << 27,
+  GDK_DEBUG_DEFAULT_SETTINGS= 1 << 28,
+  GDK_DEBUG_HIGH_DEPTH      = 1 << 29,
+  GDK_DEBUG_NO_VSYNC        = 1 << 30,
+  GDK_DEBUG_DMABUF_DISABLE  = 1 << 31,
 } GdkDebugFlags;
 
-typedef enum {
-  GDK_FEATURE_OPENGL           = 1 << 0,
-  GDK_FEATURE_GL_API           = 1 << 1,
-  GDK_FEATURE_GLES_API         = 1 << 2,
-  GDK_FEATURE_EGL              = 1 << 3,
-  GDK_FEATURE_GLX              = 1 << 4,
-  GDK_FEATURE_WGL              = 1 << 5,
-  GDK_FEATURE_VULKAN           = 1 << 6,
-  GDK_FEATURE_DMABUF           = 1 << 7,
-  GDK_FEATURE_OFFLOAD          = 1 << 8,
-  GDK_FEATURE_COLOR_MANAGEMENT = 1 << 9,
-} GdkFeatures;
-
-#define GDK_ALL_FEATURES ((1 << 10) - 1)
-
 extern guint _gdk_debug_flags;
 
 GdkDebugFlags    gdk_display_get_debug_flags    (GdkDisplay       *display);
 void             gdk_display_set_debug_flags    (GdkDisplay       *display,
                                                  GdkDebugFlags     flags);
 
-gboolean         gdk_has_feature                (GdkFeatures       feature);
-
 static inline void
 gdk_debug_message (const char *format, ...) G_GNUC_PRINTF(1, 2);
 static inline void
@@ -115,7 +106,6 @@ typedef struct
 } GdkDebugKey;
 
 guint gdk_parse_debug_var (const char        *variable,
-                           const char        *docs,
                            const GdkDebugKey *keys,
                            guint              nkeys);
 

gdk/gdkdevice.c

@@ -104,7 +104,7 @@ gdk_device_class_init (GdkDeviceClass *klass)
   object_class->get_property = gdk_device_get_property;
 
   /**
-   * GdkDevice:display:
+   * GdkDevice:display: (attributes org.gtk.Property.get=gdk_device_get_display)
    *
    * The `GdkDisplay` the `GdkDevice` pertains to.
    */
@@ -114,7 +114,7 @@ gdk_device_class_init (GdkDeviceClass *klass)
                            G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDevice:name:
+   * GdkDevice:name: (attributes org.gtk.Property.get=gdk_device_get_name)
    *
    * The device name.
    */
@@ -125,7 +125,7 @@ gdk_device_class_init (GdkDeviceClass *klass)
                            G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDevice:source:
+   * GdkDevice:source: (attributes org.gtk.Property.get=gdk_device_get_source)
    *
    * Source type for the device.
    */
@@ -137,7 +137,7 @@ gdk_device_class_init (GdkDeviceClass *klass)
                          G_PARAM_STATIC_STRINGS | G_PARAM_EXPLICIT_NOTIFY);
 
   /**
-   * GdkDevice:has-cursor:
+   * GdkDevice:has-cursor: (attributes org.gtk.Property.get=gdk_device_get_has_cursor)
    *
    * Whether the device is represented by a cursor on the screen.
    */
@@ -159,7 +159,7 @@ gdk_device_class_init (GdkDeviceClass *klass)
                          G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDevice:vendor-id:
+   * GdkDevice:vendor-id: (attributes org.gtk.Property.get=gdk_device_get_vendor_id)
    *
    * Vendor ID of this device.
    *
@@ -172,7 +172,7 @@ gdk_device_class_init (GdkDeviceClass *klass)
                            G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDevice:product-id:
+   * GdkDevice:product-id: (attributes org.gtk.Property.get=gdk_device_get_product_id)
    *
    * Product ID of this device.
    *
@@ -185,7 +185,7 @@ gdk_device_class_init (GdkDeviceClass *klass)
                            G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDevice:seat:
+   * GdkDevice:seat: (attributes org.gtk.Property.get=gdk_device_get_seat)
    *
    * `GdkSeat` of this device.
    */
@@ -196,7 +196,7 @@ gdk_device_class_init (GdkDeviceClass *klass)
                            G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDevice:num-touches:
+   * GdkDevice:num-touches: (attributes org.gtk.Property.get=gdk_device_get_num_touches)
    *
    * The maximal number of concurrent touches on a touch device.
    *
@@ -211,7 +211,7 @@ gdk_device_class_init (GdkDeviceClass *klass)
                          G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDevice:tool: (getter get_device_tool)
+   * GdkDevice:tool: (attributes org.gtk.Property.get=gdk_device_get_device_tool)
    *
    * The `GdkDeviceTool` that is currently used with this device.
    */
@@ -221,7 +221,7 @@ gdk_device_class_init (GdkDeviceClass *klass)
                          G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDevice:direction:
+   * GdkDevice:direction: (attributes org.gtk.Property.get=gdk_device_get_direction)
    *
    * The direction of the current layout.
    *
@@ -233,7 +233,7 @@ gdk_device_class_init (GdkDeviceClass *klass)
                          G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDevice:has-bidi-layouts:
+   * GdkDevice:has-bidi-layouts: (attributes org.gtk.Property.get=gdk_device_has_bidi_layouts)
    *
    * Whether the device has both right-to-left and left-to-right layouts.
    *
@@ -245,7 +245,7 @@ gdk_device_class_init (GdkDeviceClass *klass)
                             G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDevice:caps-lock-state:
+   * GdkDevice:caps-lock-state: (attributes org.gtk.Property.get=gdk_device_get_caps_lock_state)
    *
    * Whether Caps Lock is on.
    *
@@ -257,7 +257,7 @@ gdk_device_class_init (GdkDeviceClass *klass)
                             G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDevice:num-lock-state:
+   * GdkDevice:num-lock-state: (attributes org.gtk.Property.get=gdk_device_get_num_lock_state)
    *
    * Whether Num Lock is on.
    *
@@ -269,7 +269,7 @@ gdk_device_class_init (GdkDeviceClass *klass)
                             G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDevice:scroll-lock-state:
+   * GdkDevice:scroll-lock-state: (attributes org.gtk.Property.get=gdk_device_get_scroll_lock_state)
    *
    * Whether Scroll Lock is on.
    *
@@ -281,7 +281,7 @@ gdk_device_class_init (GdkDeviceClass *klass)
                             G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDevice:modifier-state:
+   * GdkDevice:modifier-state: (attributes org.gtk.Property.get=gdk_device_get_modifier_state)
    *
    * The current modifier state of the device.
    *
@@ -540,7 +540,7 @@ gdk_device_get_name (GdkDevice *device)
 }
 
 /**
- * gdk_device_get_has_cursor:
+ * gdk_device_get_has_cursor: (attributes org.gtk.Method.get_property=has-cursor)
  * @device: a `GdkDevice`
  *
  * Determines whether the pointer follows device motion.
@@ -559,7 +559,7 @@ gdk_device_get_has_cursor (GdkDevice *device)
 }
 
 /**
- * gdk_device_get_source:
+ * gdk_device_get_source: (attributes org.gtk.Method.get_property=source)
  * @device: a `GdkDevice`
  *
  * Determines the type of the device.
@@ -599,7 +599,7 @@ gdk_device_get_axis_use (GdkDevice *device,
 }
 
 /**
- * gdk_device_get_display:
+ * gdk_device_get_display: (attributes org.gtk.Method.get_property=display)
  * @device: a `GdkDevice`
  *
  * Returns the `GdkDisplay` to which @device pertains.
@@ -1082,7 +1082,7 @@ _gdk_device_surface_at_position (GdkDevice       *device,
 }
 
 /**
- * gdk_device_get_vendor_id:
+ * gdk_device_get_vendor_id: (attributes org.gtk.Method.get_property=vendor-id)
  * @device: a physical `GdkDevice`
  *
  * Returns the vendor ID of this device.
@@ -1124,7 +1124,7 @@ gdk_device_get_vendor_id (GdkDevice *device)
 }
 
 /**
- * gdk_device_get_product_id:
+ * gdk_device_get_product_id: (attributes org.gtk.Method.get_property=product-id)
  * @device: a physical `GdkDevice`
  *
  * Returns the product ID of this device.
@@ -1157,7 +1157,7 @@ gdk_device_set_seat (GdkDevice *device,
 }
 
 /**
- * gdk_device_get_seat:
+ * gdk_device_get_seat: (attributes org.gtk.Method.get_property=seat)
  * @device: A `GdkDevice`
  *
  * Returns the `GdkSeat` the device belongs to.
@@ -1202,7 +1202,7 @@ gdk_device_get_num_touches (GdkDevice *device)
 }
 
 /**
- * gdk_device_get_device_tool: (get-property tool)
+ * gdk_device_get_device_tool: (attributes org.gtk.Method.get_property=tool)
  * @device: a `GdkDevice`
  *
  * Retrieves the current tool for @device.
@@ -1218,7 +1218,7 @@ gdk_device_get_device_tool (GdkDevice *device)
 }
 
 /**
- * gdk_device_get_caps_lock_state:
+ * gdk_device_get_caps_lock_state: (attributes org.gtk.Method.get_property=caps-lock-state)
  * @device: a `GdkDevice`
  *
  * Retrieves whether the Caps Lock modifier of the keyboard is locked.
@@ -1239,7 +1239,7 @@ gdk_device_get_caps_lock_state (GdkDevice *device)
 }
 
 /**
- * gdk_device_get_num_lock_state:
+ * gdk_device_get_num_lock_state: (attributes org.gtk.Method.get_property=num-lock-state)
  * @device: a ``GdkDevice`
  *
  * Retrieves whether the Num Lock modifier of the keyboard is locked.
@@ -1260,7 +1260,7 @@ gdk_device_get_num_lock_state (GdkDevice *device)
 }
 
 /**
- * gdk_device_get_scroll_lock_state:
+ * gdk_device_get_scroll_lock_state: (attributes org.gtk.Method.get_property=scroll-lock-state)
  * @device: a `GdkDevice`
  *
  * Retrieves whether the Scroll Lock modifier of the keyboard is locked.
@@ -1281,7 +1281,7 @@ gdk_device_get_scroll_lock_state (GdkDevice *device)
 }
 
 /**
- * gdk_device_get_modifier_state:
+ * gdk_device_get_modifier_state: (attributes org.gtk.Method.get_property=modifier-state)
  * @device: a `GdkDevice`
  *
  * Retrieves the current modifier state of the keyboard.
@@ -1302,7 +1302,7 @@ gdk_device_get_modifier_state (GdkDevice *device)
 }
 
 /**
- * gdk_device_get_direction:
+ * gdk_device_get_direction: (attributes org.gtk.Method.get_property=direction)
  * @device: a `GdkDevice`
  *
  * Returns the direction of effective layout of the keyboard.
@@ -1328,7 +1328,7 @@ gdk_device_get_direction (GdkDevice *device)
 }
 
 /**
- * gdk_device_has_bidi_layouts:
+ * gdk_device_has_bidi_layouts: (attributes org.gtk.Method.get_property=has-bidi-layouts)
  * @device: a `GdkDevice`
  *
  * Determines if layouts for both right-to-left and

gdk/gdkdevicetool.c

@@ -107,7 +107,7 @@ gdk_device_tool_class_init (GdkDeviceToolClass *klass)
   object_class->get_property = gdk_device_tool_get_property;
 
   /**
-   * GdkDeviceTool:serial:
+   * GdkDeviceTool:serial: (attributes org.gtk.Property.get=gdk_device_tool_get_serial)
    *
    * The serial number of the tool.
    */
@@ -118,7 +118,7 @@ gdk_device_tool_class_init (GdkDeviceToolClass *klass)
                                                       G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDeviceTool:tool-type:
+   * GdkDeviceTool:tool-type: (attributes org.gtk.Property.get=gdk_device_tool_get_tool_type)
    *
    * The type of the tool.
    */
@@ -130,7 +130,7 @@ gdk_device_tool_class_init (GdkDeviceToolClass *klass)
                                                        G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDeviceTool:axes:
+   * GdkDeviceTool:axes: (attributes org.gtk.Property.get=gdk_device_tool_get_axes)
    *
    * The axes of the tool.
    */
@@ -140,7 +140,7 @@ gdk_device_tool_class_init (GdkDeviceToolClass *klass)
                                                    G_PARAM_CONSTRUCT_ONLY);
 
   /**
-   * GdkDeviceTool:hardware-id:
+   * GdkDeviceTool:hardware-id: (attributes org.gtk.Property.get=gdk_device_tool_get_hardware_id)
    *
    * The hardware ID of the tool.
    */
@@ -173,7 +173,7 @@ gdk_device_tool_new (guint64           serial,
 }
 
 /**
- * gdk_device_tool_get_serial:
+ * gdk_device_tool_get_serial: (attributes org.gtk.Method.get_property=serial)
  * @tool: a `GdkDeviceTool`
  *
  * Gets the serial number of this tool.
@@ -192,7 +192,7 @@ gdk_device_tool_get_serial (GdkDeviceTool *tool)
 }
 
 /**
- * gdk_device_tool_get_hardware_id:
+ * gdk_device_tool_get_hardware_id: (attributes org.gtk.Method.get_property=hardware-id)
  * @tool: a `GdkDeviceTool`
  *
  * Gets the hardware ID of this tool, or 0 if it's not known.
@@ -218,7 +218,7 @@ gdk_device_tool_get_hardware_id (GdkDeviceTool *tool)
 }
 
 /**
- * gdk_device_tool_get_tool_type:
+ * gdk_device_tool_get_tool_type: (attributes org.gtk.Method.get_property=tool-type)
  * @tool: a `GdkDeviceTool`
  *
  * Gets the `GdkDeviceToolType` of the tool.
@@ -236,7 +236,7 @@ gdk_device_tool_get_tool_type (GdkDeviceTool *tool)
 }
 
 /**
- * gdk_device_tool_get_axes:
+ * gdk_device_tool_get_axes: (attributes org.gtk.Method.get_property=axes)
  * @tool: a `GdkDeviceTool`
  *
  * Gets the axes of the tool.

gdk/gdkdisplay.c

@@ -230,7 +230,7 @@ gdk_display_class_init (GdkDisplayClass *class)
   class->opened = gdk_display_real_opened;
 
   /**
-   * GdkDisplay:composited: (getter is_composited)
+   * GdkDisplay:composited: (attributes org.gtk.Property.get=gdk_display_is_composited)
    *
    * %TRUE if the display properly composites the alpha channel.
    */
@@ -240,7 +240,7 @@ gdk_display_class_init (GdkDisplayClass *class)
                           G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDisplay:rgba: (getter is_rgba)
+   * GdkDisplay:rgba: (attributes org.gtk.Property.get=gdk_display_is_rgba)
    *
    * %TRUE if the display supports an alpha channel.
    */
@@ -250,7 +250,7 @@ gdk_display_class_init (GdkDisplayClass *class)
                           G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDisplay:shadow-width: (getter supports_shadow_width)
+   * GdkDisplay:shadow-width: (attributes org.gtk.Property.get=gdk_display_supports_shadow_width)
    *
    * %TRUE if the display supports extensible frames.
    *
@@ -262,7 +262,7 @@ gdk_display_class_init (GdkDisplayClass *class)
                           G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDisplay:input-shapes: (getter supports_input_shapes)
+   * GdkDisplay:input-shapes: (attributes org.gtk.Property.get=gdk_display_supports_input_shapes)
    *
    * %TRUE if the display supports input shapes.
    */
@@ -272,7 +272,7 @@ gdk_display_class_init (GdkDisplayClass *class)
                           G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDisplay:dmabuf-formats:
+   * GdkDisplay:dmabuf-formats: (attributes org.gtk.Property.get=gdk_display_get_dmabuf_formats)
    *
    * The dma-buf formats that are supported on this display
    *
@@ -418,17 +418,15 @@ gdk_display_dispose (GObject *object)
 {
   GdkDisplay *display = GDK_DISPLAY (object);
   GdkDisplayPrivate *priv = gdk_display_get_instance_private (display);
+  gsize i;
 
-  if (display->vk_downloader)
+  for (i = 0; i < G_N_ELEMENTS (display->dmabuf_downloaders); i++)
     {
-      gdk_dmabuf_downloader_close (display->vk_downloader);
-      g_clear_object (&display->vk_downloader);
-    }
+      if (display->dmabuf_downloaders[i] == NULL)
+        continue;
 
-  if (display->egl_downloader)
-    {
-      gdk_dmabuf_downloader_close (display->egl_downloader);
-      g_clear_object (&display->egl_downloader);
+      gdk_dmabuf_downloader_close (display->dmabuf_downloaders[i]);
+      g_clear_object (&display->dmabuf_downloaders[i]);
     }
 
   _gdk_display_manager_remove_display (gdk_display_manager_get (), display);
@@ -1118,7 +1116,7 @@ gdk_display_get_primary_clipboard (GdkDisplay *display)
 }
 
 /**
- * gdk_display_supports_input_shapes: (get-property input-shapes)
+ * gdk_display_supports_input_shapes: (attributes org.gtk.Method.get_property=input-shapes)
  * @display: a `GdkDisplay`
  *
  * Returns %TRUE if the display supports input shapes.
@@ -1311,10 +1309,10 @@ gdk_display_create_vulkan_context (GdkDisplay  *self,
   g_return_val_if_fail (surface == NULL || GDK_IS_SURFACE (surface), NULL);
   g_return_val_if_fail (error == NULL || *error == NULL, NULL);
 
-  if (!gdk_has_feature (GDK_FEATURE_VULKAN))
+  if (gdk_display_get_debug_flags (self) & GDK_DEBUG_VULKAN_DISABLE)
     {
       g_set_error_literal (error, GDK_VULKAN_ERROR, GDK_VULKAN_ERROR_NOT_AVAILABLE,
-                           _("Vulkan support disabled via GDK_DISABLE"));
+                           _("Vulkan support disabled via GDK_DEBUG"));
       return NULL;
     }
 
@@ -1364,11 +1362,11 @@ gdk_display_init_gl (GdkDisplay *self)
 
   before = GDK_PROFILER_CURRENT_TIME;
 
-  if (!gdk_has_feature (GDK_FEATURE_OPENGL))
+  if (gdk_display_get_debug_flags (self) & GDK_DEBUG_GL_DISABLE)
     {
       g_set_error_literal (&priv->gl_error, GDK_GL_ERROR,
                            GDK_GL_ERROR_NOT_AVAILABLE,
-                           _("OpenGL support disabled via GDK_DISABLE"));
+                           _("GL support disabled via GDK_DEBUG"));
       return;
     }
 
@@ -1479,7 +1477,7 @@ gdk_display_create_gl_context (GdkDisplay  *self,
   if (!gdk_display_prepare_gl (self, error))
     return NULL;
 
-  return gdk_gl_context_new (self, NULL, FALSE);
+  return gdk_gl_context_new (self, NULL);
 }
 
 /*< private >
@@ -1967,6 +1965,33 @@ gdk_display_get_egl_display (GdkDisplay *self)
 #endif
 }
 
+#ifdef HAVE_DMABUF
+static void
+gdk_display_add_dmabuf_downloader (GdkDisplay          *display,
+                                   GdkDmabufDownloader *downloader)
+{
+  gsize i;
+
+  if (downloader == NULL)
+    return;
+
+  /* dmabuf_downloaders is NULL-terminated */
+  for (i = 0; i < G_N_ELEMENTS (display->dmabuf_downloaders) - 1; i++)
+    {
+      if (display->dmabuf_downloaders[i] == NULL)
+        break;
+    }
+
+  g_assert (i < G_N_ELEMENTS (display->dmabuf_downloaders) - 1);
+
+  display->dmabuf_downloaders[i] = downloader;
+}
+#endif
+
+/* To support a drm format, we must be able to import it into GL
+ * using the relevant EGL extensions, and download it into a memory
+ * texture, possibly doing format conversion with shaders (in GSK).
+ */
 void
 gdk_display_init_dmabuf (GdkDisplay *self)
 {
@@ -1981,21 +2006,18 @@ gdk_display_init_dmabuf (GdkDisplay *self)
   builder = gdk_dmabuf_formats_builder_new ();
 
 #ifdef HAVE_DMABUF
-  if (gdk_has_feature (GDK_FEATURE_DMABUF))
+  if (!GDK_DISPLAY_DEBUG_CHECK (self, DMABUF_DISABLE))
     {
 #ifdef GDK_RENDERING_VULKAN
-      gdk_vulkan_init_dmabuf (self);
-      if (self->vk_dmabuf_formats)
-        gdk_dmabuf_formats_builder_add_formats (builder, self->vk_dmabuf_formats);
+      gdk_display_add_dmabuf_downloader (self, gdk_vulkan_get_dmabuf_downloader (self, builder));
 #endif
 
 #ifdef HAVE_EGL
-      gdk_dmabuf_egl_init (self);
-      if (self->egl_dmabuf_formats)
-        gdk_dmabuf_formats_builder_add_formats (builder, self->egl_dmabuf_formats);
+      gdk_display_add_dmabuf_downloader (self, gdk_dmabuf_get_egl_downloader (self, builder));
 #endif
 
-      gdk_dmabuf_formats_builder_add_formats (builder, gdk_dmabuf_get_mmap_formats ());
+      gdk_dmabuf_formats_builder_add_formats (builder,
+                                              gdk_dmabuf_get_mmap_formats ());
     }
 #endif
 
@@ -2053,7 +2075,7 @@ gdk_display_set_debug_flags (GdkDisplay    *display,
 }
 
 /**
- * gdk_display_is_composited: (get-property composited)
+ * gdk_display_is_composited: (attributes org.gtk.Method.get_property=composited)
  * @display: a `GdkDisplay`
  *
  * Returns whether surfaces can reasonably be expected to have
@@ -2098,7 +2120,7 @@ gdk_display_set_composited (GdkDisplay *display,
 }
 
 /**
- * gdk_display_is_rgba: (get-property rgba)
+ * gdk_display_is_rgba: (attributes org.gtk.Method.get_property=rgba)
  * @display: a `GdkDisplay`
  *
  * Returns whether surfaces on this @display are created with an
@@ -2143,7 +2165,7 @@ gdk_display_set_rgba (GdkDisplay *display,
 }
 
 /**
- * gdk_display_supports_shadow_width: (get-property shadow-width)
+ * gdk_display_supports_shadow_width: (attributes org.gtk.Method.get_property=shadow-width)
  * @display: a `GdkDisplay`
  *
  * Returns whether it's possible for a surface to draw outside of the window area.

gdk/gdkdisplaymanager.c

@@ -149,7 +149,7 @@ gdk_display_manager_class_init (GdkDisplayManagerClass *klass)
                   GDK_TYPE_DISPLAY);
 
   /**
-   * GdkDisplayManager:default-display:
+   * GdkDisplayManager:default-display: (attributes org.gtk.Property.get=gdk_display_manager_get_default_display)
    *
    * The default display.
    */
@@ -301,7 +301,7 @@ gdk_display_manager_get (void)
 }
 
 /**
- * gdk_display_manager_get_default_display:
+ * gdk_display_manager_get_default_display: (attributes org.gtk.Method.get_property=default-display)
  * @manager: a `GdkDisplayManager`
  *
  * Gets the default `GdkDisplay`.

gdk/gdkdisplayprivate.h

@@ -48,7 +48,6 @@ typedef enum {
   GDK_VULKAN_FEATURE_SEMAPHORE_EXPORT           = 1 << 2,
   GDK_VULKAN_FEATURE_SEMAPHORE_IMPORT           = 1 << 3,
   GDK_VULKAN_FEATURE_INCREMENTAL_PRESENT        = 1 << 4,
-  GDK_VULKAN_FEATURE_SWAPCHAIN_MAINTENANCE      = 1 << 5,
 } GdkVulkanFeatures;
 
 /* Tracks information about the device grab on this display */
@@ -132,8 +131,7 @@ struct _GdkDisplay
   guint have_egl_gl_colorspace : 1;
 
   GdkDmabufFormats *dmabuf_formats;
-  GdkDmabufDownloader *egl_downloader;
-  GdkDmabufDownloader *vk_downloader;
+  GdkDmabufDownloader *dmabuf_downloaders[4];
 
    /* Cached data the EGL dmabuf downloader */
   GdkDmabufFormats *egl_dmabuf_formats;

gdk/gdkdmabuf.c

@@ -71,7 +71,7 @@ download_memcpy (guchar          *dst_data,
   bpp = gdk_memory_format_bytes_per_pixel (dst_format);
   src_stride = dmabuf->planes[0].stride;
   src_data = src_datas[0] + dmabuf->planes[0].offset;
-  g_return_if_fail (sizes[0] >= dmabuf->planes[0].offset + gdk_memory_format_min_buffer_size (dst_format, src_stride, width, height));
+  g_return_if_fail (sizes[0] >= dmabuf->planes[0].offset + gdk_memory_format_min_buffer_size (dst_format, dst_stride, width, height));
 
   if (dst_stride == src_stride)
     memcpy (dst_data, src_data, (height - 1) * dst_stride + width * bpp);

gdk/gdkdmabufegl.c

@@ -18,6 +18,7 @@
 
 #include "config.h"
 
+#if defined(HAVE_DMABUF) && defined (HAVE_EGL)
 #include "gdkdmabufeglprivate.h"
 
 #include "gdkdmabufformatsbuilderprivate.h"
@@ -31,8 +32,6 @@
 
 #include <graphene.h>
 
-#if defined(HAVE_DMABUF) && defined (HAVE_EGL)
-
 /* A dmabuf downloader implementation that downloads buffers via
  * gsk_renderer_render_texture + GL texture download.
  */
@@ -134,6 +133,77 @@ gdk_dmabuf_egl_downloader_collect_formats (GdkDisplay                *display,
   return TRUE;
 }
 
+/* Hack. We don't include gsk/gsk.h here to avoid a build order problem
+ * with the generated header gskenumtypes.h, so we need to hack around
+ * a bit to access the gsk api we need.
+ */
+
+typedef struct _GskRenderer GskRenderer;
+
+extern GskRenderer *   gsk_gl_renderer_new                      (void);
+extern gboolean        gsk_renderer_realize_for_display         (GskRenderer  *renderer,
+                                                                 GdkDisplay   *display,
+                                                                 GError      **error);
+
+GdkDmabufDownloader *
+gdk_dmabuf_get_egl_downloader (GdkDisplay              *display,
+                               GdkDmabufFormatsBuilder *builder)
+{
+  GdkDmabufFormatsBuilder *formats;
+  GdkDmabufFormatsBuilder *external;
+  gboolean retval = FALSE;
+  GError *error = NULL;
+  GskRenderer *renderer;
+  GdkGLContext *previous;
+
+  g_assert (display->egl_dmabuf_formats == NULL);
+  g_assert (display->egl_external_formats == NULL);
+
+  if (!gdk_display_prepare_gl (display, NULL))
+    return NULL;
+
+  previous = gdk_gl_context_get_current ();
+  if (previous)
+    g_object_ref (previous);
+  formats = gdk_dmabuf_formats_builder_new ();
+  external = gdk_dmabuf_formats_builder_new ();
+
+  retval = gdk_dmabuf_egl_downloader_collect_formats (display, formats, external);
+
+  display->egl_dmabuf_formats = gdk_dmabuf_formats_builder_free_to_formats (formats);
+  display->egl_external_formats = gdk_dmabuf_formats_builder_free_to_formats (external);
+
+  gdk_dmabuf_formats_builder_add_formats (builder, display->egl_dmabuf_formats);
+
+  if (!retval)
+    {
+      if (previous)
+        gdk_gl_context_make_current (previous);
+      return NULL;
+    }
+
+  renderer = gsk_gl_renderer_new ();
+
+  if (!gsk_renderer_realize_for_display (renderer, display, &error))
+    {
+      g_warning ("Failed to realize GL renderer: %s", error->message);
+      g_error_free (error);
+      g_object_unref (renderer);
+      if (previous)
+        gdk_gl_context_make_current (previous);
+
+      return NULL;
+    }
+
+  if (previous)
+    {
+      gdk_gl_context_make_current (previous);
+      g_object_unref (previous);
+    }
+
+  return GDK_DMABUF_DOWNLOADER (renderer);
+}
+
 EGLImage
 gdk_dmabuf_egl_create_image (GdkDisplay      *display,
                              int              width,
@@ -220,79 +290,3 @@ gdk_dmabuf_egl_create_image (GdkDisplay      *display,
 }
 
 #endif  /* HAVE_DMABUF && HAVE_EGL */
-
-/* Hack. We don't include gsk/gsk.h here to avoid a build order problem
- * with the generated header gskenumtypes.h, so we need to hack around
- * a bit to access the gsk api we need.
- */
-
-typedef struct _GskRenderer GskRenderer;
-
-extern GskRenderer *   gsk_gl_renderer_new                      (void);
-extern gboolean        gsk_renderer_realize_for_display         (GskRenderer  *renderer,
-                                                                 GdkDisplay   *display,
-                                                                 GError      **error);
-
-void
-gdk_dmabuf_egl_init (GdkDisplay *display)
-{
-#if defined (HAVE_DMABUF) && defined (HAVE_EGL)
-  GdkDmabufFormatsBuilder *formats;
-  GdkDmabufFormatsBuilder *external;
-  gboolean retval = FALSE;
-  GError *error = NULL;
-  GskRenderer *renderer;
-  GdkGLContext *previous;
-
-  if (display->egl_dmabuf_formats != NULL)
-    return;
-
-  if (!gdk_has_feature (GDK_FEATURE_DMABUF) ||
-      !gdk_display_prepare_gl (display, NULL))
-    {
-      return;
-    }
-
-  formats = gdk_dmabuf_formats_builder_new ();
-  external = gdk_dmabuf_formats_builder_new ();
-
-  previous = gdk_gl_context_get_current ();
-  if (previous)
-    g_object_ref (previous);
-
-  retval = gdk_dmabuf_egl_downloader_collect_formats (display, formats, external);
-
-  display->egl_dmabuf_formats = gdk_dmabuf_formats_builder_free_to_formats (formats);
-  display->egl_external_formats = gdk_dmabuf_formats_builder_free_to_formats (external);
-
-  if (!retval)
-    {
-      if (previous)
-        gdk_gl_context_make_current (previous);
-      return;
-    }
-
-  renderer = gsk_gl_renderer_new ();
-
-  if (!gsk_renderer_realize_for_display (renderer, display, &error))
-    {
-      g_warning ("Failed to realize GL renderer: %s", error->message);
-      g_error_free (error);
-      g_object_unref (renderer);
-      if (previous)
-        gdk_gl_context_make_current (previous);
-
-      return;
-    }
-
-  if (previous)
-    {
-      gdk_gl_context_make_current (previous);
-      g_object_unref (previous);
-    }
-
-  display->egl_downloader = GDK_DMABUF_DOWNLOADER (renderer);
-
-#endif
-}
-

gdk/gdkdmabufeglprivate.h

@@ -1,12 +1,14 @@
 #pragma once
 
-#include "gdkdisplayprivate.h"
 #if defined(HAVE_DMABUF) && defined (HAVE_EGL)
 
 #include "gdkdmabufprivate.h"
+#include "gdkdmabufdownloaderprivate.h"
 
 #include <epoxy/egl.h>
 
+GdkDmabufDownloader *       gdk_dmabuf_get_egl_downloader       (GdkDisplay                     *display,
+                                                                 GdkDmabufFormatsBuilder        *builder);
 EGLImage                    gdk_dmabuf_egl_create_image         (GdkDisplay                     *display,
                                                                  int                             width,
                                                                  int                             height,
@@ -14,5 +16,3 @@ EGLImage                    gdk_dmabuf_egl_create_image         (GdkDisplay
                                                                  int                             target);
 
 #endif  /* HAVE_DMABUF && HAVE_EGL */
-
-void                        gdk_dmabuf_egl_init                 (GdkDisplay                     *display);

gdk/gdkdmabuffourccprivate.h

@@ -5,10 +5,6 @@
 #include <drm_fourcc.h>
 #endif
 
-#ifndef DRM_FORMAT_MOD_INVALID
-#define DRM_FORMAT_MOD_INVALID ((1ULL << 56) - 1)
-#endif
-
 #ifndef fourcc_code
 #define fourcc_code(a, b, c, d) ((__u32)(a) | ((__u32)(b) << 8) | \
 				 ((__u32)(c) << 16) | ((__u32)(d) << 24))

gdk/gdkdmabuftexture.c

@@ -183,8 +183,10 @@ gdk_dmabuf_texture_new_from_builder (GdkDmabufTextureBuilder *builder,
   GdkDisplay *display;
   GdkDmabuf dmabuf;
   GdkColorState *color_state;
+  GError *local_error = NULL;
   int width, height;
   gboolean premultiplied;
+  gsize i;
 
   display = gdk_dmabuf_texture_builder_get_display (builder);
   width = gdk_dmabuf_texture_builder_get_width (builder);
@@ -232,28 +234,28 @@ gdk_dmabuf_texture_new_from_builder (GdkDmabufTextureBuilder *builder,
                                                  : GDK_MEMORY_R8G8B8A8;
     }
 
-  if (display->egl_downloader)
+  if (!gdk_dmabuf_formats_contains (gdk_dmabuf_get_mmap_formats (), dmabuf.fourcc, dmabuf.modifier))
     {
-      if (gdk_dmabuf_downloader_supports (display->egl_downloader, self, error))
-        self->downloader = g_object_ref (display->egl_downloader);
-    }
-
-  if (!self->downloader && display->vk_downloader)
-    {
-      g_clear_error (error);
-      if (gdk_dmabuf_downloader_supports (display->vk_downloader, self, error))
-        self->downloader = g_object_ref (display->vk_downloader);
-    }
-
-  if (!self->downloader)
-    {
-      if (!gdk_dmabuf_formats_contains (gdk_dmabuf_get_mmap_formats (), dmabuf.fourcc, dmabuf.modifier))
+      for (i = 0; display->dmabuf_downloaders[i] != NULL; i++)
         {
+          if (local_error && g_error_matches (local_error, GDK_DMABUF_ERROR, GDK_DMABUF_ERROR_UNSUPPORTED_FORMAT))
+            g_clear_error (&local_error);
+
+          if (gdk_dmabuf_downloader_supports (display->dmabuf_downloaders[i],
+                                              self,
+                                              local_error ? NULL : &local_error))
+            {
+              self->downloader = g_object_ref (display->dmabuf_downloaders[i]);
+              break;
+            }
+        }
+
+      if (self->downloader == NULL)
+        {
+          g_propagate_error (error, local_error);
           g_object_unref (self);
           return NULL;
         }
-
-      g_clear_error (error);
     }
 
   GDK_DISPLAY_DEBUG (display, DMABUF,

gdk/gdkdmabuftexturebuilder.c

@@ -272,7 +272,7 @@ gdk_dmabuf_texture_builder_class_init (GdkDmabufTextureBuilderClass *klass)
   gobject_class->set_property = gdk_dmabuf_texture_builder_set_property;
 
   /**
-   * GdkDmabufTextureBuilder:display:
+   * GdkDmabufTextureBuilder:display: (attributes org.gtk.Property.get=gdk_dmabuf_texture_builder_get_display org.gtk.Property.set=gdk_dmabuf_texture_builder_set_display)
    *
    * The display that this texture will be used on.
    *
@@ -284,7 +284,7 @@ gdk_dmabuf_texture_builder_class_init (GdkDmabufTextureBuilderClass *klass)
                          G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDmabufTextureBuilder:width:
+   * GdkDmabufTextureBuilder:width: (attributes org.gtk.Property.get=gdk_dmabuf_texture_builder_get_width org.gtk.Property.set=gdk_dmabuf_texture_builder_set_width)
    *
    * The width of the texture.
    *
@@ -296,7 +296,7 @@ gdk_dmabuf_texture_builder_class_init (GdkDmabufTextureBuilderClass *klass)
                        G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDmabufTextureBuilder:height:
+   * GdkDmabufTextureBuilder:height: (attributes org.gtk.Property.get=gdk_dmabuf_texture_builder_get_height org.gtk.Property.set=gdk_dmabuf_texture_builder_set_height)
    *
    * The height of the texture.
    *
@@ -308,7 +308,7 @@ gdk_dmabuf_texture_builder_class_init (GdkDmabufTextureBuilderClass *klass)
                        G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDmabufTextureBuilder:fourcc:
+   * GdkDmabufTextureBuilder:fourcc: (attributes org.gtk.Property.get=gdk_dmabuf_texture_builder_get_fourcc org.gtk.Property.set=gdk_dmabuf_texture_builder_set_fourcc)
    *
    * The format of the texture, as a fourcc value.
    *
@@ -346,7 +346,7 @@ gdk_dmabuf_texture_builder_class_init (GdkDmabufTextureBuilderClass *klass)
                           G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDmabufTextureBuilder:n-planes:
+   * GdkDmabufTextureBuilder:n-planes: (attributes org.gtk.Property.get=gdk_dmabuf_texture_builder_get_n_planes org.gtk.Property.set=gdk_dmabuf_texture_builder_set_n_planes)
    *
    * The number of planes of the texture.
    *
@@ -373,7 +373,7 @@ gdk_dmabuf_texture_builder_class_init (GdkDmabufTextureBuilderClass *klass)
                         G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDmabufTextureBuilder:update-region:
+   * GdkDmabufTextureBuilder:update-region: (attributes org.gtk.Property.get=gdk_dmabuf_texture_builder_get_update_region org.gtk.Property.set=gdk_dmabuf_texture_builder_set_update_region)
    *
    * The update region for [property@Gdk.GLTextureBuilder:update-texture].
    *
@@ -385,7 +385,7 @@ gdk_dmabuf_texture_builder_class_init (GdkDmabufTextureBuilderClass *klass)
                         G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDmabufTextureBuilder:update-texture:
+   * GdkDmabufTextureBuilder:update-texture: (attributes org.gtk.Property.get=gdk_dmabuf_texture_builder_get_update_texture org.gtk.Property.set=gdk_dmabuf_texture_builder_set_update_texture)
    *
    * The texture [property@Gdk.DmabufTextureBuilder:update-region] is an update for.
    *
@@ -471,7 +471,7 @@ gdk_dmabuf_texture_builder_set_display (GdkDmabufTextureBuilder *self,
 }
 
 /**
- * gdk_dmabuf_texture_builder_get_width:
+ * gdk_dmabuf_texture_builder_get_width: (attributes org.gtk.Method.get_property=width)
  * @self: a `GdkDmabufTextureBuilder`
  *
  * Gets the width previously set via gdk_dmabuf_texture_builder_set_width() or
@@ -490,7 +490,7 @@ gdk_dmabuf_texture_builder_get_width (GdkDmabufTextureBuilder *self)
 }
 
 /**
- * gdk_dmabuf_texture_builder_set_width:
+ * gdk_dmabuf_texture_builder_set_width: (attributes org.gtk.Method.set_property=width)
  * @self: a `GdkDmabufTextureBuilder`
  * @width: The texture's width or 0 to unset
  *
@@ -515,7 +515,7 @@ gdk_dmabuf_texture_builder_set_width (GdkDmabufTextureBuilder *self,
 }
 
 /**
- * gdk_dmabuf_texture_builder_get_height:
+ * gdk_dmabuf_texture_builder_get_height: (attributes org.gtk.Method.get_property=height)
  * @self: a `GdkDmabufTextureBuilder`
  *
  * Gets the height previously set via gdk_dmabuf_texture_builder_set_height() or
@@ -534,7 +534,7 @@ gdk_dmabuf_texture_builder_get_height (GdkDmabufTextureBuilder *self)
 }
 
 /**
- * gdk_dmabuf_texture_builder_set_height:
+ * gdk_dmabuf_texture_builder_set_height: (attributes org.gtk.Method.set_property=height)
  * @self: a `GdkDmabufTextureBuilder`
  * @height: the texture's height or 0 to unset
  *
@@ -559,7 +559,7 @@ gdk_dmabuf_texture_builder_set_height (GdkDmabufTextureBuilder *self,
 }
 
 /**
- * gdk_dmabuf_texture_builder_get_fourcc:
+ * gdk_dmabuf_texture_builder_get_fourcc: (attributes org.gtk.Method.get_property=fourcc)
  * @self: a `GdkDmabufTextureBuilder`
  *
  * Gets the format previously set via gdk_dmabuf_texture_builder_set_fourcc()
@@ -580,7 +580,7 @@ gdk_dmabuf_texture_builder_get_fourcc (GdkDmabufTextureBuilder *self)
 }
 
 /**
- * gdk_dmabuf_texture_builder_set_fourcc:
+ * gdk_dmabuf_texture_builder_set_fourcc: (attributes org.gtk.Method.set_property=fourcc)
  * @self: a `GdkDmabufTextureBuilder`
  * @fourcc: the texture's format or 0 to unset
  *
@@ -648,7 +648,7 @@ gdk_dmabuf_texture_builder_set_modifier (GdkDmabufTextureBuilder *self,
 }
 
 /**
- * gdk_dmabuf_texture_builder_get_n_planes:
+ * gdk_dmabuf_texture_builder_get_n_planes: (attributes org.gtk.Method.get_property=n-planes)
  * @self: a `GdkDmabufTextureBuilder`
  *
  * Gets the number of planes.
@@ -710,7 +710,7 @@ gdk_dmabuf_texture_builder_set_premultiplied (GdkDmabufTextureBuilder *self,
 }
 
 /**
- * gdk_dmabuf_texture_builder_set_n_planes:
+ * gdk_dmabuf_texture_builder_set_n_planes: (attributes org.gtk.Method.set_property=n-planes)
  * @self: a `GdkDmabufTextureBuilder`
  * @n_planes: the number of planes
  *
@@ -871,7 +871,7 @@ gdk_dmabuf_texture_builder_set_offset (GdkDmabufTextureBuilder *self,
 }
 
 /**
- * gdk_dmabuf_texture_builder_get_color_state:
+ * gdk_dmabuf_texture_builder_get_color_state: (attributes org.gtk.Method.get_property=color-state)
  * @self: a `GdkDmabufTextureBuilder`
  *
  * Gets the color state previously set via gdk_dmabuf_texture_builder_set_color_state().
@@ -889,7 +889,7 @@ gdk_dmabuf_texture_builder_get_color_state (GdkDmabufTextureBuilder *self)
 }
 
 /**
- * gdk_dmabuf_texture_builder_set_color_state:
+ * gdk_dmabuf_texture_builder_set_color_state: (attributes org.gtk.Method.set_property=color-state)
  * @self: a `GdkDmabufTextureBuilder`
  * @color_state: (nullable): a `GdkColorState` or `NULL` to unset the colorstate.
  *
@@ -920,7 +920,7 @@ gdk_dmabuf_texture_builder_set_color_state (GdkDmabufTextureBuilder *self,
 }
 
 /**
- * gdk_dmabuf_texture_builder_get_update_texture:
+ * gdk_dmabuf_texture_builder_get_update_texture: (attributes org.gtk.Method.get_property=update-texture)
  * @self: a `GdkDmabufTextureBuilder`
  *
  * Gets the texture previously set via gdk_dmabuf_texture_builder_set_update_texture() or
@@ -939,7 +939,7 @@ gdk_dmabuf_texture_builder_get_update_texture (GdkDmabufTextureBuilder *self)
 }
 
 /**
- * gdk_dmabuf_texture_builder_set_update_texture:
+ * gdk_dmabuf_texture_builder_set_update_texture: (attributes org.gtk.Method.set_property=update-texture)
  * @self: a `GdkDmabufTextureBuilder`
  * @texture: (nullable): the texture to update
  *
@@ -962,7 +962,7 @@ gdk_dmabuf_texture_builder_set_update_texture (GdkDmabufTextureBuilder *self,
 }
 
 /**
- * gdk_dmabuf_texture_builder_get_update_region:
+ * gdk_dmabuf_texture_builder_get_update_region: (attributes org.gtk.Method.get_property=update-region)
  * @self: a `GdkDmabufTextureBuilder`
  *
  * Gets the region previously set via gdk_dmabuf_texture_builder_set_update_region() or
@@ -981,7 +981,7 @@ gdk_dmabuf_texture_builder_get_update_region (GdkDmabufTextureBuilder *self)
 }
 
 /**
- * gdk_dmabuf_texture_builder_set_update_region:
+ * gdk_dmabuf_texture_builder_set_update_region: (attributes org.gtk.Method.set_property=update-region)
  * @self: a `GdkDmabufTextureBuilder`
  * @region: (nullable): the region to update
  *
@@ -1063,11 +1063,11 @@ gdk_dmabuf_texture_builder_build (GdkDmabufTextureBuilder *self,
   for (i = 0; i < self->dmabuf.n_planes; i++)
     g_return_val_if_fail (self->dmabuf.planes[i].fd != -1, NULL);
 
-  if (!gdk_has_feature (GDK_FEATURE_DMABUF))
+  if (GDK_DISPLAY_DEBUG_CHECK (self->display, DMABUF_DISABLE))
     {
       g_set_error_literal (error,
                            GDK_DMABUF_ERROR, GDK_DMABUF_ERROR_NOT_AVAILABLE,
-                           "dmabuf support disabled via GDK_DISABLE environment variable");
+                           "dmabuf support disabled via GDK_DEBUG environment variable");
       return NULL;
     }
 

gdk/gdkdrag.c

@@ -92,7 +92,7 @@ static GList *drags = NULL;
 G_DEFINE_ABSTRACT_TYPE_WITH_PRIVATE (GdkDrag, gdk_drag, G_TYPE_OBJECT)
 
 /**
- * gdk_drag_get_display:
+ * gdk_drag_get_display: (attributes org.gtk.Method.get_property=display)
  * @drag: a `GdkDrag`
  *
  * Gets the `GdkDisplay` that the drag object was created for.
@@ -110,7 +110,7 @@ gdk_drag_get_display (GdkDrag *drag)
 }
 
 /**
- * gdk_drag_get_formats:
+ * gdk_drag_get_formats: (attributes org.gtk.Method.get_property=formats)
  * @drag: a `GdkDrag`
  *
  * Retrieves the formats supported by this `GdkDrag` object.
@@ -128,7 +128,7 @@ gdk_drag_get_formats (GdkDrag *drag)
 }
 
 /**
- * gdk_drag_get_actions:
+ * gdk_drag_get_actions: (attributes org.gtk.Method.get_property=actions)
  * @drag: a `GdkDrag`
  *
  * Determines the bitmask of possible actions proposed by the source.
@@ -146,7 +146,7 @@ gdk_drag_get_actions (GdkDrag *drag)
 }
 
 /**
- * gdk_drag_get_selected_action:
+ * gdk_drag_get_selected_action: (attributes org.gtk.Method.get_property=selected-action)
  * @drag: a `GdkDrag`
  *
  * Determines the action chosen by the drag destination.
@@ -164,7 +164,7 @@ gdk_drag_get_selected_action (GdkDrag *drag)
 }
 
 /**
- * gdk_drag_get_device:
+ * gdk_drag_get_device: (attributes org.gtk.Method.get_property=device)
  * @drag: a `GdkDrag`
  *
  * Returns the `GdkDevice` associated to the `GdkDrag` object.
@@ -182,7 +182,7 @@ gdk_drag_get_device (GdkDrag *drag)
 }
 
 /**
- * gdk_drag_get_content:
+ * gdk_drag_get_content: (attributes org.gtk.Method.get_property=content)
  * @drag: a `GdkDrag`
  *
  * Returns the `GdkContentProvider` associated to the `GdkDrag` object.
@@ -200,7 +200,7 @@ gdk_drag_get_content (GdkDrag *drag)
 }
 
 /**
- * gdk_drag_get_surface:
+ * gdk_drag_get_surface: (attributes org.gtk.Method.get_property=surface)
  * @drag: a `GdkDrag`
  *
  * Returns the `GdkSurface` where the drag originates.
@@ -362,7 +362,7 @@ gdk_drag_class_init (GdkDragClass *klass)
   object_class->finalize = gdk_drag_finalize;
 
   /**
-   * GdkDrag:content:
+   * GdkDrag:content: (attributes org.gtk.Property.get=gdk_drag_get_content)
    *
    * The `GdkContentProvider`.
    */
@@ -375,7 +375,7 @@ gdk_drag_class_init (GdkDragClass *klass)
                          G_PARAM_EXPLICIT_NOTIFY);
 
   /**
-   * GdkDrag:device:
+   * GdkDrag:device: (attributes org.gtk.Property.get=gdk_drag_get_device)
    *
    * The `GdkDevice` that is performing the drag.
    */
@@ -388,7 +388,7 @@ gdk_drag_class_init (GdkDragClass *klass)
                          G_PARAM_EXPLICIT_NOTIFY);
 
   /**
-   * GdkDrag:display:
+   * GdkDrag:display: (attributes org.gtk.Property.get=gdk_drag_get_display)
    *
    * The `GdkDisplay` that the drag belongs to.
    */
@@ -400,7 +400,7 @@ gdk_drag_class_init (GdkDragClass *klass)
                          G_PARAM_EXPLICIT_NOTIFY);
 
   /**
-   * GdkDrag:formats:
+   * GdkDrag:formats: (attributes org.gtk.Property.get=gdk_drag_get_formats)
    *
    * The possible formats that the drag can provide its data in.
    */
@@ -413,7 +413,7 @@ gdk_drag_class_init (GdkDragClass *klass)
                         G_PARAM_EXPLICIT_NOTIFY);
 
   /**
-   * GdkDrag:selected-action:
+   * GdkDrag:selected-action: (attributes org.gtk.Property.get=gdk_drag_get_selected_action)
    *
    * The currently selected action of the drag.
    */
@@ -426,7 +426,7 @@ gdk_drag_class_init (GdkDragClass *klass)
                         G_PARAM_EXPLICIT_NOTIFY);
 
   /**
-   * GdkDrag:actions:
+   * GdkDrag:actions: (attributes org.gtk.Property.get=gdk_drag_get_actions)
    *
    * The possible actions of this drag.
    */
@@ -439,7 +439,7 @@ gdk_drag_class_init (GdkDragClass *klass)
                         G_PARAM_EXPLICIT_NOTIFY);
 
   /**
-   * GdkDrag:surface:
+   * GdkDrag:surface: (attributes org.gtk.Property.get=gdk_drag_get_surface)
    *
    * The surface where the drag originates.
    */

gdk/gdkdrawcontext.c

@@ -172,7 +172,7 @@ gdk_draw_context_class_init (GdkDrawContextClass *klass)
   klass->empty_frame = gdk_draw_context_default_empty_frame;
 
   /**
-   * GdkDrawContext:display:
+   * GdkDrawContext:display: (attributes org.gtk.Property.get=gdk_draw_context_get_display)
    *
    * The `GdkDisplay` used to create the `GdkDrawContext`.
    */
@@ -184,7 +184,7 @@ gdk_draw_context_class_init (GdkDrawContextClass *klass)
                          G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkDrawContext:surface:
+   * GdkDrawContext:surface: (attributes org.gtk.Property.get=gdk_draw_context_get_surface)
    *
    * The `GdkSurface` the context is bound to.
    */
@@ -223,9 +223,6 @@ gdk_draw_context_init (GdkDrawContext *self)
  *
  * Returns: %TRUE if the context is between [method@Gdk.DrawContext.begin_frame]
  *   and [method@Gdk.DrawContext.end_frame] calls.
- *
- * Deprecated: 4.16: Drawing directly to the surface is no longer recommended.
- *   Use `GskRenderNode` and `GskRenderer`.
  */
 gboolean
 gdk_draw_context_is_in_frame (GdkDrawContext *context)
@@ -251,7 +248,7 @@ gdk_draw_context_surface_resized (GdkDrawContext *context)
 }
 
 /**
- * gdk_draw_context_get_display:
+ * gdk_draw_context_get_display: (attributes org.gtk.Method.get_property=display)
  * @context: a `GdkDrawContext`
  *
  * Retrieves the `GdkDisplay` the @context is created for
@@ -269,7 +266,7 @@ gdk_draw_context_get_display (GdkDrawContext *context)
 }
 
 /**
- * gdk_draw_context_get_surface:
+ * gdk_draw_context_get_surface: (attributes org.gtk.Method.get_property=surface)
  * @context: a `GdkDrawContext`
  *
  * Retrieves the surface that @context is bound to.
@@ -316,9 +313,6 @@ gdk_draw_context_get_surface (GdkDrawContext *context)
  * gdk_draw_context_begin_frame() and gdk_draw_context_end_frame() via the
  * use of [GskRenderer](../gsk4/class.Renderer.html)s, so application code
  * does not need to call these functions explicitly.
- *
- * Deprecated: 4.16: Drawing directly to the surface is no longer recommended.
- *   Use `GskRenderNode` and `GskRenderer`.
  */
 void
 gdk_draw_context_begin_frame (GdkDrawContext       *context,
@@ -330,12 +324,11 @@ gdk_draw_context_begin_frame (GdkDrawContext       *context,
   g_return_if_fail (priv->surface != NULL);
   g_return_if_fail (region != NULL);
 
-  gdk_draw_context_begin_frame_full (context, GDK_MEMORY_U8, region, NULL);
+  gdk_draw_context_begin_frame_full (context, GDK_MEMORY_U8, region);
 }
 
 /*
  * @depth: best depth to render in
- * @opaque: (nullable): opaque region of the rendering
  *
  * If the given depth is not `GDK_MEMORY_U8`, GDK will see about providing a
  * rendering target that supports a higher bit depth than 8 bits per channel.
@@ -358,10 +351,9 @@ gdk_draw_context_begin_frame (GdkDrawContext       *context,
  * to choose.
  */
 void
-gdk_draw_context_begin_frame_full (GdkDrawContext        *context,
-                                   GdkMemoryDepth         depth,
-                                   const cairo_region_t  *region,
-                                   const graphene_rect_t *opaque)
+gdk_draw_context_begin_frame_full (GdkDrawContext       *context,
+                                   GdkMemoryDepth        depth,
+                                   const cairo_region_t *region)
 {
   GdkDrawContextPrivate *priv = gdk_draw_context_get_instance_private (context);
 
@@ -386,23 +378,19 @@ gdk_draw_context_begin_frame_full (GdkDrawContext        *context,
       return;
     }
 
-  gdk_surface_set_opaque_rect (priv->surface, opaque);
-
   if (gdk_display_get_debug_flags (priv->display) & GDK_DEBUG_HIGH_DEPTH)
     depth = GDK_MEMORY_FLOAT32;
 
   priv->frame_region = cairo_region_copy (region);
   priv->surface->paint_context = g_object_ref (context);
 
-  g_assert (priv->color_state == NULL);
-
   GDK_DRAW_CONTEXT_GET_CLASS (context)->begin_frame (context,
                                                      depth,
                                                      priv->frame_region,
                                                      &priv->color_state,
                                                      &priv->depth);
 
-  /* The callback is meant to set them. Note that it does not return a ref */
+  /* the callback is meant to set them */
   g_assert (priv->color_state != NULL);
   g_assert (priv->depth < GDK_N_DEPTHS);
 
@@ -432,21 +420,6 @@ region_get_pixels (cairo_region_t *region)
 }
 #endif
 
-void
-gdk_draw_context_end_frame_full (GdkDrawContext *context)
-{
-  GdkDrawContextPrivate *priv = gdk_draw_context_get_instance_private (context);
-
-  GDK_DRAW_CONTEXT_GET_CLASS (context)->end_frame (context, priv->frame_region);
-
-  gdk_profiler_set_int_counter (pixels_counter, region_get_pixels (priv->frame_region));
-
-  priv->color_state = NULL;
-  g_clear_pointer (&priv->frame_region, cairo_region_destroy);
-  g_clear_object (&priv->surface->paint_context);
-  priv->depth = GDK_N_DEPTHS;
-}
-
 /**
  * gdk_draw_context_end_frame:
  * @context: a `GdkDrawContext`
@@ -459,9 +432,6 @@ gdk_draw_context_end_frame_full (GdkDrawContext *context)
  * When using a [class@Gdk.GLContext], this function may call `glFlush()`
  * implicitly before returning; it is not recommended to call `glFlush()`
  * explicitly before calling this function.
- *
- * Deprecated: 4.16: Drawing directly to the surface is no longer recommended.
- *   Use `GskRenderNode` and `GskRenderer`.
  */
 void
 gdk_draw_context_end_frame (GdkDrawContext *context)
@@ -489,7 +459,14 @@ gdk_draw_context_end_frame (GdkDrawContext *context)
       return;
     }
 
-  gdk_draw_context_end_frame_full (context);
+  GDK_DRAW_CONTEXT_GET_CLASS (context)->end_frame (context, priv->frame_region);
+
+  gdk_profiler_set_int_counter (pixels_counter, region_get_pixels (priv->frame_region));
+
+  g_clear_pointer (&priv->color_state, gdk_color_state_unref);
+  g_clear_pointer (&priv->frame_region, cairo_region_destroy);
+  g_clear_object (&priv->surface->paint_context);
+  priv->depth = GDK_N_DEPTHS;
 }
 
 /**
@@ -506,24 +483,15 @@ gdk_draw_context_end_frame (GdkDrawContext *context)
  * and [method@Gdk.DrawContext.end_frame], %NULL will be returned.
  *
  * Returns: (transfer none) (nullable): a Cairo region
- *
- * Deprecated: 4.16: Drawing directly to the surface is no longer recommended.
- *   Use `GskRenderNode` and `GskRenderer`.
  */
 const cairo_region_t *
-_gdk_draw_context_get_frame_region (GdkDrawContext *context)
+gdk_draw_context_get_frame_region (GdkDrawContext *context)
 {
   GdkDrawContextPrivate *priv = gdk_draw_context_get_instance_private (context);
 
-  return priv->frame_region;
-}
-
-const cairo_region_t *
-(gdk_draw_context_get_frame_region) (GdkDrawContext *context)
-{
   g_return_val_if_fail (GDK_IS_DRAW_CONTEXT (context), NULL);
 
-  return _gdk_draw_context_get_frame_region (context);
+  return priv->frame_region;
 }
 
 /*<private>

gdk/gdkdrawcontext.h

@@ -40,15 +40,15 @@ GdkDisplay *            gdk_draw_context_get_display            (GdkDrawContext
 GDK_AVAILABLE_IN_ALL
 GdkSurface *            gdk_draw_context_get_surface            (GdkDrawContext         *context);
 
-GDK_DEPRECATED_IN_4_16
+GDK_AVAILABLE_IN_ALL
 void                    gdk_draw_context_begin_frame            (GdkDrawContext         *context,
                                                                  const cairo_region_t   *region);
-GDK_DEPRECATED_IN_4_16
+GDK_AVAILABLE_IN_ALL
 void                    gdk_draw_context_end_frame              (GdkDrawContext         *context);
 
-GDK_DEPRECATED_IN_4_16
+GDK_AVAILABLE_IN_ALL
 gboolean                gdk_draw_context_is_in_frame            (GdkDrawContext         *context);
-GDK_DEPRECATED_IN_4_16
+GDK_AVAILABLE_IN_ALL
 const cairo_region_t *  gdk_draw_context_get_frame_region       (GdkDrawContext         *context);
 
 G_DEFINE_AUTOPTR_CLEANUP_FUNC(GdkDrawContext, g_object_unref)

gdk/gdkdrawcontextprivate.h

@@ -25,8 +25,6 @@
 #include "gdkcolorstateprivate.h"
 #include "gdkmemoryformatprivate.h"
 
-#include <graphene.h>
-
 G_BEGIN_DECLS
 
 #define GDK_DRAW_CONTEXT_CLASS(klass) 	(G_TYPE_CHECK_CLASS_CAST ((klass), GDK_TYPE_DRAW_CONTEXT, GdkDrawContextClass))
@@ -59,14 +57,10 @@ void                    gdk_draw_context_surface_resized        (GdkDrawContext
 
 void                    gdk_draw_context_begin_frame_full       (GdkDrawContext         *context,
                                                                  GdkMemoryDepth          depth,
-                                                                 const cairo_region_t   *region,
-                                                                 const graphene_rect_t  *opaque);
-void                    gdk_draw_context_end_frame_full         (GdkDrawContext         *context);
+                                                                 const cairo_region_t   *region);
 
 void                    gdk_draw_context_empty_frame            (GdkDrawContext         *context);
 
-#define gdk_draw_context_get_frame_region(...) _gdk_draw_context_get_frame_region(__VA_ARGS__)
-const cairo_region_t *  _gdk_draw_context_get_frame_region      (GdkDrawContext         *self);
 GdkColorState *         gdk_draw_context_get_color_state        (GdkDrawContext         *self);
 GdkMemoryDepth          gdk_draw_context_get_depth              (GdkDrawContext         *self);
 

gdk/gdkdrop.c

@@ -320,7 +320,7 @@ gdk_drop_class_init (GdkDropClass *klass)
   object_class->finalize = gdk_drop_finalize;
 
   /**
-   * GdkDrop:actions:
+   * GdkDrop:actions: (attributes org.gtk.Property.get=gdk_drop_get_actions)
    *
    * The possible actions for this drop
    */
@@ -334,7 +334,7 @@ gdk_drop_class_init (GdkDropClass *klass)
                          G_PARAM_EXPLICIT_NOTIFY);
 
   /**
-   * GdkDrop:device:
+   * GdkDrop:device: (attributes org.gtk.Property.get=gdk_drop_get_device)
    *
    * The `GdkDevice` performing the drop
    */
@@ -347,7 +347,7 @@ gdk_drop_class_init (GdkDropClass *klass)
                          G_PARAM_EXPLICIT_NOTIFY);
 
   /**
-   * GdkDrop:display:
+   * GdkDrop:display: (attributes org.gtk.Property.get=gdk_drop_get_display)
    *
    * The `GdkDisplay` that the drop belongs to.
    */
@@ -359,7 +359,7 @@ gdk_drop_class_init (GdkDropClass *klass)
                          G_PARAM_EXPLICIT_NOTIFY);
 
   /**
-   * GdkDrop:drag:
+   * GdkDrop:drag: (attributes org.gtk.Property.get=gdk_drop_get_drag)
    *
    * The `GdkDrag` that initiated this drop
    */
@@ -372,7 +372,7 @@ gdk_drop_class_init (GdkDropClass *klass)
                          G_PARAM_EXPLICIT_NOTIFY);
 
   /**
-   * GdkDrop:formats:
+   * GdkDrop:formats: (attributes org.gtk.Property.get=gdk_drop_get_formats)
    *
    * The possible formats that the drop can provide its data in.
    */
@@ -385,7 +385,7 @@ gdk_drop_class_init (GdkDropClass *klass)
                         G_PARAM_EXPLICIT_NOTIFY);
 
   /**
-   * GdkDrop:surface:
+   * GdkDrop:surface: (attributes org.gtk.Property.get=gdk_drop_get_surface)
    *
    * The `GdkSurface` the drop happens on
    */
@@ -406,7 +406,7 @@ gdk_drop_init (GdkDrop *self)
 }
 
 /**
- * gdk_drop_get_display:
+ * gdk_drop_get_display: (attributes org.gtk.Method.get_property=display)
  * @self: a `GdkDrop`
  *
  * Gets the `GdkDisplay` that @self was created for.
@@ -424,7 +424,7 @@ gdk_drop_get_display (GdkDrop *self)
 }
 
 /**
- * gdk_drop_get_device:
+ * gdk_drop_get_device: (attributes org.gtk.Method.get_property=device)
  * @self: a `GdkDrop`
  *
  * Returns the `GdkDevice` performing the drop.
@@ -442,7 +442,7 @@ gdk_drop_get_device (GdkDrop *self)
 }
 
 /**
- * gdk_drop_get_formats:
+ * gdk_drop_get_formats: (attributes org.gtk.Method.get_property=formats)
  * @self: a `GdkDrop`
  *
  * Returns the `GdkContentFormats` that the drop offers the data
@@ -461,7 +461,7 @@ gdk_drop_get_formats (GdkDrop *self)
 }
 
 /**
- * gdk_drop_get_surface:
+ * gdk_drop_get_surface: (attributes org.gtk.Method.get_property=surface)
  * @self: a `GdkDrop`
  *
  * Returns the `GdkSurface` performing the drop.
@@ -479,7 +479,7 @@ gdk_drop_get_surface (GdkDrop *self)
 }
 
 /**
- * gdk_drop_get_actions:
+ * gdk_drop_get_actions: (attributes org.gtk.Method.get_property=actions)
  * @self: a `GdkDrop`
  *
  * Returns the possible actions for this `GdkDrop`.
@@ -528,7 +528,7 @@ gdk_drop_set_actions (GdkDrop       *self,
 }
 
 /**
- * gdk_drop_get_drag:
+ * gdk_drop_get_drag: (attributes org.gtk.Method.get_property=drag)
  * @self: a `GdkDrop`
  *
  * If this is an in-app drag-and-drop operation, returns the `GdkDrag`

gdk/gdkevents.c

@@ -978,13 +978,9 @@ gdk_event_get_axis (GdkEvent   *event,
  * according to platform conventions.
  *
  * The right mouse button typically triggers context menus.
- * On macOS, Control+left mouse button also triggers.
  *
  * This function should always be used instead of simply checking for
- *
- * ```c
- * event->button == GDK_BUTTON_SECONDARY
- * ```
+ * event->button == %GDK_BUTTON_SECONDARY.
  *
  * Returns: %TRUE if the event should trigger a context menu.
  */
@@ -1002,13 +998,6 @@ gdk_event_triggers_context_menu (GdkEvent *event)
       if (bevent->button == GDK_BUTTON_SECONDARY &&
           ! (bevent->state & (GDK_BUTTON1_MASK | GDK_BUTTON2_MASK)))
         return TRUE;
-
-#ifdef __APPLE__
-      if (bevent->button == GDK_BUTTON_PRIMARY &&
-          (bevent->state & GDK_CONTROL_MASK) &&
-          ! (bevent->state & (GDK_BUTTON1_MASK | GDK_BUTTON2_MASK)))
-        return TRUE;
-#endif
     }
 
   return FALSE;

gdk/gdkglcontext.c

@@ -122,7 +122,6 @@ struct _GdkGLContextPrivate
   GdkGLMemoryFlags memory_flags[GDK_MEMORY_N_FORMATS];
 
   GdkGLFeatures features;
-  guint surface_attached : 1;
   guint use_khr_debug : 1;
   guint has_debug_output : 1;
   guint extensions_checked : 1;
@@ -638,10 +637,7 @@ gdk_gl_context_real_begin_frame (GdkDrawContext  *draw_context,
   else
     *out_depth = GDK_MEMORY_U8;
 
-  if (*out_depth == GDK_MEMORY_U8_SRGB)
-    *out_color_state = gdk_color_state_get_no_srgb_tf (color_state);
-  else
-    *out_color_state = color_state;
+  *out_color_state = color_state;
 #else
   *out_color_state = gdk_color_state_get_srgb ();
   *out_depth = GDK_MEMORY_U8;
@@ -718,8 +714,8 @@ gdk_gl_context_real_end_frame (GdkDrawContext *draw_context,
           cairo_region_get_rectangle (painted, i, &rect);
           rects[j++] = (int) floor (rect.x * scale);
           rects[j++] = (int) floor ((surface_height - rect.height - rect.y) * scale);
-          rects[j++] = (int) ceil ((rect.x + rect.width) * scale) - floor (rect.x * scale);
-          rects[j++] = (int) ceil ((surface_height - rect.y) * scale) - floor ((surface_height - rect.height - rect.y) * scale);
+          rects[j++] = (int) ceil (rect.width * scale);
+          rects[j++] = (int) ceil (rect.height * scale);
         }
       priv->eglSwapBuffersWithDamage (gdk_display_get_egl_display (display), egl_surface, rects, n_rects);
       g_free (heap_rects);
@@ -764,7 +760,7 @@ gdk_gl_context_class_init (GdkGLContextClass *klass)
   draw_context_class->surface_resized = gdk_gl_context_surface_resized;
 
   /**
-   * GdkGLContext:shared-context:
+   * GdkGLContext:shared-context: (attributes org.gtk.Property.get=gdk_gl_context_get_shared_context)
    *
    * Always %NULL
    *
@@ -783,7 +779,7 @@ gdk_gl_context_class_init (GdkGLContextClass *klass)
                          G_PARAM_DEPRECATED);
 
   /**
-   * GdkGLContext:allowed-apis:
+   * GdkGLContext:allowed-apis: (attributes org.gtk.Property.get=gdk_gl_context_get_allowed_apis org.gtk.Property.gdk_gl_context_set_allowed_apis)
    *
    * The allowed APIs.
    *
@@ -798,7 +794,7 @@ gdk_gl_context_class_init (GdkGLContextClass *klass)
                         G_PARAM_EXPLICIT_NOTIFY);
 
   /**
-   * GdkGLContext:api:
+   * GdkGLContext:api: (attributes org.gtk.Property.get=gdk_gl_context_get_api)
    *
    * The API currently in use.
    *
@@ -830,28 +826,20 @@ gdk_gl_context_init (GdkGLContext *self)
 /* Must have called gdk_display_prepare_gl() before */
 GdkGLContext *
 gdk_gl_context_new (GdkDisplay *display,
-                    GdkSurface *surface,
-                    gboolean    surface_attached)
+                    GdkSurface *surface)
 {
-  GdkGLContextPrivate *priv;
-  GdkGLContext *shared, *result;
+  GdkGLContext *shared;
 
   g_assert (surface == NULL || display == gdk_surface_get_display (surface));
-  g_assert (!surface_attached || surface != NULL);
 
   /* assert gdk_display_prepare_gl() had been called */
   shared = gdk_display_get_gl_context (display);
   g_assert (shared);
 
-  result = g_object_new (G_OBJECT_TYPE (shared),
-                         "display", display,
-                         "surface", surface,
-                         NULL);
-
-  priv = gdk_gl_context_get_instance_private (result);
-  priv->surface_attached = surface_attached;
-
-  return result;
+  return g_object_new (G_OBJECT_TYPE (shared),
+                       "display", display,
+                       "surface", surface,
+                       NULL);
 }
 
 void
@@ -1250,7 +1238,7 @@ gdk_gl_context_is_shared (GdkGLContext *self,
 }
 
 /**
- * gdk_gl_context_set_allowed_apis:
+ * gdk_gl_context_set_allowed_apis: (attributes org.gtk.Method.set_property=allowed-apis)
  * @self: a GL context
  * @apis: the allowed APIs
  *
@@ -1281,7 +1269,7 @@ gdk_gl_context_set_allowed_apis (GdkGLContext *self,
 }
 
 /**
- * gdk_gl_context_get_allowed_apis:
+ * gdk_gl_context_get_allowed_apis: (attributes org.gtk.Method.get_property=allowed-apis)
  * @self: a GL context
  *
  * Gets the allowed APIs set via gdk_gl_context_set_allowed_apis().
@@ -1301,7 +1289,7 @@ gdk_gl_context_get_allowed_apis (GdkGLContext *self)
 }
 
 /**
- * gdk_gl_context_get_api:
+ * gdk_gl_context_get_api: (attributes org.gtk.Method.get_property=api)
  * @self: a GL context
  *
  * Gets the API currently in use.
@@ -1328,28 +1316,31 @@ gdk_gl_context_is_api_allowed (GdkGLContext  *self,
                                GError       **error)
 {
   GdkGLContextPrivate *priv = gdk_gl_context_get_instance_private (self);
+  GdkDebugFlags flags;
   GdkGLAPI allowed_apis;
 
   allowed_apis = priv->allowed_apis;
 
-  if (!gdk_has_feature (GDK_FEATURE_GLES_API))
+  flags = gdk_display_get_debug_flags (gdk_gl_context_get_display (self));
+
+  if (flags & GDK_DEBUG_GL_DISABLE_GLES)
     {
       if (api == GDK_GL_API_GLES)
         {
           g_set_error_literal (error, GDK_GL_ERROR, GDK_GL_ERROR_NOT_AVAILABLE,
-                               _("OpenGL ES API disabled via GDK_DISABLE"));
+                               _("OpenGL ES disabled via GDK_DEBUG"));
           return FALSE;
         }
 
       allowed_apis &= ~GDK_GL_API_GLES;
     }
 
-  if (!gdk_has_feature (GDK_FEATURE_GL_API))
+  if (flags & GDK_DEBUG_GL_DISABLE_GL)
     {
       if (api == GDK_GL_API_GL)
         {
           g_set_error_literal (error, GDK_GL_ERROR, GDK_GL_ERROR_NOT_AVAILABLE,
-                               _("OpenGL API disabled via GDK_DISABLE"));
+                               _("OpenGL disabled via GDK_DEBUG"));
           return FALSE;
         }
 
@@ -1776,10 +1767,8 @@ gdk_gl_context_check_extensions (GdkGLContext *context)
 
   supported_features = gdk_gl_context_check_features (context);
   disabled_features = gdk_parse_debug_var ("GDK_GL_DISABLE",
-      "GDK_GL_DISABLE can be set to values which cause GDK to disable\n"
-      "certain OpenGL extensions.\n",
-      gdk_gl_feature_keys,
-      G_N_ELEMENTS (gdk_gl_feature_keys));
+                                           gdk_gl_feature_keys,
+                                           G_N_ELEMENTS (gdk_gl_feature_keys));
 
   priv->features = supported_features & ~disabled_features;
 
@@ -1833,22 +1822,12 @@ gdk_gl_context_check_is_current (GdkGLContext *context)
 void
 gdk_gl_context_make_current (GdkGLContext *context)
 {
-  GdkGLContextPrivate *priv = gdk_gl_context_get_instance_private (context);
   MaskedContext *current, *masked_context;
   gboolean surfaceless;
 
   g_return_if_fail (GDK_IS_GL_CONTEXT (context));
 
-  if (priv->surface_attached)
-    {
-      surfaceless = FALSE;
-    }
-  else
-    {
-G_GNUC_BEGIN_IGNORE_DEPRECATIONS
-      surfaceless = !gdk_draw_context_is_in_frame (GDK_DRAW_CONTEXT (context));
-G_GNUC_END_IGNORE_DEPRECATIONS
-    }
+  surfaceless = !gdk_draw_context_is_in_frame (GDK_DRAW_CONTEXT (context));
   masked_context = mask_context (context, surfaceless);
 
   current = g_private_get (&thread_current_context);
@@ -1913,7 +1892,7 @@ gdk_gl_context_get_surface (GdkGLContext *context)
 }
 
 /**
- * gdk_gl_context_get_shared_context:
+ * gdk_gl_context_get_shared_context: (attributes org.gtk.Method.get_property=shared-context)
  * @context: a `GdkGLContext`
  *
  * Used to retrieves the `GdkGLContext` that this @context share data with.
@@ -2037,11 +2016,8 @@ gdk_gl_context_clear_current (void)
  *
  * Does a gdk_gl_context_clear_current() if the current context is attached
  * to @surface, leaves the current context alone otherwise.
- * 
- * Returns: (nullable) (transfer full): The context that was cleared, so that it can be
- *   re-made current later
  **/
-GdkGLContext *
+void
 gdk_gl_context_clear_current_if_surface (GdkSurface *surface)
 {
   MaskedContext *current;
@@ -2052,20 +2028,11 @@ gdk_gl_context_clear_current_if_surface (GdkSurface *surface)
       GdkGLContext *context = unmask_context (current);
 
       if (gdk_gl_context_get_surface (context) != surface)
-        return NULL;
-
-      g_object_ref (context);
+        return;
 
       if (GDK_GL_CONTEXT_GET_CLASS (context)->clear_current (context))
-        {
-          g_private_replace (&thread_current_context, NULL);
-          return context;
-        }
-
-      g_object_unref (context);
+        g_private_replace (&thread_current_context, NULL);
     }
-
-  return NULL;
 }
 
 /**
@@ -2165,30 +2132,17 @@ gboolean
 gdk_gl_backend_can_be_used (GdkGLBackend   backend_type,
                             GError       **error)
 {
-  if (the_gl_backend_type != GDK_GL_NONE &&
-      the_gl_backend_type != backend_type)
-    {
-      g_set_error (error, GDK_GL_ERROR, GDK_GL_ERROR_NOT_AVAILABLE,
-                   /* translators: This is about OpenGL backend names, like
-                    * "Trying to use X11 GLX, but EGL is already in use"
-                    */
-                   _("Trying to use %s, but %s is already in use"),
-                   gl_backend_names[backend_type],
-                   gl_backend_names[the_gl_backend_type]);
-      return FALSE;
-    }
+  if (the_gl_backend_type == GDK_GL_NONE ||
+      the_gl_backend_type == backend_type)
+    return TRUE;
 
-  if ((backend_type == GDK_GL_EGL && !gdk_has_feature (GDK_FEATURE_EGL)) ||
-      (backend_type == GDK_GL_GLX && !gdk_has_feature (GDK_FEATURE_GLX)) ||
-      (backend_type == GDK_GL_WGL && !gdk_has_feature (GDK_FEATURE_WGL)))
-    {
-      g_set_error (error, GDK_GL_ERROR, GDK_GL_ERROR_NOT_AVAILABLE,
-                   _("Trying to use %s, but it is disabled via GDK_DISABLE"),
-                   gl_backend_names[backend_type]);
-      return FALSE;
-    }
-
-  return TRUE;
+  g_set_error (error, GDK_GL_ERROR, GDK_GL_ERROR_NOT_AVAILABLE,
+               /* translators: This is about OpenGL backend names, like
+                * "Trying to use X11 GLX, but EGL is already in use" */
+               _("Trying to use %s, but %s is already in use"),
+               gl_backend_names[backend_type],
+               gl_backend_names[the_gl_backend_type]);
+  return FALSE;
 }
 
 /*<private>
@@ -2217,7 +2171,6 @@ gdk_gl_backend_use (GdkGLBackend backend_type)
   g_assert (the_gl_backend_type == backend_type);
 }
 
-#if defined(HAVE_EGL) && defined(HAVE_DMABUF)
 static guint
 gdk_gl_context_import_dmabuf_for_target (GdkGLContext    *self,
                                          int              width,
@@ -2225,6 +2178,7 @@ gdk_gl_context_import_dmabuf_for_target (GdkGLContext    *self,
                                          const GdkDmabuf *dmabuf,
                                          int              target)
 {
+#if defined(HAVE_EGL) && defined(HAVE_DMABUF)
   GdkDisplay *display = gdk_gl_context_get_display (self);
   EGLImage image;
   guint texture_id;
@@ -2246,8 +2200,10 @@ gdk_gl_context_import_dmabuf_for_target (GdkGLContext    *self,
   eglDestroyImageKHR (gdk_display_get_egl_display (display), image);
 
   return texture_id;
-}
+#else
+  return 0;
 #endif
+}
 
 guint
 gdk_gl_context_import_dmabuf (GdkGLContext    *self,
@@ -2256,11 +2212,10 @@ gdk_gl_context_import_dmabuf (GdkGLContext    *self,
                               const GdkDmabuf *dmabuf,
                               gboolean        *external)
 {
-#if defined(HAVE_EGL) && defined(HAVE_DMABUF)
   GdkDisplay *display = gdk_gl_context_get_display (self);
   guint texture_id;
 
-  gdk_dmabuf_egl_init (display);
+  gdk_display_init_dmabuf (display);
 
   if (gdk_dmabuf_formats_contains (display->egl_dmabuf_formats, dmabuf->fourcc, dmabuf->modifier))
     {
@@ -2351,9 +2306,6 @@ gdk_gl_context_import_dmabuf (GdkGLContext    *self,
       *external = target == GL_TEXTURE_EXTERNAL_OES;
       return texture_id;
     }
-#else
-  return 0;
-#endif
 }
 
 gboolean

gdk/gdkglcontextprivate.h

@@ -120,11 +120,10 @@ gboolean                gdk_gl_backend_can_be_used              (GdkGLBackend
                                                                  GError         **error);
 void                    gdk_gl_backend_use                      (GdkGLBackend     backend_type);
 
-GdkGLContext *          gdk_gl_context_clear_current_if_surface (GdkSurface             *surface) G_GNUC_WARN_UNUSED_RESULT;
+void                    gdk_gl_context_clear_current_if_surface (GdkSurface      *surface);
 
-GdkGLContext *          gdk_gl_context_new                      (GdkDisplay             *display,
-                                                                 GdkSurface             *surface,
-                                                                 gboolean                surface_attached);
+GdkGLContext *          gdk_gl_context_new                      (GdkDisplay      *display,
+                                                                 GdkSurface      *surface);
 
 gboolean                gdk_gl_context_is_api_allowed           (GdkGLContext           *self,
                                                                  GdkGLAPI                api,

gdk/gdkgltexture.c

@@ -101,10 +101,6 @@ gdk_gl_texture_invoke_callback (gpointer data)
   context = gdk_display_get_gl_context (gdk_gl_context_get_display (invoke->self->context));
 
   previous = gdk_gl_context_get_current ();
-
-  if (previous)
-    g_object_ref (previous);
-
   gdk_gl_context_make_current (context);
 
   if (invoke->self->sync && context != invoke->self->context)
@@ -117,14 +113,9 @@ gdk_gl_texture_invoke_callback (gpointer data)
   g_atomic_int_set (&invoke->spinlock, 1);
 
   if (previous)
-    {
-      gdk_gl_context_make_current (previous);
-      g_object_unref (previous);
-    }
+    gdk_gl_context_make_current (previous);
   else
-    {
-      gdk_gl_context_clear_current ();
-    }
+    gdk_gl_context_clear_current ();
 
   return FALSE;
 }

gdk/gdkgltexturebuilder.c

@@ -225,7 +225,7 @@ gdk_gl_texture_builder_class_init (GdkGLTextureBuilderClass *klass)
   gobject_class->set_property = gdk_gl_texture_builder_set_property;
 
   /**
-   * GdkGLTextureBuilder:context:
+   * GdkGLTextureBuilder:context: (attributes org.gtk.Property.get=gdk_gl_texture_builder_get_context org.gtk.Property.set=gdk_gl_texture_builder_set_context)
    *
    * The context owning the texture.
    *
@@ -237,7 +237,7 @@ gdk_gl_texture_builder_class_init (GdkGLTextureBuilderClass *klass)
                          G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkGLTextureBuilder:format:
+   * GdkGLTextureBuilder:format: (attributes org.gtk.Property.get=gdk_gl_texture_builder_get_format org.gtk.Property.set=gdk_gl_texture_builder_set_format)
    *
    * The format when downloading the texture.
    *
@@ -250,7 +250,7 @@ gdk_gl_texture_builder_class_init (GdkGLTextureBuilderClass *klass)
                        G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkGLTextureBuilder:has-mipmap:
+   * GdkGLTextureBuilder:has-mipmap: (attributes org.gtk.Property.get=gdk_gl_texture_builder_get_has_mipmap org.gtk.Property.set=gdk_gl_texture_builder_set_has_mipmap)
    *
    * If the texture has a mipmap.
    *
@@ -262,7 +262,7 @@ gdk_gl_texture_builder_class_init (GdkGLTextureBuilderClass *klass)
                           G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkGLTextureBuilder:height:
+   * GdkGLTextureBuilder:height: (attributes org.gtk.Property.get=gdk_gl_texture_builder_get_height org.gtk.Property.set=gdk_gl_texture_builder_set_height)
    *
    * The height of the texture.
    *
@@ -274,7 +274,7 @@ gdk_gl_texture_builder_class_init (GdkGLTextureBuilderClass *klass)
                       G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkGLTextureBuilder:id:
+   * GdkGLTextureBuilder:id: (attributes org.gtk.Property.get=gdk_gl_texture_builder_get_id org.gtk.Property.set=gdk_gl_texture_builder_set_id)
    *
    * The texture ID to use.
    *
@@ -286,7 +286,7 @@ gdk_gl_texture_builder_class_init (GdkGLTextureBuilderClass *klass)
                        G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkGLTextureBuilder:sync:
+   * GdkGLTextureBuilder:sync: (attributes org.gtk.Property.get=gdk_gl_texture_builder_get_sync org.gtk.Property.set=gdk_gl_texture_builder_set_sync)
    *
    * An optional `GLSync` object.
    *
@@ -311,7 +311,7 @@ gdk_gl_texture_builder_class_init (GdkGLTextureBuilderClass *klass)
                         G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkGLTextureBuilder:update-region:
+   * GdkGLTextureBuilder:update-region: (attributes org.gtk.Property.get=gdk_gl_texture_builder_get_update_region org.gtk.Property.set=gdk_gl_texture_builder_set_update_region)
    *
    * The update region for [property@Gdk.GLTextureBuilder:update-texture].
    *
@@ -323,7 +323,7 @@ gdk_gl_texture_builder_class_init (GdkGLTextureBuilderClass *klass)
                         G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkGLTextureBuilder:update-texture:
+   * GdkGLTextureBuilder:update-texture: (attributes org.gtk.Property.get=gdk_gl_texture_builder_get_update_texture org.gtk.Property.set=gdk_gl_texture_builder_set_update_texture)
    *
    * The texture [property@Gdk.GLTextureBuilder:update-region] is an update for.
    *
@@ -335,7 +335,7 @@ gdk_gl_texture_builder_class_init (GdkGLTextureBuilderClass *klass)
                          G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkGLTextureBuilder:width:
+   * GdkGLTextureBuilder:width: (attributes org.gtk.Property.get=gdk_gl_texture_builder_get_width org.gtk.Property.set=gdk_gl_texture_builder_set_width)
    *
    * The width of the texture.
    *
@@ -372,7 +372,7 @@ gdk_gl_texture_builder_new (void)
 }
 
 /**
- * gdk_gl_texture_builder_get_context:
+ * gdk_gl_texture_builder_get_context: (attributes org.gtk.Method.get_property=context)
  * @self: a `GdkGLTextureBuilder`
  *
  * Gets the context previously set via gdk_gl_texture_builder_set_context() or
@@ -391,7 +391,7 @@ gdk_gl_texture_builder_get_context (GdkGLTextureBuilder *self)
 }
 
 /**
- * gdk_gl_texture_builder_set_context:
+ * gdk_gl_texture_builder_set_context: (attributes org.gtk.Method.set_property=context)
  * @self: a `GdkGLTextureBuilder`
  * @context: (nullable): The context the texture belongs to or %NULL to unset
  *
@@ -416,7 +416,7 @@ gdk_gl_texture_builder_set_context (GdkGLTextureBuilder *self,
 }
 
 /**
- * gdk_gl_texture_builder_get_height:
+ * gdk_gl_texture_builder_get_height: (attributes org.gtk.Method.get_property=height)
  * @self: a `GdkGLTextureBuilder`
  *
  * Gets the height previously set via gdk_gl_texture_builder_set_height() or
@@ -435,7 +435,7 @@ gdk_gl_texture_builder_get_height (GdkGLTextureBuilder *self)
 }
 
 /**
- * gdk_gl_texture_builder_set_height:
+ * gdk_gl_texture_builder_set_height: (attributes org.gtk.Method.set_property=height)
  * @self: a `GdkGLTextureBuilder`
  * @height: The texture's height or 0 to unset
  *
@@ -460,7 +460,7 @@ gdk_gl_texture_builder_set_height (GdkGLTextureBuilder *self,
 }
 
 /**
- * gdk_gl_texture_builder_get_id:
+ * gdk_gl_texture_builder_get_id: (attributes org.gtk.Method.get_property=id)
  * @self: a `GdkGLTextureBuilder`
  *
  * Gets the texture id previously set via gdk_gl_texture_builder_set_id() or
@@ -479,7 +479,7 @@ gdk_gl_texture_builder_get_id (GdkGLTextureBuilder *self)
 }
 
 /**
- * gdk_gl_texture_builder_set_id:
+ * gdk_gl_texture_builder_set_id: (attributes org.gtk.Method.set_property=id)
  * @self: a `GdkGLTextureBuilder`
  * @id: The texture id to be used for creating the texture
  *
@@ -506,7 +506,7 @@ gdk_gl_texture_builder_set_id (GdkGLTextureBuilder *self,
 }
 
 /**
- * gdk_gl_texture_builder_get_width:
+ * gdk_gl_texture_builder_get_width: (attributes org.gtk.Method.get_property=width)
  * @self: a `GdkGLTextureBuilder`
  *
  * Gets the width previously set via gdk_gl_texture_builder_set_width() or
@@ -525,7 +525,7 @@ gdk_gl_texture_builder_get_width (GdkGLTextureBuilder *self)
 }
 
 /**
- * gdk_gl_texture_builder_set_width:
+ * gdk_gl_texture_builder_set_width: (attributes org.gtk.Method.set_property=width)
  * @self: a `GdkGLTextureBuilder`
  * @width: The texture's width or 0 to unset
  *
@@ -550,7 +550,7 @@ gdk_gl_texture_builder_set_width (GdkGLTextureBuilder *self,
 }
 
 /**
- * gdk_gl_texture_builder_get_has_mipmap:
+ * gdk_gl_texture_builder_get_has_mipmap: (attributes org.gtk.Method.get_property=has-mipmap)
  * @self: a `GdkGLTextureBuilder`
  *
  * Gets whether the texture has a mipmap.
@@ -568,7 +568,7 @@ gdk_gl_texture_builder_get_has_mipmap (GdkGLTextureBuilder *self)
 }
 
 /**
- * gdk_gl_texture_builder_set_has_mipmap:
+ * gdk_gl_texture_builder_set_has_mipmap: (attributes org.gtk.Method.set_property=has-mipmap)
  * @self: a `GdkGLTextureBuilder`
  * @has_mipmap: Whether the texture has a mipmap
  *
@@ -594,7 +594,7 @@ gdk_gl_texture_builder_set_has_mipmap (GdkGLTextureBuilder *self,
 }
 
 /**
- * gdk_gl_texture_builder_get_sync:
+ * gdk_gl_texture_builder_get_sync: (attributes org.gtk.Method.get_property=sync)
  * @self: a `GdkGLTextureBuilder`
  *
  * Gets the `GLsync` previously set via gdk_gl_texture_builder_set_sync().
@@ -612,7 +612,7 @@ gdk_gl_texture_builder_get_sync (GdkGLTextureBuilder *self)
 }
 
 /**
- * gdk_gl_texture_builder_set_sync:
+ * gdk_gl_texture_builder_set_sync: (attributes org.gtk.Method.set_property=sync)
  * @self: a `GdkGLTextureBuilder`
  * @sync: (nullable): the GLSync object
  *
@@ -642,7 +642,7 @@ gdk_gl_texture_builder_set_sync (GdkGLTextureBuilder *self,
 }
 
 /**
- * gdk_gl_texture_builder_get_color_state:
+ * gdk_gl_texture_builder_get_color_state: (attributes org.gtk.Method.get_property=color-state)
  * @self: a `GdkGLTextureBuilder`
  *
  * Gets the color state previously set via gdk_gl_texture_builder_set_color_state().
@@ -660,7 +660,7 @@ gdk_gl_texture_builder_get_color_state (GdkGLTextureBuilder *self)
 }
 
 /**
- * gdk_gl_texture_builder_set_color_state:
+ * gdk_gl_texture_builder_set_color_state: (attributes org.gtk.Method.set_property=color-state)
  * @self: a `GdkGLTextureBuilder`
  * @color_state: a `GdkColorState`
  *
@@ -687,7 +687,7 @@ gdk_gl_texture_builder_set_color_state (GdkGLTextureBuilder *self,
 }
 
 /**
- * gdk_gl_texture_builder_get_format:
+ * gdk_gl_texture_builder_get_format: (attributes org.gtk.Method.get_property=format)
  * @self: a `GdkGLTextureBuilder`
  *
  * Gets the format previously set via gdk_gl_texture_builder_set_format().
@@ -705,7 +705,7 @@ gdk_gl_texture_builder_get_format (GdkGLTextureBuilder *self)
 }
 
 /**
- * gdk_gl_texture_builder_set_format:
+ * gdk_gl_texture_builder_set_format: (attributes org.gtk.Method.set_property=format)
  * @self: a `GdkGLTextureBuilder`
  * @format: The texture's format
  *
@@ -743,7 +743,7 @@ gdk_gl_texture_builder_set_format (GdkGLTextureBuilder *self,
 }
 
 /**
- * gdk_gl_texture_builder_get_update_texture:
+ * gdk_gl_texture_builder_get_update_texture: (attributes org.gtk.Method.get_property=update-texture)
  * @self: a `GdkGLTextureBuilder`
  *
  * Gets the texture previously set via gdk_gl_texture_builder_set_update_texture() or
@@ -762,7 +762,7 @@ gdk_gl_texture_builder_get_update_texture (GdkGLTextureBuilder *self)
 }
 
 /**
- * gdk_gl_texture_builder_set_update_texture:
+ * gdk_gl_texture_builder_set_update_texture: (attributes org.gtk.Method.set_property=update-texture)
  * @self: a `GdkGLTextureBuilder`
  * @texture: (nullable): the texture to update
  *
@@ -785,7 +785,7 @@ gdk_gl_texture_builder_set_update_texture (GdkGLTextureBuilder *self,
 }
 
 /**
- * gdk_gl_texture_builder_get_update_region:
+ * gdk_gl_texture_builder_get_update_region: (attributes org.gtk.Method.get_property=update-region)
  * @self: a `GdkGLTextureBuilder`
  *
  * Gets the region previously set via gdk_gl_texture_builder_set_update_region() or
@@ -804,7 +804,7 @@ gdk_gl_texture_builder_get_update_region (GdkGLTextureBuilder *self)
 }
 
 /**
- * gdk_gl_texture_builder_set_update_region:
+ * gdk_gl_texture_builder_set_update_region: (attributes org.gtk.Method.set_property=update-region)
  * @self: a `GdkGLTextureBuilder`
  * @region: (nullable): the region to update
  *

gdk/gdkkeysyms-update.pl

@@ -96,7 +96,8 @@ print OUT_GDKKEYSYMS<<EOF;
  * GTK+ at ftp://ftp.gtk.org/pub/gtk/.
  */
 
-#pragma once
+#ifndef __GDK_KEYSYMS_H__
+#define __GDK_KEYSYMS_H__
 
 
 EOF
@@ -164,6 +165,8 @@ close IN_XF86KEYSYM;
 
 
 print OUT_GDKKEYSYMS<<EOF;
+
+#endif /* __GDK_KEYSYMS_H__ */
 EOF
 
 printf "We just finished converting keysymdef.h to gdkkeysyms.h\nThank you\n";

gdk/gdkkeysyms.h

@@ -297,11 +297,8 @@
 #define GDK_KEY_dead_u 0xfe88
 #define GDK_KEY_dead_U 0xfe89
 #define GDK_KEY_dead_small_schwa 0xfe8a
-#define GDK_KEY_dead_schwa 0xfe8a
 #define GDK_KEY_dead_capital_schwa 0xfe8b
-#define GDK_KEY_dead_SCHWA 0xfe8b
 #define GDK_KEY_dead_greek 0xfe8c
-#define GDK_KEY_dead_hamza 0xfe8d
 #define GDK_KEY_First_Virtual_Screen 0xfed0
 #define GDK_KEY_Prev_Virtual_Screen 0xfed1
 #define GDK_KEY_Next_Virtual_Screen 0xfed2
@@ -493,7 +490,6 @@
 #define GDK_KEY_copyright 0x0a9
 #define GDK_KEY_ordfeminine 0x0aa
 #define GDK_KEY_guillemotleft 0x0ab
-#define GDK_KEY_guillemetleft 0x0ab
 #define GDK_KEY_notsign 0x0ac
 #define GDK_KEY_hyphen 0x0ad
 #define GDK_KEY_registered 0x0ae
@@ -509,9 +505,7 @@
 #define GDK_KEY_cedilla 0x0b8
 #define GDK_KEY_onesuperior 0x0b9
 #define GDK_KEY_masculine 0x0ba
-#define GDK_KEY_ordmasculine 0x0ba
 #define GDK_KEY_guillemotright 0x0bb
-#define GDK_KEY_guillemetright 0x0bb
 #define GDK_KEY_onequarter 0x0bc
 #define GDK_KEY_onehalf 0x0bd
 #define GDK_KEY_threequarters 0x0be
@@ -1749,11 +1743,6 @@
 #define GDK_KEY_ohorn 0x10001a1
 #define GDK_KEY_Uhorn 0x10001af
 #define GDK_KEY_uhorn 0x10001b0
-#define GDK_KEY_combining_tilde 0x1000303
-#define GDK_KEY_combining_grave 0x1000300
-#define GDK_KEY_combining_acute 0x1000301
-#define GDK_KEY_combining_hook 0x1000309
-#define GDK_KEY_combining_belowdot 0x1000323
 #define GDK_KEY_EcuSign 0x10020a0
 #define GDK_KEY_ColonSign 0x10020a1
 #define GDK_KEY_CruzeiroSign 0x10020a2
@@ -2324,3 +2313,4 @@
 #define GDK_KEY_Prev_VMode 0x1008fe23
 #define GDK_KEY_LogWindowTree 0x1008fe24
 #define GDK_KEY_LogGrabInfo 0x1008fe25
+

gdk/gdkmemoryformatprivate.h

@@ -110,16 +110,6 @@ void                    gdk_memory_convert_color_state      (guchar
                                                              GdkColorState              *dest_color_state,
                                                              gsize                       width,
                                                              gsize                       height);
-void                    gdk_memory_mipmap                   (guchar                     *dest,
-                                                             gsize                       dest_stride,
-                                                             GdkMemoryFormat             dest_format,
-                                                             const guchar               *src,
-                                                             gsize                       src_stride,
-                                                             GdkMemoryFormat             src_format,
-                                                             gsize                       src_width,
-                                                             gsize                       src_height,
-                                                             guint                       lod_level,
-                                                             gboolean                    linear);
 
 
 G_END_DECLS

gdk/gdkmemorytexture.c

@@ -111,7 +111,7 @@ gdk_memory_sanitize (GBytes          *bytes,
       stride % align == 0)
     {
       *out_stride = stride;
-      return bytes;
+      return g_bytes_ref (bytes);
     }
 
   bpp = gdk_memory_format_bytes_per_pixel (format);
@@ -122,8 +122,6 @@ gdk_memory_sanitize (GBytes          *bytes,
   for (y = 0; y < height; y++)
     memcpy (copy + y * copy_stride, data + y * stride, bpp * width);
 
-  g_bytes_unref (bytes);
-
   *out_stride = copy_stride;
   return g_bytes_new_take (copy, copy_stride * height);
 }
@@ -199,7 +197,7 @@ gdk_memory_texture_new (int              width,
   /* needs to be this complex to support subtexture of the bottom right part */
   g_return_val_if_fail (g_bytes_get_size (bytes) >= gdk_memory_format_min_buffer_size (format, stride, width, height), NULL);
 
-  bytes = gdk_memory_sanitize (g_bytes_ref (bytes), width, height, format, stride, &stride);
+  bytes = gdk_memory_sanitize (bytes, width, height, format, stride, &stride);
 
   self = g_object_new (GDK_TYPE_MEMORY_TEXTURE,
                        "width", width,

gdk/gdkmemorytexturebuilder.c

@@ -348,7 +348,7 @@ gdk_memory_texture_builder_get_bytes (GdkMemoryTextureBuilder *self)
 }
 
 /**
- * gdk_memory_texture_builder_set_bytes:
+ * gdk_memory_texture_builder_set_bytes: (attributes org.gtk.Method.set_property=bytes)
  * @self: a `GdkMemoryTextureBuilder`
  * @bytes: (nullable): The bytes the texture shows or %NULL to unset
  *
@@ -377,7 +377,7 @@ gdk_memory_texture_builder_set_bytes (GdkMemoryTextureBuilder *self,
 }
 
 /**
- * gdk_memory_texture_builder_get_color_state:
+ * gdk_memory_texture_builder_get_color_state: (attributes org.gtk.Method.get_property=color-state)
  * @self: a `GdkMemoryTextureBuilder`
  *
  * Gets the colorstate previously set via gdk_memory_texture_builder_set_color_state().
@@ -395,7 +395,7 @@ gdk_memory_texture_builder_get_color_state (GdkMemoryTextureBuilder *self)
 }
 
 /**
- * gdk_memory_texture_builder_set_color_state:
+ * gdk_memory_texture_builder_set_color_state: (attributes org.gtk.Method.set_property=color-state)
  * @self: a `GdkMemoryTextureBuilder`
  * @color_state: (nullable): The colorstate describing the data
  *
@@ -425,7 +425,7 @@ gdk_memory_texture_builder_set_color_state (GdkMemoryTextureBuilder *self,
 }
 
 /**
- * gdk_memory_texture_builder_get_height:
+ * gdk_memory_texture_builder_get_height: (attributes org.gtk.Method.get_property=height)
  * @self: a `GdkMemoryTextureBuilder`
  *
  * Gets the height previously set via gdk_memory_texture_builder_set_height()
@@ -444,7 +444,7 @@ gdk_memory_texture_builder_get_height (GdkMemoryTextureBuilder *self)
 }
 
 /**
- * gdk_memory_texture_builder_set_height:
+ * gdk_memory_texture_builder_set_height: (attributes org.gtk.Method.set_property=height)
  * @self: a `GdkMemoryTextureBuilder`
  * @height: The texture's height or 0 to unset
  *
@@ -469,7 +469,7 @@ gdk_memory_texture_builder_set_height (GdkMemoryTextureBuilder *self,
 }
 
 /**
- * gdk_memory_texture_builder_get_width:
+ * gdk_memory_texture_builder_get_width: (attributes org.gtk.Method.get_property=width)
  * @self: a `GdkMemoryTextureBuilder`
  *
  * Gets the width previously set via gdk_memory_texture_builder_set_width()
@@ -488,7 +488,7 @@ gdk_memory_texture_builder_get_width (GdkMemoryTextureBuilder *self)
 }
 
 /**
- * gdk_memory_texture_builder_set_width:
+ * gdk_memory_texture_builder_set_width: (attributes org.gtk.Method.set_property=width)
  * @self: a `GdkMemoryTextureBuilder`
  * @width: The texture's width or 0 to unset
  *
@@ -512,6 +512,7 @@ gdk_memory_texture_builder_set_width (GdkMemoryTextureBuilder *self,
   g_object_notify_by_pspec (G_OBJECT (self), properties[PROP_WIDTH]);
 }
 
+/* gdk_memory_texture_builder_get_stride: (attributes org.gtk.Method.get_property=stride) */
 /**
  * gdk_memory_texture_builder_get_stride:
  * @self: a `GdkMemoryTextureBuilder`
@@ -530,6 +531,7 @@ gdk_memory_texture_builder_get_stride (GdkMemoryTextureBuilder *self)
   return self->stride;
 }
 
+ /* gdk_memory_texture_builder_set_stride: (attributes org.gtk.Method.set_property=stride) */
 /**
  * gdk_memory_texture_builder_set_stride:
  * @self: a `GdkMemoryTextureBuilder`
@@ -556,7 +558,7 @@ gdk_memory_texture_builder_set_stride (GdkMemoryTextureBuilder *self,
 }
 
 /**
- * gdk_memory_texture_builder_get_format:
+ * gdk_memory_texture_builder_get_format: (attributes org.gtk.Method.get_property=format)
  * @self: a `GdkMemoryTextureBuilder`
  *
  * Gets the format previously set via gdk_memory_texture_builder_set_format().
@@ -574,7 +576,7 @@ gdk_memory_texture_builder_get_format (GdkMemoryTextureBuilder *self)
 }
 
 /**
- * gdk_memory_texture_builder_set_format:
+ * gdk_memory_texture_builder_set_format: (attributes org.gtk.Method.set_property=format)
  * @self: a `GdkMemoryTextureBuilder`
  * @format: The texture's format
  *
@@ -599,7 +601,7 @@ gdk_memory_texture_builder_set_format (GdkMemoryTextureBuilder *self,
 }
 
 /**
- * gdk_memory_texture_builder_get_update_texture:
+ * gdk_memory_texture_builder_get_update_texture: (attributes org.gtk.Method.get_property=update-texture)
  * @self: a `GdkMemoryTextureBuilder`
  *
  * Gets the texture previously set via gdk_memory_texture_builder_set_update_texture()
@@ -618,7 +620,7 @@ gdk_memory_texture_builder_get_update_texture (GdkMemoryTextureBuilder *self)
 }
 
 /**
- * gdk_memory_texture_builder_set_update_texture:
+ * gdk_memory_texture_builder_set_update_texture: (attributes org.gtk.Method.set_property=update-texture)
  * @self: a `GdkMemoryTextureBuilder`
  * @texture: (nullable): the texture to update
  *
@@ -642,7 +644,7 @@ gdk_memory_texture_builder_set_update_texture (GdkMemoryTextureBuilder *self,
 }
 
 /**
- * gdk_memory_texture_builder_get_update_region:
+ * gdk_memory_texture_builder_get_update_region: (attributes org.gtk.Method.get_property=update-region)
  * @self: a `GdkMemoryTextureBuilder`
  *
  * Gets the region previously set via gdk_memory_texture_builder_set_update_region()
@@ -661,7 +663,7 @@ gdk_memory_texture_builder_get_update_region (GdkMemoryTextureBuilder *self)
 }
 
 /**
- * gdk_memory_texture_builder_set_update_region:
+ * gdk_memory_texture_builder_set_update_region: (attributes org.gtk.Method.set_property=update-region)
  * @self: a `GdkMemoryTextureBuilder`
  * @region: (nullable): the region to update
  *

gdk/gdkmonitor.c

@@ -187,7 +187,7 @@ gdk_monitor_class_init (GdkMonitorClass *class)
   object_class->set_property = gdk_monitor_set_property;
 
   /**
-   * GdkMonitor:description:
+   * GdkMonitor:description: (attributes org.gtk.Property.get=gdk_monitor_get_description)
    *
    * A short description of the monitor, meant for display to the user.
    *
@@ -199,7 +199,7 @@ gdk_monitor_class_init (GdkMonitorClass *class)
                          G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkMonitor:display:
+   * GdkMonitor:display: (attributes org.gtk.Property.get=gdk_monitor_get_display)
    *
    * The `GdkDisplay` of the monitor.
    */
@@ -209,7 +209,7 @@ gdk_monitor_class_init (GdkMonitorClass *class)
                          G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkMonitor:manufacturer:
+   * GdkMonitor:manufacturer: (attributes org.gtk.Property.get=gdk_monitor_get_manufacturer)
    *
    * The manufacturer name.
    */
@@ -219,7 +219,7 @@ gdk_monitor_class_init (GdkMonitorClass *class)
                          G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkMonitor:model:
+   * GdkMonitor:model: (attributes org.gtk.Property.get=gdk_monitor_get_model)
    *
    * The model name.
    */
@@ -229,7 +229,7 @@ gdk_monitor_class_init (GdkMonitorClass *class)
                          G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkMonitor:connector:
+   * GdkMonitor:connector: (attributes org.gtk.Property.get=gdk_monitor_get_connector)
    *
    * The connector name.
    */
@@ -239,7 +239,7 @@ gdk_monitor_class_init (GdkMonitorClass *class)
                          G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkMonitor:scale-factor:
+   * GdkMonitor:scale-factor: (attributes org.gtk.Property.get=gdk_monitor_get_scale_factor)
    *
    * The scale factor.
    *
@@ -253,7 +253,7 @@ gdk_monitor_class_init (GdkMonitorClass *class)
                       G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkMonitor:scale:
+   * GdkMonitor:scale: (attributes org.gtk.Property.get=gdk_monitor_get_scale)
    *
    * The scale of the monitor.
    *
@@ -265,7 +265,7 @@ gdk_monitor_class_init (GdkMonitorClass *class)
                         G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkMonitor:geometry:
+   * GdkMonitor:geometry: (attributes org.gtk.Property.get=gdk_monitor_get_geometry)
    *
    * The geometry of the monitor.
    */
@@ -275,7 +275,7 @@ gdk_monitor_class_init (GdkMonitorClass *class)
                         G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkMonitor:width-mm:
+   * GdkMonitor:width-mm: (attributes org.gtk.Property.get=gdk_monitor_get_width_mm)
    *
    * The width of the monitor, in millimeters.
    */
@@ -286,7 +286,7 @@ gdk_monitor_class_init (GdkMonitorClass *class)
                       G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkMonitor:height-mm:
+   * GdkMonitor:height-mm: (attributes org.gtk.Property.get=gdk_monitor_get_height_mm)
    *
    * The height of the monitor, in millimeters.
    */
@@ -297,7 +297,7 @@ gdk_monitor_class_init (GdkMonitorClass *class)
                       G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkMonitor:refresh-rate:
+   * GdkMonitor:refresh-rate: (attributes org.gtk.Property.get=gdk_monitor_get_refresh_rate)
    *
    * The refresh rate, in milli-Hertz.
    */
@@ -308,7 +308,7 @@ gdk_monitor_class_init (GdkMonitorClass *class)
                       G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkMonitor:subpixel-layout:
+   * GdkMonitor:subpixel-layout: (attributes org.gtk.Property.get=gdk_monitor_get_subpixel_layout)
    *
    * The subpixel layout.
    */
@@ -319,7 +319,7 @@ gdk_monitor_class_init (GdkMonitorClass *class)
                        G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkMonitor:valid: (getter is_valid)
+   * GdkMonitor:valid: (attributes org.gtk.Property.get=gdk_monitor_is_valid)
    *
    * Whether the object is still valid.
    */
@@ -346,7 +346,7 @@ gdk_monitor_class_init (GdkMonitorClass *class)
 }
 
 /**
- * gdk_monitor_get_display:
+ * gdk_monitor_get_display: (attributes org.gtk.Method.get_property=display)
  * @monitor: a `GdkMonitor`
  *
  * Gets the display that this monitor belongs to.
@@ -362,7 +362,7 @@ gdk_monitor_get_display (GdkMonitor *monitor)
 }
 
 /**
- * gdk_monitor_get_geometry:
+ * gdk_monitor_get_geometry: (attributes org.gtk.Method.get_property=geometry)
  * @monitor: a `GdkMonitor`
  * @geometry: (out): a `GdkRectangle` to be filled with the monitor geometry
  *
@@ -383,7 +383,7 @@ gdk_monitor_get_geometry (GdkMonitor   *monitor,
 }
 
 /**
- * gdk_monitor_get_width_mm:
+ * gdk_monitor_get_width_mm: (attributes org.gtk.Method.get_property=width-mm)
  * @monitor: a `GdkMonitor`
  *
  * Gets the width in millimeters of the monitor.
@@ -399,7 +399,7 @@ gdk_monitor_get_width_mm (GdkMonitor *monitor)
 }
 
 /**
- * gdk_monitor_get_height_mm:
+ * gdk_monitor_get_height_mm: (attributes org.gtk.Method.get_property=height-mm)
  * @monitor: a `GdkMonitor`
  *
  * Gets the height in millimeters of the monitor.
@@ -415,7 +415,7 @@ gdk_monitor_get_height_mm (GdkMonitor *monitor)
 }
 
 /**
- * gdk_monitor_get_connector:
+ * gdk_monitor_get_connector: (attributes org.gtk.Method.get_property=connector)
  * @monitor: a `GdkMonitor`
  *
  * Gets the name of the monitor's connector, if available.
@@ -435,7 +435,7 @@ gdk_monitor_get_connector (GdkMonitor *monitor)
 }
 
 /**
- * gdk_monitor_get_manufacturer:
+ * gdk_monitor_get_manufacturer: (attributes org.gtk.Method.get_property=manufacturer)
  * @monitor: a `GdkMonitor`
  *
  * Gets the name or PNP ID of the monitor's manufacturer.
@@ -457,7 +457,7 @@ gdk_monitor_get_manufacturer (GdkMonitor *monitor)
 }
 
 /**
- * gdk_monitor_get_model:
+ * gdk_monitor_get_model: (attributes org.gtk.Method.get_property=model)
  * @monitor: a `GdkMonitor`
  *
  * Gets the string identifying the monitor model, if available.
@@ -473,7 +473,7 @@ gdk_monitor_get_model (GdkMonitor *monitor)
 }
 
 /**
- * gdk_monitor_get_scale_factor:
+ * gdk_monitor_get_scale_factor: (attributes org.gtk.Method.get_property=scale-factor)
  * @monitor: a `GdkMonitor`
  *
  * Gets the internal scale factor that maps from monitor coordinates
@@ -497,7 +497,7 @@ gdk_monitor_get_scale_factor (GdkMonitor *monitor)
 }
 
 /**
- * gdk_monitor_get_scale:
+ * gdk_monitor_get_scale: (attributes org.gtk.Method.get_property=scale)
  * @monitor: a `GdkMonitor`
  *
  * Gets the internal scale factor that maps from monitor coordinates
@@ -520,7 +520,7 @@ gdk_monitor_get_scale (GdkMonitor *monitor)
 }
 
 /**
- * gdk_monitor_get_refresh_rate:
+ * gdk_monitor_get_refresh_rate: (attributes org.gtk.Method.get_property=refresh-rate)
  * @monitor: a `GdkMonitor`
  *
  * Gets the refresh rate of the monitor, if available.
@@ -539,7 +539,7 @@ gdk_monitor_get_refresh_rate (GdkMonitor *monitor)
 }
 
 /**
- * gdk_monitor_get_subpixel_layout:
+ * gdk_monitor_get_subpixel_layout: (attributes org.gtk.Method.get_property=subpixel-layout)
  * @monitor: a `GdkMonitor`
  *
  * Gets information about the layout of red, green and blue
@@ -649,7 +649,7 @@ void
 gdk_monitor_set_scale (GdkMonitor *monitor,
                        double      scale)
 {
-  g_return_if_fail (scale > 0.);
+  g_return_if_fail (scale >= 1.);
 
   monitor->scale_set = TRUE;
 
@@ -696,7 +696,7 @@ gdk_monitor_invalidate (GdkMonitor *monitor)
 }
 
 /**
- * gdk_monitor_is_valid: (get-property valid)
+ * gdk_monitor_is_valid: (attributes org.gtk.Method.get_property=valid)
  * @monitor: a `GdkMonitor`
  *
  * Returns %TRUE if the @monitor object corresponds to a
@@ -716,7 +716,7 @@ gdk_monitor_is_valid (GdkMonitor *monitor)
 }
 
 /**
- * gdk_monitor_get_description:
+ * gdk_monitor_get_description: (attributes org.gtk.Method.get_property=description)
  * @monitor: a `GdkMonitor`
  *
  * Gets a string describing the monitor, if available.

gdk/gdkparalleltask.c

@@ -1,86 +0,0 @@
-/*
- * Copyright © 2024 Benjamin Otte
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2.1 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this library. If not, see <http://www.gnu.org/licenses/>.
- *
- * Authors: Benjamin Otte <otte@gnome.org>
- */
-
-#include "config.h"
-
-#include "gdkparalleltaskprivate.h"
-
-typedef struct _TaskData TaskData;
-
-struct _TaskData
-{
-  GdkTaskFunc task_func;
-  gpointer task_data;
-  int n_running_tasks;
-};
-
-static void
-gdk_parallel_task_thread_func (gpointer data,
-                               gpointer unused)
-{
-  TaskData *task = data;
-
-  task->task_func (task->task_data);
-
-  g_atomic_int_add (&task->n_running_tasks, -1);
-}
-
-/**
- * gdk_parallel_task_run:
- * @task_func: the function to spawn
- * @task_data: data to pass to the function
- *
- * Spawns the given function in many threads.
- * Once all functions have exited, this function returns.
- **/
-void
-gdk_parallel_task_run (GdkTaskFunc task_func,
-                       gpointer    task_data)
-{
-  static GThreadPool *pool;
-  TaskData task = {
-    .task_func = task_func,
-    .task_data = task_data,
-  };
-  int i, n_tasks;
-
-  if (g_once_init_enter (&pool))
-    {
-      GThreadPool *the_pool = g_thread_pool_new (gdk_parallel_task_thread_func,
-                              NULL,
-                              MAX (2, g_get_num_processors ()) - 1,
-                              FALSE,
-                              NULL);
-      g_once_init_leave (&pool, the_pool);
-    }
-
-  n_tasks = g_get_num_processors ();
-  task.n_running_tasks = n_tasks;
-  /* Start with 1 because we run 1 task ourselves */
-  for (i = 1; i < n_tasks; i++)
-    {
-      g_thread_pool_push (pool, &task, NULL);
-    }
-
-  gdk_parallel_task_thread_func (&task, NULL);
-
-  while (g_atomic_int_get (&task.n_running_tasks) > 0)
-    g_thread_yield ();
-}
-

gdk/gdkparalleltaskprivate.h

@@ -1,32 +0,0 @@
-/*
- * Copyright © 2024 Benjamin Otte
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2.1 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this library. If not, see <http://www.gnu.org/licenses/>.
- *
- * Authors: Benjamin Otte <otte@gnome.org>
- */
-
-#pragma once
-
-#include <glib.h>
-
-G_BEGIN_DECLS
-
-typedef void (* GdkTaskFunc) (gpointer user_data);
-
-void                    gdk_parallel_task_run               (GdkTaskFunc                 task_func,
-                                                             gpointer                    task_data);
-
-G_END_DECLS
-

gdk/gdkpopup.c

@@ -80,7 +80,7 @@ gdk_popup_default_init (GdkPopupInterface *iface)
   iface->get_position_y = gdk_popup_default_get_position_y;
 
   /**
-   * GdkPopup:parent:
+   * GdkPopup:parent: (attributes org.gtk.Property.get=gdk_popup_get_parent)
    *
    * The parent surface.
    */
@@ -90,7 +90,7 @@ gdk_popup_default_init (GdkPopupInterface *iface)
                            G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY | G_PARAM_STATIC_STRINGS));
 
   /**
-   * GdkPopup:autohide:
+   * GdkPopup:autohide: (attributes org.gtk.Property.get=gdk_popup_get_autohide)
    *
    * Whether to hide on outside clicks.
    */
@@ -178,7 +178,7 @@ gdk_popup_get_rect_anchor (GdkPopup *popup)
 }
 
 /**
- * gdk_popup_get_parent:
+ * gdk_popup_get_parent: (attributes org.gtk.Method.get_property=parent)
  * @popup: a `GdkPopup`
  *
  * Returns the parent surface of a popup.
@@ -233,7 +233,7 @@ gdk_popup_get_position_y (GdkPopup *popup)
 }
 
 /**
- * gdk_popup_get_autohide:
+ * gdk_popup_get_autohide: (attributes org.gtk.Method.get_property=autohide)
  * @popup: a `GdkPopup`
  *
  * Returns whether this popup is set to hide on outside clicks.

gdk/gdkrectangleprivate.h

@@ -52,16 +52,6 @@ gdk_rectangle_transform_affine (const GdkRectangle *src,
   dest->height = ceilf (MAX (y1, y2)) - dest->y;
 }
 
-static inline gboolean
-gdk_rectangle_contains (const GdkRectangle *rect,
-                        const GdkRectangle *contained)
-{
-  return contained->x >= rect->x
-      && contained->y >= rect->y
-      && contained->x + contained->width <= rect->x + rect->width
-      && contained->y + contained->height <= rect->y + rect->height;
-}
-
 
 G_END_DECLS
 

gdk/gdkseat.c

@@ -179,7 +179,7 @@ gdk_seat_class_init (GdkSeatClass *klass)
                   GDK_TYPE_DEVICE_TOOL);
 
   /**
-   * GdkSeat:display:
+   * GdkSeat:display: (attributes org.gtk.Property.get=gdk_seat_get_display)
    *
    * `GdkDisplay` of this seat.
    */
@@ -390,7 +390,7 @@ gdk_seat_device_removed (GdkSeat   *seat,
 }
 
 /**
- * gdk_seat_get_display:
+ * gdk_seat_get_display: (attributes org.gtk.Method.get_property=display)
  * @seat: a `GdkSeat`
  *
  * Returns the `GdkDisplay` this seat belongs to.

gdk/gdksubsurface.c

@@ -167,12 +167,6 @@ gdk_subsurface_attach (GdkSubsurface         *subsurface,
   g_return_val_if_fail (sibling == NULL || GDK_IS_SUBSURFACE (sibling), FALSE);
   g_return_val_if_fail (sibling == NULL || sibling->parent == subsurface->parent, FALSE);
 
-  /* if the texture fully covers the background, ignore it */
-  if (background &&
-      gsk_rect_contains_rect (dest, background) &&
-      gdk_memory_format_alpha (gdk_texture_get_format (texture)) == GDK_MEMORY_ALPHA_OPAQUE)
-    background = NULL;
-
   result = GDK_SUBSURFACE_GET_CLASS (subsurface)->attach (subsurface,
                                                           texture,
                                                           source,

gdk/gdksurface.c

@@ -40,13 +40,11 @@
 #include <glib/gi18n-lib.h>
 #include "gdkmarshalers.h"
 #include "gdkpopupprivate.h"
-#include "gdkrectangleprivate.h"
+#include "gdkrectangle.h"
 #include "gdktoplevelprivate.h"
 #include "gdkvulkancontext.h"
 #include "gdksubsurfaceprivate.h"
 
-#include "gsk/gskrectprivate.h"
-
 #include <math.h>
 
 #ifdef HAVE_EGL
@@ -77,9 +75,6 @@ struct _GdkSurfacePrivate
   GdkMemoryDepth egl_surface_depth;
 #endif
 
-  cairo_region_t *opaque_region;
-  cairo_rectangle_int_t opaque_rect; /* This is different from the region */
-
   gpointer widget;
 
   GdkColorState *color_state;
@@ -515,12 +510,6 @@ gdk_surface_real_create_subsurface (GdkSurface *surface)
   return NULL;
 }
 
-static void
-gdk_surface_default_set_opaque_region (GdkSurface     *surface,
-                                       cairo_region_t *region)
-{
-}
-
 static void
 gdk_surface_constructed (GObject *object)
 {
@@ -544,10 +533,9 @@ gdk_surface_class_init (GdkSurfaceClass *klass)
   klass->beep = gdk_surface_real_beep;
   klass->get_scale = gdk_surface_real_get_scale;
   klass->create_subsurface = gdk_surface_real_create_subsurface;
-  klass->set_opaque_region = gdk_surface_default_set_opaque_region;
 
   /**
-   * GdkSurface:cursor:
+   * GdkSurface:cursor: (attributes org.gtk.Property.get=gdk_surface_get_cursor org.gtk.Property.set=gdk_surface_set_cursor)
    *
    * The mouse pointer for the `GdkSurface`.
    */
@@ -557,7 +545,7 @@ gdk_surface_class_init (GdkSurfaceClass *klass)
                            G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkSurface:display:
+   * GdkSurface:display: (attributes org.gtk.Property.get=gdk_surface_get_display)
    *
    * The `GdkDisplay` connection of the surface.
    */
@@ -567,7 +555,7 @@ gdk_surface_class_init (GdkSurfaceClass *klass)
                            G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkSurface:frame-clock:
+   * GdkSurface:frame-clock: (attributes org.gtk.Property.get=gdk_surface_get_frame_clock)
    *
    * The `GdkFrameClock` of the surface.
    */
@@ -577,7 +565,7 @@ gdk_surface_class_init (GdkSurfaceClass *klass)
                            G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkSurface:mapped:
+   * GdkSurface:mapped: (attributes org.gtk.Property.get=gdk_surface_get_mapped)
    *
    * Whether the surface is mapped.
    */
@@ -587,7 +575,7 @@ gdk_surface_class_init (GdkSurfaceClass *klass)
                             G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkSurface:width:
+   * GdkSurface:width: (attributes org.gtk.Property.get=gdk_surface_get_width)
    *
    * The width of the surface in pixels.
    */
@@ -597,7 +585,7 @@ gdk_surface_class_init (GdkSurfaceClass *klass)
                         G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkSurface:height:
+   * GdkSurface:height: (attributes org.gtk.Property.get=gdk_surface_get_height)
    *
    * The height of the surface, in pixels.
    */
@@ -607,7 +595,7 @@ gdk_surface_class_init (GdkSurfaceClass *klass)
                         G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkSurface:scale-factor:
+   * GdkSurface:scale-factor: (attributes org.gtk.Property.get=gdk_surface_get_scale_factor)
    *
    * The scale factor of the surface.
    *
@@ -620,7 +608,7 @@ gdk_surface_class_init (GdkSurfaceClass *klass)
                         G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
 
   /**
-   * GdkSurface:scale:
+   * GdkSurface:scale: (attributes org.gtk.Property.get=gdk_surface_get_scale)
    *
    * The scale of the surface.
    *
@@ -783,7 +771,7 @@ gdk_surface_finalize (GObject *object)
 
   g_clear_object (&surface->display);
 
-  g_clear_pointer (&priv->opaque_region, cairo_region_destroy);
+  g_clear_pointer (&surface->opaque_region, cairo_region_destroy);
 
   if (surface->parent)
     surface->parent->children = g_list_remove (surface->parent->children, surface);
@@ -1083,7 +1071,7 @@ gdk_surface_get_widget (GdkSurface *self)
 }
 
 /**
- * gdk_surface_get_display:
+ * gdk_surface_get_display: (attributes org.gtk.Method.get_property=display)
  * @surface: a `GdkSurface`
  *
  * Gets the `GdkDisplay` associated with a `GdkSurface`.
@@ -1112,7 +1100,7 @@ gdk_surface_is_destroyed (GdkSurface *surface)
 }
 
 /**
- * gdk_surface_get_mapped:
+ * gdk_surface_get_mapped: (attributes org.gtk.Method.get_property=mapped)
  * @surface: a `GdkSurface`
  *
  * Checks whether the surface has been mapped.
@@ -1136,7 +1124,6 @@ gdk_surface_set_egl_native_window (GdkSurface *self,
 {
 #ifdef HAVE_EGL
   GdkSurfacePrivate *priv = gdk_surface_get_instance_private (self);
-  GdkGLContext *current = NULL;
 
   /* This checks that all EGL platforms we support conform to the same struct sizes.
    * When this ever fails, there will be some fun times happening for whoever tries
@@ -1147,19 +1134,12 @@ gdk_surface_set_egl_native_window (GdkSurface *self,
     {
       GdkDisplay *display = gdk_surface_get_display (self);
 
-      current = gdk_gl_context_clear_current_if_surface (self);
-
+      gdk_gl_context_clear_current_if_surface (self);
       eglDestroySurface (gdk_display_get_egl_display (display), priv->egl_surface);
       priv->egl_surface = NULL;
     }
 
   priv->egl_native_window = native_window;
-
-  if (current)
-    {
-      gdk_gl_context_make_current (current);
-      g_object_unref (current);
-    }
 }
 
 gpointer /* EGLSurface */
@@ -1179,26 +1159,20 @@ gdk_surface_ensure_egl_surface (GdkSurface     *self,
 
   g_return_val_if_fail (priv->egl_native_window != NULL, depth);
 
-  if (depth == GDK_MEMORY_NONE)
+  if (priv->egl_surface_depth != depth &&
+      priv->egl_surface != NULL &&
+      gdk_display_get_egl_config (display, priv->egl_surface_depth) != gdk_display_get_egl_config (display, depth))
     {
-      if (priv->egl_surface_depth == GDK_MEMORY_NONE)
-        depth = GDK_MEMORY_U8;
-      else
-        depth = priv->egl_surface_depth;
+      gdk_gl_context_clear_current_if_surface (self);
+      eglDestroySurface (gdk_display_get_egl_display (display), priv->egl_surface);
+      priv->egl_surface = NULL;
     }
 
-  if (priv->egl_surface == NULL ||
-      (priv->egl_surface != NULL &&
-       gdk_display_get_egl_config (display, priv->egl_surface_depth) != gdk_display_get_egl_config (display, depth)))
+  if (priv->egl_surface == NULL)
     {
-      GdkGLContext *cleared;
       EGLint attribs[4];
       int i;
 
-      cleared = gdk_gl_context_clear_current_if_surface (self);
-      if (priv->egl_surface != NULL)
-        eglDestroySurface (gdk_display_get_egl_display (display), priv->egl_surface);
-
       i = 0;
       if (depth == GDK_MEMORY_U8_SRGB && display->have_egl_gl_colorspace)
         {
@@ -1223,12 +1197,6 @@ gdk_surface_ensure_egl_surface (GdkSurface     *self,
                                                       NULL);
         }
       priv->egl_surface_depth = depth;
-
-      if (cleared)
-        {
-          gdk_gl_context_make_current (cleared);
-          g_object_unref (cleared);
-        }
     }
 
   return priv->egl_surface_depth;
@@ -1288,7 +1256,7 @@ gdk_surface_create_gl_context (GdkSurface   *surface,
   if (!gdk_display_prepare_gl (surface->display, error))
     return NULL;
 
-  return gdk_gl_context_new (surface->display, surface, FALSE);
+  return gdk_gl_context_new (surface->display, surface);
 }
 
 /**
@@ -1845,7 +1813,7 @@ gdk_surface_set_cursor_internal (GdkSurface *surface,
 }
 
 /**
- * gdk_surface_get_cursor:
+ * gdk_surface_get_cursor: (attributes org.gtk.Method.get_property=cursor)
  * @surface: a `GdkSurface`
  *
  * Retrieves a `GdkCursor` pointer for the cursor currently set on the
@@ -1867,7 +1835,7 @@ gdk_surface_get_cursor (GdkSurface *surface)
 }
 
 /**
- * gdk_surface_set_cursor:
+ * gdk_surface_set_cursor: (attributes org.gtk.Method.set_property=cursor)
  * @surface: a `GdkSurface`
  * @cursor: (nullable): a `GdkCursor`
  *
@@ -2027,7 +1995,7 @@ gdk_surface_get_geometry (GdkSurface *surface,
 }
 
 /**
- * gdk_surface_get_width:
+ * gdk_surface_get_width: (attributes org.gtk.Method.get_property=width)
  * @surface: a `GdkSurface`
  *
  * Returns the width of the given @surface.
@@ -2046,7 +2014,7 @@ gdk_surface_get_width (GdkSurface *surface)
 }
 
 /**
- * gdk_surface_get_height:
+ * gdk_surface_get_height: (attributes org.gtk.Method.get_property=height)
  * @surface: a `GdkSurface`
  *
  * Returns the height of the given @surface.
@@ -2590,7 +2558,7 @@ gdk_surface_set_frame_clock (GdkSurface     *surface,
 }
 
 /**
- * gdk_surface_get_frame_clock:
+ * gdk_surface_get_frame_clock: (attributes org.gtk.Method.get_property=frame-clock)
  * @surface: surface to get frame clock for
  *
  * Gets the frame clock for the surface.
@@ -2609,7 +2577,7 @@ gdk_surface_get_frame_clock (GdkSurface *surface)
 }
 
 /**
- * gdk_surface_get_scale_factor:
+ * gdk_surface_get_scale_factor: (attributes org.gtk.Method.get_property=scale-factor)
  * @surface: surface to get scale factor for
  *
  * Returns the internal scale factor that maps from surface coordinates
@@ -2635,7 +2603,7 @@ gdk_surface_get_scale_factor (GdkSurface *surface)
 }
 
 /**
- * gdk_surface_get_scale:
+ * gdk_surface_get_scale: (attributes org.gtk.Method.get_property=scale)
  * @surface: surface to get scale for
  *
  * Returns the internal scale that maps from surface coordinates
@@ -2665,35 +2633,6 @@ gdk_surface_get_scale (GdkSurface *surface)
   return GDK_SURFACE_GET_CLASS (surface)->get_scale (surface);
 }
 
-static void
-gdk_surface_update_opaque_region (GdkSurface *self)
-{
-  GdkSurfacePrivate *priv = gdk_surface_get_instance_private (self);
-  cairo_region_t *region;
-
-  if (priv->opaque_region == NULL)
-    {
-      if (priv->opaque_rect.width <= 0)
-        region = NULL;
-      else
-        region = cairo_region_create_rectangle (&priv->opaque_rect);
-    }
-  else
-    {
-      if (priv->opaque_rect.width <= 0)
-        region = cairo_region_reference (priv->opaque_region);
-      else
-        {
-          region = cairo_region_copy (priv->opaque_region);
-          cairo_region_union_rectangle (region, &priv->opaque_rect);
-        }
-    }
-
-  GDK_SURFACE_GET_CLASS (self)->set_opaque_region (self, region);
-
-  g_clear_pointer (&region, cairo_region_destroy);
-}
-
 /**
  * gdk_surface_set_opaque_region:
  * @surface: a top-level `GdkSurface`
@@ -2715,77 +2654,27 @@ gdk_surface_update_opaque_region (GdkSurface *self)
  * is opaque, as we know where the opaque regions are. If your surface
  * background is not opaque, please update this property in your
  * [GtkWidgetClass.css_changed](../gtk4/vfunc.Widget.css_changed.html) handler.
- *
- * Deprecated: 4.16: GDK can figure out the opaque parts of a window itself
- *   by inspecting the contents that are drawn.
  */
 void
 gdk_surface_set_opaque_region (GdkSurface      *surface,
                                cairo_region_t *region)
 {
-  GdkSurfacePrivate *priv = gdk_surface_get_instance_private (surface);
+  GdkSurfaceClass *class;
 
   g_return_if_fail (GDK_IS_SURFACE (surface));
   g_return_if_fail (!GDK_SURFACE_DESTROYED (surface));
 
-  if (cairo_region_equal (priv->opaque_region, region))
+  if (cairo_region_equal (surface->opaque_region, region))
     return;
 
-  g_clear_pointer (&priv->opaque_region, cairo_region_destroy);
+  g_clear_pointer (&surface->opaque_region, cairo_region_destroy);
 
   if (region != NULL)
-    priv->opaque_region = cairo_region_reference (region);
+    surface->opaque_region = cairo_region_reference (region);
 
-  gdk_surface_update_opaque_region (surface);
-}
-
-/* Sets the opaque rect from the rendernode via end_frame() */
-void
-gdk_surface_set_opaque_rect (GdkSurface            *self,
-                             const graphene_rect_t *rect)
-{
-  GdkSurfacePrivate *priv = gdk_surface_get_instance_private (self);
-  cairo_rectangle_int_t opaque;
-
-  if (rect)
-    gsk_rect_to_cairo_shrink (rect, &opaque);
-  else
-    opaque = (cairo_rectangle_int_t) { 0, 0, 0, 0 };
-
-  if (gdk_rectangle_equal (&priv->opaque_rect, &opaque))
-    return;
-
-  priv->opaque_rect = opaque;
-
-  gdk_surface_update_opaque_region (self);
-}
-
-/*
- * gdk_surface_is_opaque:
- * @self: a surface
- *
- * Checks if the whole surface is known to be opaque.
- * This allows using an RGBx buffer instead of RGBA.
- *
- * This function works for the currently rendered frame inside
- * begin_frame() implementations.
- *
- * Returns: %TRUE if the whole surface is provably opaque
- **/
-gboolean
-gdk_surface_is_opaque (GdkSurface *self)
-{
-  GdkSurfacePrivate *priv = gdk_surface_get_instance_private (self);
-  cairo_rectangle_int_t whole = { 0, 0, self->width, self->height };
-
-  if (gdk_rectangle_contains (&priv->opaque_rect, &whole))
-    return TRUE;
-
-  if (priv->opaque_region &&
-      cairo_region_contains_rectangle (priv->opaque_region, &whole) == CAIRO_REGION_OVERLAP_IN)
-    return TRUE;
-
-  return FALSE;
+  class = GDK_SURFACE_GET_CLASS (surface);
+  if (class->set_opaque_region)
+    class->set_opaque_region (surface, region);
 }
 
 void

gdk/gdksurface.h

@@ -125,7 +125,7 @@ void       gdk_surface_request_layout     (GdkSurface       *surface);
 GDK_AVAILABLE_IN_ALL
 GdkFrameClock* gdk_surface_get_frame_clock      (GdkSurface     *surface);
 
-GDK_DEPRECATED_IN_4_16
+GDK_AVAILABLE_IN_ALL
 void       gdk_surface_set_opaque_region        (GdkSurface      *surface,
                                                  cairo_region_t *region);
 

gdk/gdksurfaceprivate.h

@@ -96,6 +96,8 @@ struct _GdkSurface
   GSList *draw_contexts;
   GdkDrawContext *paint_context;
 
+  cairo_region_t *opaque_region;
+
   GdkSeat *current_shortcuts_inhibited_seat;
 
   GPtrArray *subsurfaces;
@@ -251,17 +253,14 @@ gdk_gravity_flip_vertically (GdkGravity anchor)
   g_assert_not_reached ();
 }
 
-void       _gdk_surface_destroy           (GdkSurface           *surface,
-                                           gboolean               foreign_destroy);
-void       gdk_surface_invalidate_rect    (GdkSurface            *surface,
-                                           const GdkRectangle    *rect);
-void       gdk_surface_invalidate_region  (GdkSurface            *surface,
-                                           const cairo_region_t  *region);
-void       _gdk_surface_clear_update_area (GdkSurface            *surface);
-void       _gdk_surface_update_size       (GdkSurface            *surface);
-void       gdk_surface_set_opaque_rect    (GdkSurface            *self,
-                                           const graphene_rect_t *rect);
-gboolean   gdk_surface_is_opaque          (GdkSurface            *self);
+void       _gdk_surface_destroy           (GdkSurface      *surface,
+                                           gboolean        foreign_destroy);
+void       gdk_surface_invalidate_rect    (GdkSurface           *surface,
+                                           const GdkRectangle   *rect);
+void       gdk_surface_invalidate_region  (GdkSurface           *surface,
+                                           const cairo_region_t *region);
+void       _gdk_surface_clear_update_area (GdkSurface      *surface);
+void       _gdk_surface_update_size       (GdkSurface      *surface);
 
 GdkGLContext * gdk_surface_get_paint_gl_context (GdkSurface *surface,
                                                  GError   **error);

gdk/gdktexture.c

@@ -33,18 +33,7 @@
  *
  * `GdkTexture` is an immutable object: That means you cannot change
  * anything about it other than increasing the reference count via
- * [method@GObject.Object.ref], and consequently, it is a threadsafe object.
- *
- * GDK provides a number of threadsafe texture loading functions:
- * [ctor@Gdk.Texture.new_from_resource],
- * [ctor@Gdk.Texture.new_from_bytes],
- * [ctor@Gdk.Texture.new_from_file],
- * [ctor@Gdk.Texture.new_from_filename],
- * [ctor@Gdk.Texture.new_for_pixbuf]. Note that these are meant for loading
- * icons and resources that are shipped with the toolkit or application. It
- * is recommended that you use a dedicated image loading framework such as
- * [glycin](https://lib.rs/crates/glycin), if you need to load untrusted image
- * data.
+ * [method@GObject.Object.ref], and consequently, it is a thread-safe object.
  */
 
 #include "config.h"
@@ -395,7 +384,7 @@ gdk_texture_class_init (GdkTextureClass *klass)
   gobject_class->finalize = gdk_texture_finalize;
 
   /**
-   * GdkTexture:width:
+   * GdkTexture:width: (attributes org.gtk.Property.get=gdk_texture_get_width)
    *
    * The width of the texture, in pixels.
    */
@@ -410,7 +399,7 @@ gdk_texture_class_init (GdkTextureClass *klass)
                       G_PARAM_EXPLICIT_NOTIFY);
 
   /**
-   * GdkTexture:height:
+   * GdkTexture:height: (attributes org.gtk.Property.get=gdk_texture_get_height)
    *
    * The height of the texture, in pixels.
    */
@@ -425,7 +414,7 @@ gdk_texture_class_init (GdkTextureClass *klass)
                       G_PARAM_EXPLICIT_NOTIFY);
 
   /**
-   * GdkTexture:color-state:
+   * GdkTexture:color-state: (attributes org.gtk.Property.get=gdk_texture_get_color_state)
    *
    * The color state of the texture.
    *
@@ -781,7 +770,7 @@ gdk_texture_new_from_filename (const char  *path,
 }
 
 /**
- * gdk_texture_get_width:
+ * gdk_texture_get_width: (attributes org.gtk.Method.get_property=width)
  * @texture: a `GdkTexture`
  *
  * Returns the width of @texture, in pixels.
@@ -797,7 +786,7 @@ gdk_texture_get_width (GdkTexture *texture)
 }
 
 /**
- * gdk_texture_get_height:
+ * gdk_texture_get_height: (attributes org.gtk.Method.get_property=height)
  * @texture: a `GdkTexture`
  *
  * Returns the height of the @texture, in pixels.
@@ -813,7 +802,7 @@ gdk_texture_get_height (GdkTexture *texture)
 }
 
 /**
- * gdk_texture_get_color_state:
+ * gdk_texture_get_color_state: (attributes org.gtk.Method.get_property=color-state)
  * @self: a `GdkTexture`
  *
  * Returns the color state associated with the texture.

gdk/gdktoplevel.c

@@ -157,7 +157,7 @@ gdk_toplevel_default_init (GdkToplevelInterface *iface)
   iface->unexport_handle = gdk_toplevel_default_unexport_handle;
 
   /**
-   * GdkToplevel:state:
+   * GdkToplevel:state: (attributes org.gtk.Property.get=gdk_toplevel_get_state)
    *
    * The state of the toplevel.
    */
@@ -167,7 +167,7 @@ gdk_toplevel_default_init (GdkToplevelInterface *iface)
                           G_PARAM_READABLE | G_PARAM_STATIC_STRINGS));
 
   /**
-   * GdkToplevel:title:
+   * GdkToplevel:title: (attributes org.gtk.Property.set=gdk_toplevel_set_title)
    *
    * The title of the surface.
    */
@@ -177,7 +177,7 @@ gdk_toplevel_default_init (GdkToplevelInterface *iface)
                            G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY));
 
   /**
-   * GdkToplevel:startup-id:
+   * GdkToplevel:startup-id: (attributes org.gtk.Property.set=gdk_toplevel_set_startup_id)
    *
    * The startup ID of the surface.
    *
@@ -190,7 +190,7 @@ gdk_toplevel_default_init (GdkToplevelInterface *iface)
                            G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY));
 
   /**
-   * GdkToplevel:transient-for:
+   * GdkToplevel:transient-for: (attributes org.gtk.Property.set=gdk_toplevel_set_transient_for)
    *
    * The transient parent of the surface.
    */
@@ -200,7 +200,7 @@ gdk_toplevel_default_init (GdkToplevelInterface *iface)
                            G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY));
 
   /**
-   * GdkToplevel:modal:
+   * GdkToplevel:modal: (attributes org.gtk.Property.set=gdk_toplevel_set_modal)
    *
    * Whether the surface is modal.
    */
@@ -210,7 +210,7 @@ gdk_toplevel_default_init (GdkToplevelInterface *iface)
                             G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY));
 
   /**
-   * GdkToplevel:icon-list:
+   * GdkToplevel:icon-list: (attributes org.gtk.Property.set=gdk_toplevel_set_icon_list)
    *
    * A list of textures to use as icon.
    */
@@ -219,7 +219,7 @@ gdk_toplevel_default_init (GdkToplevelInterface *iface)
                             G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY));
 
   /**
-   * GdkToplevel:decorated:
+   * GdkToplevel:decorated: (attributes org.gtk.Property.set=gdk_toplevel_set_decorated)
    *
    * Whether the window manager should add decorations.
    */
@@ -229,7 +229,7 @@ gdk_toplevel_default_init (GdkToplevelInterface *iface)
                             G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY));
 
   /**
-   * GdkToplevel:deletable:
+   * GdkToplevel:deletable: (attributes org.gtk.Property.set=gdk_toplevel_set_deletable)
    *
    * Whether the window manager should allow to close the surface.
    */
@@ -391,7 +391,7 @@ gdk_toplevel_focus (GdkToplevel *toplevel,
 }
 
 /**
- * gdk_toplevel_get_state:
+ * gdk_toplevel_get_state: (attributes org.gtk.Method.get_property=state)
  * @toplevel: a `GdkToplevel`
  *
  * Gets the bitwise or of the currently active surface state flags,
@@ -412,7 +412,7 @@ gdk_toplevel_get_state (GdkToplevel *toplevel)
 }
 
 /**
- * gdk_toplevel_set_title:
+ * gdk_toplevel_set_title: (attributes org.gtk.Method.set_property=title)
  * @toplevel: a `GdkToplevel`
  * @title: title of @surface
  *
@@ -431,7 +431,7 @@ gdk_toplevel_set_title (GdkToplevel *toplevel,
 }
 
 /**
- * gdk_toplevel_set_startup_id:
+ * gdk_toplevel_set_startup_id: (attributes org.gtk.Method.set_property=startup-id)
  * @toplevel: a `GdkToplevel`
  * @startup_id: a string with startup-notification identifier
  *
@@ -451,7 +451,7 @@ gdk_toplevel_set_startup_id (GdkToplevel *toplevel,
 }
 
 /**
- * gdk_toplevel_set_transient_for:
+ * gdk_toplevel_set_transient_for: (attributes org.gtk.Method.set_property=transient-for)
  * @toplevel: a `GdkToplevel`
  * @parent: another toplevel `GdkSurface`
  *
@@ -475,7 +475,7 @@ gdk_toplevel_set_transient_for (GdkToplevel *toplevel,
 }
 
 /**
- * gdk_toplevel_set_modal:
+ * gdk_toplevel_set_modal: (attributes org.gtk.Method.set_property=modal)
  * @toplevel: a `GdkToplevel`
  * @modal: %TRUE if the surface is modal, %FALSE otherwise.
  *
@@ -499,7 +499,7 @@ gdk_toplevel_set_modal (GdkToplevel *toplevel,
 }
 
 /**
- * gdk_toplevel_set_icon_list:
+ * gdk_toplevel_set_icon_list: (attributes org.gtk.Method.set_property=icon-list)
  * @toplevel: a `GdkToplevel`
  * @surfaces: (transfer none) (element-type GdkTexture):
  *   A list of textures to use as icon, of different sizes
@@ -547,7 +547,7 @@ gdk_toplevel_show_window_menu (GdkToplevel *toplevel,
 }
 
 /**
- * gdk_toplevel_set_decorated:
+ * gdk_toplevel_set_decorated: (attributes org.gtk.Method.set_property=decorated)
  * @toplevel: a `GdkToplevel`
  * @decorated: %TRUE to request decorations
  *
@@ -567,7 +567,7 @@ gdk_toplevel_set_decorated (GdkToplevel *toplevel,
 }
 
 /**
- * gdk_toplevel_set_deletable:
+ * gdk_toplevel_set_deletable: (attributes org.gtk.Method.set_property=deletable)
  * @toplevel: a `GdkToplevel`
  * @deletable: %TRUE to request a delete button
  *

gdk/gdktoplevel.h

@@ -85,6 +85,7 @@ typedef enum
  * @GDK_TOPLEVEL_STATE_BOTTOM_RESIZABLE: whether the bottom edge is resizable
  * @GDK_TOPLEVEL_STATE_LEFT_TILED: whether the left edge is tiled
  * @GDK_TOPLEVEL_STATE_LEFT_RESIZABLE: whether the left edge is resizable
+ * @GDK_TOPLEVEL_STATE_SUSPENDED: the surface is not visible to the user
  *
  * Specifies the state of a toplevel surface.
  *
@@ -94,14 +95,6 @@ typedef enum
  * will give an indication of tiledness without any of the per-edge states
  * being set.
  */
-
-/**
- * GDK_TOPLEVEL_STATE_SUSPENDED:
- *
- * The surface is not visible to the user.
- *
- * Since: 4.12
- */
 typedef enum
 {
   GDK_TOPLEVEL_STATE_MINIMIZED        = 1 << 0,

gdk/gdkvulkancontext.c

@@ -41,7 +41,6 @@ static const GdkDebugKey gsk_vulkan_feature_keys[] = {
   { "semaphore-export", GDK_VULKAN_FEATURE_SEMAPHORE_EXPORT, "Disable sync of exported dmabufs" },
   { "semaphore-import", GDK_VULKAN_FEATURE_SEMAPHORE_IMPORT, "Disable sync of imported dmabufs" },
   { "incremental-present", GDK_VULKAN_FEATURE_INCREMENTAL_PRESENT, "Do not send damage regions" },
-  { "swapchain-maintenance", GDK_VULKAN_FEATURE_SWAPCHAIN_MAINTENANCE, "Do not use advanced swapchain features" },
 };
 #endif
 
@@ -272,13 +271,7 @@ gdk_vulkan_strerror (VkResult result)
 #endif
 #if VK_HEADER_VERSION >= 274
     case VK_ERROR_INVALID_VIDEO_STD_PARAMETERS_KHR:
-      return "The specified Video Std parameters do not adhere to the syntactic or semantic requirements of the used video compression standard or implementation. (VK_ERROR_INVALID_VIDEO_STD_PARAMETERS_KHR)";
-#endif
-#if VK_HEADER_VERSION >= 294
-    case VK_PIPELINE_BINARY_MISSING_KHR:
-      return "The application attempted to create a pipeline binary by querying an internal cache, but the internal cache entry did not exist. (VK_PIPELINE_BINARY_MISSING_KHR)";
-    case VK_ERROR_NOT_ENOUGH_SPACE_KHR:
-      return "The application did not provide enough space to return all the required data. (VK_ERROR_NOT_ENOUGH_SPACE_KHR)";
+      return "The specified Video Std parameters do not adhere to the syntactic or semantic requirements of the used video compression standard or implementation";
 #endif
 
     case VK_RESULT_MAX_ENUM:
@@ -310,15 +303,6 @@ surface_present_mode_to_string (VkPresentModeKHR present_mode)
   return "(unknown)";
 }
 
-static gboolean
-gdk_vulkan_context_has_feature (GdkVulkanContext  *self,
-                                GdkVulkanFeatures  feature)
-{
-  GdkDisplay *display = gdk_draw_context_get_display (GDK_DRAW_CONTEXT (self));
-
-  return (display->vulkan_features & feature) ? TRUE : FALSE;
-}
-
 static const VkPresentModeKHR preferred_present_modes[] = {
   VK_PRESENT_MODE_MAILBOX_KHR,
   VK_PRESENT_MODE_IMMEDIATE_KHR,
@@ -572,12 +556,8 @@ physical_device_supports_extension (VkPhysicalDevice  device,
 static GdkVulkanFeatures
 physical_device_check_features (VkPhysicalDevice device)
 {
-  VkPhysicalDeviceSwapchainMaintenance1FeaturesEXT swapchain_maintenance1_features = {
-      .sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SWAPCHAIN_MAINTENANCE_1_FEATURES_EXT,
-  };
   VkPhysicalDeviceVulkan12Features v12_features = {
       .sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_1_2_FEATURES,
-      .pNext = &swapchain_maintenance1_features
   };
   VkPhysicalDeviceSamplerYcbcrConversionFeatures ycbcr_features = {
       .sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SAMPLER_YCBCR_CONVERSION_FEATURES,
@@ -623,10 +603,6 @@ physical_device_check_features (VkPhysicalDevice device)
   if (physical_device_supports_extension (device, VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME))
     features |= GDK_VULKAN_FEATURE_INCREMENTAL_PRESENT;
 
-  if (swapchain_maintenance1_features.swapchainMaintenance1 ||
-      physical_device_supports_extension (device, VK_EXT_SWAPCHAIN_MAINTENANCE_1_EXTENSION_NAME))
-    features |= GDK_VULKAN_FEATURE_SWAPCHAIN_MAINTENANCE;
-
   return features;
 }
 
@@ -702,10 +678,7 @@ gdk_vulkan_context_begin_frame (GdkDrawContext  *draw_context,
 
   cairo_region_union (region, priv->regions[priv->draw_index]);
 
-  if (priv->current_depth == GDK_MEMORY_U8_SRGB)
-    *out_color_state = gdk_color_state_get_no_srgb_tf (color_state);
-  else
-    *out_color_state = color_state;
+  *out_color_state = color_state;
   *out_depth = priv->current_depth;
 }
 
@@ -716,10 +689,11 @@ gdk_vulkan_context_end_frame (GdkDrawContext *draw_context,
   GdkVulkanContext *context = GDK_VULKAN_CONTEXT (draw_context);
   GdkVulkanContextPrivate *priv = gdk_vulkan_context_get_instance_private (context);
   GdkSurface *surface = gdk_draw_context_get_surface (draw_context);
+  GdkDisplay *display = gdk_draw_context_get_display (draw_context);
   VkRectLayerKHR *rectangles;
   int n_regions;
 
-  if (gdk_vulkan_context_has_feature (context, GDK_VULKAN_FEATURE_INCREMENTAL_PRESENT))
+  if (display->vulkan_features & GDK_VULKAN_FEATURE_INCREMENTAL_PRESENT)
     {
       double scale;
 
@@ -737,8 +711,8 @@ gdk_vulkan_context_end_frame (GdkDrawContext *draw_context,
               .layer = 0,
               .offset.x = (int) floor (r.x * scale),
               .offset.y = (int) floor (r.y * scale),
-              .extent.width = (int) ceil ((r.x + r.width) * scale) - floor (r.x * scale),
-              .extent.height = (int) ceil ((r.y + r.height) * scale) - floor (r.y * scale),
+              .extent.width = (int) ceil (r.width * scale),
+              .extent.height = (int) ceil (r.height * scale),
           };
         }
     }
@@ -1371,6 +1345,7 @@ gdk_vulkan_context_get_draw_index (GdkVulkanContext *context)
   GdkVulkanContextPrivate *priv = gdk_vulkan_context_get_instance_private (context);
 
   g_return_val_if_fail (GDK_IS_VULKAN_CONTEXT (context), 0);
+  g_return_val_if_fail (gdk_draw_context_is_in_frame (GDK_DRAW_CONTEXT (context)), 0);
 
   return priv->draw_index;
 }
@@ -1394,6 +1369,7 @@ gdk_vulkan_context_set_draw_semaphore (GdkVulkanContext *context,
   GdkVulkanContextPrivate *priv = gdk_vulkan_context_get_instance_private (context);
 
   g_return_if_fail (GDK_IS_VULKAN_CONTEXT (context));
+  g_return_if_fail (!gdk_draw_context_is_in_frame (GDK_DRAW_CONTEXT (context)));
   g_return_if_fail (priv->draw_semaphore == VK_NULL_HANDLE);
 
   priv->draw_semaphore = semaphore;
@@ -1429,9 +1405,8 @@ gdk_display_create_vulkan_device (GdkDisplay  *display,
   last = n_devices;
 
   skip_features = gdk_parse_debug_var ("GDK_VULKAN_DISABLE",
-      "GDK_VULKAN_DISABLE can be set to a list of Vulkan features to disable.\n",
-      gsk_vulkan_feature_keys,
-      G_N_ELEMENTS (gsk_vulkan_feature_keys));
+                                       gsk_vulkan_feature_keys,
+                                       G_N_ELEMENTS (gsk_vulkan_feature_keys));
   if (skip_features & GDK_VULKAN_FEATURE_YCBCR)
     skip_features |= GDK_VULKAN_FEATURE_DMABUF;
 
@@ -1530,11 +1505,6 @@ gdk_display_create_vulkan_device (GdkDisplay  *display,
         {
           if (queue_props[j].queueFlags & VK_QUEUE_GRAPHICS_BIT)
             {
-              VkPhysicalDeviceSwapchainMaintenance1FeaturesEXT swapchain_maintenance1_features = { 
-                .sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SWAPCHAIN_MAINTENANCE_1_FEATURES_EXT,
-                .swapchainMaintenance1 = VK_TRUE,
-              };
-              gpointer create_device_pNext = NULL;
               GPtrArray *device_extensions;
 
               device_extensions = g_ptr_array_new ();
@@ -1563,12 +1533,6 @@ gdk_display_create_vulkan_device (GdkDisplay  *display,
                 }
               if (features & GDK_VULKAN_FEATURE_INCREMENTAL_PRESENT)
                 g_ptr_array_add (device_extensions, (gpointer) VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
-              if (features & GDK_VULKAN_FEATURE_SWAPCHAIN_MAINTENANCE)
-                {
-                  g_ptr_array_add (device_extensions, (gpointer) VK_EXT_SWAPCHAIN_MAINTENANCE_1_EXTENSION_NAME);
-                  swapchain_maintenance1_features.pNext = create_device_pNext;
-                  create_device_pNext = &swapchain_maintenance1_features;
-                }
 
 #define ENABLE_IF(flag) ((features & (flag)) ? VK_TRUE : VK_FALSE)
               GDK_DISPLAY_DEBUG (display, VULKAN, "Using Vulkan device %u, queue %u", i, j);
@@ -1587,7 +1551,6 @@ gdk_display_create_vulkan_device (GdkDisplay  *display,
                                                     .pNext = &(VkPhysicalDeviceVulkan11Features) {
                                                         .sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_1_1_FEATURES,
                                                         .samplerYcbcrConversion = ENABLE_IF (GDK_VULKAN_FEATURE_YCBCR),
-                                                        .pNext = create_device_pNext,
                                                     }
                                                 },
                                                 NULL,
@@ -1639,9 +1602,9 @@ gdk_vulkan_debug_report (VkDebugReportFlagsEXT      flags,
                          void*                      pUserData)
 {
   if (flags & VK_DEBUG_REPORT_ERROR_BIT_EXT)
-    g_warning ("Vulkan: %s: %s", pLayerPrefix, pMessage);
+    g_critical ("Vulkan: %s: %s", pLayerPrefix, pMessage);
   else if (flags & VK_DEBUG_REPORT_WARNING_BIT_EXT)
-    g_warning ("Vulkan: %s: %s", pLayerPrefix, pMessage);
+    g_critical ("Vulkan: %s: %s", pLayerPrefix, pMessage);
   else if (flags & VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT)
     g_warning ("Vulkan: %s: %s", pLayerPrefix, pMessage);
   else if (flags & VK_DEBUG_REPORT_DEBUG_BIT_EXT)
@@ -1662,10 +1625,10 @@ gdk_display_create_vulkan_instance (GdkDisplay  *display,
   gboolean have_debug_report = FALSE;
   VkResult res;
 
-  if (!gdk_has_feature (GDK_FEATURE_VULKAN))
+  if (gdk_display_get_debug_flags (display) & GDK_DEBUG_VULKAN_DISABLE)
     {
       g_set_error_literal (error, GDK_VULKAN_ERROR, GDK_VULKAN_ERROR_NOT_AVAILABLE,
-                           _("Vulkan support disabled via GDK_DISABLE"));
+                           _("Vulkan support disabled via GDK_DEBUG"));
       return FALSE;
     }
 
@@ -1706,32 +1669,28 @@ gdk_display_create_vulkan_instance (GdkDisplay  *display,
         g_ptr_array_add (used_extensions, (gpointer) VK_KHR_EXTERNAL_MEMORY_CAPABILITIES_EXTENSION_NAME);
       if (g_str_equal (extensions[i].extensionName, VK_KHR_EXTERNAL_SEMAPHORE_CAPABILITIES_EXTENSION_NAME))
         g_ptr_array_add (used_extensions, (gpointer) VK_KHR_EXTERNAL_SEMAPHORE_CAPABILITIES_EXTENSION_NAME);
-      if (g_str_equal (extensions[i].extensionName, VK_KHR_GET_SURFACE_CAPABILITIES_2_EXTENSION_NAME))
-        g_ptr_array_add (used_extensions, (gpointer) VK_KHR_GET_SURFACE_CAPABILITIES_2_EXTENSION_NAME);
-      if (g_str_equal (extensions[i].extensionName, VK_EXT_SURFACE_MAINTENANCE_1_EXTENSION_NAME))
-        g_ptr_array_add (used_extensions, (gpointer) VK_EXT_SURFACE_MAINTENANCE_1_EXTENSION_NAME);
     }
 
-  res = vkCreateInstance (&(VkInstanceCreateInfo) {
-                               .sType = VK_STRUCTURE_TYPE_INSTANCE_CREATE_INFO,
-                               .pNext = NULL,
-                               .flags = 0,
-                               .pApplicationInfo = &(VkApplicationInfo) {
-                                   .sType = VK_STRUCTURE_TYPE_APPLICATION_INFO,
-                                   .pNext = NULL,
-                                   .pApplicationName = g_get_application_name (),
-                                   .applicationVersion = 0,
-                                   .pEngineName = "GTK",
-                                   .engineVersion = VK_MAKE_VERSION (GDK_MAJOR_VERSION, GDK_MINOR_VERSION, GDK_MICRO_VERSION),
-                                   .apiVersion = VK_API_VERSION_1_3
-                               },
-                               .enabledLayerCount = 0,
-                               .ppEnabledLayerNames = NULL,
-                               .enabledExtensionCount = used_extensions->len,
-                               .ppEnabledExtensionNames = (const char * const *) used_extensions->pdata,
-                           },
-                           NULL,
-                           &display->vk_instance);
+  res = GDK_VK_CHECK (vkCreateInstance, &(VkInstanceCreateInfo) {
+                                             .sType = VK_STRUCTURE_TYPE_INSTANCE_CREATE_INFO,
+                                             .pNext = NULL,
+                                             .flags = 0,
+                                             .pApplicationInfo = &(VkApplicationInfo) {
+                                                 .sType = VK_STRUCTURE_TYPE_APPLICATION_INFO,
+                                                 .pNext = NULL,
+                                                 .pApplicationName = g_get_application_name (),
+                                                 .applicationVersion = 0,
+                                                 .pEngineName = "GTK",
+                                                 .engineVersion = VK_MAKE_VERSION (GDK_MAJOR_VERSION, GDK_MINOR_VERSION, GDK_MICRO_VERSION),
+                                                 .apiVersion = VK_API_VERSION_1_3
+                                             },
+                                             .enabledLayerCount = 0,
+                                             .ppEnabledLayerNames = NULL,
+                                             .enabledExtensionCount = used_extensions->len,
+                                             .ppEnabledExtensionNames = (const char * const *) used_extensions->pdata,
+                                         },
+                                         NULL,
+                                         &display->vk_instance);
   g_ptr_array_free (used_extensions, TRUE);
 
   if (res != VK_SUCCESS)
@@ -1888,6 +1847,8 @@ gdk_display_unref_vulkan (GdkDisplay *display)
   display->vk_instance = VK_NULL_HANDLE;
 }
 
+#ifdef HAVE_DMABUF
+
 /* Hack. We don't include gsk/gsk.h here to avoid a build order problem
  * with the generated header gskenumtypes.h, so we need to hack around
  * a bit to access the gsk api we need.
@@ -1900,10 +1861,10 @@ extern gboolean        gsk_renderer_realize_for_display         (GskRenderer  *r
                                                                  GdkDisplay   *display,
                                                                  GError      **error);
 
-void
-gdk_vulkan_init_dmabuf (GdkDisplay *display)
+GdkDmabufDownloader *
+gdk_vulkan_get_dmabuf_downloader (GdkDisplay              *display,
+                                  GdkDmabufFormatsBuilder *builder)
 {
-#ifdef HAVE_DMABUF
   GdkDmabufFormatsBuilder *vulkan_builder;
   GskRenderer *renderer;
   VkDrmFormatModifierPropertiesEXT modifier_list[100];
@@ -1921,15 +1882,13 @@ gdk_vulkan_init_dmabuf (GdkDisplay *display)
   GError *error = NULL;
   gsize i, j;
 
-  if (display->vk_dmabuf_formats != NULL)
-    return;
+  g_assert (display->vk_dmabuf_formats == NULL);
 
-  if (!gdk_has_feature (GDK_FEATURE_DMABUF) ||
-      !gdk_display_init_vulkan (display, NULL) ||
-      ((display->vulkan_features & GDK_VULKAN_FEATURE_DMABUF) == 0))
-    {
-      return;
-    }
+  if (!gdk_display_init_vulkan (display, NULL))
+    return NULL;
+
+  if ((display->vulkan_features & GDK_VULKAN_FEATURE_DMABUF) == 0)
+    return NULL;
 
   vulkan_builder = gdk_dmabuf_formats_builder_new ();
 
@@ -1963,21 +1922,24 @@ gdk_vulkan_init_dmabuf (GdkDisplay *display)
 
   display->vk_dmabuf_formats = gdk_dmabuf_formats_builder_free_to_formats (vulkan_builder);
 
+  gdk_dmabuf_formats_builder_add_formats (builder, display->vk_dmabuf_formats);
+
   renderer = gsk_vulkan_renderer_new ();
 
   if (!gsk_renderer_realize_for_display (renderer, display, &error))
     {
-      g_warning ("Failed to realize Vulkan renderer: %s", error->message);
+      g_warning ("Failed to realize GL renderer: %s", error->message);
       g_error_free (error);
       g_object_unref (renderer);
+
+      return NULL;
     }
-  else
-    {
-      display->vk_downloader = GDK_DMABUF_DOWNLOADER (renderer);
-    }
-#endif
+
+  return GDK_DMABUF_DOWNLOADER (renderer);
 }
 
+#endif
+
 VkShaderModule
 gdk_display_get_vk_shader_module (GdkDisplay *self,
                                   const char *resource_name)

gdk/gdkvulkancontextprivate.h

@@ -65,7 +65,7 @@ gdk_vulkan_handle_result (VkResult    res,
 {
   if (res != VK_SUCCESS)
     {
-      g_warning ("%s(): %s (%d)", called_function, gdk_vulkan_strerror (res), res);
+      GDK_DEBUG (VULKAN, "%s(): %s (%d)", called_function, gdk_vulkan_strerror (res), res);
     }
 
   return res;
@@ -78,7 +78,10 @@ gboolean                gdk_display_init_vulkan                         (GdkDisp
 void                    gdk_display_ref_vulkan                          (GdkDisplay            *display);
 void                    gdk_display_unref_vulkan                        (GdkDisplay            *display);
 
-void                    gdk_vulkan_init_dmabuf                          (GdkDisplay            *display);
+#ifdef HAVE_DMABUF
+GdkDmabufDownloader *   gdk_vulkan_get_dmabuf_downloader                (GdkDisplay            *display,
+                                                                         GdkDmabufFormatsBuilder *builder);
+#endif
 
 VkShaderModule          gdk_display_get_vk_shader_module                (GdkDisplay            *display,
                                                                          const char            *resource_name);

gdk/keynames.txt

@@ -1133,7 +1133,6 @@
 0x00fe8a dead_small_schwa
 0x00fe8b dead_capital_schwa
 0x00fe8c dead_greek
-0x00fe8d dead_hamza
 0x00fea0 ch
 0x00fea1 Ch
 0x00fea2 CH
@@ -1399,11 +1398,6 @@
 0x1000259 schwa
 0x1000275 obarred
 0x1000292 ezh
-0x1000300 combining_grave
-0x1000301 combining_acute
-0x1000303 combining_tilde
-0x1000309 combining_hook
-0x1000323 combining_belowdot
 0x1000492 Cyrillic_GHE_bar
 0x1000493 Cyrillic_ghe_bar
 0x1000496 Cyrillic_ZHE_descender

gdk/loaders/gdktiff.c

@@ -228,7 +228,7 @@ struct _FormatData {
   guint16 bits_per_sample;
   guint16 samples_per_pixel;
   guint16 sample_format;
-  gint16 alpha_samples;
+  guint16 alpha_samples;
   guint16 photometric;
 };
 
@@ -241,27 +241,27 @@ static const FormatData format_data[] = {
   [GDK_MEMORY_A8R8G8B8]                         = { GDK_MEMORY_R8G8B8A8,                          8, 4, SAMPLEFORMAT_UINT,   EXTRASAMPLE_UNASSALPHA, PHOTOMETRIC_RGB },
   [GDK_MEMORY_R8G8B8A8]                         = { GDK_MEMORY_R8G8B8A8,                          8, 4, SAMPLEFORMAT_UINT,   EXTRASAMPLE_UNASSALPHA, PHOTOMETRIC_RGB },
   [GDK_MEMORY_A8B8G8R8]                         = { GDK_MEMORY_R8G8B8A8,                          8, 4, SAMPLEFORMAT_UINT,   EXTRASAMPLE_UNASSALPHA, PHOTOMETRIC_RGB },
-  [GDK_MEMORY_R8G8B8]                           = { GDK_MEMORY_R8G8B8,                            8, 3, SAMPLEFORMAT_UINT,   -1,                     PHOTOMETRIC_RGB },
-  [GDK_MEMORY_B8G8R8]                           = { GDK_MEMORY_R8G8B8,                            8, 3, SAMPLEFORMAT_UINT,   -1,                     PHOTOMETRIC_RGB },
-  [GDK_MEMORY_R8G8B8X8]                         = { GDK_MEMORY_R8G8B8X8,                          8, 4, SAMPLEFORMAT_UINT,   0,                      PHOTOMETRIC_RGB },
-  [GDK_MEMORY_X8R8G8B8]                         = { GDK_MEMORY_R8G8B8X8,                          8, 4, SAMPLEFORMAT_UINT,   0,                      PHOTOMETRIC_RGB },
-  [GDK_MEMORY_B8G8R8X8]                         = { GDK_MEMORY_R8G8B8X8,                          8, 4, SAMPLEFORMAT_UINT,   0,                      PHOTOMETRIC_RGB },
-  [GDK_MEMORY_X8B8G8R8]                         = { GDK_MEMORY_R8G8B8X8,                          8, 4, SAMPLEFORMAT_UINT,   0,                      PHOTOMETRIC_RGB },
-  [GDK_MEMORY_R16G16B16]                        = { GDK_MEMORY_R16G16B16,                        16, 3, SAMPLEFORMAT_UINT,   -1,                     PHOTOMETRIC_RGB },
+  [GDK_MEMORY_R8G8B8]                           = { GDK_MEMORY_R8G8B8,                            8, 3, SAMPLEFORMAT_UINT,   0,                      PHOTOMETRIC_RGB },
+  [GDK_MEMORY_B8G8R8]                           = { GDK_MEMORY_R8G8B8,                            8, 3, SAMPLEFORMAT_UINT,   0,                      PHOTOMETRIC_RGB },
+  [GDK_MEMORY_R8G8B8X8]                         = { GDK_MEMORY_R8G8B8,                            8, 3, SAMPLEFORMAT_UINT,   0,                      PHOTOMETRIC_RGB },
+  [GDK_MEMORY_X8R8G8B8]                         = { GDK_MEMORY_R8G8B8,                            8, 3, SAMPLEFORMAT_UINT,   0,                      PHOTOMETRIC_RGB },
+  [GDK_MEMORY_B8G8R8X8]                         = { GDK_MEMORY_R8G8B8,                            8, 3, SAMPLEFORMAT_UINT,   0,                      PHOTOMETRIC_RGB },
+  [GDK_MEMORY_X8B8G8R8]                         = { GDK_MEMORY_R8G8B8,                            8, 3, SAMPLEFORMAT_UINT,   0,                      PHOTOMETRIC_RGB },
+  [GDK_MEMORY_R16G16B16]                        = { GDK_MEMORY_R16G16B16,                        16, 3, SAMPLEFORMAT_UINT,   0,                      PHOTOMETRIC_RGB },
   [GDK_MEMORY_R16G16B16A16_PREMULTIPLIED]       = { GDK_MEMORY_R16G16B16A16_PREMULTIPLIED,       16, 4, SAMPLEFORMAT_UINT,   EXTRASAMPLE_ASSOCALPHA, PHOTOMETRIC_RGB },
   [GDK_MEMORY_R16G16B16A16]                     = { GDK_MEMORY_R16G16B16A16,                     16, 4, SAMPLEFORMAT_UINT,   EXTRASAMPLE_UNASSALPHA, PHOTOMETRIC_RGB },
-  [GDK_MEMORY_R16G16B16_FLOAT]                  = { GDK_MEMORY_R16G16B16_FLOAT,                  16, 3, SAMPLEFORMAT_IEEEFP, -1,                     PHOTOMETRIC_RGB },
+  [GDK_MEMORY_R16G16B16_FLOAT]                  = { GDK_MEMORY_R16G16B16_FLOAT,                  16, 3, SAMPLEFORMAT_IEEEFP, 0,                      PHOTOMETRIC_RGB },
   [GDK_MEMORY_R16G16B16A16_FLOAT_PREMULTIPLIED] = { GDK_MEMORY_R16G16B16A16_FLOAT_PREMULTIPLIED, 16, 4, SAMPLEFORMAT_IEEEFP, EXTRASAMPLE_ASSOCALPHA, PHOTOMETRIC_RGB },
   [GDK_MEMORY_R16G16B16A16_FLOAT]               = { GDK_MEMORY_R16G16B16A16_FLOAT,               16, 4, SAMPLEFORMAT_IEEEFP, EXTRASAMPLE_UNASSALPHA, PHOTOMETRIC_RGB },
-  [GDK_MEMORY_R32G32B32_FLOAT]                  = { GDK_MEMORY_R32G32B32_FLOAT,                  32, 3, SAMPLEFORMAT_IEEEFP, -1,                     PHOTOMETRIC_RGB },
+  [GDK_MEMORY_R32G32B32_FLOAT]                  = { GDK_MEMORY_R32G32B32_FLOAT,                  32, 3, SAMPLEFORMAT_IEEEFP, 0,                      PHOTOMETRIC_RGB },
   [GDK_MEMORY_R32G32B32A32_FLOAT_PREMULTIPLIED] = { GDK_MEMORY_R32G32B32A32_FLOAT_PREMULTIPLIED, 32, 4, SAMPLEFORMAT_IEEEFP, EXTRASAMPLE_ASSOCALPHA, PHOTOMETRIC_RGB },
   [GDK_MEMORY_R32G32B32A32_FLOAT]               = { GDK_MEMORY_R32G32B32A32_FLOAT,               32, 4, SAMPLEFORMAT_IEEEFP, EXTRASAMPLE_UNASSALPHA, PHOTOMETRIC_RGB },
   [GDK_MEMORY_G8A8_PREMULTIPLIED]               = { GDK_MEMORY_G8A8_PREMULTIPLIED,                8, 2, SAMPLEFORMAT_UINT,   EXTRASAMPLE_ASSOCALPHA, PHOTOMETRIC_MINISBLACK },
   [GDK_MEMORY_G8A8]                             = { GDK_MEMORY_G8A8,                              8, 2, SAMPLEFORMAT_UINT,   EXTRASAMPLE_UNASSALPHA, PHOTOMETRIC_MINISBLACK },
-  [GDK_MEMORY_G8]                               = { GDK_MEMORY_G8,                                8, 1, SAMPLEFORMAT_UINT,   -1,                     PHOTOMETRIC_MINISBLACK },
+  [GDK_MEMORY_G8]                               = { GDK_MEMORY_G8,                                8, 1, SAMPLEFORMAT_UINT,   0,                      PHOTOMETRIC_MINISBLACK },
   [GDK_MEMORY_G16A16_PREMULTIPLIED]             = { GDK_MEMORY_G16A16_PREMULTIPLIED,             16, 2, SAMPLEFORMAT_UINT,   EXTRASAMPLE_ASSOCALPHA, PHOTOMETRIC_MINISBLACK },
   [GDK_MEMORY_G16A16]                           = { GDK_MEMORY_G16A16,                           16, 2, SAMPLEFORMAT_UINT,   EXTRASAMPLE_UNASSALPHA, PHOTOMETRIC_MINISBLACK },
-  [GDK_MEMORY_G16]                              = { GDK_MEMORY_G16,                              16, 1, SAMPLEFORMAT_UINT,   -1,                     PHOTOMETRIC_MINISBLACK },
+  [GDK_MEMORY_G16]                              = { GDK_MEMORY_G16,                              16, 1, SAMPLEFORMAT_UINT,   0,                      PHOTOMETRIC_MINISBLACK },
   [GDK_MEMORY_A8]                               = { GDK_MEMORY_G8A8,                              8, 2, SAMPLEFORMAT_UINT,   EXTRASAMPLE_UNASSALPHA, PHOTOMETRIC_MINISBLACK },
   [GDK_MEMORY_A16]                              = { GDK_MEMORY_G16A16,                           16, 2, SAMPLEFORMAT_UINT,   EXTRASAMPLE_UNASSALPHA, PHOTOMETRIC_MINISBLACK },
   [GDK_MEMORY_A16_FLOAT]                        = { GDK_MEMORY_R16G16B16A16_FLOAT,               16, 4, SAMPLEFORMAT_IEEEFP, EXTRASAMPLE_ASSOCALPHA, PHOTOMETRIC_RGB },
@@ -302,7 +302,7 @@ gdk_save_tiff (GdkTexture *texture)
   TIFFSetField (tif, TIFFTAG_SAMPLEFORMAT, fdata->sample_format);
   TIFFSetField (tif, TIFFTAG_ORIENTATION, ORIENTATION_TOPLEFT);
   TIFFSetField (tif, TIFFTAG_COMPRESSION, COMPRESSION_NONE);
-  if (fdata->alpha_samples >= 0)
+  if (fdata->alpha_samples)
     TIFFSetField (tif, TIFFTAG_EXTRASAMPLES, 1, &fdata->alpha_samples);
 
   TIFFSetField (tif, TIFFTAG_PHOTOMETRIC, fdata->photometric);
@@ -384,7 +384,7 @@ gdk_load_tiff (GBytes  *input_bytes,
   guint16 sample_format;
   guint16 orientation;
   guint32 width, height;
-  gint16 alpha_samples;
+  guint16 alpha_samples;
   GdkMemoryFormat format;
   guchar *data, *line;
   gsize stride;
@@ -421,9 +421,9 @@ gdk_load_tiff (GBytes  *input_bytes,
       if (TIFFGetField (tif, TIFFTAG_EXTRASAMPLES, &extra, &extra_types))
         alpha_samples = extra_types[0];
       else
-        alpha_samples = -1;
+        alpha_samples = 0;
 
-      if (alpha_samples >= 0 && alpha_samples != EXTRASAMPLE_ASSOCALPHA && alpha_samples != EXTRASAMPLE_UNASSALPHA && alpha_samples != 0)
+      if (alpha_samples != 0 && alpha_samples != EXTRASAMPLE_ASSOCALPHA && alpha_samples != EXTRASAMPLE_UNASSALPHA)
         {
           texture = load_fallback (tif, error);
           TIFFClose (tif);
@@ -431,7 +431,7 @@ gdk_load_tiff (GBytes  *input_bytes,
         }
     }
   else
-    alpha_samples = -1;
+    alpha_samples = 0;
 
   for (format = 0; format < G_N_ELEMENTS (format_data); format++)
     {

gdk/macos/GdkMacosWindow.c

@@ -250,7 +250,8 @@ typedef NSString *CALayerContentsGravity;
 
 -(BOOL)canBecomeKeyWindow
 {
-  return GDK_IS_TOPLEVEL (gdk_surface);
+  return GDK_IS_TOPLEVEL (gdk_surface) ||
+         (GDK_IS_POPUP (gdk_surface) && GDK_SURFACE (gdk_surface)->input_region != NULL);
 }
 
 -(void)showAndMakeKey:(BOOL)makeKey
@@ -691,9 +692,24 @@ typedef NSString *CALayerContentsGravity;
 
 -(void)setStyleMask:(NSWindowStyleMask)styleMask
 {
+  gboolean was_opaque;
+  gboolean is_opaque;
+
+  was_opaque = (([self styleMask] & NSWindowStyleMaskTitled) != 0);
+
   [super setStyleMask:styleMask];
 
+  is_opaque = (([self styleMask] & NSWindowStyleMaskTitled) != 0);
+
   _gdk_macos_surface_update_fullscreen_state (gdk_surface);
+
+  if (was_opaque != is_opaque)
+    {
+      [self setOpaque:is_opaque];
+
+      if (!is_opaque)
+        [self setBackgroundColor:[NSColor clearColor]];
+    }
 }
 
 -(NSRect)constrainFrameRect:(NSRect)frameRect toScreen:(NSScreen *)screen
@@ -769,20 +785,13 @@ typedef NSString *CALayerContentsGravity;
 
   if (decorated)
     {
-      style_mask &= ~NSWindowStyleMaskFullSizeContentView;
-      [self setTitleVisibility:NSWindowTitleVisible];
+      style_mask |= NSWindowStyleMaskTitled;
     }
   else
     {
-      style_mask |= NSWindowStyleMaskFullSizeContentView;
-      [self setTitleVisibility:NSWindowTitleHidden];
+      style_mask &= ~NSWindowStyleMaskTitled;
     }
 
-  [self setTitlebarAppearsTransparent:!decorated];
-  [[self standardWindowButton:NSWindowCloseButton] setHidden:!decorated];
-  [[self standardWindowButton:NSWindowMiniaturizeButton] setHidden:!decorated];
-  [[self standardWindowButton:NSWindowZoomButton] setHidden:!decorated];
-
   [self setStyleMask:style_mask];
 }
 

gdk/macos/gdkmacoscairocontext.c

@@ -107,13 +107,32 @@ _gdk_macos_cairo_context_cairo_create (GdkCairoContext *cairo_context)
       cairo_clip (cr);
     }
 
+  /* If we have some exposed transparent area in the damage region,
+   * we need to clear the existing content first to leave an transparent
+   * area for cairo. We use (surface_bounds or damage)-(opaque) to get
+   * the smallest set of rectangles we need to clear as it's expensive.
+   */
   if (!opaque)
     {
+      cairo_region_t *transparent;
+      cairo_rectangle_int_t r = { 0, 0, width/scale, height/scale };
+
       cairo_save (cr);
 
-      cairo_set_operator (cr, CAIRO_OPERATOR_CLEAR);
-      cairo_paint (cr);
+      if (damage != NULL)
+        cairo_region_get_extents (damage, &r);
+      transparent = cairo_region_create_rectangle (&r);
+      if (surface->opaque_region)
+        cairo_region_subtract (transparent, surface->opaque_region);
 
+      if (!cairo_region_is_empty (transparent))
+        {
+          gdk_cairo_region (cr, transparent);
+          cairo_set_operator (cr, CAIRO_OPERATOR_CLEAR);
+          cairo_fill (cr);
+        }
+
+      cairo_region_destroy (transparent);
       cairo_restore (cr);
     }
 

gdk/macos/gdkmacosdragsurface.c

@@ -101,8 +101,6 @@ _gdk_macos_drag_surface_constructed (GObject *object)
   [window setOpaque:NO];
   [window setBackgroundColor:[NSColor clearColor]];
   [window setDecorated:NO];
-  [window setLevel:NSStatusWindowLevel];
-  [window setIgnoresMouseEvents:YES];
 
   frame_clock = _gdk_frame_clock_idle_new ();
   gdk_surface_set_frame_clock (surface, frame_clock);

gdk/macos/gdkmacosglcontext.c

@@ -242,7 +242,7 @@ gdk_macos_gl_context_allocate (GdkMacosGLContext *self)
     return;
 
   /* Alter to an opaque surface if necessary */
-  opaque = gdk_surface_is_opaque (surface);
+  opaque = _gdk_macos_surface_is_opaque (GDK_MACOS_SURFACE (surface));
   if (opaque != self->last_opaque)
     {
       self->last_opaque = !!opaque;

gdk/macos/gdkmacossurface-private.h

@@ -86,6 +86,7 @@ CGDirectDisplayID  _gdk_macos_surface_get_screen_id           (GdkMacosSurface
 const char        *_gdk_macos_surface_get_title               (GdkMacosSurface      *self);
 void               _gdk_macos_surface_set_title               (GdkMacosSurface      *self,
                                                                const char           *title);
+gboolean           _gdk_macos_surface_is_opaque               (GdkMacosSurface      *self);
 NSView            *_gdk_macos_surface_get_view                (GdkMacosSurface      *self);
 gboolean           _gdk_macos_surface_get_modal_hint          (GdkMacosSurface      *self);
 void               _gdk_macos_surface_set_modal_hint          (GdkMacosSurface      *self,

gdk/macos/gdkmacossurface.c

@@ -533,7 +533,7 @@ gdk_macos_surface_class_init (GdkMacosSurfaceClass *klass)
   surface_class->set_opaque_region = gdk_macos_surface_set_opaque_region;
 
   /**
-   * GdkMacosSurface:native:
+   * GdkMacosSurface:native: (attributes org.gtk.Property.get=gdk_macos_surface_get_native_window)
    *
    * The "native" property contains the underlying NSWindow.
    */
@@ -553,6 +553,29 @@ gdk_macos_surface_init (GdkMacosSurface *self)
   self->monitors = g_ptr_array_new_with_free_func (g_object_unref);
 }
 
+gboolean
+_gdk_macos_surface_is_opaque (GdkMacosSurface *self)
+{
+  GdkSurface *surface = (GdkSurface *)self;
+
+  g_return_val_if_fail (GDK_IS_MACOS_SURFACE (self), FALSE);
+
+  if (surface->opaque_region != NULL &&
+      cairo_region_num_rectangles (surface->opaque_region) == 1)
+    {
+      cairo_rectangle_int_t extents;
+
+      cairo_region_get_extents (surface->opaque_region, &extents);
+
+      return (extents.x == 0 &&
+              extents.y == 0 &&
+              extents.width == GDK_SURFACE (self)->width &&
+              extents.height == GDK_SURFACE (self)->height);
+    }
+
+  return FALSE;
+}
+
 const char *
 _gdk_macos_surface_get_title (GdkMacosSurface *self)
 {
@@ -613,7 +636,7 @@ _gdk_macos_surface_set_native (GdkMacosSurface *self,
 }
 
 /**
- * gdk_macos_surface_get_native_window:
+ * gdk_macos_surface_get_native_window: (attributes org.gtk.Method.get_property=native)
  * @self: a #GdkMacosSurface
  *
  * Gets the underlying NSWindow used by the surface.

gdk/macos/gdkmacostoplevelsurface.c

@@ -617,14 +617,6 @@ _gdk_macos_toplevel_surface_constructed (GObject *object)
 
   _gdk_macos_surface_set_native (GDK_MACOS_SURFACE (self), window);
 
-  [window setOpaque:NO];
-
-  /* Workaround: if we use full transparency, window rendering becomes slow,
-   * because macOS tries to dynamically calculate the shadow.
-   * Instead provide a tiny bit of alpha, so shadows are drawn around the window.
-   */
-  [window setBackgroundColor:[[NSColor blackColor] colorWithAlphaComponent:0.00001]];
-
   /* Allow NSWindow to go fullscreen */
   [window setCollectionBehavior:NSWindowCollectionBehaviorFullScreenPrimary];
 

gdk/meson.build

@@ -52,24 +52,23 @@ gdk_public_sources = files([
   'gdkmonitor.c',
   'gdkpaintable.c',
   'gdkpango.c',
-  'gdkparalleltask.c',
   'gdkpipeiostream.c',
-  'gdkpopup.c',
-  'gdkpopuplayout.c',
-  'gdkprofiler.c',
   'gdkrectangle.c',
   'gdkrgba.c',
   'gdkseat.c',
   'gdkseatdefault.c',
   'gdksnapshot.c',
-  'gdksubsurface.c',
-  'gdksurface.c',
   'gdktexture.c',
   'gdktexturedownloader.c',
+  'gdkvulkancontext.c',
+  'gdksubsurface.c',
+  'gdksurface.c',
+  'gdkpopuplayout.c',
+  'gdkprofiler.c',
+  'gdkpopup.c',
   'gdktoplevellayout.c',
   'gdktoplevelsize.c',
   'gdktoplevel.c',
-  'gdkvulkancontext.c',
   'loaders/gdkpng.c',
   'loaders/gdktiff.c',
   'loaders/gdkjpeg.c',

gdk/wayland/gdkclipboard-wayland.c

@@ -110,12 +110,6 @@ gdk_wayland_clipboard_data_source_send (void                  *data,
                      source, mime_type, fd);
 
   mime_type = gdk_intern_mime_type (mime_type);
-  if (!mime_type)
-    {
-      close (fd);
-      return;
-    }
-
   stream = g_unix_output_stream_new (fd, TRUE);
 
   gdk_clipboard_write_async (GDK_CLIPBOARD (cb),

gdk/wayland/gdkdisplay-wayland.c

@@ -61,7 +61,6 @@
 #include <wayland/server-decoration-client-protocol.h>
 #include "linux-dmabuf-unstable-v1-client-protocol.h"
 #include "presentation-time-client-protocol.h"
-#include "xx-color-management-v4-client-protocol.h"
 
 #include "wm-button-layout-translation.h"
 
@@ -353,19 +352,19 @@ gdk_registry_handle_global (void               *data,
 
   GDK_DEBUG (MISC, "add global %u, interface %s, version %u", id, interface, version);
 
-  if (strcmp (interface, wl_compositor_interface.name) == 0)
+  if (strcmp (interface, "wl_compositor") == 0)
     {
       display_wayland->compositor =
         wl_registry_bind (display_wayland->wl_registry, id,
                           &wl_compositor_interface, MIN (version, 6));
     }
-  else if (strcmp (interface, wl_shm_interface.name) == 0)
+  else if (strcmp (interface, "wl_shm") == 0)
     {
       display_wayland->shm =
         wl_registry_bind (display_wayland->wl_registry, id, &wl_shm_interface, 1);
       wl_shm_add_listener (display_wayland->shm, &wl_shm_listener, display_wayland);
     }
-  else if (strcmp (interface, zwp_linux_dmabuf_v1_interface.name) == 0 && version >= 4)
+  else if (strcmp (interface, "zwp_linux_dmabuf_v1") == 0 && version >= 4)
     {
       struct zwp_linux_dmabuf_feedback_v1 *feedback;
 
@@ -377,23 +376,23 @@ gdk_registry_handle_global (void               *data,
                                                                       feedback);
       _gdk_wayland_display_async_roundtrip (display_wayland);
     }
-  else if (strcmp (interface, xdg_wm_base_interface.name) == 0)
+  else if (strcmp (interface, "xdg_wm_base") == 0)
     {
       display_wayland->xdg_wm_base_id = id;
       display_wayland->xdg_wm_base_version = version;
     }
-  else if (strcmp (interface, zxdg_shell_v6_interface.name) == 0)
+  else if (strcmp (interface, "zxdg_shell_v6") == 0)
     {
       display_wayland->zxdg_shell_v6_id = id;
     }
-  else if (strcmp (interface, xdg_wm_dialog_v1_interface.name) == 0)
+  else if (strcmp (interface, "xdg_wm_dialog_v1") == 0)
     {
       display_wayland->xdg_wm_dialog =
         wl_registry_bind (display_wayland->wl_registry, id,
                           &xdg_wm_dialog_v1_interface,
                           MIN (version, XDG_WM_DIALOG_VERSION));
     }
-  else if (strcmp (interface, gtk_shell1_interface.name) == 0)
+  else if (strcmp (interface, "gtk_shell1") == 0)
     {
       display_wayland->gtk_shell =
         wl_registry_bind (display_wayland->wl_registry, id,
@@ -401,7 +400,7 @@ gdk_registry_handle_global (void               *data,
                           MIN (version, GTK_SHELL1_VERSION));
       gdk_wayland_display_set_has_gtk_shell (display_wayland);
     }
-  else if (strcmp (interface, wl_output_interface.name) == 0)
+  else if (strcmp (interface, "wl_output") == 0)
     {
       output =
        wl_registry_bind (display_wayland->wl_registry, id, &wl_output_interface,
@@ -410,7 +409,7 @@ gdk_registry_handle_global (void               *data,
                                       MIN (version, OUTPUT_VERSION));
       _gdk_wayland_display_async_roundtrip (display_wayland);
     }
-  else if (strcmp (interface, wl_seat_interface.name) == 0)
+  else if (strcmp (interface, "wl_seat") == 0)
     {
       SeatAddedClosure *closure;
       static const char *required_device_manager_globals[] = {
@@ -426,67 +425,67 @@ gdk_registry_handle_global (void               *data,
       closure->version = version;
       postpone_on_globals_closure (display_wayland, &closure->base);
     }
-  else if (strcmp (interface, wl_data_device_manager_interface.name) == 0)
+  else if (strcmp (interface, "wl_data_device_manager") == 0)
     {
       display_wayland->data_device_manager =
         wl_registry_bind (display_wayland->wl_registry, id, &wl_data_device_manager_interface,
                           MIN (version, 3));
     }
-  else if (strcmp (interface, wl_subcompositor_interface.name) == 0)
+  else if (strcmp (interface, "wl_subcompositor") == 0)
     {
       display_wayland->subcompositor =
         wl_registry_bind (display_wayland->wl_registry, id, &wl_subcompositor_interface, 1);
     }
-  else if (strcmp (interface, zwp_pointer_gestures_v1_interface.name) == 0)
+  else if (strcmp (interface, "zwp_pointer_gestures_v1") == 0)
     {
       display_wayland->pointer_gestures =
         wl_registry_bind (display_wayland->wl_registry,
                           id, &zwp_pointer_gestures_v1_interface,
                           MIN (version, GDK_ZWP_POINTER_GESTURES_V1_VERSION));
     }
-  else if (strcmp (interface, zwp_primary_selection_device_manager_v1_interface.name) == 0)
+  else if (strcmp (interface, "zwp_primary_selection_device_manager_v1") == 0)
     {
       display_wayland->primary_selection_manager =
         wl_registry_bind(display_wayland->wl_registry, id,
                          &zwp_primary_selection_device_manager_v1_interface, 1);
     }
-  else if (strcmp (interface, zwp_tablet_manager_v2_interface.name) == 0)
+  else if (strcmp (interface, "zwp_tablet_manager_v2") == 0)
     {
       display_wayland->tablet_manager =
         wl_registry_bind(display_wayland->wl_registry, id,
                          &zwp_tablet_manager_v2_interface, 1);
     }
-  else if (strcmp (interface, zxdg_exporter_v1_interface.name) == 0)
+  else if (strcmp (interface, "zxdg_exporter_v1") == 0)
     {
       display_wayland->xdg_exporter =
         wl_registry_bind (display_wayland->wl_registry, id,
                           &zxdg_exporter_v1_interface, 1);
     }
-  else if (strcmp (interface, zxdg_exporter_v2_interface.name) == 0)
+  else if (strcmp (interface, "zxdg_exporter_v2") == 0)
     {
       display_wayland->xdg_exporter_v2 =
         wl_registry_bind (display_wayland->wl_registry, id,
                           &zxdg_exporter_v2_interface, 1);
     }
-  else if (strcmp (interface, zxdg_importer_v1_interface.name) == 0)
+  else if (strcmp (interface, "zxdg_importer_v1") == 0)
     {
       display_wayland->xdg_importer =
         wl_registry_bind (display_wayland->wl_registry, id,
                           &zxdg_importer_v1_interface, 1);
     }
-  else if (strcmp (interface, zxdg_importer_v2_interface.name) == 0)
+  else if (strcmp (interface, "zxdg_importer_v2") == 0)
     {
       display_wayland->xdg_importer_v2 =
         wl_registry_bind (display_wayland->wl_registry, id,
                           &zxdg_importer_v2_interface, 1);
     }
-  else if (strcmp (interface, zwp_keyboard_shortcuts_inhibit_manager_v1_interface.name) == 0)
+  else if (strcmp (interface, "zwp_keyboard_shortcuts_inhibit_manager_v1") == 0)
     {
       display_wayland->keyboard_shortcuts_inhibit =
         wl_registry_bind (display_wayland->wl_registry, id,
                           &zwp_keyboard_shortcuts_inhibit_manager_v1_interface, 1);
     }
-  else if (strcmp (interface, org_kde_kwin_server_decoration_manager_interface.name) == 0)
+  else if (strcmp (interface, "org_kde_kwin_server_decoration_manager") == 0)
     {
       display_wayland->server_decoration_manager =
         wl_registry_bind (display_wayland->wl_registry, id,
@@ -495,7 +494,7 @@ gdk_registry_handle_global (void               *data,
                                                            &server_decoration_listener,
                                                            display_wayland);
     }
-  else if (strcmp (interface, zxdg_output_manager_v1_interface.name) == 0)
+  else if (strcmp(interface, "zxdg_output_manager_v1") == 0)
     {
       display_wayland->xdg_output_manager =
         wl_registry_bind (display_wayland->wl_registry, id,
@@ -504,39 +503,38 @@ gdk_registry_handle_global (void               *data,
       gdk_wayland_display_init_xdg_output (display_wayland);
       _gdk_wayland_display_async_roundtrip (display_wayland);
     }
-  else if (strcmp (interface, zwp_idle_inhibit_manager_v1_interface.name) == 0)
+  else if (strcmp(interface, "zwp_idle_inhibit_manager_v1") == 0)
     {
       display_wayland->idle_inhibit_manager =
         wl_registry_bind (display_wayland->wl_registry, id,
                           &zwp_idle_inhibit_manager_v1_interface, 1);
     }
-  else if (strcmp (interface, xdg_activation_v1_interface.name) == 0)
+  else if (strcmp (interface, "xdg_activation_v1") == 0)
     {
       display_wayland->xdg_activation =
         wl_registry_bind (display_wayland->wl_registry, id,
                           &xdg_activation_v1_interface, 1);
     }
-  else if (strcmp (interface, wp_fractional_scale_manager_v1_interface.name) == 0)
+  else if (strcmp (interface, "wp_fractional_scale_manager_v1") == 0)
     {
       display_wayland->fractional_scale =
         wl_registry_bind (display_wayland->wl_registry, id,
                           &wp_fractional_scale_manager_v1_interface, 1);
     }
-  else if (strcmp (interface, wp_viewporter_interface.name) == 0)
+  else if (strcmp (interface, "wp_viewporter") == 0)
     {
       display_wayland->viewporter =
         wl_registry_bind (display_wayland->wl_registry, id,
                           &wp_viewporter_interface, 1);
     }
-  else if (strcmp (interface, wp_presentation_interface.name) == 0)
+  else if (strcmp (interface, "wp_presentation") == 0)
     {
       display_wayland->presentation =
         wl_registry_bind (display_wayland->wl_registry, id,
                           &wp_presentation_interface,
                           MIN (version, 1));
     }
-  else if (strcmp (interface, xx_color_manager_v4_interface.name) == 0 &&
-           gdk_has_feature (GDK_FEATURE_COLOR_MANAGEMENT))
+  else if (strcmp (interface, "xx_color_manager_v4") == 0)
     {
       display_wayland->color = gdk_wayland_color_new (display_wayland, registry, id, version);
     }
@@ -1130,9 +1128,6 @@ get_cursor_theme (GdkWaylandDisplay *display_wayland,
         return theme;
     }
 
-  if (strcmp (name, "default") != 0)
-    return get_cursor_theme (display_wayland, "default", size);
-
   /* This may fall back to builtin cursors */
   return wl_cursor_theme_create ("/usr/share/icons/default/cursors", size, display_wayland->shm);
 }
@@ -1219,7 +1214,7 @@ _gdk_wayland_display_load_cursor_theme (GdkWaylandDisplay *display_wayland)
   if (gdk_display_get_setting (GDK_DISPLAY (display_wayland), "gtk-cursor-theme-size", &v))
     size = g_value_get_int (&v);
   else
-    size = 24;
+    size = 32;
   g_value_unset (&v);
 
   g_value_init (&v, G_TYPE_STRING);
@@ -1753,7 +1748,7 @@ static TranslationEntry translations[] = {
   { FALSE, "org.gnome.desktop.interface", "gtk-theme", "gtk-theme-name" , G_TYPE_STRING, { .s = "Adwaita" } },
   { FALSE, "org.gnome.desktop.interface", "icon-theme", "gtk-icon-theme-name", G_TYPE_STRING, { .s = "gnome" } },
   { FALSE, "org.gnome.desktop.interface", "cursor-theme", "gtk-cursor-theme-name", G_TYPE_STRING, { .s = "Adwaita" } },
-  { FALSE, "org.gnome.desktop.interface", "cursor-size", "gtk-cursor-theme-size", G_TYPE_INT, { .i = 24 } },
+  { FALSE, "org.gnome.desktop.interface", "cursor-size", "gtk-cursor-theme-size", G_TYPE_INT, { .i = 32 } },
   { FALSE, "org.gnome.desktop.interface", "font-name", "gtk-font-name", G_TYPE_STRING, { .s = "Cantarell 11" } },
   { FALSE, "org.gnome.desktop.interface", "cursor-blink", "gtk-cursor-blink", G_TYPE_BOOLEAN,  { .b = TRUE } },
   { FALSE, "org.gnome.desktop.interface", "cursor-blink-time", "gtk-cursor-blink-time", G_TYPE_INT, { .i = 1200 } },
@@ -1947,8 +1942,7 @@ init_settings (GdkDisplay *display)
   GSettings *settings;
   int i;
 
-  if (gdk_should_use_portal () &&
-      !(gdk_display_get_debug_flags (display) & GDK_DEBUG_DEFAULT_SETTINGS))
+  if (gdk_should_use_portal ())
     {
       GVariant *ret;
       GError *error = NULL;
@@ -1997,7 +1991,6 @@ init_settings (GdkDisplay *display)
           g_debug ("Received no portal settings");
           g_clear_pointer (&iter, g_variant_iter_free);
           g_clear_pointer (&ret, g_variant_unref);
-          g_clear_object (&display_wayland->settings_portal);
 
           goto fallback;
         }