css parser: Small optimization

Avoid creating a GFile until it is needed.

.gitlab-ci.yml

@@ -459,7 +459,6 @@ reference:
     - mv _build/docs/reference/gdk/gdk4-wayland/ _reference/gdk4-wayland/
     - mv _build/docs/reference/gsk/gsk4/ _reference/gsk4/
     - mv _build/docs/reference/gtk/gtk4/ _reference/gtk4/
-    - mv _build/docs/reference/gtk/*.html _reference/gtk4/
     - mv _build/subprojects/pango/docs/Pango/ _reference/Pango/
     - mv _build/subprojects/pango/docs/PangoCairo/ _reference/PangoCairo/
     - mv _build/subprojects/pango/docs/PangoFc/ _reference/PangoFc/

.gitlab-ci/test-msys2.sh

@@ -35,11 +35,7 @@ pacman --noconfirm -S --needed \
     mingw-w64-$MSYS2_ARCH-python-gobject \
     mingw-w64-$MSYS2_ARCH-shaderc \
     mingw-w64-$MSYS2_ARCH-vulkan \
-    mingw-w64-$MSYS2_ARCH-vulkan-headers \
-    mingw-w64-$MSYS2_ARCH-libpng \
-    mingw-w64-$MSYS2_ARCH-libjpeg-turbo \
-    mingw-w64-$MSYS2_ARCH-libtiff \
-    mingw-w64-$MSYS2_ARCH-lcms2
+    mingw-w64-$MSYS2_ARCH-vulkan-headers
 
 mkdir -p _ccache
 export CCACHE_BASEDIR="$(pwd)"

NEWS

@@ -1,109 +1,6 @@
-Overview of Changes in 4.15.2, xx-xx-xxxx
+Overview of Changes in 4.15.1, xx-xx-xxxx
 =========================================
 
-* GtkFileChooserWidget:
- - Plug some memory leaks
- - Make Ctrl-Shift-N create a new folder
-
-* CSS:
- - Support color(), oklab(), etc (https://www.w3.org/TR/css-color-4/)
- - Support color-mix() (https://www.w3.org/TR/css-color-5/)
- - Support relative colors (https://www.w3.org/TR/css-color-5/)
-
-* Accessibility:
- - Avoid markup when reading labels
-
-* GSK:
- - Subset fonts when serializing node trees
-
-* Wayland:
- - Use xdg-dialog protocol for attached dialogs
-
-* Windows:
- - Build with UNICODE
-
-* Debugging:
- - Add GTK_DEBUG=css for warning about deprecated css syntax
-
-* Tools:
- - nodeparser: Add an extract command for data urls
-
-* Deprecations:
- - CSS Color functions shade(), lighter(), darker(), alpha(), mix()
-
-* Translation updates:
- Hebrew
-
-
-Overview of Changes in 4.15.1, 21-05-2024
-=========================================
-
-* GtkGraphicsOffload:
- - Don't crash without a child
-
-* GtkSpinner:
- - Don't animate when unmapped
-
-* CSS:
- - Support the :root selector
- - Support variables and custom properties (https://www.w3.org/TR/css-variables-1/)
- - Implement math functions (https://www.w3.org/TR/css-values-4/)
- - Support modern syntax and calc in rgb() and hsl()
-
-* Icontheme:
- - Make symbolic svg loading more efficient
- - Handle color-free symbolics more efficiently
-
-* Accessibility:
- - Make the gtk-demo sidebar search more accessible
- - Stop emitting focus events
- - Realize child contexts when necessary
-
-* GDK:
- - Support XDG_ACTIVATION_TOKEN
- - dmabuf: Be more defensive when importing unknown formats to GL
- - dmabuf: Use narrow range for YUV
- - vulkan: Recreate swapchains when necessary or beneficial
-
-* GSK:
- - Improve logging for GDK_DEBUG=offload
- - Improve logging for GSK_DEBUG=renderer
- - gpu: Warn about inefficient texture import
- - gpu: Handle tiny offscreens correctly
- - vulkan: Add profiler marks in various places
- - vulkan: Fix a problem with imported dmabufs showing up black
- - cairo: Speed up mask nodes, since we use them for symbolic icons
-
-* Wayland:
- - Use wl_compositor version 6
-
-* X11:
- - Implement a missing method
-
-* Build:
- - Fix many ubsan warnings
-
-* Debugging:
- - Show more texture details in the recorder
- - Use GTK_DEBUG=css to see CSS deprecations
-
-* macOS:
- - Fix problems with events handed back to the OS
- - Respect GDK_DEBUG=default-settings
- - Allow applictions to handle Dock > Quit
-
-* Deprecations:
- - Use of @name colors in CSS
-
-* Translation updates:
- Catalan
- Georgian
- Hungarian
- Korean
- Portuguese
- Turkish
-
-
 Overview of Changes in 4.15.0, 21-04-2024
 =========================================
 

demos/gtk-demo/colorspaces.c

@@ -1,86 +0,0 @@
-/* Color Spaces
- *
- * Demonstrates support for color spaces.
- *
- * The test images used here are taken from http://displaycal.net/icc-color-management-test/
- * and are licensed under the Creative Commons BY-SA 4.0 International License
- */
-
-#include <gtk/gtk.h>
-
-static GtkWidget *jpeg;
-static GtkWidget *png;
-static GtkWidget *tiff;
-static GtkWidget *noprofile;
-static GtkWidget *test1;
-static GtkWidget *test2;
-
-static void
-on_changed (GtkCheckButton *button,
-            gpointer        user_data)
-{
-  GdkTexture *texture;
-  const char *extension = NULL;
-  char *path;
-
-  if (!gtk_check_button_get_active (GTK_CHECK_BUTTON (button)))
-    return;
-
-  if (gtk_check_button_get_active (GTK_CHECK_BUTTON (jpeg)))
-    extension = ".jpg";
-  else if (gtk_check_button_get_active (GTK_CHECK_BUTTON (png)))
-    extension = ".png";
-  else if (gtk_check_button_get_active (GTK_CHECK_BUTTON (tiff)))
-    extension = ".tif";
-  else if (gtk_check_button_get_active (GTK_CHECK_BUTTON (noprofile)))
-    extension = "-expected-result-no-cm.png";
-
-  path = g_strconcat ("/colorspaces/sRGB_Gray", extension, NULL);
-  texture = gdk_texture_new_from_resource (path);
-  gtk_picture_set_paintable (GTK_PICTURE (test1), GDK_PAINTABLE (texture));
-  g_object_unref (texture);
-
-  path = g_strconcat ("/colorspaces/ICC-Rendering-Intent-Test", extension, NULL);
-  texture = gdk_texture_new_from_resource (path);
-  gtk_picture_set_paintable (GTK_PICTURE (test2), GDK_PAINTABLE (texture));
-  g_object_unref (texture);
-}
-
-GtkWidget*
-do_colorspaces (GtkWidget *do_widget)
-{
-  static GtkWidget *window;
-
-  if (!window)
-    {
-      GtkBuilder *builder;
-      GtkBuilderScope *scope;
-
-      scope = gtk_builder_cscope_new ();
-      gtk_builder_cscope_add_callback_symbol (GTK_BUILDER_CSCOPE (scope),
-                                              "on_changed", G_CALLBACK (on_changed));
-
-      builder = gtk_builder_new ();
-      gtk_builder_set_scope (builder, scope);
-      gtk_builder_add_from_resource (builder, "/colorspaces/colorspaces.ui", NULL);
-      window = GTK_WIDGET (gtk_builder_get_object (builder, "window"));
-      jpeg = GTK_WIDGET (gtk_builder_get_object (builder, "jpeg"));
-      png = GTK_WIDGET (gtk_builder_get_object (builder, "png"));
-      tiff = GTK_WIDGET (gtk_builder_get_object (builder, "tiff"));
-      noprofile = GTK_WIDGET (gtk_builder_get_object (builder, "noprofile"));
-      test1 = GTK_WIDGET (gtk_builder_get_object (builder, "test1"));
-      test2 = GTK_WIDGET (gtk_builder_get_object (builder, "test2"));
-      gtk_window_set_display (GTK_WINDOW (window),
-                              gtk_widget_get_display (do_widget));
-      g_object_add_weak_pointer (G_OBJECT (window), (gpointer *)&window);
-      g_object_unref (builder);
-      g_object_unref (scope);
-    }
-
-  if (!gtk_widget_get_visible (window))
-    gtk_window_present (GTK_WINDOW (window));
-  else
-    gtk_window_destroy (GTK_WINDOW (window));
-
-  return window;
-}

demos/gtk-demo/colorspaces.ui

@@ -1,94 +0,0 @@
-<interface>
-  <object class="GtkWindow" id="window">
-    <property name="default-width">660</property>
-    <property name="default-height">660</property>
-    <property name="resizable">false</property>
-    <property name="title">Color Profiles</property>
-    <child>
-      <object class="GtkScrolledWindow">
-        <child>
-          <object class="GtkBox">
-            <property name="orientation">vertical</property>
-            <property name="spacing">10</property>
-            <property name="margin-top">10</property>
-            <property name="margin-bottom">10</property>
-            <property name="margin-start">10</property>
-            <property name="margin-end">10</property>
-            <child>
-              <object class="GtkBox">
-                <property name="spacing">10</property>
-                <child>
-                  <object class="GtkLabel">
-                    <property name="label">File format:</property>
-                  </object>
-                </child>
-                <child>
-                  <object class="GtkCheckButton" id="jpeg">
-                    <property name="label">JPEG</property>
-                    <property name="active">1</property>
-                    <signal name="notify::active" handler="on_changed"/>
-                  </object>
-                </child>
-                <child>
-                  <object class="GtkCheckButton" id="png">
-                    <property name="label">PNG</property>
-                    <property name="group">jpeg</property>
-                    <signal name="notify::active" handler="on_changed"/>
-                  </object>
-                </child>
-                <child>
-                  <object class="GtkCheckButton" id="tiff">
-                    <property name="label">TIFF</property>
-                    <property name="group">png</property>
-                    <signal name="notify::active" handler="on_changed"/>
-                  </object>
-                </child>
-                <child>
-                  <object class="GtkCheckButton" id="noprofile">
-                    <property name="label">No profile</property>
-                    <property name="group">tiff</property>
-                    <signal name="notify::active" handler="on_changed"/>
-                  </object>
-                </child>
-              </object>
-            </child>
-            <child>
-              <object class="GtkLabel">
-                <property name="label">Test 1: Matrix-based profile</property>
-                <style>
-                  <class name="title-3"/>
-                </style>
-              </object>
-            </child>
-            <child>
-              <object class="GtkPicture" id="test1">
-                <property name="hexpand">1</property>
-                <property name="vexpand">1</property>
-                <property name="can-shrink">1</property>
-                <property name="keep-aspect-ratio">1</property>
-                <property name="file">resource:///colorprofiles/sRGB_Gray.jpg</property>
-              </object>
-            </child>
-            <child>
-              <object class="GtkLabel">
-                <property name="label">Test 2: Lookup table-based profile</property>
-                <style>
-                  <class name="title-3"/>
-                </style>
-              </object>
-            </child>
-            <child>
-              <object class="GtkPicture" id="test2">
-                <property name="hexpand">1</property>
-                <property name="vexpand">1</property>
-                <property name="can-shrink">1</property>
-                <property name="keep-aspect-ratio">1</property>
-                <property name="file">resource:///colorprofiles/ICC-Rendering-Intent-Test.jpg</property>
-              </object>
-            </child>
-          </object>
-        </child>
-      </object>
-    </child>
-  </object>
-</interface>

demos/gtk-demo/demo.gresource.xml

@@ -19,17 +19,6 @@
     <file>demoimage.c</file>
     <file>demoimage.h</file>
   </gresource>
-  <gresource prefix="/colorspaces">
-    <file>colorspaces.ui</file>
-    <file>sRGB_Gray.jpg</file>
-    <file>sRGB_Gray.png</file>
-    <file>sRGB_Gray.tif</file>
-    <file>sRGB_Gray-expected-result-no-cm.png</file>
-    <file>ICC-Rendering-Intent-Test.png</file>
-    <file>ICC-Rendering-Intent-Test.jpg</file>
-    <file>ICC-Rendering-Intent-Test.tif</file>
-    <file>ICC-Rendering-Intent-Test-expected-result-no-cm.png</file>
-  </gresource>
   <gresource prefix="/constraints_builder">
     <file>constraints_builder.ui</file>
   </gresource>
@@ -276,7 +265,6 @@
     <file>assistant.c</file>
     <file>builder.c</file>
     <file>clipboard.c</file>
-    <file>colorspaces.c</file>
     <file>combobox.c</file>
     <file>constraints.c</file>
     <file>constraints_interactive.c</file>

demos/gtk-demo/language-names.c

@@ -40,7 +40,7 @@ get_win32_all_locales_scripts (LPWSTR locale_w, DWORD flags, LPARAM param)
 {
   wchar_t *langname_w = NULL;
   wchar_t locale_abbrev_w[9];
-  gchar *langname, *locale_abbrev, *locale;
+  gchar *langname, *locale_abbrev, *locale, *p;
   gint i;
   const LCTYPE iso639_lctypes[] = { LOCALE_SISO639LANGNAME, LOCALE_SISO639LANGNAME2 };
   GHashTable *ht_scripts_langs = (GHashTable *) param;
@@ -59,6 +59,7 @@ get_win32_all_locales_scripts (LPWSTR locale_w, DWORD flags, LPARAM param)
   GetLocaleInfoEx (locale_w, LOCALE_SLOCALIZEDDISPLAYNAME, langname_w, langname_size);
   langname = g_utf16_to_utf8 (langname_w, -1, NULL, NULL, NULL);
   locale = g_utf16_to_utf8 (locale_w, -1, NULL, NULL, NULL);
+  p = strchr (locale, '-');
   lang = pango_language_from_string (locale);
   if (g_hash_table_lookup (ht_scripts_langs, lang) == NULL)
     g_hash_table_insert (ht_scripts_langs, lang, langname);

demos/gtk-demo/meson.build

@@ -5,7 +5,6 @@ demos = files([
   'assistant.c',
   'builder.c',
   'clipboard.c',
-  'colorspaces.c',
   'combobox.c',
   'constraints.c',
   'constraints_interactive.c',

demos/node-editor/node-format.md

@@ -117,27 +117,16 @@ should be aware that the allowed values are meant to be used on 3D transformatio
 so their naming might appear awkward. However, it is always possible to use the
 matrix3d() production to specify all 16 values individually.
 
-### color-state
-
-| property    | syntax           | default                | printed     |
-| ----------- | ---------------- | ---------------------- | ----------- |
-| bounds      | `<rect>`         | 50                     | always      |
-| color-state | `<ident>|<url>`  | srgb                   | always      |
-
-Creates a node like `gsk_color_state_node_new()` with the given properties.
-
 ### conic-gradient
 
-| property          | syntax            | default                | printed     |
-| ----------------- | ----------------- | ---------------------- | ----------- |
-| bounds            | `<rect>`          | 50                     | always      |
-| center            | `<point>`         | 25, 25                 | always      |
-| rotation          | `<number>`        | 0                      | always      |
-| color-state       | `<ident>`|`<url>` | srgb                   | non-default |
-| hue-interpolation | `<ident>`         | shorter                | non-default |
-| stops             | `<color-stop>`    | 0 #AF0, 1 #F0C         | always      |
+| property | syntax           | default                | printed     |
+| -------- | ---------------- | ---------------------- | ----------- |
+| bounds   | `<rect>`         | 50                     | always      |
+| center   | `<point>`        | 25, 25                 | always      |
+| rotation | `<number>`       | 0                      | always      |
+| stops    | `<color-stop>`   | 0 #AF0, 1 #F0C         | always      |
 
-Creates a node like `gsk_conic_gradient_node_new_in()` with the given properties.
+Creates a node like `gsk_conic_gradient_node_new()` with the given properties.
 
 ### cross-fade
 
@@ -203,16 +192,14 @@ Creates a node like `gsk_inset_shadow_node_new()` with the given properties.
 
 ### linear-gradient
 
-| property          | syntax            | default                | printed     |
-| ----------------- | ----------------- | ---------------------- | ----------- |
-| bounds            | `<rect>`          | 50                     | always      |
-| start             | `<point>`         | 0 0                    | always      |
-| end               | `<point>`         | 0 50                   | always      |
-| color-state       | `<ident>`|`<url>` | srgb                   | non-default |
-| hue-interpolation | `<ident>`         | shorter                | non-default |
-| stops             | `<color-stop>`    | 0 #AF0, 1 #F0C         | always      |
+| property | syntax           | default                | printed     |
+| -------- | ---------------- | ---------------------- | ----------- |
+| bounds   | `<rect>`         | 50                     | always      |
+| start    | `<point>`        | 0 0                    | always      |
+| end      | `<point>`        | 0 50                   | always      |
+| stops    | `<color-stop>`   | 0 #AF0, 1 #F0C         | always      |
 
-Creates a node like `gsk_linear_gradient_node_new_in()` with the given properties.
+Creates a node like `gsk_linear_gradient_node_new()` with the given properties.
 
 ### mask
 
@@ -248,17 +235,15 @@ Creates a node like `gsk_outset_shadow_node_new()` with the given properties.
 
 ### radial-gradient
 
-| property          | syntax            | default                | printed     |
-| ----------------- | ----------------- | ---------------------- | ----------- |
-| bounds            | `<rect>`          | 50                     | always      |
-| center            | `<point>`         | 25 25                  | always      |
-| hradius           | `<number>`        | 25                     | always      |
-| vradius           | `<number>`        | 25                     | always      |
-| start             | `<number>`        | 0                      | always      |
-| end               | `<number>`        | 1                      | always      |
-| color-state       | `<ident>`|`<url>` | srgb                   | non-default |
-| hue-interpolation | `<ident>`         | shorter                | non-default |
-| stops             | `<color-stop>`    | 0 #AF0, 1 #F0C         | always      |
+| property | syntax           | default                | printed     |
+| -------- | ---------------- | ---------------------- | ----------- |
+| bounds   | `<rect>`         | 50                     | always      |
+| center   | `<point>`        | 25 25                  | always      |
+| hradius  | `<number>`       | 25                     | always      |
+| vradius  | `<number>`       | 25                     | always      |
+| start    | `<number>`       | 0                      | always      |
+| end      | `<number>`       | 1                      | always      |
+| stops    | `<color-stop>`   | 0 #AF0, 1 #F0C         | always      |
 
 Creates a node like `gsk_radial_gradient_node_new()` with the given properties.
 
@@ -274,33 +259,29 @@ Creates a node like `gsk_repeat_node_new()` with the given properties.
 
 ### repeating-linear-gradient
 
-| property          | syntax            | default                | printed     |
-| ----------------- | ----------------- | ---------------------- | ----------- |
-| bounds            | `<rect>`          | 50                     | always      |
-| start             | `<point>`         | 0 0                    | always      |
-| end               | `<point>`         | 0 50                   | always      |
-| color-state       | `<ident>`|`<url>` | srgb                   | non-default |
-| hue-interpolation | `<ident>`         | shorter                | non-default |
-| stops             | `<color-stop>`    | 0 #AF0, 1 #F0C         | always      |
+| property | syntax           | default                | printed     |
+| -------- | ---------------- | ---------------------- | ----------- |
+| bounds   | `<rect>`         | 50                     | always      |
+| start    | `<point>`        | 0 0                    | always      |
+| end      | `<point>`        | 0 50                   | always      |
+| stops    | `<color-stop>`   | 0 #AF0, 1 #F0C         | always      |
 
-Creates a node like `gsk_repeating_linear_gradient_node_new_in()` with the given
+Creates a node like `gsk_repeating_linear_gradient_node_new()` with the given
 properties.
 
 ### repeating radial-gradient
 
-| property          | syntax            | default                | printed     |
-| ----------------- | ----------------- | ---------------------- | ----------- |
-| bounds            | `<rect>`          | 50                     | always      |
-| center            | `<point>`         | 25 25                  | always      |
-| hradius           | `<number>`        | 25                     | always      |
-| vradius           | `<number>`        | 25                     | always      |
-| start             | `<number>`        | 0                      | always      |
-| end               | `<number>`        | 1                      | always      |
-| color-state       | `<ident>`|`<url>` | srgb                   | non-default |
-| hue-interpolation | `<ident>`         | shorter                | non-default |
-| stops             | `<color-stop>`    | 0 #AF0, 1 #F0C         | always      |
+| property | syntax           | default                | printed     |
+| -------- | ---------------- | ---------------------- | ----------- |
+| bounds   | `<rect>`         | 50                     | always      |
+| center   | `<point>`        | 25 25                  | always      |
+| hradius  | `<number>`       | 25                     | always      |
+| vradius  | `<number>`       | 25                     | always      |
+| start    | `<number>`       | 0                      | always      |
+| end      | `<number>`       | 1                      | always      |
+| stops    | `<color-stop>`   | 0 #AF0, 1 #F0C         | always      |
 
-Creates a node like `gsk_repeating_radial_gradient_node_new_in()` with the given
+Creates a node like `gsk_repeating_radial_gradient_node_new()` with the given
 properties.
 
 ### rounded-clip

demos/widget-factory/widget-factory.css

@@ -6,10 +6,3 @@
 .toolbar {
   -gtk-icon-style: symbolic;
 }
-
-.gtk-gradient-color {
-  background: linear-gradient(to right, lime, red);
-}
-.gtk-gradient-monochrome {
-  background: linear-gradient(to right, black, white);
-}

demos/widget-factory/widget-factory.gresource.xml

@@ -117,9 +117,5 @@
     <file>portland-rose.jpg</file>
     <file>nyc.jpg</file>
     <file>beach.jpg</file>
-    <file>linear-gradient-color.png</file>
-    <file>linear-gradient-monochrome.png</file>
-    <file>srgb-gradient-color.png</file>
-    <file>srgb-gradient-monochrome.png</file>
   </gresource>
 </gresources>

demos/widget-factory/widget-factory.ui

@@ -1344,173 +1344,13 @@ Suspendisse feugiat quam quis dolor accumsan cursus.</property>
                             <child>
                               <object class="GtkNotebookPage">
                                 <property name="child">
-                                  <object class="GtkGrid">
-                                    <property name="hexpand">0</property>
-                                    <property name="row-spacing">6</property>
-                                    <property name="column-spacing">6</property>
-                                    <property name="margin-start">6</property>
-                                    <property name="margin-end">6</property>
-                                    <property name="margin-top">6</property>
-                                    <property name="margin-bottom">6</property>
-                                    <property name="row-homogeneous">1</property>
-                                    <property name="valign">start</property>
-                                    <child>
-                                      <object class="GtkLabel">
-                                        <property name="label" translatable="yes">color</property>
-                                        <style>
-                                          <class name="caption-heading"/>
-                                        </style>
-                                        <layout>
-                                          <property name="column">0</property>
-                                          <property name="row">0</property>
-                                          <property name="column-span">2</property>
-                                        </layout>
-                                      </object>
-                                    </child>
-                                    <child>
-                                      <object class="GtkLabel">
-                                        <property name="label">sRGB</property>
-                                        <layout>
-                                          <property name="column">0</property>
-                                          <property name="row">1</property>
-                                        </layout>
-                                      </object>
-                                    </child>
-                                    <child>
-                                      <object class="GtkPicture">
-                                        <property name="file">resource:///org/gtk/WidgetFactory4/srgb-gradient-color.png</property>
-                                        <property name="can-shrink">0</property>
-                                        <property name="keep-aspect-ratio">0</property>
-                                        <property name="hexpand">1</property>
-                                        <layout>
-                                          <property name="column">1</property>
-                                          <property name="row">1</property>
-                                        </layout>
-                                      </object>
-                                    </child>
-                                    <child>
-                                      <object class="GtkLabel">
-                                        <property name="label">GTK</property>
-                                        <layout>
-                                          <property name="column">0</property>
-                                          <property name="row">2</property>
-                                        </layout>
-                                      </object>
-                                    </child>
-                                    <child>
-                                      <object class="GtkPicture">
-                                        <property name="width-request">128</property>
-                                        <property name="keep-aspect-ratio">0</property>
-                                        <style>
-                                          <class name="gtk-gradient-color"/>
-                                        </style>
-                                        <layout>
-                                          <property name="column">1</property>
-                                          <property name="row">2</property>
-                                        </layout>
-                                      </object>
-                                    </child>
-                                    <child>
-                                      <object class="GtkLabel">
-                                        <property name="label">linear</property>
-                                        <layout>
-                                          <property name="column">0</property>
-                                          <property name="row">3</property>
-                                        </layout>
-                                      </object>
-                                    </child>
-                                    <child>
-                                      <object class="GtkPicture">
-                                        <property name="file">resource:///org/gtk/WidgetFactory4/linear-gradient-color.png</property>
-                                        <property name="can-shrink">0</property>
-                                        <property name="keep-aspect-ratio">0</property>
-                                        <layout>
-                                          <property name="column">1</property>
-                                          <property name="row">3</property>
-                                        </layout>
-                                      </object>
-                                    </child>
-                                    <child>
-                                      <object class="GtkLabel">
-                                        <property name="label" translatable="yes">monochrome</property>
-                                        <style>
-                                          <class name="caption-heading"/>
-                                        </style>
-                                        <layout>
-                                          <property name="column">0</property>
-                                          <property name="row">4</property>
-                                          <property name="column-span">2</property>
-                                        </layout>
-                                      </object>
-                                    </child>
-                                    <child>
-                                      <object class="GtkLabel">
-                                        <property name="label">sRGB</property>
-                                        <layout>
-                                          <property name="column">0</property>
-                                          <property name="row">5</property>
-                                        </layout>
-                                      </object>
-                                    </child>
-                                    <child>
-                                      <object class="GtkPicture">
-                                        <property name="file">resource:///org/gtk/WidgetFactory4/srgb-gradient-monochrome.png</property>
-                                        <property name="can-shrink">0</property>
-                                        <property name="keep-aspect-ratio">0</property>
-                                        <property name="hexpand">1</property>
-                                        <layout>
-                                          <property name="column">1</property>
-                                          <property name="row">5</property>
-                                        </layout>
-                                      </object>
-                                    </child>
-                                    <child>
-                                      <object class="GtkLabel">
-                                        <property name="label">GTK</property>
-                                        <layout>
-                                          <property name="column">0</property>
-                                          <property name="row">6</property>
-                                        </layout>
-                                      </object>
-                                    </child>
-                                    <child>
-                                      <object class="GtkPicture">
-                                        <property name="width-request">128</property>
-                                        <property name="keep-aspect-ratio">0</property>
-                                        <style>
-                                          <class name="gtk-gradient-monochrome"/>
-                                        </style>
-                                        <layout>
-                                          <property name="column">1</property>
-                                          <property name="row">6</property>
-                                        </layout>
-                                      </object>
-                                    </child>
-                                    <child>
-                                      <object class="GtkLabel">
-                                        <property name="label">linear</property>
-                                        <layout>
-                                          <property name="column">0</property>
-                                          <property name="row">7</property>
-                                        </layout>
-                                      </object>
-                                    </child>
-                                    <child>
-                                      <object class="GtkPicture">
-                                        <property name="file">resource:///org/gtk/WidgetFactory4/linear-gradient-monochrome.png</property>
-                                        <property name="can-shrink">0</property>
-                                        <property name="keep-aspect-ratio">0</property>
-                                        <layout>
-                                          <property name="column">1</property>
-                                          <property name="row">7</property>
-                                        </layout>
-                                      </object>
-                                    </child>
+                                  <object class="GtkBox" id="box8">
+                                    <property name="orientation">1</property>
                                   </object>
                                 </property>
                                 <property name="tab">
                                   <object class="GtkLabel" id="label8">
-                                    <property name="label" translatable="1">Gradients</property>
+                                    <property name="label" translatable="1">page 1</property>
                                   </object>
                                 </property>
                               </object>

docs/reference/gtk/css-properties.md

@@ -15,16 +15,16 @@ spec.
 The following units are supported for basic datatypes:
 
 Length
-: px, pt, em, ex, rem, pc, in, cm, mm
+: px, pt, em, ex, rem, pc, in, cm, mm, calc()
 
 Percentage
-: %
+: %, calc()
 
 Angle
-: deg, rad, grad, turn
+: deg, grad, turn, calc()
 
 Time
-: s, ms
+: s, ms, calc()
 
 Length values with the em or ex units are resolved using the font
 size value, unless they occur in setting the font-size itself, in
@@ -33,15 +33,11 @@ which case they are resolved using the inherited font size value.
 The rem unit is resolved using the initial font size value, which is
 not quite the same as the CSS definition of rem.
 
-Length values using physical units (pt, pc, in, cm, mm) are translated
-to px using the dpi value specified by the -gtk-dpi property, which is
-different from the CSS definition, which uses a fixed dpi of 96.
-
-The calc() notation adds considerable expressive power to all of these
-datatypes. There are limits on what types can be combined in such an
-expression (e.g. it does not make sense to add a number and a time).
-For the full details, see the
-[CSS Values and Units](https://www.w3.org/TR/css-values-4/) spec.
+The calc() notation adds considerable expressive power. There are limits
+on what types can be combined in such an expression (e.g. it does not make
+sense to add a number and a time). For the full details, see the
+[CSS3 Values and Units](https://www.w3.org/TR/css3-values/#calc-notation)
+spec.
 
 A common pattern among shorthand properties (called 'four sides') is one
 where one to four values can be specified, to determine a value for each
@@ -86,54 +82,36 @@ color: var(--prop, green);
 
 ## Colors
 
-### CSS Colors
-
-Colors can be expressed in numerous ways in CSS (see the
-[Color Module](https://www.w3.org/TR/css-color-5/). GTK supports
-many (but not all) of these.
-
-You can use rgb(), rgba(), hsl() with both the legacy or the modern CSS
-syntax, and calc() can be used as well in color expressions. hwb(), oklab(),
-oklch(), color(), color-mix() and relative colors are supported as well.
-
-### Non-CSS Colors
-
-GTK  extends the CSS syntax with several additional ways to specify colors.
-
-These extensions are deprecated and should be replaced by the equivalent
-standard CSS notions.
+GTK extends the CSS syntax with several additional ways to specify colors.
 
 The first is a reference to a color defined via a @define-color rule in CSS.
 The syntax for @define-color rules is as follows:
 
 ```
-@define-color name color
+@define-color Name Color
 ```
 
 To refer to the color defined by a @define-color rule, prefix the name with @.
 
-The standard CSS mechanisms that should be used instead of @define-color are
-custom properties, :root and var().
-
 GTK also supports color expressions, which allow colors to be transformed to
 new ones. Color expressions can be nested, providing a rich language to
 define colors. Color expressions resemble functions, taking 1 or more colors
 and in some cases a number as arguments.
 
-`lighter(color)`
- : produces a brighter variant of `color`.
+`lighter(Color)`
+ : produces a brighter variant of Color
 
-`darker(color)`
- : produces a darker variant of `color`.
+`darker(Color)`
+ : produces a darker variant of Color
 
-`shade(color, number)`
- : changes the lightness of `color`. The `number` ranges from 0 for black to 2 for white.
+`shade(Color, Number)`
+ : changes the lightness of Color. The number ranges from 0 for black to 2 for white.
 
-`alpha(color, number)`
- : multiplies the alpha value of `color` by `number` (between 0 and 1).
+`alpha(Color, Number)`
+ : replaces the alpha value of color with number (between 0 and 1)
 
-`mix(color1, color2, number)`
- : interpolates between the two colors.
+`mix(Color1, Color2, Number)`
+ : interpolates between the two colors
 
 ## Images
 
@@ -141,7 +119,7 @@ GTK extends the CSS syntax for images and also uses it for specifying icons.
 To load a themed icon, use
 
 ```
--gtk-icontheme(name)
+-gtk-icontheme(Name)
 ```
 
 The specified icon name is used to look up a themed icon, while taking into
@@ -170,14 +148,14 @@ and the
 syntax makes this available. -gtk-recolor requires a url as first argument.
 The remaining arguments specify the color palette to use. If the palette is
 not explicitly specified, the current value of the -gtk-icon-palette property
-is used.
+is used. 
 
 GTK supports scaled rendering on hi-resolution displays. This works best if
 images can specify normal and hi-resolution variants. From CSS, this can be
 done with
 
 ```
--gtk-scaled(image1, image2)
+-gtk-scaled(Image1, Image2)
 ```
 
 ## GTK CSS Properties

docs/reference/gtk/drawing-model.md

@@ -99,15 +99,16 @@ reaches the requested phase. However, in practice most things
 happen at higher levels:
 
 - If you are doing an animation, you can use
-  [method@Gtk.Widget.add_tick_callback] which will cause a regular
+  gtk_widget_add_tick_callback() which will cause a regular
   beating of the clock with a callback in the Update phase
   until you stop the tick.
 - If some state changes that causes the size of your widget to
-  change you call [method@Gtk.Widget.queue_resize] which will request
+  change you call gtk_widget_queue_resize() which will request
   a Layout phase and mark your widget as needing relayout.
-- If some state changes so you need to redraw your widget you
-  use [method@Gtk.Widget.queue_draw] to request a Paint phase for
-  your widget.
+- If some state changes so you need to redraw some area of
+  your widget you use the normal gtk_widget_queue_draw()
+  set of functions. These will request a Paint phase and
+  mark the region as needing redraw.
 
 There are also a lot of implicit triggers of these from the
 CSS layer (which does animations, resizes and repaints as needed).

docs/reference/gtk/gtk4-rendernode-tool.rst

@@ -18,7 +18,6 @@ SYNOPSIS
 |
 |   **gtk4-rendernode-tool** benchmark [OPTIONS...] <FILE>
 |   **gtk4-rendernode-tool** compare [OPTIONS...] <FILE1> <FILE2>
-|   **gtk4-rendernode-tool** extract [OPTIONS...] <FILE>
 |   **gtk4-rendernode-tool** info [OPTIONS...] <FILE>
 |   **gtk4-rendernode-tool** render [OPTIONS...] <FILE> [<FILE>]
 |   **gtk4-rendernode-tool** show [OPTIONS...] <FILE>
@@ -100,15 +99,3 @@ exit code is 1. If the images are identical, it is 0.
 ``--quiet``
 
   Don't write results to stdout.
-
-
-Extract
-^^^^^^^
-
-The ``extract`` command saves all the data urls found in a node file to a given
-directory. The file names for the extracted files are derived from the mimetype
-of the url.
-
-``--dir=DIRECTORY``
-
-  Save extracted files in ``DIRECTORY`` (defaults to the current directory).

docs/reference/gtk/gtk4.toml.in

@@ -77,13 +77,11 @@ content_files = [
   "section-tree-widget.md",
   "migrating-2to4.md",
   "migrating-3to4.md",
-  "migrating-4to5.md",
   "broadway.md",
   "osx.md",
   "wayland.md",
   "windows.md",
   "x11.md",
-  "tools.md",
   "visual_index.md",
 ]
 content_images = [

docs/reference/gtk/meson.build

@@ -14,7 +14,6 @@ expand_content_md_files = [
   'running.md',
   'migrating-2to4.md',
   'migrating-3to4.md',
-  'migrating-4to5.md',
   'actions.md',
   'input-handling.md',
   'drawing-model.md',
@@ -26,8 +25,7 @@ expand_content_md_files = [
   'section-tree-widget.md',
   'section-list-widget.md',
   'question_index.md',
-  'visual_index.md',
-  'tools.md',
+  'visual_index.md'
 ]
 
 gtk_images = []
@@ -62,39 +60,39 @@ if get_option('documentation')
     build_by_default: true,
     install: true,
     install_dir: docs_dir,
-    install_tag: 'doc',
   )
 endif
 
-rst2man = find_program('rst2man', 'rst2man.py', required: get_option('man-pages'))
-rst2html5 = find_program('rst2html5', 'rst2html5.py', required: get_option('documentation'))
-
-rst_files = [
-  [ 'gtk4-broadwayd', '1' ],
-  [ 'gtk4-builder-tool', '1' ],
-  [ 'gtk4-encode-symbolic-svg', '1', ],
-  [ 'gtk4-launch', '1', ],
-  [ 'gtk4-query-settings', '1', ],
-  [ 'gtk4-rendernode-tool', '1' ],
-  [ 'gtk4-update-icon-cache', '1', ],
-  [ 'gtk4-path-tool', '1', ],
-]
-
-if get_option('build-demos')
-  rst_files += [
-    [ 'gtk4-demo', '1', ],
-    [ 'gtk4-demo-application', '1', ],
-    [ 'gtk4-widget-factory', '1', ],
-    [ 'gtk4-icon-browser', '1', ],
-    [ 'gtk4-node-editor', '1', ],
-  ]
+rst2man = find_program('rst2man', 'rst2man.py', required: false)
+if get_option('man-pages') and not rst2man.found()
+  error('No rst2man found, but man pages were explicitly enabled')
 endif
 
-rst2x_flags = [
-  '--syntax-highlight=none',
-]
+if get_option('man-pages') and rst2man.found()
+  rst_files = [
+    [ 'gtk4-broadwayd', '1' ],
+    [ 'gtk4-builder-tool', '1' ],
+    [ 'gtk4-encode-symbolic-svg', '1', ],
+    [ 'gtk4-launch', '1', ],
+    [ 'gtk4-query-settings', '1', ],
+    [ 'gtk4-rendernode-tool', '1' ],
+    [ 'gtk4-update-icon-cache', '1', ],
+    [ 'gtk4-path-tool', '1', ],
+  ]
 
-if get_option('man-pages')
+  if get_option('build-demos')
+    rst_files += [
+      [ 'gtk4-demo', '1', ],
+      [ 'gtk4-demo-application', '1', ],
+      [ 'gtk4-widget-factory', '1', ],
+      [ 'gtk4-icon-browser', '1', ],
+      [ 'gtk4-node-editor', '1', ],
+    ]
+  endif
+
+  rst2man_flags = [
+    '--syntax-highlight=none',
+  ]
 
   foreach rst: rst_files
     man_name = rst[0]
@@ -105,34 +103,12 @@ if get_option('man-pages')
       output: '@0@.@1@'.format(man_name, man_section),
       command: [
         rst2man,
-        rst2x_flags,
+        rst2man_flags,
         '@INPUT@',
       ],
       capture: true,
       install: true,
       install_dir: get_option('mandir') / 'man@0@'.format(man_section),
-      install_tag: 'doc',
-    )
-  endforeach
-endif
-
-if get_option('documentation')
-
-  foreach rst: rst_files
-    man_name = rst[0]
-
-    custom_target(
-      input: '@0@.rst'.format(man_name),
-      output: '@0@.html'.format(man_name),
-      command: [
-        rst2html5,
-        rst2x_flags,
-        '@INPUT@',
-      ],
-      capture: true,
-      install: true,
-      install_dir: docs_dir / 'gtk4',
-      install_tag: 'doc',
     )
   endforeach
 endif

docs/reference/gtk/migrating-4to5.md

@@ -58,7 +58,7 @@ use a GtkLabel.
 If you have a need for custom drawing that fits into the current
 (dark or light) theme, e.g. for rendering a graph, you can still
 get the current style foreground color, using
-[method@Gtk.Widget.get_color].
+[method@Gtk.Widget.get_style_color].
 
 ## Local stylesheets are going away
 
@@ -73,103 +73,6 @@ GTK 5 will no longer provide this functionality. The recommendations
 is to use a global stylesheet (i.e. gtk_style_context_add_provider_for_display())
 and rely on style classes to make your CSS apply only where desired.
 
-## Non-standard CSS extensions are going away
-
-GTK's CSS machinery has a some non-standard extensions around colors:
-named colors with \@define-color and color functions: lighter(), darker(),
-shade(), alpha(), mix().
-
-GTK now implements equivalent functionality from the CSS specs.
-
-### \@define-color is going away
-
-\@define-color should be replaced by custom properties in the :root scope.
-
-Instead of
-
-```
-@define-color fg_color #2e3436
-
-...
-
-box {
-  color: @fg_color;
-}
-```
-
-use
-
-```
-:root {
-  --fg-color: #2e3436;
-}
-
-...
-
-box {
-  color: var(--fg-color);
-}
-```
-
-For more information about custom CSS properties and variables, see the
-[CSS Custom Properties for Cascading Variables](https://www.w3.org/TR/css-variables-1/)
-spec.
-
-### Color expressions are going away
-
-The color functions can all be replaced by combinations of calc() and color-mix().
-
-ligher(c) and darker(c) are just shade(c, 1.3) or shade(c, 0.7), respectively, and
-thus can be handled the same way as shade in the examples below.
-
-Replace
-
-```
-a {
-  color: mix(red, green, 0.8);
-}
-
-b {
-  color: alpha(green, 0.6);
-}
-
-c {
-  color: shade(red, 1.3);
-}
-
-d {
-  color: shade(red, 0.7);
-}
-```
-
-with
-
-```
-a {
-  color: color-mix(in srgb, red, green 80%);
-}
-
-b {
-  color: rgb(from green, r g b / calc(alpha * 0.6));
-}
-
-c {
-  color: hsl(from red, h calc(s * 1.3) calc(l * 1.3));
-}
-
-d {
-  color: hsl(from red, h calc(s * 0.7) calc(l * 0.7));
-}
-```
-
-Variations of these replacements are possible.
-
-Note that GTK has historically computed mix() and shade() values in the SRGB and HSL
-colorspaces, but using OKLAB instead might yield slightly better results.
-
-For more information about color-mix(), see the
-[CSS Color](https://drafts.csswg.org/css-color-5) spec.
-
 ## Chooser interfaces are going away
 
 The GtkColorChooser, GtkFontChooser, GtkFileChooser and GtkAppChooser

docs/reference/gtk/overview.md

@@ -64,6 +64,6 @@ GTK is divided into three parts:
 [cairo]: https://www.cairographics.org/manual/
 [opengl]: https://www.opengl.org/about/
 [vulkan]: https://www.vulkan.org/
-[pango]: https://docs.gtk.org/Pango/
+[pango]: https://docs.gtk.org/pango/
 [gdkpixbuf]: https://docs.gtk.org/gdk-pixbuf/
 [graphene]: https://ebassi.github.io/graphene/

docs/reference/gtk/tools.md

@@ -1,18 +0,0 @@
-Title: Tools and Demos
-
-GTK ships with a number of tools and demos that come with their own
-documentation in the form of man pages.
-
- - [gtk4-broadwayd](gtk4-broadwayd.html)
- - [gtk4-builder-tool](gtk4-builder-tool.html)
- - [gtk4-demo](gtk4-demo.html)
- - [gtk4-demo-application](gtk4-demo-application.html)
- - [gtk4-encode-symbolic-svg](gtk4-encode-symbolic-svg.html)
- - [gtk4-icon-browser](gtk4-icon-browser.html)
- - [gtk4-launch](gtk4-launch.html)
- - [gtk4-node-editor](gtk4-node-editor.html)
- - [gtk4-path-tool](gtk4-path-tool.html)
- - [gtk4-query-settings](gtk4-query-settings.html)
- - [gtk4-rendernode-tool](gtk4-rendernode-tool.html)
- - [gtk4-update-icon-cache](gtk4-update-icon-cache.html)
- - [gtk4-widget-factory](gtk4-widget-factory.html)

gdk/broadway/gdkcairocontext-broadway.c

@@ -46,10 +46,9 @@ gdk_broadway_cairo_context_begin_frame (GdkDrawContext *draw_context,
   width = gdk_surface_get_width (surface);
   height = gdk_surface_get_height (surface);
   scale = gdk_surface_get_scale_factor (surface);
-
-  self->paint_surface = gdk_surface_create_similar_surface (surface,
-                                                            CAIRO_CONTENT_COLOR_ALPHA,
-                                                            width * scale, height *scale);
+  self->paint_surface = cairo_image_surface_create (CAIRO_FORMAT_ARGB32,
+                                                    width * scale, height * scale);
+  cairo_surface_set_device_scale (self->paint_surface, scale, scale);
 
   repaint_region = cairo_region_create_rectangle (&(cairo_rectangle_int_t) { 0, 0, width, height });
   cairo_region_union (region, repaint_region);

gdk/gdk.c

@@ -19,7 +19,7 @@
  * Modified by the GTK+ Team and others 1997-2000.  See the AUTHORS
  * file for a list of people on the GTK+ Team.  See the ChangeLog
  * files for a list of changes.  These files are distributed with
- * GTK+ at ftp://ftp.gtk.org/pub/gtk/.
+ * GTK+ at ftp://ftp.gtk.org/pub/gtk/. 
  */
 
 #include "config.h"
@@ -138,7 +138,6 @@ static const GdkDebugKey gdk_debug_keys[] = {
   { "high-depth",      GDK_DEBUG_HIGH_DEPTH, "Use high bit depth rendering if possible" },
   { "no-vsync",        GDK_DEBUG_NO_VSYNC, "Repaint instantly (uses 100% CPU with animations)" },
   { "dmabuf-disable",  GDK_DEBUG_DMABUF_DISABLE, "Disable dmabuf support" },
-  { "srgb",            GDK_DEBUG_SRGB, "Force sRRGB rendering and turn off color profiles" },
 };
 
 

gdk/gdk.h

@@ -30,8 +30,6 @@
 #include <gdk/gdkcairo.h>
 #include <gdk/gdkcairocontext.h>
 #include <gdk/gdkclipboard.h>
-#include <gdk/gdkcolor.h>
-#include <gdk/gdkcolorstate.h>
 #include <gdk/gdkconfig.h>
 #include <gdk/gdkcontentdeserializer.h>
 #include <gdk/gdkcontentformats.h>

gdk/gdkarrayimpl.c

@@ -41,10 +41,8 @@ G_BEGIN_DECLS
 
 #ifdef GDK_ARRAY_NULL_TERMINATED
 #define GDK_ARRAY_REAL_SIZE(_size) ((_size) + 1)
-#define GDK_ARRAY_MAX_SIZE (G_MAXSIZE / sizeof (_T_) - 1)
 #else
 #define GDK_ARRAY_REAL_SIZE(_size) (_size)
-#define GDK_ARRAY_MAX_SIZE (G_MAXSIZE / sizeof (_T_))
 #endif
 
 /* make this readable */
@@ -179,23 +177,18 @@ G_GNUC_UNUSED static inline void
 gdk_array(reserve) (GdkArray *self,
                     gsize      n)
 {
-  gsize new_capacity, size, capacity;
+  gsize new_size, size;
 
-  if (G_UNLIKELY (n > GDK_ARRAY_MAX_SIZE))
-    g_error ("requesting array size of %zu, but maximum size is %zu", n, GDK_ARRAY_MAX_SIZE);
-
-  capacity = gdk_array(get_capacity) (self);
-  if (n <= capacity)
-     return;
+  if (n <= gdk_array(get_capacity) (self))
+    return;
 
   size = gdk_array(get_size) (self);
-  /* capacity * 2 can overflow, that's why we MAX() */
-  new_capacity = MAX (GDK_ARRAY_REAL_SIZE (n), capacity * 2);
+  new_size = ((gsize) 1) << g_bit_storage (MAX (GDK_ARRAY_REAL_SIZE (n), 16) - 1);
 
 #ifdef GDK_ARRAY_PREALLOC
   if (self->start == self->preallocated)
     {
-      self->start = g_new (_T_, new_capacity);
+      self->start = g_new (_T_, new_size);
       memcpy (self->start, self->preallocated, sizeof (_T_) * GDK_ARRAY_REAL_SIZE (size));
     }
   else
@@ -203,15 +196,15 @@ gdk_array(reserve) (GdkArray *self,
 #ifdef GDK_ARRAY_NULL_TERMINATED
   if (self->start == NULL)
     {
-      self->start = g_new (_T_, new_capacity);
+      self->start = g_new (_T_, new_size);
       *self->start = *(_T_[1]) { 0 };
     }
   else
 #endif
-    self->start = g_renew (_T_, self->start, new_capacity);
+    self->start = g_renew (_T_, self->start, new_size);
 
   self->end = self->start + size;
-  self->end_allocation = self->start + new_capacity;
+  self->end_allocation = self->start + new_size;
 #ifdef GDK_ARRAY_NULL_TERMINATED
   self->end_allocation--;
 #endif
@@ -319,7 +312,6 @@ gdk_array(get) (const GdkArray *self,
 #undef gdk_array_paste
 #undef gdk_array
 #undef GDK_ARRAY_REAL_SIZE
-#undef GDK_ARRAY_MAX_SIZE
 
 #undef GDK_ARRAY_BY_VALUE
 #undef GDK_ARRAY_ELEMENT_TYPE

gdk/gdkcairo.c

@@ -20,11 +20,7 @@
 #include "gdkcairo.h"
 
 #include "gdkrgba.h"
-#include "gdkcolor.h"
 #include "gdktexture.h"
-#include "gdkcolorstate.h"
-#include "gdkcolorprivate.h"
-#include "gdkmemoryformatprivate.h"
 
 #include <math.h>
 
@@ -39,47 +35,14 @@ void
 gdk_cairo_set_source_rgba (cairo_t       *cr,
                            const GdkRGBA *rgba)
 {
-  GdkColor color;
-  const float *components;
-
   g_return_if_fail (cr != NULL);
   g_return_if_fail (rgba != NULL);
 
-  gdk_color_convert_rgba (&color, gdk_cairo_get_color_state (cr), rgba);
-  components = gdk_color_get_components (&color);
   cairo_set_source_rgba (cr,
-                         components[0],
-                         components[1],
-                         components[2],
-                         components[3]);
-}
-
-/**
- * gdk_cairo_set_source_color:
- * @cr: a cairo contet
- * @rgba: a `GdkColor`
- *
- * Sets the specified `GdkColor` as the source color of @cr.
- *
- * Since: 4.16
- */
-void
-gdk_cairo_set_source_color (cairo_t        *cr,
-                            const GdkColor *color)
-{
-  GdkColor c;
-  const float *components;
-
-  g_return_if_fail (cr != NULL);
-  g_return_if_fail (color != NULL);
-
-  gdk_color_convert (&c, gdk_cairo_get_color_state (cr), color);
-  components = gdk_color_get_components (&c);
-  cairo_set_source_rgba (cr,
-                         components[0],
-                         components[1],
-                         components[2],
-                         components[3]);
+                         rgba->red,
+                         rgba->green,
+                         rgba->blue,
+                         rgba->alpha);
 }
 
 /**
@@ -340,98 +303,3 @@ gdk_cairo_region_create_from_surface (cairo_surface_t *surface)
 
   return region;
 }
-
-static cairo_user_data_key_t color_state_key;
-
-/**
- * gdk_cairo_surface_set_color_state:
- * @surface: a surface
- * @color_state: the color state to attach to the surface
- *
- * Attaches a `GdkColorState` to the Cairo surface.
- *
- * This is just auxiliary data for use by GTK, no Cairo functions
- * do interact with this information.
- *
- * Note that all Cairo compositing operations are assumed to happen
- * in a linear RGB color state, so if you want to use the surface
- * as a target for rendering in a color managed way, you should use
- * such a color state.
- *
- * The default color state is assumed to be sRGB, which is not
- * linear.
- *
- * Since: 4.16
- */
-void
-gdk_cairo_surface_set_color_state (cairo_surface_t *surface,
-                                   GdkColorState   *color_state)
-{
-  g_return_if_fail (surface != NULL);
-  g_return_if_fail (color_state != NULL);
-
-  cairo_surface_set_user_data (surface,
-                               &color_state_key,
-                               gdk_color_state_ref (color_state),
-                               (cairo_destroy_func_t) gdk_color_state_unref);
-}
-
-/**
- * gdk_cairo_surface_get_color_state:
- * @surface: a surface
- *
- * Gets the color state GTK assumes for the surface.
- *
- * See [method@Gdk.CairoSurface.set_color_state] for details.
- *
- * Returns: (transfer none): the color state
- *
- * Since: 4.16
- */
-GdkColorState *
-gdk_cairo_surface_get_color_state (cairo_surface_t *surface)
-{
-  GdkColorState *color_state;
-
-  g_return_val_if_fail (surface != NULL, gdk_color_state_get_srgb ());
-
-  color_state = cairo_surface_get_user_data (surface, &color_state_key);
-  if (color_state == NULL)
-    color_state = gdk_color_state_get_srgb ();
-
-  return color_state;
-}
-
-/**
- * gdk_cairo_get_color_state:
- * @cr: a cairo context
- *
- * Gets the color state GTK assumes for the cairo context.
- *
- * Returns: (transfer none): the color state
- *
- * Since: 4.16
- */
-GdkColorState *
-gdk_cairo_get_color_state (cairo_t *cr)
-{
-  GdkColorState *color_state;
-  cairo_surface_t *surface;
-
-  g_return_val_if_fail (cr != NULL, gdk_color_state_get_srgb ());
-
-  surface = cairo_get_group_target (cr);
-  color_state = cairo_surface_get_user_data (surface, &color_state_key);
-  if (color_state != NULL)
-    return color_state;
-
-  /* theoretically, we should walk the whole group stack, but I don't
-   * think Cairo lets us do that
-   */
-  surface = cairo_get_target (cr);
-  color_state = cairo_surface_get_user_data (surface, &color_state_key);
-  if (color_state != NULL)
-    return color_state;
-
-  return gdk_color_state_get_srgb ();
-}

gdk/gdkcairo.h

@@ -30,11 +30,6 @@ G_BEGIN_DECLS
 GDK_AVAILABLE_IN_ALL
 void       gdk_cairo_set_source_rgba    (cairo_t              *cr,
                                          const GdkRGBA        *rgba);
-
-GDK_AVAILABLE_IN_4_16
-void       gdk_cairo_set_source_color   (cairo_t              *cr,
-                                         const GdkColor       *color);
-
 GDK_AVAILABLE_IN_ALL
 void       gdk_cairo_set_source_pixbuf  (cairo_t              *cr,
                                          const GdkPixbuf      *pixbuf,
@@ -49,15 +44,9 @@ void       gdk_cairo_region             (cairo_t              *cr,
                                          const cairo_region_t *region);
 
 GDK_AVAILABLE_IN_ALL
-cairo_region_t *        gdk_cairo_region_create_from_surface    (cairo_surface_t        *surface);
-
-GDK_AVAILABLE_IN_4_16
-void                    gdk_cairo_surface_set_color_state       (cairo_surface_t        *surface,
-                                                                 GdkColorState          *color_state);
-GDK_AVAILABLE_IN_4_16
-GdkColorState *         gdk_cairo_surface_get_color_state       (cairo_surface_t        *surface);
-GDK_AVAILABLE_IN_4_16
-GdkColorState *         gdk_cairo_get_color_state               (cairo_t                *cr);
+cairo_region_t *
+           gdk_cairo_region_create_from_surface
+                                        (cairo_surface_t      *surface);
 
 GDK_DEPRECATED_IN_4_6_FOR(gdk_gl_texture_new)
 void       gdk_cairo_draw_from_gl (cairo_t              *cr,

gdk/gdkclipboard.c

@@ -522,6 +522,8 @@ gdk_clipboard_get_content (GdkClipboard *clipboard)
  *
  * If the clipboard is not local, this function does nothing but report success.
  *
+ * The @callback must call [method@Gdk.Clipboard.store_finish].
+ *
  * The purpose of this call is to preserve clipboard contents beyond the
  * lifetime of an application, so this function is typically called on
  * exit. Depending on the platform, the functionality may not be available
@@ -636,6 +638,9 @@ gdk_clipboard_read_internal (GdkClipboard        *clipboard,
  * Asynchronously requests an input stream to read the @clipboard's
  * contents from.
  *
+ * When the operation is finished @callback will be called. You must then
+ * call [method@Gdk.Clipboard.read_finish] to get the result of the operation.
+ *
  * The clipboard will choose the most suitable mime type from the given list
  * to fulfill the request, preferring the ones listed first.
  */
@@ -829,6 +834,9 @@ gdk_clipboard_read_value_internal (GdkClipboard        *clipboard,
  * Asynchronously request the @clipboard contents converted to the given
  * @type.
  *
+ * When the operation is finished @callback will be called. You must then call
+ * [method@Gdk.Clipboard.read_value_finish] to get the resulting `GValue`.
+ *
  * For local clipboard contents that are available in the given `GType`,
  * the value will be copied directly. Otherwise, GDK will try to use
  * [func@content_deserialize_async] to convert the clipboard's data.
@@ -887,6 +895,9 @@ gdk_clipboard_read_value_finish (GdkClipboard  *clipboard,
  *
  * Asynchronously request the @clipboard contents converted to a `GdkPixbuf`.
  *
+ * When the operation is finished @callback will be called. You must then
+ * call [method@Gdk.Clipboard.read_texture_finish] to get the result.
+ *
  * This is a simple wrapper around [method@Gdk.Clipboard.read_value_async].
  * Use that function or [method@Gdk.Clipboard.read_async] directly if you
  * need more control over the operation.
@@ -949,6 +960,9 @@ gdk_clipboard_read_texture_finish (GdkClipboard  *clipboard,
  *
  * Asynchronously request the @clipboard contents converted to a string.
  *
+ * When the operation is finished @callback will be called. You must then
+ * call [method@Gdk.Clipboard.read_text_finish] to get the result.
+ *
  * This is a simple wrapper around [method@Gdk.Clipboard.read_value_async].
  * Use that function or [method@Gdk.Clipboard.read_async] directly if you
  * need more control over the operation.

gdk/gdkcolor.c

@@ -1,507 +0,0 @@
-/* GDK - The GIMP Drawing Kit
- *
- * Copyright (C) 2021 Benjamin Otte
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this library. If not, see <http://www.gnu.org/licenses/>.
- */
-
-#include "config.h"
-
-#include "gdkcolorprivate.h"
-#include "gdkcolorstateprivate.h"
-#include "gdkrgbaprivate.h"
-
-#include <lcms2.h>
-
-/**
- * GdkColor:
- * @color_state: the color state to interpret the values in
- * @values: the 3 coordinates that define the color, followed
- *   by the alpha value
- *
- * A `GdkColor` represents a color.
- *
- * The color state defines the meaning and range of the values.
- * E.g., the srgb color state has r, g, b components representing
- * red, green and blue with a range of [0,1], while the oklch color
- * state has l, c, h components representing luminosity, chromaticity
- * and hue, with l ranging from 0 to 1 and c from 0 to about 0.4, while
- * h is interpreted as angle in degrees.
- *
- * value[3] is always the alpha value with a range of [0,1].
- *
- * Note that `GdkColor` is mainly intended for on-stack use, and does
- * not take a reference to the @color_state, unless you use gdk_color_copy().
- */
-
-/* {{{ Boxed type */
-
-G_DEFINE_BOXED_TYPE (GdkColor, gdk_color,
-                     gdk_color_copy, gdk_color_free)
-
-/**
- * gdk_color_copy:
- * @self: a `GdkColor`
- *
- * Makes a copy of a `GdkColor`.
- *
- * The result must be freed through [method@Gdk.Color.free].
- *
- * Returns: A newly allocated `GdkColor`, with the same contents as @self
- *
- * Since: 4.16
- */
-GdkColor *
-gdk_color_copy (const GdkColor *self)
-{
-  GdkColor *copy = g_new0 (GdkColor, 1);
-  g_set_object (&copy->color_state, self->color_state);
-  memcpy (copy->values, self->values, sizeof (float) * 4);
-  return copy;
-}
-
-/**
- * gdk_color_free:
- * @self: a `GdkColor`
- *
- * Frees a `Gdkcolor`.
- *
- * Since: 4.16
- */
-void
-gdk_color_free (GdkColor *self)
-{
-  g_clear_pointer (&self->color_state, gdk_color_state_unref);
-  g_free (self);
-}
-
-/* }}} */
-/* {{{ Public API */
-
-void
-(gdk_color_init) (GdkColor      *self,
-                  GdkColorState *color_state,
-                  const float    components[4])
-{
-  _gdk_color_init (self, color_state, components);
-}
-
-void
-(gdk_color_init_from_rgba) (GdkColor       *self,
-                            const GdkRGBA  *rgba)
-{
-  _gdk_color_init_from_rgba (self, rgba);
-}
-
-GdkColorState *
-(gdk_color_get_color_state) (const GdkColor *self)
-{
-  return _gdk_color_get_color_state (self);
-}
-
-const float *
-(gdk_color_get_components) (const GdkColor *self)
-{
-  return _gdk_color_get_components (self);
-}
-
-gboolean
-(gdk_color_equal) (const GdkColor *self,
-                   const GdkColor *other)
-{
-  return _gdk_color_equal (self, other);
-}
-
-gboolean
-(gdk_color_is_black) (const GdkColor *self)
-{
-  return _gdk_color_is_black (self);
-}
-
-gboolean
-(gdk_color_is_clear) (const GdkColor *self)
-{
-  return _gdk_color_is_clear (self);
-}
-
-gboolean
-(gdk_color_is_opaque) (const GdkColor *self)
-{
-  return _gdk_color_is_opaque (self);
-}
-
-/* }}} */
-
-/**
- * gdk_color_convert:
- * @self: the `GdkColor` to store the result in
- * @color_state: the target color start
- * @other: the `GdkColor` to convert
- *
- * Converts a given `GdkColor` to another color state.
- *
- * After the conversion, @self will represent the same
- * color as @other in @color_state, to the degree possible.
- *
- * Different color states have different gamuts of colors
- * they can represent, and converting a color to a color
- * state with a smaller gamut may yield an 'out of gamut'
- * result.
- *
- * Since: 4.16
- */
-void
-(gdk_color_convert) (GdkColor        *self,
-                     GdkColorState   *color_state,
-                     const GdkColor  *other)
-{
-  GdkColorStateTransform tf;
-
-  self->color_state = color_state;
-
-  gdk_color_state_transform_init (&tf, other->color_state, color_state, TRUE);
-  gdk_color_state_transform (&tf, other->values, self->values, 1);
-  gdk_color_state_transform_finish (&tf);
-}
-
-/**
- * gdk_color_convert_rgba:
- * @self: the `GdkColor` to store the result in
- * @color_state: the target color state
- * @rgba: the `GdkRGBA` to convert
- *
- * Converts a given `GdkRGBA` to the target @color_state.
- *
- * Since: 4.16
- */
-void
-gdk_color_convert_rgba (GdkColor        *self,
-                        GdkColorState   *color_state,
-                        const GdkRGBA   *rgba)
-{
-  GdkColor tmp = { (GdkColorState *) GINT_TO_POINTER (GDK_COLOR_STATE_SRGB),
-                   { rgba->red, rgba->green, rgba->blue, rgba->alpha } };
-
-  gdk_color_convert (self, color_state, &tmp);
-}
-
-/**
- * gdk_color_mix:
- * @self: the `GdkColor` to store the result in
- * @color_start: the target color state
- * @src1: the first color
- * @src2: the second color
- * @progress: the relative amount of @src2, from 0 to 1
- *
- * Mix two colors.
- *
- * This operation first converts @src1 and @src2 to the
- * target @color_state, and then interpolates between them
- * with a position given by @progress.
- *
- * Since: 4.16
- */
-void
-gdk_color_mix (GdkColor        *self,
-               GdkColorState   *color_state,
-               const GdkColor  *src1,
-               const GdkColor  *src2,
-               double           progress)
-{
-  if (src1->color_state != color_state)
-    {
-      GdkColor tmp;
-      gdk_color_convert (&tmp, color_state, src1);
-      gdk_color_mix (self, color_state, &tmp, src2, progress);
-    }
-  else if (src2->color_state != color_state)
-    {
-      GdkColor tmp;
-      gdk_color_convert (&tmp, color_state, src2);
-      gdk_color_mix (self, color_state, src1, &tmp, progress);
-    }
-  else
-    {
-      gsize i;
-      const float *s1, *s2;
-      float *d;
-
-      self->color_state = color_state;
-      self->values[3] = src1->values[3] * (1.0 - progress) + src2->values[3] * progress;
-
-      d = (float *) gdk_color_get_components (self);
-      s1 = gdk_color_get_components (src1);
-      s2 = gdk_color_get_components (src2);
-
-      if (self->values[3] == 0)
-        {
-          for (i = 0; i < 3; i++)
-            d[i] = s1[i] * (1.0 - progress) + s2[i] * progress;
-        }
-      else
-        {
-          for (i = 0; i < 3; i++)
-            d[i] = (s1[i] * src1->values[3] * (1.0 - progress) + s2[i] * src2->values[3] * progress) / self->values[3];
-        }
-    }
-}
-
-/*< private >
- * gdk_color_parser_parse:
- * @parser: the parser
- * @color: location to store the parsed color
- *
- * Parses a string representation of colors that
- * is inspired by CSS.
- *
- * Returns: `TRUE` if parsing succeeded
- *
- * Since: 4.16
- */
-gboolean
-gdk_color_parser_parse (GtkCssParser  *parser,
-                        GdkColor      *color)
-{
-  const GtkCssToken *token;
-  GdkRGBA rgba;
-
-  if (gtk_css_parser_has_function (parser, "color"))
-    {
-      GdkColorState *color_state;
-      float values[4];
-      const char *coords;
-
-      gtk_css_parser_start_block (parser);
-
-      if (gtk_css_parser_try_ident (parser, "srgb"))
-        {
-          coords = "rgb";
-          color_state = gdk_color_state_get_srgb ();
-        }
-      else if (gtk_css_parser_try_ident (parser, "srgb-linear"))
-        {
-          coords = "rgb";
-          color_state = gdk_color_state_get_srgb_linear ();
-        }
-      else if (gtk_css_parser_try_ident (parser, "oklab"))
-        {
-          coords = "lab";
-          color_state = gdk_color_state_get_oklab ();
-        }
-      else if (gtk_css_parser_try_ident (parser, "oklch"))
-        {
-          coords = "lch";
-          color_state = gdk_color_state_get_oklch ();
-        }
-      else
-        {
-          gtk_css_parser_error_syntax (parser, "Expected a valid color state");
-          gtk_css_parser_end_block (parser);
-          return FALSE;
-        }
-
-      for (int i = 0; i < 3; i++)
-        {
-          token = gtk_css_parser_get_token (parser);
-
-          if (gtk_css_token_is (token, GTK_CSS_TOKEN_PERCENTAGE))
-            {
-              float v = token->number.number;
-
-              switch (coords[i])
-                {
-                case 'l':
-                  values[i] = CLAMP (v / 100.0, 0, 1);
-                  break;
-                case 'a':
-                case 'b':
-                  values[i] = v * 0.4 / 100.0;
-                  break;
-                case 'c':
-                  values[i] = MAX (0, v * 0.4 / 100.0);
-                  break;
-                case 'h':
-                  gtk_css_parser_error_syntax (parser, "Can't use percentage for hue");
-                  gtk_css_parser_end_block (parser);
-                  return FALSE;
-                default:
-                  values[i] = CLAMP (v / 100.0, 0, 1);
-                  break;
-                }
-
-              gtk_css_parser_consume_token (parser);
-            }
-          else if (gtk_css_token_is (token, GTK_CSS_TOKEN_SIGNED_NUMBER) ||
-                   gtk_css_token_is (token, GTK_CSS_TOKEN_SIGNLESS_NUMBER) ||
-                   gtk_css_token_is (token, GTK_CSS_TOKEN_SIGNED_INTEGER) ||
-                   gtk_css_token_is (token, GTK_CSS_TOKEN_SIGNLESS_INTEGER))
-            {
-              float v = token->number.number;
-
-              switch (coords[i])
-                {
-                case 'l':
-                  values[i] = CLAMP (v, 0, 1);
-                  break;
-                case 'a':
-                case 'b':
-                case 'h':
-                  values[i] = v;
-                  break;
-                case 'c':
-                  values[i] = MAX (0, v);
-                  break;
-                default:
-                  values[i] = CLAMP (v, 0, 1);
-                  break;
-                }
-
-              gtk_css_parser_consume_token (parser);
-            }
-          else
-            {
-              gtk_css_parser_error_syntax (parser, "Expected a number or percentage");
-              gtk_css_parser_end_block (parser);
-              return FALSE;
-            }
-        }
-
-      token = gtk_css_parser_get_token (parser);
-      if (gtk_css_token_is (token, GTK_CSS_TOKEN_EOF))
-        {
-          values[3] = 1;
-        }
-      else if (gtk_css_token_is_delim (token, '/'))
-        {
-          gtk_css_parser_consume_token (parser);
-
-          token = gtk_css_parser_get_token (parser);
-
-          if (gtk_css_token_is (token, GTK_CSS_TOKEN_PERCENTAGE))
-            {
-              values[3] = CLAMP (token->number.number / 100.0, 0, 1);
-              gtk_css_parser_consume_token (parser);
-            }
-          else if (gtk_css_token_is (token, GTK_CSS_TOKEN_SIGNED_NUMBER) ||
-                   gtk_css_token_is (token, GTK_CSS_TOKEN_SIGNLESS_NUMBER) ||
-                   gtk_css_token_is (token, GTK_CSS_TOKEN_SIGNED_INTEGER) ||
-                   gtk_css_token_is (token, GTK_CSS_TOKEN_SIGNLESS_INTEGER))
-            {
-              values[3] = CLAMP (token->number.number, 0, 1);
-              gtk_css_parser_consume_token (parser);
-            }
-          else
-            {
-              gtk_css_parser_error_syntax (parser, "Expected a number or percentage");
-              gtk_css_parser_end_block (parser);
-              return FALSE;
-            }
-
-          token = gtk_css_parser_get_token (parser);
-          if (!gtk_css_token_is (token, GTK_CSS_TOKEN_EOF))
-            {
-              gtk_css_parser_error_syntax (parser, "Garbage at the end of the value");
-              gtk_css_parser_end_block (parser);
-              return FALSE;
-            }
-
-          gtk_css_parser_consume_token (parser);
-        }
-      else
-        {
-          gtk_css_parser_error_syntax (parser, "Expected '/'");
-          gtk_css_parser_end_block (parser);
-          return FALSE;
-        }
-
-      gtk_css_parser_end_block (parser);
-
-      gdk_color_init (color, color_state, values);
-      return TRUE;
-    }
-  else if (gdk_rgba_parser_parse (parser, &rgba))
-    {
-      gdk_color_init_from_rgba (color, &rgba);
-      return TRUE;
-    }
-
-  return FALSE;
-}
-
-/**
- * gdk_color_print:
- * @self: a `GdkColor`
- * @string: the string to print on
- *
- * Appends a representation of @self to @string.
- *
- * The representation is inspired by CSS3 colors,
- * but not 100% identical, and looks like this:
- *
- *     color(NAME V1 V2 V3 / ALPHA)
- *
- * where `NAME` is the name of the color state,
- * `V1`, `V2`, `V3` and `ALPHA` are the components
- * of the color. Alpha may be omitted if it is 1.
- *
- * Since: 4.16
- */
-void
-gdk_color_print (const GdkColor *self,
-                 GString        *string)
-{
-  char buffer[48];
-
-  g_string_append (string, "color(");
-  g_string_append (string, gdk_color_state_get_name (self->color_state));
-  g_string_append_c (string, ' ');
-  g_ascii_dtostr (buffer, sizeof (buffer), self->values[0]);
-  g_string_append (string, buffer);
-  g_string_append_c (string, ' ');
-  g_ascii_dtostr (buffer, sizeof (buffer), self->values[1]);
-  g_string_append (string, buffer);
-  g_string_append_c (string, ' ');
-  g_ascii_dtostr (buffer, sizeof (buffer), self->values[2]);
-  g_string_append (string, buffer);
-  if (self->values[3] < 0.999)
-    {
-      g_string_append (string, " / ");
-      g_ascii_dtostr (buffer, sizeof (buffer), self->values[3]);
-      g_string_append (string, buffer);
-    }
-  g_string_append_c (string, ')');
-}
-
-/**
- * gdk_color_to_string:
- * @self: a `GdkColor`
- *
- * Returns a string representation @self.
- *
- * See [method@Gdk.Color.print] for details about
- * the format.
- *
- * Returns: (transfer full): a newly allocated string
- *
- * Since: 4.16
- */
-char *
-gdk_color_to_string (const GdkColor *self)
-{
-  GString *string = g_string_new ("");
-  gdk_color_print (self, string);
-  return g_string_free (string, FALSE);
-}
-
-/* vim:set foldmethod=marker expandtab: */

gdk/gdkcolor.h

@@ -1,106 +0,0 @@
-/* GDK - The GIMP Drawing Kit
- *
- * Copyright (C) 2021 Benjamin Otte
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this library. If not, see <http://www.gnu.org/licenses/>.
- */
-
-#pragma once
-
-#include <gdk/gdktypes.h>
-#include <gdk/gdkcolorstate.h>
-#include <gdk/gdkrgba.h>
-
-
-/* The interpretation of the first 3 components depends on the color state.
- * values[3] is always alpha.
- */
-struct _GdkColor
-{
-  GdkColorState *color_state;
-  float values[4];
-};
-
-G_STATIC_ASSERT (sizeof (GdkColor) % sizeof (gpointer) == 0);
-
-#define GDK_TYPE_COLOR (gdk_color_get_type ())
-
-G_BEGIN_DECLS
-
-#define GDK_COLOR_INIT(cs, c1, c2, c3, c4) \
-  (GdkColor) { (cs), { (c1), (c2), (c3), (c4) } }
-
-#define GDK_COLOR_INIT_SRGB(c1, c2, c3, c4) \
-  GDK_COLOR_INIT (GDK_COLOR_STATE_SRGB, (c1), (c2), (c3), (c4) )
-
-#define GDK_COLOR_INIT_RGBA(r) \
-  GDK_COLOR_INIT_SRGB ((r)->red, (r)->green, (r)->blue, (r)->alpha)
-
-GDK_AVAILABLE_IN_4_16
-GType             gdk_color_get_type            (void) G_GNUC_CONST;
-
-GDK_AVAILABLE_IN_4_16
-GdkColor *        gdk_color_copy                (const GdkColor         *self);
-GDK_AVAILABLE_IN_4_16
-void              gdk_color_free                (GdkColor               *self);
-
-GDK_AVAILABLE_IN_4_16
-void              gdk_color_init                (GdkColor               *self,
-                                                 GdkColorState          *color_state,
-                                                 const float             components[4]);
-GDK_AVAILABLE_IN_4_16
-void              gdk_color_init_from_rgba      (GdkColor               *self,
-                                                 const GdkRGBA          *rgba);
-
-GDK_AVAILABLE_IN_4_16
-void              gdk_color_convert             (GdkColor               *self,
-                                                 GdkColorState          *color_state,
-                                                 const GdkColor         *other);
-GDK_AVAILABLE_IN_4_16
-void              gdk_color_convert_rgba        (GdkColor               *self,
-                                                 GdkColorState          *color_state,
-                                                 const GdkRGBA          *rgba);
-GDK_AVAILABLE_IN_4_16
-void              gdk_color_mix                 (GdkColor               *self,
-                                                 GdkColorState          *color_state,
-                                                 const GdkColor         *src1,
-                                                 const GdkColor         *src2,
-                                                 double                  progress);
-
-GDK_AVAILABLE_IN_4_16
-void              gdk_color_print               (const GdkColor         *self,
-                                                 GString                *string);
-
-GDK_AVAILABLE_IN_4_16
-char *            gdk_color_to_string           (const GdkColor         *self);
-
-GDK_AVAILABLE_IN_4_16
-GdkColorState *   gdk_color_get_color_state     (const GdkColor         *self);
-
-GDK_AVAILABLE_IN_4_16
-const float *     gdk_color_get_components      (const GdkColor         *self);
-
-GDK_AVAILABLE_IN_4_16
-gboolean          gdk_color_equal               (const GdkColor         *color1,
-                                                 const GdkColor         *color2);
-GDK_AVAILABLE_IN_4_16
-gboolean          gdk_color_is_black            (const GdkColor         *self);
-GDK_AVAILABLE_IN_4_16
-gboolean          gdk_color_is_clear            (const GdkColor         *self);
-GDK_AVAILABLE_IN_4_16
-gboolean          gdk_color_is_opaque           (const GdkColor         *self);
-
-#include "gdkcolorimpl.h"
-
-G_END_DECLS

gdk/gdkcolorimpl.h

@@ -1,122 +0,0 @@
-/* GDK - The GIMP Drawing Kit
- *
- * Copyright (C) 2021 Benjamin Otte
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this library. If not, see <http://www.gnu.org/licenses/>.
- */
-
-#pragma once
-
-#define gdk_color_init(self, cs, comp) _gdk_color_init ((self), (cs), (comp))
-static inline void
-_gdk_color_init (GdkColor        *self,
-                 GdkColorState   *color_state,
-                 const float      components[4])
-{
-  self->color_state = color_state;
-  self->values[0] = components[0];
-  self->values[1] = components[1];
-  self->values[2] = components[2];
-  self->values[3] = components[3];
-}
-
-#define gdk_color_init_from_rgb(self, rgba) _gdk_color_init_from_rgba (self, rgba)
-static inline void
-_gdk_color_init_from_rgba (GdkColor      *self,
-                           const GdkRGBA *rgba)
-{
-  self->color_state = GDK_COLOR_STATE_SRGB;
-  self->values[0] = rgba->red;
-  self->values[1] = rgba->green;
-  self->values[2] = rgba->blue;
-  self->values[3] = rgba->alpha;
-}
-
-#define gdk_color_get_color_state(self) _gdk_color_get_color_state (self)
-static inline GdkColorState *
-_gdk_color_get_color_state (const GdkColor *self)
-{
-  return self->color_state;
-}
-
-#define gdk_color_get_components(self) _gdk_color_get_components (self)
-static inline const float *
-_gdk_color_get_components (const GdkColor *self)
-{
-  return self->values;
-}
-
-#define gdk_color_equal(self, other) _gdk_color_equal (self, other)
-static inline gboolean
-_gdk_color_equal (const GdkColor *self,
-                  const GdkColor *other)
-{
-  return self->values[0] == other->values[0] &&
-         self->values[1] == other->values[1] &&
-         self->values[2] == other->values[2] &&
-         self->values[3] == other->values[3] &&
-         gdk_color_state_equal (self->color_state, other->color_state);
-}
-
-static inline gboolean
-all_zero (const GdkColor *c)
-{
-  return c->values[0] == 0 && c->values[1] == 0 && c->values[2] == 0;
-}
-
-#define gdk_color_is_black(self) _gdk_color_is_black (self)
-static inline gboolean
-_gdk_color_is_black (const GdkColor *self)
-{
-  if (gdk_color_state_equal (self->color_state, GDK_COLOR_STATE_SRGB))
-    return all_zero (self);
-  else
-    {
-      GdkColor c;
-      gboolean res;
-
-      gdk_color_convert (&c, GDK_COLOR_STATE_SRGB, self);
-      res = all_zero (&c);
-      return res;
-    }
-}
-
-#define gdk_color_is_clear(self) _gdk_color_is_clear (self)
-static inline gboolean
-_gdk_color_is_clear (const GdkColor *self)
-{
-  return self->values[3] < ((float) 0x00ff / (float) 0xffff);
-}
-
-#define gdk_color_is_opaque(self) _gdk_color_is_opaque (self)
-static inline gboolean
-_gdk_color_is_opaque (const GdkColor *self)
-{
-  return self->values[3] > ((float)0xff00 / (float)0xffff);
-}
-
-#define gdk_color_convert(self, cs, other) _gdk_color_convert (self, cs, other)
-static inline void
-_gdk_color_convert (GdkColor        *self,
-                    GdkColorState   *color_state,
-                    const GdkColor  *other)
-{
-  if (gdk_color_state_equal (color_state, other->color_state))
-    {
-      gdk_color_init (self, color_state, other->values);
-      return;
-    }
-
-  (gdk_color_convert) (self, color_state, other);
-}

gdk/gdkcolorprivate.h

@@ -1,27 +0,0 @@
-/* GDK - The GIMP Drawing Kit
- * Copyright (C) 2024, Red Hat, Inc
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this library. If not, see <http://www.gnu.org/licenses/>.
- */
-
-#pragma once
-
-#include "gdkcolor.h"
-
-#include "gtk/css/gtkcssparserprivate.h"
-
-
-gboolean        gdk_color_parser_parse  (GtkCssParser *parser,
-                                         GdkColor     *color);
-

gdk/gdkcolorstate.c

@@ -1,950 +0,0 @@
-/* gdkcolorstate.c
- *
- * Copyright 2024 Matthias Clasen
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this library. If not, see <http://www.gnu.org/licenses/>.
- */
-
-#include "config.h"
-
-#include "gdkcolorstateprivate.h"
-
-#include <glib/gi18n-lib.h>
-#include "gtk/gtkcolorutilsprivate.h"
-
-/**
- * GdkColorState:
- *
- * A `GdkColorState` object provides the information to interpret
- * colors and pixels in a variety of ways.
- *
- * They are also known as
- * [*color spaces*](https://en.wikipedia.org/wiki/Color_space).
- *
- * Crucially, GTK knows how to convert colors from one color
- * state to another.
- *
- * `GdkColorState objects are immutable and therefore threadsafe.
- *
- * Since 4.16
- */
-
-static GdkColorStateClass * get_class (GdkColorState *self);
-
-
-G_DEFINE_BOXED_TYPE (GdkColorState, gdk_color_state,
-                     gdk_color_state_ref, gdk_color_state_unref);
-
-/* {{{ Public API */
-
-GdkColorState *
-(gdk_color_state_ref) (GdkColorState *self)
-{
-  return _gdk_color_state_ref (self);
-}
-
-void
-(gdk_color_state_unref) (GdkColorState *self)
-{
-  _gdk_color_state_unref (self);
-}
-
-GdkColorState *
-(gdk_color_state_get_srgb) (void)
-{
-  return _gdk_color_state_get_srgb ();
-}
-
-GdkColorState *
-(gdk_color_state_get_srgb_linear) (void)
-{
-  return _gdk_color_state_get_srgb_linear ();
-}
-
-GdkColorState *
-(gdk_color_state_get_hsl) (void)
-{
-  return _gdk_color_state_get_hsl ();
-}
-
-GdkColorState *
-(gdk_color_state_get_hwb) (void)
-{
-  return _gdk_color_state_get_hwb ();
-}
-
-GdkColorState *
-(gdk_color_state_get_oklab) (void)
-{
-  return _gdk_color_state_get_oklab ();
-}
-
-GdkColorState *
-(gdk_color_state_get_oklch) (void)
-{
-  return _gdk_color_state_get_oklch ();
-}
-
-GdkColorState *
-(gdk_color_state_get_display_p3) (void)
-{
-  return _gdk_color_state_get_display_p3 ();
-}
-
-GdkColorState *
-(gdk_color_state_get_xyz) (void)
-{
-  return _gdk_color_state_get_xyz ();
-}
-
-GdkColorState *
-(gdk_color_state_get_rec2020) (void)
-{
-  return _gdk_color_state_get_rec2020 ();
-}
-
-GdkColorState *
-(gdk_color_state_get_rec2100_pq) (void)
-{
-  return _gdk_color_state_get_rec2100_pq ();
-}
-
-GdkColorState *
-(gdk_color_state_get_rec2100_linear) (void)
-{
-  return _gdk_color_state_get_rec2100_linear ();
-}
-
-/**
- * gdk_color_state_equal:
- * @self: a `GdkColorState`
- * @other: another `GdkColorStatee`
- *
- * Compares two `GdkColorStates` for equality.
- *
- * Note that this function is not guaranteed to be perfect and two objects
- * describing the same color state may compare not equal. However, different
- * color states will never compare equal.
- *
- * Returns: %TRUE if the two color states compare equal
- *
- * Since: 4.16
- */
-gboolean
-(gdk_color_state_equal) (GdkColorState *self,
-                         GdkColorState *other)
-{
-  return _gdk_color_state_equal (self, other);
-}
-
-/**
- * gdk_color_state_is_linear:
- * @self: a `GdkColorState`
- *
- * Returns whether the color state is linear.
- *
- * Returns: `TRUE` if the color state is linear
- * Since: 4.16
- */
-gboolean
-gdk_color_state_is_linear (GdkColorState *self)
-{
-  return get_class (self)->is_linear (self);
-}
-
-/**
- * gdk_color_state_save_to_icc_profile:
- * @self: a `GdkColorState`
- * @error: Return location for an error
- *
- * Saves the color state to an
- * [ICC profile](https://en.wikipedia.org/wiki/ICC_profile).
- *
- * Some color states cannot be represented as ICC profiles.
- * In that case, @error will be set and %NULL will be returned.
- *
- * Returns: (nullable): A new `GBytes` containing the ICC profile
- *
- * Since: 4.16
- */
-GBytes *
-gdk_color_state_save_to_icc_profile (GdkColorState  *self,
-                                     GError        **error)
-{
-  return get_class (self)->save_to_icc_profile (self, error);
-}
-
-/**
- * gdk_color_state_save_to_cicp_data:
- * @self: a `GdkColorState`
- * @color_primaries: return location for color primaries
- * @transfer_characteristics: return location for transfer characteristics
- * @matrix_coefficients: return location for matrix_coefficients
- * @full_range: return location for the full range flag
- * @error: Return location for an error
- *
- * Saves the color state as
- * [CICP](https://en.wikipedia.org/wiki/Coding-independent_code_points)
- * data.
- *
- * Some color states cannot be represented as CICP data.
- * In that case, @error will be set and `FALSE` will be returned.
- *
- * Returns: (nullable): `TRUE` if the out arguments were set
- *
- * Since: 4.16
- */
-gboolean
-gdk_color_state_save_to_cicp_data (GdkColorState  *self,
-                                   int            *color_primaries,
-                                   int            *transfer_characteristics,
-                                   int            *matrix_coefficients,
-                                   gboolean       *full_range,
-                                   GError        **error)
-{
-  return get_class (self)->save_to_cicp_data (self,
-                                              color_primaries,
-                                              transfer_characteristics,
-                                              matrix_coefficients,
-                                              full_range,
-                                              error);
-}
-
-/* }}} */
-/* {{{ ICC implementation */
-
-#define GDK_LCMS_COLOR_STATE(c) ((GdkLcmsColorState *)(c))
-
-typedef struct {
-  GdkColorState state;
-
-  cmsHPROFILE lcms_profile;
-} GdkLcmsColorState;
-
-/* {{{ Helpers */
-
-static cmsHPROFILE
-gdk_lcms_color_state_get_lcms_profile (GdkColorState *self)
-{
-  g_return_val_if_fail (GDK_IS_LCMS_COLOR_STATE (self), NULL);
-
-  return GDK_LCMS_COLOR_STATE (self)->lcms_profile;
-}
-
-static cmsHPROFILE
-gdk_lcms_get_srgb_profile (void)
-{
-   return cmsCreate_sRGBProfile ();
-}
-
-static cmsHPROFILE
-gdk_lcms_get_srgb_linear_profile (void)
-{
-  cmsToneCurve *curve;
-  cmsHPROFILE profile;
-
-  curve = cmsBuildGamma (NULL, 1.0);
-  profile = cmsCreateRGBProfile (&(cmsCIExyY) {
-                                   0.3127, 0.3290, 1.0
-                                 },
-                                 &(cmsCIExyYTRIPLE) {
-                                   { 0.6400, 0.3300, 1.0 },
-                                   { 0.3000, 0.6000, 1.0 },
-                                   { 0.1500, 0.0600, 1.0 }
-                                 },
-                                 (cmsToneCurve*[3]) { curve, curve, curve });
-  cmsFreeToneCurve (curve);
-
-  return profile;
-}
-
-static GBytes *
-gdk_lcms_save_profile (cmsHPROFILE   profile,
-                       GError      **error)
-{
-  cmsUInt32Number size;
-  guchar *data;
-
-  size = 0;
-  if (!cmsSaveProfileToMem (profile, NULL, &size))
-    {
-      g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED, _("Could not prepare ICC profile"));
-      return NULL;
-    }
-
-  data = g_malloc (size);
-  if (!cmsSaveProfileToMem (profile, data, &size))
-    {
-      g_free (data);
-      g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED, _("Failed to save ICC profile"));
-      return NULL;
-    }
-
-  return g_bytes_new_take (data, size);
-}
-
-/* }}} */
-/* {{{ GdkColorState vfuncs */
-
-static void
-gdk_lcms_color_state_free (GdkColorState *state)
-{
-  GdkLcmsColorState *self = (GdkLcmsColorState *) state;
-
-  cmsCloseProfile (self->lcms_profile);
-
-  g_free (self);
-}
-
-static gboolean
-gdk_lcms_color_state_equal (GdkColorState *state1,
-                            GdkColorState *state2)
-{
-  GBytes *icc1, *icc2;
-  gboolean res;
-
-  icc1 = gdk_color_state_save_to_icc_profile (state1, NULL);
-  icc2 = gdk_color_state_save_to_icc_profile (state2, NULL);
-
-  res = g_bytes_equal (icc1, icc2);
-
-  g_bytes_unref (icc1);
-  g_bytes_unref (icc2);
-
-  return res;
-}
-
-static gboolean
-gdk_lcms_color_state_is_linear (GdkColorState *state)
-{
-  return FALSE; /* FIXME */
-}
-
-static GBytes *
-gdk_lcms_color_state_save_to_icc_profile (GdkColorState  *state,
-                                          GError        **error)
-{
-  GdkLcmsColorState *self = GDK_LCMS_COLOR_STATE (state);
-
-  return gdk_lcms_save_profile (self->lcms_profile, error);
-}
-
-static gboolean
-gdk_lcms_color_state_save_to_cicp_data (GdkColorState  *self,
-                                        int            *color_primaries,
-                                        int            *transfer_characteristics,
-                                        int            *matrix_coefficients,
-                                        gboolean       *full_range,
-                                        GError        **error)
-{
-  g_set_error_literal (error, G_IO_ERROR, G_IO_ERROR_NOT_SUPPORTED,
-                       _("This color state does not support CICP data"));
-  return FALSE;
-}
-
-static const char *
-gdk_lcms_color_state_get_name (GdkColorState *self)
-{
-  static char buffer[48];
-
-  g_snprintf (buffer, sizeof (buffer), "lcms color state %p", self);
-
-  return buffer;
-}
-
-static guint
-gdk_lcms_color_state_get_min_depth (GdkColorState *self)
-{
-  return GDK_MEMORY_U16; /* ? */
-}
-
-static int
-gdk_lcms_color_state_get_hue_coord (GdkColorState *self)
-{
-  return -1;
-}
-
-static GdkColorStateClass LCMS_COLOR_STATE_CLASS =
-{
-  GDK_TYPE_LCMS_COLOR_STATE,
-  gdk_lcms_color_state_free,
-  gdk_lcms_color_state_equal,
-  gdk_lcms_color_state_is_linear,
-  gdk_lcms_color_state_save_to_icc_profile,
-  gdk_lcms_color_state_save_to_cicp_data,
-  gdk_lcms_color_state_get_name,
-  gdk_lcms_color_state_get_min_depth,
-  gdk_lcms_color_state_get_hue_coord,
-};
-
-/* }}} */
-/* {{{ Private API */
-
-GdkColorState *
-gdk_color_state_new_from_lcms_profile (cmsHPROFILE lcms_profile)
-{
-  GdkLcmsColorState *self;
-
-  self= g_new0 (GdkLcmsColorState, 1);
-
-  self->state.klass = &LCMS_COLOR_STATE_CLASS;
-  self->state.ref_count = 1;
-
-  self->lcms_profile = lcms_profile;
-
-  return (GdkColorState *) self;
-}
-
-/* }}} */
-/* {{{ Public API */
-
-/**
- * gdk_color_state_new_from_icc_profile:
- * @icc_profile: The ICC profiles given as a `GBytes`
- * @error: Return location for an error
- *
- * Creates a new color state for the given ICC profile data.
- *
- * if the profile is not valid, %NULL is returned and an error
- * is raised.
- *
- * Returns: a new `GdkColorState` or %NULL on error
- *
- * Since: 4.16
- */
-GdkColorState *
-gdk_color_state_new_from_icc_profile (GBytes  *icc_profile,
-                                      GError **error)
-{
-  cmsHPROFILE lcms_profile;
-  const guchar *data;
-  gsize size;
-
-  g_return_val_if_fail (icc_profile != NULL, NULL);
-  g_return_val_if_fail (error == NULL || *error == NULL, NULL);
-
-  data = g_bytes_get_data (icc_profile, &size);
-
-  lcms_profile = cmsOpenProfileFromMem (data, size);
-  if (lcms_profile == NULL)
-    {
-      g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED, _("Failed to load ICC profile"));
-      return NULL;
-    }
-
-  return gdk_color_state_new_from_lcms_profile (lcms_profile);
-}
-
-/* }}} */
-/* }}} */
-/* {{{ Named implementation */
-
-static gboolean
-gdk_named_color_state_is_linear (GdkColorState *self)
-{
-  switch (GDK_NAMED_COLOR_STATE_ID (self))
-    {
-    case GDK_COLOR_STATE_ID_SRGB_LINEAR:
-    case GDK_COLOR_STATE_ID_OKLAB:
-    case GDK_COLOR_STATE_ID_OKLCH:
-    case GDK_COLOR_STATE_ID_XYZ:
-    case GDK_COLOR_STATE_ID_REC2100_LINEAR:
-      return TRUE;
-
-    case GDK_COLOR_STATE_ID_SRGB:
-    case GDK_COLOR_STATE_ID_HSL:
-    case GDK_COLOR_STATE_ID_HWB:
-    case GDK_COLOR_STATE_ID_DISPLAY_P3:
-    case GDK_COLOR_STATE_ID_REC2020:
-    case GDK_COLOR_STATE_ID_REC2100_PQ:
-      return FALSE;
-
-    default:
-      g_assert_not_reached ();
-    }
-}
-
-static GBytes *
-gdk_named_color_state_save_to_icc_profile (GdkColorState  *self,
-                                           GError        **error)
-{
-  cmsHPROFILE profile;
-
-  switch (GDK_NAMED_COLOR_STATE_ID (self))
-    {
-    case GDK_COLOR_STATE_ID_SRGB:
-      profile = gdk_lcms_get_srgb_profile ();
-      break;
-
-    case GDK_COLOR_STATE_ID_SRGB_LINEAR:
-      profile = gdk_lcms_get_srgb_linear_profile ();
-      break;
-
-    case GDK_COLOR_STATE_ID_OKLAB:
-    case GDK_COLOR_STATE_ID_OKLCH:
-    case GDK_COLOR_STATE_ID_HSL:
-    case GDK_COLOR_STATE_ID_HWB:
-    case GDK_COLOR_STATE_ID_DISPLAY_P3:
-    case GDK_COLOR_STATE_ID_XYZ:
-    case GDK_COLOR_STATE_ID_REC2020:
-    case GDK_COLOR_STATE_ID_REC2100_PQ:
-    case GDK_COLOR_STATE_ID_REC2100_LINEAR:
-      profile = NULL;
-      break;
-
-    default:
-      g_assert_not_reached ();
-    }
-
-  if (profile)
-    {
-      GBytes *bytes;
-
-      bytes = gdk_lcms_save_profile (profile, error);
-      cmsCloseProfile (profile);
-
-      return bytes;
-    }
-  else
-    {
-      g_set_error (error,
-                   G_IO_ERROR, G_IO_ERROR_FAILED,
-                   _("ICC profile not supported for this color state"));
-
-      return NULL;
-    }
-}
-
-static gboolean
-gdk_named_color_state_save_to_cicp_data (GdkColorState  *self,
-                                         int            *color_primaries,
-                                         int            *transfer_characteristics,
-                                         int            *matrix_coefficients,
-                                         gboolean       *full_range,
-                                         GError        **error)
-{
-  switch (GDK_NAMED_COLOR_STATE_ID (self))
-    {
-    case GDK_COLOR_STATE_ID_SRGB:
-      *color_primaries = 0;
-      *transfer_characteristics = 13;
-      *matrix_coefficients = 0;
-      *full_range = TRUE;
-      return TRUE;
-
-    case GDK_COLOR_STATE_ID_SRGB_LINEAR:
-      *color_primaries = 0;
-      *transfer_characteristics = 8;
-      *matrix_coefficients = 0;
-      *full_range = TRUE;
-      return TRUE;
-
-    case GDK_COLOR_STATE_ID_REC2100_PQ:
-      *color_primaries = 9;
-      *transfer_characteristics = 16;
-      *matrix_coefficients = 0;
-      *full_range = TRUE;
-      return TRUE;
-
-    case GDK_COLOR_STATE_ID_REC2100_LINEAR:
-      *color_primaries = 9;
-      *transfer_characteristics = 8;
-      *matrix_coefficients = 0;
-      *full_range = TRUE;
-      return TRUE;
-
-    case GDK_COLOR_STATE_ID_DISPLAY_P3:
-      *color_primaries = 12;
-      *transfer_characteristics = 13;
-      *matrix_coefficients = 0;
-      *full_range = TRUE;
-      return TRUE;
-
-    case GDK_COLOR_STATE_ID_HSL:
-    case GDK_COLOR_STATE_ID_HWB:
-    case GDK_COLOR_STATE_ID_OKLAB:
-    case GDK_COLOR_STATE_ID_OKLCH:
-    case GDK_COLOR_STATE_ID_XYZ:
-    case GDK_COLOR_STATE_ID_REC2020:
-      break;
-
-    default:
-      g_assert_not_reached ();
-    }
-
-  g_set_error_literal (error, G_IO_ERROR, G_IO_ERROR_NOT_SUPPORTED,
-                       _("This color state does not support CICP data"));
-  return FALSE;
-}
-
-const char *
-gdk_color_state_get_name_from_id (GdkColorStateId id)
-{
-  const char *names[] = {
-    "srgb", "srgb-linear", "hsl", "hwb",
-    "oklab", "oklch", "display-p3", "xyz",
-    "rec2020", "rec2100-pq", "rec2100-linear",
-  };
-
-  return names[(id - 1) >> 1];
-}
-
-static const char *
-gdk_named_color_state_get_name (GdkColorState *self)
-{
-  return gdk_color_state_get_name_from_id (GDK_NAMED_COLOR_STATE_ID (self));
-}
-
-static guint
-gdk_named_color_state_get_min_depth (GdkColorState *self)
-{
-  switch (GDK_NAMED_COLOR_STATE_ID (self))
-    {
-    case GDK_COLOR_STATE_ID_OKLAB:
-    case GDK_COLOR_STATE_ID_OKLCH:
-    case GDK_COLOR_STATE_ID_HSL:
-    case GDK_COLOR_STATE_ID_HWB:
-    case GDK_COLOR_STATE_ID_DISPLAY_P3:
-    case GDK_COLOR_STATE_ID_XYZ:
-    case GDK_COLOR_STATE_ID_REC2020:
-    case GDK_COLOR_STATE_ID_REC2100_PQ:
-    case GDK_COLOR_STATE_ID_REC2100_LINEAR:
-    case GDK_COLOR_STATE_ID_SRGB_LINEAR:
-      return GDK_MEMORY_FLOAT16;
-
-    case GDK_COLOR_STATE_ID_SRGB:
-      return GDK_MEMORY_U8;
-
-    default:
-      g_assert_not_reached ();
-    }
-}
-
-static int
-gdk_named_color_state_get_hue_coord (GdkColorState *in)
-{
-  switch (GDK_NAMED_COLOR_STATE_ID (in))
-    {
-    case GDK_COLOR_STATE_ID_SRGB:
-    case GDK_COLOR_STATE_ID_SRGB_LINEAR:
-    case GDK_COLOR_STATE_ID_OKLAB:
-    case GDK_COLOR_STATE_ID_DISPLAY_P3:
-    case GDK_COLOR_STATE_ID_XYZ:
-    case GDK_COLOR_STATE_ID_REC2020:
-    case GDK_COLOR_STATE_ID_REC2100_PQ:
-    case GDK_COLOR_STATE_ID_REC2100_LINEAR:
-      return -1;
-
-    case GDK_COLOR_STATE_ID_HSL:
-    case GDK_COLOR_STATE_ID_HWB:
-      return 0;
-
-    case GDK_COLOR_STATE_ID_OKLCH:
-      return 2;
-
-    default:
-      g_assert_not_reached ();
-    }
-}
-
-static GdkColorStateClass NAMED_COLOR_STATE_CLASS =
-{
-  GDK_TYPE_NAMED_COLOR_STATE,
-  NULL,
-  NULL,
-  gdk_named_color_state_is_linear,
-  gdk_named_color_state_save_to_icc_profile,
-  gdk_named_color_state_save_to_cicp_data,
-  gdk_named_color_state_get_name,
-  gdk_named_color_state_get_min_depth,
-  gdk_named_color_state_get_hue_coord,
-};
-
-/* }}} */
-/* {{{ CICP support */
-
-GdkColorState *
-gdk_color_state_new_from_cicp_data (int      color_primaries,
-                                    int      transfer_characteristics,
-                                    int      matrix_coefficients,
-                                    gboolean full_range)
-{
-  /* FIXME We don't support these */
-  if (!full_range || matrix_coefficients != 0)
-    return NULL;
-
-  /* Look for cases we can handle */
-  if (color_primaries == 0 && transfer_characteristics == 13)
-    return gdk_color_state_get_srgb ();
-  else if (color_primaries == 0 && transfer_characteristics == 8)
-    return gdk_color_state_get_srgb_linear ();
-  else if (color_primaries == 9 && transfer_characteristics == 16)
-    return gdk_color_state_get_rec2100_pq ();
-  else if (color_primaries == 9 && transfer_characteristics == 8)
-    return gdk_color_state_get_rec2100_linear ();
-  else if (color_primaries == 12 && transfer_characteristics == 13)
-    return gdk_color_state_get_display_p3 ();
-
-  return NULL;
-}
-
-/* }}} */
-/* {{{ Private API */
-
-static GdkColorStateClass *
-get_class (GdkColorState *self)
-{
-  if (GDK_IS_NAMED_COLOR_STATE (self))
-    return &NAMED_COLOR_STATE_CLASS;
-
-  return self->klass;
-}
-
-GdkMemoryDepth
-gdk_color_state_get_min_depth (GdkColorState *self)
-{
-  return (GdkMemoryDepth) get_class (self)->get_min_depth (self);
-}
-
-const char *
-gdk_color_state_get_name (GdkColorState *self)
-{
-  return get_class (self)->get_name (self);
-}
-
-int
-gdk_color_state_get_hue_coord (GdkColorState *self)
-{
-  return get_class (self)->get_hue_coord (self);
-}
-
-/* }}} */
-/* {{{ Conversion */
-
-#define two_step(name, func1, func2)    \
-static void                             \
-name (float r,  float g,  float b,      \
-      float *x, float *y, float *z)     \
-{                                       \
-  func1 (r, g, b, x, y, z);             \
-  func2 (*x, *y, *z, x, y, z);          \
-}
-
-/* A full complement of xyz <> anything step functions */
-two_step (srgb_to_xyz, gtk_rgb_to_linear_srgb, gtk_linear_srgb_to_xyz)
-two_step (xyz_to_srgb, gtk_xyz_to_linear_srgb, gtk_linear_srgb_to_rgb)
-two_step (hsl_to_xyz, gtk_hsl_to_rgb, srgb_to_xyz)
-two_step (xyz_to_hsl, xyz_to_srgb, gtk_rgb_to_hsl)
-two_step (hwb_to_xyz, gtk_hwb_to_rgb, srgb_to_xyz)
-two_step (xyz_to_hwb, xyz_to_srgb, gtk_rgb_to_hwb)
-two_step (oklab_to_xyz, gtk_oklab_to_linear_srgb, gtk_linear_srgb_to_xyz)
-two_step (xyz_to_oklab, gtk_xyz_to_linear_srgb, gtk_linear_srgb_to_oklab)
-two_step (oklch_to_xyz, gtk_oklch_to_oklab, oklab_to_xyz)
-two_step (xyz_to_oklch, xyz_to_oklab, gtk_oklab_to_oklch)
-two_step (p3_to_xyz, gtk_p3_to_rgb, srgb_to_xyz)
-two_step (xyz_to_p3, xyz_to_srgb, gtk_rgb_to_p3)
-two_step (rec2100_linear_to_xyz, gtk_rec2100_linear_to_rec2020_linear, gtk_rec2020_linear_to_xyz)
-two_step (xyz_to_rec2100_linear, gtk_xyz_to_rec2020_linear, gtk_rec2020_linear_to_rec2100_linear)
-two_step (rec2100_pq_to_xyz, gtk_rec2100_pq_to_rec2100_linear, rec2100_linear_to_xyz)
-two_step (xyz_to_rec2100_pq, xyz_to_rec2100_linear, gtk_rec2100_linear_to_rec2100_pq)
-
-
-static struct {
- GdkColorStateId n1;
- GdkColorStateId n2;
- StepFunc func;
-} functions[] = {
-  {  GDK_COLOR_STATE_ID_SRGB,            GDK_COLOR_STATE_ID_SRGB_LINEAR,    gtk_rgb_to_linear_srgb },
-  {  GDK_COLOR_STATE_ID_SRGB,            GDK_COLOR_STATE_ID_HSL,            gtk_rgb_to_hsl },
-  {  GDK_COLOR_STATE_ID_SRGB,            GDK_COLOR_STATE_ID_HWB,            gtk_rgb_to_hwb },
-  {  GDK_COLOR_STATE_ID_SRGB,            GDK_COLOR_STATE_ID_OKLAB,          gtk_rgb_to_oklab },
-  {  GDK_COLOR_STATE_ID_SRGB,            GDK_COLOR_STATE_ID_DISPLAY_P3,     gtk_rgb_to_p3 },
-  {  GDK_COLOR_STATE_ID_SRGB,            GDK_COLOR_STATE_ID_XYZ,            srgb_to_xyz },
-  {  GDK_COLOR_STATE_ID_SRGB_LINEAR,     GDK_COLOR_STATE_ID_SRGB,           gtk_linear_srgb_to_rgb },
-  {  GDK_COLOR_STATE_ID_SRGB_LINEAR,     GDK_COLOR_STATE_ID_OKLAB,          gtk_linear_srgb_to_oklab },
-  {  GDK_COLOR_STATE_ID_SRGB_LINEAR,     GDK_COLOR_STATE_ID_XYZ,            gtk_linear_srgb_to_xyz },
-  {  GDK_COLOR_STATE_ID_HSL,             GDK_COLOR_STATE_ID_SRGB,           gtk_hsl_to_rgb },
-  {  GDK_COLOR_STATE_ID_HSL,             GDK_COLOR_STATE_ID_XYZ,            hsl_to_xyz },
-  {  GDK_COLOR_STATE_ID_HWB,             GDK_COLOR_STATE_ID_SRGB,           gtk_hwb_to_rgb },
-  {  GDK_COLOR_STATE_ID_HWB,             GDK_COLOR_STATE_ID_XYZ,            hwb_to_xyz },
-  {  GDK_COLOR_STATE_ID_OKLAB,           GDK_COLOR_STATE_ID_SRGB,           gtk_oklab_to_rgb },
-  {  GDK_COLOR_STATE_ID_OKLAB,           GDK_COLOR_STATE_ID_SRGB_LINEAR,    gtk_oklab_to_linear_srgb },
-  {  GDK_COLOR_STATE_ID_OKLAB,           GDK_COLOR_STATE_ID_OKLCH,          gtk_oklab_to_oklch },
-  {  GDK_COLOR_STATE_ID_OKLAB,           GDK_COLOR_STATE_ID_XYZ,            oklab_to_xyz },
-  {  GDK_COLOR_STATE_ID_OKLCH,           GDK_COLOR_STATE_ID_OKLAB,          gtk_oklch_to_oklab },
-  {  GDK_COLOR_STATE_ID_OKLCH,           GDK_COLOR_STATE_ID_XYZ,            oklch_to_xyz },
-  {  GDK_COLOR_STATE_ID_DISPLAY_P3,      GDK_COLOR_STATE_ID_SRGB,           gtk_p3_to_rgb },
-  {  GDK_COLOR_STATE_ID_DISPLAY_P3,      GDK_COLOR_STATE_ID_XYZ,            p3_to_xyz },
-  {  GDK_COLOR_STATE_ID_XYZ,             GDK_COLOR_STATE_ID_SRGB,           xyz_to_srgb },
-  {  GDK_COLOR_STATE_ID_XYZ,             GDK_COLOR_STATE_ID_SRGB_LINEAR,    gtk_xyz_to_linear_srgb },
-  {  GDK_COLOR_STATE_ID_XYZ,             GDK_COLOR_STATE_ID_HSL,            xyz_to_hsl },
-  {  GDK_COLOR_STATE_ID_XYZ,             GDK_COLOR_STATE_ID_HWB,            xyz_to_hwb },
-  {  GDK_COLOR_STATE_ID_XYZ,             GDK_COLOR_STATE_ID_OKLAB,          xyz_to_oklab },
-  {  GDK_COLOR_STATE_ID_XYZ,             GDK_COLOR_STATE_ID_OKLCH,          xyz_to_oklch },
-  {  GDK_COLOR_STATE_ID_XYZ,             GDK_COLOR_STATE_ID_DISPLAY_P3,     xyz_to_p3 },
-  {  GDK_COLOR_STATE_ID_XYZ,             GDK_COLOR_STATE_ID_REC2020,        gtk_xyz_to_rec2020 },
-  {  GDK_COLOR_STATE_ID_XYZ,             GDK_COLOR_STATE_ID_REC2100_PQ,     xyz_to_rec2100_pq },
-  {  GDK_COLOR_STATE_ID_XYZ,             GDK_COLOR_STATE_ID_REC2100_LINEAR, xyz_to_rec2100_linear },
-  {  GDK_COLOR_STATE_ID_REC2020,         GDK_COLOR_STATE_ID_XYZ,            gtk_rec2020_to_xyz },
-  {  GDK_COLOR_STATE_ID_REC2100_PQ,      GDK_COLOR_STATE_ID_XYZ,            rec2100_pq_to_xyz },
-  {  GDK_COLOR_STATE_ID_REC2100_PQ,      GDK_COLOR_STATE_ID_REC2100_LINEAR, gtk_rec2100_pq_to_rec2100_linear },
-  {  GDK_COLOR_STATE_ID_REC2100_LINEAR,  GDK_COLOR_STATE_ID_REC2100_PQ,     gtk_rec2100_linear_to_rec2100_pq },
-  {  GDK_COLOR_STATE_ID_REC2100_LINEAR,  GDK_COLOR_STATE_ID_XYZ,            rec2100_linear_to_xyz },
-};
-
-static StepFunc
-find_function (GdkColorStateId n1, GdkColorStateId n2)
-{
-  for (int k = 0; k < G_N_ELEMENTS (functions); k++)
-    {
-      if (functions[k].n1 == n1 && functions[k].n2 == n2)
-        return functions[k].func;
-    }
-
-  return NULL;
-}
-
-void
-gdk_color_state_transform_init (GdkColorStateTransform *tf,
-                                GdkColorState          *from,
-                                GdkColorState          *to,
-                                gboolean                copy_alpha)
-{
-  memset (tf, 0, sizeof (GdkColorStateTransform));
-
-  if (GDK_IS_NAMED_COLOR_STATE (from) &&
-      GDK_IS_NAMED_COLOR_STATE (to))
-    {
-      tf->step1 = find_function (GDK_NAMED_COLOR_STATE_ID (from),
-                                 GDK_NAMED_COLOR_STATE_ID (to));
-      if (tf->step1 == NULL && from != to)
-        {
-          tf->step1 = find_function (GDK_NAMED_COLOR_STATE_ID (from),
-                                     GDK_COLOR_STATE_ID_XYZ);
-          tf->step2 = find_function (GDK_COLOR_STATE_ID_XYZ,
-                                     GDK_NAMED_COLOR_STATE_ID (to));
-        }
-    }
-  else
-    {
-      cmsHPROFILE profile1, profile2;
-
-      if (GDK_IS_LCMS_COLOR_STATE (from))
-        profile1 = gdk_lcms_color_state_get_lcms_profile (from);
-      else
-        profile1 = NULL;
-
-      if (GDK_IS_LCMS_COLOR_STATE (to))
-        profile2 = gdk_lcms_color_state_get_lcms_profile (to);
-      else
-        profile2 = NULL;
-
-      if (profile1 && profile2)
-        {
-          tf->transform = cmsCreateTransform (profile1,
-                                              TYPE_RGBA_FLT,
-                                              profile2,
-                                              TYPE_RGBA_FLT,
-                                              INTENT_PERCEPTUAL,
-                                              copy_alpha ? cmsFLAGS_COPY_ALPHA : 0);
-        }
-      else if (GDK_IS_NAMED_COLOR_STATE (from) && profile2)
-        {
-          tf->step1 = find_function (GDK_NAMED_COLOR_STATE_ID (from),
-                                     GDK_COLOR_STATE_ID_XYZ);
-
-          profile1 = cmsCreateXYZProfile ();
-          tf->transform = cmsCreateTransform (profile1,
-                                              TYPE_RGBA_FLT,
-                                              profile2,
-                                              TYPE_RGBA_FLT,
-                                              INTENT_PERCEPTUAL,
-                                              copy_alpha ? cmsFLAGS_COPY_ALPHA : 0);
-
-          tf->cms_first = FALSE;
-        }
-      else if (profile1 && GDK_IS_NAMED_COLOR_STATE (to))
-        {
-          profile2 = cmsCreateXYZProfile ();
-          tf->transform = cmsCreateTransform (profile1,
-                                              TYPE_RGBA_FLT,
-                                              profile2,
-                                              TYPE_RGBA_FLT,
-                                              INTENT_PERCEPTUAL,
-                                              copy_alpha ? cmsFLAGS_COPY_ALPHA : 0);
-
-          tf->step1 = find_function (GDK_COLOR_STATE_ID_XYZ,
-                                     GDK_NAMED_COLOR_STATE_ID (to));
-
-          tf->cms_first = TRUE;
-        }
-      else
-        g_assert_not_reached ();
-
-      g_clear_pointer (&profile1, cmsCloseProfile);
-      g_clear_pointer (&profile2, cmsCloseProfile);
-    }
-
-  tf->copy_alpha = copy_alpha;
-}
-
-void
-gdk_color_state_transform_finish (GdkColorStateTransform *tf)
-{
-  if (tf->transform)
-    cmsDeleteTransform (tf->transform);
-}
-
-void
-gdk_color_state_transform (GdkColorStateTransform *tf,
-                           const float            *src,
-                           float                  *dst,
-                           int                     width)
-{
-  if (tf->copy_alpha)
-    memcpy (dst, src, sizeof (float) * 4 * width);
-  else
-    {
-      for (int i = 0; i < width * 4; i += 4)
-        {
-          dst[i] = src[i];
-          dst[i + 1] = src[i + 1];
-          dst[i + 2] = src[i + 2];
-        }
-    }
-
-  if (tf->cms_first && tf->transform)
-    cmsDoTransform (tf->transform, dst, dst, width);
-
-  if (tf->step1 && tf->step2)
-    {
-      for (int i = 0; i < width * 4; i += 4)
-        {
-          tf->step1 (dst[i], dst[i+1], dst[i+2], &dst[i], &dst[i+1], &dst[i+2]);
-          tf->step2 (dst[i], dst[i+1], dst[i+2], &dst[i], &dst[i+1], &dst[i+2]);
-        }
-    }
-  else if (tf->step1)
-    {
-      for (int i = 0; i < width * 4; i += 4)
-        tf->step1 (dst[i], dst[i+1], dst[i+2], &dst[i], &dst[i+1], &dst[i+2]);
-    }
-
-  if (!tf->cms_first && tf->transform)
-    cmsDoTransform (tf->transform, dst, dst, width);
-}
-
-/* }}} */
-
-/* vim:set foldmethod=marker expandtab: */

gdk/gdkcolorstate.h

@@ -1,104 +0,0 @@
-/* gdkcolorstate.h
- *
- * Copyright 2024 Red Hat, Inc.
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this library. If not, see <http://www.gnu.org/licenses/>.
- */
-
-#pragma once
-
-#if !defined (__GDK_H_INSIDE__) && !defined (GTK_COMPILATION)
-#error "Only <gdk/gdk.h> can be included directly."
-#endif
-
-#include <gdk/gdktypes.h>
-
-G_BEGIN_DECLS
-
-#define GDK_TYPE_COLOR_STATE (gdk_color_state_get_type ())
-
-GDK_AVAILABLE_IN_4_16
-GType           gdk_color_state_get_type                (void) G_GNUC_CONST;
-
-GDK_AVAILABLE_IN_4_16
-GdkColorState * gdk_color_state_ref                     (GdkColorState  *self);
-
-GDK_AVAILABLE_IN_4_16
-void            gdk_color_state_unref                   (GdkColorState  *self);
-
-GDK_AVAILABLE_IN_4_16
-GdkColorState * gdk_color_state_get_srgb                (void);
-
-GDK_AVAILABLE_IN_4_16
-GdkColorState * gdk_color_state_get_srgb_linear         (void);
-
-GDK_AVAILABLE_IN_4_16
-GdkColorState * gdk_color_state_get_hsl                 (void);
-
-GDK_AVAILABLE_IN_4_16
-GdkColorState * gdk_color_state_get_hwb                 (void);
-
-GDK_AVAILABLE_IN_4_16
-GdkColorState * gdk_color_state_get_oklab               (void);
-
-GDK_AVAILABLE_IN_4_16
-GdkColorState * gdk_color_state_get_oklch               (void);
-
-GDK_AVAILABLE_IN_4_16
-GdkColorState * gdk_color_state_get_display_p3          (void);
-
-GDK_AVAILABLE_IN_4_16
-GdkColorState * gdk_color_state_get_xyz                 (void);
-
-GDK_AVAILABLE_IN_4_16
-GdkColorState * gdk_color_state_get_rec2020             (void);
-
-GDK_AVAILABLE_IN_4_16
-GdkColorState * gdk_color_state_get_rec2100_pq          (void);
-
-GDK_AVAILABLE_IN_4_16
-GdkColorState * gdk_color_state_get_rec2100_linear      (void);
-
-GDK_AVAILABLE_IN_4_16
-gboolean        gdk_color_state_equal                   (GdkColorState  *self,
-                                                         GdkColorState  *other);
-
-GDK_AVAILABLE_IN_4_16
-gboolean        gdk_color_state_is_linear               (GdkColorState  *self);
-
-GDK_AVAILABLE_IN_4_16
-GdkColorState * gdk_color_state_new_from_icc_profile    (GBytes         *icc_profile,
-                                                         GError        **error);
-
-GDK_AVAILABLE_IN_4_16
-GdkColorState * gdk_color_state_new_from_cicp_data      (int             color_primaries,
-                                                         int             transfer_characteristics,
-                                                         int             matrix_coefficients,
-                                                         gboolean        full_range);
-
-GDK_AVAILABLE_IN_4_16
-GBytes *        gdk_color_state_save_to_icc_profile     (GdkColorState  *self,
-                                                         GError        **error);
-
-GDK_AVAILABLE_IN_4_16
-gboolean        gdk_color_state_save_to_cicp_data       (GdkColorState  *self,
-                                                         int            *color_primaries,
-                                                         int            *transfer_characteristic,
-                                                         int            *matrix_coefficients,
-                                                         gboolean       *full_range,
-                                                         GError        **error);
-
-#include "gdkcolorstateimpl.h"
-
-G_END_DECLS

gdk/gdkcolorstateimpl.h

@@ -1,204 +0,0 @@
-/* gdkcolorstateimpl.h
- *
- * Copyright 2024 Red Hat, Inc.
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this library. If not, see <http://www.gnu.org/licenses/>.
- */
-
-#pragma once
-
-typedef enum
-{
-  GDK_COLOR_STATE_ID_SRGB           =  1,
-  GDK_COLOR_STATE_ID_SRGB_LINEAR    =  3,
-  GDK_COLOR_STATE_ID_HSL            =  5,
-  GDK_COLOR_STATE_ID_HWB            =  7,
-  GDK_COLOR_STATE_ID_OKLAB          =  9,
-  GDK_COLOR_STATE_ID_OKLCH          = 11,
-  GDK_COLOR_STATE_ID_DISPLAY_P3     = 13,
-  GDK_COLOR_STATE_ID_XYZ            = 15,
-  GDK_COLOR_STATE_ID_REC2020        = 17,
-  GDK_COLOR_STATE_ID_REC2100_PQ     = 19,
-  GDK_COLOR_STATE_ID_REC2100_LINEAR = 21,
-} GdkColorStateId;
-
-enum
-{
-  GDK_TYPE_NAMED_COLOR_STATE,
-  GDK_TYPE_LCMS_COLOR_STATE,
-};
-
-typedef struct _GdkColorStateClass GdkColorStateClass;
-
-struct _GdkColorState
-{
-  GdkColorStateClass *klass;
-  int ref_count;
-};
-
-struct _GdkColorStateClass
-{
-  int type;
-
-  void                  (* free)                (GdkColorState  *self);
-  gboolean              (* equal)               (GdkColorState  *self,
-                                                 GdkColorState  *other);
-  gboolean              (* is_linear)           (GdkColorState  *self);
-  GBytes *              (* save_to_icc_profile) (GdkColorState  *self,
-                                                 GError        **error);
-  gboolean              (* save_to_cicp_data)   (GdkColorState  *self,
-                                                 int            *color_primaries,
-                                                 int            *transfer_characteristics,
-                                                 int            *matrix_coefficients,
-                                                 gboolean       *full_range,
-                                                 GError        **error);
-  const char *          (* get_name)            (GdkColorState  *self);
-  guint                 (* get_min_depth)       (GdkColorState  *self);
-  int                   (* get_hue_coord)       (GdkColorState  *self);
-};
-
-#define GDK_NAMED_COLOR_STATE_ID(c) ((GdkColorStateId) (GPOINTER_TO_INT (c)))
-#define GDK_IS_NAMED_COLOR_STATE(c) ((GPOINTER_TO_INT(c)) & 1)
-#define GDK_IS_LCMS_COLOR_STATE(c) ((c)->klass->type == GDK_TYPE_LCMS_COLOR_STATE)
-
-#define gdk_color_state_ref(self) _gdk_color_state_ref (self)
-static inline GdkColorState *
-_gdk_color_state_ref (GdkColorState *self)
-{
-  if (GDK_IS_NAMED_COLOR_STATE (self))
-    return self;
-
-  self->ref_count++;
-
-  return self;
-}
-
-#define gdk_color_state_unref(self) _gdk_color_state_unref (self)
-static inline void
-_gdk_color_state_unref (GdkColorState *self)
-{
-  if (GDK_IS_NAMED_COLOR_STATE (self))
-    return;
-
-  self->ref_count--;
-
-  if (self->ref_count == 0)
-    self->klass->free (self);
-}
-
-#define GDK_COLOR_STATE_SRGB ((GdkColorState *) GINT_TO_POINTER (GDK_COLOR_STATE_ID_SRGB))
-#define GDK_COLOR_STATE_SRGB_LINEAR ((GdkColorState *) GINT_TO_POINTER (GDK_COLOR_STATE_ID_SRGB_LINEAR))
-#define GDK_COLOR_STATE_HSL ((GdkColorState *) GINT_TO_POINTER (GDK_COLOR_STATE_ID_HSL))
-#define GDK_COLOR_STATE_HWB ((GdkColorState *) GINT_TO_POINTER (GDK_COLOR_STATE_ID_HWB))
-#define GDK_COLOR_STATE_OKLAB ((GdkColorState *) GINT_TO_POINTER (GDK_COLOR_STATE_ID_OKLAB))
-#define GDK_COLOR_STATE_OKLCH ((GdkColorState *) GINT_TO_POINTER (GDK_COLOR_STATE_ID_OKLCH))
-#define GDK_COLOR_STATE_DISPLAY_P3 ((GdkColorState *) GINT_TO_POINTER (GDK_COLOR_STATE_ID_DISPLAY_P3))
-#define GDK_COLOR_STATE_XYZ ((GdkColorState *) GINT_TO_POINTER (GDK_COLOR_STATE_ID_XYZ))
-#define GDK_COLOR_STATE_REC2020 ((GdkColorState *) GINT_TO_POINTER (GDK_COLOR_STATE_ID_REC2020))
-#define GDK_COLOR_STATE_REC2100_PQ ((GdkColorState *) GINT_TO_POINTER (GDK_COLOR_STATE_ID_REC2100_PQ))
-#define GDK_COLOR_STATE_REC2100_LINEAR ((GdkColorState *) GINT_TO_POINTER (GDK_COLOR_STATE_ID_REC2100_LINEAR))
-
-#define gdk_color_state_get_srgb() _gdk_color_state_get_srgb ()
-static inline GdkColorState *
-_gdk_color_state_get_srgb (void)
-{
-  return GDK_COLOR_STATE_SRGB;
-}
-
-#define gdk_color_state_get_srgb_linear() _gdk_color_state_get_srgb_linear ()
-static inline GdkColorState *
-_gdk_color_state_get_srgb_linear (void)
-{
-  return GDK_COLOR_STATE_SRGB_LINEAR;
-}
-
-#define gdk_color_state_get_hsl() _gdk_color_state_get_hsl ()
-static inline GdkColorState *
-_gdk_color_state_get_hsl (void)
-{
-  return GDK_COLOR_STATE_HSL;
-}
-
-#define gdk_color_state_get_hwb() _gdk_color_state_get_hwb ()
-static inline GdkColorState *
-_gdk_color_state_get_hwb (void)
-{
-  return GDK_COLOR_STATE_HWB;
-}
-
-#define gdk_color_state_get_oklab() _gdk_color_state_get_oklab ()
-static inline GdkColorState *
-_gdk_color_state_get_oklab (void)
-{
-  return GDK_COLOR_STATE_OKLAB;
-}
-
-#define gdk_color_state_get_oklch() _gdk_color_state_get_oklch ()
-static inline GdkColorState *
-_gdk_color_state_get_oklch (void)
-{
-  return GDK_COLOR_STATE_OKLCH;
-}
-
-#define gdk_color_state_get_display_p3() _gdk_color_state_get_display_p3 ()
-static inline GdkColorState *
-_gdk_color_state_get_display_p3 (void)
-{
-  return GDK_COLOR_STATE_DISPLAY_P3;
-}
-
-#define gdk_color_state_get_xyz() _gdk_color_state_get_xyz ()
-static inline GdkColorState *
-_gdk_color_state_get_xyz (void)
-{
-  return GDK_COLOR_STATE_XYZ;
-}
-
-#define gdk_color_state_get_rec2020() _gdk_color_state_get_rec2020 ()
-static inline GdkColorState *
-_gdk_color_state_get_rec2020 (void)
-{
-  return GDK_COLOR_STATE_REC2020;
-}
-
-#define gdk_color_state_get_rec2100_pq() _gdk_color_state_get_rec2100_pq ()
-static inline GdkColorState *
-_gdk_color_state_get_rec2100_pq (void)
-{
-  return GDK_COLOR_STATE_REC2100_PQ;
-}
-
-#define gdk_color_state_get_rec2100_linear() _gdk_color_state_get_rec2100_linear ()
-static inline GdkColorState *
-_gdk_color_state_get_rec2100_linear (void)
-{
-  return GDK_COLOR_STATE_REC2100_LINEAR;
-}
-
-#define gdk_color_state_equal(a,b) _gdk_color_state_equal ((a), (b))
-static inline gboolean
-_gdk_color_state_equal (GdkColorState *self,
-                        GdkColorState *other)
-{
-  if (self == other)
-    return TRUE;
-
-  if (GDK_IS_NAMED_COLOR_STATE (self) || GDK_IS_NAMED_COLOR_STATE (other))
-    return FALSE;
-
-  if (self->klass != other->klass)
-    return FALSE;
-
-  return self->klass->equal (self, other);
-}

gdk/gdkcolorstateprivate.h

@@ -1,39 +0,0 @@
-#pragma once
-
-#include "gdkcolorstate.h"
-#include "gdkmemoryformatprivate.h"
-#include <lcms2.h>
-
-const char *   gdk_color_state_get_name      (GdkColorState *color_state);
-GdkMemoryDepth gdk_color_state_get_min_depth (GdkColorState *color_state);
-int            gdk_color_state_get_hue_coord (GdkColorState *color_state);
-
-typedef void (* StepFunc) (float  s0, float  s1, float  s2,
-                           float *d0, float *d1, float *d2);
-
-typedef struct _GdkColorStateTransform GdkColorStateTransform;
-
-struct _GdkColorStateTransform
-{
-  gpointer transform;
-  StepFunc step1;
-  StepFunc step2;
-  gboolean cms_first;
-  gboolean copy_alpha;
-};
-
-void gdk_color_state_transform_init (GdkColorStateTransform *tf,
-                                     GdkColorState           *from,
-                                     GdkColorState           *to,
-                                     gboolean                 copy_alpha);
-
-void gdk_color_state_transform_finish (GdkColorStateTransform *tf);
-
-void gdk_color_state_transform (GdkColorStateTransform *tf,
-                                const float            *src,
-                                float                  *dst,
-                                int                     width);
-
-GdkColorState *gdk_color_state_new_from_lcms_profile (cmsHPROFILE profile);
-
-const char *gdk_color_state_get_name_from_id (GdkColorStateId id);

gdk/gdkcontentdeserializer.c

@@ -540,6 +540,9 @@ deserialize_not_found (GdkContentDeserializer *deserializer)
  *
  * The default I/O priority is %G_PRIORITY_DEFAULT (i.e. 0), and lower numbers
  * indicate a higher priority.
+ *
+ * When the operation is finished, @callback will be called. You must then
+ * call [func@Gdk.content_deserialize_finish] to get the result of the operation.
  */
 void
 gdk_content_deserialize_async (GInputStream        *stream,

gdk/gdkcontentprovider.c

@@ -279,6 +279,10 @@ gdk_content_provider_content_changed (GdkContentProvider *provider)
  * Asynchronously writes the contents of @provider to @stream in the given
  * @mime_type.
  *
+ * When the operation is finished @callback will be called. You must then call
+ * [method@Gdk.ContentProvider.write_mime_type_finish] to get the result
+ * of the operation.
+ *
  * The given mime type does not need to be listed in the formats returned by
  * [method@Gdk.ContentProvider.ref_formats]. However, if the given `GType` is
  * not supported, `G_IO_ERROR_NOT_SUPPORTED` will be reported.

gdk/gdkcontentserializer.c

@@ -546,6 +546,9 @@ serialize_not_found (GdkContentSerializer *serializer)
  *
  * The default I/O priority is %G_PRIORITY_DEFAULT (i.e. 0), and lower numbers
  * indicate a higher priority.
+ *
+ * When the operation is finished, @callback will be called. You must then
+ * call [func@Gdk.content_serialize_finish] to get the result of the operation.
  */
 void
 gdk_content_serialize_async (GOutputStream       *stream,

gdk/gdkcursor.h

@@ -52,7 +52,7 @@ GdkCursor*  gdk_cursor_new_from_name     (const char      *name,
                                           GdkCursor       *fallback);
 
 /**
- * GdkCursorGetTextureCallback:
+ * GdkCursorGetTestureCallback:
  * @cursor: the `GdkCursor`
  * @cursor_size: the nominal cursor size, in application pixels
  * @scale: the device scale

gdk/gdkdebugprivate.h

@@ -40,7 +40,6 @@ typedef enum {
   GDK_DEBUG_OFFLOAD         = 1 << 12,
 
   /* flags below are influencing behavior */
-  GDK_DEBUG_SRGB            = 1 << 13,
   GDK_DEBUG_PORTALS         = 1 << 14,
   GDK_DEBUG_NO_PORTALS      = 1 << 15,
   GDK_DEBUG_GL_DISABLE      = 1 << 16,

gdk/gdkdmabuf.c

@@ -24,7 +24,6 @@
 #include "gdkdmabuffourccprivate.h"
 #include "gdkdmabuftextureprivate.h"
 #include "gdkmemoryformatprivate.h"
-#include "gdkcolorstate.h"
 
 #ifdef HAVE_DMABUF
 #include <sys/mman.h>
@@ -2063,15 +2062,12 @@ out:
 void
 gdk_dmabuf_download_mmap (GdkTexture      *texture,
                           GdkMemoryFormat  format,
-                          GdkColorState   *color_state,
                           guchar          *data,
                           gsize            stride)
 {
   GdkMemoryFormat src_format = gdk_texture_get_format (texture);
-  GdkColorState *src_color_state = gdk_texture_get_color_state (texture);
 
-  if (format == src_format &&
-      gdk_color_state_equal (color_state, src_color_state))
+  if (format == src_format)
     gdk_dmabuf_do_download_mmap (texture, data, stride);
   else
     {
@@ -2087,10 +2083,8 @@ gdk_dmabuf_download_mmap (GdkTexture      *texture,
 
       gdk_dmabuf_do_download_mmap (texture, src_data, src_stride);
 
-      gdk_memory_convert (data, stride,
-                          format, color_state,
-                          src_data, src_stride,
-                          src_format, src_color_state,
+      gdk_memory_convert (data, stride, format,
+                          src_data, src_stride, src_format,
                           width, height);
 
       g_free (src_data);

gdk/gdkdmabufdownloader.c

@@ -35,7 +35,6 @@ void
 gdk_dmabuf_downloader_download (GdkDmabufDownloader *self,
                                 GdkDmabufTexture    *texture,
                                 GdkMemoryFormat      format,
-                                GdkColorState       *color_state,
                                 guchar              *data,
                                 gsize                stride)
 {
@@ -44,6 +43,6 @@ gdk_dmabuf_downloader_download (GdkDmabufDownloader *self,
   g_return_if_fail (GDK_IS_DMABUF_DOWNLOADER (self));
 
   iface = GDK_DMABUF_DOWNLOADER_GET_IFACE (self);
-  iface->download (self, texture, format, color_state, data, stride);
+  iface->download (self, texture, format, data, stride);
 }
 

gdk/gdkdmabufdownloaderprivate.h

@@ -20,7 +20,6 @@ struct _GdkDmabufDownloaderInterface
   void                  (* download)                            (GdkDmabufDownloader            *downloader,
                                                                  GdkDmabufTexture               *texture,
                                                                  GdkMemoryFormat                 format,
-                                                                 GdkColorState                  *color_state,
                                                                  guchar                         *data,
                                                                  gsize                           stride);
 };
@@ -32,7 +31,6 @@ gboolean                gdk_dmabuf_downloader_supports          (GdkDmabufDownlo
 void                    gdk_dmabuf_downloader_download          (GdkDmabufDownloader            *downloader,
                                                                  GdkDmabufTexture               *texture,
                                                                  GdkMemoryFormat                 format,
-                                                                 GdkColorState                  *color_state,
                                                                  guchar                         *data,
                                                                  gsize                           stride);
 

gdk/gdkdmabufegl.c

@@ -163,8 +163,6 @@ gdk_dmabuf_get_egl_downloader (GdkDisplay              *display,
     return NULL;
 
   previous = gdk_gl_context_get_current ();
-  if (previous)
-    g_object_ref (previous);
   formats = gdk_dmabuf_formats_builder_new ();
   external = gdk_dmabuf_formats_builder_new ();
 
@@ -196,10 +194,7 @@ gdk_dmabuf_get_egl_downloader (GdkDisplay              *display,
     }
 
   if (previous)
-    {
-      gdk_gl_context_make_current (previous);
-      g_object_unref (previous);
-    }
+    gdk_gl_context_make_current (previous);
 
   return GDK_DMABUF_DOWNLOADER (renderer);
 }

gdk/gdkdmabufprivate.h

@@ -27,7 +27,6 @@ struct _GdkDmabuf
 GdkDmabufFormats *          gdk_dmabuf_get_mmap_formats         (void) G_GNUC_CONST;
 void                        gdk_dmabuf_download_mmap            (GdkTexture                     *texture,
                                                                  GdkMemoryFormat                 format,
-                                                                 GdkColorState                  *color_state,
                                                                  guchar                         *data,
                                                                  gsize                           stride);
 

gdk/gdkdmabuftexture.c

@@ -62,13 +62,6 @@ struct _GdkDmabufTextureClass
   GdkTextureClass parent_class;
 };
 
-/**
- * gdk_dmabuf_error_quark:
- *
- * Registers an error quark for [class@Gdk.DmabufTexture] errors.
- *
- * Returns: the error quark
- **/
 G_DEFINE_QUARK (gdk-dmabuf-error-quark, gdk_dmabuf_error)
 
 G_DEFINE_TYPE (GdkDmabufTexture, gdk_dmabuf_texture, GDK_TYPE_TEXTURE)
@@ -96,7 +89,6 @@ struct _Download
 {
   GdkDmabufTexture *texture;
   GdkMemoryFormat format;
-  GdkColorState *color_state;
   guchar *data;
   gsize stride;
   volatile int spinlock;
@@ -110,7 +102,6 @@ gdk_dmabuf_texture_invoke_callback (gpointer data)
   gdk_dmabuf_downloader_download (download->texture->downloader,
                                   download->texture,
                                   download->format,
-                                  download->color_state,
                                   download->data,
                                   download->stride);
 
@@ -122,17 +113,16 @@ gdk_dmabuf_texture_invoke_callback (gpointer data)
 static void
 gdk_dmabuf_texture_download (GdkTexture      *texture,
                              GdkMemoryFormat  format,
-                             GdkColorState   *color_state,
                              guchar          *data,
                              gsize            stride)
 {
   GdkDmabufTexture *self = GDK_DMABUF_TEXTURE (texture);
-  Download download = { self, format, color_state, data, stride, 0 };
+  Download download = { self, format, data, stride, 0 };
 
   if (self->downloader == NULL)
     {
 #ifdef HAVE_DMABUF
-      gdk_dmabuf_download_mmap (texture, format, color_state, data, stride);
+      gdk_dmabuf_download_mmap (texture, format, data, stride);
 #endif
       return;
     }
@@ -203,7 +193,6 @@ gdk_dmabuf_texture_new_from_builder (GdkDmabufTextureBuilder *builder,
   self = g_object_new (GDK_TYPE_DMABUF_TEXTURE,
                        "width", width,
                        "height", height,
-                       "color-state", gdk_dmabuf_texture_builder_get_color_state (builder),
                        NULL);
 
   g_set_object (&self->display, display);

gdk/gdkdmabuftexturebuilder.c

@@ -24,7 +24,6 @@
 #include "gdkdebugprivate.h"
 #include "gdkdisplay.h"
 #include "gdkenumtypes.h"
-#include "gdkcolorstate.h"
 #include "gdkdmabuftextureprivate.h"
 #include "gdkdmabuftexturebuilderprivate.h"
 
@@ -42,8 +41,6 @@ struct _GdkDmabufTextureBuilder
 
   GdkDmabuf dmabuf;
 
-  GdkColorState *color_state;
-
   GdkTexture *update_texture;
   cairo_region_t *update_region;
 };
@@ -127,7 +124,6 @@ enum
   PROP_MODIFIER,
   PROP_PREMULTIPLIED,
   PROP_N_PLANES,
-  PROP_COLOR_STATE,
   PROP_UPDATE_REGION,
   PROP_UPDATE_TEXTURE,
 
@@ -145,7 +141,6 @@ gdk_dmabuf_texture_builder_dispose (GObject *object)
 
   g_clear_object (&self->update_texture);
   g_clear_pointer (&self->update_region, cairo_region_destroy);
-  g_clear_pointer (&self->color_state, gdk_color_state_unref);
 
   G_OBJECT_CLASS (gdk_dmabuf_texture_builder_parent_class)->dispose (object);
 }
@@ -188,10 +183,6 @@ gdk_dmabuf_texture_builder_get_property (GObject    *object,
       g_value_set_uint (value, self->dmabuf.n_planes);
       break;
 
-    case PROP_COLOR_STATE:
-      g_value_set_boxed (value, self->color_state);
-      break;
-
     case PROP_UPDATE_REGION:
       g_value_set_boxed (value, self->update_region);
       break;
@@ -244,10 +235,6 @@ gdk_dmabuf_texture_builder_set_property (GObject      *object,
       gdk_dmabuf_texture_builder_set_n_planes (self, g_value_get_uint (value));
       break;
 
-    case PROP_COLOR_STATE:
-      gdk_dmabuf_texture_builder_set_color_state (self, g_value_get_boxed (value));
-      break;
-
     case PROP_UPDATE_REGION:
       gdk_dmabuf_texture_builder_set_update_region (self, g_value_get_boxed (value));
       break;
@@ -360,18 +347,6 @@ gdk_dmabuf_texture_builder_class_init (GdkDmabufTextureBuilderClass *klass)
                        1, GDK_DMABUF_MAX_PLANES, 1,
                        G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS);
 
-  /**
-   * GdkDmabufTextureBuilder:color-state: (attributes org.gtk.Property.get=gdk_dmabuf_texture_builder_get_color_state org.gtk.Property.set=gdk_dmabuf_texture_builder_set_color_state)
-   *
-   * The color state of the texture.
-   *
-   * Since: 4.16
-   */
-  properties[PROP_COLOR_STATE] =
-    g_param_spec_boxed ("color-state", NULL, NULL,
-                        GDK_TYPE_COLOR_STATE,
-                        G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS);
-
   /**
    * GdkDmabufTextureBuilder:update-region: (attributes org.gtk.Property.get=gdk_dmabuf_texture_builder_get_update_region org.gtk.Property.set=gdk_dmabuf_texture_builder_set_update_region)
    *
@@ -408,8 +383,6 @@ gdk_dmabuf_texture_builder_init (GdkDmabufTextureBuilder *self)
 
   for (int i = 0; i < GDK_DMABUF_MAX_PLANES; i++)
     self->dmabuf.planes[i].fd = -1;
-
-  self->color_state = gdk_color_state_get_srgb ();
 }
 
 /**
@@ -870,48 +843,6 @@ gdk_dmabuf_texture_builder_set_offset (GdkDmabufTextureBuilder *self,
   self->dmabuf.planes[plane].offset = offset;
 }
 
-/**
- * gdk_dmabuf_texture_builder_get_color_state: (attributes org.gtk.Method.get_property=color-state)
- * @self: a `GdkDmabufTextureBuilder`
- *
- * Gets the color state previously set via gdk_dmabuf_texture_builder_set_color_state().
- *
- * Returns: the color state
- *
- * Since: 4.16
- */
-GdkColorState *
-gdk_dmabuf_texture_builder_get_color_state (GdkDmabufTextureBuilder *self)
-{
-  g_return_val_if_fail (GDK_IS_DMABUF_TEXTURE_BUILDER (self), NULL);
-
-  return self->color_state;
-}
-
-/**
- * gdk_dmabuf_texture_builder_set_color_state: (attributes org.gtk.Method.set_property=color-state)
- * @self: a `GdkDmabufTextureBuilder`
- * @color_state: a `GdkColorState`
- *
- * Sets the color state for the texture.
- *
- * Since: 4.16
- */
-void
-gdk_dmabuf_texture_builder_set_color_state (GdkDmabufTextureBuilder *self,
-                                            GdkColorState           *color_state)
-{
-  g_return_if_fail (GDK_IS_DMABUF_TEXTURE_BUILDER (self));
-  g_return_if_fail (color_state != NULL);
-
-  if (self->color_state != color_state)
-    {
-      g_clear_pointer (&self->color_state, gdk_color_state_unref);
-      self->color_state = gdk_color_state_ref (color_state);
-      g_object_notify_by_pspec (G_OBJECT (self), properties[PROP_COLOR_STATE]);
-    }
-}
-
 /**
  * gdk_dmabuf_texture_builder_get_update_texture: (attributes org.gtk.Method.get_property=update-texture)
  * @self: a `GdkDmabufTextureBuilder`

gdk/gdkdmabuftexturebuilder.h

@@ -100,12 +100,6 @@ void                     gdk_dmabuf_texture_builder_set_offset       (GdkDmabufT
                                                                       unsigned int                plane,
                                                                       unsigned int                offset);
 
-GDK_AVAILABLE_IN_4_16
-GdkColorState *          gdk_dmabuf_texture_builder_get_color_state    (GdkDmabufTextureBuilder  *self);
-GDK_AVAILABLE_IN_4_16
-void                     gdk_dmabuf_texture_builder_set_color_state    (GdkDmabufTextureBuilder  *self,
-                                                                        GdkColorState            *color_state);
-
 GDK_AVAILABLE_IN_4_14
 GdkTexture *             gdk_dmabuf_texture_builder_get_update_texture (GdkDmabufTextureBuilder  *self) G_GNUC_PURE;
 GDK_AVAILABLE_IN_4_14

gdk/gdkdrop.c

@@ -134,7 +134,7 @@ gdk_drop_read_local_async (GdkDrop             *self,
 
   g_object_get (priv->drag, "content", &content, NULL);
   content_formats = gdk_content_provider_ref_formats (content);
-  g_object_unref (content);
+  g_object_unref (content); 
   content_formats = gdk_content_formats_union_serialize_mime_types (content_formats);
   mime_type = gdk_content_formats_match_mime_type (content_formats, formats);
 
@@ -784,7 +784,7 @@ gdk_drop_read_value_internal (GdkDrop             *self,
   GdkContentFormats *formats;
   GValue *value;
   GTask *task;
-
+ 
   g_return_if_fail (priv->state != GDK_DROP_STATE_FINISHED);
 
   task = g_task_new (self, cancellable, callback, user_data);
@@ -849,6 +849,10 @@ gdk_drop_read_value_internal (GdkDrop             *self,
  * Asynchronously request the drag operation's contents converted
  * to the given @type.
  *
+ * When the operation is finished @callback will be called. You must
+ * then call [method@Gdk.Drop.read_value_finish] to get the resulting
+ * `GValue`.
+ *
  * For local drag-and-drop operations that are available in the given
  * `GType`, the value will be copied directly. Otherwise, GDK will
  * try to use [func@Gdk.content_deserialize_async] to convert the data.

gdk/gdkevents.c

@@ -1371,8 +1371,6 @@ gdk_event_get_modifier_state (GdkEvent *event)
  * Extract the event surface relative x/y coordinates from an event.
  *
  * This position is in [surface coordinates](coordinates.html).
- *
- * Returns: whether the positions were set
  */
 gboolean
 gdk_event_get_position (GdkEvent *event,

gdk/gdkglcontext.c

@@ -152,13 +152,6 @@ enum {
 
 static GParamSpec *properties[LAST_PROP] = { NULL, };
 
-/**
- * gdk_gl_error_quark:
- *
- * Registers an error quark for [class@Gdk.GLContext] errors.
- *
- * Returns: the error quark
- **/
 G_DEFINE_QUARK (gdk-gl-error-quark, gdk_gl_error)
 
 G_DEFINE_ABSTRACT_TYPE_WITH_PRIVATE (GdkGLContext, gdk_gl_context, GDK_TYPE_DRAW_CONTEXT)
@@ -1963,6 +1956,8 @@ gdk_gl_context_get_glsl_version_string (GdkGLContext *self)
         return "#version 310 es";
       else if (gdk_gl_version_greater_equal (&priv->gl_version, &GDK_GL_VERSION_INIT (3, 0)))
         return "#version 300 es";
+      else if (gdk_gl_version_greater_equal (&priv->gl_version, &GDK_GL_VERSION_INIT (3, 0)))
+        return "#version 300 es";
       else
         return "#version 100";
     }

gdk/gdkgltexture.c

@@ -24,7 +24,6 @@
 #include "gdkglcontextprivate.h"
 #include "gdkmemoryformatprivate.h"
 #include "gdkmemorytextureprivate.h"
-#include "gdkcolorstate.h"
 
 #include <epoxy/gl.h>
 
@@ -137,7 +136,6 @@ typedef struct _Download Download;
 struct _Download
 {
   GdkMemoryFormat format;
-  GdkColorState *color_state;
   guchar *data;
   gsize stride;
 };
@@ -187,15 +185,13 @@ gdk_gl_texture_do_download (GdkGLTexture *self,
 {
   GdkTexture *texture = GDK_TEXTURE (self);
   GdkMemoryFormat format;
-  GdkColorState *color_state;
   gsize expected_stride;
   Download *download = download_;
   GLint gl_internal_format;
   GLenum gl_format, gl_type;
   GLint gl_swizzle[4];
 
-  format = gdk_texture_get_format (texture);
-  color_state = gdk_texture_get_color_state (texture);
+  format = gdk_texture_get_format (texture),
   expected_stride = texture->width * gdk_memory_format_bytes_per_pixel (download->format);
 
   if (!gdk_gl_context_get_use_es (context) &&
@@ -229,11 +225,9 @@ gdk_gl_texture_do_download (GdkGLTexture *self,
           gdk_memory_convert (download->data,
                               download->stride,
                               download->format,
-                              download->color_state,
                               pixels,
                               stride,
                               format,
-                              color_state,
                               texture->width,
                               texture->height);
 
@@ -383,11 +377,9 @@ gdk_gl_texture_do_download (GdkGLTexture *self,
           gdk_memory_convert (download->data,
                               download->stride,
                               download->format,
-                              download->color_state,
                               pixels,
                               stride,
                               actual_format,
-                              color_state,
                               texture->width,
                               texture->height);
 
@@ -401,7 +393,6 @@ gdk_gl_texture_do_download (GdkGLTexture *self,
 static void
 gdk_gl_texture_download (GdkTexture      *texture,
                          GdkMemoryFormat  format,
-                         GdkColorState   *color_state,
                          guchar          *data,
                          gsize            stride)
 {
@@ -410,12 +401,11 @@ gdk_gl_texture_download (GdkTexture      *texture,
 
   if (self->saved)
     {
-      gdk_texture_do_download (self->saved, format, color_state, data, stride);
+      gdk_texture_do_download (self->saved, format, data, stride);
       return;
     }
 
   download.format = format;
-  download.color_state = color_state;
   download.data = data;
   download.stride = stride;
 
@@ -481,7 +471,8 @@ gdk_gl_texture_release (GdkGLTexture *self)
   g_return_if_fail (self->saved == NULL);
 
   texture = GDK_TEXTURE (self);
-  self->saved = GDK_TEXTURE (gdk_memory_texture_from_texture (texture));
+  self->saved = GDK_TEXTURE (gdk_memory_texture_from_texture (texture,
+                                                              gdk_texture_get_format (texture)));
 
   drop_gl_resources (self);
 }
@@ -497,7 +488,6 @@ gdk_gl_texture_new_from_builder (GdkGLTextureBuilder *builder,
   self = g_object_new (GDK_TYPE_GL_TEXTURE,
                        "width", gdk_gl_texture_builder_get_width (builder),
                        "height", gdk_gl_texture_builder_get_height (builder),
-                       "color-state", gdk_gl_texture_builder_get_color_state (builder),
                        NULL);
 
   self->context = g_object_ref (gdk_gl_texture_builder_get_context (builder));

gdk/gdkgltexturebuilder.c

@@ -23,7 +23,6 @@
 
 #include "gdkenumtypes.h"
 #include "gdkglcontext.h"
-#include "gdkcolorstate.h"
 #include "gdkgltextureprivate.h"
 
 #include <cairo-gobject.h>
@@ -39,7 +38,6 @@ struct _GdkGLTextureBuilder
   GdkMemoryFormat format;
   gboolean has_mipmap;
   gpointer sync;
-  GdkColorState *color_state;
 
   GdkTexture *update_texture;
   cairo_region_t *update_region;
@@ -77,7 +75,6 @@ enum
   PROP_HEIGHT,
   PROP_ID,
   PROP_SYNC,
-  PROP_COLOR_STATE,
   PROP_UPDATE_REGION,
   PROP_UPDATE_TEXTURE,
   PROP_WIDTH,
@@ -98,7 +95,6 @@ gdk_gl_texture_builder_dispose (GObject *object)
 
   g_clear_object (&self->update_texture);
   g_clear_pointer (&self->update_region, cairo_region_destroy);
-  g_clear_pointer (&self->color_state, gdk_color_state_unref);
 
   G_OBJECT_CLASS (gdk_gl_texture_builder_parent_class)->dispose (object);
 }
@@ -137,10 +133,6 @@ gdk_gl_texture_builder_get_property (GObject    *object,
       g_value_set_pointer (value, self->sync);
       break;
 
-    case PROP_COLOR_STATE:
-      g_value_set_object (value, self->color_state);
-      break;
-
     case PROP_UPDATE_REGION:
       g_value_set_boxed (value, self->update_region);
       break;
@@ -193,10 +185,6 @@ gdk_gl_texture_builder_set_property (GObject      *object,
       gdk_gl_texture_builder_set_sync (self, g_value_get_pointer (value));
       break;
 
-    case PROP_COLOR_STATE:
-      gdk_gl_texture_builder_set_color_state (self, g_value_get_object (value));
-      break;
-
     case PROP_UPDATE_REGION:
       gdk_gl_texture_builder_set_update_region (self, g_value_get_boxed (value));
       break;
@@ -298,18 +286,6 @@ gdk_gl_texture_builder_class_init (GdkGLTextureBuilderClass *klass)
     g_param_spec_pointer ("sync", NULL, NULL,
                           G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS);
 
-  /**
-   * GdkGLTextureBuilder:color-state: (attributes org.gtk.Property.get=gdk_gl_texture_builder_get_color_state org.gtk.Property.set=gdk_gl_texture_builder_set_color_state)
-   *
-   * The color state of the texture.
-   *
-   * Since: 4.16
-   */
-  properties[PROP_COLOR_STATE] =
-    g_param_spec_boxed ("color-state", NULL, NULL,
-                        GDK_TYPE_COLOR_STATE,
-                        G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS);
-
   /**
    * GdkGLTextureBuilder:update-region: (attributes org.gtk.Property.get=gdk_gl_texture_builder_get_update_region org.gtk.Property.set=gdk_gl_texture_builder_set_update_region)
    *
@@ -353,7 +329,6 @@ static void
 gdk_gl_texture_builder_init (GdkGLTextureBuilder *self)
 {
   self->format = GDK_MEMORY_R8G8B8A8_PREMULTIPLIED;
-  self->color_state = gdk_color_state_get_srgb ();
 }
 
 /**
@@ -641,48 +616,6 @@ gdk_gl_texture_builder_set_sync (GdkGLTextureBuilder *self,
   g_object_notify_by_pspec (G_OBJECT (self), properties[PROP_SYNC]);
 }
 
-/**
- * gdk_gl_texture_builder_get_color_state: (attributes org.gtk.Method.get_property=color-state)
- * @self: a `GdkGLTextureBuilder`
- *
- * Gets the color state previously set via gdk_gl_texture_builder_set_color_state().
- *
- * Returns: the color state
- *
- * Since: 4.16
- */
-GdkColorState *
-gdk_gl_texture_builder_get_color_state (GdkGLTextureBuilder *self)
-{
-  g_return_val_if_fail (GDK_IS_GL_TEXTURE_BUILDER (self), NULL);
-
-  return self->color_state;
-}
-
-/**
- * gdk_gl_texture_builder_set_color_state: (attributes org.gtk.Method.set_property=color-state)
- * @self: a `GdkGLTextureBuilder`
- * @color_state: a `GdkColorState`
- *
- * Sets the color state for the texture.
- *
- * Since: 4.16
- */
-void
-gdk_gl_texture_builder_set_color_state (GdkGLTextureBuilder *self,
-                                        GdkColorState       *color_state)
-{
-  g_return_if_fail (GDK_IS_GL_TEXTURE_BUILDER (self));
-  g_return_if_fail (color_state != NULL);
-
-  if (self->color_state != color_state)
-    {
-      g_clear_pointer (&self->color_state, gdk_color_state_unref);
-      self->color_state = gdk_color_state_ref (color_state);
-      g_object_notify_by_pspec (G_OBJECT (self), properties[PROP_COLOR_STATE]);
-    }
-}
-
 /**
  * gdk_gl_texture_builder_get_format: (attributes org.gtk.Method.get_property=format)
  * @self: a `GdkGLTextureBuilder`

gdk/gdkgltexturebuilder.h

@@ -76,12 +76,6 @@ GDK_AVAILABLE_IN_4_12
 void                    gdk_gl_texture_builder_set_sync         (GdkGLTextureBuilder    *self,
                                                                  gpointer                sync);
 
-GDK_AVAILABLE_IN_4_16
-GdkColorState *         gdk_gl_texture_builder_get_color_state  (GdkGLTextureBuilder    *self);
-GDK_AVAILABLE_IN_4_16
-void                    gdk_gl_texture_builder_set_color_state  (GdkGLTextureBuilder    *self,
-                                                                 GdkColorState          *color_state);
-
 GDK_AVAILABLE_IN_4_12
 GdkTexture *            gdk_gl_texture_builder_get_update_texture (GdkGLTextureBuilder  *self) G_GNUC_PURE;
 GDK_AVAILABLE_IN_4_12

gdk/gdkmemoryformat.c

@@ -23,9 +23,8 @@
 
 #include "gdkdmabuffourccprivate.h"
 #include "gdkglcontextprivate.h"
-#include "gdkcolorstateprivate.h"
+
 #include "gsk/gl/fp16private.h"
-#include "gtk/gtkcolorutilsprivate.h"
 
 #include <epoxy/gl.h>
 
@@ -328,7 +327,6 @@ ADD_ALPHA_FUNC(r8g8b8_to_a8b8g8r8, 0, 1, 2, 3, 2, 1, 0)
 
 struct _GdkMemoryFormatDescription
 {
-  const char *name;
   GdkMemoryAlpha alpha;
   GdkMemoryFormat premultiplied;
   GdkMemoryFormat straight;
@@ -368,7 +366,6 @@ struct _GdkMemoryFormatDescription
 
 static const GdkMemoryFormatDescription memory_formats[] = {
   [GDK_MEMORY_B8G8R8A8_PREMULTIPLIED] = {
-    .name = "*BGRA8",
     .alpha = GDK_MEMORY_ALPHA_PREMULTIPLIED,
     .premultiplied = GDK_MEMORY_B8G8R8A8_PREMULTIPLIED,
     .straight = GDK_MEMORY_B8G8R8A8,
@@ -397,7 +394,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = b8g8r8a8_premultiplied_from_float,
   },
   [GDK_MEMORY_A8R8G8B8_PREMULTIPLIED] = {
-    .name = "*ARGB8",
     .alpha = GDK_MEMORY_ALPHA_PREMULTIPLIED,
     .premultiplied = GDK_MEMORY_A8R8G8B8_PREMULTIPLIED,
     .straight = GDK_MEMORY_A8R8G8B8,
@@ -426,7 +422,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = a8r8g8b8_premultiplied_from_float,
   },
   [GDK_MEMORY_R8G8B8A8_PREMULTIPLIED] = {
-    .name = "*RGBA8",
     .alpha = GDK_MEMORY_ALPHA_PREMULTIPLIED,
     .premultiplied = GDK_MEMORY_R8G8B8A8_PREMULTIPLIED,
     .straight = GDK_MEMORY_R8G8B8A8,
@@ -454,7 +449,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = r8g8b8a8_premultiplied_from_float,
   },
   [GDK_MEMORY_A8B8G8R8_PREMULTIPLIED] = {
-    .name = "*ABGR8",
     .alpha = GDK_MEMORY_ALPHA_PREMULTIPLIED,
     .premultiplied = GDK_MEMORY_A8B8G8R8_PREMULTIPLIED,
     .straight = GDK_MEMORY_A8B8G8R8,
@@ -483,7 +477,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = a8b8g8r8_premultiplied_from_float,
   },
   [GDK_MEMORY_B8G8R8A8] = {
-    .name = "BGRA8",
     .alpha = GDK_MEMORY_ALPHA_STRAIGHT,
     .premultiplied = GDK_MEMORY_B8G8R8A8_PREMULTIPLIED,
     .straight = GDK_MEMORY_B8G8R8A8,
@@ -512,7 +505,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = b8g8r8a8_from_float,
   },
   [GDK_MEMORY_A8R8G8B8] = {
-    .name = "ARGB8",
     .alpha = GDK_MEMORY_ALPHA_STRAIGHT,
     .premultiplied = GDK_MEMORY_A8R8G8B8_PREMULTIPLIED,
     .straight = GDK_MEMORY_A8R8G8B8,
@@ -541,7 +533,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = a8r8g8b8_from_float,
   },
   [GDK_MEMORY_R8G8B8A8] = {
-    .name = "RGBA8",
     .alpha = GDK_MEMORY_ALPHA_STRAIGHT,
     .premultiplied = GDK_MEMORY_R8G8B8A8_PREMULTIPLIED,
     .straight = GDK_MEMORY_R8G8B8A8,
@@ -569,7 +560,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = r8g8b8a8_from_float,
   },
   [GDK_MEMORY_A8B8G8R8] = {
-    .name = "ABGR8",
     .alpha = GDK_MEMORY_ALPHA_STRAIGHT,
     .premultiplied = GDK_MEMORY_A8B8G8R8_PREMULTIPLIED,
     .straight = GDK_MEMORY_A8B8G8R8,
@@ -598,7 +588,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = a8b8g8r8_from_float,
   },
   [GDK_MEMORY_B8G8R8X8] = {
-    .name = "BGRX8",
     .alpha = GDK_MEMORY_ALPHA_OPAQUE,
     .premultiplied = GDK_MEMORY_B8G8R8X8,
     .straight = GDK_MEMORY_B8G8R8X8,
@@ -628,7 +617,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = b8g8r8x8_from_float,
   },
   [GDK_MEMORY_X8R8G8B8] = {
-    .name = "XRGB8",
     .alpha = GDK_MEMORY_ALPHA_OPAQUE,
     .premultiplied = GDK_MEMORY_X8R8G8B8,
     .straight = GDK_MEMORY_X8R8G8B8,
@@ -658,7 +646,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = x8r8g8b8_from_float,
   },
   [GDK_MEMORY_R8G8B8X8] = {
-    .name = "RGBX8",
     .alpha = GDK_MEMORY_ALPHA_OPAQUE,
     .premultiplied = GDK_MEMORY_R8G8B8X8,
     .straight = GDK_MEMORY_R8G8B8X8,
@@ -687,7 +674,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = r8g8b8x8_from_float,
   },
   [GDK_MEMORY_X8B8G8R8] = {
-    .name = "XBGR8",
     .alpha = GDK_MEMORY_ALPHA_OPAQUE,
     .premultiplied = GDK_MEMORY_X8B8G8R8,
     .straight = GDK_MEMORY_X8B8G8R8,
@@ -717,7 +703,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = x8b8g8r8_from_float,
   },
   [GDK_MEMORY_R8G8B8] = {
-    .name = "RGB8",
     .alpha = GDK_MEMORY_ALPHA_OPAQUE,
     .premultiplied = GDK_MEMORY_R8G8B8,
     .straight = GDK_MEMORY_R8G8B8,
@@ -746,7 +731,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = r8g8b8_from_float,
   },
   [GDK_MEMORY_B8G8R8] = {
-    .name = "BGR8",
     .alpha = GDK_MEMORY_ALPHA_OPAQUE,
     .premultiplied = GDK_MEMORY_B8G8R8,
     .straight = GDK_MEMORY_B8G8R8,
@@ -776,7 +760,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = b8g8r8_from_float,
   },
   [GDK_MEMORY_R16G16B16] = {
-    .name = "RGB16",
     .alpha = GDK_MEMORY_ALPHA_OPAQUE,
     .premultiplied = GDK_MEMORY_R16G16B16,
     .straight = GDK_MEMORY_R16G16B16,
@@ -808,7 +791,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = r16g16b16_from_float,
   },
   [GDK_MEMORY_R16G16B16A16_PREMULTIPLIED] = {
-    .name = "*RGBA16",
     .alpha = GDK_MEMORY_ALPHA_PREMULTIPLIED,
     .premultiplied = GDK_MEMORY_R16G16B16A16_PREMULTIPLIED,
     .straight = GDK_MEMORY_R16G16B16A16,
@@ -839,7 +821,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = r16g16b16a16_from_float,
   },
   [GDK_MEMORY_R16G16B16A16] = {
-    .name = "RGBA16",
     .alpha = GDK_MEMORY_ALPHA_STRAIGHT,
     .premultiplied = GDK_MEMORY_R16G16B16A16_PREMULTIPLIED,
     .straight = GDK_MEMORY_R16G16B16A16,
@@ -870,7 +851,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = r16g16b16a16_from_float,
   },
   [GDK_MEMORY_R16G16B16_FLOAT] = {
-    .name = "RGBA16f",
     .alpha = GDK_MEMORY_ALPHA_OPAQUE,
     .premultiplied = GDK_MEMORY_R16G16B16_FLOAT,
     .straight = GDK_MEMORY_R16G16B16_FLOAT,
@@ -901,7 +881,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = r16g16b16_float_from_float,
   },
   [GDK_MEMORY_R16G16B16A16_FLOAT_PREMULTIPLIED] = {
-    .name = "*RGBA16f",
     .alpha = GDK_MEMORY_ALPHA_PREMULTIPLIED,
     .premultiplied = GDK_MEMORY_R16G16B16A16_FLOAT_PREMULTIPLIED,
     .straight = GDK_MEMORY_R16G16B16A16_FLOAT,
@@ -931,7 +910,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = r16g16b16a16_float_from_float,
   },
   [GDK_MEMORY_R16G16B16A16_FLOAT] = {
-    .name = "RGBA16f",
     .alpha = GDK_MEMORY_ALPHA_STRAIGHT,
     .premultiplied = GDK_MEMORY_R16G16B16A16_FLOAT_PREMULTIPLIED,
     .straight = GDK_MEMORY_R16G16B16A16_FLOAT,
@@ -961,7 +939,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = r16g16b16a16_float_from_float,
   },
   [GDK_MEMORY_R32G32B32_FLOAT] = {
-    .name = "RGB32f",
     .alpha = GDK_MEMORY_ALPHA_OPAQUE,
     .premultiplied = GDK_MEMORY_R32G32B32_FLOAT,
     .straight = GDK_MEMORY_R32G32B32_FLOAT,
@@ -992,7 +969,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = r32g32b32_float_from_float,
   },
   [GDK_MEMORY_R32G32B32A32_FLOAT_PREMULTIPLIED] = {
-    .name = "*RGBA32f",
     .alpha = GDK_MEMORY_ALPHA_PREMULTIPLIED,
     .premultiplied = GDK_MEMORY_R32G32B32A32_FLOAT_PREMULTIPLIED,
     .straight = GDK_MEMORY_R32G32B32A32_FLOAT,
@@ -1022,7 +998,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = r32g32b32a32_float_from_float,
   },
   [GDK_MEMORY_R32G32B32A32_FLOAT] = {
-    .name = "RGBA32f",
     .alpha = GDK_MEMORY_ALPHA_STRAIGHT,
     .premultiplied = GDK_MEMORY_R32G32B32A32_FLOAT_PREMULTIPLIED,
     .straight = GDK_MEMORY_R32G32B32A32_FLOAT,
@@ -1052,7 +1027,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = r32g32b32a32_float_from_float,
   },
   [GDK_MEMORY_G8A8_PREMULTIPLIED] = {
-    .name = "*GA8",
     .alpha = GDK_MEMORY_ALPHA_PREMULTIPLIED,
     .premultiplied = GDK_MEMORY_G8A8_PREMULTIPLIED,
     .straight = GDK_MEMORY_G8A8,
@@ -1081,7 +1055,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = g8a8_premultiplied_from_float,
   },
   [GDK_MEMORY_G8A8] = {
-    .name = "GA8",
     .alpha = GDK_MEMORY_ALPHA_STRAIGHT,
     .premultiplied = GDK_MEMORY_G8A8_PREMULTIPLIED,
     .straight = GDK_MEMORY_G8A8,
@@ -1110,7 +1083,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = g8a8_from_float,
   },
   [GDK_MEMORY_G8] = {
-    .name = "G8",
     .alpha = GDK_MEMORY_ALPHA_OPAQUE,
     .premultiplied = GDK_MEMORY_G8,
     .straight = GDK_MEMORY_G8,
@@ -1139,7 +1111,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = g8_from_float,
   },
   [GDK_MEMORY_G16A16_PREMULTIPLIED] = {
-    .name = "*GA16",
     .alpha = GDK_MEMORY_ALPHA_PREMULTIPLIED,
     .premultiplied = GDK_MEMORY_G16A16_PREMULTIPLIED,
     .straight = GDK_MEMORY_G16A16,
@@ -1171,7 +1142,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = g16a16_premultiplied_from_float,
   },
   [GDK_MEMORY_G16A16] = {
-    .name = "GA16",
     .alpha = GDK_MEMORY_ALPHA_STRAIGHT,
     .premultiplied = GDK_MEMORY_G16A16_PREMULTIPLIED,
     .straight = GDK_MEMORY_G16A16,
@@ -1203,7 +1173,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = g16a16_from_float,
   },
   [GDK_MEMORY_G16] = {
-    .name = "G16",
     .alpha = GDK_MEMORY_ALPHA_OPAQUE,
     .premultiplied = GDK_MEMORY_G16,
     .straight = GDK_MEMORY_G16,
@@ -1235,7 +1204,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = g16_from_float,
   },
   [GDK_MEMORY_A8] = {
-    .name = "A8",
     .alpha = GDK_MEMORY_ALPHA_PREMULTIPLIED,
     .premultiplied = GDK_MEMORY_A8,
     .straight = GDK_MEMORY_A8,
@@ -1264,7 +1232,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = a8_from_float,
   },
   [GDK_MEMORY_A16] = {
-    .name = "A16",
     .alpha = GDK_MEMORY_ALPHA_PREMULTIPLIED,
     .premultiplied = GDK_MEMORY_A16,
     .straight = GDK_MEMORY_A16,
@@ -1296,7 +1263,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = a16_from_float,
   },
   [GDK_MEMORY_A16_FLOAT] = {
-    .name = "A16f",
     .alpha = GDK_MEMORY_ALPHA_PREMULTIPLIED,
     .premultiplied = GDK_MEMORY_A16_FLOAT,
     .straight = GDK_MEMORY_A16_FLOAT,
@@ -1327,7 +1293,6 @@ static const GdkMemoryFormatDescription memory_formats[] = {
     .from_float = a16_float_from_float,
   },
   [GDK_MEMORY_A32_FLOAT] = {
-    .name = "A32f",
     .alpha = GDK_MEMORY_ALPHA_PREMULTIPLIED,
     .premultiplied = GDK_MEMORY_A32_FLOAT,
     .straight = GDK_MEMORY_A32_FLOAT,
@@ -1696,12 +1661,6 @@ gdk_memory_format_get_dmabuf_fourcc (GdkMemoryFormat format)
 #endif
 }
 
-const char *
-gdk_memory_format_get_name (GdkMemoryFormat format)
-{
-  return memory_formats[format].name;
-}
-
 static void
 premultiply (float *rgba,
              gsize  n)
@@ -1735,18 +1694,14 @@ void
 gdk_memory_convert (guchar              *dest_data,
                     gsize                dest_stride,
                     GdkMemoryFormat      dest_format,
-                    GdkColorState       *dest_color_state,
                     const guchar        *src_data,
                     gsize                src_stride,
                     GdkMemoryFormat      src_format,
-                    GdkColorState       *src_color_state,
                     gsize                width,
                     gsize                height)
 {
   const GdkMemoryFormatDescription *dest_desc = &memory_formats[dest_format];
   const GdkMemoryFormatDescription *src_desc = &memory_formats[src_format];
-  GdkColorStateTransform transform;
-  gboolean has_transform;
   float *tmp;
   gsize y;
   void (*func) (guchar *, const guchar *, gsize) = NULL;
@@ -1754,8 +1709,7 @@ gdk_memory_convert (guchar              *dest_data,
   g_assert (dest_format < GDK_MEMORY_N_FORMATS);
   g_assert (src_format < GDK_MEMORY_N_FORMATS);
 
-  if (gdk_color_state_equal (src_color_state, dest_color_state) &&
-      src_format == dest_format)
+  if (src_format == dest_format)
     {
       gsize bytes_per_row = src_desc->bytes_per_pixel * width;
 
@@ -1775,9 +1729,7 @@ gdk_memory_convert (guchar              *dest_data,
       return;
     }
 
-  if (!gdk_color_state_equal (src_color_state, dest_color_state))
-    func = NULL;
-  else if (src_format == GDK_MEMORY_R8G8B8A8 && dest_format == GDK_MEMORY_R8G8B8A8_PREMULTIPLIED)
+  if (src_format == GDK_MEMORY_R8G8B8A8 && dest_format == GDK_MEMORY_R8G8B8A8_PREMULTIPLIED)
     func = r8g8b8a8_to_r8g8b8a8_premultiplied;
   else if (src_format == GDK_MEMORY_B8G8R8A8 && dest_format == GDK_MEMORY_R8G8B8A8_PREMULTIPLIED)
     func = r8g8b8a8_to_b8g8r8a8_premultiplied;
@@ -1825,43 +1777,19 @@ gdk_memory_convert (guchar              *dest_data,
       return;
     }
 
-  if (!gdk_color_state_equal (src_color_state, dest_color_state))
-    {
-      gdk_color_state_transform_init (&transform, src_color_state, dest_color_state, TRUE);
-      has_transform = TRUE;
-    }
-  else
-    {
-      has_transform = FALSE;
-    }
-
   tmp = g_new (float, width * 4);
 
   for (y = 0; y < height; y++)
     {
       src_desc->to_float (tmp, src_data, width);
-      if (has_transform)
-        {
-          if (src_desc->alpha == GDK_MEMORY_ALPHA_PREMULTIPLIED)
-            unpremultiply (tmp, width);
-          gdk_color_state_transform (&transform, tmp, tmp, width);
-          if (dest_desc->alpha != GDK_MEMORY_ALPHA_STRAIGHT)
-            premultiply (tmp, width);
-        }
-      else
-        {
-          if (src_desc->alpha == GDK_MEMORY_ALPHA_PREMULTIPLIED && dest_desc->alpha == GDK_MEMORY_ALPHA_STRAIGHT)
-            unpremultiply (tmp, width);
-          else if (src_desc->alpha == GDK_MEMORY_ALPHA_STRAIGHT && dest_desc->alpha != GDK_MEMORY_ALPHA_STRAIGHT)
-            premultiply (tmp, width);
-        }
+      if (src_desc->alpha == GDK_MEMORY_ALPHA_PREMULTIPLIED && dest_desc->alpha == GDK_MEMORY_ALPHA_STRAIGHT)
+        unpremultiply (tmp, width);
+      else if (src_desc->alpha == GDK_MEMORY_ALPHA_STRAIGHT && dest_desc->alpha != GDK_MEMORY_ALPHA_STRAIGHT)
+        premultiply (tmp, width);
       dest_desc->from_float (dest_data, tmp, width);
       src_data += src_stride;
       dest_data += dest_stride;
     }
 
-  if (has_transform)
-    gdk_color_state_transform_finish (&transform);
-
   g_free (tmp);
 }

gdk/gdkmemoryformatprivate.h

@@ -75,16 +75,14 @@ VkFormat                gdk_memory_format_vk_rgba_format    (GdkMemoryFormat
                                                              VkComponentMapping         *out_swizzle);
 #endif
 guint32                 gdk_memory_format_get_dmabuf_fourcc (GdkMemoryFormat             format);
-const char *            gdk_memory_format_get_name          (GdkMemoryFormat             format);
+
 
 void                    gdk_memory_convert                  (guchar                     *dest_data,
                                                              gsize                       dest_stride,
                                                              GdkMemoryFormat             dest_format,
-                                                             GdkColorState              *dest_color_state,
                                                              const guchar               *src_data,
                                                              gsize                       src_stride,
                                                              GdkMemoryFormat             src_format,
-                                                             GdkColorState              *src_color_state,
                                                              gsize                       width,
                                                              gsize                       height);
 

gdk/gdkmemorytexture.c

@@ -22,7 +22,6 @@
 #include "gdkmemorytextureprivate.h"
 
 #include "gdkmemoryformatprivate.h"
-#include "gdkcolorstate.h"
 #include "gsk/gl/fp16private.h"
 
 /**
@@ -59,7 +58,6 @@ gdk_memory_texture_dispose (GObject *object)
 static void
 gdk_memory_texture_download (GdkTexture      *texture,
                              GdkMemoryFormat  format,
-                             GdkColorState   *color_state,
                              guchar          *data,
                              gsize            stride)
 {
@@ -67,11 +65,9 @@ gdk_memory_texture_download (GdkTexture      *texture,
 
   gdk_memory_convert (data, stride,
                       format,
-                      color_state,
                       (guchar *) g_bytes_get_data (self->bytes, NULL),
                       self->stride,
                       texture->format,
-                      texture->color_state,
                       gdk_texture_get_width (texture),
                       gdk_texture_get_height (texture));
 }
@@ -135,7 +131,7 @@ gdk_memory_sanitize (GBytes          *bytes,
  * @bytes: the `GBytes` containing the pixel data
  * @stride: rowstride for the data
  *
- * Creates a new texture for a blob of sRGB image data.
+ * Creates a new texture for a blob of image data.
  *
  * The `GBytes` must contain @stride × @height pixels
  * in the given format.
@@ -148,43 +144,11 @@ gdk_memory_texture_new (int              width,
                         GdkMemoryFormat  format,
                         GBytes          *bytes,
                         gsize            stride)
-{
-  return  gdk_memory_texture_new_with_color_state (width, height, format,
-                                                   gdk_color_state_get_srgb (),
-                                                   bytes, stride);
-}
-
-/**
- * gdk_memory_texture_new_with_color_state:
- * @width: the width of the texture
- * @height: the height of the texture
- * @format: the format of the data
- * @color_state: a `GdkColorSpace`
- * @bytes: the `GBytes` containing the pixel data
- * @stride: rowstride for the data
- *
- * Creates a new texture for a blob of image data with a given color state.
- *
- * The `GBytes` must contain @stride x @height pixels
- * in the given format.
- *
- * Returns: A newly-created `GdkTexture`
- *
- * Since: 4.16
- */
-GdkTexture *
-gdk_memory_texture_new_with_color_state (int              width,
-                                         int              height,
-                                         GdkMemoryFormat  format,
-                                         GdkColorState   *color_state,
-                                         GBytes          *bytes,
-                                         gsize            stride)
 {
   GdkMemoryTexture *self;
 
   g_return_val_if_fail (width > 0, NULL);
   g_return_val_if_fail (height > 0, NULL);
-  g_return_val_if_fail (color_state != NULL, NULL);
   g_return_val_if_fail (bytes != NULL, NULL);
   g_return_val_if_fail (stride >= width * gdk_memory_format_bytes_per_pixel (format), NULL);
   /* needs to be this complex to support subtexture of the bottom right part */
@@ -195,7 +159,6 @@ gdk_memory_texture_new_with_color_state (int              width,
   self = g_object_new (GDK_TYPE_MEMORY_TEXTURE,
                        "width", width,
                        "height", height,
-                       "color-state", color_state,
                        NULL);
 
   GDK_TEXTURE (self)->format = format;
@@ -228,19 +191,19 @@ gdk_memory_texture_new_subtexture (GdkMemoryTexture  *source,
   size = source->stride * (height - 1) + width * bpp;
   bytes = g_bytes_new_from_bytes (source->bytes, offset, size);
 
-  result = gdk_memory_texture_new_with_color_state (width,
-                                                    height,
-                                                    texture->format,
-                                                    texture->color_state,
-                                                    bytes,
-                                                    source->stride);
+  result = gdk_memory_texture_new (width,
+                                   height,
+                                   texture->format,
+                                   bytes,
+                                   source->stride);
   g_bytes_unref (bytes);
 
   return result;
 }
 
 GdkMemoryTexture *
-gdk_memory_texture_from_texture (GdkTexture *texture)
+gdk_memory_texture_from_texture (GdkTexture      *texture,
+                                 GdkMemoryFormat  format)
 {
   GdkTexture *result;
   GBytes *bytes;
@@ -250,19 +213,23 @@ gdk_memory_texture_from_texture (GdkTexture *texture)
   g_return_val_if_fail (GDK_IS_TEXTURE (texture), NULL);
 
   if (GDK_IS_MEMORY_TEXTURE (texture))
-    return g_object_ref (GDK_MEMORY_TEXTURE (texture));
+    {
+      GdkMemoryTexture *memtex = GDK_MEMORY_TEXTURE (texture);
 
-  stride = texture->width * gdk_memory_format_bytes_per_pixel (texture->format);
+      if (gdk_texture_get_format (texture) == format)
+        return g_object_ref (memtex);
+    }
+
+  stride = texture->width * gdk_memory_format_bytes_per_pixel (format);
   data = g_malloc_n (stride, texture->height);
 
-  gdk_texture_do_download (texture, texture->format, texture->color_state, data, stride);
+  gdk_texture_do_download (texture, format, data, stride);
   bytes = g_bytes_new_take (data, stride * texture->height);
-  result = gdk_memory_texture_new_with_color_state (texture->width,
-                                                    texture->height,
-                                                    texture->format,
-                                                    texture->color_state,
-                                                    bytes,
-                                                    stride);
+  result = gdk_memory_texture_new (texture->width,
+                                   texture->height,
+                                   format,
+                                   bytes,
+                                   stride);
   g_bytes_unref (bytes);
 
   return GDK_MEMORY_TEXTURE (result);

gdk/gdkmemorytexture.h

@@ -68,14 +68,6 @@ GdkTexture *            gdk_memory_texture_new              (int
                                                              GBytes            *bytes,
                                                              gsize              stride);
 
-GDK_AVAILABLE_IN_4_16
-GdkTexture *            gdk_memory_texture_new_with_color_state (int              width,
-                                                                 int              height,
-                                                                 GdkMemoryFormat  format,
-                                                                 GdkColorState   *color_state,
-                                                                 GBytes          *bytes,
-                                                                 gsize            stride);
-
 
 G_END_DECLS
 

gdk/gdkmemorytextureprivate.h

@@ -28,7 +28,8 @@ G_BEGIN_DECLS
 #define GDK_MEMORY_GDK_PIXBUF_OPAQUE GDK_MEMORY_R8G8B8
 #define GDK_MEMORY_GDK_PIXBUF_ALPHA GDK_MEMORY_R8G8B8A8
 
-GdkMemoryTexture *      gdk_memory_texture_from_texture     (GdkTexture        *texture);
+GdkMemoryTexture *      gdk_memory_texture_from_texture     (GdkTexture        *texture,
+                                                             GdkMemoryFormat    format);
 GdkTexture *            gdk_memory_texture_new_subtexture   (GdkMemoryTexture  *texture,
                                                              int                x,
                                                              int                y,

gdk/gdkrgba.c

@@ -396,18 +396,10 @@ gboolean
  */
 char *
 gdk_rgba_to_string (const GdkRGBA *rgba)
-{
-  return g_string_free (gdk_rgba_print (rgba, g_string_new ("")), FALSE);
-}
-
-GString *
-gdk_rgba_print (const GdkRGBA *rgba,
-                GString       *string)
 {
   if (rgba->alpha > 0.999)
     {
-      g_string_append_printf (string,
-                              "rgb(%d,%d,%d)",
+      return g_strdup_printf ("rgb(%d,%d,%d)",
                               (int)(0.5 + CLAMP (rgba->red, 0., 1.) * 255.),
                               (int)(0.5 + CLAMP (rgba->green, 0., 1.) * 255.),
                               (int)(0.5 + CLAMP (rgba->blue, 0., 1.) * 255.));
@@ -418,15 +410,12 @@ gdk_rgba_print (const GdkRGBA *rgba,
 
       g_ascii_formatd (alpha, G_ASCII_DTOSTR_BUF_SIZE, "%g", CLAMP (rgba->alpha, 0, 1));
 
-      g_string_append_printf (string,
-                              "rgba(%d,%d,%d,%s)",
+      return g_strdup_printf ("rgba(%d,%d,%d,%s)",
                               (int)(0.5 + CLAMP (rgba->red, 0., 1.) * 255.),
                               (int)(0.5 + CLAMP (rgba->green, 0., 1.) * 255.),
                               (int)(0.5 + CLAMP (rgba->blue, 0., 1.) * 255.),
                               alpha);
     }
-
-  return string;
 }
 
 static gboolean

gdk/gdkrgbaprivate.h

@@ -72,8 +72,5 @@ _gdk_rgba_equal (gconstpointer p1,
          rgba1->alpha == rgba2->alpha;
 }
 
-GString * gdk_rgba_print (const GdkRGBA *rgba,
-                          GString       *string);
-
 G_END_DECLS
 

gdk/gdksurface.c

@@ -30,8 +30,6 @@
 #include "gdksurface.h"
 
 #include "gdkprivate.h"
-#include "gdkcolorstate.h"
-#include "gdkcairo.h"
 #include "gdkcontentprovider.h"
 #include "gdkdeviceprivate.h"
 #include "gdkdisplayprivate.h"
@@ -46,7 +44,6 @@
 #include "gdktoplevelprivate.h"
 #include "gdkvulkancontext.h"
 #include "gdksubsurfaceprivate.h"
-#include "gdkcolorstate.h"
 
 #include <math.h>
 
@@ -92,7 +89,6 @@ enum {
 
 enum {
   PROP_0,
-  PROP_COLOR_STATE,
   PROP_CURSOR,
   PROP_DISPLAY,
   PROP_FRAME_CLOCK,
@@ -488,18 +484,6 @@ gdk_surface_init (GdkSurface *surface)
 
   surface->alpha = 255;
 
-  if (g_getenv ("GDK_DISPLAY_COLORSTATE"))
-    {
-      const char *env = g_getenv ("GDK_DISPLAY_COLORSTATE");
-      if (strcmp (env, "srgb") == 0)
-        surface->color_state = gdk_color_state_get_srgb ();
-      else if (strcmp (env, "srgb-linear") == 0)
-        surface->color_state = gdk_color_state_get_srgb_linear ();
-    }
-
-  if (surface->color_state == NULL)
-    surface->color_state = gdk_color_state_get_srgb ();
-
   surface->device_cursor = g_hash_table_new_full (NULL, NULL,
                                                  NULL, g_object_unref);
 
@@ -544,25 +528,6 @@ gdk_surface_class_init (GdkSurfaceClass *klass)
   klass->get_scale = gdk_surface_real_get_scale;
   klass->create_subsurface = gdk_surface_real_create_subsurface;
 
-  /**
-   * GdkSurface:color-state: (attributes org.gtk.Property.get=gdk_surface_get_color_state)
-   *
-   * The preferred color state for rendering to the surface
-   *
-   * This color state is negotiated between GTK and the compositor.
-   *
-   * The color state may change as the surface gets moved around - for example
-   * to different monitors or when the compositor gets reconfigured. As long as
-   * the surface isn't shown, the color space may not represent the actual color
-   * state that is going to be used.
-   *
-   * Since: 4.16
-   */
-  properties[PROP_COLOR_STATE] =
-      g_param_spec_boxed ("color-state", NULL, NULL,
-                          GDK_TYPE_COLOR_STATE,
-                          G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
-
   /**
    * GdkSurface:cursor: (attributes org.gtk.Property.get=gdk_surface_get_cursor org.gtk.Property.set=gdk_surface_set_cursor)
    *
@@ -821,10 +786,6 @@ gdk_surface_set_property (GObject      *object,
 
   switch (prop_id)
     {
-    case PROP_COLOR_STATE:
-      gdk_surface_set_color_state (surface, g_value_get_object (value));
-      break;
-
     case PROP_CURSOR:
       gdk_surface_set_cursor (surface, g_value_get_object (value));
       break;
@@ -858,10 +819,6 @@ gdk_surface_get_property (GObject    *object,
 
   switch (prop_id)
     {
-    case PROP_COLOR_STATE:
-      g_value_set_object (value, gdk_surface_get_color_state (surface));
-      break;
-
     case PROP_CURSOR:
       g_value_set_object (value, gdk_surface_get_cursor (surface));
       break;
@@ -2373,7 +2330,6 @@ gdk_surface_create_similar_surface (GdkSurface      *surface,
                                                 content == CAIRO_CONTENT_ALPHA ? CAIRO_FORMAT_A8 : CAIRO_FORMAT_ARGB32,
                                                 width * scale, height * scale);
   cairo_surface_set_device_scale (similar_surface, scale, scale);
-  gdk_cairo_surface_set_color_state (similar_surface, gdk_surface_get_color_state (surface));
 
   return similar_surface;
 }
@@ -3120,37 +3076,3 @@ gdk_surface_get_subsurface (GdkSurface *surface,
 {
   return g_ptr_array_index (surface->subsurfaces, idx);
 }
-
-void
-gdk_surface_set_color_state (GdkSurface    *surface,
-                             GdkColorState *color_state)
-{
-  /* This way we support unsetting, too */
-  if (G_UNLIKELY (gdk_display_get_debug_flags (surface->display) & GDK_DEBUG_SRGB))
-    color_state = gdk_color_state_get_srgb ();
-
-  if (gdk_color_state_equal (surface->color_state, color_state))
-    return;
-
-  g_set_object (&surface->color_state, color_state);
-
-  g_object_notify_by_pspec (G_OBJECT (surface), properties[PROP_COLOR_STATE]);
-}
-
-/**
- * gdk_surface_get_color_state:
- * @self: a `GdkSurface`
- *
- * Returns the preferred color state for rendering to the given @surface.
- *
- * Returns: (transfer none): The color state of @surface
- *
- * Since: 4.16
- */
-GdkColorState *
-gdk_surface_get_color_state (GdkSurface *surface)
-{
-  g_return_val_if_fail (GDK_IS_SURFACE (surface), gdk_color_state_get_srgb ());
-
-  return surface->color_state;
-}

gdk/gdksurface.h

@@ -139,9 +139,6 @@ GdkVulkanContext *
                gdk_surface_create_vulkan_context(GdkSurface     *surface,
                                                  GError        **error);
 
-GDK_AVAILABLE_IN_4_16
-GdkColorState *gdk_surface_get_color_state      (GdkSurface     *surface);
-
 G_DEFINE_AUTOPTR_CLEANUP_FUNC (GdkSurface, g_object_unref)
 
 G_END_DECLS

gdk/gdksurfaceprivate.h

@@ -105,8 +105,6 @@ struct _GdkSurface
    */
   GdkSubsurface *subsurfaces_above;
   GdkSubsurface *subsurfaces_below;
-
-  GdkColorState *color_state;
 };
 
 struct _GdkSurfaceClass
@@ -357,7 +355,4 @@ gsize           gdk_surface_get_n_subsurfaces  (GdkSurface          *surface);
 GdkSubsurface * gdk_surface_get_subsurface     (GdkSurface          *surface,
                                                 gsize                idx);
 
-void            gdk_surface_set_color_state    (GdkSurface          *surface,
-                                                GdkColorState       *color_state);
-
 G_END_DECLS

gdk/gdktexture.c

@@ -44,21 +44,12 @@
 #include "gdkmemorytextureprivate.h"
 #include "gdkpaintable.h"
 #include "gdksnapshot.h"
-#include "gdkcolorstate.h"
-#include "gdkcairo.h"
 
 #include <graphene.h>
 #include "loaders/gdkpngprivate.h"
 #include "loaders/gdktiffprivate.h"
 #include "loaders/gdkjpegprivate.h"
 
-/**
- * gdk_texture_error_quark:
- *
- * Registers an error quark for [class@Gdk.Texture] errors.
- *
- * Returns: the error quark
- **/
 G_DEFINE_QUARK (gdk-texture-error-quark, gdk_texture_error)
 
 /* HACK: So we don't need to include any (not-yet-created) GSK or GTK headers */
@@ -71,7 +62,6 @@ enum {
   PROP_0,
   PROP_WIDTH,
   PROP_HEIGHT,
-  PROP_COLOR_STATE,
 
   N_PROPS
 };
@@ -261,7 +251,6 @@ G_DEFINE_ABSTRACT_TYPE_WITH_CODE (GdkTexture, gdk_texture, G_TYPE_OBJECT,
 static void
 gdk_texture_default_download (GdkTexture      *texture,
                               GdkMemoryFormat  format,
-                              GdkColorState   *color_state,
                               guchar          *data,
                               gsize            stride)
 {
@@ -286,12 +275,6 @@ gdk_texture_set_property (GObject      *gobject,
       self->height = g_value_get_int (value);
       break;
 
-    case PROP_COLOR_STATE:
-      if (self->color_state)
-        gdk_color_state_unref (self->color_state);
-      self->color_state = gdk_color_state_ref (g_value_get_boxed (value));
-      break;
-
     default:
       G_OBJECT_WARN_INVALID_PROPERTY_ID (gobject, prop_id, pspec);
       break;
@@ -316,10 +299,6 @@ gdk_texture_get_property (GObject    *gobject,
       g_value_set_int (value, self->height);
       break;
 
-    case PROP_COLOR_STATE:
-      g_value_set_boxed (value, self->color_state);
-      break;
-
     default:
       G_OBJECT_WARN_INVALID_PROPERTY_ID (gobject, prop_id, pspec);
       break;
@@ -358,8 +337,6 @@ gdk_texture_dispose (GObject *object)
 
   gdk_texture_clear_render_data (self);
 
-  g_clear_pointer (&self->color_state, gdk_color_state_unref);
-
   G_OBJECT_CLASS (gdk_texture_parent_class)->dispose (object);
 }
 
@@ -404,28 +381,12 @@ gdk_texture_class_init (GdkTextureClass *klass)
                       G_PARAM_STATIC_STRINGS |
                       G_PARAM_EXPLICIT_NOTIFY);
 
-  /**
-   * GdkTexture:color-state: (attributes org.gtk.Property.get=gdk_texture_get_color_state)
-   *
-   * The color state of the texture.
-   *
-   * Since: 4.16
-   */
-  properties[PROP_COLOR_STATE] =
-    g_param_spec_boxed ("color-state", NULL, NULL,
-                        GDK_TYPE_COLOR_STATE,
-                        G_PARAM_READWRITE |
-                        G_PARAM_CONSTRUCT_ONLY |
-                        G_PARAM_STATIC_STRINGS |
-                        G_PARAM_EXPLICIT_NOTIFY);
-
   g_object_class_install_properties (gobject_class, N_PROPS, properties);
 }
 
 static void
 gdk_texture_init (GdkTexture *self)
 {
-  self->color_state = gdk_color_state_get_srgb ();
 }
 
 /**
@@ -456,42 +417,17 @@ gdk_texture_new_for_surface (cairo_surface_t *surface)
                                       (GDestroyNotify) cairo_surface_destroy,
                                       cairo_surface_reference (surface));
 
-  texture = gdk_memory_texture_new_with_color_state (cairo_image_surface_get_width (surface),
-                                                     cairo_image_surface_get_height (surface),
-                                                     GDK_MEMORY_DEFAULT,
-                                                     gdk_cairo_surface_get_color_state (surface),
-                                                     bytes,
-                                                     cairo_image_surface_get_stride (surface));
+  texture = gdk_memory_texture_new (cairo_image_surface_get_width (surface),
+                                    cairo_image_surface_get_height (surface),
+                                    GDK_MEMORY_DEFAULT,
+                                    bytes,
+                                    cairo_image_surface_get_stride (surface));
 
   g_bytes_unref (bytes);
 
   return texture;
 }
 
-static GdkColorState *
-gdk_color_state_from_pixbuf (GdkPixbuf *pixbuf)
-{
-  const char *icc_profile_base64;
-  GdkColorState *color_state = NULL;
-
-  icc_profile_base64 = gdk_pixbuf_get_option (pixbuf, "icc-profile");
-  if (icc_profile_base64)
-    {
-      guchar *icc_data;
-      gsize icc_len;
-      GBytes *bytes;
-
-      icc_data = g_base64_decode (icc_profile_base64, &icc_len);
-      bytes = g_bytes_new_take (icc_data, icc_len);
-      color_state = gdk_color_state_new_from_icc_profile (bytes, NULL);
-      g_bytes_unref (bytes);
-    }
-  if (!color_state)
-    color_state = gdk_color_state_get_srgb ();
-
-  return color_state;
-}
-
 /**
  * gdk_texture_new_for_pixbuf:
  * @pixbuf: a `GdkPixbuf`
@@ -509,31 +445,24 @@ gdk_texture_new_for_pixbuf (GdkPixbuf *pixbuf)
 {
   GdkTexture *texture;
   GBytes *bytes;
-  GdkColorState *color_state;
 
   g_return_val_if_fail (GDK_IS_PIXBUF (pixbuf), NULL);
 
-  color_state = gdk_color_state_from_pixbuf (pixbuf);
-
   bytes = g_bytes_new_with_free_func (gdk_pixbuf_get_pixels (pixbuf),
                                       gdk_pixbuf_get_height (pixbuf)
                                       * (gsize) gdk_pixbuf_get_rowstride (pixbuf),
                                       g_object_unref,
                                       g_object_ref (pixbuf));
-
-  texture = gdk_memory_texture_new_with_color_state (gdk_pixbuf_get_width (pixbuf),
-                                                     gdk_pixbuf_get_height (pixbuf),
-                                                     gdk_pixbuf_get_has_alpha (pixbuf)
-                                                     ? GDK_MEMORY_GDK_PIXBUF_ALPHA
-                                                     : GDK_MEMORY_GDK_PIXBUF_OPAQUE,
-                                                     color_state,
-                                                     bytes,
-                                                     gdk_pixbuf_get_rowstride (pixbuf));
+  texture = gdk_memory_texture_new (gdk_pixbuf_get_width (pixbuf),
+                                    gdk_pixbuf_get_height (pixbuf),
+                                    gdk_pixbuf_get_has_alpha (pixbuf)
+                                    ? GDK_MEMORY_GDK_PIXBUF_ALPHA
+                                    : GDK_MEMORY_GDK_PIXBUF_OPAQUE,
+                                    bytes,
+                                    gdk_pixbuf_get_rowstride (pixbuf));
 
   g_bytes_unref (bytes);
 
-  gdk_color_state_unref (color_state);
-
   return texture;
 }
 
@@ -791,32 +720,13 @@ gdk_texture_get_height (GdkTexture *texture)
   return texture->height;
 }
 
-/**
- * gdk_texture_get_color_state: (attributes org.gtk.Method.get_property=color-state)
- * @texture: a `GdkTexture`
- *
- * Returns the color state associsated with @texture.
- *
- * Returns: (transfer none): the color state of the `GdkTexture`
- *
- * Since: 4.16
- */
-GdkColorState *
-gdk_texture_get_color_state (GdkTexture *texture)
-{
-  g_return_val_if_fail (GDK_IS_TEXTURE (texture), NULL);
-
-  return texture->color_state;
-}
-
 void
 gdk_texture_do_download (GdkTexture      *texture,
                          GdkMemoryFormat  format,
-                         GdkColorState   *color_state,
                          guchar          *data,
                          gsize            stride)
 {
-  GDK_TEXTURE_GET_CLASS (texture)->download (texture, format, color_state, data, stride);
+  GDK_TEXTURE_GET_CLASS (texture)->download (texture, format, data, stride);
 }
 
 static gboolean
@@ -912,8 +822,7 @@ gdk_texture_set_diff (GdkTexture     *self,
 }
 
 cairo_surface_t *
-gdk_texture_download_surface (GdkTexture    *texture,
-                              GdkColorState *color_state)
+gdk_texture_download_surface (GdkTexture *texture)
 {
   cairo_surface_t *surface;
   cairo_status_t surface_status;
@@ -925,13 +834,10 @@ gdk_texture_download_surface (GdkTexture    *texture,
   if (surface_status != CAIRO_STATUS_SUCCESS)
     g_warning ("%s: surface error: %s", __FUNCTION__,
                cairo_status_to_string (surface_status));
-  else
-    gdk_texture_do_download (texture,
-                             GDK_MEMORY_DEFAULT,
-                             color_state,
-                             cairo_image_surface_get_data (surface),
-                             cairo_image_surface_get_stride (surface));
 
+  gdk_texture_download (texture,
+                        cairo_image_surface_get_data (surface),
+                        cairo_image_surface_get_stride (surface));
   cairo_surface_mark_dirty (surface);
 
   return surface;
@@ -978,7 +884,6 @@ gdk_texture_download (GdkTexture *texture,
 
   gdk_texture_do_download (texture,
                            GDK_MEMORY_DEFAULT,
-                           gdk_color_state_get_srgb (),
                            data,
                            stride);
 }

gdk/gdktexture.h

@@ -83,9 +83,6 @@ int                     gdk_texture_get_height                 (GdkTexture
 GDK_AVAILABLE_IN_4_10
 GdkMemoryFormat         gdk_texture_get_format                 (GdkTexture      *self) G_GNUC_PURE;
 
-GDK_AVAILABLE_IN_4_16
-GdkColorState *         gdk_texture_get_color_state            (GdkTexture      *self);
-
 GDK_AVAILABLE_IN_ALL
 void                    gdk_texture_download                   (GdkTexture      *texture,
                                                                 guchar          *data,

gdk/gdktexturedownloader.c

@@ -39,7 +39,6 @@
 #include "gdkmemoryformatprivate.h"
 #include "gdkmemorytextureprivate.h"
 #include "gdktextureprivate.h"
-#include "gdkcolorstate.h"
 
 G_DEFINE_BOXED_TYPE (GdkTextureDownloader, gdk_texture_downloader,
                      gdk_texture_downloader_copy,
@@ -52,7 +51,6 @@ gdk_texture_downloader_init (GdkTextureDownloader *self,
 {
   self->texture = g_object_ref (texture);
   self->format = GDK_MEMORY_DEFAULT;
-  self->color_state = gdk_color_state_get_srgb ();
 }
 
 void
@@ -105,7 +103,6 @@ gdk_texture_downloader_copy (const GdkTextureDownloader *self)
 
   copy = gdk_texture_downloader_new (self->texture);
   gdk_texture_downloader_set_format (copy, self->format);
-  gdk_texture_downloader_set_color_state (copy, self->color_state);
 
   return copy;
 }
@@ -124,8 +121,6 @@ gdk_texture_downloader_free (GdkTextureDownloader *self)
   g_return_if_fail (self != NULL);
 
   gdk_texture_downloader_finish (self);
-
-  g_clear_pointer (&self->color_state, gdk_color_state_unref);
   g_free (self);
 }
 
@@ -204,39 +199,6 @@ gdk_texture_downloader_get_format (const GdkTextureDownloader *self)
   return self->format;
 }
 
-/**
- * gdk_texture_downloader_set_color_state:
- * @self: a texture downloader
- * @color_state: the color state to use
- *
- * Sets the color state that the data will be converted to.
- *
- * Since: 4.16
- */
-void
-gdk_texture_downloader_set_color_state (GdkTextureDownloader *self,
-                                        GdkColorState        *color_state)
-{
-  g_clear_pointer (&self->color_state, gdk_color_state_unref);
-  self->color_state = gdk_color_state_ref (color_state);
-}
-
-/**
- * gdk_texture_downloader_get_color_state:
- * @self: a texture downloader
- *
- * Gets the color state that the data will be converted to.
- *
- * Returns: the color state
- *
- * Since: 4.16
- */
-GdkColorState *
-gdk_texture_downloader_get_color_state (const GdkTextureDownloader *self)
-{
-  return self->color_state;
-}
-
 /**
  * gdk_texture_downloader_download_into:
  * @self: a texture downloader
@@ -257,7 +219,7 @@ gdk_texture_downloader_download_into (const GdkTextureDownloader *self,
   g_return_if_fail (data != NULL);
   g_return_if_fail (stride >= gdk_texture_get_width (self->texture) * gdk_memory_format_bytes_per_pixel (self->format));
 
-  gdk_texture_do_download (self->texture, self->format, self->color_state, data, stride);
+  gdk_texture_do_download (self->texture, self->format, data, stride);
 }
 
 /**
@@ -288,8 +250,7 @@ gdk_texture_downloader_download_bytes (const GdkTextureDownloader *self,
   g_return_val_if_fail (out_stride != NULL, NULL);
 
   if (GDK_IS_MEMORY_TEXTURE (self->texture) &&
-      gdk_texture_get_format (self->texture) == self->format &&
-      gdk_color_state_equal (self->texture->color_state, self->color_state))
+      gdk_texture_get_format (self->texture) == self->format)
     {
       GdkMemoryTexture *memtex = GDK_MEMORY_TEXTURE (self->texture);
 
@@ -299,7 +260,7 @@ gdk_texture_downloader_download_bytes (const GdkTextureDownloader *self,
   stride = self->texture->width * gdk_memory_format_bytes_per_pixel (self->format);
   data = g_malloc_n (stride, self->texture->height);
 
-  gdk_texture_do_download (self->texture, self->format, self->color_state, data, stride);
+  gdk_texture_do_download (self->texture, self->format, data, stride);
 
   *out_stride = stride;
   return g_bytes_new_take (data, stride * self->texture->height);

gdk/gdktexturedownloader.h

@@ -49,12 +49,6 @@ void                    gdk_texture_downloader_set_format       (GdkTextureDownl
 GDK_AVAILABLE_IN_4_10
 GdkMemoryFormat         gdk_texture_downloader_get_format       (const GdkTextureDownloader     *self);
 
-GDK_AVAILABLE_IN_4_16
-void                    gdk_texture_downloader_set_color_state  (GdkTextureDownloader           *self,
-                                                                 GdkColorState                  *color_state);
-GDK_AVAILABLE_IN_4_16
-GdkColorState *         gdk_texture_downloader_get_color_state  (const GdkTextureDownloader     *self);
-
 
 GDK_AVAILABLE_IN_4_10
 void                    gdk_texture_downloader_download_into    (const GdkTextureDownloader     *self,

gdk/gdktexturedownloaderprivate.h

@@ -28,7 +28,6 @@ struct _GdkTextureDownloader
   /*< private >*/
   GdkTexture *texture;
   GdkMemoryFormat format;
-  GdkColorState *color_state;
 };
 
 void                    gdk_texture_downloader_init              (GdkTextureDownloader           *self,

gdk/gdktextureprivate.h

@@ -26,8 +26,6 @@ struct _GdkTexture
   int width;
   int height;
 
-  GdkColorState *color_state;
-
   gpointer render_key;
   gpointer render_data;
   GDestroyNotify render_notify;
@@ -48,7 +46,6 @@ struct _GdkTextureClass {
   /* mandatory: Download in the given format into data */
   void                  (* download)                    (GdkTexture             *texture,
                                                          GdkMemoryFormat         format,
-                                                         GdkColorState          *color_state,
                                                          guchar                 *data,
                                                          gsize                   stride);
 };
@@ -56,12 +53,10 @@ struct _GdkTextureClass {
 gboolean                gdk_texture_can_load            (GBytes                 *bytes);
 
 GdkTexture *            gdk_texture_new_for_surface     (cairo_surface_t        *surface);
-cairo_surface_t *       gdk_texture_download_surface    (GdkTexture             *texture,
-                                                         GdkColorState          *color_state);
+cairo_surface_t *       gdk_texture_download_surface    (GdkTexture             *texture);
 
 void                    gdk_texture_do_download         (GdkTexture             *texture,
                                                          GdkMemoryFormat         format,
-                                                         GdkColorState          *color_state,
                                                          guchar                 *data,
                                                          gsize                   stride);
 void                    gdk_texture_diff                (GdkTexture             *self,

gdk/gdktoplevel.c

@@ -767,6 +767,9 @@ gdk_toplevel_titlebar_gesture (GdkToplevel        *toplevel,
  * This function asynchronously obtains a handle for a toplevel surface
  * that can be passed to other processes.
  *
+ * When a handle has been obtained, @callback will be called, and can
+ * receive the handle via [method@Gdk.Toplevel.export_handle_finish].
+ *
  * It is an error to call this function on a surface that is already
  * exported.
  *

gdk/gdktoplevel.h

@@ -118,12 +118,9 @@ typedef enum
 
 /**
  * GdkTitlebarGesture:
- * @GDK_TITLEBAR_GESTURE_DOUBLE_CLICK: double click gesture
- * @GDK_TITLEBAR_GESTURE_RIGHT_CLICK: right click gesture
- * @GDK_TITLEBAR_GESTURE_MIDDLE_CLICK: middle click gesture
- *
- * The kind of title bar gesture to emit with
- * [method@Gdk.Toplevel.titlebar_gesture].
+ * @GDK_TITLEBAR_GESTURE_DOUBLE_CLICK:
+ * @GDK_TITLEBAR_GESTURE_RIGHT_CLICK:
+ * @GDK_TITLEBAR_GESTURE_MIDDLE_CLICK:
  *
  * Since: 4.4
  */

gdk/gdktypes.h

@@ -74,8 +74,6 @@ typedef cairo_rectangle_int_t         GdkRectangle;
 
 /* Forward declarations of commonly used types */
 typedef struct _GdkRGBA               GdkRGBA;
-typedef struct _GdkColor              GdkColor;
-typedef struct _GdkColorState         GdkColorState;
 typedef struct _GdkContentFormats     GdkContentFormats;
 typedef struct _GdkContentProvider    GdkContentProvider;
 typedef struct _GdkCursor             GdkCursor;

gdk/gdkvulkancontext.c

@@ -30,7 +30,6 @@
 #include "gdkdmabuftextureprivate.h"
 #include "gdkdisplayprivate.h"
 #include "gdkprofilerprivate.h"
-#include "gdkmemorytexture.h"
 #include <glib/gi18n-lib.h>
 #include <math.h>
 
@@ -95,13 +94,6 @@ enum {
   LAST_SIGNAL
 };
 
-/**
- * gdk_vulkan_error_quark:
- *
- * Registers an error quark for [class@Gdk.VulkanContext] errors.
- *
- * Returns: the error quark
- **/
 G_DEFINE_QUARK (gdk-vulkan-error-quark, gdk_vulkan_error)
 
 static guint signals[LAST_SIGNAL] = { 0 };
@@ -615,8 +607,7 @@ physical_device_check_features (VkPhysicalDevice device)
     features |= GDK_VULKAN_FEATURE_YCBCR;
 
   if (physical_device_supports_extension (device, VK_KHR_EXTERNAL_MEMORY_FD_EXTENSION_NAME) &&
-      physical_device_supports_extension (device, VK_EXT_IMAGE_DRM_FORMAT_MODIFIER_EXTENSION_NAME) &&
-      physical_device_supports_extension (device, VK_EXT_EXTERNAL_MEMORY_DMA_BUF_EXTENSION_NAME))
+      physical_device_supports_extension (device, VK_EXT_IMAGE_DRM_FORMAT_MODIFIER_EXTENSION_NAME))
     features |= GDK_VULKAN_FEATURE_DMABUF;
 
   if (physical_device_supports_extension (device, VK_KHR_EXTERNAL_SEMAPHORE_FD_EXTENSION_NAME))
@@ -641,54 +632,33 @@ gdk_vulkan_context_begin_frame (GdkDrawContext *draw_context,
 {
   GdkVulkanContext *context = GDK_VULKAN_CONTEXT (draw_context);
   GdkVulkanContextPrivate *priv = gdk_vulkan_context_get_instance_private (context);
-  VkResult acquire_result;
   guint i;
 
   if (depth != priv->current_format)
     {
       if (priv->formats[depth].gdk_format != priv->formats[priv->current_format].gdk_format)
         {
-          GdkMemoryDepth old_format = priv->current_format;
           GError *error = NULL;
-
-          priv->current_format = depth;
           if (!gdk_vulkan_context_check_swapchain (context, &error))
             {
               g_warning ("%s", error->message);
               g_error_free (error);
-              priv->current_format = old_format;
               return;
             }
         }
+      priv->current_format = depth;
     }
   for (i = 0; i < priv->n_images; i++)
     {
       cairo_region_union (priv->regions[i], region);
     }
 
-acquire_next_image:
-  acquire_result = GDK_VK_CHECK (vkAcquireNextImageKHR, gdk_vulkan_context_get_device (context),
-                                                        priv->swapchain,
-                                                        UINT64_MAX,
-                                                        priv->draw_semaphore,
-                                                        VK_NULL_HANDLE,
-                                                        &priv->draw_index);
-  if ((acquire_result == VK_ERROR_OUT_OF_DATE_KHR) ||
-      (acquire_result == VK_SUBOPTIMAL_KHR))
-    {
-      GError *error = NULL;
-
-      GDK_DEBUG (VULKAN, "Recreating the swapchain");
-
-      if (!gdk_vulkan_context_check_swapchain (context, &error))
-        {
-          g_warning ("%s", error->message);
-          g_error_free (error);
-          return;
-        }
-
-       goto acquire_next_image;
-     }
+  GDK_VK_CHECK (vkAcquireNextImageKHR, gdk_vulkan_context_get_device (context),
+                                       priv->swapchain,
+                                       UINT64_MAX,
+                                       priv->draw_semaphore,
+                                       VK_NULL_HANDLE,
+                                       &priv->draw_index);
 
   cairo_region_union (region, priv->regions[priv->draw_index]);
 }
@@ -1298,15 +1268,6 @@ gdk_vulkan_context_get_image_format (GdkVulkanContext *context)
   return priv->formats[priv->current_format].vk_format.format;
 }
 
-GdkMemoryFormat
-gdk_vulkan_context_get_memory_format (GdkVulkanContext *context)
-{
-  GdkVulkanContextPrivate *priv = gdk_vulkan_context_get_instance_private (context);
-
-  g_return_val_if_fail (GDK_IS_VULKAN_CONTEXT (context), GDK_MEMORY_DEFAULT);
-
-  return priv->formats[priv->current_format].gdk_format;
-}
 /**
  * gdk_vulkan_context_get_n_images:
  * @context: a `GdkVulkanContext`
@@ -1538,7 +1499,6 @@ gdk_display_create_vulkan_device (GdkDisplay  *display,
 
                   g_ptr_array_add (device_extensions, (gpointer) VK_KHR_EXTERNAL_MEMORY_FD_EXTENSION_NAME);
                   g_ptr_array_add (device_extensions, (gpointer) VK_KHR_EXTERNAL_MEMORY_EXTENSION_NAME);
-                  g_ptr_array_add (device_extensions, (gpointer) VK_EXT_EXTERNAL_MEMORY_DMA_BUF_EXTENSION_NAME);
 
                   g_ptr_array_add (device_extensions, (gpointer) VK_EXT_IMAGE_DRM_FORMAT_MODIFIER_EXTENSION_NAME);
                   g_ptr_array_add (device_extensions, (gpointer) VK_KHR_IMAGE_FORMAT_LIST_EXTENSION_NAME);
@@ -1879,9 +1839,8 @@ gdk_display_unref_vulkan (GdkDisplay *display)
     {
       g_free (key);
       vkDestroyShaderModule (display->vk_device,
-                             *((VkShaderModule *)value),
+                             value,
                              NULL);
-      g_free (value);
     }
   g_hash_table_unref (display->vk_shader_modules);
 
@@ -2009,13 +1968,13 @@ VkShaderModule
 gdk_display_get_vk_shader_module (GdkDisplay *self,
                                   const char *resource_name)
 {
-  VkShaderModule *shader;
+  VkShaderModule shader;
   GError *error = NULL;
   GBytes *bytes;
 
   shader = g_hash_table_lookup (self->vk_shader_modules, resource_name);
   if (shader)
-    return *shader;
+    return shader;
 
   bytes = g_resources_lookup_data (resource_name, 0, &error);
   if (bytes == NULL)
@@ -2025,7 +1984,6 @@ gdk_display_get_vk_shader_module (GdkDisplay *self,
       return VK_NULL_HANDLE;
     }
 
-  shader = g_new0 (VkShaderModule, 1);
   if (GDK_VK_CHECK (vkCreateShaderModule, self->vk_device,
                                           &(VkShaderModuleCreateInfo) {
                                               .sType = VK_STRUCTURE_TYPE_SHADER_MODULE_CREATE_INFO,
@@ -2033,20 +1991,18 @@ gdk_display_get_vk_shader_module (GdkDisplay *self,
                                               .pCode = (uint32_t *) g_bytes_get_data (bytes, NULL),
                                           },
                                           NULL,
-                                          shader) == VK_SUCCESS)
+                                          &shader) == VK_SUCCESS)
     {
       g_hash_table_insert (self->vk_shader_modules, g_strdup (resource_name), shader);
     }
   else
     {
-      g_free (shader);
-
-      return VK_NULL_HANDLE;
+      shader = VK_NULL_HANDLE;
     }
 
   g_bytes_unref (bytes);
 
-  return *shader;
+  return shader;
 }
 
 #else /* GDK_RENDERING_VULKAN */

gdk/gdkvulkancontextprivate.h

@@ -94,7 +94,6 @@ VkDevice                gdk_vulkan_context_get_device                   (GdkVulk
 VkQueue                 gdk_vulkan_context_get_queue                    (GdkVulkanContext      *context);
 uint32_t                gdk_vulkan_context_get_queue_family_index       (GdkVulkanContext      *context);
 VkFormat                gdk_vulkan_context_get_image_format             (GdkVulkanContext      *context);
-GdkMemoryFormat         gdk_vulkan_context_get_memory_format            (GdkVulkanContext      *context);
 uint32_t                gdk_vulkan_context_get_n_images                 (GdkVulkanContext      *context);
 VkImage                 gdk_vulkan_context_get_image                    (GdkVulkanContext      *context,
                                                                          guint                  id);

gdk/loaders/gdkjpeg.c

@@ -24,8 +24,6 @@
 #include <glib/gi18n-lib.h>
 #include "gdktexture.h"
 #include "gdktexturedownloaderprivate.h"
-#include "gdkcolorstate.h"
-#include "gdkmemorytextureprivate.h"
 
 #include "gdkprofilerprivate.h"
 
@@ -145,12 +143,9 @@ gdk_load_jpeg (GBytes  *input_bytes,
   guint width, height, stride;
   unsigned char *data = NULL;
   unsigned char *row[1];
-  JOCTET *icc_data;
-  unsigned int icc_len;
   GBytes *bytes;
   GdkTexture *texture;
   GdkMemoryFormat format;
-  GdkColorState *color_state;
   G_GNUC_UNUSED guint64 before = GDK_PROFILER_CURRENT_TIME;
 
   info.err = jpeg_std_error (&jerr.pub);
@@ -174,9 +169,6 @@ gdk_load_jpeg (GBytes  *input_bytes,
                 g_bytes_get_data (input_bytes, NULL),
                 g_bytes_get_size (input_bytes));
 
-  /* save color space */
-  jpeg_save_markers (&info, JPEG_APP0 + 2, 0xFFFF);
-
   jpeg_read_header (&info, TRUE);
   jpeg_start_decompress (&info);
 
@@ -234,35 +226,19 @@ gdk_load_jpeg (GBytes  *input_bytes,
       g_assert_not_reached ();
     }
 
-  if (jpeg_read_icc_profile (&info, &icc_data, &icc_len))
-    {
-      GBytes *icc_bytes = g_bytes_new_with_free_func (icc_data, icc_len, free, icc_data);
-      color_state = gdk_color_state_new_from_icc_profile (icc_bytes, error);
-      g_bytes_unref (icc_bytes);
-    }
-  else
-    color_state = gdk_color_state_get_srgb ();
-
   jpeg_finish_decompress (&info);
   jpeg_destroy_decompress (&info);
 
   bytes = g_bytes_new_take (data, stride * height);
 
-  if (color_state)
-    {
-      texture = gdk_memory_texture_new_with_color_state (width, height,
-                                                         format,
-                                                         color_state,
-                                                         bytes, stride);
-    }
-  else
-    texture = NULL;
+  texture = gdk_memory_texture_new (width, height,
+                                    format,
+                                    bytes, stride);
 
-  g_clear_pointer (&color_state, gdk_color_state_unref);
   g_bytes_unref (bytes);
 
   gdk_profiler_end_mark (before, "Load jpeg", NULL);
-
+ 
   return texture;
 }
 
@@ -281,12 +257,9 @@ gdk_save_jpeg (GdkTexture *texture)
   gsize texstride;
   guchar *row;
   int width, height;
-  GdkColorState *color_state;
-  GBytes *bytes;
 
   width = gdk_texture_get_width (texture);
   height = gdk_texture_get_height (texture);
-  color_state = gdk_texture_get_color_state (texture);
 
   info.err = jpeg_std_error (&jerr.pub);
   jerr.pub.error_exit = fatal_error_handler;
@@ -325,15 +298,6 @@ gdk_save_jpeg (GdkTexture *texture)
 
   jpeg_start_compress (&info, TRUE);
 
-  bytes = gdk_color_state_save_to_icc_profile (color_state, NULL);
-  if (bytes)
-    {
-      jpeg_write_icc_profile (&info,
-                              g_bytes_get_data (bytes, NULL),
-                              g_bytes_get_size (bytes));
-      g_bytes_unref (bytes);
-    }
-
   while (info.next_scanline < info.image_height)
     {
       row = (guchar *) texdata + info.next_scanline * texstride;

gdk/loaders/gdkpng.c

@@ -20,14 +20,11 @@
 #include "gdkpngprivate.h"
 
 #include <glib/gi18n-lib.h>
-#include "gdkcolorstateprivate.h"
-#include "gdkcolorstateprivate.h"
 #include "gdkmemoryformatprivate.h"
 #include "gdkmemorytexture.h"
 #include "gdkprofilerprivate.h"
 #include "gdktexturedownloaderprivate.h"
 #include "gsk/gl/fp16private.h"
-
 #include <png.h>
 #include <stdio.h>
 
@@ -129,182 +126,6 @@ png_simple_warning_callback (png_structp     png,
 {
 }
 
-/* }}} */
-/* {{{ Color profile handling */
-
-typedef struct
-{
-  gboolean cicp_chunk_read;
-  int color_primaries;
-  int transfer_function;
-  int matrix_coefficients;
-  int full_range;
-} CICPData;
-
-static int
-png_read_chunk_func (png_structp        png,
-                     png_unknown_chunkp chunk)
-{
-  if (strcmp ((char *) chunk->name, "cICP") == 0 &&
-      chunk->size == 4)
-    {
-      CICPData *cicp = png_get_user_chunk_ptr (png);
-
-      cicp->cicp_chunk_read = TRUE;
-
-      cicp->color_primaries = chunk->data[0];
-      cicp->transfer_function = chunk->data[1];
-      cicp->matrix_coefficients = chunk->data[2];
-      cicp->full_range = chunk->data[3];
-
-      return 1;
-    }
-
-  return 0;
-}
-
-static GdkColorState *
-gdk_png_get_color_state (png_struct *png,
-                         png_info   *info)
-{
-  GdkColorState *color_state;
-  guchar *icc_data;
-  png_uint_32 icc_len;
-  char *name;
-  double gamma;
-  cmsCIExyY whitepoint;
-  cmsCIExyYTRIPLE primaries;
-  cmsToneCurve *curve;
-  cmsHPROFILE lcms_profile;
-  int intent;
-  CICPData *cicp;
-
-  cicp = png_get_user_chunk_ptr (png);
-
-  if (cicp->cicp_chunk_read)
-    {
-      color_state = gdk_color_state_new_from_cicp_data (cicp->color_primaries,
-                                                        cicp->transfer_function,
-                                                        cicp->matrix_coefficients,
-                                                        cicp->full_range);
-      if (color_state)
-        {
-          g_debug ("Color state from cICP data: %s\n", gdk_color_state_get_name (color_state));
-          return color_state;
-        }
-      else
-        {
-          g_debug ("Failed to create color state from cICP data: %d/%d/%d %d\n",
-                   cicp->color_primaries,
-                   cicp->transfer_function,
-                   cicp->matrix_coefficients,
-                   cicp->full_range);
-        }
-    }
-
-  if (png_get_iCCP (png, info, &name, NULL, &icc_data, &icc_len))
-    {
-      GBytes *bytes = g_bytes_new (icc_data, icc_len);
-
-      color_state = gdk_color_state_new_from_icc_profile (bytes, NULL);
-      g_bytes_unref (bytes);
-      if (color_state)
-        return color_state;
-    }
-
-  if (png_get_sRGB (png, info, &intent))
-    return gdk_color_state_get_srgb ();
-
-  /* If neither of those is valid, the result is sRGB */
-  if (!png_get_valid (png, info, PNG_INFO_gAMA) &&
-      !png_get_valid (png, info, PNG_INFO_cHRM))
-    return gdk_color_state_get_srgb ();
-
-  if (!png_get_gAMA (png, info, &gamma))
-    gamma = 2.4;
-
-  if (!png_get_cHRM (png, info,
-                     &whitepoint.x, &whitepoint.y,
-                     &primaries.Red.x, &primaries.Red.y,
-                     &primaries.Green.x, &primaries.Green.y,
-                     &primaries.Blue.x, &primaries.Blue.y))
-    {
-      if (gamma == 2.4)
-        return gdk_color_state_get_srgb ();
-
-      whitepoint = (cmsCIExyY) { 0.3127, 0.3290, 1.0 };
-      primaries = (cmsCIExyYTRIPLE) {
-                    { 0.6400, 0.3300, 1.0 },
-                    { 0.3000, 0.6000, 1.0 },
-                    { 0.1500, 0.0600, 1.0 }
-                  };
-    }
-  else
-    {
-      primaries.Red.Y = 1.0;
-      primaries.Green.Y = 1.0;
-      primaries.Blue.Y = 1.0;
-    }
-
-  curve = cmsBuildGamma (NULL, 1.0 / gamma);
-  lcms_profile = cmsCreateRGBProfile (&whitepoint,
-                                      &primaries,
-                                      (cmsToneCurve*[3]) { curve, curve, curve });
-  color_state = gdk_color_state_new_from_lcms_profile (lcms_profile);
-  /* FIXME: errors? */
-  if (color_state == NULL)
-    color_state = gdk_color_state_get_srgb ();
-  cmsFreeToneCurve (curve);
-
-  return color_state;
-}
-
-static void
-gdk_png_set_color_state (png_struct    *png,
-                         png_info      *info,
-                         GdkColorState *color_state,
-                         png_byte      *chunk_data)
-{
-  int cp, tc, mc;
-  gboolean fr;
-
-  if (gdk_color_state_save_to_cicp_data (color_state, &cp, &tc, &mc, &fr, NULL))
-    {
-      png_unknown_chunk chunk = {
-        .name = { 'c', 'I', 'C', 'P', '\0' },
-        .data = chunk_data,
-        .size = 4,
-        .location = PNG_HAVE_IHDR,
-      };
-
-      chunk_data[0] = (png_byte)cp;
-      chunk_data[1] = (png_byte)tc;
-      chunk_data[2] = (png_byte)mc;
-      chunk_data[3] = (png_byte)fr;
-
-      g_debug ("got cicp %d/%d/%d %d\n", cp, tc, mc, fr);
-
-      png_set_unknown_chunks (png, info, &chunk, 1);
-    }
-  else if (color_state == gdk_color_state_get_srgb ())
-    {
-      png_set_sRGB_gAMA_and_cHRM (png, info, /* FIXME */ PNG_sRGB_INTENT_PERCEPTUAL);
-    }
-  else
-    {
-      GBytes *bytes = gdk_color_state_save_to_icc_profile (color_state, NULL);
-      if (bytes)
-        {
-          png_set_iCCP (png, info,
-                        "ICC profile",
-                        0,
-                        g_bytes_get_data (bytes, NULL),
-                        g_bytes_get_size (bytes));
-          g_bytes_unref (bytes);
-        }
-    }
-}
-
 /* }}} */
 /* {{{ Public API */
 
@@ -326,11 +147,8 @@ gdk_load_png (GBytes      *bytes,
   guchar *buffer = NULL;
   guchar **row_pointers = NULL;
   GBytes *out_bytes;
-  GdkColorState *color_state;
   GdkTexture *texture;
   int bpp;
-  CICPData cicp = { FALSE, };
-
   G_GNUC_UNUSED gint64 before = GDK_PROFILER_CURRENT_TIME;
 
   io.data = (guchar *)g_bytes_get_data (bytes, &io.size);
@@ -351,7 +169,6 @@ gdk_load_png (GBytes      *bytes,
     g_error ("Out of memory");
 
   png_set_read_fn (png, &io, png_read_func);
-  png_set_read_user_chunk_fn (png, &cicp, png_read_chunk_func);
 
   if (sigsetjmp (png_jmpbuf (png), 1))
     {
@@ -449,8 +266,6 @@ gdk_load_png (GBytes      *bytes,
       return NULL;
     }
 
-  color_state = gdk_png_get_color_state (png, info);
-
   bpp = gdk_memory_format_bytes_per_pixel (format);
   if (!g_size_checked_mul (&stride, width, bpp) ||
       !g_size_checked_add (&stride, stride, (8 - stride % 8) % 8))
@@ -466,7 +281,6 @@ gdk_load_png (GBytes      *bytes,
 
   if (!buffer || !row_pointers)
     {
-      gdk_color_state_unref (color_state);
       g_free (buffer);
       g_free (row_pointers);
       png_destroy_read_struct (&png, &info, NULL);
@@ -483,11 +297,8 @@ gdk_load_png (GBytes      *bytes,
   png_read_end (png, info);
 
   out_bytes = g_bytes_new_take (buffer, height * stride);
-  texture = gdk_memory_texture_new_with_color_state (width, height,
-                                                     format, color_state,
-                                                     out_bytes, stride);
+  texture = gdk_memory_texture_new (width, height, format, out_bytes, stride);
   g_bytes_unref (out_bytes);
-  gdk_color_state_unref (color_state);
 
   if (options && png_get_text (png, info, &text, &num_texts))
     {
@@ -526,14 +337,11 @@ gdk_save_png (GdkTexture *texture)
   GBytes *bytes;
   gsize stride;
   const guchar *data;
-  GdkColorState *color_state;
   int png_format;
   int depth;
-  png_byte chunk_data[4];
 
   width = gdk_texture_get_width (texture);
   height = gdk_texture_get_height (texture);
-  color_state = gdk_texture_get_color_state (texture);
   format = gdk_texture_get_format (texture);
 
   switch (format)
@@ -628,8 +436,6 @@ gdk_save_png (GdkTexture *texture)
   /* 2^31-1 is the maximum size for PNG files */
   png_set_user_limits (png, (1u << 31) - 1, (1u << 31) - 1);
 
-  png_set_keep_unknown_chunks (png, PNG_HANDLE_CHUNK_ALWAYS, NULL, 0);
-
   info = png_create_info_struct (png);
   if (!info)
     {
@@ -659,8 +465,6 @@ gdk_save_png (GdkTexture *texture)
                 PNG_COMPRESSION_TYPE_DEFAULT,
                 PNG_FILTER_TYPE_DEFAULT);
 
-  gdk_png_set_color_state (png, info, color_state, chunk_data);
-
   png_write_info (png, info);
 
 #if G_BYTE_ORDER == G_LITTLE_ENDIAN

gdk/loaders/gdktiff.c

@@ -24,7 +24,6 @@
 #include "gdkmemorytexture.h"
 #include "gdkprofilerprivate.h"
 #include "gdktexturedownloaderprivate.h"
-#include "gdkcolorstate.h"
 
 #include <tiffio.h>
 
@@ -220,49 +219,6 @@ tiff_open_write (GBytes **result)
                          NULL, NULL);
 }
 
-/* }}} */
-/* {{{ Color profile handling */
-
-static GdkColorState *
-gdk_tiff_get_color_state (TIFF *tiff)
-{
-  const char *icc_data;
-  guint icc_len;
-
-  if (TIFFGetField (tiff, TIFFTAG_ICCPROFILE, &icc_len, &icc_data))
-    {
-      GBytes *icc_bytes;
-      GdkColorState *color_state;
-
-      icc_bytes = g_bytes_new (icc_data, icc_len);
-      color_state = gdk_color_state_new_from_icc_profile (icc_bytes, NULL);
-      g_bytes_unref (icc_bytes);
-
-      if (color_state)
-        return color_state;
-    }
-
-  return gdk_color_state_get_srgb ();
-}
-
-static void
-gdk_tiff_set_color_state (TIFF          *tiff,
-                          GdkColorState *color_state)
-{
-  GBytes *bytes;
-
-  bytes = gdk_color_state_save_to_icc_profile (color_state, NULL);
-
-  if (bytes)
-    {
-      TIFFSetField (tiff, TIFFTAG_ICCPROFILE,
-                    g_bytes_get_size (bytes),
-                    g_bytes_get_data (bytes, NULL));
-
-      g_bytes_unref (bytes);
-    }
-}
-
 /* }}} */
 /* {{{ Public API */
 
@@ -326,7 +282,6 @@ gdk_save_tiff (GdkTexture *texture)
   GBytes *bytes, *result = NULL;
   GdkTextureDownloader downloader;
   GdkMemoryFormat format;
-  GdkColorState *color_state;
   const FormatData *fdata = NULL;
 
   tif = tiff_open_write (&result);
@@ -334,7 +289,6 @@ gdk_save_tiff (GdkTexture *texture)
   width = gdk_texture_get_width (texture);
   height = gdk_texture_get_height (texture);
   format = gdk_texture_get_format (texture);
-  color_state = gdk_texture_get_color_state (texture);
   fdata = &format_data[format];
 
   if (fdata == NULL)
@@ -354,8 +308,6 @@ gdk_save_tiff (GdkTexture *texture)
   TIFFSetField (tif, TIFFTAG_PHOTOMETRIC, fdata->photometric);
   TIFFSetField (tif, TIFFTAG_PLANARCONFIG, PLANARCONFIG_CONTIG);
 
-  gdk_tiff_set_color_state (tif, color_state);
-
   gdk_texture_downloader_init (&downloader, texture);
   gdk_texture_downloader_set_format (&downloader, fdata->format);
   bytes = gdk_texture_downloader_download_bytes (&downloader, &stride);
@@ -392,7 +344,6 @@ load_fallback (TIFF    *tif,
   int width, height;
   guchar *data;
   GBytes *bytes;
-  GdkColorState *color_state;
   GdkTexture *texture;
 
   TIFFGetField (tif, TIFFTAG_IMAGEWIDTH, &width);
@@ -409,15 +360,12 @@ load_fallback (TIFF    *tif,
       return NULL;
     }
 
-  color_state = gdk_tiff_get_color_state (tif);
-
   bytes = g_bytes_new_take (data, width * height * 4);
 
-  texture = gdk_memory_texture_new_with_color_state (width, height,
-                                                     GDK_MEMORY_R8G8B8A8_PREMULTIPLIED,
-                                                     color_state,
-                                                     bytes,
-                                                     width * 4);
+  texture = gdk_memory_texture_new (width, height,
+                                    GDK_MEMORY_R8G8B8A8_PREMULTIPLIED,
+                                    bytes,
+                                    width * 4);
 
   g_bytes_unref (bytes);
 
@@ -442,7 +390,6 @@ gdk_load_tiff (GBytes  *input_bytes,
   gsize stride;
   int bpp;
   GBytes *bytes;
-  GdkColorState *color_state;
   GdkTexture *texture;
   G_GNUC_UNUSED gint64 before = GDK_PROFILER_CURRENT_TIME;
 
@@ -543,16 +490,13 @@ gdk_load_tiff (GBytes  *input_bytes,
       line += stride;
     }
 
-  color_state = gdk_tiff_get_color_state (tif);
-
   bpp = gdk_memory_format_bytes_per_pixel (format);
   bytes = g_bytes_new_take (data, width * height * bpp);
 
-  texture = gdk_memory_texture_new_with_color_state (width, height,
-                                                     format, color_state,
-                                                     bytes, width * bpp);
+  texture = gdk_memory_texture_new (width, height,
+                                    format,
+                                    bytes, width * bpp);
   g_bytes_unref (bytes);
-  gdk_color_state_unref (color_state);
 
   TIFFClose (tif);
 

gdk/macos/gdkmacosdragsurface.c

@@ -96,12 +96,12 @@ _gdk_macos_drag_surface_constructed (GObject *object)
                                                  defer:NO
                                                 screen:screen];
 
-  _gdk_macos_surface_set_native (self, window);
-
   [window setOpaque:NO];
   [window setBackgroundColor:[NSColor clearColor]];
   [window setDecorated:NO];
 
+  _gdk_macos_surface_set_native (self, window);
+
   frame_clock = _gdk_frame_clock_idle_new ();
   gdk_surface_set_frame_clock (surface, frame_clock);
   g_object_unref (frame_clock);

gdk/macos/gdkmacospopupsurface.c

@@ -52,7 +52,6 @@ gdk_macos_popup_surface_layout (GdkMacosPopupSurface *self,
   GdkRectangle bounds;
   GdkRectangle final_rect;
   int x, y;
-  int shadow_left, shadow_right, shadow_top, shadow_bottom;
 
   g_assert (GDK_IS_MACOS_POPUP_SURFACE (self));
   g_assert (layout != NULL);
@@ -69,19 +68,10 @@ gdk_macos_popup_surface_layout (GdkMacosPopupSurface *self,
     monitor = _gdk_macos_surface_get_best_monitor (GDK_MACOS_SURFACE (self));
   gdk_macos_monitor_get_workarea (monitor, &bounds);
 
-  gdk_popup_layout_get_shadow_width (layout,
-                                     &shadow_left,
-                                     &shadow_right,
-                                     &shadow_top,
-                                     &shadow_bottom);
-
   gdk_surface_layout_popup_helper (GDK_SURFACE (self),
                                    width,
                                    height,
-                                   shadow_left,
-                                   shadow_right,
-                                   shadow_top,
-                                   shadow_bottom,
+                                   0, 0, 0, 0, /* shadow-left/right/top/bottom */
                                    monitor,
                                    &bounds,
                                    self->layout,
@@ -316,14 +306,14 @@ _gdk_macos_popup_surface_constructed (GObject *object)
                                                  defer:NO
                                                 screen:screen];
 
-  _gdk_macos_surface_set_native (GDK_MACOS_SURFACE (self), window);
-
   [window setOpaque:NO];
   [window setBackgroundColor:[NSColor clearColor]];
   [window setDecorated:NO];
   [window setExcludedFromWindowsMenu:YES];
   [window setLevel:NSPopUpMenuWindowLevel];
 
+  _gdk_macos_surface_set_native (GDK_MACOS_SURFACE (self), window);
+
   gdk_surface_set_frame_clock (surface, gdk_surface_get_frame_clock (surface->parent));
 
   GDK_END_MACOS_ALLOC_POOL;

gdk/macos/gdkmacostoplevelsurface.c

@@ -591,11 +591,11 @@ _gdk_macos_toplevel_surface_constructed (GObject *object)
                                                  defer:NO
                                                 screen:screen];
 
-  _gdk_macos_surface_set_native (GDK_MACOS_SURFACE (self), window);
-
   /* Allow NSWindow to go fullscreen */
   [window setCollectionBehavior:NSWindowCollectionBehaviorFullScreenPrimary];
 
+  _gdk_macos_surface_set_native (GDK_MACOS_SURFACE (self), window);
+
   frame_clock = _gdk_frame_clock_idle_new ();
   gdk_surface_set_frame_clock (surface, frame_clock);
   g_object_unref (frame_clock);

gdk/meson.build

@@ -6,8 +6,6 @@ gdk_public_sources = files([
   'gdkcairo.c',
   'gdkcairocontext.c',
   'gdkclipboard.c',
-  'gdkcolor.c',
-  'gdkcolorstate.c',
   'gdkcontentdeserializer.c',
   'gdkcontentformats.c',
   'gdkcontentprovider.c',
@@ -77,9 +75,6 @@ gdk_public_headers = files([
   'gdkcairo.h',
   'gdkcairocontext.h',
   'gdkclipboard.h',
-  'gdkcolor.h',
-  'gdkcolorimpl.h',
-  'gdkcolorstate.h',
   'gdkcontentdeserializer.h',
   'gdkcontentformats.h',
   'gdkcontentprovider.h',
@@ -133,8 +128,8 @@ install_headers(gdk_deprecated_headers, subdir: 'gtk-4.0/gdk/deprecated')
 gdk_sources = gdk_public_sources + gdk_deprecated_sources
 
 gdk_private_h_sources = files([
-  'gdkdevicetoolprivate.h',
   'gdkeventsprivate.h',
+  'gdkdevicetoolprivate.h',
   'gdkhslaprivate.h',
   'gdkmonitorprivate.h',
   'gdkseatdefaultprivate.h',
@@ -229,7 +224,6 @@ gdk_deps = [
   fontconfig_dep,
   platform_gio_dep,
   pangocairo_dep,
-  lcms2_dep,
   vulkan_dep,
   libdrm_dep,
   png_dep,

gdk/wayland/gdkcairocontext-wayland.c

@@ -158,9 +158,6 @@ gdk_wayland_cairo_context_begin_frame (GdkDrawContext *draw_context,
   else
     self->paint_surface = gdk_wayland_cairo_context_create_surface (self);
 
-  gdk_cairo_surface_set_color_state (self->paint_surface,
-                                     gdk_surface_get_color_state (gdk_draw_context_get_surface (draw_context)));
-
   surface_region = gdk_wayland_cairo_context_surface_get_region (self->paint_surface);
   if (surface_region)
     cairo_region_union (region, surface_region);

gdk/wayland/gdkcursor-wayland.c

@@ -165,29 +165,25 @@ _gdk_wayland_cursor_get_buffer (GdkWaylandDisplay *display,
                                 double            *scale)
 {
   GdkTexture *texture;
+  int desired_scale_factor;
+
+  desired_scale_factor = (int) ceil (desired_scale);
 
   if (gdk_cursor_get_name (cursor))
     {
       struct wl_cursor *c;
-      int scale_factor;
 
       if (g_str_equal (gdk_cursor_get_name (cursor), "none"))
-        {
-          *hotspot_x = *hotspot_y = 0;
-          *width = *height = 0;
-          *scale = 1;
-          return NULL;
-        }
-
-      scale_factor = (int) ceil (desired_scale);
+        goto none;
 
       c = gdk_wayland_cursor_load_for_name (display,
-                                            display->cursor_theme,
-                                            scale_factor,
+                                            _gdk_wayland_display_get_cursor_theme (display),
+                                            desired_scale_factor,
                                             gdk_cursor_get_name (cursor));
       if (c && c->image_count > 0)
         {
           struct wl_cursor_image *image;
+          int cursor_scale;
 
           if (image_index >= c->image_count)
             {
@@ -199,23 +195,23 @@ _gdk_wayland_cursor_get_buffer (GdkWaylandDisplay *display,
 
           image = c->images[image_index];
 
-          *width = display->cursor_theme_size;
-          *height = display->cursor_theme_size;
-          *scale = image->width / (double) *width;
-          *hotspot_x = image->hotspot_x / scale_factor;
-          *hotspot_y = image->hotspot_y / scale_factor;
-
-          if (*scale != scale_factor && !use_viewporter)
+          cursor_scale = desired_scale_factor;
+          if ((image->width % cursor_scale != 0) ||
+              (image->height % cursor_scale != 0))
             {
-              g_warning (G_STRLOC " cursor image size (%d) not an integer "
-                         "multiple of theme size (%d)", image->width, *width);
-              *width = image->width;
-              *height = image->height;
-              *hotspot_x = image->hotspot_x;
-              *hotspot_y = image->hotspot_y;
-              *scale = 1;
+              g_warning (G_STRLOC " cursor image size (%dx%d) not an integer "
+                         "multiple of scale (%d)", image->width, image->height,
+                         cursor_scale);
+              cursor_scale = 1;
             }
 
+          *hotspot_x = image->hotspot_x / cursor_scale;
+          *hotspot_y = image->hotspot_y / cursor_scale;
+
+          *width = image->width / cursor_scale;
+          *height = image->height / cursor_scale;
+          *scale = cursor_scale;
+
           return wl_cursor_image_get_buffer (image);
         }
     }
@@ -261,7 +257,7 @@ from_texture:
   else
     {
       if (!use_viewporter)
-        *scale = ceil (desired_scale);
+        *scale = desired_scale_factor;
       else
         *scale = desired_scale;
 
@@ -298,23 +294,28 @@ from_texture:
     }
 
   if (gdk_cursor_get_fallback (cursor))
-    {
-      return _gdk_wayland_cursor_get_buffer (display,
-                                             gdk_cursor_get_fallback (cursor),
-                                             desired_scale,
-                                             use_viewporter,
-                                             image_index,
-                                             hotspot_x, hotspot_y,
-                                             width, height,
-                                             scale);
-    }
+    return _gdk_wayland_cursor_get_buffer (display,
+                                           gdk_cursor_get_fallback (cursor),
+                                           desired_scale,
+                                           use_viewporter,
+                                           image_index,
+                                           hotspot_x, hotspot_y,
+                                           width, height,
+                                           scale);
   else
     {
       texture = gdk_texture_new_from_resource ("/org/gtk/libgdk/cursor/default");
       goto from_texture;
     }
 
-  g_assert_not_reached ();
+none:
+  *hotspot_x = 0;
+  *hotspot_y = 0;
+  *width = 0;
+  *height = 0;
+  *scale = 1;
+
+  return NULL;
 }
 
 guint

gdk/wayland/gdkdisplay-wayland.c

@@ -97,7 +97,6 @@
 #define OUTPUT_VERSION_WITH_DONE 2
 #define NO_XDG_OUTPUT_DONE_SINCE_VERSION 3
 #define OUTPUT_VERSION           3
-#define XDG_WM_DIALOG_VERSION    1
 
 #ifdef HAVE_TOPLEVEL_STATE_SUSPENDED
 #define XDG_WM_BASE_VERSION      6
@@ -383,13 +382,6 @@ gdk_registry_handle_global (void               *data,
     {
       display_wayland->zxdg_shell_v6_id = id;
     }
-  else if (strcmp (interface, "xdg_wm_dialog_v1") == 0)
-    {
-      display_wayland->xdg_wm_dialog =
-        wl_registry_bind (display_wayland->wl_registry, id,
-                          &xdg_wm_dialog_v1_interface,
-                          MIN (version, XDG_WM_DIALOG_VERSION));
-    }
   else if (strcmp (interface, "gtk_shell1") == 0)
     {
       display_wayland->gtk_shell =

gdk/wayland/gdkdisplay-wayland.h

@@ -41,7 +41,6 @@
 #include <gdk/wayland/viewporter-client-protocol.h>
 #include <gdk/wayland/presentation-time-client-protocol.h>
 #include <gdk/wayland/single-pixel-buffer-v1-client-protocol.h>
-#include <gdk/wayland/xdg-dialog-v1-client-protocol.h>
 
 #include <glib.h>
 #include <gdk/gdkkeys.h>
@@ -103,7 +102,6 @@ struct _GdkWaylandDisplay
   DmabufFormatsInfo *dmabuf_formats_info;
   struct xdg_wm_base *xdg_wm_base;
   struct zxdg_shell_v6 *zxdg_shell_v6;
-  struct xdg_wm_dialog_v1 *xdg_wm_dialog;
   struct gtk_shell1 *gtk_shell;
   struct wl_data_device_manager *data_device_manager;
   struct wl_subcompositor *subcompositor;

gdk/wayland/gdkseat-wayland.c

@@ -3866,25 +3866,9 @@ pointer_surface_leave (void              *data,
   pointer_surface_update_scale (device);
 }
 
-static void
-pointer_surface_preferred_buffer_scale (void              *data,
-                                        struct wl_surface *wl_surface,
-                                        int32_t            factor)
-{
-}
-
-static void
-pointer_surface_preferred_buffer_transform (void              *data,
-                                            struct wl_surface *wl_surface,
-                                            uint32_t           transform)
-{
-}
-
 static const struct wl_surface_listener pointer_surface_listener = {
   pointer_surface_enter,
-  pointer_surface_leave,
-  pointer_surface_preferred_buffer_scale,
-  pointer_surface_preferred_buffer_transform,
+  pointer_surface_leave
 };
 
 static void

gdk/wayland/gdktoplevel-wayland.c

@@ -37,7 +37,6 @@
 #include <wayland/presentation-time-client-protocol.h>
 #include <wayland/xdg-shell-unstable-v6-client-protocol.h>
 #include <wayland/xdg-foreign-unstable-v2-client-protocol.h>
-#include <wayland/xdg-dialog-v1-client-protocol.h>
 
 #include <stdlib.h>
 #include <stdio.h>
@@ -85,7 +84,6 @@ struct _GdkWaylandToplevel
     struct gtk_surface1 *gtk_surface;
     struct xdg_toplevel *xdg_toplevel;
     struct zxdg_toplevel_v6 *zxdg_toplevel_v6;
-    struct xdg_dialog_v1 *xdg_dialog;
   } display_server;
 
   GdkWaylandToplevel *transient_for;
@@ -207,7 +205,6 @@ gdk_wayland_toplevel_clear_saved_size (GdkWaylandToplevel *toplevel)
 
 static void maybe_set_gtk_surface_dbus_properties (GdkWaylandToplevel *wayland_toplevel);
 static void maybe_set_gtk_surface_modal (GdkWaylandToplevel *wayland_toplevel);
-static gboolean maybe_set_xdg_dialog_modal (GdkWaylandToplevel *wayland_toplevel);
 
 static void
 gdk_wayland_toplevel_hide_surface (GdkWaylandSurface *wayland_surface)
@@ -218,7 +215,6 @@ gdk_wayland_toplevel_hide_surface (GdkWaylandSurface *wayland_surface)
 
   g_clear_pointer (&toplevel->display_server.xdg_toplevel, xdg_toplevel_destroy);
   g_clear_pointer (&toplevel->display_server.zxdg_toplevel_v6, zxdg_toplevel_v6_destroy);
-  g_clear_pointer (&toplevel->display_server.xdg_dialog, xdg_dialog_v1_destroy);
 
   if (toplevel->display_server.gtk_surface)
     {
@@ -881,8 +877,7 @@ gdk_wayland_surface_create_xdg_toplevel (GdkWaylandToplevel *wayland_toplevel)
   gdk_wayland_toplevel_set_application_id (GDK_TOPLEVEL (wayland_toplevel), app_id);
 
   maybe_set_gtk_surface_dbus_properties (wayland_toplevel);
-  if (!maybe_set_xdg_dialog_modal (wayland_toplevel))
-    maybe_set_gtk_surface_modal (wayland_toplevel);
+  maybe_set_gtk_surface_modal (wayland_toplevel);
 
   gdk_profiler_add_mark (GDK_PROFILER_CURRENT_TIME, 0, "Wayland surface commit", NULL);
   wl_surface_commit (wayland_surface->display_server.wl_surface);
@@ -1094,40 +1089,12 @@ maybe_set_gtk_surface_modal (GdkWaylandToplevel *wayland_toplevel)
 
 }
 
-static gboolean
-maybe_set_xdg_dialog_modal (GdkWaylandToplevel *wayland_toplevel)
-{
-  GdkWaylandDisplay *display_wayland =
-    GDK_WAYLAND_DISPLAY (gdk_surface_get_display (GDK_SURFACE (wayland_toplevel)));
-
-  if (!display_wayland->xdg_wm_dialog)
-    return FALSE;
-  if (!is_realized_toplevel (GDK_WAYLAND_SURFACE (wayland_toplevel)))
-    return FALSE;
-
-  if (!wayland_toplevel->display_server.xdg_dialog)
-    {
-      wayland_toplevel->display_server.xdg_dialog =
-        xdg_wm_dialog_v1_get_xdg_dialog (display_wayland->xdg_wm_dialog,
-                                         wayland_toplevel->display_server.xdg_toplevel);
-    }
-
-  if (GDK_SURFACE (wayland_toplevel)->modal_hint)
-    xdg_dialog_v1_set_modal (wayland_toplevel->display_server.xdg_dialog);
-  else
-    xdg_dialog_v1_unset_modal (wayland_toplevel->display_server.xdg_dialog);
-
-  return TRUE;
-}
-
 static void
 gdk_wayland_toplevel_set_modal_hint (GdkWaylandToplevel *wayland_toplevel,
                                      gboolean            modal)
 {
   GDK_SURFACE (wayland_toplevel)->modal_hint = modal;
-
-  if (!maybe_set_xdg_dialog_modal (wayland_toplevel))
-    maybe_set_gtk_surface_modal (wayland_toplevel);
+  maybe_set_gtk_surface_modal (wayland_toplevel);
 }
 
 void