pathbar: Setup the cancellable earlier

There have been reports of people hitting the
assertion in drop_node_for_cancellable, and a
plausible explanation is that we are adding it
too late in the codepath.

Fixes: #5792

demos/gtk-demo/listbox.ui

@@ -64,6 +64,8 @@
             </child>
             <child>
               <object class="GtkLabel" id="short_time_label">
+                <property name="hexpand">1</property>
+                <property name="xalign">1</property>
                 <property name="valign">baseline</property>
                 <property name="label" translatable="yes">38m</property>
                 <style>

docs/reference/gtk/migrating-3to4.md

@@ -875,10 +875,10 @@ reference.
 ### Adapt to coordinate API changes
 
 A number of APIs that are accepting or returning coordinates have
-been changed from ints to doubles: `gtk_widget_translate_coordinates()`,
+been changed from `int`s to `double`s: `gtk_widget_translate_coordinates()`,
 `gtk_fixed_put()`, `gtk_fixed_move()`. This change is mostly transparent,
 except for cases where out parameters are involved: you need to
-pass double* now, instead of int*.
+pass `double*` now, instead of `int*`.
 
 ### Adapt to GtkStyleContext API changes
 

docs/reference/gtk/migrating-4to5.md

@@ -119,3 +119,17 @@ it no longer has a resize handle for the window.
 
 These are very specialized widgets that should better live with the application
 where they are used.
+
+## Widget size api changes
+
+The functions gtk_widget_get_allocated_width() and gtk_widget_get_allocated_height()
+are going away. In most cases, [method@Gtk.Widget.get_width] and [method@Gtk.Widget.get_height]
+are suitable replacements. Note that the semantics are slightly different though:
+the old functions return the size of the CSS border area, while the new functions return
+the size of the widgets content area. In places where this difference matters, you can
+use `gtk_widget_compute_bounds (widget, widget, &bounds)` instead.
+
+The function gtk_widget_get_allocation() is also going away. It does not have a direct
+replacement, but the previously mentioned alternatives can be used for it too.
+
+The function gtk_widget_get_allocated_baseline() has been renamed to [method@Gtk.Widget.get_baseline].

gdk/gdkdisplaymanager.c

@@ -437,7 +437,7 @@ gdk_display_manager_open_display (GdkDisplayManager *manager,
             }
         }
 
-      if (!found && !display)
+      if (!found && !any && !display)
         g_warning ("No such backend: %s", backend);
     }
 

gdk/gdkvulkancontext.c

@@ -223,7 +223,7 @@ gdk_vulkan_strerror (VkResult result)
 #if VK_HEADER_VERSION < 140
     case VK_RESULT_RANGE_SIZE:
 #endif
-#if VK_HEADER_VERSION >= 218
+#if VK_HEADER_VERSION >= 238
     case VK_ERROR_IMAGE_USAGE_NOT_SUPPORTED_KHR:
       return "The requested VkImageUsageFlags are not supported. (VK_ERROR_IMAGE_USAGE_NOT_SUPPORTED_KHR)";
     case VK_ERROR_VIDEO_PICTURE_LAYOUT_NOT_SUPPORTED_KHR:

gsk/gl/gskglrenderjob.c

@@ -4145,6 +4145,7 @@ gsk_gl_render_job_visit_node_with_offscreen (GskGLRenderJob       *job,
                                                      flipped_x ? -1 : 1,
                                                      flipped_y ? -1 : 1);
       gsk_gl_render_job_push_modelview (job, transform);
+      gsk_transform_unref (transform);
     }
 
   gsk_gl_render_job_transform_bounds (job, offscreen->bounds, &viewport);
@@ -4182,6 +4183,7 @@ gsk_gl_render_job_visit_node_with_offscreen (GskGLRenderJob       *job,
     {
       GskTransform *transform = gsk_transform_scale (NULL, downscale_x, downscale_y);
       gsk_gl_render_job_push_modelview (job, transform);
+      gsk_transform_unref (transform);
       gsk_gl_render_job_transform_bounds (job, offscreen->bounds, &viewport);
     }
 

gtk/deprecated/gtkinfobar.c

@@ -51,7 +51,7 @@ G_GNUC_BEGIN_IGNORE_DEPRECATIONS
 /**
  * GtkInfoBar:
  *
- * `GtkInfoBar` can be show messages to the user without a dialog.
+ * `GtkInfoBar` can be used to show messages to the user without a dialog.
  *
  * ![An example GtkInfoBar](info-bar.png)
  *

gtk/gtkemojichooser.c

@@ -563,12 +563,11 @@ add_emoji (GtkWidget    *box,
   int i;
   PangoLayout *layout;
   PangoRectangle rect;
+  gunichar code = 0;
 
   codes = g_variant_get_child_value (item, 0);
   for (i = 0; i < g_variant_n_children (codes); i++)
     {
-      gunichar code;
-
       g_variant_get_child (codes, i, "u", &code);
       if (code == 0)
         code = modifier;
@@ -576,7 +575,10 @@ add_emoji (GtkWidget    *box,
         p += g_unichar_to_utf8 (code, p);
     }
   g_variant_unref (codes);
-  p += g_unichar_to_utf8 (0xFE0F, p); /* U+FE0F is the Emoji variation selector */
+
+  if (code != 0xFE0F && code != 0xFE0E)
+    p += g_unichar_to_utf8 (0xFE0F, p); /* Append a variation selector, if there isn't one already */
+
   p[0] = 0;
 
   label = gtk_label_new (text);

gtk/gtkexpander.c

@@ -106,9 +106,10 @@
  *     ╰── <child>
  * ```
  *
- * `GtkExpander` has three CSS nodes, the main node with the name expander-widget,
- * a subnode with name title and node below it with name expander. The arrow of an
- * expander that is showing its child gets the :checked pseudoclass added to it.
+ * `GtkExpander` has a main node `expander-widget`, and subnode `box` containing
+ * the title and child widget. The box subnode `title` contains node `expander`,
+ * i.e. the expand/collapse arrow; then the label widget if any. The arrow of an
+ * expander that is showing its child gets the `:checked` pseudoclass set on it.
  *
  * # Accessibility
  *

gtk/gtkinscription.c

@@ -43,7 +43,7 @@
  * space as well as it can.
  *
  * Users of this widget should take care to plan behaviour for the common case
- * where the text doesn't fit exactly in the allocated space, .
+ * where the text doesn't fit exactly in the allocated space.
  *
  * Since: 4.8
  */

gtk/gtkpathbar.c

@@ -935,6 +935,7 @@ _gtk_path_bar_set_file (GtkPathBar *path_bar,
 
   info->cancellable = g_cancellable_new ();
   path_bar->get_info_cancellable = info->cancellable;
+  add_cancellable (path_bar, info->cancellable);
 
   if (g_file_is_native (info->file))
     {
@@ -959,7 +960,6 @@ _gtk_path_bar_set_file (GtkPathBar *path_bar,
                                          gtk_path_bar_get_mount_callback,
                                          info);
     }
-  add_cancellable (path_bar, info->cancellable);
 }
 
 /**