mediacontrols: Make the labels and scale droppable

Request a reasonable minimum size for the scale, but
let the mediacontrols drop both labels and scale when
space is at a premium.

gtk/gtkboxlayout.c

@@ -49,6 +49,117 @@
  * you can use the #GtkBoxLayout:spacing property.
  */
 
+struct _GtkBoxLayoutChild
+{
+  GtkLayoutChild parent_instance;
+
+  guint droppable;
+};
+
+enum {
+  PROP_CHILD_DROPPABLE = 1,
+
+  N_CHILD_PROPERTIES
+};
+
+static GParamSpec *child_props[N_CHILD_PROPERTIES];
+
+G_DEFINE_TYPE (GtkBoxLayoutChild, gtk_box_layout_child, GTK_TYPE_LAYOUT_CHILD)
+
+static void
+gtk_box_layout_child_set_property (GObject      *gobject,
+                                   guint         prop_id,
+                                   const GValue *value,
+                                   GParamSpec   *pspec)
+{
+  GtkBoxLayoutChild *self = GTK_BOX_LAYOUT_CHILD (gobject);
+
+  switch (prop_id)
+    {
+    case PROP_CHILD_DROPPABLE:
+      gtk_box_layout_child_set_droppable (self, g_value_get_uint (value));
+      break;
+
+    default:
+      G_OBJECT_WARN_INVALID_PROPERTY_ID (gobject, prop_id, pspec);
+      break;
+    }
+}
+
+static void
+gtk_box_layout_child_get_property (GObject    *gobject,
+                                   guint       prop_id,
+                                   GValue     *value,
+                                   GParamSpec *pspec)
+{
+  GtkBoxLayoutChild *self = GTK_BOX_LAYOUT_CHILD (gobject);
+
+  switch (prop_id)
+    {
+    case PROP_CHILD_DROPPABLE:
+      g_value_set_uint (value, self->droppable);
+      break;
+
+    default:
+      G_OBJECT_WARN_INVALID_PROPERTY_ID (gobject, prop_id, pspec);
+      break;
+    }
+}
+
+static void
+gtk_box_layout_child_class_init (GtkBoxLayoutChildClass *klass)
+{
+  GObjectClass *gobject_class = G_OBJECT_CLASS (klass);
+
+  gobject_class->set_property = gtk_box_layout_child_set_property;
+  gobject_class->get_property = gtk_box_layout_child_get_property;
+
+  /**
+   * GtkBoxLayoutChild:droppable:
+   *
+   * The priority for dropping this child when there is not enough
+   * space. 0 means the child cannot be dropped, higher priorities
+   * make the child get dropped earlier.
+   */
+  child_props[PROP_CHILD_DROPPABLE] =
+    g_param_spec_uint ("droppable",
+                       P_("Drop Priority"),
+                       P_("Whether to drop this child when there is not enough space"),
+                       0, G_MAXUINT, 0,
+                       GTK_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY);
+
+  g_object_class_install_properties (gobject_class, N_CHILD_PROPERTIES, child_props);
+}
+
+static void
+gtk_box_layout_child_init (GtkBoxLayoutChild *self)
+{
+}
+
+void
+gtk_box_layout_child_set_droppable (GtkBoxLayoutChild *self,
+                                    int                droppable)
+{
+  g_return_if_fail (GTK_IS_BOX_LAYOUT_CHILD (self));
+
+  if (self->droppable == droppable)
+    return;
+
+  self->droppable = droppable;
+
+  gtk_layout_manager_layout_changed (gtk_layout_child_get_layout_manager (GTK_LAYOUT_CHILD (self)));
+
+  g_object_notify_by_pspec (G_OBJECT (self), child_props[PROP_CHILD_DROPPABLE]);
+}
+
+int
+gtk_box_layout_child_get_droppable (GtkBoxLayoutChild *self)
+{
+  g_return_val_if_fail (GTK_IS_BOX_LAYOUT_CHILD (self), 0);
+
+  return self->droppable;
+}
+
 struct _GtkBoxLayout
 {
   GtkLayoutManager parent_instance;
@@ -62,6 +173,15 @@ struct _GtkBoxLayout
 G_DEFINE_TYPE_WITH_CODE (GtkBoxLayout, gtk_box_layout, GTK_TYPE_LAYOUT_MANAGER,
                          G_IMPLEMENT_INTERFACE (GTK_TYPE_ORIENTABLE, NULL))
 
+static inline GtkBoxLayoutChild *
+get_box_child (GtkBoxLayout *self,
+               GtkWidget    *child)
+{
+  GtkLayoutManager *manager = GTK_LAYOUT_MANAGER (self);
+
+  return GTK_BOX_LAYOUT_CHILD (gtk_layout_manager_get_layout_child (manager, child));
+}
+
 enum {
   PROP_HOMOGENEOUS = 1,
   PROP_SPACING,
@@ -210,6 +330,7 @@ gtk_box_layout_compute_size (GtkBoxLayout *self,
 {
   GtkWidget *child;
   int n_visible_children = 0;
+  int n_droppable_children = 0;
   int required_min = 0, required_nat = 0;
   int largest_min = 0, largest_nat = 0;
   int spacing = get_spacing (self, gtk_widget_get_css_node (widget));
@@ -221,6 +342,8 @@ gtk_box_layout_compute_size (GtkBoxLayout *self,
       int child_min = 0;
       int child_nat = 0;
 
+      gtk_widget_set_child_visible (child, TRUE);
+
       if (!gtk_widget_should_layout (child))
         continue;
 
@@ -232,6 +355,12 @@ gtk_box_layout_compute_size (GtkBoxLayout *self,
       largest_min = MAX (largest_min, child_min);
       largest_nat = MAX (largest_nat, child_nat);
 
+      if (get_box_child (self, child)->droppable > 0)
+        {
+          n_droppable_children++;
+          child_min = 0;
+        }
+
       required_min += child_min;
       required_nat += child_nat;
 
@@ -242,11 +371,11 @@ gtk_box_layout_compute_size (GtkBoxLayout *self,
     {
       if (self->homogeneous)
         {
-          required_min = largest_min * n_visible_children;
-          required_nat = largest_nat * n_visible_children;
+          required_min = largest_min * (n_visible_children - n_droppable_children);
+          required_nat = largest_nat * (n_visible_children - n_droppable_children);
         }
 
-      required_min += (n_visible_children - 1) * spacing;
+      required_min += (n_visible_children - n_droppable_children - 1) * spacing;
       required_nat += (n_visible_children - 1) * spacing;
     }
 
@@ -456,6 +585,20 @@ gtk_box_layout_measure (GtkLayoutManager *layout_manager,
     }
 }
 
+typedef struct {
+  int index;
+  int droppable;
+} DroppableData;
+
+static int
+sort_by_droppable (const void *p1, const void *p2)
+{
+  const DroppableData *d1 = p1;
+  const DroppableData *d2 = p2;
+
+  return d2->droppable - d1->droppable;
+}
+
 static void
 gtk_box_layout_allocate (GtkLayoutManager *layout_manager,
                          GtkWidget        *widget,
@@ -481,6 +624,76 @@ gtk_box_layout_allocate (GtkLayoutManager *layout_manager,
   gint x = 0, y = 0, i;
   gint child_size;
   gint spacing;
+  int n_children;
+  int size;
+  DroppableData *droppable;
+
+  direction = _gtk_widget_get_direction (widget);
+  spacing = get_spacing (self, gtk_widget_get_css_node (widget));
+
+  n_children = 0;
+  for (child = _gtk_widget_get_first_child (widget);
+       child != NULL;
+       child = gtk_widget_get_next_sibling (child))
+    {
+      gtk_widget_set_child_visible (child, TRUE);
+      n_children++;
+    }
+
+  sizes = g_newa (GtkRequestedSize, n_children);
+  droppable = g_newa (DroppableData, n_children);
+
+  nvis_children = 0;
+
+  /* Retrieve desired size for visible children. */
+  for (i = 0, child = _gtk_widget_get_first_child (widget);
+       child != NULL;
+       child = _gtk_widget_get_next_sibling (child), i++)
+    {
+      sizes[i].data = child;
+      sizes[i].minimum_size = sizes[i].natural_size = 0;
+
+      droppable[i].index = i;
+      droppable[i].droppable = 0;
+
+      if (!gtk_widget_should_layout (child))
+        continue;
+
+      droppable[i].droppable = get_box_child (self, child)->droppable;
+
+      gtk_widget_measure (child,
+                          self->orientation,
+                          self->orientation == GTK_ORIENTATION_HORIZONTAL ? height : width,
+                          &sizes[i].minimum_size, &sizes[i].natural_size,
+                          NULL, NULL);
+
+      children_minimum_size += sizes[i].minimum_size;
+      nvis_children++;
+    }
+
+  if (self->orientation == GTK_ORIENTATION_HORIZONTAL)
+    size = width;
+  else
+    size = height;
+
+  if (children_minimum_size + (nvis_children - 1) * spacing > size)
+    {
+      qsort (droppable, n_children, sizeof (DroppableData), sort_by_droppable);
+
+      for (i = 0; i < n_children; i++)
+        {
+          if (droppable[i].droppable == 0)
+            break;
+
+          child = sizes[droppable[i].index].data;
+          gtk_widget_set_child_visible (child, FALSE);
+          nvis_children--;
+          children_minimum_size -= sizes[droppable[i].index].minimum_size;
+
+          if (children_minimum_size + (nvis_children - 1) * spacing <= size)
+            break;
+        }
+    }
 
   count_expand_children (widget, self->orientation, &nvis_children, &nexpand_children);
 
@@ -488,10 +701,6 @@ gtk_box_layout_allocate (GtkLayoutManager *layout_manager,
   if (nvis_children <= 0)
     return;
 
-  direction = _gtk_widget_get_direction (widget);
-  sizes = g_newa (GtkRequestedSize, nvis_children);
-  spacing = get_spacing (self, gtk_widget_get_css_node (widget));
-
   if (self->orientation == GTK_ORIENTATION_HORIZONTAL)
     extra_space = width - (nvis_children - 1) * spacing;
   else
@@ -501,27 +710,6 @@ gtk_box_layout_allocate (GtkLayoutManager *layout_manager,
   minimum_above = natural_above = 0;
   minimum_below = natural_below = 0;
 
-  /* Retrieve desired size for visible children. */
-  for (i = 0, child = _gtk_widget_get_first_child (widget);
-       child != NULL;
-       child = _gtk_widget_get_next_sibling (child))
-    {
-      if (!gtk_widget_should_layout (child))
-        continue;
-
-      gtk_widget_measure (child,
-                          self->orientation,
-                          self->orientation == GTK_ORIENTATION_HORIZONTAL ? height : width,
-                          &sizes[i].minimum_size, &sizes[i].natural_size,
-                          NULL, NULL);
-
-      children_minimum_size += sizes[i].minimum_size;
-
-      sizes[i].data = child;
-
-      i++;
-    }
-
   if (self->homogeneous)
     {
       /* We still need to run the above loop to populate the minimum sizes for
@@ -553,10 +741,10 @@ gtk_box_layout_allocate (GtkLayoutManager *layout_manager,
     }
 
   /* Allocate child sizes. */
-  for (i = 0, child = _gtk_widget_get_first_child (widget);
-       child != NULL;
-       child = _gtk_widget_get_next_sibling (child))
+  for (i = 0; i < n_children; i++)
     {
+      child = sizes[i].data;
+
       if (!gtk_widget_should_layout (child))
         continue;
 
@@ -613,8 +801,6 @@ gtk_box_layout_allocate (GtkLayoutManager *layout_manager,
               natural_above = MAX (natural_above, child_natural_baseline);
             }
         }
-
-      i++;
     }
 
   if (self->orientation == GTK_ORIENTATION_VERTICAL)
@@ -657,10 +843,10 @@ gtk_box_layout_allocate (GtkLayoutManager *layout_manager,
       y = 0;
     }
 
-  for (i = 0, child = _gtk_widget_get_first_child (widget);
-       child != NULL;
-       child = _gtk_widget_get_next_sibling (child))
+  for (i = 0; i < n_children; i++)
     {
+      child = sizes[i].data;
+
       if (!gtk_widget_should_layout (child))
         continue;
 
@@ -687,8 +873,6 @@ gtk_box_layout_allocate (GtkLayoutManager *layout_manager,
         }
 
       gtk_widget_size_allocate (child, &child_allocation, baseline);
-
-      i++;
     }
 }
 
@@ -701,6 +885,7 @@ gtk_box_layout_class_init (GtkBoxLayoutClass *klass)
   gobject_class->set_property = gtk_box_layout_set_property;
   gobject_class->get_property = gtk_box_layout_get_property;
 
+  layout_manager_class->layout_child_type = GTK_TYPE_BOX_LAYOUT_CHILD;
   layout_manager_class->measure = gtk_box_layout_measure;
   layout_manager_class->allocate = gtk_box_layout_allocate;
 

gtk/gtkboxlayout.h

@@ -27,7 +27,8 @@
 
 G_BEGIN_DECLS
 
-#define GTK_TYPE_BOX_LAYOUT (gtk_box_layout_get_type())
+#define GTK_TYPE_BOX_LAYOUT       (gtk_box_layout_get_type())
+#define GTK_TYPE_BOX_LAYOUT_CHILD (gtk_box_layout_child_get_type())
 
 GDK_AVAILABLE_IN_ALL
 G_DECLARE_FINAL_TYPE (GtkBoxLayout, gtk_box_layout, GTK, BOX_LAYOUT, GtkLayoutManager)
@@ -51,4 +52,12 @@ void                    gtk_box_layout_set_baseline_position    (GtkBoxLayout
 GDK_AVAILABLE_IN_ALL
 GtkBaselinePosition     gtk_box_layout_get_baseline_position    (GtkBoxLayout        *box_layout);
 
+GDK_AVAILABLE_IN_ALL
+G_DECLARE_FINAL_TYPE (GtkBoxLayoutChild, gtk_box_layout_child, GTK, BOX_LAYOUT_CHILD, GtkLayoutChild)
+
+void                    gtk_box_layout_child_set_droppable      (GtkBoxLayoutChild  *child,
+                                                                 int                 priority);
+GDK_AVAILABLE_IN_ALL
+int                     gtk_box_layout_child_get_droppable      (GtkBoxLayoutChild  *child);
+
 G_END_DECLS

gtk/gtkwidget.c

@@ -12318,6 +12318,9 @@ gtk_widget_should_layout (GtkWidget *widget)
   if (!_gtk_widget_get_visible (widget))
     return FALSE;
 
+  if (!_gtk_widget_get_child_visible (widget))
+    return FALSE;
+
   if (GTK_IS_NATIVE (widget))
     return FALSE;
 

gtk/ui/gtkmediacontrols.ui

@@ -34,6 +34,9 @@
                 <attributes>
                   <attribute name="font-features" value="tnum=1"/>
                 </attributes>
+                <layout>
+                  <property name="droppable">2</property>
+                </layout>
               </object>
             </child>
             <child>
@@ -42,6 +45,10 @@
                 <property name="draw_value">0</property>
                 <property name="restrict-to-fill-level">0</property>
                 <property name="hexpand">1</property>
+                <property name="width-request">100</property>
+                <layout>
+                  <property name="droppable">1</property>
+                </layout>
               </object>
             </child>
             <child>
@@ -49,6 +56,9 @@
                 <attributes>
                   <attribute name="font-features" value="tnum=1"/>
                 </attributes>
+                <layout>
+                  <property name="droppable">3</property>
+                </layout>
               </object>
             </child>
           </object>