Lerking/micropython
1
0
Fork 0
mirror of https://github.com/micropython/micropython.git synced 2026-03-10 19:00:30 +01:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

esp32/esp32_rmt: Release GIL while waiting for TX done.

Browse Source 
When the timeout parameter of `esp32.RMT.wait_done()` is set to a non-zero
value, the underlying `rmt_tx_wait_all_done` blocks (it passes the timeout
to `xQueueReceive`).  Thus we should release the GIL so that other
MicroPython threads are not blocked from running.

Signed-off-by: Daniël van de Giessen <daniel@dvdgiessen.nl>
This commit is contained in:
Daniël van de Giessen
2026-02-16 15:27:34 +01:00
committed by Damien George
parent 158cbd6065
commit f02dc6dd8f
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
ports/esp32/esp32_rmt.c
View File

@@ -275,16 +275,24 @@ static mp_obj_t esp32_rmt_wait_done(size_t n_args, const mp_obj_t *pos_args, mp_
mp_arg_parse_all(n_args, pos_args, kw_args, MP_ARRAY_SIZE(allowed_args), allowed_args, args);
esp32_rmt_obj_t *self = MP_OBJ_TO_PTR(args[0].u_obj);
mp_int_t timeout = args[1].u_int;
if (self->pin == -1) {
mp_raise_msg(&mp_type_OSError, MP_ERROR_TEXT("already deinitialized"));
} else if (!self->enabled) {
return mp_const_true;
} else if (args[1].u_int == 0 && self->tx_ongoing > 0) {
} else if (timeout == 0 && self->tx_ongoing > 0) {
// shortcut to avoid console spamming with timeout msgs by rmt_tx_wait_all_done()
return mp_const_false;
}
esp_err_t err = rmt_tx_wait_all_done(self->channel, args[1].u_int);
if (timeout != 0) {
MP_THREAD_GIL_EXIT();
}
esp_err_t err = rmt_tx_wait_all_done(self->channel, timeout);
if (timeout != 0) {
MP_THREAD_GIL_ENTER();
}
return err == ESP_OK ? mp_const_true : mp_const_false;
}
static MP_DEFINE_CONST_FUN_OBJ_KW(esp32_rmt_wait_done_obj, 1, esp32_rmt_wait_done);