Don't convert partuuids for empty src_partition element #149

2022-10-23T12:25:30+02:00

aaronkollasch commented

2022-10-23 12:25:30 +02:00

(Migrated from github.com)

Issue

When converting to partuuids, if there is an empty element in ${src_partition[@]}, then /etc/fstab will have /dev/ replaced with PARTUUID= without actually changing the device name to a PARTUUID.

I don't have the exact logs when this happened to me, but it looked something like this:

$ sudo rpi-clone -l sda --convert-fstab-to-partuuid

This will change your /etc/fstab, are you sure?  (yes/no): yes

Converting /etc/fstab from device names to PARTUUID
lsblk: /dev/: not a block device
  Editing /etc/fstab, changing /dev/ to
...

and I ended up with a broken fstab:

proc            /proc           proc    defaults          0       0
PARTUUID=mmcblk0p6  /boot           vfat    defaults          0       2
PARTUUID=mmcblk0p7  /               ext4    defaults,noatime  0       1
# a swapfile is not a swap partition, no line here
#   use  dphys-swapfile swap[on|off]  for that

I had previously run sudo rpi-clone -l sda so perhaps that is why there was an empty element in src_partition, I'm not sure.

Changes

Check that ${src_partition[p]} is not empty before editing /etc/fstab.

Then, the command I used will instead exit with an error, which is much safer:

Could not find any sda partition names in /etc/fstab, nothing changed.

## Issue When converting to partuuids, if there is an empty element in `${src_partition[@]}`, then `/etc/fstab` will have `/dev/` replaced with `PARTUUID=` without actually changing the device name to a PARTUUID. I don't have the exact logs when this happened to me, but it looked something like this: ```console $ sudo rpi-clone -l sda --convert-fstab-to-partuuid This will change your /etc/fstab, are you sure? (yes/no): yes Converting /etc/fstab from device names to PARTUUID lsblk: /dev/: not a block device Editing /etc/fstab, changing /dev/ to ... ``` and I ended up with a broken fstab: ```fstab proc /proc proc defaults 0 0 PARTUUID=mmcblk0p6 /boot vfat defaults 0 2 PARTUUID=mmcblk0p7 / ext4 defaults,noatime 0 1 # a swapfile is not a swap partition, no line here # use dphys-swapfile swap[on|off] for that ``` I had previously run `sudo rpi-clone -l sda` so perhaps that is why there was an empty element in `src_partition`, I'm not sure. ## Changes Check that `${src_partition[p]}` is not empty before editing `/etc/fstab`. Then, the command I used will instead exit with an error, which is much safer: ``` Could not find any sda partition names in /etc/fstab, nothing changed. ```

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin aaronkollasch/fix-partuuid-convert:aaronkollasch/fix-partuuid-convert

git checkout aaronkollasch/fix-partuuid-convert

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Lerking/rpi-clone#149