CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-09 18:10:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

el.style is readonly in strict mode IE. Fixing crash in IE. (#3119)

Browse Source
This commit is contained in:
Sam El-Husseini
2019-09-27 12:21:08 -07:00
committed by GitHub
parent a2e6cfffcc
commit 41e5914bd7
1 changed files with 6 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
core/components/tree/basenode.js
View File

@@ -606,7 +606,10 @@ Blockly.tree.BaseNode.prototype.toDom = function() {
var nonEmptyAndExpanded = this.getExpanded() && this.hasChildren();
var children = document.createElement('div');
children.style = this.getLineStyle();
children.style.backgroundPosition = this.getBackgroundPosition();
if (!nonEmptyAndExpanded) {
children.style.display = 'none';
}
if (nonEmptyAndExpanded) {
// children
@@ -635,12 +638,10 @@ Blockly.tree.BaseNode.prototype.getPixelIndent_ = function() {
* @protected
*/
Blockly.tree.BaseNode.prototype.getRowDom = function() {
var style = 'padding-' + (this.isRightToLeft() ? 'right' : 'left') + ':' +
this.getPixelIndent_() + 'px';
var row = document.createElement('div');
row.className = this.getRowClassName();
row.style = style;
row.style['padding-' + (this.isRightToLeft() ? 'right' : 'left')] =
this.getPixelIndent_() + 'px';
row.appendChild(this.getIconDom());
row.appendChild(this.getLabelDom());
@@ -690,16 +691,6 @@ Blockly.tree.BaseNode.prototype.getCalculatedIconClass = function() {
throw Error('unimplemented abstract method');
};
/**
* @return {string} The line style.
* @protected
*/
Blockly.tree.BaseNode.prototype.getLineStyle = function() {
var nonEmptyAndExpanded = this.getExpanded() && this.hasChildren();
return 'background-position: ' + this.getBackgroundPosition() + '; ' +
(nonEmptyAndExpanded ? '' : 'display: none');
};
/**
* @return {string} The background position style value.
* @protected