CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-11 10:57:07 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4079 from rachel-fenichel/deprecation_warnings

Browse Source 
Deprecation warnings
This commit is contained in:
Rachel Fenichel
2020-08-05 10:24:09 -07:00
committed by GitHub
parent ade149d77c f27354d8ab
commit 4368f97f85
3 changed files with 38 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
core/comment.js
View File

@@ -18,6 +18,7 @@ goog.require('Blockly.Events');
goog.require('Blockly.Events.BlockChange');
goog.require('Blockly.Events.Ui');
goog.require('Blockly.Icon');
goog.require('Blockly.utils.deprecation');
goog.require('Blockly.utils.dom');
goog.require('Blockly.utils.object');
goog.require('Blockly.utils.userAgent');
@@ -364,6 +365,11 @@ Blockly.Comment.prototype.setBubbleSize = function(width, height) {
* @deprecated August 2019 Use block.getCommentText() instead.
*/
Blockly.Comment.prototype.getText = function() {
Blockly.utils.deprecation.warn(
'Comment.prototype.getText',
'August 2019',
'December 2020',
'block.getCommentText');
return this.model_.text || '';
};
@@ -376,6 +382,11 @@ Blockly.Comment.prototype.getText = function() {
* @deprecated August 2019 Use block.setCommentText() instead.
*/
Blockly.Comment.prototype.setText = function(text) {
Blockly.utils.deprecation.warn(
'Comment.prototype.setText',
'August 2019',
'December 2020',
'block.setCommentText');
if (this.model_.text == text) {
return;
}

25
core/field.js
View File

@@ -18,6 +18,7 @@ goog.require('Blockly.Events');
goog.require('Blockly.Events.BlockChange');
goog.require('Blockly.Gesture');
goog.require('Blockly.utils');
goog.require('Blockly.utils.deprecation');
goog.require('Blockly.utils.dom');
goog.require('Blockly.utils.Rect');
goog.require('Blockly.utils.Size');
@@ -537,6 +538,11 @@ Blockly.Field.prototype.getValidator = function() {
* functions instead.
*/
Blockly.Field.prototype.classValidator = function(text) {
Blockly.utils.deprecation.warn(
'Field.prototype.classValidator',
'May 2019',
'December 2020',
'Blockly.Field.prototype.doClassValidation_');
return text;
};
@@ -548,6 +554,10 @@ Blockly.Field.prototype.classValidator = function(text) {
* @deprecated May 2019. setValue now contains all relevant logic.
*/
Blockly.Field.prototype.callValidator = function(text) {
Blockly.utils.deprecation.warn(
'Field.prototype.callValidator',
'May 2019',
'December 2020');
var classResult = this.classValidator(text);
if (classResult === null) {
// Class validator rejects value. Game over.
@@ -619,10 +629,12 @@ Blockly.Field.prototype.showEditor = function(opt_e) {
* check the size of the field.
*/
Blockly.Field.prototype.updateWidth = function() {
console.warn('Deprecated call to updateWidth, call' +
' Blockly.Field.updateSize_ to force an update to the size of the' +
' field, or Blockly.utils.dom.getTextWidth() to check the size' +
' of the field.');
Blockly.utils.deprecation.warn(
'Field.prototype.updateWidth',
'May 2019',
'December 2020',
'Blockly.Field.prototype.updateSize_ or Blockly.utils.dom.getTextWidth');
this.updateSize_();
};
@@ -809,6 +821,11 @@ Blockly.Field.prototype.getText = function() {
* @deprecated 2019 setText should not be used directly. Use setValue instead.
*/
Blockly.Field.prototype.setText = function(_newText) {
Blockly.utils.deprecation.warn(
'Field.prototype.setText',
'May 2019',
'December 2020',
'Blockly.Field.prototype.setValue');
throw Error('setText method is deprecated');
};

6
core/rendered_connection.js
View File

@@ -16,6 +16,7 @@ goog.require('Blockly.Connection');
goog.require('Blockly.Events');
goog.require('Blockly.utils');
goog.require('Blockly.utils.Coordinate');
goog.require('Blockly.utils.deprecation');
goog.require('Blockly.utils.dom');
goog.require('Blockly.utils.object');
@@ -424,6 +425,11 @@ Blockly.RenderedConnection.prototype.startTrackingAll = function() {
*/
Blockly.RenderedConnection.prototype.isConnectionAllowed = function(candidate,
maxRadius) {
Blockly.utils.deprecation.warn(
'RenderedConnection.prototype.isConnectionAllowed',
'July 2020',
'July 2021',
'Blockly.Workspace.prototype.getConnectionChecker().canConnect');
if (this.distanceFrom(candidate) > maxRadius) {
return false;
}