CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-09 01:50:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix lint errors in field_textinput (PR #2024)

Browse Source 
Merge from AnmAtAnm/fix-lint-errors
This commit is contained in:
Andrew n marshall
2018-08-28 11:34:26 -07:00
committed by GitHub
parent 512c746a53 7ee9b6bc3e
commit 6344f0b530
1 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
core/field_textinput.js
View File

@@ -106,18 +106,17 @@ Blockly.FieldTextInput.prototype.dispose = function() {
* @override
*/
Blockly.FieldTextInput.prototype.setValue = function(newValue) {
if (newValue === null) {
return; // No change if null.
}
if (this.sourceBlock_) {
var validated = this.callValidator(newValue);
// If the new value is invalid, validation returns null.
// In this case we still want to display the illegal result.
if (validated !== null) {
newValue = validated;
if (newValue !== null) { // No change if null.
if (this.sourceBlock_) {
var validated = this.callValidator(newValue);
// If the new value is invalid, validation returns null.
// In this case we still want to display the illegal result.
if (validated !== null) {
newValue = validated;
}
}
Blockly.Field.prototype.setValue.call(this, newValue);
}
Blockly.Field.prototype.setValue.call(this, newValue);
};
/**
@@ -369,6 +368,11 @@ Blockly.FieldTextInput.prototype.widgetDispose_ = function() {
};
};
/**
* Attempt to save the text field changes when the user input loses focus.
* If the value is not valid, revert to the default value.
* @private
*/
Blockly.FieldTextInput.prototype.maybeSaveEdit_ = function() {
var htmlInput = Blockly.FieldTextInput.htmlInput_;
// Save the edit (if it validates).