CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-11 19:07:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup for #3179 (#3229)

Browse Source
This commit is contained in:
RoboErikG
2019-10-14 09:57:38 -07:00
committed by GitHub
parent c98bf02012
commit d09b85dc9e
2 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
core/field_angle.js
View File

@@ -173,6 +173,7 @@ Blockly.FieldAngle.prototype.configure_ = function(config) {
this.clockwise_ = clockwise;
}
// If these are passed as null then we should leave them on the default.
var offset = config['offset'];
if (offset != null) {
offset = Number(offset);

13
tests/mocha/field_number_test.js
View File

@@ -247,11 +247,10 @@ suite('Number Fields', function() {
numberField.setValue(123.456);
assertValue(numberField, 123);
});
test('null', function() {
test('Null', function() {
var numberField = new Blockly.FieldNumber
.fromJson({ precision: null});
numberField.setValue(123.456);
assertValue(numberField, 123.456);
assertEquals(numberField.getPrecision(), 0);
});
});
suite('Min', function() {
@@ -282,11 +281,10 @@ suite('Number Fields', function() {
numberField.setValue(20);
assertValue(numberField, 20);
});
test('null', function() {
test('Null', function() {
var numberField = new Blockly.FieldNumber
.fromJson({ min: null});
numberField.setValue(-20);
assertValue(numberField, -20);
assertEquals(numberField.getMin(), -Infinity);
});
});
suite('Max', function() {
@@ -320,8 +318,7 @@ suite('Number Fields', function() {
test('null', function() {
var numberField = new Blockly.FieldNumber
.fromJson({ max: null});
numberField.setValue(20);
assertValue(numberField, 20);
assertEquals(numberField.getMax(), Infinity);
});
});
});