CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-16 13:27:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

Update goog_module.md with suggested fixes

Browse Source 
* Fix typos.
* Reinstate "Proposed Changes" section.
* Mark text that should be edit with ALL CAPS.
This commit is contained in:
Christopher Allen
2021-07-15 11:24:15 +01:00
committed by Christopher Allen
parent 36fa8604df
commit d4196c1105
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
.github/PULL_REQUEST_TEMPLATE/goog_module.md vendored
View File

@@ -1,20 +1,24 @@
<!-- Suggested PR title: Migrate path/to/file.js to goog.module syntax -->
<!-- Suggested PR title: Migrate PATH/TO/FILE.js to goog.module syntax -->
## The basics
- [ ] I branched from `goog.module`
- [ ] My pull request is against `goog.module`
- [ ] I branched from `goog_module`
- [ ] My pull request is against `goog_module`
- [ ] My code follows the [style guide](
https://developers.google.com/blockly/guides/modify/web/style-guide)
- [ ] My code is presented in the form suggeseted in the [module
- [ ] My code is presented in the form suggested in the [module
conversion guide](https://github.com/google/blockly/issues/5026)
- [ ] I have run `npm test` locally already.
- [ ] I have run `npm test`.
## The details
### Resolves
Part of #5026
### Proposed Changes
Converts `PATH/TO/FILE.js` to `goog.module` with ES6 `const`/`let`.
### Additional Information
<!-- Anything else we should know? -->