Commit Graph

9310 Commits

Author SHA1 Message Date
Ben Henning 902b26b1a1 chore: part 1 of addressing reviewer comments. 2025-04-03 22:25:50 +00:00
Aaron Dodson ca362725ee refactor!: Backport LineCursor to core. (#8834)
* refactor: Backport LineCursor to core.

* fix: Fix instantiation of LineCursor.

* fix: Fix tests.

* chore: Assauge the linter.

* chore: Fix some typos.

* feat: Make padding configurable for scrollBoundsIntoView.

* chore: Merge in the latest changes from keyboard-experimentation.

* refactor: Clarify name and docs for findSiblingOrParentSibling().

* fix: Improve scrollBoundsIntoView() behavior.

* fix: Export CursorOptions.

* refactor: Further clarify second parameter of setCurNode().

* fix: Revert change that could prevent scrolling bounds into view.
2025-04-03 12:15:17 -07:00
Ben Henning 209de217d6 Merge pull request #8831 from google/dependabot/npm_and_yarn/develop/eslint-plugin-jsdoc-50.6.9
chore(deps): bump eslint-plugin-jsdoc from 50.6.0 to 50.6.9
2025-04-01 15:18:29 -07:00
Aaron Dodson 7171350992 fix!: Tighten and correct typings on ASTNode (#8835)
* fix!: Tighten typings on ASTNode.create*Node() methods.

* fix: Restore missing condition.

* fix: Fix unsafe casts, non-null assertions and incorrect types.

* refactor: Simplify parent input checks.
2025-04-01 14:59:40 -07:00
dependabot[bot] d85fcef1d8 chore(deps): bump eslint-plugin-jsdoc from 50.6.0 to 50.6.9
Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 50.6.0 to 50.6.9.
- [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases)
- [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc)
- [Commits](https://github.com/gajus/eslint-plugin-jsdoc/compare/v50.6.0...v50.6.9)

---
updated-dependencies:
- dependency-name: eslint-plugin-jsdoc
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-03-31 09:53:41 +00:00
RoboErikG 212f13af08 feat: Add a method for creating flyout options (#8829) 2025-03-28 14:02:28 -07:00
Aaron Dodson 7a07b4b2ba refactor!: Remove old cursor and tab support. (#8803) 2025-03-28 13:54:33 -07:00
Ben Henning 3dc4d17b30 Update tests/mocha/index.html 2025-03-27 16:54:19 -07:00
Ben Henning 9ab77cedff chore: fix formatting issues 2025-03-27 22:04:51 +00:00
Ben Henning 516e3af936 feat: finish core impl + tests
This adds new tests for the FocusableTreeTraverser and fixes a number of
issues with the original implementation (one of which required two new
API methods to be added to IFocusableTree). More tests have also been
added for FocusManager, and defocusing tracked nodes/trees has been
fully implemented in FocusManager.
2025-03-27 21:57:30 +00:00
Ben Henning ad6bbbc740 Merge pull request #8806 from google/dependabot/npm_and_yarn/develop/eslint-config-prettier-10.1.1
chore(deps): bump eslint-config-prettier from 9.1.0 to 10.1.1
2025-03-26 14:06:16 -07:00
dependabot[bot] 74ad061ef4 chore(deps): bump chai from 5.1.2 to 5.2.0 (#8807)
Bumps [chai](https://github.com/chaijs/chai) from 5.1.2 to 5.2.0.
- [Release notes](https://github.com/chaijs/chai/releases)
- [Changelog](https://github.com/chaijs/chai/blob/main/History.md)
- [Commits](https://github.com/chaijs/chai/compare/v5.1.2...v5.2.0)

---
updated-dependencies:
- dependency-name: chai
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-26 10:46:15 -07:00
Aaron Dodson e6155fd254 Merge pull request #8813 from google/master
chore: Merge `master` back into `develop` following 11.2.2 release
2025-03-25 14:51:38 -07:00
zhiyan wang 63a4df6533 fix: fix bug that modalInputs option is not working in toolbox area (#8817) 2025-03-24 13:18:30 -07:00
Ben Henning d9beacddb4 feat: add FocusManager
This is the bulk of the work for introducing the central logical unit
for managing and sychronizing focus as a first-class Blockly concept
with that of DOM focus.

There's a lot to do yet, including:
- Ensuring clicks within Blockly's scope correctly sync back to focus
  changes.
- Adding support for, and testing, cases when focus is lost from all
  registered trees.
- Testing nested tree propagation.
- Testing the traverser utility class.
- Adding implementations for IFocusableTree and IFocusableNode
  throughout Blockly.
2025-03-21 00:33:51 +00:00
Aaron Dodson e02d3853ee release: Update version number to 12.0.0-beta.2 blockly-v12.0.0-beta.2 2025-03-20 14:37:18 -07:00
Aaron Dodson 4141230bcd Merge pull request #8812 from google/rc/v11.2.2
release: v11.2.2
blockly-v11.2.2
2025-03-20 14:15:01 -07:00
Aaron Dodson ae25b32dd8 release: Update version number to 11.2.2 2025-03-20 11:13:22 -07:00
Aaron Dodson 74014736a8 release: Merge branch 'develop' into rc/v11.2.2 2025-03-20 11:12:39 -07:00
Aaron Dodson 0f07567965 fix: Allow the marker's current node to be null. (#8802) 2025-03-20 09:46:31 -07:00
Aaron Dodson df616e83e5 chore: Try adding additional permissions. (#8810) 2025-03-19 09:58:38 -07:00
Aaron Dodson 6b424457b0 chore: Update permissions on GitHub actions. (#8809) 2025-03-18 09:57:23 -07:00
Aaron Dodson a1f739334a chore: Update permissions on GitHub actions. (#8808) 2025-03-18 09:21:37 -07:00
dependabot[bot] 629d6e05bb chore(deps): bump eslint-config-prettier from 9.1.0 to 10.1.1
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 9.1.0 to 10.1.1.
- [Release notes](https://github.com/prettier/eslint-config-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prettier/eslint-config-prettier/compare/v9.1.0...v10.1.1)

---
updated-dependencies:
- dependency-name: eslint-config-prettier
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-03-17 09:45:05 +00:00
Aaron Dodson 0983c43bc4 Merge pull request #8798 from google/develop-v12-merge
chore: Merge develop into rc/v12.0.0
2025-03-12 13:29:12 -07:00
Aaron Dodson 00d77456c9 Revert "fix!: Remove the blocklyMenuItemHighlight CSS class and use the hover…" (#8800)
This reverts commit d6125d4fb9.
2025-03-12 09:27:47 -07:00
Aaron Dodson b8f71b83b7 Merge branch 'rc/v12.0.0' into develop-v12-merge 2025-03-11 09:42:25 -07:00
dependabot[bot] 87efad0670 chore(deps): bump glob from 10.4.1 to 11.0.1 (#8730)
Bumps [glob](https://github.com/isaacs/node-glob) from 10.4.1 to 11.0.1.
- [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md)
- [Commits](https://github.com/isaacs/node-glob/compare/v10.4.1...v11.0.1)

---
updated-dependencies:
- dependency-name: glob
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-10 17:47:10 +00:00
dependabot[bot] 810dd72970 chore(deps): bump eslint-plugin-prettier from 5.2.1 to 5.2.3 (#8777)
Bumps [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) from 5.2.1 to 5.2.3.
- [Release notes](https://github.com/prettier/eslint-plugin-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/prettier/eslint-plugin-prettier/compare/v5.2.1...v5.2.3)

---
updated-dependencies:
- dependency-name: eslint-plugin-prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-10 16:45:30 +00:00
dependabot[bot] d3f0c6d589 chore(deps): bump @hyperjump/json-schema from 1.9.8 to 1.11.0 (#8760)
Bumps [@hyperjump/json-schema](https://github.com/hyperjump-io/json-schema) from 1.9.8 to 1.11.0.
- [Commits](https://github.com/hyperjump-io/json-schema/compare/v1.9.8...v1.11.0)

---
updated-dependencies:
- dependency-name: "@hyperjump/json-schema"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-10 16:40:48 +00:00
dependabot[bot] fd558106b1 chore(deps): bump google-github-actions/deploy-appengine (#8755)
Bumps [google-github-actions/deploy-appengine](https://github.com/google-github-actions/deploy-appengine) from 2.1.4 to 2.1.5.
- [Release notes](https://github.com/google-github-actions/deploy-appengine/releases)
- [Changelog](https://github.com/google-github-actions/deploy-appengine/blob/main/CHANGELOG.md)
- [Commits](https://github.com/google-github-actions/deploy-appengine/compare/v2.1.4...v2.1.5)

---
updated-dependencies:
- dependency-name: google-github-actions/deploy-appengine
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-10 16:39:38 +00:00
Aaron Dodson fa4fce5c12 feat!: Added support for separators in menus. (#8767)
* feat!: Added support for separators in menus.

* chore: Do English gooder.

* fix: Remove menu separators from the DOM during dispose.
2025-02-27 14:00:40 -08:00
Aaron Dodson dcd2d0e539 fix: Fix a bug where selection outlines could be cut off when connecting blocks. (#8789) 2025-02-27 13:04:37 -08:00
Aaron Dodson 0ed6c82acc fix: Disallow and ignore x and y attributes for blocks in toolbox definitions. (#8785)
* fix: Disallow and ignore x and y attributes for blocks in toolbox definitions.

* chore: Clarify comment in BlockFlyoutInflater.
2025-02-27 10:55:34 -08:00
Aaron Dodson 22dbd75bd4 refactor: make CommentView more amenable to subclassing. (#8783) 2025-02-24 08:17:38 -08:00
michaela-mm d016801089 fix: Fix bug in IF block generators. (#8780) 2025-02-24 14:35:33 +00:00
Aaron Dodson 7e44e81e42 fix: Fix bug that prevented editing workspace comments on Firefox. (#8779)
* fix: Fix bug that prevented editing workspace comments on Firefox.

* chore: Add a docstring for getTextArea().

* refactor: Use isTargetInput() instead of comparing to comment textarea.
2025-02-20 09:56:41 -08:00
RoboErikG b343a13bbe fix: Fixes #8764 by moving the event grouping calls up to dragger.ts (#8781) 2025-02-20 08:56:57 -08:00
Ben Henning 8c25c1f8ed Merge pull request #8774 from BenHenning/introduce-focus-system-interfaces
feat: Add interfaces for focus management
2025-02-19 15:53:20 -08:00
Ben Henning de076a7cf5 Empty commit to re-trigger CI flows.
They didn't trigger automatically after a force push.
2025-02-19 23:51:08 +00:00
Ben Henning 3ae422a566 feat: Add interfaces for focus management.
Introduces the necessary base interfaces for representing different
focusable contexts within Blockly. The actual logic for utilizing and
implementing these interfaces will come in later PRs.
2025-02-19 23:03:21 +00:00
Aaron Dodson 29950fd872 fix: Allow dragging blocks from the far lower right corner. (#8766) 2025-02-12 14:22:14 -08:00
RoboErikG 15d6ea2558 Fix: #8194 by using a stepped animation for the wiggle (#8743)
* Fix #8194 by using animation steps for the wiggle

* Formatting cleanup
2025-02-12 13:16:35 -08:00
Aaron Dodson 58406af64f fix: Fix menu scrolling. (#8765)
* Revert "fix: Fix bug that preventing scrolling menu items into view. (#8726)"

This reverts commit f166b677c0.

* fix: Fix menu scrolling.
2025-02-12 11:53:16 -08:00
dependabot[bot] db57976e10 chore(deps): bump typescript-eslint from 8.16.0 to 8.23.0 (#8761)
Bumps [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) from 8.16.0 to 8.23.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.23.0/packages/typescript-eslint)

---
updated-dependencies:
- dependency-name: typescript-eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-10 08:37:15 -08:00
Aaron Dodson 8fcc73097f fix: Improve menu mouse/keyboard selection interaction. (#8749)
* chore: Use "pointer" instead of "mouse" in menu.ts.

* fix: Only highlight menu items on hover if the pointer has moved.

* fix: Don't blur menus on pointerleave.
2025-02-04 15:47:25 -08:00
Aaron Dodson e6e57ddc01 fix: Fix bug that caused blocks dragged from non-primary flyouts to be misplaced. (#8753)
* fix: Fix bug that caused blocks dragged from non-primary flyouts to be misplaced.

* chore: Fix docstring.
2025-02-04 15:23:03 -08:00
dependabot[bot] 101ad82826 chore(deps): bump @microsoft/api-documenter from 7.25.14 to 7.26.7 (#8757)
Bumps [@microsoft/api-documenter](https://github.com/microsoft/rushstack/tree/HEAD/apps/api-documenter) from 7.25.14 to 7.26.7.
- [Changelog](https://github.com/microsoft/rushstack/blob/main/apps/api-documenter/CHANGELOG.md)
- [Commits](https://github.com/microsoft/rushstack/commits/@microsoft/api-documenter_v7.26.7/apps/api-documenter)

---
updated-dependencies:
- dependency-name: "@microsoft/api-documenter"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-03 08:25:39 -08:00
Aaron Dodson 34da1da061 fix: Fix flaky connection checker test. (#8754) 2025-01-31 08:10:33 -08:00
Aaron Dodson 343c2f51f3 feat: Add support for toggling readonly mode. (#8750)
* feat: Add methods for toggling and inspecting the readonly state of a workspace.

* refactor: Use the new readonly setters/getters in place of checking the injection options.

* fix: Fix bug that allowed dragging blocks from a flyout onto a readonly workspace.

* feat: Toggle a `blocklyReadOnly` class when readonly status is changed.

* chore: Placate the linter.

* chore: Placate the compiler.
2025-01-30 13:47:36 -08:00