Commit Graph

3559 Commits

Author SHA1 Message Date
alschmiedt
0141c9f51a Updates issue template 2019-07-02 14:09:29 -07:00
alschmiedt
6a32e196bf Update github templates 2019-07-02 13:29:50 -07:00
Rachel Fenichel
a45b0b1d85 Merge pull request #2597 from rachel-fenichel/svg_utils
Create svg_utils file
2019-06-28 16:55:39 -07:00
Rachel Fenichel
f2be890f9f More cleanup 2019-06-28 16:55:04 -07:00
Neil Fraser
d23dc0ae55 Minor cleanup from #2581 2019-06-28 16:47:12 -07:00
Neil Fraser
712576a5b1 Fix IE not unhighlighting
This is a rework of PR #2580.
2019-06-28 16:47:12 -07:00
Rachel Fenichel
2aa1bed83f Add some spaces 2019-06-28 16:36:59 -07:00
Rachel Fenichel
f1e05b1e68 Lowercase l in comments 2019-06-28 15:09:59 -07:00
Rachel Fenichel
1f82f9d9e2 Create svg_utils file 2019-06-28 15:00:09 -07:00
Neil Fraser
cbd944106c Strip silly code
Sigh.
2019-06-26 13:55:55 -07:00
Neil Fraser
3a77a3d7ce Define colours of standard categories by hue.
Previously they were defined in hex.
This meant that saturation and value were hardcoded.
This also resulted in off-by-one errors (Math was hardcoded as #5C68A6, but is calculated as #5B67A5) which in turn resulted in the colour not being highlighted in the picker.
2019-06-26 13:55:55 -07:00
Neil Fraser
ef28773a52 Enable selection of “no colour” on categories.
Near complete rewrite of colour picker for Blockly Factory.
* Drop IE6 support.
* Flip picker as needed so it doesn’t go offscreen.
* Add support for no colour.
* Factor CSS out of JS.
* Provide palette of our standard colours.
2019-06-26 13:55:55 -07:00
Neil Fraser
7e048f2e09 Remove last Closure from Block Factory.
Improves UI, but is still pretty clunky.  For example there’s still not way to choose “no colour”.
Closes #668.
2019-06-26 13:55:55 -07:00
alschmiedt
83c5d27143 Merge pull request #2576 from BeksOmega/fixes/ProcedureRenaming
Added Procedure Tests
2019-06-26 07:33:28 -07:00
Beka Westberg
b34ca2f93b Fixed review comments. 2019-06-25 15:08:01 -07:00
Beka Westberg
347519b2a1 Added all block files to mocha index. 2019-06-25 15:08:01 -07:00
Beka Westberg
427291c05d Added skipping bad variable test. 2019-06-25 15:08:01 -07:00
Beka Westberg
2620a5092e Added message.js to mocha tests file. 2019-06-25 15:08:01 -07:00
Beka Westberg
942c7c2a38 Deleted inaccurate jsunit procedure tests. 2019-06-25 15:08:01 -07:00
Beka Westberg
85c4e4129f Added procedure tests. 2019-06-25 15:08:01 -07:00
alschmiedt
a8dc8359c5 Merge pull request #2587 from BeksOmega/fixes/ImagesAndTextDropdown
Fixed Rendering of Images & Text Dropdown
2019-06-24 17:19:58 -07:00
alschmiedt
55fc506782 Merge pull request #2577 from BeksOmega/fixes/doValueInvalid
Added Sending the Bad Value to doValueInvalid
2019-06-24 16:09:20 -07:00
Beka Westberg
5a4cc7ae12 Removed textToDom Needing <xml> Documents (#2585)
* Removed textToDom needing <xml> documents.

* Fixed jsdoc.

* Followon changes resulting from lack of XML tag.

* Fix Mocha test.
2019-06-24 15:50:06 -07:00
Beka Westberg
3227223c82 Renamed _newValue param to _invalidValue. 2019-06-24 14:58:33 -07:00
Beka Westberg
27a6593d27 Removed Class Option Check from Text Input fromJson (#2588)
* Removed class option check from text input fromJson, as text input fields don't accept a class.

* Fixed syntax error.
2019-06-24 13:34:28 -07:00
Beka Westberg
b98eef2ae2 Fixed rendering of images & text dropdown. 2019-06-24 10:20:26 -07:00
translatewiki.net
fd368820ef Localisation updates from https://translatewiki.net. 2019-06-24 16:41:32 +02:00
Rachel Fenichel
2d334c154f Merge pull request #2583 from nicholascioli/develop
upgrade gulp to v4
2019-06-21 16:07:14 -07:00
Nicholas Cioli
a5717fb333 upgrade gulp to v4
As of NodeJS v12, gulp v3 fails to run at all. This small change
should allow for future compatibility with NodeJS.
2019-06-21 17:43:21 -05:00
amber-cd
492d0719d6 Pull Request: Split showContextMenu_ (#2581)
* Split showContextMenu_

Split showContextMenu_ into generateContextMenu_ and showContextMenu_. This allows for custom Blockly forks to easily extend the context menu options available on all blocks by just doing something like

```
var oldGenerateContextMenu_ = Blockly.BlockSvg.prototype.generateContextMenu_;
Blockly.BlockSvg.prototype.generateContextMenu_ = function() {
  var menuOptions = Blockly.BlockSvg.prototype.generateContextMenu_() || [];
  // Push other options into menuOptions
  return menuOptions;
}
```

Rather than having to modify the core code in such a way as to cause unnecessary maintenance overhead when upgrading Blockly versions.

* Forgot the docblock, sorry

* Oops, missed a few ESLint things

* Update block_svg.js

Updated to be protected rather than private.
2019-06-21 15:14:11 -07:00
Beka Westberg
69e2eae218 Fixed setTooltip not working before appendField(). (#2578) 2019-06-21 13:36:25 -07:00
translatewiki.net
028d89f8d5 Localisation updates from https://translatewiki.net. 2019-06-20 21:27:25 +02:00
Beka Westberg
4a0d5f5df0 Added sending the bad value to doValueInvalid. 2019-06-14 12:00:10 -07:00
Rachel Fenichel
2aa05c6d6d Merge pull request #2568 from BeksOmega/tests/Trashcan
Added Trashcan Tests
2019-06-13 14:49:48 -07:00
translatewiki.net
bffd8dde62 Localisation updates from https://translatewiki.net. 2019-06-13 20:00:53 +02:00
Beka Westberg
2463a754db Updated TODO's. 2019-06-12 18:36:50 -07:00
Beka Westberg
406c6aca76 Changed sendDeleteEvent to append <xml> tags. Fixed bad <next> tests. 2019-06-12 18:25:44 -07:00
Beka Westberg
6665e46cd1 Removed test cases that never actually occure. 2019-06-12 18:12:19 -07:00
Neil Fraser
9f6c1c316a Refactor workspace.connectionDBList
It seems wrong that Blockly.ConnectionDB.init reaches in to create a property on workspace.
It seems wrong that this database isn’t disposed of when the workspace is.
It seems unnecessary that disposed connections need to drop their reference *to* the workspace’s database since the connection object is going away anyway, and the databases aren’t.
2019-06-12 13:15:39 -07:00
Neil Fraser
74f908d77f Fix escaping issue in Code demo.
Resolves #1002
2019-06-12 10:59:33 -07:00
Neil Fraser
f1c73e2244 Rename helper function 2019-06-12 10:59:33 -07:00
Neil Fraser
b8cbd9e7df Resolve 13 warnings
Reduce count from 632 to 619.
Eliminate copy-paste code duplication in Field.prototype.setValue
2019-06-12 10:59:33 -07:00
Beka Westberg
bf6d621c63 Added colour and date editor auto close on selection. 2019-06-11 16:22:24 -07:00
Beka Westberg
d05ce11736 Added trashcan tests. 2019-06-11 15:24:58 -07:00
Rachel Fenichel
4e1224dbab Merge pull request #2551 from BeksOmega/fixes/FieldDisposal
Fixed Field Disposal, and Reorganized Editor Creation
2019-06-11 14:48:46 -07:00
Beka Westberg
efdfec6d8a Fixed last rebase error. 2019-06-11 14:29:19 -07:00
Beka Westberg
6f69b85639 Removed unnecessary todo's. 2019-06-11 14:24:48 -07:00
Beka Westberg
4b0397de17 Cleaned up utils renamings. Readded widget div hide in field angle. 2019-06-11 13:48:01 -07:00
Beka Westberg
392119680e Fixed misc PR comments. 2019-06-11 13:32:10 -07:00
Beka Westberg
2af17fd782 Removed obsolete widgetDiv check in tooltip code. 2019-06-11 13:32:10 -07:00