Commit Graph

2622 Commits

Author SHA1 Message Date
Maribeth Bottorff
c13880d4d0 Use camel case for registry types (#4199) 2020-08-20 09:21:45 -07:00
Beka Westberg
2e2a5c230e Fix lastMarker_ disposal (#4184) 2020-08-19 13:21:44 -07:00
Sam El-Husseini
af571e27df Call apply colour when inserting a field to a block that has already been renderered (#4183) 2020-08-17 14:08:03 -07:00
Monica Kozbial
a89ff37bd8 Add checks to WorkspaceSvg dispose and fix shared Workspace tests (#4170)
* Fix workspace tests and add add checks for WorkspaceSvg dispose

* Move flyout test to WorkspaceSvg
2020-08-17 10:32:55 -07:00
Monica Kozbial
0a36117885 Replace console "WARNING" log calls with warn call (#4171) 2020-08-13 10:53:04 -07:00
Beka Westberg
111b47980d Fix toolbox sizes not being updated properly (#4139)
* Fix toolbox changing size

* Fix flyout changing size

* Fix mutator bumping blocks

* Fix accessing .flyout_
2020-08-13 08:19:40 -07:00
Monica Kozbial
f8f98831af Add zoom controls tests. (#4159) 2020-08-12 18:39:35 -07:00
Rachel Fenichel
0951b5e613 Update eslintrc for eslint v7, and resolve new lint errors 2020-08-10 15:10:48 -07:00
Maribeth Bottorff
9568d3f2cc Add tests for contextmenu_items (#4118)
Add tests for context menu items
2020-08-10 11:46:10 -07:00
mfallihee
254fb60481 Use toLocaleString to count decimal places consistently (#4124) 2020-08-10 10:47:14 -07:00
Monica Kozbial
12b5658109 Rename trashcan api calls for open/close lid. (#4110)
* Rename trashcan api calls for open/close lid.

* Update comments.
2020-08-05 12:25:35 -07:00
Rachel Fenichel
4368f97f85 Merge pull request #4079 from rachel-fenichel/deprecation_warnings
Deprecation warnings
2020-08-05 10:24:09 -07:00
Rachel Fenichel
f27354d8ab PR comments 2020-08-05 10:09:18 -07:00
seldomU
ade149d77c flyout button stores all the deserialized properties (#4107)
The properties can be useful for callbacks, see https://github.com/google/blockly/issues/4027#issuecomment-656325534
2020-08-05 07:54:19 -07:00
Sam El-Husseini
f3fdab11fb Add IBubble interface (#4104)
* Add IBubble interface and make use of it for WorkspaceCommentSvgs
2020-08-04 17:28:12 -04:00
Sam El-Husseini
4a2b0b583c Add option sub types (#4096)
* Add option types
2020-08-03 12:33:07 -07:00
Sam El-Husseini
51bbc2d9bb Move events into the global registry (#4053)
* Move events into the global registry
2020-08-03 08:11:58 -07:00
Rachel Fenichel
b72c5736b1 December 2020-07-28 10:55:48 -07:00
Rachel Fenichel
b296ccae97 Add formal deprecation warnings 2020-07-28 10:51:28 -07:00
Sam El-Husseini
5d43d256e2 Move test blocks to dev-tools, refactor advanced playground (#4057)
* Remove remaining advanced playground actions, and remove test blocks
2020-07-24 13:53:00 -07:00
alschmiedt
0f00f42580 Adds Ability to Add a Flyout as a Plugin (#4059) 2020-07-22 17:13:19 -07:00
Monica Kozbial
26993a120f Emitting event on trashcan close. (#4056)
* Emitting event on trashcan close.
2020-07-21 13:14:29 -07:00
Monica Kozbial
e88ec53425 Hide flyout after Events are re-enabled when creating a block (#4055) 2020-07-21 12:58:40 -07:00
Monica Kozbial
64488c1402 Add listener for flyout events to playground. (#4035)
* Update workspace click and add listener for flyout events to playground.

* Fix test.

* Fix typing error

* change variable

* Update variable.
2020-07-20 14:00:03 -07:00
Rachel Fenichel
98b436031c Use registry for connection checker 2020-07-17 10:51:39 -06:00
Rachel Fenichel
815c8b8919 More deprecation 2020-07-16 17:49:51 -06:00
Rachel Fenichel
602d1b6d63 Use new deprecation warning helper 2020-07-16 17:46:49 -06:00
Rachel Fenichel
1700efc77b Add distance parameter to canConnect 2020-07-16 17:40:13 -06:00
Rachel Fenichel
3322834a9b Add deprecation warnings and tests 2020-07-16 17:40:13 -06:00
Rachel Fenichel
745017f325 Move from one, two to a, b 2020-07-16 17:40:13 -06:00
Rachel Fenichel
e47d33148e Review feedback 2020-07-16 17:40:13 -06:00
Rachel Fenichel
809148b435 Fix compiler errors 2020-07-16 17:40:13 -06:00
Rachel Fenichel
7288c66294 Rename connectionTypeChecker->connectionChecker 2020-07-16 17:40:13 -06:00
Rachel Fenichel
8ae3dc3d5e Cleanup 2020-07-16 17:40:13 -06:00
Rachel Fenichel
e24f3cef9b Add isDragging to canConnectWithReason and delete newly unused code paths. 2020-07-16 17:40:13 -06:00
Rachel Fenichel
e3c8d834cb Add todos and rebuild 2020-07-16 17:40:13 -06:00
Rachel Fenichel
01d33ce2e7 Fix type checks 2020-07-16 17:40:13 -06:00
Rachel Fenichel
450aed0aa2 More work on connection type checks 2020-07-16 17:40:12 -06:00
Rachel Fenichel
bb8348befd Move to a single canConnect function, and update tests 2020-07-16 17:40:12 -06:00
Rachel Fenichel
8c17e325b5 Update connection tests to directly use the type checker 2020-07-16 17:40:12 -06:00
Rachel Fenichel
c743a92bb9 Start work on connection type checker 2020-07-16 17:40:12 -06:00
Rachel Fenichel
5b393eed76 More cleanup 2020-07-16 14:11:48 -06:00
Rachel Fenichel
6990ac5efd Fix annotation and remove redundant 'Blockly.' 2020-07-16 14:08:27 -06:00
Rachel Fenichel
2f5663b1ec Add deprecation helper + 2 uses 2020-07-16 13:59:32 -06:00
Eric Anderson
2b8208b1e2 Perf: Move multiline xml text encoding out of domToText (#4046)
* Move multiline xml text encoding out of domToText
2020-07-14 16:32:12 -07:00
Sam El-Husseini
0f3db47fa5 Use generics to derive SVG element type (#4036)
* Encapsulate type in a generic to automatically derive type of SVG element when using createSvgElement
2020-07-13 10:40:31 -07:00
Maribeth Bottorff
e4bbd451a3 Use Context Menu registry for block-level menu options (#4032)
Use registry for block-level context menu items.
2020-07-10 19:11:48 -07:00
Monica Kozbial
40efb59a34 Unbind event handlers in dispose of zoom controls. (#4031)
* Unbind event handlers in dispose of zoom controls.

* Move event handler references to constructor.
2020-07-10 17:34:53 -07:00
Monica Kozbial
d3b8b78035 Update click event handling for workspace and trashcan. (#4024)
* Update click event handling for workspace and trashcan.

* Fix typo

* Change event name for trashcan flyout open
2020-07-10 13:23:08 -07:00
Monica Kozbial
fdd0f4f25f Emit UI event on zoom control clicks. (#4025)
* Emit UI event on zoom control clicks.

* Fix typo

* Update jsdoc for mouse event handlers.
2020-07-10 10:15:09 -07:00