Aaron Dodson
0d44d22629
Revert "Reflow flyouts when zoom level changes to keep block zoom level in sync."
...
This reverts commit 1f6c8f0206 .
2021-06-28 10:48:36 -07:00
Aaron Dodson
1f6c8f0206
Reflow flyouts when zoom level changes to keep block zoom level in sync.
2021-06-18 20:26:17 +00:00
Monica Kozbial
7b286dbf82
Update the registered component ids ( #4898 )
2021-06-17 17:50:04 -07:00
Aaron Dodson
245a44b030
Merge pull request #4920 from gonfunko/capture-warning
...
Use captureWarning helper from dev-tools instead of mocha/test_helpers.js implementation
2021-06-17 16:04:23 -07:00
Monica Kozbial
7d45b531ac
Update toolbox drag target when visibility changes ( #4919 )
2021-06-17 15:17:36 -07:00
Aaron Dodson
ad7a40dac4
Merge pull request #4927 from gonfunko/flyout-delete
...
Fixed bug that prevented delete areas from updating when flyout width changed.
2021-06-17 08:54:09 -07:00
Aaron Dodson
50fcdfb7ac
Keep horizontal flyout delete area in sync with its bounds.
2021-06-17 15:39:15 +00:00
Aaron Dodson
de220a3ff0
Fixed bug that prevented delete areas from updating when flyout width changed.
2021-06-16 20:08:44 +00:00
Neil Fraser
36d25343f4
Don’t hide insertion marker if it’s already gone
...
Fixes #2338 .
I also looked at having workspace.clear delete any insertion marker, but there doesn’t appear to be a public API for this. Shouldn’t matter, this should be sufficient.
2021-06-16 11:48:34 -07:00
Aaron Dodson
9fa6b03789
Merge pull request #4925 from gonfunko/copy-paste
...
Prevent an error beep when copying blocks in Safari.
2021-06-16 11:16:51 -07:00
Aaron Dodson
7a456a048b
Prevent an error beep when copying blocks in Safari.
2021-06-16 17:51:36 +00:00
Monica Kozbial
a15bbf1700
Revert #4697 ( #4917 )
2021-06-16 09:36:39 -07:00
alschmiedt
a46dbb37e7
Fixes workspace scroll bug ( #4921 )
2021-06-16 08:18:28 -07:00
jschanker
672574b056
Require field name to be string, test changes
...
* Now throws error for getField/getFieldValue/setFieldValue if provided name is not a string
* Changed error to more specific TypeError
* Type checking and error message moved up to getField
* Tests added/modified to check that non-string types for field names produce type errors
2021-06-16 10:46:05 +01:00
jschanker
62bb663b38
Added tests/setFieldValue error message
...
* Added tests for getting/setting field (values) when names are not supplied and test for getting a field value, setting it to a new value, and getting it again.
* Added more user-friendly error message for setFieldValue telling the developer that he/she is missing the name rather than Field "undefined" not found.
* Fixed lint error by removing trailing space
2021-06-16 10:46:05 +01:00
jschanker
f9c5260fb0
Added tests/setFieldValue error message
...
* Added tests for getting/setting field (values) when names are not supplied and test for getting a field value, setting it to a new value, and getting it again.
* Added more user-friendly error message for setFieldValue telling the developer that he/she is missing the name rather than Field "undefined" not found.
2021-06-16 10:46:05 +01:00
jschanker
ee8e282360
Fix #4830 for getting/setting unnamed fields
...
* Returns null when getting unnamed field (value), throws error Field "undefined" not found when attempting to set value of unnamed field
2021-06-16 10:46:05 +01:00
Aaron Dodson
355c54f70a
Use captureWarning helper from dev-tools instead of mocha/test_helpers.js implementation.
2021-06-15 19:10:13 +00:00
Monica Kozbial
e5a2df301a
Add msg files ( #4918 )
2021-06-15 11:27:36 -07:00
Aaron Dodson
f9702deab0
Merge pull request #4911 from gonfunko/ipad-useragent
...
Updated user agent parsing to detect iPads posing as desktop Safari.
2021-06-15 08:33:01 -07:00
Aaron Dodson
289d8ac857
Adjusted line wrapping.
2021-06-15 15:22:51 +00:00
Neil Fraser
0eef4f34f6
'navigator' may be renamed by the compiler.
...
Use quoted name instead. Also, navigator doesn't exist in Node, or non-browser environments.
2021-06-14 22:32:55 -07:00
Aaron Dodson
c29afbcd27
Updated user agent parsing to detect iPads posing as desktop Safari.
2021-06-14 22:14:46 +00:00
Aaron Dodson
8d8309e7e7
Merge pull request #4906 from gonfunko/test-suite
...
Use selenium-standalone-service to automatically start and stop Selenium when running the test suite.
2021-06-14 14:10:57 -07:00
Monica Kozbial
ff34e067f8
Update positionable jsdoc ( #4908 )
2021-06-14 13:14:01 -07:00
Aaron Dodson
65339377f4
Moved Typescript to devDependencies.
2021-06-14 19:40:41 +00:00
Monica Kozbial
1931c31aa6
Update JsDoc for IDragTarget ( #4907 )
2021-06-14 12:19:36 -07:00
Aaron Dodson
5cd2d375ef
Updated comment for runGeneratorsInBrowser to refer to Chrome instead of Firefox.
2021-06-14 19:06:28 +00:00
Aaron Dodson
384e88add1
Merge branch 'test-suite' of https://github.com/gonfunko/blockly into test-suite
2021-06-14 11:54:35 -07:00
Aaron Dodson
146840e09f
Updated CI config to run new simplified test target.
2021-06-14 18:54:13 +00:00
Aaron Dodson
df7da795a3
Use selenium-standalone-service to automatically start and stop Selenium when running the test suite.
2021-06-14 11:52:49 -07:00
Christopher Allen
e65a396809
Revert removal of node v10 from build matrix.
2021-06-14 19:41:12 +01:00
Christopher Allen
f94cb15021
Re-disable CI on macOS
...
I have been unable to resolve the mocha test issues, so leave macOS
disabled for the moment.
2021-06-14 19:41:12 +01:00
Christopher Allen
f477db2251
Remove unneeded macOS setup
...
Chrome comes pre-installed on GitHub hosted macOS runners, and while
`Xvfb` does not seem to be installed neither does it seem to be needed.
2021-06-14 19:41:12 +01:00
Christopher Allen
ab33cd567a
Update test setup for GitHub Actions
...
- Do the (hopefully now) correct test to check we are on macOS.
- Fix brew command-line syntax for installing google-chrome.
2021-06-14 19:41:12 +01:00
Christopher Allen
5cc0df775d
Reenable CI on macOS
...
Working on fixing #2114 .
2021-06-14 19:41:12 +01:00
Christopher Allen
403f3119a6
Bump node.js versions for CI
...
Remove v12 and add v16, per https://nodejs.org/en/about/releases/
2021-06-14 19:41:12 +01:00
Aaron Dodson
06352c0eea
Use selenium-standalone-service to automatically start and stop Selenium when running the test suite.
2021-06-14 17:27:01 +00:00
Monica Kozbial
34fce2c1cb
Moves toolbox cursor styling out of block_dragger ( #4896 )
2021-06-11 18:02:40 -07:00
Maribeth Bottorff
5a1533d1b0
Creates getLocationAfterMove in BlockDragger ( #4905 )
...
* Add getLocationAfterMove method to block dragger
* Renames and addresses comments
2021-06-11 17:32:27 -07:00
Monica Kozbial
a17cb7f12e
Adding parameter to dragEnter and dragExit ( #4890 )
...
* introduce IDraggable interface
* Add parameter to drag methods in IDragTarget
* combines bubble/drag methods on IDragTarget and IDeleteArea to take an IDraggable element
2021-06-11 12:58:26 -07:00
Neil Fraser
fb170b9052
Remove extra space in generator error message.
2021-06-11 12:12:14 -07:00
Monica Kozbial
8aeb78eff3
Revert bubble dragger logic change and helper name change ( #4897 )
...
* Revert accidental change in bubble drag logic
* Revert name change
2021-06-11 11:10:39 -07:00
Monica Kozbial
73b06f14bb
Fix bug in Flyout getClientRect ( #4901 )
2021-06-11 11:10:22 -07:00
alschmiedt
566b14e15f
Fixes block dragger after merge ( #4895 )
2021-06-10 16:54:33 -07:00
Monica Kozbial
2005576036
Add onDragOver and wouldDelete_ to DeleteArea ( #4888 )
...
* keep track of state for whether the block or bubble would be deleted for use with drag enter exit
* Check if block and bubble is deletable in IDeleteArea
* Add to jsdoc of IDeleteArea
2021-06-10 16:27:04 -07:00
Maribeth Bottorff
2c15a0dfb1
Merge pull request #4894 from maribethb/clone-coord
...
Add a clone method to Coordinate
2021-06-10 16:24:41 -07:00
Maribeth Bottorff
777b3f46d6
use clone
2021-06-10 16:17:12 -07:00
Monica Kozbial
e40093dc23
Add API to IDragTarget to prevent block move ( #4886 )
2021-06-10 16:17:07 -07:00
Maribeth Bottorff
c4f04a7a7b
Merge branch 'develop' of github.com:google/blockly into clone-coord
2021-06-10 16:15:25 -07:00