Commit Graph

1714 Commits

Author SHA1 Message Date
Tim Dawborn
14ee069543 Remove use of Array.prototype.includes which is not implemented in IE or Edge < 14. Fixes google/blockly#876. 2017-01-27 13:51:18 +11:00
Andrew n marshall
10108cc697 jsdoc corrections (#874) 2017-01-26 17:33:55 -08:00
Rachel Fenichel
3742788557 annotation updates 2017-01-26 16:37:35 -08:00
Rachel Fenichel
30a63e31dd Merge pull request #863 from rachel-fenichel/feature/custom_category
Enable custom flyout categories.
2017-01-26 15:43:47 -08:00
Andrew n marshall
624afeee94 Blockly.Extensions.buildTooltipForDropdown(..): Deferred validation. (#870)
Defer tooltip message string check until after load, when all Blockly.Msg should be loaded.
Avoids validation in headless mode, due to lack of document.readyState.
2017-01-26 15:12:32 -08:00
Andrew n marshall
5891288d60 .getOptions_() to .getOptions() (#869)
Fixes #867.
2017-01-26 09:52:00 -08:00
Tim Dawborn
e16058e95a Update the set of reserved words in Python to reflect the current state of Python (2.7 and 3.6). (#861) 2017-01-25 15:02:49 -08:00
Rachel Fenichel
0062658cfa Add some safety 2017-01-25 14:49:46 -08:00
Rachel Fenichel
4872a6ad7f Enable custom flyout categories. 2017-01-23 17:21:48 -08:00
Rachel Fenichel
a0b5aeb8d9 Merge pull request #862 from AnmAtAnm/math-blocks
Correcting math_change color
2017-01-23 17:05:24 -08:00
Andrew n marshall
709295a689 Correcting math_change color 2017-01-23 17:03:05 -08:00
Rachel Fenichel
9f564fba35 Merge pull request #859 from google/feature/readme_forum_ref
Update README.md
2017-01-23 15:27:33 -08:00
Rachel Fenichel
b8a465e739 Update README.md
Add a link to our forum.
2017-01-23 15:23:05 -08:00
Andrew n marshall
0da5dda1f0 Fixing JSON support for images in dropdowns. Adding tests. (#851)
Fixes #848.
2017-01-23 13:39:14 -08:00
Andrew n marshall
7b0275cd70 Porting math.js blocks to JSON (#846)
Moving all `math.js` definitions into a single JSON array, complete with i18n syntax for all messages, dropdowns, and tooltips.

Adding Blockly.Extensions.buildTooltipForDropdown(..) to facilitate the creation and error-checking of tooltips that update based on the value of a dropdown.

Now warn on raw string in JSON 'extensions'.
2017-01-23 10:23:55 -08:00
Tim Dawborn
46316c7cea Add a block to reverse a list (#844) 2017-01-21 10:48:42 -08:00
Rachel Fenichel
f6168e1364 Merge pull request #840 from rachel-fenichel/bugfix/procedure_rename
Use setValue in fieldTextInput so that procedure renaming works
2017-01-20 22:04:16 -08:00
Tim Dawborn
34750bccd8 New blocks text_count, text_replace, and text_reverse (#830)
Includes generators for all languages and units tests on those generators.
2017-01-20 16:08:27 -08:00
Andrew n marshall
fb0f1b05dd Unit tests for JSON block definitions (just the start) (#850)
* Beginnings of a JSON block definition unit test set.
 * Dispose of unit test workspaces and blocks in finally blocks.
 * Clarify JSON error message by echoing arg notation.
2017-01-20 14:18:33 -08:00
Sean Lip
fceba91c6c Clean up workspace.component.js. When moving a block from one place to another, move all blocks after it too, and adjust the active descs accordingly. 2017-01-19 17:12:15 -08:00
Rachel Fenichel
1655850d60 Merge pull request #841 from rachel-fenichel/bugfix/long_stop_bind_event
Use bindEvent_ instead of bindEventWithChecks_ for longStop
2017-01-19 10:29:15 -08:00
Rachel Fenichel
7413413069 Use bindEvent_ instead of bindEventWithChecks_ for longStop 2017-01-18 18:14:30 -08:00
Rachel Fenichel
752c35e2e2 Merge pull request #827 from google/excludes
Reduce number of Closure files in App Engine upload.
2017-01-18 17:47:06 -08:00
Sean Lip
59b074d19f Further cleanup and removal of unnecessary functions. Pull some strings out for i18n. 2017-01-18 17:45:15 -08:00
Rachel Fenichel
915f097480 Use setValue in fieldTextInput so that procedure renaming works 2017-01-18 17:08:40 -08:00
Sean Lip
d2bfd134b6 Rewrite tree.service.js.
- Remove unnecessary code and functions.
- Add documentation where needed.
- Fix a bug arising when a block on the workspace is attached to an existing link.
2017-01-18 16:56:16 -08:00
Andrew n marshall
78dc5ed9c2 JSON definitions for colour blocks (#838)
Replaces old colour block definitions with a Blockly.defineBlocksWithJsonArray(..) call. Generator unit tests continue to load and pass, signifying compatibility with prior block definitions.

Replaces extension 'math_number_tooltip' with the reusable 'parent_tooltip_when_inline' extension, also used by colour_picker. Includes tests.
2017-01-18 13:48:46 -08:00
picklesrus
8aa8b1b3ba Add ability to add a class to a scrollbar so that different types of … (#837)
* Add ability to add a class to a scrollbar so that different types of scrollbars can
be distinguished from each other. You used to be able to do this by looking at the parent
element but now all the scrollbars are siblings in the dom.

Also, use this new class to fix #816 so that layering of the flyout and workspace scrollbars
are done correctly.
2017-01-18 13:02:08 -08:00
Andrew n marshall
a47bd93f4c Adding extensions for JSON support of dynamic blocks. (#834)
Adding support for extensions, functions that can assist with loading blocks, much like init functions, but that can be referenced from JSON definitions. This allows JSON definitions to define dynamic blocks such as onchange handlers and mutators.

Rewrote math_number as an example pure JSON block.
2017-01-18 12:45:39 -08:00
Andrew n marshall
bf16f11dbd Replace single quotes with double. (#836)
Fixes commits in #832.
2017-01-18 09:24:29 -08:00
Sean Lip
767ce2ab8e Refactor and simplify field-segment.component.js. 2017-01-17 17:21:32 -08:00
Sean Lip
9d8adaba91 Remove debug info. 2017-01-17 15:53:13 -08:00
Sean Lip
5ed6b7a48d Remove unnecessary check when attaching a new block to a marked connection. 2017-01-17 15:52:04 -08:00
Andrew n marshall
211d973054 FieldNumber & FieldAngle: Default value "0" (#832)
FieldNumber and FieldAngle previously accepted "undefined" as values, if not defined in JSON. This catches these and uses "0" for any NaN value.  The constructor value parameter is now optional. Includes tests.
2017-01-17 15:39:59 -08:00
Sean Lip
08a141aa21 Minor refactoring of the modal code (add comments, guard against invalid keystrokes, etc.). 2017-01-17 15:19:12 -08:00
Sean Lip
4bef8cc329 Rename workspace-tree to workspace-block. 2017-01-17 13:32:33 -08:00
Sean Lip
ed0c9868c6 Fix bug in audioService where attached event callbacks were not being cleared properly. 2017-01-17 11:48:01 -08:00
Neil Fraser
59f408592a Replace 'const' with 'var'.
This unbreaks IE10 and advanced compiled apps such as Blockly Games.
2017-01-16 20:35:28 -08:00
Rachel Fenichel
48df04eb72 Merge pull request #800 from groklearning/add-allInputsFilled-methods
Adds `allInputsFilled` methods to Block and Workspace.
2017-01-16 15:33:21 -08:00
Neil Fraser
90b63f49cb Python false is False. Issue #828. 2017-01-16 09:33:02 -08:00
Neil Fraser
5efc148c4a Reduce number of Closure files in App Engine upload. 2017-01-15 19:52:34 -08:00
Tim Dawborn
69df716ef5 Fixes as per code review on PR. 2017-01-16 08:48:11 +11:00
Andrew n marshall
4fdd16b499 JSON support for message lookup in colour, tooltip, and help URL. (#825)
String replacement for the colour, tooltip text and help URL attributes of JSON defined blocks.
Demonstrated in logic_boolean.
2017-01-13 16:54:27 -08:00
Andrew n marshall
560d373c93 Adding support for untranslated messages. (#819)
This will be used to define constants accessible in JSON block definitions. Messages with descriptions that include `{{Notranslate}}` will not be included in the translation files sent to TranslateWiki. Instead, they are written to `msg/json/constants.json`, and later merged back into the `.js` files, similar to synonyms.

Template details: https://translatewiki.net/wiki/Template:Notranslate
2017-01-13 15:32:00 -08:00
Rachel Fenichel
45be30432a Merge pull request #821 from rachel-fenichel/cleanup/mirror_naming
Naming changes in mirror demo
2017-01-12 16:35:16 -08:00
Rachel Fenichel
2867a3a85d Naming changes in mirror demo 2017-01-12 16:27:37 -08:00
Andrew n marshall
98dc0ed344 Integrating qqq.json changes into messages.json. (#820)
From commits b77f8cbebc and 4ecdedec9f
2017-01-12 15:31:11 -08:00
Andrew n marshall
ac3df2759c PR #818: Adding support for string table lookups in dropdown field labels
Adding support for string table lookups in dropdown field labels specified in JSON.

Adds Blockly.utils.replaceMessageReferences() method to handle string replacement without interpolation tokens.  Effectively uses the same old code, now moved into tokenizeInterpolation_(), which takes a parseInterpolationTokens option.

Replaces the direct JavaScript references (not pure JSON, and thus not portable).

Demonstrating this behavior in the logic_boolean dropdown.
2017-01-11 15:47:56 -08:00
Rachel Fenichel
35d83a576f Merge pull request #814 from justingeeslin/use-closure-compiler-npm-module
Use the npm closure library
2017-01-11 11:31:43 -08:00
Neil Fraser
bea74dbbe3 Fix undo/redo for FieldCheckbox
Thanks to PR #813 by ademenev
2017-01-10 22:18:37 -08:00