Commit Graph

1737 Commits

Author SHA1 Message Date
Andrew n marshall
15827c5d30 Adds Block.prototype.mixin() and Blockly.Extensions.registerMixin(). (#907)
Adds Block.prototype.mixin() and Blockly.Extensions.registerMixin().
This adds support for a common use pattern in extensions, and adds
error checking to avoid future incompatibilities.
2017-02-06 10:00:08 -08:00
Jim Mussared
ec878b02cd Correct changedState in setWarningText() (#908)
When clearing warnings on blocks with IDs, the changedState variable should be true if the text changed. This will trigger the block being reshaped and remove the space for the notification icon (this.bumpNeighbours_).
2017-02-06 08:41:17 -08:00
CoryDCode
1a1646a5c4 Pinning the angular2 dependency, and including licenses. (#893) 2017-02-02 13:29:02 -08:00
Rachel Fenichel
cab3afd677 Merge pull request #894 from google/seanlip-block-descriptions
Use the empty field placeholder for dropdowns that do not have a value selected.
2017-02-02 11:53:33 -08:00
Benjie Gillam
7d8fa7327c Fix typo causing TypeError (#901) 2017-02-01 09:13:03 -08:00
Andrew n marshall
e95991cba8 Adding @namespace annotations for JSDoc. (#900) 2017-02-01 09:10:35 -08:00
Tim Dawborn
89ee9809d9 Bugfix for #892. I incorrectly converted one CSS transform setting to use the cross-browser setting function in 40a063763c. (#895) 2017-01-31 08:58:03 -08:00
Sean Lip
2c72590a01 Use the empty field placeholder for dropdowns that do not have a value selected. 2017-01-30 16:23:40 -08:00
Sean Lip
ff578359a6 Deleting a top-level block does not cause blocks after it to be deleted. Properly handle the active desc for this case. 2017-01-27 20:27:58 -08:00
Sean Lip
bf3b5f9d0d Fix a bug where splicing a block between two linked blocks disconnects the group and messes up the focus. 2017-01-27 18:33:39 -08:00
Sean Lip
42ce2f6856 Clear all active desc ids when the 'Erase Workspace' button is pressed. 2017-01-27 15:38:49 -08:00
Rachel Fenichel
fe92d75793 Merge pull request #885 from rachel-fenichel/bugfix/context_menu_placement
Place context menu correctly on touch
2017-01-27 14:08:36 -08:00
Rachel Fenichel
3722c7d329 Place context menu correctly on touch 2017-01-27 14:03:20 -08:00
Rachel Fenichel
37906a1099 Merge pull request #882 from rachel-fenichel/bugfix/set_check_headless
Stop bumping neighbours in headless blockly
2017-01-27 13:06:46 -08:00
Rachel Fenichel
3e04dea9c9 Merge pull request #881 from rachel-fenichel/bugfix/events_rendered
Don't try to get block position in a headless workspace
2017-01-27 13:06:35 -08:00
Rachel Fenichel
2474ec53ab Stop bumping neighbours in headless blockly 2017-01-27 11:33:04 -08:00
Rachel Fenichel
6bae750b10 Don't try to get block position in a headless workspace 2017-01-27 10:41:40 -08:00
Rachel Fenichel
b530f73747 Merge pull request #878 from groklearning/fix-ie-edge-block-text-width
Work around the IE/Edge `getComputedTextLength()` block sizing bug
2017-01-27 09:39:29 -08:00
CoryDCode
c1c5d8f5a7 Merge pull request #852 from CoryDCode/cd-combo-focus-fix
Fixing combo boxes getting out-of-sync with NVDA.
2017-01-27 09:39:04 -08:00
Tim Dawborn
39731c6ddc Change CSS transforms to work with older browsers (#879)
* Change the setting of the CSS transform properties on SVG nodes to set both the unprefixed version and the `-webkit-` prefixed version so that Blockly correctly renders in order browsers, such as Safari < 9 and iOS Safari < 9.2. For discussion of this issue, see https://groups.google.com/forum/#!topic/blockly/o3pERaRQhSg

* Correct the separation between the CSS transform property and the rest of the CSS that was in the variable misleadingly called "transform".
2017-01-27 09:19:58 -08:00
Rachel Fenichel
20d0730558 Merge pull request #877 from groklearning/bugfix-876
Remove IE/Edge-breaking use of Array.prototype.includes
2017-01-26 22:11:26 -08:00
Tim Dawborn
d55d9cbd9f Attempt to work around the IE/Edge bug where getComputedTextLength() throws an exception when the SVG node is not visible. This workaround forces a re-render, which in turn, forces a re-calculation of the node width once a block is inserted into the workspace SVG. This workaround is only executed on IE and Edge. See https://groups.google.com/forum/#!topic/blockly/T8IR4t4xAIY for the initial discussion of this issue. 2017-01-27 15:15:09 +11:00
Tim Dawborn
14ee069543 Remove use of Array.prototype.includes which is not implemented in IE or Edge < 14. Fixes google/blockly#876. 2017-01-27 13:51:18 +11:00
Andrew n marshall
10108cc697 jsdoc corrections (#874) 2017-01-26 17:33:55 -08:00
Rachel Fenichel
3742788557 annotation updates 2017-01-26 16:37:35 -08:00
Rachel Fenichel
30a63e31dd Merge pull request #863 from rachel-fenichel/feature/custom_category
Enable custom flyout categories.
2017-01-26 15:43:47 -08:00
Andrew n marshall
624afeee94 Blockly.Extensions.buildTooltipForDropdown(..): Deferred validation. (#870)
Defer tooltip message string check until after load, when all Blockly.Msg should be loaded.
Avoids validation in headless mode, due to lack of document.readyState.
2017-01-26 15:12:32 -08:00
Andrew n marshall
5891288d60 .getOptions_() to .getOptions() (#869)
Fixes #867.
2017-01-26 09:52:00 -08:00
Tim Dawborn
e16058e95a Update the set of reserved words in Python to reflect the current state of Python (2.7 and 3.6). (#861) 2017-01-25 15:02:49 -08:00
Rachel Fenichel
0062658cfa Add some safety 2017-01-25 14:49:46 -08:00
Rachel Fenichel
4872a6ad7f Enable custom flyout categories. 2017-01-23 17:21:48 -08:00
Rachel Fenichel
a0b5aeb8d9 Merge pull request #862 from AnmAtAnm/math-blocks
Correcting math_change color
2017-01-23 17:05:24 -08:00
Andrew n marshall
709295a689 Correcting math_change color 2017-01-23 17:03:05 -08:00
Rachel Fenichel
9f564fba35 Merge pull request #859 from google/feature/readme_forum_ref
Update README.md
2017-01-23 15:27:33 -08:00
Rachel Fenichel
b8a465e739 Update README.md
Add a link to our forum.
2017-01-23 15:23:05 -08:00
Andrew n marshall
0da5dda1f0 Fixing JSON support for images in dropdowns. Adding tests. (#851)
Fixes #848.
2017-01-23 13:39:14 -08:00
Andrew n marshall
7b0275cd70 Porting math.js blocks to JSON (#846)
Moving all `math.js` definitions into a single JSON array, complete with i18n syntax for all messages, dropdowns, and tooltips.

Adding Blockly.Extensions.buildTooltipForDropdown(..) to facilitate the creation and error-checking of tooltips that update based on the value of a dropdown.

Now warn on raw string in JSON 'extensions'.
2017-01-23 10:23:55 -08:00
Tim Dawborn
46316c7cea Add a block to reverse a list (#844) 2017-01-21 10:48:42 -08:00
Rachel Fenichel
f6168e1364 Merge pull request #840 from rachel-fenichel/bugfix/procedure_rename
Use setValue in fieldTextInput so that procedure renaming works
2017-01-20 22:04:16 -08:00
CoryDCode
ed0bec07a2 Fixing combo boxes getting out-of-sync with NVDA.
Combo boxes need to be special cased like text input. Also, Escape is
a reserved button in NVDA, so I added Enter as a way to "submit and
move up a level" in addition to escape, so these boxes can be edited
while NVDA is on.
2017-01-20 16:16:51 -08:00
Tim Dawborn
34750bccd8 New blocks text_count, text_replace, and text_reverse (#830)
Includes generators for all languages and units tests on those generators.
2017-01-20 16:08:27 -08:00
Andrew n marshall
fb0f1b05dd Unit tests for JSON block definitions (just the start) (#850)
* Beginnings of a JSON block definition unit test set.
 * Dispose of unit test workspaces and blocks in finally blocks.
 * Clarify JSON error message by echoing arg notation.
2017-01-20 14:18:33 -08:00
Sean Lip
fceba91c6c Clean up workspace.component.js. When moving a block from one place to another, move all blocks after it too, and adjust the active descs accordingly. 2017-01-19 17:12:15 -08:00
Rachel Fenichel
1655850d60 Merge pull request #841 from rachel-fenichel/bugfix/long_stop_bind_event
Use bindEvent_ instead of bindEventWithChecks_ for longStop
2017-01-19 10:29:15 -08:00
Rachel Fenichel
7413413069 Use bindEvent_ instead of bindEventWithChecks_ for longStop 2017-01-18 18:14:30 -08:00
Rachel Fenichel
752c35e2e2 Merge pull request #827 from google/excludes
Reduce number of Closure files in App Engine upload.
2017-01-18 17:47:06 -08:00
Sean Lip
59b074d19f Further cleanup and removal of unnecessary functions. Pull some strings out for i18n. 2017-01-18 17:45:15 -08:00
Rachel Fenichel
915f097480 Use setValue in fieldTextInput so that procedure renaming works 2017-01-18 17:08:40 -08:00
Sean Lip
d2bfd134b6 Rewrite tree.service.js.
- Remove unnecessary code and functions.
- Add documentation where needed.
- Fix a bug arising when a block on the workspace is attached to an existing link.
2017-01-18 16:56:16 -08:00
Andrew n marshall
78dc5ed9c2 JSON definitions for colour blocks (#838)
Replaces old colour block definitions with a Blockly.defineBlocksWithJsonArray(..) call. Generator unit tests continue to load and pass, signifying compatibility with prior block definitions.

Replaces extension 'math_number_tooltip' with the reusable 'parent_tooltip_when_inline' extension, also used by colour_picker. Includes tests.
2017-01-18 13:48:46 -08:00