Rachel Fenichel
450aed0aa2
More work on connection type checks
2020-07-16 17:40:12 -06:00
Rachel Fenichel
c743a92bb9
Start work on connection type checker
2020-07-16 17:40:12 -06:00
Sam El-Husseini
0f3db47fa5
Use generics to derive SVG element type ( #4036 )
...
* Encapsulate type in a generic to automatically derive type of SVG element when using createSvgElement
2020-07-13 10:40:31 -07:00
Sam El-Husseini
317834ff59
Add accessibility interfaces and fix navigation types ( #3908 )
...
* Add accessibility interfaces and fix navigation types
2020-05-21 11:18:10 -07:00
Beka Westberg
9e98df9949
Fix collapsed blocks not updating when modified ( #3806 )
...
* Stop recursive render calls
* Fix visibility bugs.
* Make toString ignore collapsed input.
* Add automatic collapse rendering handling
* Fix insertion markers with collapsed
* Add tests
* Fix build?
* PR comments
* Add missing jsdoc
2020-04-16 13:02:05 -07:00
Neil Fraser
4e2f8e6e02
Use SPDX licences.
...
This is a followup to #3127 .
At the time, SPDX licenses were pending approval by Google.
2020-02-11 13:27:20 -08:00
Monica Kozbial
9b8fa7a177
Using shapeFor for notch and tab paths. ( #3572 )
2020-01-10 13:31:49 -08:00
Neil Fraser
123f436e04
Add parens around inline assignments ( #3381 )
2019-10-31 15:17:35 -07:00
Beka Westberg
c32c835088
Fixed programmatically added connections not being added to the connection db ( #3318 )
...
* Fixed programmatically added connections not getting added to the connection db.
2019-10-29 15:31:40 -07:00
Sam El-Husseini
52bef4463c
Fix warnings related to connections. ( #3306 )
...
* Fix warnings related to connections.
2019-10-23 17:56:52 -04:00
Sam El-Husseini
91717854c0
Fix warnings related to insertion markers. ( #3309 )
2019-10-22 14:20:42 -04:00
Rachel Fenichel
b9dd13cde0
Fix #3169 ( #3199 )
2019-10-08 17:29:53 -07:00
Rachel Fenichel
608ce7b93c
Merge pull request #3133 from BeksOmega/fixes/ConnectionTracking
...
Connection Tracking Pt 3: Changed connections to use 'tracked_' property
2019-10-07 11:05:10 -07:00
Sam El-Husseini
d0772ad496
Fix compiler warnings related to fields. ( #3144 )
...
* Fix compiler warnings related to fields.
2019-10-03 15:58:46 -07:00
Neil Fraser
b46a4fe286
Bring our license format up to date ( #3127 )
...
* Google changed from an Inc to an LLC.
This happened back in 2017 but we didn’t notice. Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.
* Remove project description/titles from licenses
This is no longer part of Google’s header requirements. Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).
* License no longer requires URL.
* Fix license regexps.
2019-10-02 14:46:56 -07:00
Beka Westberg
df5b5766c1
General cleanup.
2019-10-01 19:22:19 -07:00
Beka Westberg
5aaab251a3
Changed all other known 'hiding' references to 'tracking'.
2019-10-01 19:02:02 -07:00
Beka Westberg
9d47e2b34e
Fixed adding and removing from connection DB (will be cleaned up a future PR, but I want to focus on cleaning connections).
2019-10-01 16:58:33 -07:00
Beka Westberg
d4e0594c2c
Combined inDB_ and hidden_ into single tracked_ property.
2019-10-01 16:55:29 -07:00
Beka Westberg
229dd69e54
Fixed review comments.
2019-09-30 15:32:17 -07:00
Beka Westberg
afbb2cca1e
Moved all database related code out of headless and into rendered.
2019-09-27 18:00:06 -07:00
Monica Kozbial
e1e9513e86
Disconnect child block always for block.dispose(/* healStack */ true) ( #3073 )
...
* Disconnecting child block even if it cannot be connected to parent block.
* Bump disconnected child block.
* Added method for behavior on failed connection and updated expected behavior of unplug in unit tests.
* Removing obsolete TODO and calling new helper method in tests.
2019-09-25 10:47:29 -07:00
Sam El-Husseini
e339ae26bc
Move the rendering object to live on the workspace_svg ( #3016 )
...
* Move the rendering object onto the workspace allowing the various workspaces to have different renderers.
2019-09-13 14:20:34 -07:00
Sam El-Husseini
8ab51c8639
Remove closure base file dependency ( #2976 )
...
* Trim down closure's base dependency even further by removing the dependency on closure's base file.
2019-09-11 17:30:51 -07:00
Rachel Fenichel
2ffe71f0a0
Remove references to dark path offset; fix highlights while dragging'
2019-09-05 11:59:28 -07:00
Rachel Fenichel
37250f4ce4
Fix connection highlight rendering
2019-07-31 12:42:34 -07:00
Sam El-Husseini
c1b49a1da7
Fix some jsdoc types ( #2701 )
...
* Fix JSDoc regarding type inconsistencies. Make image field src required and update image field tests.
2019-07-25 12:24:36 -07:00
Abby
3dd1973a5a
Ran the rename script
2019-07-24 13:48:25 -07:00
Abby
1c26b6d79b
Adds helper functions for keyboard nav
2019-07-24 11:42:37 -07:00
Erik Pasternak
5911e54dc0
Revert "Propagate the visible state when blocks connect ( #2003 )"
...
This reverts commit ec78eeb39b .
2019-07-19 16:03:40 -07:00
Erik Pasternak
73f13b7d9c
Revert "Properly set the display style on blocks when connections are unhidden"
...
This reverts commit bacfae24dd .
2019-07-19 15:56:23 -07:00
Erik Pasternak
1af59813d9
Revert "Fix wrong method call"
...
This reverts commit 3adc554f6b .
2019-07-19 15:56:06 -07:00
Erik Pasternak
3adc554f6b
Fix wrong method call
2019-07-18 14:19:22 -07:00
Erik Pasternak
bacfae24dd
Properly set the display style on blocks when connections are unhidden
...
We weren't always setting the display style on blocks when the hidden
state changed on a connection. This meant that sometimes unhiding a
connection would cause the attached block to be invisible.
This moves the display style code into the setHidden so it is never
skipped.
2019-07-18 14:08:53 -07:00
Neil Fraser
848d3a3509
Move setCssTransform & createSvgElement to dom.
...
Also move SVG_NS and HTML_NS properties.
2019-06-07 10:32:57 -07:00
Neil Fraser
d1a29739d8
Move utilities into own directory.
...
TODO: There are more functions which may be migrated into dom and string.
2019-06-07 10:32:57 -07:00
Neil Fraser
5bf7069a2f
Remove goog.math.Coordinate
2019-06-07 10:32:57 -07:00
Neil Fraser
9f528922a7
Fix some dependencies
2019-05-24 15:45:05 -07:00
RoboErikG
ec78eeb39b
Propagate the visible state when blocks connect ( #2003 )
...
* Propagate the visible state when blocks connect
This fixes #1967 .
In rendered connections when connecting:
- If the superior connection is hidden this hides the newly connected block.
- If the superior connection isn't hidden it makes sure the block is visible.
In rendered connections when disconnecting:
- If the superior connection is hidden, make the disconnected block stack visible.
TODO before review:
- write tests.
- update collapsed message
* Add missing overrides
* Add tests for hidden connections and fix a bug while disposing
2019-04-15 16:23:19 -07:00
alschmiedt
a759fffcc1
Fixes bumping too much when in RTL
2019-04-04 15:54:17 -07:00
Beka Westberg
1b2ec7230c
Added randomness to bumping per Issue #2011
2018-12-02 12:34:34 -08:00
Andrew n marshall
411ec9724e
Replacing node.parentNode.removeChild(node)
...
...with Blockly.utils.removeNode(..), which includes
a null/undefined check on parentNode before continuing.
2018-09-04 13:31:53 -07:00
Neil Fraser
c51cf0b79c
Remove goog.dom.removeNode
2018-07-11 12:20:02 -07:00
Neil Fraser
51e86263c7
Correct requires for goog.math.*
2018-07-11 12:20:02 -07:00
Neil Fraser
0583bee502
Correct requires for goog.dom
2018-07-11 12:20:02 -07:00
Neil Fraser
284b79407e
Require Blockly.utils where needed.
2018-07-11 12:20:02 -07:00
Neil Fraser
3909bd420a
Remove all goog.asserts and goog.isXxx
...
First step to reducing Closure’s footprint.
2018-07-11 12:20:02 -07:00
Rachel Fenichel
14e846f2b7
Fix 1380
2018-05-17 16:19:44 -07:00
Neil Fraser
662d79443f
Add 'ordered' option to descendant getting functions. ( #1786 )
2018-04-17 11:41:03 -07:00
Rachel Fenichel
2b7b4bf3af
More lint
2018-01-24 16:40:07 -08:00