Commit Graph

3871 Commits

Author SHA1 Message Date
kozbial
95163f30de Minor refactor in alignRowElements currentWidth and desiredWidth computation. 2019-08-13 17:15:50 -07:00
Sam El-Husseini
a41a3c5f33 Add keycode utils to reference keycodes via an enum (#2814) 2019-08-13 16:25:26 -07:00
Rachel Fenichel
39b3717b2c Include next connection in block's bounding box 2019-08-13 15:23:27 -07:00
Rachel Fenichel
1ef4a1343b Merge pull request #2817 from rachel-fenichel/baby_steps
Replace path array with path string
2019-08-13 15:18:29 -07:00
Rachel Fenichel
f449c8bb3c Remove commented out code 2019-08-13 14:32:03 -07:00
Rachel Fenichel
4f487c65f0 Fix hat 2019-08-13 14:26:22 -07:00
Sam El-Husseini
109e32b866 Revert "Add extra style methods used by closure components"
This reverts commit cb461b2c94.
2019-08-13 14:19:25 -07:00
Sam El-Husseini
cb461b2c94 Add extra style methods used by closure components 2019-08-13 14:18:40 -07:00
Rachel Fenichel
6b440cc5e0 Replace path array with path string 2019-08-13 14:17:51 -07:00
alschmiedt
00be6a6381 Make the navigation namespace lowercase (#2812) 2019-08-13 14:00:49 -07:00
alschmiedt
74fa3bb71a Initial commit for changing key mappings (#2787)
* Added ability to easily change key mappings
2019-08-13 13:37:01 -07:00
kozbial
99c970bcf5 Adding missing padding to statement input rows. 2019-08-13 13:32:03 -07:00
Rachel Fenichel
71e720444f Use connection width to find empty input width 2019-08-13 10:16:29 -07:00
Rachel Fenichel
d954182c41 Fix width with children for external inputs 2019-08-13 10:16:29 -07:00
Rachel Fenichel
ede7c7e125 Include tab width in block width 2019-08-13 10:16:29 -07:00
Rachel Fenichel
5b955f6bbe Add xpos to rows; add bounding box debug rendering 2019-08-13 10:16:29 -07:00
Rachel Fenichel
6e825c33a0 Centralize references to some shapes. 2019-08-13 10:16:29 -07:00
Rachel Fenichel
797b8dae46 Include tab width in block width 2019-08-13 10:14:33 -07:00
Rachel Fenichel
ace1971795 Make hats have height! 2019-08-13 10:14:33 -07:00
Rachel Fenichel
eb19ea970a Hats 2019-08-13 10:14:33 -07:00
Rachel Fenichel
caec821fec Cleanup 2019-08-13 10:14:33 -07:00
Rachel Fenichel
67d6a2f4f8 Cleanup 2019-08-13 10:14:33 -07:00
Rachel Fenichel
c901b20486 Handle negative x and y origin 2019-08-13 10:14:33 -07:00
Rachel Fenichel
74238d6e24 Works for positive x and y offsets; fails for negative 2019-08-13 10:14:33 -07:00
Rachel Fenichel
da391da005 Improvements for y offsets 2019-08-13 10:14:33 -07:00
Rachel Fenichel
7ecb841d8c Merge pull request #2804 from rachel-fenichel/variables_not_constants
Centralize references to puzzle tab and notch in measurables.js
2019-08-13 09:47:10 -07:00
Rachel Fenichel
61d03ba249 Add debug rendering that shows the bounding box of the block 2019-08-12 16:09:19 -07:00
Rachel Fenichel
23bddeaaa9 Centralize references to puzzle tab and notch in measurables.js 2019-08-12 16:03:42 -07:00
Sam El-Husseini
70ab436876 Math.sign -> Math.sin (#2802)
There was a typo at some point.
2019-08-12 12:40:16 -07:00
Beka Westberg
37efbd0559 Fixed jitter when bumping blocks if objects were too large for the workspace. (#2778) 2019-08-12 09:11:27 -07:00
Beka Westberg
d6ebbc9698 Removed deprecated callValidator call. 2019-08-09 09:08:28 -07:00
Sam El-Husseini
6425287daa Support getting sizes of elements that are not visible (#2786)
* Support getting sizes of elements that are not visible
2019-08-08 21:09:15 -07:00
Monica Kozbial
f2562c80d8 Merge pull request #2784 from moniika/moniika-rtl-image-flip
Adding logic to flip FieldImages in RTL with flipRtl flag set.
2019-08-07 13:15:16 -07:00
kozbial
a47177af28 fixing spacing 2019-08-07 12:24:09 -07:00
kozbial
11813c706c Remove flipRtl path for icon. 2019-08-07 12:20:15 -07:00
Sam El-Husseini
36135ac62b Fix RTL text field positioning bug by ensuring a reflow (#2779) 2019-08-07 10:54:36 -07:00
Sam El-Husseini
5ada490eca Cherry pick npm distribution change to develop (#2785) 2019-08-07 10:53:53 -07:00
Beka Westberg
654467e9ac Added disposed = false properties to fields, connections, and blocks. Changed applicable unit tests from isNotOk -> isFalse. 2019-08-07 07:17:41 -07:00
Beka Westberg
6f03634730 Moved disposed into finally block. 2019-08-07 07:11:17 -07:00
Beka Westberg
057cee51f8 Added disposed property to blocks (for use in unit tests). 2019-08-07 07:07:30 -07:00
Beka Westberg
a4b4f09071 Fixed connection dispose jsdoc. 2019-08-07 07:07:30 -07:00
Beka Westberg
8921fa96a9 Removed redundant connection disposal code from block. 2019-08-07 07:07:30 -07:00
Beka Westberg
49405a88bd Changed connections to handle disposing of connected blocks. 2019-08-07 07:07:29 -07:00
Sam El-Husseini
f34f2beac7 Remove all calls to goog.style (#2781)
* Remove dependency on goog.style
2019-08-06 14:54:13 -07:00
kozbial
d4b12343d6 Adding logic to flip FieldImages in RTL with flipRtl flag set. 2019-08-06 14:43:18 -07:00
Rachel Fenichel
5deedc8f53 Merge pull request #2783 from rachel-fenichel/field_corrected_size
Remove getCorrectedSize for fields
2019-08-06 13:45:44 -07:00
Rachel Fenichel
40ba284c3f Change constant 2019-08-06 13:40:06 -07:00
RoboErikG
dac4ae2e78 Don't try to zoom flyouts and mutators (#2772)
* Don't try to zoom flyouts and mutators

Fixes #2752

Flyouts and mutator workspaces don't have enough info to handle
zooming correctly, so they were throwing errors if you pinched them.
This adds a check to quit a zoom early if in either of those. We
might want to revisit later if we should support zooming on them.

* Add TODO
2019-08-06 13:05:01 -07:00
Rachel Fenichel
ed245a3c9e Remove dealWithOffsetFields 2019-08-06 11:44:03 -07:00
Rachel Fenichel
c6463acc70 Cleanup and comments 2019-08-06 11:03:53 -07:00