Commit Graph

2805 Commits

Author SHA1 Message Date
Gokula Krishna 2c3ef64609 Remove varId attribute while saving 2018-07-24 17:29:35 +08:00
Gokula Krishna 97d3956c43 Prioritize current key var-id 2018-07-24 13:31:04 +08:00
Gokula Krishna 6275c6eef7 Change XML attribute for procedure from varId to var-id 2018-07-24 11:12:17 +08:00
RoboErikG 61803167d8 Add test for deleting a rendered block with a comment (#1984)
Disabled for now as it fails due to #1960.
2018-07-23 10:56:37 -07:00
translatewiki.net eca22c9bd2 Localisation updates from https://translatewiki.net. 2018-07-23 09:31:27 +02:00
Andrew n marshall f42291ea64 Do not escape % in python strings. (#1982)
Rebase of PR-1890, commit 793055… from Ellipsis753:patch-1
2018-07-20 15:54:11 -07:00
translatewiki.net 49955bd984 Localisation updates from https://translatewiki.net. 2018-07-20 14:59:28 +02:00
RoboErikG c815608fdf Fix failing svg canvas test (#1977)
Partial fix for #1976. This fixes the broken test by initializing the
svg for blocks when they're created.
2018-07-17 09:35:53 -07:00
Andrew n marshall 4860e34f51 Removing goog.* uses from blocks/*.js files (#1975)
* Removing goog.arrays.equals() in blocks/procedures.js, with minor refactor.
* Replacing goog.dom.createDom() in blocks/procedures.js, blocks/variables.js,  blocks/variables_dynamic.js, and blocks/loops.js.
2018-07-16 17:01:12 -07:00
Neil Fraser c8bfc888c8 Throw errors instead of strings. (#1974)
Blocks and generators
2018-07-16 16:33:44 -07:00
RoboErikG 99ebefa1bf Revert "Fix #1960 by collecting block info before icons are destroyed" (#1973)
* Revert "Localisation updates from https://translatewiki.net."

This reverts commit c4a0b64945.

* Revert "Fix #1960 by collecting block info before icons are destroyed (#1970)"

This reverts commit 9a3bd45b22.
2018-07-16 10:18:40 -07:00
translatewiki.net c4a0b64945 Localisation updates from https://translatewiki.net. 2018-07-16 16:49:05 +02:00
RoboErikG 9a3bd45b22 Fix #1960 by collecting block info before icons are destroyed (#1970)
The icons in rendered Blockly currently own the comment text. When
a block was deleted the icons were being disposed of before the block
info was recorded in the event, which meant the comment was lost. This
adds some additional logic to block_svg to make sure the event is
captured before the icons are removed.
2018-07-12 15:34:32 -07:00
Neil Fraser ac2fa96d7f Replace goog.dom.createDom for creating HTML 2018-07-11 12:20:02 -07:00
Neil Fraser dce60fd152 Replace ReferenceError with Error.
Change to 4-space indentation rather than aligning with parent structure.
2018-07-11 12:20:02 -07:00
Neil Fraser c51cf0b79c Remove goog.dom.removeNode 2018-07-11 12:20:02 -07:00
Neil Fraser f802859547 Remove goog.dom.removeChildren
HTML can be nullified with innerHTML, SVG needs a loop.
2018-07-11 12:20:02 -07:00
Neil Fraser c8e08109f2 Correct requires for goog.style 2018-07-11 12:20:02 -07:00
Neil Fraser 51e86263c7 Correct requires for goog.math.* 2018-07-11 12:20:02 -07:00
Neil Fraser 0583bee502 Correct requires for goog.dom 2018-07-11 12:20:02 -07:00
Neil Fraser 8f7674ea08 Correct requires for goog.events 2018-07-11 12:20:02 -07:00
Neil Fraser 67a18036d0 Fix Travis errors 2018-07-11 12:20:02 -07:00
Neil Fraser 07d1d86283 Remove remaining goog.math 2018-07-11 12:20:02 -07:00
Neil Fraser 284b79407e Require Blockly.utils where needed. 2018-07-11 12:20:02 -07:00
Neil Fraser 60cce6cd0c Remove goog.math angle functions. 2018-07-11 12:20:02 -07:00
Neil Fraser eea2794e38 Remove goog.dom.TagName 2018-07-11 12:20:02 -07:00
Neil Fraser 06d90c9b34 Remove goog.array 2018-07-11 12:20:02 -07:00
Neil Fraser 03bf9f5e71 Remove goog.string 2018-07-11 12:20:02 -07:00
Neil Fraser 3909bd420a Remove all goog.asserts and goog.isXxx
First step to reducing Closure’s footprint.
2018-07-11 12:20:02 -07:00
Andrew n marshall 02dc7b1d1d Fixing JSDoc for the return type of Blockly.WorkspaceComment.parseAttributes (#1966) 2018-07-03 12:07:25 -07:00
Andrew n marshall cf3f914be8 Moving TODOs out of jsdoc comments. (#1965) 2018-07-03 11:42:40 -07:00
Andrew n marshall ec4963f4b4 Merge pull request #1961 from rachel-fenichel/master_to_develop_june
Master->develop
2018-07-02 12:35:00 -07:00
Andrew n marshall 1bd135c9a5 Updating NPM package version to 1.20180629.0-develop (#1962) 2018-07-02 12:34:03 -07:00
Neil Fraser 13f7e75ffb Supress empty <variables> tag in XML. 2018-06-29 17:52:26 -07:00
Rachel Fenichel a89b541de6 Merge branch 'master' into master_to_develop_june 2018-06-29 16:45:05 -07:00
Rachel Fenichel b88a3bf41a Merge pull request #1944 from google/rc/june_2018
June 2018 release
2018-06-29 16:30:51 -07:00
Rachel Fenichel a4b2a990d5 Merge pull request #1957 from rachel-fenichel/bugfix/generator_test_loadall
Remove variable IDs from colour test XML
2018-06-29 11:00:58 -07:00
Rachel Fenichel 999f8a114d Remove variable IDs from colour test XML 2018-06-29 10:47:03 -07:00
translatewiki.net b4e5463195 Localisation updates from https://translatewiki.net. 2018-06-28 07:18:22 +02:00
Rachel Fenichel b141dbd3f5 Merge pull request #1950 from rachel-fenichel/bugfix/adjusted_colours
Fix colour generator tests
2018-06-27 14:48:31 -07:00
Rachel Fenichel 28eb831754 Better error messages in colour generator tests 2018-06-27 14:41:53 -07:00
Rachel Fenichel 83855248a6 Correctly adjust indices in colour tests 2018-06-27 14:32:40 -07:00
Andrew n marshall eafc3cd099 Adding appropriate test values to number field test blocks (#1943) 2018-06-26 18:19:01 -07:00
Rachel Fenichel d4a4b79dd5 Merge pull request #1940 from rachel-fenichel/master_to_develop_again
Merge master to develop to make git history happy
2018-06-26 13:36:37 -07:00
Rachel Fenichel 3d7a0eb7e1 Merge branch 'master' into master_to_develop_again 2018-06-26 13:30:14 -07:00
Rachel Fenichel 29d804de34 Merge pull request #1937 from rachel-fenichel/rebuild
Rebuild on develop before cutting a release
2018-06-26 12:53:50 -07:00
Rachel Fenichel 5ffa9122c8 Rebuild 2018-06-26 12:48:24 -07:00
Andrew n marshall 51253f9787 Updating npm dependencies. (#1936) 2018-06-26 12:32:49 -07:00
Andrew n marshall 02ea01c234 Revert changes to i18n/js_to_json.py from 4cb4b42 (#1935) 2018-06-25 17:34:55 -07:00
Rachel Fenichel d92e464c20 Merge pull request #1933 from AnmAtAnm/fix-blockfactory-define-code
Revert breaking changes to BlockFactory
2018-06-25 18:47:13 -04:00